rx_buffer_info should be refill not linearly, but out of order.
IDs should be taken from empty_rx_reqs array.
rx_refill_buffer is introduced to temporary storage
bulk of mbufs taken from pool.
In case of error unused mbufs are put back to pool.
Fixes: c2034976673d ("net/ena: add Rx out of order
Acked-by: Hemant Agrawal
Hello,
I experienced a problem with the MLX5 driver running a code that is working
fine with an Intel card. I have found that the reason of this error is an
overflow of the uint16_t number of descriptors in the mlx driver.
Here the details:
- The NIC is a Mellanox ConnectX-5 100G.
- This is a s
18.11-rc4 verification done on NXP SoCs with integrated NICs.
Signed-off-by: Shreyansh Jain
---
doc/guides/rel_notes/release_18_11.rst | 12
1 file changed, 12 insertions(+)
diff --git a/doc/guides/rel_notes/release_18_11.rst
b/doc/guides/rel_notes/release_18_11.rst
index 32ff0e5c
On 14/11/2018 15:36, Jasvinder Singh wrote:
There will be change in API functions because of mbuf sched field
updates, outlined in deprecation note of mbuf->hash.sched.
Signed-off-by: Jasvinder Singh
Acked-by: Cristian Dumitrescu
---
doc/guides/rel_notes/deprecation.rst | 5 +
1 file
From: Nikhil Rao
In the eth Rx adapter SW service function,
move the return to after the spinlock unlock.
Coverity issue: 302857
Fixes: a66a83744667 ("eventdev: fix Rx SW adapter stop")
CC: sta...@dpdk.org
Signed-off-by: Nikhil Rao
---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
1 f
There is not need for these useless information and
it had better be removed in oder not to confusing users.
Signed-off-by: Wei Zhao
---
examples/ipv4_multicast/main.c | 8
1 file changed, 8 deletions(-)
diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c
index
Add the background for this patch
https://mails.dpdk.org/archives/dev/2018-November/119391.html
> -Original Message-
> From: Zhao1, Wei
> Sent: Wednesday, November 21, 2018 5:49 PM
> To: dev@dpdk.org
> Cc: sta...@dpdk.org; Ananyev, Konstantin ;
> Zhao1, Wei
> Subject: [PATCH] examples/i
v1: change the max core setting to 256 for arm64 platform
Joyce Kong (2):
config: enable more than 128 cores for Arm platform
config: enable more than 128 cores for meson build
config/arm/meson.build | 2 +-
config/defconfig_arm64-armv8a-linuxapp-gcc | 1 +
2 files change
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm platform.
Fixes: b
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on thundex platform
for me
Hi,
21/11/2018 12:10, Joyce Kong:
> v1: change the max core setting to 256 for arm64 platform
>
> Joyce Kong (2):
> config: enable more than 128 cores for Arm platform
> config: enable more than 128 cores for meson build
2 comments:
- It doesn't need to be split in 2 commits.
- Are you sure
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm64 platform.
Fixes:
The VLAN push action on E-Switch supports only 802.1Q (0x8100)
and 802.1AD (0x88A8) Tag Protocol ID (TPID) insertions. The
parameter check for RTE_FLOW_ACTION_TYPE_OF_PUSH_VLAN action
is added.
Fixes: 57123c00c1b8 ("net/mlx5: add Linux TC flower driver for E-Switch flow")
Signed-off-by: Viachesla
-Original Message-
> Date: Wed, 21 Nov 2018 19:27:12 +0800
> From: Joyce Kong
> To: dev@dpdk.org
> CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com,
> honnappa.nagaraha...@arm.com, gavin...@arm.com, sta...@dpdk.org
> Subject: [PATCH v2] config: enable more than 128 cores for Arm64
On 11/21/2018 7:48 AM, Hideyuki Yamashita wrote:
> Hello,
>
> I have some basic questions about telemetry API
> which is planned to be relaesed in 18.11.
>
> Note that I have read the follwoing document.
> https://doc.dpdk.org/guides/howto/telemetry.html
>
> Q1. In general dpdk application use p
> -Original Message-
> From: Thomas Monjalon
> Sent: Wednesday, November 21, 2018 7:14 PM
> To: Joyce Kong (Arm Technology China)
> Cc: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Honnappa Nagarahalli
> ; Gavin Hu (Arm Technology China)
> ; hemant.agra...@nxp.com
> Subject: Re: [PATCH v
If there are any planned API/ABI change on v19.02, deprecation notice patches
for them should be sent, approved and merged withing v18.11 scope which is only
a few days away.
If you will be working on a feature for v19.02, please take some time think if
it will cause any API/ABI change.
And if it
RTE_BITMAP_OPTIMIZATIONS was never set to 0 and makes no sense
anyway, so remove all code related to it. Also, drop the "likely"
for bsf64 code, because it's a generic function and we cannot
make any assumptions about likely values of incoming arguments.
Signed-off-by: Anatoly Burakov
Acked-by: C
Rename rte_bsf64 to rte_bsf64_safe (this is a "safe" version in
that it prevents undefined behavior by checking if incoming
parameter is zero) and move it to common header.
Signed-off-by: Anatoly Burakov
Acked-by: Cristian Dumitrescu
Acked-by: Jasvinder Singh
---
doc/guides/rel_notes/deprecati
-Original Message-
> Date: Wed, 21 Nov 2018 03:39:15 +0530
> From: nikhil@intel.com
> To: dev@dpdk.org
> CC: Nikhil Rao , sta...@dpdk.org
> Subject: [dpdk-dev] [PATCH] eventdev: fix missing unlock in eth Rx adapter
> X-Mailer: git-send-email 2.14.1.145.gb3622a4
>
>
> From: Nikhil Rao
eth rxtx callback is dynamically allocated using rte_zmalloc()
but not released. Fix it by calling rte_free() to free callback
when removing rxtx callback.
Signed-off-by: wanlebing
Signed-off-by: wanlebing
---
lib/librte_ethdev/rte_ethdev.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, November 6, 2018 12:49 PM
> To: dev@dpdk.org; tho...@monjalon.net; Pattan, Reshma
> ; step...@networkplumber.org; Mcnamara, John
>
> Cc: Byrne, Stephen1 ; Glynn, Michael J
> ; Patel, Amol ; Varghese,
> Vipin
> Subject: [PATC
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, November 6, 2018 12:49 PM
> To: dev@dpdk.org; tho...@monjalon.net; Pattan, Reshma
> ; step...@networkplumber.org; Mcnamara, John
>
> Cc: Byrne, Stephen1 ; Glynn, Michael J
> ; Patel, Amol ; Varghese,
> Vipin
> Subject: [PATC
The Bottom-of-Stack (bos) bit of MPLS indicates
whether its the last MPLS layer (1) or not (0).
Indicating that the encapsulating MPLS is the
last MPLS layer in the packet as the default
behavior is more appropriate since multiple
encapsulation actions is not supported.
Fixes: 3e77031be855 ("app/
On 11/21/2018 1:11 PM, wanlebing wrote:
> eth rxtx callback is dynamically allocated using rte_zmalloc()
> but not released. Fix it by calling rte_free() to free callback
> when removing rxtx callback.
I guess they are not freed intentionally because there is no safe way to do it.
I remember Konst
On 11/19/2018 12:46 PM, Shahaf Shuler wrote:
> Signed-off-by: Shahaf Shuler
Series applied to dpdk-next-net/master, thanks.
> -Original Message-
> From: Saleh Alsouqi
> Sent: Wednesday, November 21, 2018 4:47 PM
> To: wenzhuo...@intel.com; jingjing...@intel.com;
> bernard.iremon...@intel.com
> Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org
> Subject: [PATCH] app/testpmd: fix mpls bos bit default value
>
> The Bo
On 11/21/2018 8:21 AM, Rafal Kozik wrote:
> rx_buffer_info should be refill not linearly, but out of order.
> IDs should be taken from empty_rx_reqs array.
>
> rx_refill_buffer is introduced to temporary storage
> bulk of mbufs taken from pool.
>
> In case of error unused mbufs are put back to po
On 11/20/2018 8:23 AM, Ori Kam wrote:
>
>
>> -Original Message-
>> From: dev On Behalf Of Dekel Peled
>> Sent: Monday, November 19, 2018 6:55 PM
>> To: wenzhuo...@intel.com; jingjing...@intel.com;
>> bernard.iremon...@intel.com
>> Cc: dev@dpdk.org; Ori Kam ; Shahaf Shuler
>> ; Dekel Pele
On 11/20/2018 2:15 PM, Matan Azrad wrote:
>
>
> From: Ferruh Yigit
>> DEFERRED state replaced by ownership concept and it is no more used as
>> code comment states.
>>
>> ethdev ABI broken on this release use this opportunity to remove DEFERRED
>> state.
>>
>> Signed-off-by: Ferruh Yigit
> Acked
On 11/20/2018 10:35 PM, Ferruh Yigit wrote:
> On 11/20/2018 1:00 PM, Jasvinder Singh wrote:
>> The memcpy operation overwrites the device info fields set
>> by ethdev API and leaves the device field undefined.
>> Thus, replaces memcpy by only updating the required fields
>> at the driver layer.
>>
> -Original Message-
> From: Ferruh Yigit
> Sent: Wednesday, November 21, 2018 5:19 PM
> To: Ori Kam ; Dekel Peled ;
> wenzhuo...@intel.com; jingjing...@intel.com; bernard.iremon...@intel.com
> Cc: dev@dpdk.org; Shahaf Shuler
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MPLSoUDP e
In some usages, kvlist is processed one time in rte_kvargs_process(),
and it is processed a second time if need to check whether it was matched.
In order to simplify implementation of kvargs checks, a new callback
may be used for "no match" cases.
The change of the function prototype would be as b
Hello Ferruh,
this patch fix issue in Rx path which could have caused receive of
wrong packets.
If it is possible, I would be very grateful if this patch could be
applied to v18.11.
Best regards,
Rafal
śr., 21 lis 2018 o 16:16 Ferruh Yigit napisał(a):
>
> On 11/21/2018 8:21 AM, Rafal Kozik wrot
>
> Rather than building a complex shim, why not just have an OS dependent section
> of the driver. The bigger issue is that the kernel side functionality in BSD
> is different or missing. For example TAP API is different and not
> multi-queue.
Once I started working on it, I had to go this ro
> -Original Message-
> From: Varghese, Vipin
> Sent: Tuesday, November 6, 2018 12:49 PM
> To: dev@dpdk.org; tho...@monjalon.net; Pattan, Reshma
> ; step...@networkplumber.org; Mcnamara, John
>
> Cc: Byrne, Stephen1 ; Glynn, Michael J
> ; Patel, Amol ; Varghese,
> Vipin
> +
On 10/3/2018 8:48 PM, Ferruh Yigit wrote:
> On 10/3/2018 2:36 PM, Gagandeep Singh wrote:
>> *ENETC* PMD driver which integrates with the existing PCI bus.
>> Document is also part of the set
>>
>> v4->v5 Change-log:
>> * missing commit info added in patch [3/4]
>> * dev_close API implemented
>> * l
The TCA_FLOWER_KEY_VLAN_ETH_TYPE should be specified for the E-Switch
Flows with VLAN and L3 pattern items in the Netlink messages. The patch
adds missing flower key to the messages. This patch partially reverts to
the code smashed by http://patches.dpdk.org/patch/47781
Fixes: 251e8d02cf37 ("net/m
Even if a device failed to plug, it's still a device
object that references the devargs. Those devargs will
be freed automatically together with the device, but
can't be freed any earlier.
Fixes: 7e8b26650146 ("eal: fix hotplug add / remove")
Cc: gaetan.ri...@6wind.com
Signed-off-by: Darek Stojac
Setting up a device that wasn't setup in the primary
process will possibly break the primary process. That's
because the IPC message to retrieve the group fd in the
primary will also *open* that group if it wasn't opened
before. Even though the secondary process closes that fd
soon after as a part
21/11/2018 19:37, Darek Stojaczyk:
> Even if a device failed to plug, it's still a device
> object that references the devargs. Those devargs will
> be freed automatically together with the device, but
> can't be freed any earlier.
Thanks for the patch.
Please, be more specific about the bug.
You
If a device fails to attach before it's plugged,
the subsequent rollback will still try to detach it,
causing a segfault. Unplugging a device that wasn't
plugged isn't really supported, so this patch adds
an extra error check to prevent that from happening.
While here, fix this also for normal (no
Even if a device failed to plug, it's still a device
object that references the devargs. Those devargs will
be freed automatically together with the device, but
freeing them any earlier - like it's done in the hotplug
error handling path right now - will give us a dangling
pointer and a segfault sc
On Wed, 21 Nov 2018 11:41:36 +
"Joyce Kong (Arm Technology China)" wrote:
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
On Wed, 21 Nov 2018 11:11:51 -0600 (CST)
Mit Matelske wrote:
> >
> > Rather than building a complex shim, why not just have an OS dependent
> > section
> > of the driver. The bigger issue is that the kernel side functionality in
> > BSD
> > is different or missing. For example TAP API is dif
On Tue, 6 Nov 2018 18:19:07 +0530
Vipin Varghese wrote:
Minor observations which are things that checkpatch etc won't see
but make the code easier to read/maintain.
> +/* border variable to hold for show */
> +char bdr_str[MAX_STRING_LEN];
Does this have to be global, could it just be static?
From: Shahed Shaikh
Following commit updated the Tx offload mask
commit 1037ed842c37 ("mbuf: fix Tx offload mask").
So, not having PKT_TX_IPV6 and PKT_TX_IPV4 in qede PMDs supported
Tx offload mask breaks TSO support since application will fail in transmit
prepare function.
Fixes: 1037ed842c37
Update QEDE PMD firmware version to 8.37.7.0
Signed-off-by: Rasesh Mody
---
doc/guides/nics/qede.rst |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/guides/nics/qede.rst b/doc/guides/nics/qede.rst
index cba3886..c0a3833 100644
--- a/doc/guides/nics/qede.rst
+++ b
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, November 20, 2018 2:54 PM
> To: Zhang, Qi Z ; Richardson, Bruce
> ; Wiles, Keith
> Cc: dev@dpdk.org; Lu, Wenzhuo ; Iremonger, Bernard
> ; sta...@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: improve MAC swap per
Hi Hideyuki,
Regarding your questions about DPDK CPU usage, etc:
I believe that due to the way PMDs are implemented, maybe one
should consider using DPDK RTE jobstats API for collecting stats for a DPDK
app. This API reflects better the actual DPDK app stats.
See an example in:
https://doc.dpdk.or
This commit improves the programmer guide of the hash
library to be more accurate on new features introduced
in 18.11.
Signed-off-by: Yipeng Wang
Signed-off-by: Sameh Gobriel
---
doc/guides/prog_guide/hash_lib.rst | 145 ++---
1 file changed, 85 insertions(+), 60
cc konstantin.ananyev
konstantin.ananyev, please help.
Ferruh Yigit 于2018年11月21日周三 下午10:48写道：
> On 11/21/2018 1:11 PM, wanlebing wrote:
> > eth rxtx callback is dynamically allocated using rte_zmalloc()
> > but not released. Fix it by calling rte_free() to free callback
> > when removing rxtx c
Add a debug check for out-of-bound write while freeing the key slot.
Coverity issue: 325733
Fixes: e605a1d36ca7 ("hash: add lock-free r/w concurrency")
Cc: honnappa.nagaraha...@arm.com
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Steve Capper
Reviewed-by: Gavin Hu
---
lib/librte_hash/rte_
The --server-socket-path and --client-socket-path options
have already been removed. So also remove them from the doc
to avoid confusion.
Fixes: 09f4aa2b955f ("app/pdump: remove unused socket path options")
Cc: sta...@dpdk.org
Signed-off-by: Tiwei Bie
---
doc/guides/tools/pdump.rst | 10 ---
We already changed to use generic IPC in pdump since below commit:
commit 660098d61f57 ("pdump: use generic multi-process channel")
The `rte_pdump_set_socket_dir()`, the `path` parameter of
`rte_pdump_init()` and the `enum rte_pdump_socktype` have been
deprecated since then. This commit removes t
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Steve Capper
Reviewed-by: Gavin Hu
---
lib/librte_eal/common/include/rte_log.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librte_eal/common/include/rte_log.h
b/lib/librte_eal/common/include/rte_log.h
index 2f789cb90..b4e91a4a5 10064
Lock-less data structures provide scalability and determinism.
They enable use cases where locking may not be allowed
(for ex: real-time applications).
In the following paras, the term 'memory' refers to memory allocated
by typical APIs like malloc or anything that is representative of
memory, for
Add Thread Quiescent State (TQS) library. This library helps identify
the quiescent state of the reader threads so that the writers
can free the memory associated with the lock less data structures.
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Steve Capper
Reviewed-by: Gavin Hu
---
config/
From: Dharmik Thakkar
Add API positive/negative test cases and functional tests.
Signed-off-by: Malvika Gupta
Signed-off-by: Dharmik Thakkar
Signed-off-by: Honnappa Nagarahalli
Reviewed-by: Gavin Hu
---
test/test/Makefile | 2 +
test/test/autotest_data.py | 6 +
test/test/meson.
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm64 platform.
Fixes:
> -Original Message-
> From: Jerin Jacob
> Sent: Wednesday, November 21, 2018 7:35 PM
> To: Joyce Kong (Arm Technology China)
> Cc: dev@dpdk.org; tho...@monjalon.net; Honnappa Nagarahalli
> ; Gavin Hu (Arm Technology China)
> ; sta...@dpdk.org
> Subject: Re: [PATCH v2] config: enable more
-Original Message-
> Date: Thu, 22 Nov 2018 15:01:14 +0800
> From: Joyce Kong
> To: dev@dpdk.org
> CC: tho...@monjalon.net, jerin.ja...@caviumnetworks.com,
> honnappa.nagaraha...@arm.com, gavin...@arm.com, sta...@dpdk.org
> Subject: [PATCH v3] config: enable more than 128 cores for Arm64
Hi.
Is the any differentiation points with liburcu [1] ?
Is there any profit having own implementation inside DPDK ?
[1] http://liburcu.org/
https://lwn.net/Articles/573424/
Best regards, Ilya Maximets.
> Lock-less data structures provide scalability and determinism.
> They enable use cases
When running dpdk applications on cores whose ids are bigger
than original max_core setting, eal error as below:
EAL: Detected 104 lcore(s)
EAL: Detected 2 NUMA nodes
EAL: invalid core list
-l CORELIST core indexes between 0 and 128
The fix is to increase max_core to 256 on Arm64 platform.
Fixes:
> -Original Message-
> From: Jerin Jacob
> Sent: Thursday, November 22, 2018 3:09 PM
> To: Joyce Kong (Arm Technology China)
> Cc: dev@dpdk.org; tho...@monjalon.net; Honnappa Nagarahalli
> ; Gavin Hu (Arm Technology China)
> ; sta...@dpdk.org
> Subject: Re: [PATCH v3] config: enable more
66 matches
Mail list logo
