21/11/2018 19:37, Darek Stojaczyk:
> Even if a device failed to plug, it's still a device
> object that references the devargs. Those devargs will
> be freed automatically together with the device, but
> can't be freed any earlier.
Thanks for the patch.
Please, be more specific about the bug.
You could add 2 more paragraphs:
- One before, to explain the tested scenario and the result.
- One after, to explain how it is fixed (changing the goto by a return).
[...]
> ret = dev->bus->plug(dev);
> if (ret) {
> - if (rte_dev_is_probed(dev)) /* if already succeeded earlier */
> - return ret; /* no rollback */
> - RTE_LOG(ERR, EAL, "Driver cannot attach the device (%s)\n",
> - dev->name);
> - goto err_devarg;
> + if (!rte_dev_is_probed(dev)) /* if hasn't succeeded earlier */
> + RTE_LOG(ERR, EAL, "Driver cannot attach the device
> (%s)\n",
> + dev->name);
> + return ret;
> }
