Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask

2018-10-25 Thread Yan, Zhirun
> -Original Message- > From: Ye, Xiaolong > Sent: Thursday, October 25, 2018 2:09 PM > To: Yan, Zhirun > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask > > On 10/25, Zhirun Yan wrote: > >Tx offload mask is upda

[dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask

2018-10-25 Thread Zhirun Yan
Tx offload mask is updated in following commit: commit 1037ed842c37 ("mbuf: fix Tx offload mask"). Currently, the new added offload flags are not supported in PMD and application will fail to call PMD transmit prepare function. This patch updates IXGBE_TX_OFFFLOAD_MASK. Fixes: 1037ed842c37 ("mbuf

Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process

2018-10-25 Thread Thomas Monjalon
27/09/2018 15:28, Ferruh Yigit: > On 9/21/2018 5:25 PM, Paul Luse wrote: > > From: paul luse > > > > This patch fixes an issue caught with ASAN where a vdev_scan() > > to a secondary bus was failing to free some memory. > > > > Signed-off-by: paul luse > > (carry from Anatoly's ack from other

Re: [dpdk-dev] [PATCH v6] compress/qat: enable dynamic huffman encoding

2018-10-25 Thread Akhil Goyal
Hi Fiona, On 10/25/2018 7:00 AM, Fiona Trahe wrote: > Enable dynamic huffman encoding in the QAT comp PMD. > > Signed-off-by: Tomasz Jozwiak > Signed-off-by: Fiona Trahe > Acked-by: Arek Kusztal > --- The patch is still failing in i686 and armv7 Testing i686 *

[dpdk-dev] [PATCH] net/i40e: fix Rx instability with vector mode

2018-10-25 Thread Beilei Xing
Previously, there is instability during vector Rx if descriptor number is not power of 2, e.g. process hang and some Rx packets are unexpectedly empty. That's because vector Rx mode assumes Rx descriptor number is power of 2 when doing bit mask. This patch allows vector mode only when the number of

Re: [dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask

2018-10-25 Thread Ye Xiaolong
On 10/25, Zhirun Yan wrote: >Tx offload mask is updated in following commit: commit 1037ed842c37 >("mbuf: fix Tx offload mask"). Currently, the new added offload >flags are not supported in PMD and application will fail to call >PMD transmit prepare function. > >This patch updates IXGBE_TX_OFFFLOAD

[dpdk-dev] Regarding -: net_vmxnet3: link status Interrupt is not working in DPDK 17.11.2 version

2018-10-25 Thread Verma, Siddharth
Hi , link status Interrupt is not working in DPDK 17.11.2 version for net_vmxnet3 driver , we are doing port connect/disconnect using vmware/ESXI but we are getting any LSI from DPDK. Looks like dpdk is not generating any event . Please do let me know, whether I am missing any configuraion/patch

[dpdk-dev] Regarding -: net_vmxnet3: link status Interrupt is not working in DPDK 17.11.2 version

2018-10-25 Thread siddharth verma
Hi , link status Interrupt is not working in DPDK 17.11.2 version for net_vmxnet3 driver , we are doing port connect/disconnect using vmware/ESXI but we are getting any LSI from DPDK. Looks like dpdk is not generating any event . Please do let me know, whether I am missing any configuraion/patch

Re: [dpdk-dev] [PATCH v3] latencystats: fix timestamp marking and latency calculation

2018-10-25 Thread Thomas Monjalon
25/09/2018 16:51, Reshma Pattan: > Latency calculation logic is not correct for the case where > packets gets dropped before TX. As for the dropped packets, > the timestamp is not cleared, and such packets still gets > counted for latency calculation in next runs, that will result > in inaccurate l

[dpdk-dev] [PATCH 2/2] net/mlx5: fix detection and error for multiple item layers

2018-10-25 Thread Shahaf Shuler
1. The check for the Eth item was wrong. causing an error with flow rules like: flow create 0 ingress pattern eth / vlan vid is 13 / ipv4 / gre / eth / vlan vid is 15 / end actions drop / end 2. align all error messages. 3. align multiple item layers check. Fixes: 23c1d42c7138 ("net/mlx5: split

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration

2018-10-25 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 8:55 PM > To: Iremonger, Bernard > Cc: Wu, Jingjing ; Lu, Wenzhuo > ; dev@dpdk.org; ophi...@mellanox.com; > wis...@mellanox.com; Yigit, Ferruh ; > arybche...@solarflare

[dpdk-dev] [PATCH 1/2] net/mlx5: fix bit width of flow items

2018-10-25 Thread Shahaf Shuler
Apply the changes from commit c744f6b1b969 ("net/mlx5: fix bit width of item and action flags") in some places that were overlooked. Fixes: c744f6b1b969 ("net/mlx5: fix bit width of item and action flags") Fixes: 23c1d42c7138 ("net/mlx5: split flow validation to dedicated function") Signed-off-by

Re: [dpdk-dev] [PATCH 5/5] app/testpmd: setup attached ports on probe event

2018-10-25 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, October 24, 2018 8:58 PM > To: Iremonger, Bernard > Cc: Wu, Jingjing ; Lu, Wenzhuo > ; dev@dpdk.org; ophi...@mellanox.com; > wis...@mellanox.com; Yigit, Ferruh ; > arybche...@solarflare

Re: [dpdk-dev] [PATCH 4/5] app/testpmd: move ethdev events registration

2018-10-25 Thread Thomas Monjalon
25/10/2018 10:54, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/10/2018 17:55, Iremonger, Bernard: > > > Hi Thomas, > > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > +/* Pretty printing of ethdev events */ static const char * co

Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter API

2018-10-25 Thread Ferruh Yigit
On 10/24/2018 6:25 PM, Shahaf Shuler wrote: > Hi Ferruh, > > Wednesday, October 24, 2018 7:36 PM, Ferruh Yigit >> Subject: Re: [dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter >> API >> >> On 10/24/2018 5:31 PM, Ferruh Yigit wrote: >>> On 10/23/2018 11:04 AM, Slava Ovsiienko wrote: >>>

Re: [dpdk-dev] [dpdk-web] [PATCH v1] add dpdk-quickstart python script

2018-10-25 Thread Hunt, David
Hi, I'm just wondering if there is anything I can do to help move this website patch forward? Any suggestions? Regards, Dave. On 3/8/2018 12:41 PM, david.hunt at intel.com (David Hunt) wrote: This patch contains two section. 1. Updates to the existing quick-start.html page giving

Re: [dpdk-dev] [dpdk-web] [PATCH v1] add dpdk-quickstart python script

2018-10-25 Thread Thomas Monjalon
25/10/2018 11:09, Hunt, David: > Hi, > > I'm just wondering if there is anything I can do to help move this > website patch forward? Any suggestions? The website has changed. It is using Hugo now. The update in doc/quick-start.html must be ported. About the python script, I don't understand why

Re: [dpdk-dev] [PATCH] bpf: fix a typo

2018-10-25 Thread Thomas Monjalon
22/08/2018 17:25, Ananyev, Konstantin: > From: Rami Rosen [mailto:ramir...@gmail.com] > > > > This trivial patch fixes a typo in rte_bpf_ethdev.h, > > > > Signed-off-by: Rami Rosen > > --- > > lib/librte_bpf/rte_bpf_ethdev.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > dif

Re: [dpdk-dev] [PATCH v9 1/8] net/virtio: vring init for packed queues

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:29PM +0200, Jens Freimann wrote: > Add and initialize descriptor data structures. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ethdev.c | 18 > drivers/net/virtio/virtio_pci.h| 7 +++ > drivers/net/virtio/virtio_ring.h | 74

Re: [dpdk-dev] [PATCH v9 2/8] net/virtio: add packed virtqueue defines

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:30PM +0200, Jens Freimann wrote: > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ring.h | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio/virtio_ring.h > b/drivers/net/virtio/virtio_ring.h > index e65da

Re: [dpdk-dev] [PATCH v9 3/8] net/virtio: add packed virtqueue helpers

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:31PM +0200, Jens Freimann wrote: > Add helper functions to set/clear and check descriptor flags. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ring.h | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/n

Re: [dpdk-dev] [PATCH v9 4/8] net/virtio: dump packed virtqueue data

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:32PM +0200, Jens Freimann wrote: > Add support to dump packed virtqueue data to the > VIRTQUEUE_DUMP() macro. > > Signed-off-by: Jens Freimann > Reviewed-by: Maxime Coquelin > --- > drivers/net/virtio/virtqueue.h | 9 + > 1 file changed, 9 insertions(+) >

[dpdk-dev] DPDK Release Status Meeting 25/10/2018

2018-10-25 Thread Ferruh Yigit
Minutes 25 October 2018 --- Agenda: * Dates * Subtrees * Bugzilla Participants: * 6wind * Debian * Intel * Mellanox * NXP * RedHat Release Dates - * RC1 date is unchanged, it is *Friday, 26 October 2018* * RC2 date is *Friday, 2 November 2018* * Release date is

Re: [dpdk-dev] [PATCH] bus/pci: use device driver name instead of handler type

2018-10-25 Thread Burakov, Anatoly
On 25-Oct-18 7:00 AM, Alejandro Lucero wrote: On Thu, Oct 25, 2018 at 6:30 AM Alejandro Lucero < alejandro.luc...@netronome.com> wrote: On Thu, Oct 25, 2018 at 12:11 AM Thomas Monjalon wrote: Hi, 19/10/2018 18:43, Alejandro Lucero: --- a/drivers/bus/pci/linux/pci.c +++ b/drivers/bus/pci/

Re: [dpdk-dev] [PATCH v2 1/4] hash: fix unnecessary pause

2018-10-25 Thread Bruce Richardson
On Thu, Oct 25, 2018 at 08:31:16AM +0200, Mattias Rönnblom wrote: > On 2018-10-24 20:09, Yipeng Wang wrote: > > There is a rte_pause in hash table reset function. > > Since the loop is not a polling loop on shared > > data structure, the rte_pause is not needed. > > > > I'm guessing the include

Re: [dpdk-dev] [dpdk-web] [PATCH v1] add dpdk-quickstart python script

2018-10-25 Thread Hunt, David
Hi Thomas, On 25/10/2018 10:14 AM, Thomas Monjalon wrote: 25/10/2018 11:09, Hunt, David: Hi, I'm just wondering if there is anything I can do to help move this website patch forward? Any suggestions? The website has changed. It is using Hugo now. The update in doc/quick-start.html must be po

Re: [dpdk-dev] [PATCH v2 2/4] test/hash: change multiwriter test to use jhash

2018-10-25 Thread Bruce Richardson
On Wed, Oct 24, 2018 at 11:09:28AM -0700, Yipeng Wang wrote: > With sequential key, the test will cover more corner > cases with jhash instead of crc hash, since jhash > generates more random hash pattern on sequential key. > It is useful for functional verification. > > Signed-off-by: Yipeng Wang

Re: [dpdk-dev] [PATCH v9 5/8] net/virtio: implement transmit path for packed queues

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:33PM +0200, Jens Freimann wrote: > This implements the transmit path for devices with > support for packed virtqueues. > > Signed-off-by: Jens Freiman > --- > drivers/net/virtio/virtio_ethdev.c | 32 +++- > drivers/net/virtio/virtio_ethdev.h | 2 + > drivers/net/

Re: [dpdk-dev] [PATCH v2 3/4] test/hash: add readwrite test for ext table

2018-10-25 Thread Bruce Richardson
On Wed, Oct 24, 2018 at 11:09:29AM -0700, Yipeng Wang wrote: > This commit improves the readwrite test to consider > extendable table feature and add more functional tests > to cover more corner cases. > > Signed-off-by: Yipeng Wang > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2 4/4] test/hash: remove hash scaling unit test

2018-10-25 Thread Bruce Richardson
On Wed, Oct 24, 2018 at 11:09:30AM -0700, Yipeng Wang wrote: > The hash scaling unit test is not really needed > any more since the multi-writer is supported now > inside the library and it is tested by multi-writer > unit test. > > Signed-off-by: Yipeng Wang > --- > test/test/Makefile

Re: [dpdk-dev] [PATCH v9 6/8] net/virtio: implement receive path for packed queues

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:34PM +0200, Jens Freimann wrote: > Implement the receive part. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ethdev.c | 18 +- > drivers/net/virtio/virtio_ethdev.h | 2 + > drivers/net/virtio/virtio_rxtx.c | 280 ++--

Re: [dpdk-dev] [PATCH] eal: fix floating device argument pointer

2018-10-25 Thread Gaëtan Rivet
On Thu, Oct 25, 2018 at 03:22:11AM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Wednesday, October 24, 2018 10:34 AM > > To: Thomas Monjalon > > Cc: dev@dpdk.org; Zhang, Qi Z > > Subject: Re: [dpdk-dev] [PATCH] eal

Re: [dpdk-dev] [PATCH] bus/pci: use device driver name instead of handler type

2018-10-25 Thread Alejandro Lucero
On Thu, Oct 25, 2018 at 10:29 AM Burakov, Anatoly wrote: > On 25-Oct-18 7:00 AM, Alejandro Lucero wrote: > > On Thu, Oct 25, 2018 at 6:30 AM Alejandro Lucero < > > alejandro.luc...@netronome.com> wrote: > > > >> > >> > >> On Thu, Oct 25, 2018 at 12:11 AM Thomas Monjalon > >> wrote: > >> > >>> Hi

Re: [dpdk-dev] [PATCH v9 0/8] implement packed virtqueues

2018-10-25 Thread Tiwei Bie
On Wed, Oct 24, 2018 at 04:32:28PM +0200, Jens Freimann wrote: > This is a basic implementation of packed virtqueues as specified in the > Virtio 1.1 draft. A compiled version of the current draft is available > at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at > https://github.com/oas

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-25 Thread Hideyuki Yamashita
Hi, > 25/10/2018 04:54, Hideyuki Yamashita: > > Hi, > > > > > Yes it may work with most of the drivers. > > Question for my understadnding. > > You said that most of the drivers assign only one > > port when hotplug_add is called, right? > > Then what is the exception? > > What kind of device/d

[dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost

2018-10-25 Thread Tiwei Bie
Tiwei Bie (2): net/virtio: drop duplicated reset method net/vhost: fix parameters string drivers/net/vhost/rte_eth_vhost.c | 6 +- drivers/net/virtio/virtio_pci.c | 15 --- drivers/net/virtio/virtio_pci.h | 1 - drivers/net/virtio/virtio_user_ethdev.c |

[dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method

2018-10-25 Thread Tiwei Bie
Drop the duplicated reset() method in virtio_pci_ops. Currently vtpci_reset() is implemented on set_status() and get_status() directly. The reset() method in virtio_pci_ops isn't used and its implementation in the legacy device isn't right. Signed-off-by: Tiwei Bie --- drivers/net/virtio/virtio_

[dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string

2018-10-25 Thread Tiwei Bie
Add the missing params to the param string. Fixes: 39cac2adcad0 ("net/vhost: add client option") Fixes: 4ce97c6f6b4f ("net/vhost: add an option to enable dequeue zero copy") Fixes: 447e0d379756 ("net/vhost: add parameter to enable IOMMU feature") Fixes: 6d6e95cec455 ("net/vhost: add parameter to e

Re: [dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-25 Thread Gaëtan Rivet
On Thu, Oct 25, 2018 at 11:30:36AM +0800, Qi Zhang wrote: > It's not necessary to insert device argment to devargs_list > during bus scan, but this happens when we try to attach a > device on secondary process. The patch fix the issue. > > Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process chan

[dpdk-dev] [PATCH v2 0/2] Changes for RSA verify operation in OpenSSL PMD and unit tests

2018-10-25 Thread Akash Saxena
v2: Added NULL check for tmp buffer allocation failure. v1: In lib cryptodev, RSA verify operation inputs plain message text and corresponding signature and expected to return RTE_CRYPTO_OP_STATUS_SUCCESS/FAILURE on a signature match/mismatch. Current OpenSSL PMD RSA verify implementation overrid

[dpdk-dev] [PATCH v2 2/2] test/crypto: remove data verification at rsa verify operation

2018-10-25 Thread Akash Saxena
Change unit test app to check only for op->status = RTE_CRYPTO_OP_STATUS_SUCCESS/ERROR instead of calling rsa_verify(). Signed-off-by: Ayuj Verma Signed-off-by: Akash Saxena Signed-off-by: Shally Verma --- test/test/test_cryptodev_asym.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deleti

[dpdk-dev] [PATCH v2 1/2] crypto/openssl: changes for RSA verify operation

2018-10-25 Thread Akash Saxena
Add tmp buffer to pass to OpenSSL sign API and memcmp output with original plain text to verify signature match. Set op->status = RTE_CRYPO_OP_STATUS_ERROR on signature mismatch. Signed-off-by: Ayuj Verma Signed-off-by: Akash Saxena Signed-off-by: Shally Verma --- drivers/crypto/openssl/rte_op

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-25 Thread Ferruh Yigit
On 10/23/2018 8:09 AM, Shreyansh Jain wrote: > Besides the comment I sent before about 'Fixes' before sign-off, a > single trivial comment inline ... > > On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: >> This patch fixes rte_eal_hotplug_add without checking return value issue >> >> Signed-o

Re: [dpdk-dev] [RFC] ethdev: make offload name API non-experimental

2018-10-25 Thread Ferruh Yigit
On 10/22/2018 3:39 PM, Ferruh Yigit wrote: > On 10/19/2018 6:35 PM, Stephen Hemminger wrote: >> The offload name functions are useful, but since they are >> marked experimental they can not be used by upstream projects. >> For example, VPP duplicates the same table in its code. >> >> Signed-off-by:

Re: [dpdk-dev] [dpdk-web] [PATCH v1] add dpdk-quickstart python script

2018-10-25 Thread Thomas Monjalon
25/10/2018 11:31, Hunt, David: > Hi Thomas, > > > On 25/10/2018 10:14 AM, Thomas Monjalon wrote: > > 25/10/2018 11:09, Hunt, David: > >> Hi, > >> > >> I'm just wondering if there is anything I can do to help move this > >> website patch forward? Any suggestions? > > The website has changed. > > I

Re: [dpdk-dev] [dpdk-web] [PATCH v1] add dpdk-quickstart python script

2018-10-25 Thread Hunt, David
Hi Thomas, On 25/10/2018 11:30 AM, Thomas Monjalon wrote: 25/10/2018 11:31, Hunt, David: Hi Thomas, On 25/10/2018 10:14 AM, Thomas Monjalon wrote: 25/10/2018 11:09, Hunt, David: Hi, I'm just wondering if there is anything I can do to help move this website patch forward? Any suggestions?

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-25 Thread Thomas Monjalon
25/10/2018 11:46, Hideyuki Yamashita: > Hi, > > > 25/10/2018 04:54, Hideyuki Yamashita: > > > Hi, > > > > > > > Yes it may work with most of the drivers. > > > Question for my understadnding. > > > You said that most of the drivers assign only one > > > port when hotplug_add is called, right? >

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix metadata API and Tx insertion

2018-10-25 Thread Ferruh Yigit
On 10/24/2018 11:49 AM, Ori Kam wrote: > > >> -Original Message- >> From: dev On Behalf Of Dekel Peled >> Sent: Wednesday, October 24, 2018 9:22 AM >> To: wenzhuo...@intel.com; jingjing...@intel.com; >> bernard.iremon...@intel.com; olivier.m...@6wind.com; Adrien Mazarguil >> ; Thomas Mon

[dpdk-dev] [PATCH v9 5/8] net/virtio: implement transmit path for packed queues

2018-10-25 Thread Jens Freimann
This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c | 32 +++- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 285 + drivers/net/virtio/

[dpdk-dev] [PATCH] eal: fix rte_mp_request_sync() memleak on device hotplug

2018-10-25 Thread Darek Stojaczyk
rte_mp_request_sync() says that the caller is responsible for freeing one of its parameters afterwards. EAL didn't do that, causing a memory leak. Fixes: 244d5130719c ("eal: enable hotplug on multi-process") Cc: qi.z.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by: Darek Stojaczyk --- lib/lib

[dpdk-dev] [PATCH] vdev: fix rte_mp_request_sync() memleak on scan

2018-10-25 Thread Darek Stojaczyk
rte_mp_request_sync() says that the caller is responsible for freeing one of its parameters afterwards. vdev didn't do that, causing a memory leak. Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") Cc: jianfeng@intel.com Cc: qi.z.zh...@intel.com Cc: sta...@dpdk.org Signed-off-by

[dpdk-dev] [PATCH] vfio: fix read-after-free on getting container fd

2018-10-25 Thread Darek Stojaczyk
We were reading some memory just after freeing it. Fixes: 83a73c5fef66 ("vfio: use generic multi-process channel") Cc: jianfeng@intel.com Cc: anatoly.bura...@intel.com Cc: sta...@dpdk.org Signed-off-by: Darek Stojaczyk --- lib/librte_eal/linuxapp/eal/eal_vfio.c | 3 ++- 1 file changed, 2 in

[dpdk-dev] [PATCH v2] bus/pci: use device driver name instead of handler type

2018-10-25 Thread Alejandro Lucero
Invoking the right pci read/write functions is based on interrupt handler type. However, this is not configured for secondary processes precluding to use those functions. This patch fixes the issue using the driver name the device is bound to instead. Fixes: 632b2d1deeed ("eal: provide functions

[dpdk-dev] [PATCH] eal: fixup hotplugging an already present device

2018-10-25 Thread Darek Stojaczyk
We were returning rc = -1 from a device probing function whenever the provided device was already probed before. This basically broke hotplugging a device in secondary process when the same device was already hotplugged in the primary. To fix it, just return 0 instead of -1. I believe this is the

[dpdk-dev] [PATCH v9 6/8] net/virtio: implement receive path for packed queues

2018-10-25 Thread Jens Freimann
Implement the receive part. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 18 +- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 278 ++--- drivers/net/virtio/virtqueue.c | 22 +++ drivers/net/virtio/virtqueue

[dpdk-dev] [PATCH v2] bus/pci: use device driver name instead of handler type

2018-10-25 Thread Alejandro Lucero
Invoking the right pci read/write functions is based on interrupt handler type. However, this is not configured for secondary processes precluding to use those functions. This patch fixes the issue using the driver name the device is bound to instead. Fixes: 632b2d1deeed ("eal: provide functions

Re: [dpdk-dev] Memory allocation in dpdk at basic level

2018-10-25 Thread Avinash Chaurasia
Thanks a lot! Avinash Kumar Chaurasia On Tue, Oct 23, 2018 at 3:26 PM Burakov, Anatoly wrote: > On 22-Oct-18 10:08 PM, Avinash Chaurasia wrote: > > Hello, > > I am not sure whether this is right list for posting this problem. I am > > trying to understand how dpdk allocate memory. I tried dig

Re: [dpdk-dev] [PATCH v9 5/8] net/virtio: implement transmit path for packed queues

2018-10-25 Thread Jens Freimann
On Wed, Oct 24, 2018 at 06:55:15PM +0200, Maxime Coquelin wrote: On 10/24/18 4:32 PM, Jens Freimann wrote: diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c index eb891433e..837457243 100644 --- a/drivers/net/virtio/virtio_rxtx.c +++ b/drivers/net/virtio/virtio_r

Re: [dpdk-dev] [PATCH 1/2] net: add Mpls header structure

2018-10-25 Thread Ferruh Yigit
On 10/23/2018 8:46 AM, Olivier Matz wrote: > Add the Mpls header structure in librte_net. It will be used by next > patch that adds the support of Mpls L2 layer in the software packet > type parser. > > Signed-off-by: Olivier Matz For series, Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/2] net: add Mpls header structure

2018-10-25 Thread Ferruh Yigit
On 10/25/2018 12:04 PM, Ferruh Yigit wrote: > On 10/23/2018 8:46 AM, Olivier Matz wrote: >> Add the Mpls header structure in librte_net. It will be used by next >> patch that adds the support of Mpls L2 layer in the software packet >> type parser. >> >> Signed-off-by: Olivier Matz > > For series,

[dpdk-dev] [PATCH] malloc: fix external heap allocation in no huge mode

2018-10-25 Thread Anatoly Burakov
When no-huge mode is enabled, we always overwrite the socket ID to be SOCKET_ID_ANY in rte_malloc, because there is no NUMA awareness in no-huge mode. However, with external memory support, a socket ID may have other meaning, and we cannot overwrite the socket ID in those cases. Fixes: 65ff37b105f

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: fix metadata API and Tx insertion

2018-10-25 Thread Thomas Monjalon
25/10/2018 12:45, Ferruh Yigit: > On 10/24/2018 11:49 AM, Ori Kam wrote: > > From: dev On Behalf Of Dekel Peled > >> > >> Previous patch introduces the Tx metadata feature, with unnecessary > >> restrictions on data entry. > >> It also used the metadata in txonly fwd engine only. > >> > >> This fi

Re: [dpdk-dev] [PATCH] eal: fixup hotplugging an already present device

2018-10-25 Thread Thomas Monjalon
25/10/2018 12:51, Darek Stojaczyk: > We were returning rc = -1 from a device probing function > whenever the provided device was already probed before. > > This basically broke hotplugging a device in secondary > process when the same device was already hotplugged in > the primary. > > To fix it,

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix complete queue compression device argument

2018-10-25 Thread Xueming(Steven) Li
Sorry, these 2 patches are candidates for stable. > -Original Message- > From: Xueming Li > Sent: Wednesday, October 24, 2018 4:40 PM > To: Shahaf Shuler ; Yongseok Koh > Cc: Xueming(Steven) Li ; dev@dpdk.org > Subject: [PATCH 1/2] net/mlx5: fix complete queue compression device argument

Re: [dpdk-dev] [PATCH v7 0/5] kni: add API to set link status on kernel interface

2018-10-25 Thread Ferruh Yigit
On 10/24/2018 11:26 PM, Dan Gora wrote: > Hi All, > > Attached is version 7 of a patchset to add a new API function to > set the link status on kernel interfaces created with the KNI kernel > module. > > v7 > > * Add commands to check/clear statistics in kni sample app in KNI sample > app

Re: [dpdk-dev] [PATCH 1/6] doc: add missing shared library versions to release notes

2018-10-25 Thread Thomas Monjalon
15/10/2018 16:50, Ferruh Yigit: > Fixes: 857ed6c68cf2 ("member: implement main API") > Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") > > Signed-off-by: Ferruh Yigit Series applied without patch 6 (rejected), thanks for the good clean-up.

Re: [dpdk-dev] [PATCH] ethdev: filter destroy event before probed

2018-10-25 Thread Ferruh Yigit
On 10/24/2018 2:12 PM, Thomas Monjalon wrote: > If a port is being created and rollbacked because of an error, > the event RTE_ETH_EVENT_DESTROY should not be sent. > It makes no sense to receive a destroy event for a port which > was not yet announced via RTE_ETH_EVENT_NEW. > > Signed-off-by: Tho

Re: [dpdk-dev] [PATCH] ethdev: filter destroy event before probed

2018-10-25 Thread Ferruh Yigit
On 10/25/2018 1:38 PM, Ferruh Yigit wrote: > On 10/24/2018 2:12 PM, Thomas Monjalon wrote: >> If a port is being created and rollbacked because of an error, >> the event RTE_ETH_EVENT_DESTROY should not be sent. >> It makes no sense to receive a destroy event for a port which >> was not yet announc

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-25 Thread Xu, Rosen
> -Original Message- > From: Yigit, Ferruh > Sent: Thursday, October 25, 2018 18:26 > To: Shreyansh Jain ; Xu, Rosen > ; dev@dpdk.org > Cc: Zhang, Tianfei ; Hemant Agrawal > > Subject: Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue > 323508 > > On 10/23/2018 8:09 AM

Re: [dpdk-dev] [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and definitions

2018-10-25 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Tuesday, October 23, 2018 13:02 > To: Slava Ovsiienko > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and > definitions > > On Mon, Oct 15, 2018 at 02:13:29PM +, Viacheslav Ovsiie

Re: [dpdk-dev] [PATCH] ethdev: fix iterator default behaviour for representors

2018-10-25 Thread Ferruh Yigit
On 10/24/2018 2:13 PM, Thomas Monjalon wrote: > The iterator was matching all representors if it was not specified > in the devargs string. It was a wrong default behaviour. > > If there is no representor parameter in the devargs, the iterator > should not match any representor port. > > The impl

Re: [dpdk-dev] [PATCH v9 5/8] net/virtio: implement transmit path for packed queues

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:31:04PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:33PM +0200, Jens Freimann wrote: This implements the transmit path for devices with support for packed virtqueues. Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c | 32 +++- drivers/ne

Re: [dpdk-dev] [PATCH v4 0/2] CPU non-blocking delay

2018-10-25 Thread Ferruh Yigit
On 10/10/2018 3:12 PM, Ilya Maximets wrote: > For meson build without deprecation warnings following > patch should be applied first: > http://patches.dpdk.org/patch/46064/ > > Version 4: > * Fixed return value checking for nanosleep(). > It doesn't return EINTR, it sets the errn

Re: [dpdk-dev] [PATCH] net/*/base: allow experimental APIs in base of avf and qede

2018-10-25 Thread Ferruh Yigit
On 10/4/2018 4:10 PM, Ilya Maximets wrote: > On 04.10.2018 17:51, Ferruh Yigit wrote: >> On 10/4/2018 2:18 PM, Ilya Maximets wrote: >>> This functionality was missed while adding new drivers to >>> the meson build. >> >> Is there any call from base code to experimental APIs? What do you think >> a

Re: [dpdk-dev] [PATCH v9 1/8] net/virtio: vring init for packed queues

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:21:15PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:29PM +0200, Jens Freimann wrote: Add and initialize descriptor data structures. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 18 drivers/net/virtio/virtio_pci.h| 7 +

Re: [dpdk-dev] [PATCH 1/2] mbuf: add FCoE packet type

2018-10-25 Thread Thomas Monjalon
23/10/2018 09:44, Olivier Matz: > On Sun, Aug 26, 2018 at 06:24:54PM +0530, Jerin Jacob wrote: > > Add support of FCoE packet type. > > > > Signed-off-by: Jerin Jacob > > Acked-by: Olivier Matz Series applied, thanks

Re: [dpdk-dev] [PATCH v9 1/8] net/virtio: vring init for packed queues

2018-10-25 Thread Maxime Coquelin
On 10/25/18 3:48 PM, Jens Freimann wrote: On Thu, Oct 25, 2018 at 05:21:15PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:29PM +0200, Jens Freimann wrote: Add and initialize descriptor data structures. Signed-off-by: Jens Freimann ---  drivers/net/virtio/virtio_ethdev.c | 18 -

Re: [dpdk-dev] [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation routine

2018-10-25 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Tuesday, October 23, 2018 13:05 > To: Slava Ovsiienko > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation > routine > > On Mon, Oct 15, 2018 at 02:13:30PM +, Viacheslav Ovsiienko wr

Re: [dpdk-dev] [PATCH v9 4/8] net/virtio: dump packed virtqueue data

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:25:40PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:32PM +0200, Jens Freimann wrote: Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtqueue.h | 9

Re: [dpdk-dev] [PATCH v9 6/8] net/virtio: implement receive path for packed queues

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:39:09PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:34PM +0200, Jens Freimann wrote: Implement the receive part. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 18 +- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/vi

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

2018-10-25 Thread Thomas Monjalon
23/10/2018 11:20, Olivier Matz: > On Mon, Aug 27, 2018 at 06:08:35PM +0530, Jerin Jacob wrote: > > Add support for IGMP packet type. > > > > Signed-off-by: Jerin Jacob > > Acked-by: Olivier Matz Applied, thanks

Re: [dpdk-dev] [PATCH 3/4] eal: don't crash if alarm set fails

2018-10-25 Thread Burakov, Anatoly
On 25-Oct-18 12:51 AM, Thomas Monjalon wrote: 18/09/2018 12:16, Burakov, Anatoly: On 18-Sep-18 10:43 AM, Thomas Monjalon wrote: 26/07/2018 11:41, Burakov, Anatoly: On 25-Jul-18 7:20 PM, Stephen Hemminger wrote: There is no need to call rte_exit and crash the application here; better to let th

Re: [dpdk-dev] [PATCH] vdev: fix rte_mp_request_sync() memleak on scan

2018-10-25 Thread Thomas Monjalon
This patch was already sent, reviewed and applied. Why do you re-send it? 25/10/2018 12:47, Darek Stojaczyk: > rte_mp_request_sync() says that the caller is responsible > for freeing one of its parameters afterwards. vdev didn't > do that, causing a memory leak. > > Fixes: cdb068f031c6 ("bus/vdev

Re: [dpdk-dev] [PATCH] net/ixgbe_ipsec: prevent ic_session leak on failure

2018-10-25 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Radu Nicolau > Sent: Tuesday, October 16, 2018 6:32 AM > To: Varghese, Vipin ; Ananyev, Konstantin > ; dev@dpdk.org; Lu, Wenzhuo > > Subject: Re: [dpdk-dev] [PATCH] net/ixgbe_ipsec: prevent ic_session leak on > f

Re: [dpdk-dev] [PATCH] doc: add deprecated list in doxygen

2018-10-25 Thread Thomas Monjalon
18/10/2018 18:16, Ferruh Yigit: > On 10/18/2018 5:09 PM, Thomas Monjalon wrote: > > The option GENERATE_DEPRECATEDLIST will create a page > > "Deprecated List" in "Related Pages" menu. > > +1 > > Acked-by: Ferruh Yigit Applied

Re: [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine

2018-10-25 Thread Slava Ovsiienko
> -Original Message- > From: Yongseok Koh > Sent: Tuesday, October 23, 2018 13:06 > To: Slava Ovsiienko > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation > routine > > On Mon, Oct 15, 2018 at 02:13:31PM +, Viacheslav Ovsiienko w

Re: [dpdk-dev] [PATCH v9 3/8] net/virtio: add packed virtqueue helpers

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:23:53PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:31PM +0200, Jens Freimann wrote: Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 26 ++ 1 file cha

Re: [dpdk-dev] [PATCH v9 2/8] net/virtio: add packed virtqueue defines

2018-10-25 Thread Jens Freimann
On Thu, Oct 25, 2018 at 05:22:37PM +0800, Tiwei Bie wrote: On Wed, Oct 24, 2018 at 04:32:30PM +0200, Jens Freimann wrote: Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ring.h b

Re: [dpdk-dev] [PATCH] devtools: fix alignment of Marvell build options

2018-10-25 Thread Thomas Monjalon
18/10/2018 18:08, Ferruh Yigit: > On 10/18/2018 4:36 PM, Thomas Monjalon wrote: > > Really minor issue: > > There were extra spaces making the alignment wrong. > > > > Fixes: e95faac15110 ("crypto/mrvl: rename PMD to mvsam") > > Cc: t...@semihalf.com > > Fixes: 4ccc8d770d3b ("net/mvneta: add PMD s

Re: [dpdk-dev] [PATCH] devtools: add exception for OCTEON TX

2018-10-25 Thread Thomas Monjalon
10/10/2018 15:01, Anoob Joseph: > The 'TX' in OCTEON TX would cause a warning. Adding an exception for > that. > > OCTEON TX is a registered product under Cavium > > Signed-off-by: Anoob Joseph Applied, thanks

Re: [dpdk-dev] [PATCH] devtools: add git log checks for PHY

2018-10-25 Thread Thomas Monjalon
15/10/2018 16:53, Ferruh Yigit: > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-25 Thread Zhang, Qi Z
> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Thursday, October 25, 2018 4:51 AM > To: Zhang, Qi Z > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] bus/vdev: fix device argument corrupt after bus scan > > On Thu, Oct 25

Re: [dpdk-dev] [PATCH] bus/vdev: fix device argument corrupt after bus scan

2018-10-25 Thread Gaëtan Rivet
On Thu, Oct 25, 2018 at 02:56:55PM +, Zhang, Qi Z wrote: > > > > -Original Message- > > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > > Sent: Thursday, October 25, 2018 4:51 AM > > To: Zhang, Qi Z > > Cc: tho...@monjalon.net; dev@dpdk.org; sta...@dpdk.org > > Subject: Re: [PAT

[dpdk-dev] [PATCH v2 1/5] app/testpmd: check not detaching device twice

2018-10-25 Thread Thomas Monjalon
The command "port detach" is removing the EAL rte_device of the ethdev port specified as parameter. The function name and some comments are updated to make clear that we are detaching the whole device. After detaching, the pointer, which maps a port to its device, is reset. This way, it is possibl

[dpdk-dev] [PATCH v2 0/5] app/testpmd: improve attach/detach support

2018-10-25 Thread Thomas Monjalon
While working on EAL probe/remove and ethdev iterator/close, some scenarios appeared to not be managed by testpmd, especially because it was not designed for multi-ports devices: - configure dependent port (detected via event) - configuring twice (if already probed before) - detaching twice

[dpdk-dev] [PATCH v2 2/5] app/testpmd: merge ports list update functions

2018-10-25 Thread Thomas Monjalon
The arrays ports_ids and fwd_ports_ids require the same kind of update when some ports are removed or added. The functions update_fwd_ports() and remove_unused_fwd_ports() are merged in the new function remove_invalid_ports(). The part for adding new port is moved into setup_attached_port(). Sign

[dpdk-dev] [PATCH v2 3/5] app/testpmd: check not configuring port twice

2018-10-25 Thread Thomas Monjalon
It is possible to request probing of a device twice, and possibly get new ports for this device. However, the ports which were already probed and setup must not be setup again. That's why it is checked whether the port is already part of fwd_ports_ids array at the beginning of the function setup_at

[dpdk-dev] [PATCH v2 4/5] app/testpmd: move ethdev events registration

2018-10-25 Thread Thomas Monjalon
The callback for ethdev events was registered on port start, so it was missing some events. It is now registered at the beginning of the main function. Signed-off-by: Thomas Monjalon --- app/test-pmd/testpmd.c | 72 -- 1 file changed, 42 insertions(+), 30

Re: [dpdk-dev] [PATCH v2 9/9] doc/procinfo: add information for debug options

2018-10-25 Thread Varghese, Vipin
> - --stats-reset | --xstats-reset] > + --stats-reset | --xstats-reset --dbg-port | --dbg-tm | --dbg-crypto | > + --dbg-mempool[=name] | --dbg-ring[=name]] I have noticed that the word 'dbg' has not been updated to 'show'. I will send v3.

[dpdk-dev] [PATCH v2 5/5] app/testpmd: setup attached ports on probe event

2018-10-25 Thread Thomas Monjalon
After probing is done, each new port must be setup. The new ports are currently guessed by iterating on ports matching the devargs string used for probing. When probing a port, it is possible that one more port probing get triggered (e.g. PF is automatically probed when probing a VF representor).

  1   2   >