25/10/2018 10:54, Iremonger, Bernard: > Hi Thomas, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 24/10/2018 17:55, Iremonger, Bernard: > > > Hi Thomas, > > > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > +/* Pretty printing of ethdev events */ static const char * const > > > > +eth_event_desc[] = { > > > > + [RTE_ETH_EVENT_UNKNOWN] = "unknown", > > > > + [RTE_ETH_EVENT_INTR_LSC] = "LSC", > > > > > > How about replacing "LSC" with "interrupt link status change" > > > > When it is printed, "event" is appended. > > So I think "interrupt" is a bit too much. > > OK for "link state change"? > > Yes, > > > > > + [RTE_ETH_EVENT_QUEUE_STATE] = "queue state", > > > > + [RTE_ETH_EVENT_INTR_RESET] = "interrupt reset", > > Should "interrupt" be dropped from "interrupt reset" too for consistency?
Yes, you're right. > > > > + [RTE_ETH_EVENT_VF_MBOX] = "VF mbox", > > > > + [RTE_ETH_EVENT_IPSEC] = "IPsec", > > > > + [RTE_ETH_EVENT_MACSEC] = "MACsec", > > > > + [RTE_ETH_EVENT_INTR_RMV] = "device removal", > > > > > > How about replacing "device removal" with "interrupt device removal" > > > > For same reason, I think "device removal" is enough. > > It will be printed as "device removal event". I will send a v2 today. Thanks for the review.
