[dpdk-dev] [dpdk-announce] Reminder: DPDK North America CFP closes this week

2018-10-23 Thread Trishan de Lanerolle
With the community in the midst of 18.11 release cycle, we have extended the CFP for DPDK North America until the end of the week, *Friday, October 26th.* If you’re planning to submit a proposal you have less than 5 days to do so. You can submit proposals at: https://events.linuxfoundation.org/eve

Re: [dpdk-dev] [PATCH] net/i40e: cancel alarm handler at the end of device closure

2018-10-23 Thread Xing, Beilei
> -Original Message- > From: Ye, Xiaolong > Sent: Tuesday, October 23, 2018 8:54 AM > To: Zhang, Qi Z ; Xing, Beilei > Cc: dev@dpdk.org; Ye, Xiaolong ; sta...@dpdk.org > Subject: [PATCH] net/i40e: cancel alarm handler at the end of device closure > > Some operations in i40evf_dev_close

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Shreyansh Jain
Besides the comment I sent before about 'Fixes' before sign-off, a single trivial comment inline ... On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: > This patch fixes rte_eal_hotplug_add without checking return value issue > > Signed-off-by: Rosen Xu > Fixes: ef1e8ede3da5 ("raw/ifpga: add

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-23 Thread Thomas Monjalon
22/10/2018 23:24, Ananyev, Konstantin: > From: Thomas Monjalon > > 22/10/2018 15:37, Andrew Rybchenko: > > > On 10/22/18 4:15 PM, Thomas Monjalon wrote: > > > > The MAC addresses of a port can be matched with devargs. > > > > > > > > As the conflict between rte_ether.h and netinet/ether.h is not re

Re: [dpdk-dev] [PATCH v2] ethdev: fix device info getting

2018-10-23 Thread Thomas Monjalon
23/10/2018 03:25, Lu, Wenzhuo: > Hi Thomas, Ferruh, Andrew, > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 22/10/2018 14:01, Ferruh Yigit: > > > On 8/23/2018 9:58 AM, Andrew Rybchenko wrote: > > > > On 22.08.2018 19:55, Ferruh Yigit wrote: > > > >> On 8/14/2018 1:57 AM, Lu, Wenzhuo wro

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-10-23 Thread Thomas Monjalon
Hi, 23/10/2018 03:52, Hideyuki Yamashita: > Hi, > > Thanks for your guidance again. > > Q1. > Is following my understanding correct? > If a device has multiple port, then "rte_eth_dev_get_port_by_name" > will NOT work becauase it uses strcmp and needs "exact match" > of the device name. > New it

[dpdk-dev] [PATCH] test/test_external_mem: fix loop initialization

2018-10-23 Thread Ali Alnubani
Loop initial declarations are only allowed in C99 mode, which causes a compilation failure on non C99 compliant systems: test/test/test_external_mem.c: In function ‘test_external_mem’: test/test/test_external_mem.c:375:2: error: ‘for’ loop initial declarations are only allowed in C99 mode for (i

Re: [dpdk-dev] [PATCH 4/5] net/mlx5: fix wildcard item for Direct Verbs

2018-10-23 Thread Shahaf Shuler
Wednesday, October 17, 2018 5:08 AM, Yongseok Koh: > Subject: [PATCH 4/5] net/mlx5: fix wildcard item for Direct Verbs > > If a network layer is specified with no spec, it means wildcard match. > flow_dv_translate_item_*() returns without writing anything if spec is null > and it causes creation o

Re: [dpdk-dev] [PATCH 1/2] mbuf: add FCoE packet type

2018-10-23 Thread Olivier Matz
On Sun, Aug 26, 2018 at 06:24:54PM +0530, Jerin Jacob wrote: > Add support of FCoE packet type. > > Signed-off-by: Jerin Jacob Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH 2/2] mbuf: add MPLS packet type

2018-10-23 Thread Olivier Matz
On Sun, Aug 26, 2018 at 06:24:55PM +0530, Jerin Jacob wrote: > Add support of MPLS packet type. > > Signed-off-by: Jerin Jacob Acked-by: Olivier Matz

[dpdk-dev] [PATCH 2/2] net: support Mpls in software packet type parser

2018-10-23 Thread Olivier Matz
Add a new RTE_PTYPE_L2_ETHER_MPLS packet type, and its support in rte_net_get_ptype(). Signed-off-by: Didier Pallard Signed-off-by: Olivier Matz --- lib/librte_mbuf/rte_mbuf_ptype.h | 7 +++ lib/librte_net/rte_ether.h | 2 ++ lib/librte_net/rte_net.c | 21 +++

[dpdk-dev] [PATCH 1/2] net: add Mpls header structure

2018-10-23 Thread Olivier Matz
Add the Mpls header structure in librte_net. It will be used by next patch that adds the support of Mpls L2 layer in the software packet type parser. Signed-off-by: Olivier Matz --- lib/librte_net/Makefile| 2 +- lib/librte_net/meson.build | 3 ++- lib/librte_net/rte_mpls.h | 42 +

Re: [dpdk-dev] [PATCH 2/2] mbuf: add MPLS packet type

2018-10-23 Thread Olivier Matz
On Tue, Oct 23, 2018 at 09:45:33AM +0200, Olivier Matz wrote: > On Sun, Aug 26, 2018 at 06:24:55PM +0530, Jerin Jacob wrote: > > Add support of MPLS packet type. > > > > Signed-off-by: Jerin Jacob > > Acked-by: Olivier Matz By the way, I've just submitted an implementation of the software pars

Re: [dpdk-dev] [PATCH] vhost: fix vector filling for packed ring

2018-10-23 Thread Maxime Coquelin
Hi Tiwei, On 10/23/2018 08:07 AM, Tiwei Bie wrote: We should return the length of the buffers described by the current descriptor chain after filling the buffer vector. So we need to zero the *len first. Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring") Cc: sta...@dpdk.o

[dpdk-dev] DPDK techboard minutes of October 10

2018-10-23 Thread Hemant Agrawal
Meeting notes for the DPDK technical board meeting held on 2018-10-10 Attendees: - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Konstantin Ananyev - Maxime Coquelin - Olivier Matz - Stephen Hemminger - Thom

[dpdk-dev] [PATCH v7 4/7] doc: replace doxygen example in contribution guide

2018-10-23 Thread Thomas Monjalon
The provided example of doxygen header is about a deprecated function. It is replaced by rte_spinlock_trylock() which is small and good enough for the purpose. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/contributing/documentation.rst | 15 +-- 1 file

[dpdk-dev] [PATCH v7 3/7] ethdev: allow iterating with pure class filter

2018-10-23 Thread Thomas Monjalon
If no rte_device is given in the iterator, eth_dev_match() is looking at all ports without any restriction, except the ethdev kvargs filter. It allows to iterate with a devargs filter referencing only some ethdev parameters. The format (from the new devargs syntax) is: class=eth,paramY=Y

[dpdk-dev] [PATCH v7 1/7] bus/vdev: add iteration filter on name

2018-10-23 Thread Thomas Monjalon
A virtual device can be matched with following syntax: bus=vdev,name=X Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- drivers/bus/vdev/vdev_params.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_params.c

[dpdk-dev] [PATCH v7 0/7] replace attach/detach functions

2018-10-23 Thread Thomas Monjalon
The functions for EAL attach/detach had already some replacements, so they are removed. The functions for ethdev attach/detach are removed and replaced thanks to a new ethdev iterator working with devargs. rte_eth_dev_attach(devargs, &port_id) is replaced by: rte_dev_probe(devargs); RT

[dpdk-dev] [PATCH v7 2/7] ethdev: add iterator to match devargs input

2018-10-23 Thread Thomas Monjalon
The iterator will return the ethdev port ids matching a devargs string. It is recommended to use the macro RTE_ETH_FOREACH_MATCHING_DEV() for usage convenience. The class string is prefixed with '+' in order to skip the validation of the parameter keys. It is tolerated for the compatibility with t

[dpdk-dev] [PATCH v7 5/7] ethdev: remove deprecated attach/detach functions

2018-10-23 Thread Thomas Monjalon
The hotplug attach/detach features are implemented in EAL layer. There is a new ethdev iterator to retrieve ports from ethdev layer. As announced earlier, the (buggy) ethdev functions are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Thomas Monjalon
The command "port detach" is removing the EAL rte_device of the ethdev port specified as parameter. After detaching, the pointer, which maps a port to its device, is resetted. This way, it is possible to check whether a port is still associated to a (not removed) device. Signed-off-by: Thomas Mon

[dpdk-dev] [PATCH v7 6/7] eal: remove deprecated attach/detach functions

2018-10-23 Thread Thomas Monjalon
These hotplug functions were deprecated and have some new replacements. As announced earlier, the oldest ones are now removed. Signed-off-by: Thomas Monjalon Reviewed-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst| 5 --- doc/guides/rel_notes/release_18_11.rst | 6 +++ lib

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-23 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, October 23, 2018 8:21 AM > To: Ananyev, Konstantin > Cc: Andrew Rybchenko ; dev@dpdk.org; > gaetan.ri...@6wind.com; ophi...@mellanox.com; Yigit, Ferruh > ; olivier.m...@6wind.com; Horton, Remy >

Re: [dpdk-dev] Change ether_addr to avoid conflict

2018-10-23 Thread Thomas Monjalon
22/10/2018 17:06, Wiles, Keith: > > > On Oct 21, 2018, at 8:39 AM, Lewis Donzis wrote: > > > > Please consider changing “struct ether_addr” in rte_ether.h to “struct > > rte_ether_addr”, in order to avoid conflicts with the same structure name > > /usr/include/net/ethernet.h. > > > > This is

Re: [dpdk-dev] [PATCH v5 4/4] net/mlx5: support e-switch flow count action

2018-10-23 Thread Ferruh Yigit
On 10/22/2018 9:10 PM, Shahaf Shuler wrote: > Ferruh, > > Monday, October 22, 2018 12:15 PM, Ferruh Yigit: >> Subject: Re: [dpdk-dev] [PATCH v5 4/4] net/mlx5: support e-switch flow >> count action >> >> Getting following build error with clang, will not pull from mlx tree until >> issue >> resolv

Re: [dpdk-dev] [PATCH v6 05/13] telemetry: add client feature and sockets

2018-10-23 Thread Laatz, Kevin
Thanks for the review Mattias. Will address the comments both here and in the 4/13 review. Best regards, Kevin On 22/10/2018 15:05, Mattias Rönnblom wrote: On 2018-10-22 13:00, Kevin Laatz wrote:   @@ -131,6 +217,38 @@ rte_telemetry_initial_accept(struct telemetry_impl *telemetry)   }  

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-23 Thread Joseph, Anoob
Hi Thomas, I had replaced macro with functions when I revised the patch. But when more devices (with varying capabilities) need to be supported, this can get complicated. Macro approach would be simpler in that case. Right now QAT has macros and we would like to stick to what is being followed

[dpdk-dev] [PATCH] devtools: disable coloring of git-log output

2018-10-23 Thread Ali Alnubani
Colored git-log outputs will have escape characters appended to hashes, causing check-git-log.sh to fail with `error: malformed object name ?[33m?[m` when doing `git tag -l --contains `. Signed-off-by: Ali Alnubani --- devtools/git-log-fixes.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [dpdk-dev] [PATCH v8 1/4] hash: fix race condition in iterate

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:39:45AM -0700, Yipeng Wang wrote: > In rte_hash_iterate, the reader lock did not protect the > while loop which checks empty entry. This created a race > condition that the entry may become empty when enters > the lock, then a wrong key data value would be read out. > >

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter

2018-10-23 Thread Thomas Monjalon
23/10/2018 10:33, Ananyev, Konstantin: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 22/10/2018 23:24, Ananyev, Konstantin: > > > From: Thomas Monjalon > > > > 22/10/2018 15:37, Andrew Rybchenko: > > > > > On 10/22/18 4:15 PM, Thomas Monjalon wrote: > > > > > > The MAC addresses of a por

Re: [dpdk-dev] [PATCH v8 2/4] hash: add extendable bucket feature

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:39:46AM -0700, Yipeng Wang wrote: > In use cases that hash table capacity needs to be guaranteed, > the extendable bucket feature can be used to contain extra > keys in linked lists when conflict happens. This is similar > concept to the extendable bucket hash table in pa

Re: [dpdk-dev] [dpdk-users] IPV4/IPV6 TCP/UDP Pseudo Header Checksum APIs

2018-10-23 Thread Olivier Matz
Hi, You are right, the current code does not take IP or IPv6 options in account. I think this should be considered as a bug. The fix for IPv4 is not complicated, I did a quick draft here: http://git.droids-corp.org/?p=dpdk.git;a=commitdiff;h=96a6978ef6814e1450e1bd65fbce91c3d85b3121 For IPv6, it

Re: [dpdk-dev] [PATCH v2 09/33] crypto/octeontx: adds symmetric capabilities

2018-10-23 Thread Thomas Monjalon
23/10/2018 10:48, Joseph, Anoob: > From: Thomas Monjalon > > 22/10/2018 05:49, Joseph, Anoob: > > > Hi Fiona, > > > > > > I do agree that your solution seems to be a neat way for organizing > > capabilities. But Akhil & Thomas were against that idea and we had to come > > up > > with one array wi

Re: [dpdk-dev] [PATCH v8 3/4] test/hash: implement extendable bucket hash test

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:39:47AM -0700, Yipeng Wang wrote: > This commit changes the current rte_hash unit test to > test the extendable table feature and performance. > > Signed-off-by: Yipeng Wang > Reviewed-by: Honnappa Nagarahalli > Acked-by: Dharmik Thakkar > --- Acked-by: Bruce Richards

Re: [dpdk-dev] [PATCH] test/test_external_mem: fix loop initialization

2018-10-23 Thread Thomas Monjalon
23/10/2018 09:35, Ali Alnubani: > Loop initial declarations are only allowed in C99 mode, > which causes a compilation failure on non C99 compliant systems: > > test/test/test_external_mem.c: In function ‘test_external_mem’: > test/test/test_external_mem.c:375:2: error: ‘for’ > loop initial declar

Re: [dpdk-dev] [PATCH v8 4/4] hash: use partial-key hashing

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:39:48AM -0700, Yipeng Wang wrote: > This commit changes the hashing mechanism to "partial-key > hashing" to calculate bucket index and signature of key. > > This is proposed in Bin Fan, et al's paper > "MemC3: Compact and Concurrent MemCache with Dumber Caching > and Sm

Re: [dpdk-dev] [PATCH] test: fix compilation error in external memory test

2018-10-23 Thread Thomas Monjalon
17/10/2018 12:12, Burakov, Anatoly: > On 17-Oct-18 1:22 AM, Dan Gora wrote: > > Fix a compilation error in test_external_mem.c: > > > >CC test_external_mem.o > > test_external_mem.c: In function ‘test_external_mem’: > > test_external_mem.c:375:2: error: ‘for’ loop initial declarations are > >

Re: [dpdk-dev] [PATCH] mbuf: add IGMP packet type

2018-10-23 Thread Olivier Matz
On Mon, Aug 27, 2018 at 06:08:35PM +0530, Jerin Jacob wrote: > Add support for IGMP packet type. > > Signed-off-by: Jerin Jacob Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH] mem: fix resource leak

2018-10-23 Thread Thomas Monjalon
22/10/2018 22:34, Thomas Monjalon: > 22/10/2018 14:57, Anatoly Burakov: > > Segment preallocation code allocates an array of structures on the > > heap but does not free the memory afterwards. Fix it by freeing it > > at the end of the function, and changing control flow to always go > > through th

Re: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS

2018-10-23 Thread Zhao1, Wei
Hi, Iremonger Bernard > -Original Message- > From: Iremonger, Bernard > Sent: Monday, October 22, 2018 6:45 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: support more types for flow > RSS >

Re: [dpdk-dev] [PATCH] vhost: fix vector filling for packed ring

2018-10-23 Thread Maxime Coquelin
On 10/23/2018 08:07 AM, Tiwei Bie wrote: We should return the length of the buffers described by the current descriptor chain after filling the buffer vector. So we need to zero the *len first. Fixes: 2f3225a7d69b ("vhost: add vector filling support for packed ring") Cc: sta...@dpdk.org Sign

Re: [dpdk-dev] [PATCH v2] vhost/crypto: fix build without cryptodev (shared lib)

2018-10-23 Thread Maxime Coquelin
On 10/16/2018 10:47 PM, Timothy Redaelli wrote: Currently it's not possible to build DPDK as shared library with cryptodev disabled since vhost is trying to link with rte_crypto, but rte_crypto and rte_hash are only needed when you build vhost_crypto and so only when cryptodev is enabled. Thi

Re: [dpdk-dev] [PATCH v2 1/3] common/dpaax: reduce logging level

2018-10-23 Thread Jerin Jacob
-Original Message- > Date: Wed, 17 Oct 2018 10:10:34 + > From: Shreyansh Jain > To: "tho...@monjalon.net" > CC: "dev@dpdk.org" , Shreyansh Jain > Subject: [dpdk-dev] [PATCH v2 1/3] common/dpaax: reduce logging level > x-mailer: git-send-email 2.17.1 > > > DPAAX is a library used by

[dpdk-dev] [PATCH v2] app/testpmd: support more types for flow RSS

2018-10-23 Thread Wei Zhao
Some user and tester require flow RSS to support more types, so add "all" and "none" to make configuration more easy for users. Tested-by: Peng Yuan Signed-off-by: Wei Zhao --- v2: -fix typo in commit message. --- app/test-pmd/config.c | 4 1 file changed, 4 insertions(+) diff --git a/a

Re: [dpdk-dev] [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table errors

2018-10-23 Thread Jerin Jacob
-Original Message- > Date: Wed, 17 Oct 2018 10:10:36 + > From: Shreyansh Jain > To: "tho...@monjalon.net" > CC: "dev@dpdk.org" , Shreyansh Jain > Subject: [dpdk-dev] [PATCH v2 2/3] bus/fslmc: ignore dpaax pa-va table > errors > x-mailer: git-send-email 2.17.1 > > > Presence of PA-

Re: [dpdk-dev] [PATCH v2] app/testpmd: support more types for flow RSS

2018-10-23 Thread Zhao1, Wei
Add Bernard into mailing list. > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, October 23, 2018 5:21 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: [PATCH v2] app/testpmd: support more types for flow RSS > > Some user and tester

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 8:09 AM, Shreyansh Jain wrote: > Besides the comment I sent before about 'Fixes' before sign-off, a > single trivial comment inline ... > > On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: >> This patch fixes rte_eal_hotplug_add without checking return value issue >> >> Signed-o

Re: [dpdk-dev] [PATCH v6 2/3] app/testpmd: add MPLSoUDP encapsulation

2018-10-23 Thread Ferruh Yigit
On 10/22/2018 6:38 PM, Ori Kam wrote: > MPLSoUDP is an example for L3 tunnel encapsulation. > > L3 tunnel type is a tunnel that is missing the layer 2 header of the > inner packet. > > Example for MPLSoUDP tunnel: > ETH / IPV4 / UDP / MPLS / IP / L4..L7 > > In order to encapsulate such a tunnel

Re: [dpdk-dev] [PATCH v6 3/3] app/testpmd: add MPLSoGRE encapsulation

2018-10-23 Thread Ferruh Yigit
On 10/22/2018 6:38 PM, Ori Kam wrote: > Example for MPLSoGRE tunnel: > ETH / IPV4 / GRE / MPLS / IP / L4..L7 > > In order to encapsulate such a tunnel there is a need to remove L2 of > the inner packet and encap the remaining tunnel, this is done by > applying 2 rte flow commands l2_decap followed

Re: [dpdk-dev] [PATCH v6 0/3] ethdev: add generic raw tunnel encapsulation

2018-10-23 Thread Ferruh Yigit
On 10/22/2018 6:38 PM, Ori Kam wrote: > This series implement the raw tunnel encapsulation actions > and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions" > > Currenlty the encap/decap actions only support encapsulation > of VXLAN and NVGRE L2 packets (L2 encapsulation is where

Re: [dpdk-dev] Memory allocation in dpdk at basic level

2018-10-23 Thread Burakov, Anatoly
On 22-Oct-18 10:08 PM, Avinash Chaurasia wrote: Hello, I am not sure whether this is right list for posting this problem. I am trying to understand how dpdk allocate memory. I tried digging code to understand memory allocation of DPDK. So far I understood that memory is allocated from a heap that

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Iremonger, Bernard
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, October 23, 2018 9:29 AM > To: dev@dpdk.org > Cc: gaetan.ri...@6wind.com; ophi...@mellanox.com; > wis...@mellanox.com; Yigit, Ferruh ; > arybche...@solarflare.com; Iremonger, Bernard > >

Re: [dpdk-dev] [PATCH v2 1/7] net/mlx5: e-switch VXLAN configuration and definitions

2018-10-23 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:29PM +, Viacheslav Ovsiienko wrote: > This part of patchset adds configuration changes in makefile and > meson.build for Mellanox MLX5 PMD. Also necessary defenitions > for VXLAN support are made and appropriate data structures > are presented. > > Suggested-by: A

[dpdk-dev] net/mlx5: flow counters support for Linux-rdma v19

2018-10-23 Thread Slava Ovsiienko
Mellanox mlx5 PMD supports Flow counters via Verbs library. The current implementation is based on the Mellanox proprietary Verbs library included in MLNX OFED packages. The Flow counter support is recently added into linux-rdma release (v19), so the mlx5 PMD update is needed to provide Counter fea

[dpdk-dev] [PATCH v4 2/8] net/mlx5: rename flow counter configuration macro

2018-10-23 Thread Slava Ovsiienko
The HAVE_IBV_DEVICE_COUNTERS_SET_SUPPORT is replaced with HAVE_IBV_DEVICE_COUNTERS_SET_V42. At this stage it is just macro renaming. This macro is defined if system supports the "old" Flow counters functionality, MLNX_OFED version from 4.2 to 4.4 is required. We need to do this preparation before

[dpdk-dev] [PATCH v4 7/8] net/mlx5: remove unnecessary structure initializers

2018-10-23 Thread Slava Ovsiienko
The unnecessary structure filed initializers to zero are removed. We need to do this minor preparation before the following mlx5 counter structure modification. Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_tcf.c | 5 - 1 file changed, 5 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v4 5/8] net/mlx5: relocate flow counters query function

2018-10-23 Thread Slava Ovsiienko
The flow_verbs_query_count() is moved into the the group of counter managing functions and renamed to flow_verbs_counter_query() in order to be in unified fashion with others. Also minor function modification is made to avoid unreachable code warnings if there is no counter support at compile time

[dpdk-dev] [PATCH v4 1/8] net/mlx5: fix flow counters creation

2018-10-23 Thread Slava Ovsiienko
The Flow counter creation function contains two problems: - Flow counter object in Verbs is not freed in case of memory allocation error. The call of counter Verbs object deallocating function is added to fix. - The initial value of reference counter is set to one in order to prov

[dpdk-dev] [PATCH v4 3/8] net/mlx5: introduce new flow counters configuration macro

2018-10-23 Thread Slava Ovsiienko
The new configuration macro HAVE_IBV_DEVICE_COUNTERS_SET_V45 is introduced. Both makefile and meson.build are changed. Flow counter support code depends on the following configuration macros: - HAVE_IBV_DEVICE_COUNTERS_SET_V42 - is defined if system supports the "old" flow counters functionalit

[dpdk-dev] [PATCH v4 4/8] net/mlx5: simplify flow counters support check

2018-10-23 Thread Slava Ovsiienko
The redundant check of Flow counters support in runtime is removed. The flag flow_counter_en is eliminated from the code. The Verbs create counter function just returns an error if no counter support presented in the system. If there is no any of Flow counters configuration macro defined the log m

Re: [dpdk-dev] [PATCH v2 2/7] net/mlx5: e-switch VXLAN flow validation routine

2018-10-23 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:30PM +, Viacheslav Ovsiienko wrote: > This part of patchset adds support for flow item/action lists > validation. The following entities are now supported: > > - RTE_FLOW_ITEM_TYPE_VXLAN, contains the tunnel VNI > > - RTE_FLOW_ACTION_TYPE_VXLAN_DECAP, if this act

[dpdk-dev] [PATCH v4 8/8] net/mlx5: support new flow counter API

2018-10-23 Thread Slava Ovsiienko
This patch updates the functions performing the Verbs ibrary calls in order to support different versions of the library. The functions: - flow_verbs_counter_new() - flow_verbs_counter_release() - flow_verbs_counter_query() now have the several compilation branches, depending on the counters

[dpdk-dev] [PATCH v4 6/8] net/mlx5: add new flow counter Verbs API to glue library

2018-10-23 Thread Slava Ovsiienko
This patch updates the mlx5 glue library, new counter support Verbs function pointers are added to the glue linking structure mlx5_glue. This structure now contains the pointers to the both versions of counter supporting functions due to compatibility issues. Depending on configuration macros the f

Re: [dpdk-dev] [PATCH v2 3/7] net/mlx5: e-switch VXLAN flow translation routine

2018-10-23 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:31PM +, Viacheslav Ovsiienko wrote: > This part of patchset adds support of VXLAN-related items and > actions to the flow translation routine. If some of them are > specified in the rule, the extra space for tunnel description > structure is allocated. Later some t

Re: [dpdk-dev] [PATCH v2 4/7] net/mlx5: e-switch VXLAN netlink routines update

2018-10-23 Thread Yongseok Koh
On Mon, Oct 15, 2018 at 02:13:32PM +, Viacheslav Ovsiienko wrote: > This part of patchset updates Netlink exchange routine. Message > sequence numbers became not random ones, the multipart reply messages > are supported, not propagating errors to the following socket calls, > Netlink replies bu

[dpdk-dev] [PATCH v2] vhost: avoid memory barriers when no descriptors dequeued

2018-10-23 Thread Maxime Coquelin
In both split and packed dequeue paths, flush_shadow_used_ring and vhost_ring_call variants gets called even if not packets have been dequeued, and so no descriptors updates happened. It has an impact on CPU pipeline, as memory barriers are used in these functions. This patch don't call these fun

Re: [dpdk-dev] [PATCH v2] app/testpmd: support more types for flow RSS

2018-10-23 Thread Iremonger, Bernard
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wei Zhao > Sent: Tuesday, October 23, 2018 10:21 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; sta...@dpdk.org; Peng, Yuan > ; Zhao1, Wei > Subject: [dpdk-dev] [PATCH v2] app/testpmd: support more types for flow > RSS

Re: [dpdk-dev] [PATCH v5 1/5] hash: separate multi-writer from rw-concurrency

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:00PM -0500, Honnappa Nagarahalli wrote: > RW concurrency is required with single writer and multiple reader > usecase as well. Hence, multi-writer should not be enabled by default when > RW concurrency is enabled. > > Fixes: f2e3001b53ec ("hash: support read/write con

Re: [dpdk-dev] [PATCH v5 2/5] hash: support do not free on delete

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:01PM -0500, Honnappa Nagarahalli wrote: > rte_hash_lookup_xxx APIs return the index of slot in > the key store. Application(reader) can use that index to reference > other data structures in its scope. Because of this, the > index should not be freed till the applicati

Re: [dpdk-dev] [PATCH v5 3/5] hash: fix key store element alignment

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:02PM -0500, Honnappa Nagarahalli wrote: > Fix the key store array element alignment such that every array > element is aligned on KEY_ALIGNMENT boundary. This is required to > make 'pdata' in 'struct rte_hash_key' align on its natural boundary > for atomic load/store.

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Shreyansh Jain
On Tuesday 23 October 2018 03:21 PM, Ferruh Yigit wrote: > On 10/23/2018 8:09 AM, Shreyansh Jain wrote: >> Besides the comment I sent before about 'Fixes' before sign-off, a >> single trivial comment inline ... >> >> On Tuesday 23 October 2018 07:20 AM, Rosen Xu wrote: >>> This patch fixes rte_eal_

Re: [dpdk-dev] [dpdk-users] IPV4/IPV6 TCP/UDP Pseudo Header Checksum APIs

2018-10-23 Thread Shyam Shrivastav
These fixes/modifications should include the upper level APIs, rte_ipv4_udptcp_cksum and rte_ipv6_udptcp_cksum. Even for ipv4 following API is more/really useful if changed to take mbufs rte_ipv4_udptcp_cksum(const struct ipv4_hdr *ipv4_hdr, const void *l4_hdr) I can not use it in present form a

[dpdk-dev] [PATCH v6] net/mlx5: support metadata as flow rule criteria

2018-10-23 Thread Dekel Peled
As described in series starting at [1], it adds option to set metadata value as match pattern when creating a new flow rule. This patch adds metadata support in mlx5 driver, in two parts: - Add the validation and setting of metadata value in matcher, when creating a new flow rule. - Add the pass

[dpdk-dev] [PATCH v3 1/5] test: remove existing testcases for categorization

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Removed testcase list from meson build to categorize testcases into suites Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 111 -- 1 file changed, 111 deletions(-) diff --git a/test/test/meson.build b/test/te

[dpdk-dev] [PATCH v3 2/5] test: add quick run tests under test-fast suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Added test cases that runs quickly under test fast category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 99 --- 1 file changed, 94 insertions(+), 5 deletions(-) diff --git a/test/test/meson.build b/test/t

[dpdk-dev] [PATCH v3 3/5] test: add performance tests under test-perf suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Grouped performace test cases under test-perf category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 34 ++ 1 file changed, 34 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 825e84fce..70a4c

[dpdk-dev] [PATCH v3 0/5] create different meson test targets

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula 1/5: remove existing test cases to reorganize further 2/5: add test-fast suite to meson targets 3/5: add test-perf suite to meson targets 4/5: add test-driver suite to meson targets 5/5: add test-dump suite to meson targets -- v3: Updated testcase names in file prefix opt

[dpdk-dev] [PATCH v3 4/5] test: add library dependent tests under test-driver suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Added test cases that depend on library as cryptodev Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 27 +++ 1 file changed, 27 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index 70a4c6bed..a727cf461 1006

[dpdk-dev] [PATCH v3 5/5] test: add dump test cases under test-dump suite

2018-10-23 Thread Hari kumar Vemula
From: Hari Kumar Vemula Grouped logging or dump related test cases to test-dump category Signed-off-by: Hari Kumar Vemula --- test/test/meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/test/test/meson.build b/test/test/meson.build index a727cf461..9132ad0c

Re: [dpdk-dev] [PATCH v5 4/5] hash: add lock-free read-write concurrency

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:03PM -0500, Honnappa Nagarahalli wrote: > Add lock-free read-write concurrency. This is achieved by the > following changes. > > 1) Add memory ordering to avoid race conditions. The only race > condition that can occur is - using the key store element > before the ke

Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:04PM -0500, Honnappa Nagarahalli wrote: > From: Dharmik Thakkar > > Unit tests to check for hash lookup and bulk-lookup perf > with lock-free enabled and with lock-free disabled. > Unit tests performed with readers running in parallel with writers. > > Tests include

Re: [dpdk-dev] [PATCH v5 5/5] test/hash: read-write lock-free concurrency test

2018-10-23 Thread Bruce Richardson
On Mon, Oct 22, 2018 at 11:22:04PM -0500, Honnappa Nagarahalli wrote: > From: Dharmik Thakkar > > Unit tests to check for hash lookup and bulk-lookup perf > with lock-free enabled and with lock-free disabled. > Unit tests performed with readers running in parallel with writers. > > Tests include

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Thomas Monjalon
23/10/2018 12:01, Iremonger, Bernard: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > The command "port detach" is removing the EAL rte_device of the ethdev > > port specified as parameter. > > > > After detaching, the pointer, which maps a port to its device, is resetted. > > This > >

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Thomas Monjalon
23/10/2018 14:03, Thomas Monjalon: > 23/10/2018 12:01, Iremonger, Bernard: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > The command "port detach" is removing the EAL rte_device of the ethdev > > > port specified as parameter. > > > > > > After detaching, the pointer, which maps a p

Re: [dpdk-dev] [PATCH] drivers/raw/ifpga_rawdev: fix coverity issue 323508

2018-10-23 Thread Ferruh Yigit
On 10/23/2018 11:43 AM, Shreyansh Jain wrote: > On Tuesday 23 October 2018 03:21 PM, Ferruh Yigit wrote: >> On 10/23/2018 8:09 AM, Shreyansh Jain wrote: >>> Besides the comment I sent before about 'Fixes' before sign-off, a >>> single trivial comment inline ... >>> >>> On Tuesday 23 October 2018 07

Re: [dpdk-dev] [PATCH v6] net/mlx5: support metadata as flow rule criteria

2018-10-23 Thread Shahaf Shuler
Tuesday, October 23, 2018 1:48 PM, Dekel Peled: > Subject: [PATCH v6] net/mlx5: support metadata as flow rule criteria > > As described in series starting at [1], it adds option to set metadata value > as > match pattern when creating a new flow rule. > > This patch adds metadata support in mlx5

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Thomas Monjalon
I want to submit two more patches to clean testpmd for attach/detach. I propose to drop this patch from this series, and I will submit a new series dedicated to testpmd cleanup, including this patch. 23/10/2018 14:13, Thomas Monjalon: > 23/10/2018 14:03, Thomas Monjalon: > > 23/10/2018 12:01, Ir

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: avoid memory barriers when no descriptors dequeued

2018-10-23 Thread Jens Freimann
On Tue, Oct 23, 2018 at 12:07:10PM +0200, Maxime Coquelin wrote: In both split and packed dequeue paths, flush_shadow_used_ring and vhost_ring_call variants gets called even if not packets have been dequeued, and so no descriptors updates happened. It has an impact on CPU pipeline, as memory bar

Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching device twice

2018-10-23 Thread Iremonger, Bernard
Hi Thomas > Subject: Re: [dpdk-dev] [PATCH v7 7/7] app/testpmd: check not detaching > device twice > > 23/10/2018 14:03, Thomas Monjalon: > > 23/10/2018 12:01, Iremonger, Bernard: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > The command "port detach" is removing the EAL rte_d

[dpdk-dev] [PATCH] crypto/caam_jr: fix redefinition error

2018-10-23 Thread Gagandeep Singh
dma_addr_t is already defined in compat.h. so removing the local definition from caam_jr_config.h Fixes: b70a67ab70 ("crypto/caam_jr: add HW tuning options") Signed-off-by: Gagandeep Singh --- drivers/crypto/caam_jr/caam_jr_config.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[dpdk-dev] [PATCH] drivers: fix compilation if security disabled

2018-10-23 Thread Akhil Goyal
RTE_SECURITY is enabled by default. If it is disabled, dpaa2_sec, dpaa_sec and caam_jr compilation fails. This patch fixes compilation by disabling these drivers when rte_security is not available. Fixes: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") Fixes: 09e1e8d256b0 ("mk: fi

Re: [dpdk-dev] [PATCH v3 2/5] test: add quick run tests under test-fast suite

2018-10-23 Thread Pattan, Reshma
Hi, > -Original Message- > From: Vemula, Hari KumarX > Sent: Tuesday, October 23, 2018 12:01 PM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Pattan, Reshma > ; Vemula, Hari KumarX > > Subject: [PATCH v3 2/5] test: add quick run tests under test-fast suite > > From: Hari Kumar Vemula >

[dpdk-dev] [PATCH 1/2] app/testpmd: fix metadata API and Tx insertion

2018-10-23 Thread Dekel Peled
Previous patch introduces the Tx metadata feature, with unnecessary restrictions on data entry. It also used the metadata in txonly fwd engine only. This fix removes the data entry restrictions on metadata item. It also implements callback function to add the metadata in every Tx packet, sent by a

[dpdk-dev] [PATCH 2/2] ethdev: fix metadata documentation

2018-10-23 Thread Dekel Peled
Previous patch introduced the Tx metadata feature, with unnecessary restrictions on data entry. This fix updates the documentation, removing the data entry restrictions on metadata item. Fixes: aa0b9484eb5f ("ethdev: support metadata as flow rule criteria") Cc: dek...@mellanox.com Signed-off-by:

[dpdk-dev] [PATCH v1 1/9] app/procinfo: add usage for new debug

2018-10-23 Thread Vipin Varghese
Update the file with MACRO for stats border, usage text information and string comparision. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index c20effa4f..928

[dpdk-dev] [PATCH v1 2/9] app/procinfo: add compare for new options

2018-10-23 Thread Vipin Varghese
Add code for new debug options to compare usage strings and set enable flag. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 92854f5ba..5505d3fe3 100644 --

[dpdk-dev] [PATCH v1 3/9] app/procinfo: add prototype for debug instances

2018-10-23 Thread Vipin Varghese
Add prototype and function calls for the debug functions. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 5505d3fe3..5511fcb71 100644 --- a/app/

[dpdk-dev] [PATCH v1 6/9] app/procinfo: add code for debug crypto

2018-10-23 Thread Vipin Varghese
Function debug_crypto is used for displaying the crypto PMD under the primary process. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 70 +++- 1 file changed, 69 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main

[dpdk-dev] [PATCH v1 4/9] app/procinfo: add code for debug port

2018-10-23 Thread Vipin Varghese
Function debug_port is used for displaying the port PMD under the primary process. This covers basic and per queue configuration. Signed-off-by: Vipin Varghese --- app/proc-info/main.c | 113 ++- 1 file changed, 112 insertions(+), 1 deletion(-) diff --git

  1   2   >