You are right about that, I'm sending a V4 now with the fixes.
Kindest regards,
Raslan Darawsheh
> -Original Message-
> From: Iremonger, Bernard
> Sent: Thursday, October 4, 2018 5:44 PM
> To: Raslan Darawsheh ; Wu, Jingjing
>
> Cc: Thomas Monjalon ; dev@dpdk.org; Shahaf
> Shuler ; Xue
verbosity for the received/sent packets is needed in all of the
forwarding engines so moving it to be in a separate function
---
changes in v3:
- add util.c in the mason.build file
- restore missing check for ol_flags & PKT_RX_RSS_HASH.
- add local variables for rte_be_to_c
when changing verbosity level it will configure rx/tx callbacks to dump
packets based on the verbosity value as following:
1- dump only received packets:
testpmd> set verbose 1
2- dump only sent packets:
testpmd> set verbose 2
3- dump sent and received packets:
test
add new rx/tx callback functions to be used for dumping the packets.
Signed-off-by: Raslan Darawsheh
---
app/test-pmd/config.c | 67 ++
app/test-pmd/testpmd.h | 15 +++
app/test-pmd/util.c| 17 +
3 files changed, 99 inserti
Hi Akhil,
Please see inline.
Thanks,
Anoob
On 05-10-2018 17:35, Akhil Goyal wrote:
External Email
On 9/6/2018 9:45 AM, Joseph, Anoob wrote:
Hi Akhil,
Hi Anoob,
Thanks for the comments.
Please see inline.
Thanks,
Anoob
On 28-08-2018 18:31, akhil.go...@nxp.com wrote:
External Email
From:
This is a follow-up of an idea presented at Dublin
during the "hotplug talk".
Instead of changing the existing hotplug functions, as in the RFC,
some new experimental functions are added.
The old functions lose their experimental status in order to provide
a non-experimental replacement for deprec
rte_eal_parse_devargs_str() does not support parsing the bus name
at the start of devargs. So it was renamed and deprecated.
rte_eal_devargs_add(), rte_eal_devargs_type_count() and
rte_eal_devargs_dump() were declared deprecated and had their
implementation body renamed.
All these functions were
When a device is added with a devargs (hotplug or whitelist),
the bus pointer can be retrieved via its devargs.
But there is no such devargs.bus in case of standard scan.
A pointer to the rte_bus handle is added to rte_device.
When a device is allocated (during a scan),
the pointer to its bus is a
The function rte_devargs_remove(), which is intended to be internal,
can take a devargs structure as argument.
The matching is still using string comparison of bus name and
device name.
It is simpler and may allow a different devargs matching in future.
Signed-off-by: Thomas Monjalon
Reviewed-by:
All information about a device to probe can be grouped
in a common string, which is what we usually call devargs.
An application should not have to parse this string before
calling the EAL probe function.
And the syntax could evolve to be more complex and support
matching multiple devices in one st
These functions are quite old and are the only available replacement
for the deprecated attach/detach functions.
Note: some new functions may (again) replace these hotplug functions,
in future, with better parameters.
Signed-off-by: Thomas Monjalon
Reviewed-by: Andrew Rybchenko
Acked-by: Gaetan
Monday, September 24, 2018 9:37 PM, Yongseok Koh:
> Subject: [PATCH 1/2] net/mlx4: support externally allocated static memory
>
> When MLX PMD registers memory for DMA, it accesses the global memseg
> list of DPDK to maximize the range of registration so that LKey search can be
> more efficient. G
Hi Ophir,
To add on top of Koh's comment
Wednesday, October 3, 2018 9:56 PM, Yongseok Koh:
> Subject: Re: [PATCH] net/mlx5: set RSS key len 0 to indicate default RSS
> > On Oct 3, 2018, at 10:37 AM, Ophir Munk
> wrote:
> >
> > Applications which add an RSS flow must supply an RSS key table and a
-Original Message-
> Date: Fri, 5 Oct 2018 17:26:08 +0100
> From: Ferruh Yigit
> To: Reshma Pattan , Hemant Agrawal
> , Shreyansh Jain , Ashish
> Gupta , Fiona Trahe ,
> Pablo de Lara , Akhil Goyal
> , Declan Doherty , Fan
> Zhang , Rahul Lakkireddy
> , Gaetan Rivet , Qi
> Zhang , X
-Original Message-
> Date: Fri, 5 Oct 2018 17:26:10 +0100
> From: Ferruh Yigit
> To: Reshma Pattan , Hemant Agrawal
> , Shreyansh Jain , Ashish
> Gupta , Fiona Trahe ,
> Pablo de Lara , Akhil Goyal
> , Declan Doherty , Fan
> Zhang , Rahul Lakkireddy
> , Gaetan Rivet , Qi
> Zhang , X
-Original Message-
> Date: Fri, 5 Oct 2018 17:26:11 +0100
> From: Ferruh Yigit
> To: Reshma Pattan , Hemant Agrawal
> , Shreyansh Jain , Ashish
> Gupta , Fiona Trahe ,
> Pablo de Lara , Akhil Goyal
> , Declan Doherty , Fan
> Zhang , Rahul Lakkireddy
> , Gaetan Rivet , Qi
> Zhang , X
This series implement the generic L2/L3 tunnel encapsulation actions
and is based on rfc [1] "add generic L2/L3 tunnel encapsulation actions"
Currenlty the encap/decap actions only support encapsulation
of VXLAN and NVGRE L2 packets (L2 encapsulation is where
the inner packet has a valid Ethernet
Currenlty the encap/decap actions only support encapsulation
of VXLAN and NVGRE L2 packets (L2 encapsulation is where
the inner packet has a valid Ethernet header, while L3 encapsulation
is where the inner packet doesn't have the Ethernet header).
In addtion the parameter to to the encap action is
Currently there are 2 encapsulation commands in testpmd one for VXLAN
and one for NVGRE, both of those commands are using the old rte encap
command.
This commit update the commands to work with the new tunnel encap
actions.
The reason that we have different encapsulation commands, one for VXLAN
a
This patch removes the VXLAN and NVGRE encapsulation commands.
Those commands are subset of the TUNNEL_ENCAP command so there is no
need to keep both versions.
Signed-off-by: Ori Kam
Acked-by: Mohammad Abdul Awal
---
doc/guides/prog_guide/rte_flow.rst | 107
This patch complements [1], adding to MLX5 PMD the option to set
flow rule for egress traffic.
[1] "net/mlx5: support metadata as flow rule criteria"
http://mails.dpdk.org/archives/dev/2018-September/113275.html
Signed-off-by: Dekel Peled
---
V2:
* Rebase on tip.
* Apply code review comments
This patch adds glue functions for operations:
- Create packet reformat (encap/decap) flow action.
- Destroy flow action.
Signed-off-by: Dekel Peled
---
drivers/net/mlx5/mlx5_glue.c | 33 +
drivers/net/mlx5/mlx5_glue.h | 9 +
2 files changed, 42 insertion
This patch adds the required definitions for DV encap/decap actions.
It also adds usage of the new actions definition in validation
function of existing drop operation.
Signed-off-by: Dekel Peled
---
drivers/net/mlx5/mlx5_flow.c | 8
drivers/net/mlx5/mlx5_flow.h | 6 ++
2 files chan
This patch adds support for Direct Verbs decap operations, L2 and L3.
Signed-off-by: Dekel Peled
Conflicts:
drivers/net/mlx5/mlx5_flow_dv.c
---
drivers/net/mlx5/mlx5_flow_dv.c | 224 +++-
1 file changed, 219 insertions(+), 5 deletions(-)
diff --git a
This patch adds support for Direct Verbs encap operations, L2 and L3.
Signed-off-by: Dekel Peled
---
drivers/net/mlx5/mlx5_flow_dv.c | 226 +++-
1 file changed, 222 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/
This series adds support of encap and decap actions in DV format.
It is using the generic encapsulation framework from [1].
Note that encap action is relevant for egress only.
Hence this series should be merged on top of [2].
[1] "ethdev: add generic L2/L3 tunnel encapsulation actions"
http://
Currently testpmd have support only for encapsulation and decapsulation
for L2 tunnels.
This series adds commands for L3 tunnels types, L3 tunnel is a tunnel
that the inner packet is missing the L2 part. The encapsulation uses
the encap_l3 command in-order to remove the inner l2.
For decapsulation
MPLSoUDP is an example for L3 tunnel encapsulation.
Due to the complex encapsulation of MPLSoUDP flow action and based on the
fact testpmd does not allocate memory, this patch adds a new command in
testpmd to initialise a global structure containing the necessary
information to make the outer laye
This commit introduce the decapsulation of L3 tunnels.
L3 tunnels are tunnels that the inner packet is missing the L3 layer.
This command uses the generic L3 decap command and decapsulate any
tunnel by replacing the outer layers with the supplied L2.
Signed-off-by: Ori Kam
---
app/test-pmd/cmdli
Due to the complex encapsulation of MPLSoGRE flow action and based on
the fact testpmd does not allocate memory, this patch adds a new command
in testpmd to initialise a global structure containing the necessary
information to make the outer layer of the packet. This same global
structure will the
This patch fixes a typecast bug found in rte_flow_conv_name routine
used in rte_flow item/action name conversion.
Fixes: ae6b2cf49505 ("ethdev: add flow API item/action name conversion")
Signed-off-by: Moti Haimovsky
---
lib/librte_ethdev/rte_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 del
This patch fixes a typecast bug found in rte_flow_conv_name routine
used in rte_flow item/action name conversion.
Fixes: 0c2640cbfa7a ("ethdev: add flow API item/action name conversion")
Signed-off-by: Moti Haimovsky
---
v1:
Fixed wrong hash number in "Fixes" message.
---
lib/librte_ethdev/rt
> -Original Message-
> From: dev On Behalf Of Mordechay Haimovsky
> Sent: Sunday, October 7, 2018 7:22 PM
> To: Adrien Mazarguil ; Shahaf Shuler
> ; or...@contextream.com
> Cc: dev@dpdk.org; Mordechay Haimovsky
> Subject: [dpdk-dev] [PATCH v1] ethdev: fix flow API item/action name
> co
RTE_MEMZONE_SIZE_HINT_ONLY wasn't checked in any way,
causing size hints to be parsed as hard requirements.
This resulted in some allocations being failed prematurely.
Fixes: 68b6092bd3c7 ("malloc: allow reserving biggest element")
Cc: anatoly.bura...@intel.com
Cc: sta...@dpdk.org
Signed-off-by:
On 07/10/2018, 06:03, "Jerin Jacob" wrote:
How about fixing rte_pause() then?
Meaning issuing power saving instructions on missing archs.
Rte_pause() implemented as NOP or YIELD on ARM will likely not save any power.
You should use WFE for that.
I use this portable pattern:
//W
On 07/10/2018, 06:03, "Jerin Jacob" wrote:
In arm64 case, it will have ATOMIC_RELAXED followed by asm volatile
("":::"memory") of rte_pause().
I would n't have any issue, if the generated code code is same or better
than the exiting case. but it not the case, Right?
The existing case
On 07/10/2018, 08:32, "Jerin Jacob" wrote:
Add support for rte_pause() implementation for armv7.
Signed-off-by: Jerin Jacob
---
The reference implementation for Linux's cpu_relax() for armv7 is at
https://elixir.bootlin.com/linux/latest/source/arch/arm/include/asm/proce
This is a follow-up of an idea presented at Dublin
during the "hotplug talk".
The idea is to ease probing of range of ports attached
to the same rte_device.
I becomes possible to allow probing again the same device
but with a bigger range of ports in the devargs.
Instead of adding a parameter to
The PCI mapping requires to know the PCI driver to use,
even before the probing is done. That's why the PCI driver is
referenced early inside the PCI device structure. See
1d20a073fa5e ("bus/pci: reference driver structure before mapping")
However the rte_driver does not need to be referenced in r
In the devargs syntax for device representors, it is possible to add
several devices at once: -w dbdf,representor=[0-3]
It will become a more frequent case when introducing wildcards
and ranges in the new devargs syntax.
If a devargs string is provided for probing, and updated with a bigger
range
The function rte_dev_is_probed() is added in order to improve semantic
and enforce proper check of the probing status of a device.
It will answer this rte_device query:
Is it already successfully probed or not?
Signed-off-by: Thomas Monjalon
---
drivers/bus/ifpga/ifpga_bus.c | 4 ++--
These hotplug functions were deprecated and have some new replacements.
As announced earlier, the oldest ones are now removed.
Signed-off-by: Thomas Monjalon
---
doc/guides/rel_notes/deprecation.rst| 5 ---
doc/guides/rel_notes/release_18_11.rst | 6 +++
lib/librte_eal/common/eal_common_d
The hotplug attach/detach features are implemented in EAL layer.
There is a new ethdev iterator to retrieve ports from ethdev layer.
As announced earlier, the (buggy) ethdev functions are now removed.
Signed-off-by: Thomas Monjalon
---
app/test-pmd/testpmd.c| 17 ++-
do
If no rte_device is given in the iterator,
eth_dev_match() is looking at all ports without any restriction,
except the ethdev kvargs filter.
It allows to iterate with a devargs filter referencing only
some ethdev parameters. The format (from the new devargs syntax) is:
class=eth,paramY=Y
The functions for EAL attach/detach had already some replacements,
so they are removed.
The functions for ethdev attach/detach are removed and replaced
thanks to a new ethdev iterator working with devargs.
rte_eth_dev_attach(devargs, &port_id)
is replaced by:
rte_dev_probe(devargs);
RT
A virtual device can be matched with following syntax:
bus=vdev,name=X
Signed-off-by: Thomas Monjalon
---
drivers/bus/vdev/vdev_params.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_param
Signed-off-by: Thomas Monjalon
---
lib/librte_eal/common/include/rte_common.h | 6 ++
lib/librte_ethdev/ethdev_private.c | 10 ++-
lib/librte_ethdev/ethdev_private.h | 6 ++
lib/librte_ethdev/rte_ethdev.c | 87 ++
lib/librte_ethdev/rte_ethdev.h
On 18-10-05 13:52:03, Ferruh Yigit wrote:
> On 9/25/2018 3:37 PM, Xiaoyu Min wrote:
> > This patch series is for RFC[1]
> >
> > Patch 1 adds generic TTL rewrite actions to flow API
> > Patch 2 adds corresponding testpmd commands
> > Patch 3 implements the offloading logic of E-Switch rules on Mell
On 18-10-05 13:54:38, Ferruh Yigit wrote:
> On 9/25/2018 4:03 PM, Xiaoyu Min wrote:
> > This series is for RFC[1]
> >
> > Patch 1 adds generic MAC address rewrite actions to flow API
> > Patch 2 adds testpmd commands for that
> > Patch 3 offloads these actions on Mellanox MLX5 by using E-Switch ru
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, October 02, 2018 18:24
> To: Andrew Rybchenko ; Xu, Rosen
> ; Zhang, Tianfei
> Cc: dev@dpdk.org; Thomas Monjalon ; Stokes, Ian
>
> Subject: Re: [dpdk-dev] [PATCH] eal: remove experimental from hotplug
> add/remove
>
> On 10/2/
Hi Ferruh,
> -Original Message-
> From: Yigit, Ferruh
> Sent: Tuesday, October 2, 2018 10:46 PM
> To: Wang, Xiao W ; Bie, Tiwei
> Cc: dev@dpdk.org; Ye, Xiaolong ; Wang, Zhihong
> ; Chao Zhu ;
> Thomas Monjalon ; Xu, Qian Q
> Subject: Re: [dpdk-dev] [PATCH] net/ifc: add live migration sup
The typedef of "__virtio16" is introduced into Linux kernel in v3.19.
To prevent build error on old kernel, this patch replaces the
"__virtio" usage with "uint16_t".
Fixes: d7fe5a2861e7 ("net/ifc: support live migration")
Signed-off-by: Xiao Wang
---
drivers/net/ifc/ifcvf_vdpa.c | 2 +-
1 file
> >
> > I doubt it is possible to benchmark with such a precision so to see the
> > potential difference of one ADD instruction.
> > Just changes in function alignment can affect performance by percents.
> And
> > the natural variation when not using a 100% deterministic system
-Original Message-
> Date: Sun, 7 Oct 2018 20:44:54 +
> From: Ola Liljedahl
> To: Jerin Jacob
> CC: "dev@dpdk.org" , Honnappa Nagarahalli
> , "Ananyev, Konstantin"
> , "Gavin Hu (Arm Technology China)"
> , Steve Capper , nd ,
> "sta...@dpdk.org"
> Subject: Re: [PATCH v3 1/3] ring
-Original Message-
> Date: Sun, 7 Oct 2018 21:09:25 +
> From: Ola Liljedahl
> To: Jerin Jacob , Jan Viktorin
> , "Gavin Hu (Arm Technology China)"
>
> CC: "dev@dpdk.org" , "tho...@monjalon.net"
>
> Subject: Re: [dpdk-dev] [PATCH] eal/armv7: add support for rte pause
> user-agent:
On 10/8/18 1:25 AM, Thomas Monjalon wrote:
A virtual device can be matched with following syntax:
bus=vdev,name=X
Signed-off-by: Thomas Monjalon
---
drivers/bus/vdev/vdev_params.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/drivers/bus/v
On 18-10-04 04:07:02, Yongseok Koh wrote:
> On Tue, Sep 25, 2018 at 09:47:18PM +0800, Xiaoyu Min wrote:
> > Offload following modify TTL actions to E-Swtich via
> > TC-Flower driver
> >
> > - RTE_FLOW_ACTION_TYPE_SET_TTL
> > - RTE_FLOW_ACTION_TYPE_DEC_TTL
> >
> > The corresponding IP protocol rte
57 matches
Mail list logo
