Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-09-21 Thread Hideyuki Yamashita
Dear Gaetan and Thomas, Thanks for your answer. Please see inline. > 20/09/2018 11:09, Ga枓an Rivet: > > On Thu, Sep 20, 2018 at 05:46:37PM +0900, Hideyuki Yamashita wrote: > > > Hello, > > > > > > From dpdk 18.08 release rte_eth_dev_attach and > > > rte_eth_dev_detach becom deprecated API and

[dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-09-21 Thread Beilei Xing
HW supports Rx scatter offload, this patch updates Rx scatter offload for PF. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 24d73f2..37c9c08 100644 --- a/driv

Re: [dpdk-dev] DEV_RX_OFFLOAD_SCATTER not available in i40e an cxgbe

2018-09-21 Thread Xing, Beilei
Hi Martin, Thanks for the catch, patch has been sent. BR, Beilei > -Original Message- > From: Martin Weiser [mailto:martin.wei...@allegro-packets.com] > Sent: Tuesday, September 18, 2018 5:24 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Rahul Lakkireddy > Subject: DEV_RX_O

Re: [dpdk-dev] [PATCH] examples/eventdev_pipeline: add Tx adapter support

2018-09-21 Thread Rao, Nikhil
On 9/5/2018 7:15 PM, Pavan Nikhilesh wrote: Signed-off-by: Pavan Nikhilesh --- This patch depends on the following series: http://patches.dpdk.org/project/dpdk/list/?series=1121 examples/eventdev_pipeline/main.c | 62 ++-- examples/eventdev_pipeline/pipeline_common.h | 31

[dpdk-dev] [PATCH] eal: fix '--huge-unlink' option

2018-09-21 Thread Pawel Wodkowski
The final_va field is set during remap_segment() but this information is not propagated to temporal copy of huge page memory configuration so the unlink_hugepage_files() function wrongly assume that there is nothing to unlink. Fix this issue by checking orig_va instead of final_va. Fixes: 66cc45e2

Re: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-09-21 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Beilei Xing > Sent: Friday, September 21, 2018 8:36 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload > > HW supports Rx scatter offload, this patch upda

[dpdk-dev] [PATCH v2] net/i40e: update Rx offload

2018-09-21 Thread Beilei Xing
HW supports Rx scatter offload, this patch updates Rx scatter offload for PF. Signed-off-by: Beilei Xing Acked-by: Konstantin Ananyev --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) v2 change: - Remove typo in title diff --git a/drivers/net/i40e/i40e_ethdev.c b/driv

Re: [dpdk-dev] KNI performance is not what is claimed

2018-09-21 Thread Wang, Zhihong
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jay Rolette > Sent: Friday, September 21, 2018 5:39 AM > To: Stephen Hemminger > Cc: DPDK > Subject: Re: [dpdk-dev] KNI performance is not what is claimed > > On Thu, Sep 20, 2018 at 3:16 PM Stephen Hemminger <

Re: [dpdk-dev] [PATCH] eal: fix '--huge-unlink' option

2018-09-21 Thread Stojaczyk, Dariusz
I'd like to point out that the comments inside eal_memory.c are outdated (e.g. the one from line #249). It makes it difficult to review this patch. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pawel Wodkowski > Sent: Friday, September 21, 2018 1:57 PM > To:

Re: [dpdk-dev] [PATCH v2] mem: fix undefined behavior in NUMA code

2018-09-21 Thread Burakov, Anatoly
On 21-Sep-18 7:47 AM, Ilya Maximets wrote: On 20.09.2018 15:50, Anatoly Burakov wrote: When NUMA-aware hugepages config option is set, we rely on libnuma to tell the kernel to allocate hugepages on a specific NUMA node. However, we allocate node mask before we check if NUMA is available in the f

Re: [dpdk-dev] [PATCH v2 2/3] kni: fix kni fifo synchronization

2018-09-21 Thread Phil Yang (Arm Technology China)
+ Ola Liljedahl Thanks, Phil Yang > -Original Message- > From: Honnappa Nagarahalli > Sent: Friday, September 21, 2018 2:37 PM > To: Jerin Jacob > Cc: Phil Yang (Arm Technology China) ; dev@dpdk.org; nd > ; kkokkilaga...@caviumnetworks.com; Gavin Hu (Arm > Technology China) ; ferruh.yi.

Re: [dpdk-dev] [PATCH v3 17/20] examples: add external memory example app

2018-09-21 Thread Burakov, Anatoly
On 20-Sep-18 11:47 PM, Ananyev, Konstantin wrote: Hi Anatoly Introduce an example application demonstrating the use of external memory support. This is a simple application based on skeleton app, but instead of using internal DPDK memory, it is using externally allocated memory. The RX/TX an

Re: [dpdk-dev] How to replace rte_eth_dev_attach with rte_eal_hotplug_add

2018-09-21 Thread Thomas Monjalon
21/09/2018 09:19, Hideyuki Yamashita: > Dear Gaetan and Thomas, > > Thanks for your answer. > Please see inline. > > > 20/09/2018 11:09, Ga�an Rivet: > > > On Thu, Sep 20, 2018 at 05:46:37PM +0900, Hideyuki Yamashita wrote: > > > > Hello, > > > > > > > > From dpdk 18.08 release rte_eth_dev_atta

[dpdk-dev] [PATCH v3] mem: fix undefined behavior in NUMA code

2018-09-21 Thread Anatoly Burakov
When NUMA-aware hugepages config option is set, we rely on libnuma to tell the kernel to allocate hugepages on a specific NUMA node. However, we allocate node mask before we check if NUMA is available in the first place, which, according to the manpage [1], causes undefined behaviour. Fix by only

Re: [dpdk-dev] [PATCH v5 06/11] net/virtio-user: add option to use packed queues

2018-09-21 Thread Jens Freimann
On Mon, Sep 10, 2018 at 06:32:09AM +, Gavin Hu (Arm Technology China) wrote: -Original Message- From: dev On Behalf Of Jens Freimann Sent: Friday, September 7, 2018 2:20 AM To: dev@dpdk.org Cc: tiwei@intel.com; maxime.coque...@redhat.com Subject: [dpdk-dev] [PATCH v5 06/11] ne

[dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink usecases

2018-09-21 Thread Harry van Haaren
This commit fixes the cq index checks when unlinking ports/queues while the scheduler core is running. Previously, the == comparison could be "skipped" if in particular corner cases. With the check being changed to >= this is resolved as the cq idx gets reset to zero. Bugzilla ID: 60 Fixes: 617995

Re: [dpdk-dev] [PATCH 00/37] net/sfc: update base driver

2018-09-21 Thread Ferruh Yigit
On 9/10/2018 10:32 AM, Andrew Rybchenko wrote: > Update net/sfc base driver (aka libefx). > > There are a number of checkpatches.sh warnings/errors > because of coding style difference. > > Andrew Jackson (1): > net/sfc/base: highlight that image layout header generated > > Andrew Rybchenko (1

[dpdk-dev] [PATCH v6 01/11] net/virtio: vring init for packed queues

2018-09-21 Thread Jens Freimann
Add and initialize descriptor data structures. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 24 +++-- drivers/net/virtio/virtio_pci.h| 8 + drivers/net/virtio/virtio_ring.h | 55 +++--- drivers/net/virtio/virtqueue.h | 12 ++

[dpdk-dev] [PATCH v6 02/11] net/virtio: add packed virtqueue defines

2018-09-21 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/virtio/virtio_ring.h b/drivers/net/virtio/virtio_ring.h index 309069fdb..36a65f9b3 100644 --- a/drivers/net/virtio/virtio_ring.h +++ b/drivers/net/virtio/virtio_ri

[dpdk-dev] [PATCH v6 00/11] implement packed virtqueues

2018-09-21 Thread Jens Freimann
This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf A packed vi

[dpdk-dev] [PATCH v6 04/11] net/virtio: flush packed receive virtqueues

2018-09-21 Thread Jens Freimann
Flush used descriptors in packed receive virtqueue. As descriptors can be chained we need to look at the stored number of used descriptors to find out the length of the chain. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.c | 21 + 1 file changed, 21 insertion

[dpdk-dev] [PATCH v6 05/11] net/virtio: dump packed virtqueue data

2018-09-21 Thread Jens Freimann
Add support to dump packed virtqueue data to the VIRTQUEUE_DUMP() macro. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtqueue.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h index aba6be3f9..eb220563f 100644

[dpdk-dev] [PATCH v6 03/11] net/virtio: add packed virtqueue helpers

2018-09-21 Thread Jens Freimann
Add helper functions to set/clear and check descriptor flags. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ring.h | 26 ++ drivers/net/virtio/virtqueue.h | 11 +++ 2 files changed, 37 insertions(+) diff --git a/drivers/net/virtio/virtio_ring.h b/d

[dpdk-dev] [PATCH v6 06/11] net/virtio: implement transmit path for packed queues

2018-09-21 Thread Jens Freimann
This implements the transmit path for devices with support for packed virtqueues. Add the feature bit and enable code to add buffers to vring and mark descriptors as available. Signed-off-by: Jens Freiman --- drivers/net/virtio/virtio_ethdev.c | 8 +- drivers/net/virtio/virtio_ethdev.h | 2

[dpdk-dev] [PATCH v6 09/11] net/virtio: add virtio send command packed queue support

2018-09-21 Thread Jens Freimann
Use packed virtqueue format when reading and writing descriptors to/from the ring. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virt

[dpdk-dev] [PATCH v6 07/11] net/virtio: implement receive path for packed queues

2018-09-21 Thread Jens Freimann
Implement the receive part. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 15 +++- drivers/net/virtio/virtio_ethdev.h | 2 + drivers/net/virtio/virtio_rxtx.c | 130 + 3 files changed, 144 insertions(+), 3 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH v6 08/11] net/virtio: add support for mergeable buffers with packed virtqueues

2018-09-21 Thread Jens Freimann
Implement support for receiving merged buffers in virtio when packed virtqueues are enabled. Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.c | 8 +- drivers/net/virtio/virtio_rxtx.c | 117 ++--- drivers/net/virtio/virtqueue.h | 1 + 3 files c

[dpdk-dev] [PATCH v6 10/11] net/virtio-user: add option to use packed queues

2018-09-21 Thread Jens Freimann
From: Yuanhan Liu Add option to enable packed queue support for virtio-user devices. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_user/virtio_user_dev.c | 10 -- drivers/net/virtio/virtio_user/virtio_user_dev.h | 2 +- drivers/net/virtio/virtio_user_ethdev.c | 14

[dpdk-dev] [PATCH v6 11/11] net/virtio: enable packed virtqueues by default

2018-09-21 Thread Jens Freimann
Signed-off-by: Jens Freimann --- drivers/net/virtio/virtio_ethdev.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index 25eaff224..2c8a69cbf 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virt

Re: [dpdk-dev] [PATCH v3] hash table: add an iterator over conflicting entries

2018-09-21 Thread Michel Machado
On 09/12/2018 04:37 PM, Honnappa Nagarahalli wrote: +int32_t +rte_hash_iterator_init(const struct rte_hash *h, + struct rte_hash_iterator_state *state) { + struct rte_hash_iterator_istate *__state; '__state' can be replaced by 's'. + + RETURN_IF_TRUE(((h == NULL) || (state == N

[dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process

2018-09-21 Thread paul luse
This patch fixes an issue caught with ASAN where a vdev_scan() to a secondary bus was failing to free some memory. Signed-off-by: paul luse --- drivers/bus/vdev/vdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 69dee89a8..2566d6c0d

Re: [dpdk-dev] [PATCH v3] mem: fix undefined behavior in NUMA code

2018-09-21 Thread Ilya Maximets
On 21.09.2018 12:27, Anatoly Burakov wrote: > When NUMA-aware hugepages config option is set, we rely on > libnuma to tell the kernel to allocate hugepages on a specific > NUMA node. However, we allocate node mask before we check if > NUMA is available in the first place, which, according to > the

[dpdk-dev] [PATCH v3 01/13] net/dpaa: configure frame queue on MAC ID basis

2018-09-21 Thread Hemant Agrawal
The current code has the hardcoded seq for fq allocation. It require multiple changes, when some of the interfaces are assigned to kernel stack. Changing it on the mac id basis provide the flexibility to assign any interface to kernel. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethd

[dpdk-dev] [PATCH v3 00/13] NXP DPAA driver enhancements

2018-09-21 Thread Hemant Agrawal
Misc driver level enhancements V3: fix the description and implementation of jumbo buffer fix V2: remove the unused function from map file Add description/details in git commit logs. Hemant Agrawal (9): net/dpaa: configure frame queue on MAC ID basis net/dpaa: fix jumbo buffer config

[dpdk-dev] [PATCH v3 02/13] net/dpaa: fix jumbo buffer config

2018-09-21 Thread Hemant Agrawal
Set the missing dev data mtu for the correct size. Set the max supported size in hw, if user is asking for more. Fixes: 9658ac3a4ef6 ("net/dpaa: set the correct frame size in device MTU") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 22 -

[dpdk-dev] [PATCH v3 03/13] net/dpaa: implement scatter offload support

2018-09-21 Thread Hemant Agrawal
This patch implement the sg support, which can be enabled/disabled w.r.t configuration. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 62 +++--- drivers/net/dpaa/dpaa_ethdev.h | 3 +- drivers/net/dpaa/dpaa_rxtx.c | 8 +++--- drivers/ne

[dpdk-dev] [PATCH v3 05/13] net/dpaa: minor debug log enhancements

2018-09-21 Thread Hemant Agrawal
Improving the debug message for event mode and reducing the log level for less important log Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev

Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process

2018-09-21 Thread Burakov, Anatoly
On 21-Sep-18 12:29 AM, paul luse wrote: This patch fixes an issue caught with ASAN where a vdev_scan() to a secondary bus was failing to free some memory. Signed-off-by: paul luse --- drivers/bus/vdev/vdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/vdev/vdev.c b/driver

[dpdk-dev] [PATCH v3 07/13] bus/dpaa: avoid tag Set for eqcr in Tx path

2018-09-21 Thread Hemant Agrawal
From: Nipun Gupta Minor optimization for TX path. Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 8730550..71da275 100644 --- a/drivers/bus/d

[dpdk-dev] [PATCH v3 06/13] bus/dpaa: add interrupt based portal fd support

2018-09-21 Thread Hemant Agrawal
This patch add supports in bus driver for qbman to support and configure portal based FDs, which can be used for interrupt based processing. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/bman_driver.c | 17 ++ drivers/bus/dpaa/base/qbman/qman.c| 52 +++

[dpdk-dev] [PATCH v3 04/13] net/dpaa: fix link speed based on MAC type

2018-09-21 Thread Hemant Agrawal
From: Sachin Saxena The link speed shall be on the basis of mac type. Fixes: 799db4568c76 ("net/dpaa: support device info and speed capability") Cc: shreyansh.j...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Sachin Saxena --- drivers/net/dpaa/dpaa_ethdev.c | 11 +-- 1 file changed, 9 i

[dpdk-dev] [PATCH v3 08/13] bus/dpaa: avoid using be conversions for contextb

2018-09-21 Thread Hemant Agrawal
From: Nipun Gupta minor optimization in packet handling path Signed-off-by: Nipun Gupta --- drivers/bus/dpaa/base/qbman/qman.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/qman.c b/drivers/bus/dpaa/base/qbman/qman.c index 71d

[dpdk-dev] [PATCH v3 11/13] net/dpaa: tune prefetch in Rx path

2018-09-21 Thread Hemant Agrawal
As part of performance optimization excercise, tuning the prefetch placement. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_rxtx.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 2c57741..c4471

[dpdk-dev] [PATCH v3 09/13] net/dpaa: rearranging of atomic queue support code

2018-09-21 Thread Hemant Agrawal
From: Sunil Kumar Kori This is to align the code with dpaa2 to ease out maintaince of both driver code bases. Signed-off-by: Sunil Kumar Kori --- drivers/net/dpaa/dpaa_rxtx.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/drivers/net/dpaa/dpaa_r

[dpdk-dev] [PATCH v3 10/13] net/dpaa: separate Rx function for LS1046

2018-09-21 Thread Hemant Agrawal
This is to avoid the checks in datapath and help in performance. LS1046 has different data stash settings. Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 9 +-- drivers/net/dpaa/dpaa_rxtx.c | 60 +- drivers/net/dpaa/dpaa_rxtx.h

[dpdk-dev] [PATCH v3 13/13] mempool/dpaa: change the debug log level to DP

2018-09-21 Thread Hemant Agrawal
When the system goes out of buffers temporarily, the logs further slow down the system. There is no need for this continuos logs. Signed-off-by: Hemant Agrawal --- drivers/mempool/dpaa/dpaa_mempool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/dpaa/dpaa_me

[dpdk-dev] [PATCH v3 12/13] bus/dpaa: add check for re-definition in compat

2018-09-21 Thread Hemant Agrawal
Few fields in compat are giving re-defination error with new drivers such as caam_jr. Checks have been added. Signed-off-by: Hemant Agrawal --- drivers/bus/dpaa/include/compat.h | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/bus/dpaa/include/com

Re: [dpdk-dev] Incorrect latencystats implementation

2018-09-21 Thread Pattan, Reshma
Hi, > -Original Message- > From: long...@viettel.com.vn [mailto:long...@viettel.com.vn] > Sent: Friday, September 21, 2018 2:58 AM > To: Pattan, Reshma > Cc: dev@dpdk.org > Subject: RE: Incorrect latencystats implementation > > Hi Reshma, > > > -Original Message- > > From: reshm

Re: [dpdk-dev] [PATCH v4] doc: Clarify IOMMU usage with "uio_pci_generic" kernel module

2018-09-21 Thread Bruce Richardson
On Fri, Sep 21, 2018 at 11:07:42AM +0800, tone.zhang wrote: > If the devices used for DPDK are bound to the "uio_pci_generic" kernel > module, the IOMMU should be disabled in order not to break the IO > transmission because of the virtual / physical address mapping. > > The patch clarifies the IOM

Re: [dpdk-dev] [PATCH] devtools: move forbidden tokens awk script to a separate file

2018-09-21 Thread Andrzej Ostruszka
Acked-by: Andrzej Ostruszka However you might consider keeping this comment in the awk script. On 20.09.2018 23:11, Arnon Warshavsky wrote: [...] > @@ -44,85 +44,12 @@ print_usage () { > } > > check_forbidden_additions() { > -# This awk script receives a list of expressions to monitor >

[dpdk-dev] [PATCH v2 2/5] event/dpaa2: rename evq info to dpaa2 eventq

2018-09-21 Thread Hemant Agrawal
This is to keep the dpaa2 driver aligned with dpaa driver. Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 8 drivers/event/dpaa2/dpaa2_eventdev.h | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/d

[dpdk-dev] [PATCH v2 4/5] event/dpaa2: support Max event port value

2018-09-21 Thread Hemant Agrawal
This shall be number of available cores. Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 4b56e2e..456b446 100644 --- a/drivers/event/dp

[dpdk-dev] [PATCH v2 3/5] event/dpaa2: enchance timeout handling

2018-09-21 Thread Hemant Agrawal
This patch enahances: 1. configure the dequeue time out value as per the given method or per dequeue, global or default. 2. The timeout values were being mixed as ns or ms timeouts. now the values are stored as ns and scale is in ms. Signed-off-by: Hemant Agrawal --- v2: added description

[dpdk-dev] [PATCH v2 1/5] event/dpaa2: fix mbuf assignment in atomic processing

2018-09-21 Thread Hemant Agrawal
Fixes: 7b6edb640b73 ("event/dpaa2: have separate structure to hold dqrr entries") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_even

[dpdk-dev] [PATCH v2 5/5] event/dpaa2: affining portal at runtime during I/O

2018-09-21 Thread Hemant Agrawal
This patch restructure the code to have the QBMAN portal affliated at run time for per lcore basis. The device cleanup is also improved. Signed-off-by: Sunil Kumar Kori Signed-off-by: Hemant Agrawal --- v5: fixed a compilation error on x86 drivers/event/dpaa2/dpaa2_eventdev.c | 277 +++

Re: [dpdk-dev] [PATCH v2 04/13] bus/vdev: add device matching field driver

2018-09-21 Thread Gaëtan Rivet
On Thu, Sep 20, 2018 at 06:11:44PM +0200, Thomas Monjalon wrote: > 19/09/2018 18:03, Gaetan Rivet: > > The vdev bus parses a field "driver", matching > > a vdev driver name with one passed as follows: > > > >"bus=vdev,driver=" > > I think the property should be "name". > We already have a

Re: [dpdk-dev] [PATCH v3 0/8] Add Marvell NETA PMD

2018-09-21 Thread Andrzej Ostruszka
On 19.09.2018 19:39, Ferruh Yigit wrote: > On 9/19/2018 4:07 PM, Andrzej Ostruszka wrote: >> On 14.09.2018 18:20, Ferruh Yigit wrote: [...] >>> Can you also set a web page patch to add new hardware to supported hw list: >>> http://core.dpdk.org/supported/ >>> https://git.dpdk.org/tools/dpdk-web/ >>

Re: [dpdk-dev] [PATCH v6] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-09-21 Thread Jens Freimann
On Thu, Sep 20, 2018 at 05:50:39PM +0100, Kevin Traynor wrote: On 09/18/2018 10:35 AM, Jens Freimann wrote: This adds a new forwarding mode to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The g

Re: [dpdk-dev] Incorrect latencystats implementation

2018-09-21 Thread Ananyev, Konstantin
Hi Reshma, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pattan, Reshma > Sent: Friday, September 21, 2018 12:15 PM > To: long...@viettel.com.vn > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] Incorrect latencystats implementation > > Hi, > > > -Original Me

Re: [dpdk-dev] [PATCH v2 07/13] ethdev: add device matching field name

2018-09-21 Thread Gaëtan Rivet
On Thu, Sep 20, 2018 at 06:17:13PM +0200, Thomas Monjalon wrote: > 19/09/2018 18:03, Gaetan Rivet: > > The eth device class can now parse a field name, > > matching the eth_dev name with one passed as > > > >"class=eth,name=xx" > > I am not sure what is the purpose of the "name" property.

Re: [dpdk-dev] [PATCH] event/sw: fix cq idx check for unlink usecases

2018-09-21 Thread Elo, Matias (Nokia - FI/Espoo)
> On 21 Sep 2018, at 13:25, Harry van Haaren wrote: > > This commit fixes the cq index checks when unlinking > ports/queues while the scheduler core is running. > Previously, the == comparison could be "skipped" if > in particular corner cases. With the check being changed > to >= this is resol

Re: [dpdk-dev] [PATCH v6 06/11] net/virtio: implement transmit path for packed queues

2018-09-21 Thread Tiwei Bie
On Fri, Sep 21, 2018 at 12:33:03PM +0200, Jens Freimann wrote: [...] > > static inline int > -desc_is_used(struct vring_desc_packed *desc, struct vring *vr) > +_desc_is_used(struct vring_desc_packed *desc) > { > uint16_t used, avail; > > used = !!(desc->flags & VRING_DESC_F_USED(1

Re: [dpdk-dev] [PATCH v6 00/11] implement packed virtqueues

2018-09-21 Thread Tiwei Bie
On Fri, Sep 21, 2018 at 12:32:57PM +0200, Jens Freimann wrote: > This is a basic implementation of packed virtqueues as specified in the > Virtio 1.1 draft. A compiled version of the current draft is available > at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at > https://github.com/oas

Re: [dpdk-dev] [PATCH v6 06/11] net/virtio: implement transmit path for packed queues

2018-09-21 Thread Jens Freimann
On Fri, Sep 21, 2018 at 08:26:58PM +0800, Tiwei Bie wrote: On Fri, Sep 21, 2018 at 12:33:03PM +0200, Jens Freimann wrote: [...] static inline int -desc_is_used(struct vring_desc_packed *desc, struct vring *vr) +_desc_is_used(struct vring_desc_packed *desc) { uint16_t used, avail;

Re: [dpdk-dev] [PATCH v6 09/11] net/virtio: add virtio send command packed queue support

2018-09-21 Thread Tiwei Bie
On Fri, Sep 21, 2018 at 12:33:06PM +0200, Jens Freimann wrote: > Use packed virtqueue format when reading and writing descriptors > to/from the ring. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_ethdev.c | 90 ++ > 1 file changed, 90 insertions(+

Re: [dpdk-dev] [PATCH v6 06/11] net/virtio: implement transmit path for packed queues

2018-09-21 Thread Tiwei Bie
On Fri, Sep 21, 2018 at 02:37:32PM +0200, Jens Freimann wrote: > On Fri, Sep 21, 2018 at 08:26:58PM +0800, Tiwei Bie wrote: > > On Fri, Sep 21, 2018 at 12:33:03PM +0200, Jens Freimann wrote: > > [...] > > > > > > static inline int > > > -desc_is_used(struct vring_desc_packed *desc, struct vring *

[dpdk-dev] [PATCH 0/3] Some fixes and doc updates for virtio-user

2018-09-21 Thread Tiwei Bie
This series consists of some fixes and doc updates for virtio-user. Tiwei Bie (3): net/virtio-user: fix multiple queue for vhost-kernel net/virtio: add the missing supported features doc: update the doc for virtio-user doc/guides/contributing/documentation.rst | 4 ++-- .../howto/vir

[dpdk-dev] [PATCH 2/3] net/virtio: add the missing supported features

2018-09-21 Thread Tiwei Bie
The virtio features VIRTIO_NET_F_CSUM, VIRTIO_NET_F_HOST_TSO4 and VIRTIO_NET_F_HOST_TSO6 are supported by the virtio PMD. But they are missing in the supported feature set. And since below commit: commit 4174a7b59d05 ("net/virtio: improve Tx offload features negotiation") Virtio PMD will announce

[dpdk-dev] [PATCH 1/3] net/virtio-user: fix multiple queue for vhost-kernel

2018-09-21 Thread Tiwei Bie
The multiple queue support in vhost-kernel is broken because the dev->vhostfd is only available for vhost-user. We should always try to enable queue pairs when it's not in server mode. Fixes: 201a41651715 ("net/virtio-user: fix multiple queues fail in server mode") Cc: sta...@dpdk.org Signed-off-

Re: [dpdk-dev] [PATCH v2 04/13] bus/vdev: add device matching field driver

2018-09-21 Thread Thomas Monjalon
21/09/2018 13:53, Gaëtan Rivet: > On Thu, Sep 20, 2018 at 06:11:44PM +0200, Thomas Monjalon wrote: > > 19/09/2018 18:03, Gaetan Rivet: > > > The vdev bus parses a field "driver", matching > > > a vdev driver name with one passed as follows: > > > > > >"bus=vdev,driver=" > > > > I think th

[dpdk-dev] [PATCH 3/3] doc: update the doc for virtio-user

2018-09-21 Thread Tiwei Bie
Update the doc for virtio-user to use the latest testpmd parameters and commands. Signed-off-by: Tiwei Bie --- doc/guides/contributing/documentation.rst | 4 ++-- .../howto/virtio_user_as_exceptional_path.rst | 23 +++ .../virtio_user_for_container_networking.rst | 2 +- 3

Re: [dpdk-dev] [PATCH v2 07/13] ethdev: add device matching field name

2018-09-21 Thread Thomas Monjalon
21/09/2018 14:16, Gaëtan Rivet: > On Thu, Sep 20, 2018 at 06:17:13PM +0200, Thomas Monjalon wrote: > > 19/09/2018 18:03, Gaetan Rivet: > > > The eth device class can now parse a field name, > > > matching the eth_dev name with one passed as > > > > > >"class=eth,name=xx" > > > > I am not

Re: [dpdk-dev] [PATCH 1/3] crypto/mvsam: add S/G support to crypto dirver

2018-09-21 Thread Andrzej Ostruszka
Hello Akhil I'm taking over handling of the patches submitted by Tomasz. First of all, thank you for taking time to review them. On 17.09.2018 16:07, Akhil Goyal wrote: > Hi Tomasz, [...] > Please update the doc file for pmd and also set appropriate feature flag for > scatter gather support. [.

Re: [dpdk-dev] [PATCH v2 1/3] doc: add usage doc for ENETC PMD

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 10:41 AM, Gagandeep Singh wrote: > Add enetc usage document to compile and run the > DPDK application on enetc supported platform. > This document introduces the enetc driver, supported > platforms and supported features. > > Signed-off-by: Gagandeep Singh > --- > MAINTAINERS

[dpdk-dev] [PATCH v2 0/3] crypto/mvsam: yet another round of features

2018-09-21 Thread Andrzej Ostruszka
Following changes are introduced in this patch series: * Add S/G support. * Start using common/mvep for DMA memory initialization. * Add dynamic logging support. Note that 'crypto/mvsam: common use initialization' relies on 'net/mvpp2: use common code to initialize DMA' which is now on dpdk-next-

[dpdk-dev] [PATCH v2 3/3] crypto/mvsam: add dynamic logging support

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add dynamic logging support to mvsam crypto PMD. Signed-off-by: Tomasz Duszynski --- config/common_base | 1 - drivers/crypto/mvsam/rte_mrvl_pmd.c | 74 ++--- drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 10 ++--

[dpdk-dev] [PATCH v2 1/3] crypto/mvsam: add S/G support to crypto dirver

2018-09-21 Thread Andrzej Ostruszka
From: Zyta Szpak The patch adds support for chained source mbufs given to crypto operations. The crypto engine accepts source buffer containing a number of segments. The destination buffer stays the same - always one segment. On decryption, EIP engine will look for digest at 'auth_icv_offset' off

[dpdk-dev] [PATCH v2 2/3] crypto/mvsam: use common initialization

2018-09-21 Thread Andrzej Ostruszka
From: Dmitri Epshtein Use common initialization to reduce boilerplate code. Signed-off-by: Dmitri Epshtein Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/common/Makefile | 4 +++- drivers/crypto/mvsam/Makefile | 3 ++- drivers/crypto/mvsam/meson

[dpdk-dev] [PATCH v7] app/testpmd: add forwarding mode to simulate a noisy neighbour

2018-09-21 Thread Jens Freimann
This adds a new forwarding mode to testpmd to simulate more realistic behavior of a guest machine engaged in receiving and sending packets performing Virtual Network Function (VNF). The goal is to enable a simple way of measuring performance impact on cache and memory footprint utilization from va

Re: [dpdk-dev] [PATCH v2 2/3] net/enetc: add ENETC PMD with basic operations

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 10:42 AM, Gagandeep Singh wrote: > This patch introduces the enetc PMD with basic > initialisation functions includes probe, teardown, > hardware initialisation > > Signed-off-by: Gagandeep Singh <...> > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2018

Re: [dpdk-dev] [PATCH v2 3/3] net/enetc: enable Rx and Tx

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 10:42 AM, Gagandeep Singh wrote: > Add RX and TX queue setup, datapath functions > and enable the packet parsing > > Signed-off-by: Gagandeep Singh <...> > -LDLIBS += -lrte_eal > +LDLIBS += -lrte_eal -lrte_mempool > LDLIBS += -lrte_ethdev > LDLIBS += -lrte_bus_pci Isn't mbuf and

Re: [dpdk-dev] [PATCH v3 0/8] Add Marvell NETA PMD

2018-09-21 Thread Ferruh Yigit
On 9/21/2018 12:59 PM, Andrzej Ostruszka wrote: > On 19.09.2018 19:39, Ferruh Yigit wrote: >> On 9/19/2018 4:07 PM, Andrzej Ostruszka wrote: >>> On 14.09.2018 18:20, Ferruh Yigit wrote: > [...] Can you also set a web page patch to add new hardware to supported hw list: http://core.dpdk.or

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-21 Thread Ferruh Yigit
On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > When trying to include stdbool.h in DPDK base headers, there are a lot > of conflicts with drivers which redefine bool/true/false > in their compatibility layer. > > It is fixed by including stdbool.h in these drivers. > Some errors with usage of bool

Re: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, September 21, 2018 4:16 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/i40e: update Rx checksum offload > > > > > -Original Message- > > From: dev [mailto:dev-boun..

Re: [dpdk-dev] [PATCH v6 00/11] implement packed virtqueues

2018-09-21 Thread Jens Freimann
On Fri, Sep 21, 2018 at 08:32:22PM +0800, Tiwei Bie wrote: On Fri, Sep 21, 2018 at 12:32:57PM +0200, Jens Freimann wrote: This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs

Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 1:22 PM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing nativ

Re: [dpdk-dev] [PATCH v2 01/21] net/atlantic: atlantic PMD driver skeleton

2018-09-21 Thread Ferruh Yigit
On 9/13/2018 12:35 PM, Igor Russkikh wrote: > From: Pavel Belous > > Makefile/meson build infrastructure, atl_ethdev minimal skeleton, > header with aquantia aQtion NIC device and vendor IDs. > > Signed-off-by: Igor Russkikh > --- > config/common_base| 9 + >

Re: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Thursday, September 20, 2018 7:30 AM > To: Didier Pallard ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/4] fix missing Tx multi segs capabilities > > > > > -Original Message

Re: [dpdk-dev] [PATCH] net/fm10k: add imissed stats

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Wang, Xiao W > Sent: Tuesday, September 11, 2018 9:52 AM > To: Julien Meunier ; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/fm10k: add imissed stats > > Hi, > > -Original Message- > From: Julien Meunier [mailto:julien.meun...@nokia.

Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy polling while fiber link update

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Wednesday, September 12, 2018 4:29 PM > To: Ilya Maximets ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Laurent Hardy > ; Dai, Wei ; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v1] e1000: support dev reset

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Tuesday, September 18, 2018 4:57 PM > To: dev@dpdk.org > Cc: Gaetan Rivet > Subject: [dpdk-dev] [PATCH v1] e1000: support dev reset > > Add support for passive device reset on IGB ports. >

Re: [dpdk-dev] [PATCH v2 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver

2018-09-21 Thread Kevin Traynor
On 09/13/2018 01:22 PM, Igor Russkikh wrote: > Hello DPDK community! > > Aquantia would like to contribute PMD for aQtion AQC10X NIC family: > https://www.aquantia.com/products/aqtion/chips/ > These are 10G ethernet NICs with various features. > > We do base this work on parts of the existing nat

Re: [dpdk-dev] [PATCH v4 0/3] AVF build improvements

2018-09-21 Thread Zhang, Qi Z
> -Original Message- > From: Richardson, Bruce > Sent: Wednesday, September 19, 2018 6:04 PM > To: Wu, Jingjing ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh > ; Richardson, Bruce > Subject: [PATCH v4 0/3] AVF build improvements > > This set adds a number of build im

Re: [dpdk-dev] [PATCH 4/6] crypto/mvsam: add support for AES ECB

2018-09-21 Thread Andrzej Ostruszka
Akhil This is ECB mode so AFAIU there is no need for IV as this is not feed forward/back type of algo and there is nothing extra needed by the first block (same thing in ccp driver). I'm leaving this as it is (same for 3DES). On 17.09.2018 15:59, Akhil Goyal wrote: > On 8/24/2018 7:24 PM, Tomasz

Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool

2018-09-21 Thread Thomas Monjalon
21/09/2018 15:47, Ferruh Yigit: > On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > > When trying to include stdbool.h in DPDK base headers, there are a lot > > of conflicts with drivers which redefine bool/true/false > > in their compatibility layer. > > > > It is fixed by including stdbool.h in the

Re: [dpdk-dev] [PATCH 3/6] crypto/mvsam: add support for HMAC SHA224

2018-09-21 Thread Andrzej Ostruszka
On 17.09.2018 15:57, Akhil Goyal wrote: > Hi Tomasz, > > On 8/24/2018 7:24 PM, Tomasz Duszynski wrote: >> Add support for the HMAC SHA224 authentication algorithm. [...] >> { /* SHA224 */ >> .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC, >> {.sym = { > doc shall also be u

[dpdk-dev] [PATCH v2 1/6] crypto/mvsam: fix shared library build

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add missing rte_kvargs library dependency. Without that shared library build fails due to unresolved rte_kvargs_* symbols. Fixes: 25b05a1c806b ("crypto/mvsam: parse max number of sessions") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Tomasz Duszy

[dpdk-dev] [PATCH v2 0/6] crypto/mvsam: add new features and fixes

2018-09-21 Thread Andrzej Ostruszka
This patch series introduces following changes: * Add support for HMAC SHA224, AES ECB and NULL algorithms. * Update hash digest sizes to match hardware capabilities. * Fix a shared build. v2: * added Cc: sta...@dpdk.org to couple of patches * rephrased the subject/commit msgs Szymon Sliwa (

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] net/sfc: fix an Rx queue double release possibility

2018-09-21 Thread Ferruh Yigit
On 9/14/2018 8:31 AM, Andrew Rybchenko wrote: > From: Igor Romanov > > There are two function that call sfc_rx_qfini(): > sfc_rx_fini_queues() and sfc_rx_queue_release(). But only > sfc_rx_queue_release() sets rx_queues pointer of the device data to NULL. > It may lead to the scenario in which a

[dpdk-dev] [PATCH v2 4/6] crypto/mvsam: support for AES ECB

2018-09-21 Thread Andrzej Ostruszka
From: Tomasz Duszynski Add support for AES128/192/256 in ECB mode. Signed-off-by: Tomasz Duszynski Reviewed-by: Natalie Samsonov --- drivers/crypto/mvsam/rte_mrvl_pmd.c | 5 + drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 20 2 files changed, 25 insertions(+) diff -

  1   2   >