On Thu, Sep 20, 2018 at 06:17:13PM +0200, Thomas Monjalon wrote:
> 19/09/2018 18:03, Gaetan Rivet:
> > The eth device class can now parse a field name,
> > matching the eth_dev name with one passed as
> > 
> >    "class=eth,name=xxxxxx"
> 
> I am not sure what is the purpose of the "name" property.
> I think we should not need it to choose a port by its ethdev name.

rte_eth_dev_get_port_by_name seems pretty close.
Which fields do you think should be proposed first as a getter on the eth class?
Or do you have a list of fields the eth class should be restricted to?

> If you are thinking about a vdev, we can use the rte_device name (at bus 
> level).

This patch is only about eth class, it has no impact on buses.

-- 
Gaëtan Rivet
6WIND

Reply via email to