Re: [dpdk-dev] [RFC] mlx5: fix error unwind in device start

2018-08-14 Thread Shahaf Shuler
Monday, August 13, 2018 6:21 PM, Stephen Hemminger: > Subject: Re: [RFC] mlx5: fix error unwind in device start > > The issue was caused in an early version of netvsc VF support where it forgot > to call dev_configure on the mlx5 device. In that case mlx5 would get > confused and stuck. I see, we

[dpdk-dev] [PATCH 0/5] AESNI MB PMD changes

2018-08-14 Thread Pablo de Lara
The Multi-buffer library supports full digest sizes for the HMAC algorithms (except for MD5), from 0.50 version. Also, since 0.50, keys larger than the algorithm block size can be used for HMAC algorithms, performing a hash on the key. Therefore, the AESNI MB PMD now supports any key size for the

[dpdk-dev] [PATCH 1/5] crypto/aesni_mb: support all truncated HMAC digest sizes

2018-08-14 Thread Pablo de Lara
HMAC algorithms (MD5 and SHAx) have different full digest sizes. However, they are often truncated to a smaller size (such as in IPSec). This commit allows a user to generate a digest of any size up to the full size. Signed-off-by: Pablo de Lara Guarch --- drivers/crypto/aesni_mb/rte_aesni_mb_pm

[dpdk-dev] [PATCH 2/5] crypto/aesni_mb: check for invalid digest size

2018-08-14 Thread Pablo de Lara
When creating a crypto session, check if ther requested digest size is supported for AES-XCBC-MAC and AES-CCM. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pm

[dpdk-dev] [PATCH 3/5] crypto/aesni_mb: fix truncated digest size for CMAC

2018-08-14 Thread Pablo de Lara
The truncated digest size for AES-CMAC is 12 and not 16, as the Multi-buffer library can output both 12 and 16 bytes. Fixes: 6491dbbecebb ("crypto/aesni_mb: support AES CMAC") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd_private.h | 2 +- 1 file

[dpdk-dev] [PATCH 5/5] crypto/aesni_mb: support large HMAC key sizes

2018-08-14 Thread Pablo de Lara
Add support for SHAx-HMAC key sizes larger than the block size. For these sizes, the input key is digested with the non-HMAC version of the algorithm and used as the key. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/aesni_mb_ops.h| 61 +++ drivers/crypto/aesni

[dpdk-dev] [PATCH 4/5] crypto/aesni_mb: support all truncated CMAC digest sizes

2018-08-14 Thread Pablo de Lara
The full digest size of CMAC algorithm is 16 bytes. However, it is sometimes truncated to a smaller size (such as in IPSec). This commit allows a user to generate a digest of any size up to the full size. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c| 26 +++

[dpdk-dev] [PATCH] crypto/aesni_gcm: remove unneeded J0 calculation

2018-08-14 Thread Pablo de Lara
When IV size is 12, padding to 16 bytes is required and the LSB must be set to 1, according to the spec. However, the Multi-buffer library is already doing this, so it is not necessary to do it in the PMD. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 9 - 1

[dpdk-dev] [PATCH] crypto/aesni_gcm: support all truncated digest sizes

2018-08-14 Thread Pablo de Lara
The full digest size of GCM/GMAC algorithms is 16 bytes. However, it is sometimes truncated to a smaller size (such as in IPSec). This commit allows a user to generate a digest of any size up to the full size. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 79 ++

Re: [dpdk-dev] [RFC] ethdev: add generic MAC address rewrite actions

2018-08-14 Thread Jack MIN
On Mon, Aug 13, 2018 at 03:38:18PM +0530, Rahul Lakkireddy wrote: > On Tuesday, August 08/07/18, 2018 at 14:20:10 +, Jack Min wrote: > > There is a need to offload rewrite MAC address for both destination and > > source > > from the matched flow > > > > The proposed actions could make above e

Re: [dpdk-dev] [RFC 0/9] Modularize and enhance DPDK Python scripts

2018-08-14 Thread Burakov, Anatoly
On 25-Jun-18 4:59 PM, Anatoly Burakov wrote: This patchset attempts to create a library out of Python scripts that come with DPDK, with a goal of enabling external tools to get the same information about the system DPDK has, and perhaps configure DPDK. Potential applications include: * Better s

Re: [dpdk-dev] [RFC 0/3] Make device mapping more reliable

2018-08-14 Thread Burakov, Anatoly
On 31-May-18 11:57 AM, Anatoly Burakov wrote: Currently, memory for device maps is allocated ad-hoc, by calculating end of VA space allocated for hugepages and crossing fingers in hopes that those addresses will be free in primary and secondary processes. This leads to situations such as this: E

Re: [dpdk-dev] [PATCH v2 00/12] preparing l2fwd for eventmode additions

2018-08-14 Thread Bruce Richardson
On Mon, Aug 13, 2018 at 09:29:01PM +0530, Joseph, Anoob wrote: > Hi Bruce, > > The reason why l2fwd was chosen was to allow everyone to chip in their ideas > while preparing the framework. > This framework would be extended to other applications, hence needed enough > inputs before expanding to co

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-14 Thread Neil Horman
On Tue, Aug 14, 2018 at 09:23:59AM +0530, Rao, Nikhil wrote: > On 6/27/2018 11:31 PM, Neil Horman wrote: > > diff --git a/devtools/check-symbol-change.sh > > b/devtools/check-symbol-change.sh > > new file mode 100755 > > index 0..17d123cf4 > > --- /dev/null > > +++ b/devtools/check-symbol-

[dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow action hash type selection

2018-08-14 Thread Shahaf Shuler
On the code after the below commits, the criteria to select the IPV4 or IPV6 hash functions was the existence of some ETH_RSS_IPV4 RSS types on the flow rule. The check is wrong. For example ETH_RSS_NONFRAG_IPV4_TCP will not select the IPV4 hash which will cause the packet to be spread in a bad wa

Re: [dpdk-dev] [RFC 1/2] vhost: add packed ring support to vring base requests

2018-08-14 Thread Maxime Coquelin
Hi Jens, On 08/10/2018 09:09 AM, Jens Freimann wrote: On Wed, Aug 08, 2018 at 05:23:22PM +0200, Maxime Coquelin wrote: For consistency with Vhost kernel backend, save the wrap counter value into bit 31 of num's vring state field. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_user.

[dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-14 Thread Luca Boccassi
From: Brian Russell In virtio_read_caps, rte_pci_read_config returns the number of bytes read from PCI config or < 0 on error. If less than the expected number of bytes are read then log the failure and return rather than carrying on with garbage. Signed-off-by: Brian Russell --- Follow-up fro

[dpdk-dev] [PATCH 1/2] bus/pci: harmonize and document rte_pci_read_config return value

2018-08-14 Thread Luca Boccassi
On Linux, rte_pci_read_config on success returns the number of read bytes, but on BSD it returns 0. Document the return values, and have BSD behave as Linux does. At least one case (bnx2x PMD) treats 0 as an error, so the change makes sense also for that. Signed-off-by: Luca Boccassi --- driver

[dpdk-dev] [Bug 81] Use of rte_memseg_contig_walk in vhost_kernel.c causes deadlock

2018-08-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=81 Bug ID: 81 Summary: Use of rte_memseg_contig_walk in vhost_kernel.c causes deadlock Product: DPDK Version: 18.08 Hardware: All OS: All Status: CONFIRMED

[dpdk-dev] [PATCH] doc: add cross compile part for sample applications

2018-08-14 Thread Gavin Hu
Fixes: 7cacb05655 ("doc: add generic build instructions for sample apps") Cc: sta...@dpdk.org Signed-off-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli --- doc/guides/sample_app_ug/compiling.rst | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/doc/guides/samp

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix RSS flow action hash type selection

2018-08-14 Thread Yongseok Koh
> On Aug 14, 2018, at 4:17 AM, Shahaf Shuler wrote: > > On the code after the below commits, the criteria to select the IPV4 or > IPV6 hash functions was the existence of some ETH_RSS_IPV4 RSS types on > the flow rule. > > The check is wrong. For example ETH_RSS_NONFRAG_IPV4_TCP will not selec

Re: [dpdk-dev] [PATCH] net/mlx5: disable ConnectX-4 Lx Multi Packet Send by default

2018-08-14 Thread Yongseok Koh
On Mon, Aug 13, 2018 at 10:00:18AM +0300, Shahaf Shuler wrote: > On ConnectX-4 Lx the Multi Packet Send (MPW) feature is considered > un-secure, as on some cases were the application provides incorrect mbufs > on the Tx burst the host or NIC can get stuck. > > Hence, disabling the feature by defau

[dpdk-dev] [PATCH v3] netvsc: resize event buffer as needed

2018-08-14 Thread Stephen Hemminger
The event buffer was changed to be a fixed size value, had a couple of issues. The big one is that rte_free was still being called for a pointer that was not setup with rte_malloc(). The event buffer was also too small to handle heavy receive traffic; and running the event buffer out would crash t

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-14 Thread Stephen Hemminger
On Tue, 14 Aug 2018 05:52:20 + Matan Azrad wrote: > Hi Stephen > > From: Stephen Hemminger > > The rte_eth_dev_owner_unset function is unusable because it always > > returns -EINVAL. This is because the magic (unowned) value is flagged as not > > valid. > > > > It's OK to raise an error

[dpdk-dev] [PATCH] doc: add mlx5 limitation of RSS hash result

2018-08-14 Thread Yongseok Koh
Signed-off-by: Yongseok Koh --- doc/guides/nics/mlx5.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 52e1213cf5..cbcc233d03 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -136,6 +136,12 @@ Limitations

Re: [dpdk-dev] [PATCH] ethdev: fix rte_eth_dev_owner_unset

2018-08-14 Thread Matan Azrad
Hi Stephen From: Stephen Hemminger > On Tue, 14 Aug 2018 05:52:20 + > Matan Azrad wrote: > > > Hi Stephen > > > > From: Stephen Hemminger > > > The rte_eth_dev_owner_unset function is unusable because it always > > > returns -EINVAL. This is because the magic (unowned) value is > > > flagged

Re: [dpdk-dev] [PATCH v14 1/6] ethdev: add function to release port in secondary process

2018-08-14 Thread Zhang, Qi Z
Thanks for the capture, will fix in v15. > -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Sunday, August 12, 2018 7:05 PM > To: Zhang, Qi Z ; tho...@monjalon.net; > gaetan.ri...@6wind.com; Burakov, Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; >

Re: [dpdk-dev] [PATCH v14 4/6] drivers/net: enable hotplug on secondary process

2018-08-14 Thread Zhang, Qi Z
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Sunday, August 12, 2018 7:00 PM > To: Zhang, Qi Z ; tho...@monjalon.net; > gaetan.ri...@6wind.com; Burakov, Anatoly ; > arybche...@solarflare.com > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson

Re: [dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on secondary

2018-08-14 Thread Zhang, Qi Z
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Sunday, August 12, 2018 6:51 PM > To: Zhang, Qi Z ; tho...@monjalon.net; > gaetan.ri...@6wind.com; Burakov, Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; S

Re: [dpdk-dev] [RFC 1/4] ethdev: claim device reset as async

2018-08-14 Thread Zhang, Qi Z
> -Original Message- > From: Kevin Traynor [mailto:ktray...@redhat.com] > Sent: Wednesday, August 8, 2018 7:15 PM > To: Zhang, Qi Z ; tho...@monjalon.net; Ananyev, > Konstantin ; Doherty, Declan > ; Yigit, Ferruh > Cc: dev@dpdk.org; Shelton, Benjamin H ; > Vangati, Narender ; Xing, Beile

Re: [dpdk-dev] [PATCH 2/2] virtio: fix PCI config err handling

2018-08-14 Thread Tiwei Bie
On Tue, Aug 14, 2018 at 03:30:35PM +0100, Luca Boccassi wrote: > From: Brian Russell > > In virtio_read_caps, rte_pci_read_config returns the number of bytes > read from PCI config or < 0 on error. > If less than the expected number of bytes are read then log the > failure and return rather than

Re: [dpdk-dev] [PATCH] net/virtio-user: check negotiated features before set

2018-08-14 Thread Tiwei Bie
On Thu, Aug 09, 2018 at 01:34:55PM -0500, Allain Legacy wrote: > From: eric zhang > > This patch checks negotiated features to see if necessary to offload > before set the tap device offload capabilities. It also checks if kernel > support the TUNSETOFFLOAD operation. > > Signed-off-by: eric zha

Re: [dpdk-dev] [PATCH v9] checkpatches.sh: Add checks for ABI symbol addition

2018-08-14 Thread Nikhil Rao
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > I was about to say that its because you've not got enough context to let the > awk file figure out what your section name is, but that doesn't appear to be > the case. Can you provide the exact command line you are ru