> -----Original Message----- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Sunday, August 12, 2018 6:51 PM > To: Zhang, Qi Z <qi.z.zh...@intel.com>; tho...@monjalon.net; > gaetan.ri...@6wind.com; Burakov, Anatoly <anatoly.bura...@intel.com> > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org; > Richardson, Bruce <bruce.richard...@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com>; Shelton, Benjamin H > <benjamin.h.shel...@intel.com>; Vangati, Narender > <narender.vang...@intel.com> > Subject: Re: [dpdk-dev] [PATCH v14 5/6] drivers/net: enable device detach on > secondary > > On 10.08.2018 03:42, Qi Zhang wrote: > > With the enabling for hotplug on multi-process, it is not necessary to > > prevent detaching a device from a secondary process. > > > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com> > > From the patch itself including description it is absolutely unclear why > detach works and where it actually happens.
OK, I will add more detail comment. > Why is it OK to return 0 instead of error and that's it. Obviously , something need to fix, since uninit is not only called by driver->remove > Why is it necessary to call uninit at all in the case of secondary processes? Will parse NULL to rte_eth_dev_pci_generic_remove for secondary process.
