Space for string terminating NUL character should be provided to
snprintf() to avoid the last symbol truncation.
Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function")
Reported-by: Ivan Malov
Signed-off-by: Andrew Rybchenko
---
lib/librte_eal/common/eal_common_devargs.c | 2 +-
1 f
Hi Konstantin.
> Hi Alex,
> Sorry for delay in reply.
>> >> There might be situations (kind of attack when a lot of
>> >> fragmented packets are sent to a dpdk application in order
>> >> to flood the fragmentation table) when no additional mbufs
>> >> must be added to the fragmentations table sin
On 7/17/2018 7:32 PM, Jasvinder Singh wrote:
> Improve description of api used to get port name from port id or
> vice-versa.
>
> Signed-off-by: Jasvinder Singh
Reviewed-by: Ferruh Yigit
https://bugs.dpdk.org/show_bug.cgi?id=72
Stanislav Chlebec (stanislav.chle...@gmail.com) changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Return value equal to zero means success and really expected.
Fixes: 0fa0070e4391 ("net/sfc: support multicast addresses list controls")
Cc: sta...@dpdk.org
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
Fix debug build assertion if unknown L3 packet is received.
Fixes: 638bddc99faa ("net/sfc: implement EF10 native Rx datapath")
Fixes: c121f00836ca ("net/sfc: move EF10 Rx event parser to shared header")
Cc: sta...@dpdk.org
Signed-off-by: Andrew Rybchenko
---
drivers/net/sfc/sfc_ef10_rx_ev.h | 2
On 7/13/2018 7:16 AM, Shahaf Shuler wrote:
>
> Thursday, July 12, 2018 3:02 PM, Mordechay Haimovsky:
>> Subject: [PATCH v3] net/mlx5: add support for 32bit systems
>>
>> This patch adds support for building and running mlx5 PMD on 32bit systems
>> such as i686.
>>
>> The main issue to tackle was h
On 6/29/2018 4:16 PM, Andrew Rybchenko wrote:
> On 06/29/2018 12:44 PM, Jerin Jacob wrote:
>> The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change
>> to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS)
>>
>> Fixes: 5de201df8927 ("ethdev: add stats per queue")
>> Cc: sta...@dpdk.org
>>
>>
On 7/6/2018 7:43 AM, Nelio Laranjeiro wrote:
> This series adds an easy and maintainable configuration version support for
> those two actions for 18.08 by using global variables in testpmd to store the
> necessary information for the tunnel encapsulation. Those variables are used
> in conjunction
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Krzysztof Kanas
> Sent: Tuesday, July 10, 2018 7:51 AM
> To: krzysztof.ka...@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo
> ; Wu, Jingjing
> Cc: Nithin Dabilpuram ; t...@semihalf.com
> Subject: [dpdk-dev] [PATCH
Hi,
On Wed, Jul 18, 2018 at 08:23:30AM +0100, Andrew Rybchenko wrote:
> Space for string terminating NUL character should be provided to
> snprintf() to avoid the last symbol truncation.
>
> Fixes: a23bc2c4e01b ("devargs: add non-variadic parsing function")
>
> Reported-by: Ivan Malov
> Signed-
Hi Krzysztof,
> -Original Message-
> From: Krzysztof Kanas [mailto:krzysztof.ka...@caviumnetworks.com]
> Sent: Tuesday, July 10, 2018 7:51 AM
> To: krzysztof.ka...@caviumnetworks.com; dev@dpdk.org; Lu, Wenzhuo
> ; Wu, Jingjing ; Iremonger,
> Bernard
> Cc: Nithin Dabilpuram
> Subject: [PA
On 17-Jul-18 5:00 PM, Reshma Pattan wrote:
Makefiles are updated with new test case lists.
Test cases are classified as -
P1 - Main test cases,
P2 - Cryptodev/driver test cases,
P3 - Perf test cases which takes longer than 10s,
P4 - Logging/Dump test cases.
Makefile is updated with different tar
On 17-Jul-18 5:00 PM, Reshma Pattan wrote:
make rule test-basic is duplicate of test rule.
removed unused test-mempool and test-ring make rules.
Fixes: a3df7f8d9c ("mk: rename test related rules")
Fixes: a3df7f8d9c ("mk: rename test related rules")
Fixline appears two times :) Thomas can fix i
On 7/9/2018 6:14 PM, Alejandro Lucero wrote:
> This is a patched to fix a functionality coming with the first public
> release: changing/setting MAC address.
>
> The original patch assumes all NICs can safely change or set the MAC
> in any case. However, this is not always true. NFP depends on the
On 7/6/2018 3:42 PM, Rahul Lakkireddy wrote:
> Signed-off-by: Rahul Lakkireddy
Applied to dpdk-next-net/master, thanks.
16/07/2018 22:52, Gaëtan Rivet:
> Hi Pablo,
>
> On Mon, Jul 16, 2018 at 07:26:27AM +0100, Pablo de Lara wrote:
> > Fixed possible out-of-bounds issue:
> >
> > lib/librte_eal/common/eal_common_devargs.c:
> > In function ‘rte_devargs_layers_parse’:
> > lib/librte_eal/common/eal_common_devargs.c
On 7/9/2018 9:21 PM, Gage Eads wrote:
> Set the rx and tx queue state appropriately when the queues or device are
> started or stopped.
Is there a specific reason to enable these dev_ops, if so can you please
document in commit log?
>
> Signed-off-by: Gage Eads
> ---
> drivers/net/pcap/rte_eth
On 7/9/2018 4:43 PM, Rahul Lakkireddy wrote:
> Add decode logic for new flash parts shipped with new Chelsio NICs
> to fix initialization failure on these NICs.
>
> Cc: sta...@dpdk.org
I guess Fixes not added intentionally since this is not fixing a previous code
but fixing a behavior with new fl
On 7/11/2018 10:05 AM, Jerin Jacob wrote:
> -Original Message-
>> Date: Wed, 11 Jul 2018 13:54:36 +0530
>> From: Kiran Kumar
>> To: jerin.ja...@caviumnetworks.com, maciej.cze...@caviumnetworks.com,
>> ferruh.yi...@intel.com
>> Cc: dev@dpdk.org, Kiran Kumar ,
>> sta...@dpdk.org
>> Subject
On Wednesday, July 07/18/18, 2018 at 14:56:12 +0530, Ferruh Yigit wrote:
> On 7/9/2018 4:43 PM, Rahul Lakkireddy wrote:
> > Add decode logic for new flash parts shipped with new Chelsio NICs
> > to fix initialization failure on these NICs.
> >
> > Cc: sta...@dpdk.org
>
> I guess Fixes not added i
Fixes: bd475cefc7cb ("app/testpmd: fix use of uninitialized field")
Cc: krzysztof.ka...@caviumnetworks.com
Signed-off-by: Krzysztof Kanas
---
v2:
* Fix the Fixes commit message line
---
app/test-pmd/cmdline_tm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmd
On 7/16/2018 4:02 AM, Lu, Wenzhuo wrote:
> Hi,
>
>> -Original Message-
>> From: Li, Xiaoyun
>> Sent: Thursday, July 12, 2018 3:56 PM
>> To: Zhang, Qi Z ; Lu, Wenzhuo
>>
>> Cc: dev@dpdk.org; Li, Xiaoyun ; sta...@dpdk.org
>> Subject: [PATCH v3] app/testpmd: fix little perf drop
>>
>> There
On 7/18/2018 3:15 AM, John Daley wrote:
> From: Hyong Youb Kim
>
> Make a few updates in preparation for 18.08.
> - Use SPDX
> - Add 1400 series VIC adapters to supported models
> - Describe the VXLAN port number
> - Expand the description for ig-vlan-rewrite
> - Add inner RSS and checksum to the
On 7/14/2018 2:34 AM, Rasesh Mody wrote:
> We were using LICENSE.qede_pmd to reference inclusion of SPDX licensing
> tag from all the source file. Remove the LICENSE.qede_pmd file and
> directly include SPDX tags in source files.
>
> Signed-off-by: Rasesh Mody
Acked-by: Hemant Agrawal
Applied
> -Original Message-
> From: Bie, Tiwei
> Sent: Tuesday, July 17, 2018 9:11 PM
> To: maxime.coque...@redhat.com; Wang, Zhihong
> ; dev@dpdk.org
> Cc: Wang, Yinan ; Yao, Lei A
> Subject: [PATCH] vhost: fix buffer length calculation
>
> Fixes: fd68b4739d2c ("vhost: use buffer vectors in
Currently, we need runtime dir to put all of our runtime info in,
including the DPDK shared config. However, we use the shared
config to determine our proc type, and this happens earlier than
we actually create the config dir and thus can know where to
place the config file.
Fix this by moving run
setting up the bonding options before calling rte_eth_dev_probing_finish
triggers an invalid port id error because of port state not set, or set
unused
Fixes: fbe90cdd776c ("ethdev: add probing finish function")
Cc: sta...@dpdk.org
Signed-off-by: Radu Nicolau
---
drivers/net/bonding/rte_eth_bon
remove queue id checks from dev_ops
ixgbe_dev_[rx/tx]_queue_[start/stop]
queue id checks already done by ethdev APIs that are calling these
dev_ops
Signed-off-by: Ferruh Yigit
---
Cc: Keith Wiles
---
drivers/net/ixgbe/ixgbe_rxtx.c | 139 +++--
1 file changed, 63 ins
remove queue id checks from dev_ops
i40e_dev_[rx/tx]_queue_[start/stop]
i40evf_dev_[rx/tx]_queue_[start/stop]
queue id checks already done by ethdev APIs that are calling these
dev_ops
Signed-off-by: Ferruh Yigit
---
Cc: Keith Wiles
---
drivers/net/i40e/i40e_ethdev_vf.c | 107 +++--
remove queue id checks from dev_ops
fm10k_dev_[rx/tx]_queue_[start/stop]
queue id checks already done by ethdev APIs that are calling these
dev_ops
Signed-off-by: Ferruh Yigit
---
Cc: Keith Wiles
---
drivers/net/fm10k/fm10k_ethdev.c | 119 ++-
1 file changed, 54 ins
On 7/14/2018 8:38 AM, Andrew Rybchenko wrote:
> From: Igor Romanov
>
> Now exception logic handles these cases:
>
> When FW variant does not support filters with transport ports, but
> IP protocol filters are supported, TCP/UDP protocol filters may be
> used. When FW variant does not support fil
On 7/14/2018 8:38 AM, Andrew Rybchenko wrote:
> From: Igor Romanov
>
> Fallback to filter with VLAN=0 if match without VLAN is not supported
> Strictly speaking it is not 100% equivalent, but good tradeoff -
> untagged and priority only tagged frames will match.
>
> Signed-off-by: Igor Romanov
On 7/18/2018 3:02 AM, John Daley wrote:
> From: Hyong Youb Kim
>
> enic_set_mtu always reverts to the default Rx handler after changing
> MTU. Try to use the simpler, non-scatter handler in this case as well.
>
> Fixes: 35e2cb6a1795 ("net/enic: add simple Rx handler")
>
> Signed-off-by: Hyong Y
Hi Qi,
On Thu, Jul 12, 2018 at 10:01:41PM +0800, Qi Zhang wrote:
> If hotplug add an already plugged PCI device, it will
> cause rte_pci_device->device.name be corrupted due to unexpected
> rte_devargs_remove. Also if try to hotplug remove an already
> unplugged device, it will cause segment fault
On Thu, Jul 12, 2018 at 10:01:42PM +0800, Qi Zhang wrote:
> When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr)
> is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr
> is valid. So compare the 8th byte will cause the unexpected result, which
> happens when
Moved the link status validity check from the slave add to the slave
activation step. Otherwise slave add will fail for mode 4 if
the ports are all stopped but only one of them checked.
Removed activate slave call from slave add function.
Fixes: b77d21cc2364 ("ethdev: add link status get/set help
On 7/16/2018 10:26 AM, Pavan Nikhilesh wrote:
> Add L3/L4 Rx checksum offload and update capabilities.
>
> Signed-off-by: Pavan Nikhilesh
> ---
> v2 Changes:
> - Add Rx checksum offload support for l3fwd.
Overall looks good to me, any ack from driver maintainers?
Do not exit the application if power library fails to initialize
or high performance cores configuration cannot be used.
Signed-off-by: Radu Nicolau
---
examples/l3fwd-power/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/examples/l3fwd-power/main.c b/examples/l3fw
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, July 18, 2018 4:14 AM
> To: Eads, Gage ; dev@dpdk.org
> Subject: Re: [PATCH] net/pcap: set queue started and stopped
>
> On 7/9/2018 9:21 PM, Gage Eads wrote:
> > Set the rx and tx queue state appropriately when the queues or
On 7/18/2018 3:17 PM, Eads, Gage wrote:
>
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Wednesday, July 18, 2018 4:14 AM
>> To: Eads, Gage ; dev@dpdk.org
>> Subject: Re: [PATCH] net/pcap: set queue started and stopped
>>
>> On 7/9/2018 9:21 PM, Gage Eads wrote:
>>> Set the rx an
From: Alan Dewar
Add new APIs to retrieve counters in 64-bit wide fields.
Signed-off-by: Alan Dewar
---
lib/librte_sched/rte_sched.c | 72
lib/librte_sched/rte_sched.h | 76 ++
lib/librte_sched/rte_sched_versi
> On Jul 17, 2018, at 10:43 PM, wubenq...@ruijie.com.cn wrote:
>
> Hi~
>Reference:
> http://doc.dpdk.org/guides-18.05/sample_app_ug/performance_thread.html?highlight=lthread
>The L-thread subsystem provides a set of functions that are logically
> equivalent to the corresponding functio
Add L3/L4 Rx checksum offload and update capabilities.
Signed-off-by: Pavan Nikhilesh
---
v3 Changes:
- rebase on top of next-net
v2 Changes:
- Add Rx checksum offload support for l3fwd.
drivers/net/thunderx/nicvf_ethdev.c | 33 -
drivers/net/thunderx/nicvf_ethdev.h | 1 +
dri
From: "Kudurumalla, Rakesh"
This feature is used to offload stripping of vlan header from recevied
packets and update vlan_tci field in mbuf when
DEV_RX_OFFLOAD_VLAN_STRIP & ETH_VLAN_STRIP_MASK flag is set.
Signed-off-by: Rakesh Kudurumalla
Signed-off-by: Pavan Nikhilesh
---
drivers/net/thund
Hi Anatoly,
I'm investigating issue which finally comes to the fact that memory
allocated using
rte_zmalloc() has non zeros.
If I add memset just after allocation, everything is perfect and works fine.
I've found out that memset was removed from rte_zmalloc_socket() some
time ago:
>>>
comm
13/07/2018 10:43, Hunt, David:
>
> On 13/7/2018 9:33 AM, Thomas Monjalon wrote:
> > 13/07/2018 10:31, Hunt, David:
> >> Hi Thomas,
> >>
> >> On 12/7/2018 8:09 PM, Thomas Monjalon wrote:
> >>> 26/06/2018 11:23, David Hunt:
> This patch set adds the capability to do out-of-band power
> mon
> -Original Message-
> From: Burakov, Anatoly
> Sent: Wednesday, July 18, 2018 11:54 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce ; Xu, Qian Q
> ; Yao, Lei A ; Lu, PeipeiX
>
> Subject: [PATCH] eal: fix circular dependency in EAL proc type detection
>
> Currently, we need runtime dir t
> -Original Message-
> From: Yigit, Ferruh
> Sent: Wednesday, July 18, 2018 9:25 AM
> To: Eads, Gage ; dev@dpdk.org
> Subject: Re: [PATCH] net/pcap: set queue started and stopped
>
> On 7/18/2018 3:17 PM, Eads, Gage wrote:
> >
> >
> >> -Original Message-
> >> From: Yigit, Ferruh
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Andrew Rybchenko
> Sent: Wednesday, July 18, 2018 4:20 PM
> To: Burakov, Anatoly
> Cc: dev@dpdk.org; Sergio Gonzalez Monroy
>
> Subject: [dpdk-dev] Memory allocated using rte_zmalloc() has non-zeros
>
> Hi Anat
On 7/18/2018 5:04 PM, Eads, Gage wrote:
>
>
>> -Original Message-
>> From: Yigit, Ferruh
>> Sent: Wednesday, July 18, 2018 9:25 AM
>> To: Eads, Gage ; dev@dpdk.org
>> Subject: Re: [PATCH] net/pcap: set queue started and stopped
>>
>> On 7/18/2018 3:17 PM, Eads, Gage wrote:
>>>
>>>
--
Set the rx and tx queue state appropriately when the queues or device are
started or stopped. This enables usage of the ethdev rx/tx queue start/stop
functions with the PCAP PMD.
Signed-off-by: Gage Eads
---
v2 changes:
- Expand the commit message
- Fix queue start/stop state setting in eth_dev_s
On 18-Jul-18 4:20 PM, Andrew Rybchenko wrote:
Hi Anatoly,
I'm investigating issue which finally comes to the fact that memory
allocated using
rte_zmalloc() has non zeros.
If I add memset just after allocation, everything is perfect and works
fine.
I've found out that memset was removed fro
-Original Message-
> Date: Wed, 18 Jul 2018 20:35:01 +0530
> From: Pavan Nikhilesh
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
> rkuduruma...@caviumnetworks.com, ferruh.yi...@intel.com
> Cc: dev@dpdk.org, Pavan Nikhilesh
> Subject: [dpdk-dev] [PATCH v3 1/2] n
-Original Message-
> Date: Wed, 18 Jul 2018 20:35:02 +0530
> From: Pavan Nikhilesh
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com,
> rkuduruma...@caviumnetworks.com, ferruh.yi...@intel.com
> Cc: dev@dpdk.org, "Kudurumalla, Rakesh" ,
> Pavan Nikhilesh
> Subject:
-Original Message-
> Date: Tue, 17 Jul 2018 20:03:07 +0530
> From: Pavan Nikhilesh
> To: jerin.ja...@caviumnetworks.com, santosh.shu...@caviumnetworks.com
> Cc: dev@dpdk.org, Pavan Nikhilesh
> Subject: [dpdk-dev] [PATCH] app/eventdev: use proper teardown sequence
> X-Mailer: git-send-emai
https://bugs.dpdk.org/show_bug.cgi?id=2
Ajit Khaparde (ajit.khapa...@broadcom.com) changed:
What|Removed |Added
Status|IN_PROGRESS |RESOLVED
Resolu
On 18.07.2018 20:18, Burakov, Anatoly wrote:
On 18-Jul-18 4:20 PM, Andrew Rybchenko wrote:
Hi Anatoly,
I'm investigating issue which finally comes to the fact that memory
allocated using
rte_zmalloc() has non zeros.
If I add memset just after allocation, everything is perfect and
works fi
On Wed, 18 Jul 2018 22:52:12 +0300
Andrew Rybchenko wrote:
> On 18.07.2018 20:18, Burakov, Anatoly wrote:
> > On 18-Jul-18 4:20 PM, Andrew Rybchenko wrote:
> >> Hi Anatoly,
> >>
> >> I'm investigating issue which finally comes to the fact that memory
> >> allocated using
> >> rte_zmalloc() has
If the patch filename or the temporary file path have a space
in their name, the script check-symbol-change.sh does not work.
The variables for the filenames must be enclosed in quotes
in order to preserve spaces.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: nhor...@tux
17/07/2018 11:48, Stojaczyk, DariuszX:
> From: Burakov, Anatoly
> >
> > The original code did not align any addresses that were requested as
> > page-aligned, but were different because addr_is_hint was set.
> >
> > Below fix by Dariusz has introduced an issue where all unaligned addresses
> > we
If the patch filename or the temporary file path have a space
in their name, the script check-symbol-change.sh does not work.
The variables for the filenames must be enclosed in quotes
in order to preserve spaces.
Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition")
Cc: nhor...@tux
Hi Pablo,
This patch solves the bug.
Thanks
Ankur
From: Pablo de Lara
Sent: Monday, July 16, 2018 1:56:16 PM
To: Dwivedi, Ankur; declan.dohe...@intel.com
Cc: dev@dpdk.org; Pablo de Lara; sta...@dpdk.org
Subject: [PATCH] examples/l2fwd-crypto: fix digest with
DPDK malloc library allows broken programs to work because
the semantics of zmalloc and malloc are the same.
This patch changes to a more secure model which will catch
(and crash) programs that reuse memory already freed.
This supersedes earlier changes to zero memory on free and
avoid zeroing me
On Tue, Jul 17, 2018 at 09:10:35PM +0800, Tiwei Bie wrote:
> Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path")
>
> Reported-by: Yinan Wang
> Signed-off-by: Tiwei Bie
Above fix can fix below issue:
https://mails.dpdk.org/archives/dev/2018-July/108137.html
Tested-by: Yinan Wang
Hi~
If the lthreads run on different lcores, a race condition with lthread_mutex
may occur.
Like this:
lthread1 run on lcore=1
lthread2 run on lcore=2
If the mutex is owned by lthread2, lthread1 try to lock the mutex that will
block thread1. lthread_sched on lcore1 will insert lthread1 t
On Tue, Jul 17, 2018 at 09:10:35PM +0800, Tiwei Bie wrote:
> Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path")
>
> Reported-by: Yinan Wang
> Signed-off-by: Tiwei Bie
Applied to dpdk-next-virtio/master, thanks.
> On Jul 18, 2018, at 7:34 PM, wubenq...@ruijie.com.cn wrote:
>
> Hi~
>
> If the lthreads run on different lcores, a race condition with lthread_mutex
> may occur.
> Like this:
> lthread1 run on lcore=1
> lthread2 run on lcore=2
> If the mutex is owned by lthread2, lthread1 try to lock
68 matches
Mail list logo
