Hi Qi, On Thu, Jul 12, 2018 at 10:01:41PM +0800, Qi Zhang wrote: > If hotplug add an already plugged PCI device, it will > cause rte_pci_device->device.name be corrupted due to unexpected > rte_devargs_remove. Also if try to hotplug remove an already > unplugged device, it will cause segment fault due to unexpected > bus->unplug on a rte_device whose driver is NULL. > The patch fix these issues. > > Fixes: 7e8b26650146 ("eal: fix hotplug add / remove") > Cc: sta...@dpdk.org > > Signed-off-by: Qi Zhang <qi.z.zh...@intel.com>
I think we should consolidate this API at some point, maybe list the possible error values as a part of it and remove the experimental tag. In any case, the fix seems correct, thanks, Acked-by: Gaetan Rivet <gaetan.ri...@6wind.com> -- Gaëtan Rivet 6WIND