Re: [dpdk-dev] [PATCH v3] rte_ring: clarify preemptible nature of ring algorithm

2018-07-16 Thread Olivier Matz
Hi, On Mon, Jul 09, 2018 at 11:00:47PM -0500, Honnappa Nagarahalli wrote: > rte_ring implementation is not preemptible only under certain > circumstances. This clarification is helpful for data plane and > control plane communication using rte_ring. > > Signed-off-by: Honnappa Nagarahalli > Revi

Re: [dpdk-dev] [PATCH v2 1/2] ring: fix declaration after code

2018-07-16 Thread Olivier Matz
On Mon, May 28, 2018 at 05:03:38PM +0800, Andy Green wrote: > On gcc 5.4.0 / native aarch64 from Ubuntu 16.04: > > /home/agreen/lagopus/src/dpdk/build/include/ > rte_ring_c11_mem.h: In function > '__rte_ring_move_prod_head': > /home/agreen/lagopus/src/dpdk/build/include/ > rte_ring_c11_mem.h:69:3:

Re: [dpdk-dev] [PATCH v2 2/2] ring: fix sign conversion warning

2018-07-16 Thread Olivier Matz
On Mon, May 28, 2018 at 05:03:43PM +0800, Andy Green wrote: > On gcc 5.4.0 / native aarch64 from Ubuntu 16.04: > > /home/agreen/lagopus/src/dpdk/build/include/rte_ring.h: > In function '__rte_ring_do_dequeue': > /home/agreen/lagopus/src/dpdk/build/include/rte_ring.h: > 385:35: warning: conversion

[dpdk-dev] [PATCH v5 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Alex Kiselev
librte_lpm: Improve lpm6 performance Rework the lpm6 rule subsystem and replace current rules algorithm complexity O(n) with hashtables which allow dealing with large (50k) rule sets. Signed-off-by: Alex Kiselev --- lib/Makefile | 2 +- lib/librte_lpm/meson.build | 1 + lib/li

[dpdk-dev] [PATCH v5 2/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Alex Kiselev
librte_lpm: Improve lpm6 performance There is no need to rebuild the whole LPM tree when a rule is deleted. This patch addresses this issue introducing new delete operation. Signed-off-by: Alex Kiselev --- lib/librte_lpm/rte_lpm6.c | 712 ++ 1 file ch

Re: [dpdk-dev] [PATCH v3 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Alex Kiselev
> Also. Please run checkpatch shell script on your patches. For example, there > should be blank line between declarations and code. fixed in v5 -- Alex

Re: [dpdk-dev] [PATCH 1/4] eventdev: add eth Tx adapter APIs

2018-07-16 Thread Rao, Nikhil
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Tuesday, July 10, 2018 5:48 PM > To: Rao, Nikhil > Cc: olivier.m...@6wind.com; dev@dpdk.org; anoob.jos...@cavium.com > Subject: Re: [PATCH 1/4] eventdev: add eth Tx adapter APIs > > --- > > 1) Update

[dpdk-dev] [PATCH v2 1/2] net/thunderx: enable Rx checksum offload

2018-07-16 Thread Pavan Nikhilesh
Add L3/L4 Rx checksum offload and update capabilities. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Add Rx checksum offload support for l3fwd. drivers/net/thunderx/nicvf_ethdev.c | 33 - drivers/net/thunderx/nicvf_ethdev.h | 1 + drivers/net/thunderx/nicvf_rxtx.c | 73 +

[dpdk-dev] [PATCH v2 2/2] net/thunderx: add support for Rx VLAN offload

2018-07-16 Thread Pavan Nikhilesh
From: "Kudurumalla, Rakesh" This feature is used to offload stripping of vlan header from recevied packets and update vlan_tci field in mbuf when DEV_RX_OFFLOAD_VLAN_STRIP & ETH_VLAN_STRIP_MASK flag is set. Signed-off-by: Rakesh Kudurumalla Signed-off-by: Pavan Nikhilesh --- drivers/net/thund

Re: [dpdk-dev] DPDK 18.05 only works with up to 4 NUMAs systems

2018-07-16 Thread Burakov, Anatoly
On 14-Jul-18 10:44 AM, Kumar, Ravi1 wrote: Memory setup with 2M pages works with the default configuration.  With the default configuration and 2M hugepages 1.    Total amount of memory for each NUMA zone does not exceed 128G (CONFIG_RTE_MAX_MEM_MB_PER_TYPE). 2.    Total nu

[dpdk-dev] DPDK techboard minutes 2018-07-04

2018-07-16 Thread Olivier Matz
Hi, Here are the minutes of the last DPDK technical board meeting held on 2018-07-04. Attendees: 6 / 8 - Bruce Richardson - Ferruh Yigit - Hemant Agrawal - Jerin Jacob - Olivier Matz - Thomas Monjalon 1) minimal kernel version supported for DPDK - discussion should happen on ML first - de

Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-07-16 Thread Pavan Nikhilesh
On Mon, Jul 16, 2018 at 12:25:29AM +0200, Thomas Monjalon wrote: > External Email > > 10/07/2018 12:19, Pavan Nikhilesh: > > Hi Gaëtan,Ferruh, > > > > On Wed, Jun 27, 2018 at 11:57:36AM +0200, Gaëtan Rivet wrote: > > > On Wed, Jun 27, 2018 at 02:25:30PM +0530, Pavan Nikhilesh wrote: > > > > Hi Gaët

[dpdk-dev] [PATCH] app/crypto-perf: fix mempool create call failure

2018-07-16 Thread Radu Nicolau
Using a small number of sessions results in rte_mempool_create call with cache_size > n, which fails. There is no need to cache the elements, as there is no performance impact. Fixes: 501c0a3b14c3 ("app/crypto-perf: limit number of sessions") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau ---

[dpdk-dev] [pbhagavat...@caviumnetworks.com: Re: [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter]

2018-07-16 Thread Pavan Nikhilesh
Hi Nikhil, On Mon, Jul 16, 2018 at 11:25:45AM +0530, Rao, Nikhil wrote: > On 7/10/2018 4:26 PM, Pavan Nikhilesh wrote: > > +int __rte_experimental > > +rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint32_t *caps) > > +{ > > The caps get API needs to be similar to rx adapter caps get i.e. it n

[dpdk-dev] [PATCH v11] devtools: alert on new instances of rte_panic and rte_exit

2018-07-16 Thread Arnon Warshavsky
This patch adds a new function that is called per every checked patch, and alerts for new instances of rte_panic/rte_exit. The check excludes comments, and alerts in the case of a positive balance between additions and removals. Signed-off-by: Arnon Warshavsky Reviewed-by: Stephen Hemminger ---

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix mempool create call failure

2018-07-16 Thread Akhil Goyal
On 7/16/2018 4:44 PM, Radu Nicolau wrote: Using a small number of sessions results in rte_mempool_create call with cache_size > n, which fails. There is no need to cache the elements, as there is no performance impact. Fixes: 501c0a3b14c3 ("app/crypto-perf: limit number of sessions") Cc: sta...

[dpdk-dev] [Bug 40] drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h: does not compile with musl because it uses an internal glibc header

2018-07-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=40 alejandro.luc...@netronome.com changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC|

Re: [dpdk-dev] [PATCH v2] eal/devargs: add option to supply PCI dev args

2018-07-16 Thread Thomas Monjalon
16/07/2018 13:05, Pavan Nikhilesh: > On Mon, Jul 16, 2018 at 12:25:29AM +0200, Thomas Monjalon wrote: > > External Email > > > > 10/07/2018 12:19, Pavan Nikhilesh: > > > Hi Gaëtan,Ferruh, > > > > > > On Wed, Jun 27, 2018 at 11:57:36AM +0200, Gaëtan Rivet wrote: > > > > On Wed, Jun 27, 2018 at 02:25

[dpdk-dev] [PATCH] net/softnic: fix illegal memory access

2018-07-16 Thread Jasvinder Singh
Fix pointer dereferencing and read after free (USE_AFTER_FREE). Coverity issue: 302867 Fixes: bef50bcb1c47 ("net/softnic: implement start and stop") Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_swq.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH v12] devtools: alert on new instances of rte_panic and rte_exit

2018-07-16 Thread Arnon Warshavsky
This patch adds a new function that is called per every checked patch, and alerts for new instances of rte_panic/rte_exit. The check excludes comments, and alerts in the case of a positive balance between additions and removals. Signed-off-by: Arnon Warshavsky Reviewed-by: Stephen Hemminger Test

[dpdk-dev] [PATCH v2] net/ixgbe: fix missing NULL point check

2018-07-16 Thread Qi Zhang
Add missing NULL point check inside ixgbe_pf_host_uninit, or it may cause segment fault when detaching a device. Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- v2: rebase drivers/net/ixgbe/ixgbe_pf.c | 6 -- 1 file chan

Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-16 Thread Burakov, Anatoly
On 13-Jun-18 8:08 PM, Dariusz Stojaczyk wrote: Although the alignment mechanism works as intended, the `no_align` bool flag was set incorrectly. We were aligning buffers that didn't need extra alignment, and weren't aligning ones that really needed it. Fixes: b7cc54187ea4 ("mem: move virtual are

Re: [dpdk-dev] Questions about locating the rte_mbuf payload

2018-07-16 Thread Bruce Richardson
On Fri, Jul 13, 2018 at 10:41:31PM -0700, Sungho Hong wrote: > Hello I have sent the packet with the data "hellohellohello*" > in a message struct using DPDK > > struct message{ > data[PKT_SIZE] > } > > I am sending this data from a client to server, and the server receives > this dat

Re: [dpdk-dev] [PATCH v2 08/10] autotest: add new test cases to autotest

2018-07-16 Thread Pattan, Reshma
Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Friday, July 13, 2018 5:41 PM > To: Pattan, Reshma ; tho...@monjalon.net; > dev@dpdk.org > Cc: Parthasarathy, JananeeX M ; > sta...@dpdk.org > Subject: Re: [PATCH v2 08/10] autotest: add new test cases to autotest > > On 13-Jul-18

Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-16 Thread Stojaczyk, DariuszX
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 2:58 PM > To: Stojaczyk, DariuszX ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [PATCH] memory: fix alignment in eal_get_virtual_area() > > On 13-Jun-18 8:08 PM, Dariusz Stojaczyk wrote: > > Although the ali

[dpdk-dev] [PATCH] test: fix prefix discovery

2018-07-16 Thread Anatoly Burakov
Config file has moved, but the tests weren't updated to point to its new location. Update the code to find current prefix. Fixes: adf1d867361c ("eal: move runtime config file to new location") Signed-off-by: Anatoly Burakov --- test/test/test_eal_flags.c| 9 ++--- test/test/test_mp_seco

Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-16 Thread Burakov, Anatoly
On 16-Jul-18 2:29 PM, Stojaczyk, DariuszX wrote: -Original Message- From: Burakov, Anatoly Sent: Monday, July 16, 2018 2:58 PM To: Stojaczyk, DariuszX ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [PATCH] memory: fix alignment in eal_get_virtual_area() On 13-Jun-18 8:08 PM, Dariusz S

[dpdk-dev] [PATCH v3 1/9] autotest: fix printing

2018-07-16 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v3 0/9] Make unit tests great again

2018-07-16 Thread Reshma Pattan
Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memor

[dpdk-dev] [PATCH v3 4/9] autotest: visually separate different test categories

2018-07-16 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v3 5/9] autotest: improve filtering

2018-07-16 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v3 3/9] autotest: make autotest runner python 2/3 compliant

2018-07-16 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v3 2/9] autotest: fix invalid code on reports

2018-07-16 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v3 6/9] autotest: remove autotest grouping

2018-07-16 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v3 7/9] autotest: properly parallelize unit tests

2018-07-16 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list

2018-07-16 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy --- test/test/autotest_data.py | 368 - 1 file c

[dpdk-dev] [PATCH v3 9/9] mk: update make targets for classified testcases

2018-07-16 Thread Reshma Pattan
Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different targets for the above classified groups. Test ca

Re: [dpdk-dev] [PATCH] app/crypto-perf: fix mempool create call failure

2018-07-16 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Monday, July 16, 2018 12:40 PM > To: Nicolau, Radu ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/crypto-perf: fix mempool create call > failure > > On 7/16/

Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-16 Thread Burakov, Anatoly
On 16-Jul-18 3:01 PM, Burakov, Anatoly wrote: On 16-Jul-18 2:29 PM, Stojaczyk, DariuszX wrote: -Original Message- From: Burakov, Anatoly Sent: Monday, July 16, 2018 2:58 PM To: Stojaczyk, DariuszX ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [PATCH] memory: fix alignment in eal_get_

Re: [dpdk-dev] [pbhagavat...@caviumnetworks.com: Re: [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter]

2018-07-16 Thread Rao, Nikhil
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Monday, July 16, 2018 5:03 PM > To: Rao, Nikhil ; > jkollanukka...@caviumnetworks.com; olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: [pbhagavat...@caviumnetworks.com: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH] test/compress: add scatter-gather tests

2018-07-16 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 3, 2018 1:52 AM > To: Trahe, Fiona ; > ashish.gu...@caviumnetworks.com; Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH] test/compress: add scatter-gather tests > > Added Scatter-Gather test,

[dpdk-dev] [PATCH 2/4] eventdev: add caps API and PMD callbacks for eth Tx adapter

2018-07-16 Thread Pavan Nikhilesh
On Mon, Jul 16, 2018 at 02:17:40PM +, Rao, Nikhil wrote: > > > -Original Message- > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Monday, July 16, 2018 5:03 PM > > To: Rao, Nikhil ; > > jkollanukka...@caviumnetworks.com; olivier.m...@6wind.com > > Cc: dev@dp

[dpdk-dev] [PATCH] eal: fix build with gcc 4.7

2018-07-16 Thread Pablo de Lara
Fixed possible out-of-bounds issue: lib/librte_eal/common/eal_common_devargs.c: In function ‘rte_devargs_layers_parse’: lib/librte_eal/common/eal_common_devargs.c:121:7: error: array subscript is above array bounds Bugzilla ID: 71 Fixes: 338327d731e6 ("devargs: add function to par

[dpdk-dev] [PATCH] mem: fix alignment of requested virtual areas

2018-07-16 Thread Anatoly Burakov
The original code did not align any addresses that were requested as page-aligned, but were different because addr_is_hint was set. Below fix by Dariusz has introduced an issue where all unaligned addresses were left as unaligned. This patch is a partial revert of commit 7fa7216ed48d ("mem: fix a

[dpdk-dev] DPDK and forked processes

2018-07-16 Thread Eads, Gage
Hi all, Does DPDK support forking secondary processes after executing rte_eal_init()? The l2fwd_fork example and at least one application (OpenEM: https://sourceforge.net/projects/eventmachine/) use this model, and they do so by fixing up the EAL internals (e.g. manually changing process_type f

Re: [dpdk-dev] DPDK and forked processes

2018-07-16 Thread Burakov, Anatoly
On 16-Jul-18 4:00 PM, Eads, Gage wrote: Hi all, Does DPDK support forking secondary processes after executing rte_eal_init()? The l2fwd_fork example and at least one application (OpenEM: https://sourceforge.net/projects/eventmachine/) use this model, and they do so by fixing up the EAL intern

Re: [dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list

2018-07-16 Thread Burakov, Anatoly
On 16-Jul-18 3:12 PM, Reshma Pattan wrote: Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy --- +}, +{ +"Name":"Flo

Re: [dpdk-dev] [PATCH v5 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Stephen Hemminger
On Mon, 16 Jul 2018 11:05:27 +0300 Alex Kiselev wrote: > librte_lpm: Improve lpm6 performance > > Rework the lpm6 rule subsystem and replace > current rules algorithm complexity O(n) > with hashtables which allow dealing with > large (50k) rule sets. > > Signed-off-by: Alex Kiselev Internet r

Re: [dpdk-dev] [PATCH] mem: fix alignment of requested virtual areas

2018-07-16 Thread Yao, Lei A
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 3:57 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yao, Lei A ; Stojaczyk, > DariuszX ; sta...@dpdk.org > Subject: [PATCH] mem: fix alignment of requested virtual areas > > The original code did not align any

Re: [dpdk-dev] [PATCH] test: fix prefix discovery

2018-07-16 Thread Pattan, Reshma
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 2:57 PM > To: dev@dpdk.org > Cc: Pattan, Reshma > Subject: [PATCH] test: fix prefix discovery > > Config file has moved, but the tests weren't updated to point to its new > location. Update the code to find cur

Re: [dpdk-dev] [PATCH v5 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Alex Kiselev
> On Mon, 16 Jul 2018 11:05:27 +0300 > Alex Kiselev wrote: >> librte_lpm: Improve lpm6 performance >> Rework the lpm6 rule subsystem and replace >> current rules algorithm complexity O(n) >> with hashtables which allow dealing with >> large (50k) rule sets. >> Signed-off-by: Alex Kiselev >

Re: [dpdk-dev] [PATCH v5 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Alex Kiselev
Здравствуйте, Alex. Вы писали 16 июля 2018 г., 18:36:25: >> On Mon, 16 Jul 2018 11:05:27 +0300 >> Alex Kiselev wrote: >>> librte_lpm: Improve lpm6 performance >>> Rework the lpm6 rule subsystem and replace >>> current rules algorithm complexity O(n) >>> with hashtables which allow dealing wit

[dpdk-dev] [PATCH v3] test: add sample functions for packet forwarding

2018-07-16 Thread Jananee Parthasarathy
Add sample test functions for packet forwarding. These can be used for unit test cases for LatencyStats and BitrateStats libraries. Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan --- v3: Used same port for tx,rx and removed extra line v2: SOCKET0 is removed and NUM_QUEUES is us

Re: [dpdk-dev] [PATCH] net/softnic: fix illegal memory access

2018-07-16 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Monday, July 16, 2018 1:42 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] net/softnic: fix illegal memory access > > Fix pointer dereferencing and read after free (USE_AFTER_FREE). > > Coverity issue: 302867 >

[dpdk-dev] [PATCH] examples/exception_path: fix possible out-of-bounds read

2018-07-16 Thread Bruce Richardson
When printing out stats from the exception_path app, all possible lcore_ids are iterated. However, the app only supports up to 64 cores. To prevent possible errors, and to remove coverity warnings, explicitly check for out-of-range lcore ids before printing. Coverity issue: 268335 Fixes: af75078fe

Re: [dpdk-dev] [PATCH v3] rte_ring: clarify preemptible nature of ring algorithm

2018-07-16 Thread Burakov, Anatoly
On 16-Jul-18 8:00 AM, Olivier Matz wrote: Hi, On Mon, Jul 09, 2018 at 11:00:47PM -0500, Honnappa Nagarahalli wrote: rte_ring implementation is not preemptible only under certain circumstances. This clarification is helpful for data plane and control plane communication using rte_ring. Signed-o

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix digest with AEAD algorithms

2018-07-16 Thread Pablo de Lara
When performing authentication verification (both for AEAD algorithms, such as AES-GCM, or for authentication algorithms, such as SHA1-HMAC), the digest address is calculated based on the packet size and the algorithm used (substracting digest size and IP header to the packet size). However, for A

[dpdk-dev] [PATCH] test: ensure EAL flags autotest works properly on BSD

2018-07-16 Thread Anatoly Burakov
FreeBSD does not support running multiple primary processes concurrently, because all DPDK instances will allocate memory from the same place (memory provided by contigmem driver). While it is technically possible to launch a DPDK process using no-shconf switch, it will actually corrupt main proces

[dpdk-dev] [PATCH] ixgbe: wait longer for link after fiber MAC setup

2018-07-16 Thread Matthew Smith
After setting up the link on a fiber port, the maximum wait time for the link to come up is 500 ms in ixgbe_setup_mac_link_multispeed_fiber(). On an x550 SFP+ port, this is often not sufficiently long for the link to come up. This can result in never being able to retrieve accurate link status for

[dpdk-dev] [PATCH] test: fix incorrect return types

2018-07-16 Thread Reshma Pattan
UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Fixes: 9c9befea4f ("test: add flow classify unit tests") CC: jasvinder.si...@intel.com CC: bernard.iremon...@intel.com CC: sta...@dpdk.org Signed-off-by: Reshma Pattan --- test/test/test

Re: [dpdk-dev] Questions about locating the rte_mbuf payload

2018-07-16 Thread Sungho Hong
Thanks for the reply Bruce, I have solved the problem. Just like you have said all I had to know was the data size that I was sending and the packet size that the DPDK tries to send. I subtracted them to get the accurate position of the end of the packet header address and my data.

Re: [dpdk-dev] [PATCH] net/softnic: fix illegal memory access

2018-07-16 Thread Singh, Jasvinder
> -Original Message- > From: Dumitrescu, Cristian > Sent: Monday, July 16, 2018 5:04 PM > To: Singh, Jasvinder ; dev@dpdk.org > Subject: RE: [PATCH] net/softnic: fix illegal memory access > > > > > -Original Message- > > From: Singh, Jasvinder > > Sent: Monday, July 16, 2018 1

Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build

2018-07-16 Thread De Lara Guarch, Pablo
HI Thomas, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, July 11, 2018 4:50 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [PATCH] devtools: add compressdev tests to test-build > > 11/07/2018 09:17, Pablo de Lara: > > Compr

Re: [dpdk-dev] [PATCH v3 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Alex Kiselev
> On Wed, 11 Jul 2018 20:53:46 +0300 > Alex Kiselev wrote: >> librte_lpm: Improve lpm6 performance >> Rework the lpm6 rule subsystem and replace >> current rules algorithm complexity O(n) >> with hashtables which allow dealing with >> large (50k) rule sets. > Wouldn't it make more sense to u

[dpdk-dev] [PATCH v2] test/compress: add scatter-gather tests

2018-07-16 Thread Pablo de Lara
Added Scatter-Gather test, which split input data into multi-segment mbufs and compresses/decompresses the data into also a multi-segment mbuf. Signed-off-by: Pablo de Lara Acked-by: Lee Daly --- v2: - Used new SGL flags - Set ponter to NULl after freeing test/test/test_compressdev.c | 391 ++

Re: [dpdk-dev] [PATCH v3 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-16 Thread Stephen Hemminger
On Mon, 16 Jul 2018 20:34:45 +0300 Alex Kiselev wrote: > > On Wed, 11 Jul 2018 20:53:46 +0300 > > Alex Kiselev wrote: > > >> librte_lpm: Improve lpm6 performance > > >> Rework the lpm6 rule subsystem and replace > >> current rules algorithm complexity O(n) > >> with hashtables which allow

Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build

2018-07-16 Thread Thomas Monjalon
16/07/2018 19:33, De Lara Guarch, Pablo: > HI Thomas, > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, July 11, 2018 4:50 PM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] devtools: add compressdev tests to t

Re: [dpdk-dev] [PATCH v2] net/bnx2x: move SPDX tags to source files

2018-07-16 Thread Mody, Rasesh
Hi Hemant, > From: Hemant [mailto:hemant.agra...@nxp.com] > Sent: Sunday, July 15, 2018 11:30 PM > > Hi Rasesh > > On 7/14/2018 7:03 AM, Rasesh Mody wrote: > > diff --git a/drivers/net/bnx2x/bnx2x_stats.h > > b/drivers/net/bnx2x/bnx2x_stats.h index 6fcaf60..107ef20 100644 > > --- a/drivers/net/bn

Re: [dpdk-dev] [PATCH] net/softnic: fix illegal memory access

2018-07-16 Thread Singh, Jasvinder
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Singh, Jasvinder > Sent: Monday, July 16, 2018 6:26 PM > To: Dumitrescu, Cristian ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/softnic: fix illegal memory access > > > > > -Original Message- >

Re: [dpdk-dev] [PATCH] eal: fix build with gcc 4.7

2018-07-16 Thread Gaëtan Rivet
Hi Pablo, On Mon, Jul 16, 2018 at 07:26:27AM +0100, Pablo de Lara wrote: > Fixed possible out-of-bounds issue: > > lib/librte_eal/common/eal_common_devargs.c: > In function ‘rte_devargs_layers_parse’: > lib/librte_eal/common/eal_common_devargs.c:121:7: > error: array subscript is abov

Re: [dpdk-dev] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64

2018-07-16 Thread Takeshi Yoshimura
> Adding rte_smp_rmb() cause performance regression on non x86 platforms. > Having said that, load-load barrier can be expressed very well with C11 > memory > model. I guess ppc64 supports C11 memory model. If so, > Could you try CONFIG_RTE_RING_USE_C11_MEM_MODEL=y for ppc64 and check > original

Re: [dpdk-dev] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64

2018-07-16 Thread Jerin Jacob
-Original Message- > Date: Tue, 17 Jul 2018 11:54:18 +0900 > From: Takeshi Yoshimura > To: Jerin Jacob > Cc: dev@dpdk.org, sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] rte_ring: fix racy dequeue/enqueue in ppc64 > Cc: olivier.m...@6wind.com Cc: chao...@linux.vnet.ibm.com Cc: konsta

[dpdk-dev] [PATCH v4] rte_ring: clarify preemptible nature of ring algorithm

2018-07-16 Thread Honnappa Nagarahalli
rte_ring implementation is not preemptible only under certain circumstances. This clarification is helpful for data plane and control plane communication using rte_ring. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Reviewed-by: Ola Liljedahl --- v4: * Undo few changes (Anatoly, Oli

Re: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization

2018-07-16 Thread Ori Kam
Sorry for the late response, > -Original Message- > From: Xu, Rosen [mailto:rosen...@intel.com] > Sent: Thursday, July 12, 2018 9:23 AM > To: Ori Kam ; dev@dpdk.org > Cc: Yigit, Ferruh ; sta...@dpdk.org; Gilmore, Walter > E > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add rt

[dpdk-dev] [PATCH v3] test: add unit tests for bitrate library

2018-07-16 Thread Jananee Parthasarathy
Unit Test Cases for BitRate library. Dependency patch is "add sample functions for packet forwarding" Patch Link is http://patches.dpdk.org/patch/43115/ Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan Reviewed-by: Remy Horton --- v3: rebased v2: corrected data type for tx_porti