[dpdk-dev] [PATCH] qat: fix checks for 3gpp algorithms vs bit mode

2018-07-11 Thread Dmitry Eremin-Solenikov
QAT driver checks byte alignment for KASUMI/SNOW 3G/ZUC algorithms using cipher/auth_param, which are not initialized at this moment yet. Use operation params instead. Signed-off-by: Dmitry Eremin-Solenikov --- drivers/crypto/qat/qat_sym.c | 22 +++--- 1 file changed, 11 insertio

Re: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf.

2018-07-11 Thread Ian Stokes
On 7/10/2018 2:03 AM, Lu, Wenzhuo wrote: Hi Ian, -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ian Stokes Sent: Friday, June 29, 2018 9:51 PM To: dev@dpdk.org Cc: Stokes, Ian ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2] net/e1000: Support mtu set for igbvf

Re: [dpdk-dev] [PATCH v2 3/5] compress/zlib: add xform and stream create support

2018-07-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:57 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Sunila Sahu ; > Sunila Sahu ; Ashish Gupta > > Subject: [PA

Re: [dpdk-dev] [PATCH v11 01/19] ethdev: add function to release port in local process

2018-07-11 Thread Zhang, Qi Z
> -Original Message- > From: Andrew Rybchenko [mailto:arybche...@solarflare.com] > Sent: Wednesday, July 11, 2018 5:27 PM > To: Zhang, Qi Z ; tho...@monjalon.net; Burakov, > Anatoly > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ;

Re: [dpdk-dev] [PATCH v11 06/19] eal: support attach or detach share device from secondary

2018-07-11 Thread Burakov, Anatoly
On 11-Jul-18 4:09 AM, Qi Zhang wrote: This patch cover the multi-process hotplug case when a device attach/detach request be issued from a secondary process device attach on secondary: a) secondary send sync request to the primary. b) primary receive the request and attach the new device if

Re: [dpdk-dev] [PATCH v11 05/19] eal: enable hotplug on multi-process

2018-07-11 Thread Burakov, Anatoly
On 11-Jul-18 4:09 AM, Qi Zhang wrote: We are going to introduce the solution to handle hotplug in multi-process, it includes the below scenario: 1. Attach a device from the primary 2. Detach a device from the primary 3. Attach a device from a secondary 4. Detach a device from a secondary In the

[dpdk-dev] [PATCH v2] compress/isal: add chained mbuf support

2018-07-11 Thread Lee, Daly
This patch adds chained mbuf support for input or output buffers during compression/decompression operations. V2 - Fixed using chained mbufs with offsets. Signed-off-by: Lee Daly --- doc/guides/compressdevs/features/isal.ini | 1 + doc/guides/compressdevs/isal.rst | 2 - dr

Re: [dpdk-dev] [PATCH v2 1/5] compress/zlib: add ZLIB PMD support

2018-07-11 Thread Verma, Shally
Hi Pablo >-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 11 July 2018 17:44 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahipal >; Gupta, Ashish ; Sahu, >Sunila >Subject: RE: [PATCH v2 1/5] compress/zlib: add

Re: [dpdk-dev] [PATCH v11 06/19] eal: support attach or detach share device from secondary

2018-07-11 Thread Zhang, Qi Z
> -Original Message- > From: Burakov, Anatoly > Sent: Wednesday, July 11, 2018 8:34 PM > To: Zhang, Qi Z ; tho...@monjalon.net > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Richardson, Bruce ; Yigit, Ferruh > ; Shelton, Benjamin H > ; Vangati, Narender > > Subject: Re: [PATCH v11 06/19] ea

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
What version of Pktgen and DPDK are you using? Most likely DPDK has changed for the given version or Pktgen. I normally only keep pktgen working on the last releases version 18.05 in this case. I am over due pushing a updated version of pktgen, so I will try to get that done soon. > On Jul 11,

Re: [dpdk-dev] [PATCH] compress/isal: fixes ISA-L PMD used with offsets in mbuf

2018-07-11 Thread De Lara Guarch, Pablo
Hi Lee, > -Original Message- > From: Daly, Lee > Sent: Tuesday, July 10, 2018 1:44 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Daly, Lee ; sta...@dpdk.org > Subject: [PATCH] compress/isal: fixes ISA-L PMD used with offsets in mbuf > > This patch allows the ISA-L compression PMD, t

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
> On Jul 11, 2018, at 6:47 AM, khemendra kumar > wrote: > > Hi All, > > Kindly help to check below compile error in DPDK Pkt-gen on x86. > > I am following instructions from " > http://pktgen-dpdk.readthedocs.io/en/latest/getting_started.html"; > > *Below cmd I followed:* > sudo make config

Re: [dpdk-dev] [PATCH v2 4/5] compress/zlib: add enq deq apis

2018-07-11 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:57 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Sunila Sahu ; > Sunila Sahu ; Ashish Gupta > > Subject: [

Re: [dpdk-dev] [PATCH] examples/ip_pipeline: remove CLI command dependency on pipeline thread

2018-07-11 Thread Dumitrescu, Cristian
> -Original Message- > From: Singh, Jasvinder > Sent: Tuesday, July 10, 2018 9:44 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian > Subject: [PATCH] examples/ip_pipeline: remove CLI command dependency > on pipeline thread > > Applied on next-pipeline tree, thanks!

[dpdk-dev] [PATCH v12 00/19] enable hotplug on multi-process

2018-07-11 Thread Qi Zhang
v12: - fix return value in eal_dev_hotplug_request_to_primary. - add more error log in rte_eal_hotplug_add. - fix return value in rte_eal_hotplug_add and rte_eal_hotplug_remove any failure due to IPC error will return -ENOMSG, but not -1. - remove unnecessary changes from previous rework. v11: -

[dpdk-dev] [PATCH v12 02/19] bus/pci: fix PCI address compare

2018-07-11 Thread Qi Zhang
When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a device. Fixes: c752998b5e2e ("pci: int

[dpdk-dev] [PATCH v12 01/19] ethdev: add function to release port in local process

2018-07-11 Thread Qi Zhang
Add driver API rte_eth_release_port_private to support the case when an ethdev need to be detached on a secondary process. Local state is set to unused and shared data will not be reset so the primary process can still use it. Signed-off-by: Qi Zhang Reviewed-by: Andrew Rybchenko Acked-by: Remy

[dpdk-dev] [PATCH v12 03/19] bus/pci: enable vfio unmap resource for secondary

2018-07-11 Thread Qi Zhang
Subroutine to unmap VFIO resource is shared by secondary and primary, and it does not work on the secondary process. Since for secondary process, it is not necessary to close interrupt handler, set pci bus mastering and remove vfio_res from vfio_res_list. So, the patch adds a dedicate function to h

[dpdk-dev] [PATCH v12 05/19] eal: enable hotplug on multi-process

2018-07-11 Thread Qi Zhang
We are going to introduce the solution to handle hotplug in multi-process, it includes the below scenario: 1. Attach a device from the primary 2. Detach a device from the primary 3. Attach a device from a secondary 4. Detach a device from a secondary In the primary-secondary process model, we ass

[dpdk-dev] [PATCH v12 04/19] vfio: remove uneccessary IPC for group fd clear

2018-07-11 Thread Qi Zhang
Clear vfio_group_fd is not necessary to involve any IPC. Also, current IPC implementation for SOCKET_CLR_GROUP is not correct. rte_vfio_clear_group on secondary will always fail, that prevent device be detached correctly on a secondary process. The patch simply removes all IPC related stuff in rte_

[dpdk-dev] [PATCH v12 07/19] net/i40e: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 2 ++ 1 file changed, 2 ins

[dpdk-dev] [PATCH v12 09/19] net/af_packet: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 08/19] net/ixgbe: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to release a port. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++ 1 file changed, 3

[dpdk-dev] [PATCH v12 06/19] eal: support attach or detach share device from secondary

2018-07-11 Thread Qi Zhang
This patch cover the multi-process hotplug case when a device attach/detach request be issued from a secondary process device attach on secondary: a) secondary send sync request to the primary. b) primary receive the request and attach the new device if failed goto i). c) primary forward attach

[dpdk-dev] [PATCH v12 10/19] net/bonding: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 13/19] net/octeontx: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 11/19] net/kni: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 12/19] net/null: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 14/19] net/pcap: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 16/19] net/tap: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 17/19] net/vhost: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 15/19] net/softnic: enable hotplug on secondary process

2018-07-11 Thread Qi Zhang
Attach port from secondary should ignore devargs since the private device is not necessary to support. Also previously, detach port on a secondary process will mess primary process and cause the same device can't be attached back again. A secondary process should use rte_eth_release_port_private to

[dpdk-dev] [PATCH v12 18/19] examples/multi_process: add hotplug sample

2018-07-11 Thread Qi Zhang
The sample code demonstrates device (ethdev only) management at a multi-process environment. The user can attach/detach a device on primary process and see it is synced on secondary process automatically. How to start? ./hotplug_mp --proc-type=auto Command Line Example: >help >list /* attach a

[dpdk-dev] [PATCH v12 19/19] doc: update release notes for multi process hotplug

2018-07-11 Thread Qi Zhang
Update release notes for the new multi-process hotplug feature. Signed-off-by: Qi Zhang --- doc/guides/rel_notes/release_18_08.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst index bc0124295..12

Re: [dpdk-dev] [PATCH v12 06/19] eal: support attach or detach share device from secondary

2018-07-11 Thread Burakov, Anatoly
On 11-Jul-18 2:47 PM, Qi Zhang wrote: This patch cover the multi-process hotplug case when a device attach/detach request be issued from a secondary process device attach on secondary: a) secondary send sync request to the primary. b) primary receive the request and attach the new device if

Re: [dpdk-dev] [PATCH v2 3/5] compress/zlib: add xform and stream create support

2018-07-11 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 11 July 2018 17:57 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahipal >; Sahu, Sunila ; Sahu, >Sunila ; Gupta, Ashish > >Subject: RE: [PATCH v2 3/5] compress/

Re: [dpdk-dev] [PATCH v2 5/5] doc: add ZLIB PMD documentation

2018-07-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Monday, July 2, 2018 5:57 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; pathr...@caviumnetworks.com; > mcha...@caviumnetworks.com; Sunila Sahu > ; Ashish Gupta > > Subject: [PATCH v2 5/5] do

[dpdk-dev] [PATCH 1/3] app/pdump: use hotplug add instead of attach

2018-07-11 Thread Andrew Rybchenko
rte_eth_dev_attach() is to be deprecated. Signed-off-by: Andrew Rybchenko --- app/pdump/main.c | 94 +++- 1 file changed, 70 insertions(+), 24 deletions(-) diff --git a/app/pdump/main.c b/app/pdump/main.c index 6bcf8c498..ac2287124 100644 --- a/app/pd

[dpdk-dev] [PATCH 3/3] eal: deprecate device attach and detach functions

2018-07-11 Thread Andrew Rybchenko
Hotplug functions should be used directly to add and remove devices. Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/deprecation.rst| 5 + lib/librte_eal/common/include/rte_dev.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/g

[dpdk-dev] [PATCH 0/3] deprecate attach and detach functions

2018-07-11 Thread Andrew Rybchenko
As discussed in [1] EAL hotplug should be used directly to add/remove devices. app/pdump changes are build-tested only. [1] http://mails.dpdk.org/archives/dev/2018-July/107507.html Andrew Rybchenko (3): app/pdump: use hotplug add instead of attach ethdev: deprecate attach and detach function

[dpdk-dev] [PATCH 2/3] ethdev: deprecate attach and detach functions

2018-07-11 Thread Andrew Rybchenko
These functions are buggy from the very beginning and should not be used. Generic EAL hotplug mechanisms should be used instead. Signed-off-by: Andrew Rybchenko --- app/test-pmd/Makefile| 1 + app/test-pmd/meson.build | 1 + doc/guides/rel_notes/deprecation.rst | 7 ++

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
> On Jul 11, 2018, at 8:21 AM, Wiles, Keith wrote: > > > >> On Jul 11, 2018, at 6:47 AM, khemendra kumar >> wrote: >> >> Hi All, >> >> Kindly help to check below compile error in DPDK Pkt-gen on x86. >> >> I am following instructions from " >> http://pktgen-dpdk.readthedocs.io/en/latest/

[dpdk-dev] [PATCH v2] compress/isal: fix offset usage

2018-07-11 Thread Lee Daly
This patch allows the ISA-L compression PMD, to be used with offsets in the mbuf. Offsets can now be used for source and destination buffers, during compression or decompression. V2 - commit message change. - error log message reword. - avail_out not taking offset into account. Fixes: dc49

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread khemendra kumar
Hi Keith, Thanks for your quick help. I am new to Pktgen and DPDK :( Now I tried with DPDK18.02 version with Pktgen of 3.5.0 version. This works on my x86 machine :) Further I can use Pktgen 3.5.2 with DPDK 18.02. as you suggested. Now I am trying *Pktgen on ARM machine*. I am using *DPDK 18.

Re: [dpdk-dev] [dpdk-users] Traffic doesn't forward on virtual devices

2018-07-11 Thread Bala Sankaran
- Original Message - > From: "Ciara Loftus" > To: "Bala Sankaran" > Cc: "Aaron Conole" , "Keith Wiles" > , us...@dpdk.org, dev@dpdk.org, "Maxime > Coquelin" , "Ian Stokes" > Sent: Wednesday, July 11, 2018 4:12:38 AM > Subject: RE: [dpdk-users] Traffic doesn't forward on virtual devic

[dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak

2018-07-11 Thread Pablo de Lara
Processed operations ring is created for each queue pair, but it was not being freed when the queue pair was released. Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/compress/isal/isal_compress_pmd_ops.c | 3 +++ 1

[dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name

2018-07-11 Thread Pablo de Lara
There is a naming convention for logtypes of PMDs: "pmd.driverType.driverName". Therefore, the logtype for ISA-L PMD should be "pmd.compress.isal". Fixes: 490e725b95b2 ("compress/isal: add device init and de-init") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/compress/isal/isal_

[dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing

2018-07-11 Thread Pablo de Lara
Fixes: b0e23c458a6f ("compress/isal: add queue pair related ops") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/compress/isal/isal_compress_pmd_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/co

Re: [dpdk-dev] [Dpdk-pktgen]dpdk pktgen build failed on x86

2018-07-11 Thread Wiles, Keith
> On Jul 11, 2018, at 9:26 AM, khemendra kumar > wrote: > > Hi Keith, > > Thanks for your quick help. > > I am new to Pktgen and DPDK :( > > Now I tried with DPDK18.02 version with Pktgen of 3.5.0 version. > This works on my x86 machine :) > > Further I can use Pktgen 3.5.2 with DPDK 18.02

[dpdk-dev] [PATCH] devtools: add compressdev tests to test-build

2018-07-11 Thread Pablo de Lara
Compressdev tests depend on Zlib library, so they can only be enabled if this is available. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/test-build.sh b/devtools/test-build.sh index 3ea82bb46..059065891 100755 --- a/devtools

Re: [dpdk-dev] [PATCH v9 0/7] hotplug failure handle mechanism

2018-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2018 18:41:50 +0800 Jeff Guo wrote: > As we know, hot plug is an importance feature, either use for the datacenter > device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring > the higher flexibility and continuality to the networking services in multiple > use

Re: [dpdk-dev] [PATCH] devtools: add compressdev tests to test-build

2018-07-11 Thread Thomas Monjalon
11/07/2018 09:17, Pablo de Lara: > Compressdev tests depend on Zlib library, > so they can only be enabled if this is available. > > Signed-off-by: Pablo de Lara > --- > --- a/devtools/test-build.sh > +++ b/devtools/test-build.sh > @@ -154,6 +154,7 @@ config () # > test "$DPDK_DE

Re: [dpdk-dev] [PATCH v11 01/19] ethdev: add function to release port in local process

2018-07-11 Thread Andrew Rybchenko
On 11.07.2018 15:30, Zhang, Qi Z wrote: -Original Message- From: Andrew Rybchenko [mailto:arybche...@solarflare.com] Sent: Wednesday, July 11, 2018 5:27 PM To: Zhang, Qi Z ; tho...@monjalon.net; Burakov, Anatoly Cc: Ananyev, Konstantin ; dev@dpdk.org; Richardson, Bruce ; Yigit, Ferruh

Re: [dpdk-dev] [PATCH 3/3] compress/isal: fix memory leak

2018-07-11 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 11, 2018 7:39 AM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH 3/3] compress/isal: fix memory leak > > Processed operations ring is created for each queue pair,

Re: [dpdk-dev] [PATCH 2/3] compress/isal: set null pointer after freeing

2018-07-11 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 11, 2018 7:39 AM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH 2/3] compress/isal: set null pointer after freeing > > Fixes: b0e23c458a6f ("compress/isal: add qu

Re: [dpdk-dev] [PATCH 1/3] compress/isal: fix logtype name

2018-07-11 Thread Daly, Lee
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, July 11, 2018 7:39 AM > To: Daly, Lee > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH 1/3] compress/isal: fix logtype name > > There is a naming convention for logtypes of PMDs: > "pmd

Re: [dpdk-dev] [PATCH] igb_uio: fix build issue with lock down checks

2018-07-11 Thread Thomas Monjalon
29/06/2018 12:54, Ferruh Yigit: > On 6/29/2018 11:13 AM, David Marchand wrote: > > Caught on ubuntu-16.04 with hwe kernel for aarch64: > > > > $ uname -a > > Linux ubuntu1604arm64es 4.13.0-43-generic #48~16.04.1-Ubuntu SMP Thu May > > 17 13:08:01 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux > > > >

Re: [dpdk-dev] [PATCH] maintainers: update for mempool

2018-07-11 Thread Thomas Monjalon
02/07/2018 18:08, Andrew Rybchenko: > On 07/02/2018 06:55 PM, Olivier Matz wrote: > > Given its very good contributions to this library, add Andrew as > > official maintainer for librte_mempool. > > > > Signed-off-by: Olivier Matz > > --- > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -277,6 +

Re: [dpdk-dev] [dpdk-stable] [PATCH] maintainers: update for Mellanox PMDs

2018-07-11 Thread Thomas Monjalon
10/07/2018 00:12, Yongseok Koh: > > > On Jul 9, 2018, at 3:05 AM, Matan Azrad wrote: > > > > > > > > From: Adrien Mazarguil > >> Shahaf and Matan volunteered to replace Nélio and myself as maintainers > >> for > >> mlx4 and mlx5 PMDs. Cheers! > >> > > > > Thanks! > > Adrien and Nelio, > >

Re: [dpdk-dev] [PATCH v2 5/5] doc: add ZLIB PMD documentation

2018-07-11 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 11 July 2018 19:32 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahipal >; Sahu, Sunila ; Gupta, >Ashish >Subject: RE: [PATCH v2 5/5] doc: add ZLIB PMD documen

Re: [dpdk-dev] [PATCH v2] examples/multi_process: add l2fwd_fork to Makefile

2018-07-11 Thread Thomas Monjalon
05/07/2018 18:05, Ferruh Yigit: > On 7/3/2018 5:16 PM, Emma Kenny wrote: > > l2fwd_fork is not complied by default, this will make it compile > > > > Fixes: 95e8005a56e8 ("examples/l2fwd_fork: new app") > > > > Signed-off-by: Emma Kenny > > Acked-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH v1] examples/multi_process: fix build error

2018-07-11 Thread Thomas Monjalon
03/07/2018 14:10, Shahaf Shuler: > Monday, July 2, 2018 6:40 PM, Emma Kenny: > > Subject: [PATCH v1] examples/multi_process: fix build error > > > > Fix bug with undeclared variable name and calling a variable that is not > > member of struct. > > > > CC main.o > > l2fwd_fork/main.c: In function

Re: [dpdk-dev] [dpdk-stable] [PATCH v14 6/6] devtools: expand meson cross compiling test coverage

2018-07-11 Thread Thomas Monjalon
29/06/2018 19:27, Gavin Hu: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to increase the coverage by adding one more to cover > clang and the others for gcc. > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: sta...@dpdk.

[dpdk-dev] [PATCH v3 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-11 Thread Alex Kiselev
librte_lpm: Improve lpm6 performance Rework the lpm6 rule subsystem and replace current rules algorithm complexity O(n) with hashtables which allow dealing with large (50k) rule sets. Signed-off-by: Alex Kiselev --- lib/Makefile | 2 +- lib/librte_lpm/meson.build | 1 + lib/li

[dpdk-dev] [PATCH v3 2/2] librte_lpm: Improve performance of the delete and add functions

2018-07-11 Thread Alex Kiselev
There is no need to rebuild the whole LPM tree when a rule is deleted. This patch addresses this issue introducing new delete operation. Signed-off-by: Alex Kiselev --- lib/librte_lpm/rte_lpm6.c | 698 ++ 1 file changed, 583 insertions(+), 115 deletion

[dpdk-dev] [PATCH v4 2/2] librte_lpm: Improve performance of the delete and add functions

2018-07-11 Thread Alex Kiselev
librte_lpm: Improve lpm6 performance There is no need to rebuild the whole LPM tree when a rule is deleted. This patch addresses this issue introducing new delete operation. Signed-off-by: Alex Kiselev --- lib/librte_lpm/rte_lpm6.c | 698 ++ 1 file ch

[dpdk-dev] [PATCH v4 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-11 Thread Alex Kiselev
librte_lpm: Improve lpm6 performance Rework the lpm6 rule subsystem and replace current rules algorithm complexity O(n) with hashtables which allow dealing with large (50k) rule sets. Signed-off-by: Alex Kiselev --- lib/Makefile | 2 +- lib/librte_lpm/meson.build | 1 + lib/li

[dpdk-dev] [PATCH v2] crypto/qat: fix checks for 3gpp algo bit params

2018-07-11 Thread Fiona Trahe
QAT driver checks byte alignment for KASUMI/SNOW 3G/ZUC algorithms using cipher/auth_param, which are not initialized at this moment yet. Use operation params instead. Signed-off-by: Fiona Trahe --- Change in v2 : - fixed implementation to avoid data truncation This fix should be backported to s

Re: [dpdk-dev] [PATCH] qat: fix checks for 3gpp algorithms vs bit mode

2018-07-11 Thread Trahe, Fiona
Hi Dmitri, Thanks for debugging this. However the below fix can truncate the data - I'll send an alternative fix shortly. Fiona > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dmitry Eremin-Solenikov > Sent: Wednesday, July 11, 2018 1:25 PM > To: dev@dpdk.org

Re: [dpdk-dev] [PATCH v14 0/6] Fix the cross compiling errors

2018-07-11 Thread Thomas Monjalon
29/06/2018 19:27, Gavin Hu: > Gavin Hu (4): > build: fix the meson build warning > devtools: fix the missing ninja command error > build: fix the meson cross compile error > devtools: expand meson cross compiling test coverage > > gavin hu (2): > mk: fix makefile based cross build errors

Re: [dpdk-dev] [dpdk-announce] CFP for DPDK Summit Userspace

2018-07-11 Thread O'Driscoll, Tim
A quick reminder that the CFP for this closes on July 27th, which is two weeks on Friday. If you're planning to submit a proposal you can do so at: https://goo.gl/forms/Jh70MIA7QJE2nSBb2 Registration for the event is also open now. You can register at: https://www.regonline.com/DPDKDublin > --

Re: [dpdk-dev] [PATCH v3 14/21] net/mlx5: add RSS flow action

2018-07-11 Thread Yongseok Koh
On Wed, Jul 11, 2018 at 09:22:47AM +0200, Nelio Laranjeiro wrote: > Signed-off-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 682 +++ > 1 file changed, 537 insertions(+), 145 deletions(-) > [...] > @@ -1322,26 +1583,122 @@ mlx5_flow_merge(struct rte_

Re: [dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent

2018-07-11 Thread Thomas Monjalon
05/07/2018 17:47, Jasvinder Singh: > Add connection agent to enable connectivity with external agen > (e.g. telnet, netcat, Python script, etc). > > Signed-off-by: Cristian Dumitrescu > Signed-off-by: Jasvinder Singh > --- > config/common_base | 2 +- > config/

Re: [dpdk-dev] [PATCH v3 00/21] net/mlx5: flow rework

2018-07-11 Thread Yongseok Koh
On Wed, Jul 11, 2018 at 09:22:33AM +0200, Nelio Laranjeiro wrote: > Re-work flow engine to support port redirection actions through TC. > > This first series depends on [1] which is implemented in commit > "net/mlx5: support inner RSS computation" and on [2]. > Next series will bring the port red

Re: [dpdk-dev] [PATCH v3 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-11 Thread Stephen Hemminger
On Wed, 11 Jul 2018 20:53:46 +0300 Alex Kiselev wrote: > librte_lpm: Improve lpm6 performance > > Rework the lpm6 rule subsystem and replace > current rules algorithm complexity O(n) > with hashtables which allow dealing with > large (50k) rule sets. > > Signed-off-by: Alex Kiselev > --- > li

Re: [dpdk-dev] [PATCH v5 5/8] hash: add read and write concurrency support

2018-07-11 Thread Stephen Hemminger
On Tue, 10 Jul 2018 09:59:58 -0700 Yipeng Wang wrote: > + > +static inline void > +__hash_rw_reader_lock(const struct rte_hash *h) > +{ > + if (h->readwrite_concur_support && h->hw_trans_mem_support) > + rte_rwlock_read_lock_tm(h->readwrite_lock); > + else if (h->readwrite_con

Re: [dpdk-dev] [PATCH v2 5/5] doc: add ZLIB PMD documentation

2018-07-11 Thread De Lara Guarch, Pablo
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Wednesday, July 11, 2018 6:16 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Athreya, Narayana Prasad > ; Challa, Mahipal > ; Sahu, Sunila ; > Gupta, Ashish > Subject: RE: [PATCH v2 5/5] doc: add ZL

Re: [dpdk-dev] [PATCH v3] docs: add default that all fixes should be backported

2018-07-11 Thread Thomas Monjalon
04/07/2018 17:22, Thomas Monjalon: > 30/06/2018 01:10, Kevin Traynor: > > Set the starting point that all commits on master branch > > with Fixes tag should be backported to relevant stable/LTS > > branches, and explain that the submitter may indicate it is > > not suitable for backport. > > > > O

[dpdk-dev] [BUG] mlx5 build failure on Debian testing

2018-07-11 Thread Stephen Hemminger
I am seeing a build failure of MLX5 driver on Debian testing (buster) with dpdk.org master branch. This is using libibverbs-dev version 19.0-1 The failure is: mlx5_glue.h:94:11: error: ‘struct ibv_counter_set_init_attr’ declared inside parameter list will not be visible outside of this definitio

[dpdk-dev] [RFC 1/1] eventdev: add distributed software (DSW) event device

2018-07-11 Thread Mattias Rönnblom
Signed-off-by: Mattias Rönnblom --- config/common_base|5 + drivers/event/Makefile|1 + drivers/event/dsw/Makefile| 28 + drivers/event/dsw/dsw_evdev.c | 361 + drivers/event/dsw/dsw_evdev.h

[dpdk-dev] [RFC 0/1] A Distributed Software Event Device

2018-07-11 Thread Mattias Rönnblom
This is the Distributed Software (DSW) event device, which distributes the task of scheduling events among all the eventdev ports and their lcore threads. DSW is primarily designed for atomic-only queues, but also supports single-link and parallel queues. (DSW would be more accurately described a

Re: [dpdk-dev] [PATCH v2 1/1] service: Add service lcore attr APIs

2018-07-11 Thread Thomas Monjalon
09/05/2018 18:22, Erik Gabriel Carrillo: > Add APIs that allow an application to query and reset the attributes of > a service lcore. Add one such new attribute, "loops", which is a > counter that tracks the number of times the service core has looped in > the service runner function. This is use

[dpdk-dev] [PATCH v11 00/25] Device querying

2018-07-11 Thread Gaetan Rivet
This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a

[dpdk-dev] [PATCH v11 01/25] devargs: use rte-log functions

2018-07-11 Thread Gaetan Rivet
Use the standard EAL logging functions in rte_devargs. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c in

[dpdk-dev] [PATCH v11 04/25] kvargs: build before EAL

2018-07-11 Thread Gaetan Rivet
This library will be used by the EAL to parse parameters. Signed-off-by: Gaetan Rivet --- lib/Makefile | 3 +-- lib/librte_eal/meson.build| 1 + lib/librte_kvargs/Makefile| 2 +- lib/librte_kvargs/meson.build | 3 +++ lib/meson.build | 8 ++-- 5 files c

[dpdk-dev] [PATCH v11 05/25] kvargs: introduce a more flexible parsing function

2018-07-11 Thread Gaetan Rivet
This function permits defining additional terminating characters, ending the parsing to arbitrary delimiters. Signed-off-by: Gaetan Rivet Acked-by: Thomas Monjalon Acked-by: Shreyansh Jain --- lib/Makefile | 1 + lib/librte_kvargs/meson.build| 2 ++ li

[dpdk-dev] [PATCH v11 03/25] kvargs: remove error logs

2018-07-11 Thread Gaetan Rivet
Error logs in kvargs parsing should be better handled in components calling the library. This library must be as lean as possible. Signed-off-by: Gaetan Rivet Acked-by: Thomas Monjalon --- lib/librte_kvargs/rte_kvargs.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions

[dpdk-dev] [PATCH v11 02/25] devargs: add non-variadic parsing function

2018-07-11 Thread Gaetan Rivet
rte_devargs_parse becomes non-variadic, rte_devargs_parsef becomes the variadic version, to be used to compose device strings. Signed-off-by: Gaetan Rivet Acked-by: Shreyansh Jain Acked-by: Thomas Monjalon --- drivers/net/failsafe/failsafe_args.c| 2 +- drivers/net/failsafe/failsafe_e

[dpdk-dev] [PATCH v11 06/25] eal: introduce dtor macros

2018-07-11 Thread Gaetan Rivet
This macro adds symbols to the .fini section using the global RTE priorities, to ensure consistency. Signed-off-by: Gaetan Rivet Acked-by: Shreyansh Jain --- lib/librte_eal/common/include/rte_common.h | 23 ++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/com

[dpdk-dev] [PATCH v11 11/25] eal/dev: implement device iteration

2018-07-11 Thread Gaetan Rivet
Use the iteration hooks in the abstraction layers to perform the requested filtering on the internal device lists. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 168 lib/librte_eal/common/include/rte_dev.h | 26 lib/librte_eal/rte_eal_ve

[dpdk-dev] [PATCH v11 07/25] eal: introduce device class abstraction

2018-07-11 Thread Gaetan Rivet
This abstraction exists since the infancy of DPDK. It needs to be fleshed out however, to allow a generic description of devices properties and capabilities. A device class is the northbound interface of the device, intended for applications to know what it can be used for. It is conceptually jus

[dpdk-dev] [PATCH v11 10/25] eal/dev: implement device iteration initialization

2018-07-11 Thread Gaetan Rivet
Parse a device description. Split this description in their relevant part for each layers. No dynamic allocation is performed. Signed-off-by: Gaetan Rivet --- lib/Makefile| 1 + lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/eal_common_dev.c |

[dpdk-dev] [PATCH v11 08/25] devargs: add function to parse device layers

2018-07-11 Thread Gaetan Rivet
This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 lib/librte_eal/common/eal_private.h

[dpdk-dev] [PATCH v11 09/25] eal/dev: add device iterator interface

2018-07-11 Thread Gaetan Rivet
A device iterator allows iterating over a set of devices. This set is defined by the two descriptions offered, * rte_bus * rte_class Only one description can be provided, or both. It is not allowed to provide no description at all. Each layer of abstraction then performs a filter based on th

[dpdk-dev] [PATCH v11 12/25] kvargs: add generic string matching callback

2018-07-11 Thread Gaetan Rivet
This function can be used as a callback to rte_kvargs_process. This should reduce code duplication. Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 10 + lib/librte_kvargs/rte_kvargs.h | 26 lib/librte_kvargs/rte_kvargs_versi

[dpdk-dev] [PATCH v11 13/25] bus/pci: implement device iteration and comparison

2018-07-11 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/pci/Makefile | 3 +- drivers/bus/pci/meson.build | 6 +++- drivers/bus/pci/pci_common.c | 3 +- drivers/bus/pci/pci_params.c | 53 drivers/bus/pci/private.h| 25 + 5 files changed, 86 inse

[dpdk-dev] [PATCH v11 14/25] bus/pci: add device matching field id

2018-07-11 Thread Gaetan Rivet
The PCI bus can now parse a matching field "id" as follows: "bus=pci,id=:00:00.0" or "bus=pci,id=00:00.0" Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v11 17/25] ethdev: add private generic device iterator

2018-07-11 Thread Gaetan Rivet
This iterator can be customized with a comparison function that will trigger a stopping condition. It can be leveraged to write several different iterators that have similar but non-identical purposes. It is private to librte_ethdev. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile

[dpdk-dev] [PATCH v11 16/25] bus/vdev: add device matching field driver

2018-07-11 Thread Gaetan Rivet
The vdev bus parses a field "driver", matching a vdev driver name with one passed as follows: "bus=vdev,driver=" Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev_params.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_param

[dpdk-dev] [PATCH v11 15/25] bus/vdev: implement device iteration

2018-07-11 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 3 +- drivers/bus/vdev/meson.build| 5 +++- drivers/bus/vdev/vdev.c | 10 --- drivers/bus/vdev/vdev_params.c | 51 + drivers/bus/vdev/vdev_private.h | 26 + 5 files

<    1   2   3   >