29/06/2018 19:27, Gavin Hu: > The default test script covers only default host cc compiler, either gcc or > clang, the fix is to increase the coverage by adding one more to cover > clang and the others for gcc. > > Fixes: a55277a788 ("devtools: add test script for meson builds") > Cc: sta...@dpdk.org > > Signed-off-by: Gavin Hu <gavin...@arm.com> > Reviewed-by: Phil Yang <phil.y...@arm.com> > Reviewed-by: Song Zhu <song....@arm.com> > Acked-by: Bruce Richardson <bruce.richard...@intel.com> > --- > devtools/test-meson-builds.sh | 22 ++++++++++++++-------- > 1 file changed, 14 insertions(+), 8 deletions(-) > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 9bb5b93bd..f38304e6e 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -15,7 +15,7 @@ if command -v ninja >/dev/null 2>&1 ; then > elif command -v ninja-build >/dev/null 2>&1 ; then > ninja_cmd=ninja-build > else > - echo "## ERROR: ninja is missing, please install..." > + echo "ERROR: ninja is not found"
This is changing a (not related) line introduced in patch 4. I will squash myself if no other error is found.