[dpdk-dev] [PATCH v10 16/27] bus/pci: add device matching field id

2018-07-05 Thread Gaetan Rivet
The PCI bus can now parse a matching field "id" as follows: "bus=pci,id=:00:00.0" or "bus=pci,id=00:00.0" Signed-off-by: Gaetan Rivet --- drivers/bus/pci/pci_params.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v10 17/27] bus/vdev: implement device iteration

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/Makefile | 3 +- drivers/bus/vdev/meson.build| 5 +++- drivers/bus/vdev/vdev.c | 10 --- drivers/bus/vdev/vdev_params.c | 51 + drivers/bus/vdev/vdev_private.h | 26 + 5 files

[dpdk-dev] [PATCH v10 19/27] ethdev: add private generic device iterator

2018-07-05 Thread Gaetan Rivet
This iterator can be customized with a comparison function that will trigger a stopping condition. It can be leveraged to write several different iterators that have similar but non-identical purposes. It is private to librte_ethdev. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile

[dpdk-dev] [PATCH v10 20/27] ethdev: register ether layer as a class

2018-07-05 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/Makefile| 3 +- lib/librte_ethdev/meson.build | 1 + lib/librte_ethdev/rte_class_eth.c | 79 +++ 3 files changed, 82 insertions(+), 1 deletion(-) create mode 100644 lib/librte_ethdev/rte_class_eth.c diff

[dpdk-dev] [PATCH v10 18/27] bus/vdev: add device matching field driver

2018-07-05 Thread Gaetan Rivet
The vdev bus parses a field "driver", matching a vdev driver name with one passed as follows: "bus=vdev,driver=" Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev_params.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/bus/vdev/vdev_param

[dpdk-dev] [PATCH v10 21/27] ethdev: add device matching field name

2018-07-05 Thread Gaetan Rivet
The eth device class can now parse a field name, matching the eth_dev name with one passed as "class=eth,name=xx" Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/rte_class_eth.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_e

[dpdk-dev] [PATCH v10 22/27] app/testpmd: add show device command

2018-07-05 Thread Gaetan Rivet
A new interactive command is offered: show device This commands lists all rte_device element matching the device description. e.g.: show device bus=pci show device bus=vdev show device bus=vdev/class=eth show device bus=vdev,driver=net_ring/class=eth show device bus=vdev/class

[dpdk-dev] [PATCH v10 23/27] bus/pci: pre-process declarative PCI devargs

2018-07-05 Thread Gaetan Rivet
The new devargs format does not recognize a particular device name. Each bus uses its specific format. Instead of introducing a new bus API, process those devargs privately for the moment. Prepare them for matching during scan against the bus devices. Signed-off-by: Gaetan Rivet --- drivers/bus

[dpdk-dev] [PATCH v10 24/27] bus/vdev: pre-process declarative vdev devargs

2018-07-05 Thread Gaetan Rivet
The new devargs format does not recognize a particular device name. Each bus uses its specific format. Process each devargs privately prior to attempting a bus scan. Prepare them if they are using the new devargs format. Signed-off-by: Gaetan Rivet --- drivers/bus/vdev/vdev.c | 10 -

[dpdk-dev] [PATCH v10 26/27] ethdev: process declarative eth devargs

2018-07-05 Thread Gaetan Rivet
Process the class-specific arguments in a devargs. This processing takes the form of setting the proper eth_dev fields when relevant. Signed-off-by: Gaetan Rivet --- lib/librte_ethdev/eth_private.h | 5 +++ lib/librte_ethdev/rte_class_eth.c | 61 +++ lib/librte_eth

[dpdk-dev] [PATCH v10 25/27] bus/pci: process declarative PCI devargs

2018-07-05 Thread Gaetan Rivet
Introduce the facility to process future PCI parameters. Once the matching between PCI devices and devargs has been done, it is possible to process each devargs. New parameters would have the PCI device handle to work with when parsing the device (bus specific) parameters. Signed-off-by: Gaetan R

[dpdk-dev] [PATCH v10 27/27] eal: add generic dev parameter

2018-07-05 Thread Gaetan Rivet
Add the --dev parameter to the EAL. This new parameter takes a generic device declaration as argument. It uses the new devargs parsing API. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 4 +++ lib/librte_eal/common/eal_common_options.c | 36 +++---

Re: [dpdk-dev] [PATCH v9 20/27] ethdev: register ether layer as a class

2018-07-05 Thread Gaëtan Rivet
On Thu, Jul 05, 2018 at 12:13:56PM +0100, Bruce Richardson wrote: > On Thu, Jul 05, 2018 at 11:36:38AM +0200, Gaëtan Rivet wrote: > > Hi Andrew, > > > > On Wed, Jul 04, 2018 at 03:20:17PM +0300, Andrew Rybchenko wrote: > > > On 07/04/2018 01:15 AM, Gaetan Rivet wrote: > > > > Signed-off-by: Gaetan

Re: [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

2018-07-05 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 05 July 2018 16:56 >To: Verma, Shally ; Gupta, Ashish >; Trahe, Fiona ; >Daly, Lee ; Sahu, Sunila >Cc: dev@dpdk.org >Subject: RE: [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-05 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, July 5, 2018 6:55 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > ; arybche..

Re: [dpdk-dev] [PATCH] test/crypto: fix the devid testcases

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Wednesday, July 4, 2018 10:50 AM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; sta...@dpdk.org; Doherty, Declan > > Subject: [PATCH] test/crypto: fix the devid testcases > > devid is valid, while ts_

Re: [dpdk-dev] [PATCH v4] net/mlx4: support hardware TSO

2018-07-05 Thread Matan Azrad
HI Moti Please see inline. From: Mordechay Haimovsky > Implement support for hardware TSO. > > Signed-off-by: Moti Haimovsky > --- > v4: > * Bug fixes in filling TSO data segments. > * Modifications according to review inputs from Adrien Mazarguil > and Matan Azrad. > in reply to > 1530190137

Re: [dpdk-dev] [PATCH v1] net/tap: explain how to compile eBPF C file

2018-07-05 Thread Wiles, Keith
> On Jul 4, 2018, at 3:11 PM, Thomas Monjalon wrote: > > 04/07/2018 21:47, Ferruh Yigit: >> On 6/12/2018 3:02 PM, Ophir Munk wrote: >>> Please note that other than cloning iproute2 we also need to install clang >>> and llvm tools versions 3.7 and upper. >>> Not sure there are clang and llvm pa

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bonding: don't clear active slave count

2018-07-05 Thread Ferruh Yigit
On 7/4/2018 3:28 AM, Chas Williams wrote: > From: "Charles (Chas) Williams" > > When the bond PMD is stopped, the active slave count is reset. > For 802.3ad mode this potentially leaks memory and clears state since > a second sequential activate_slave() will occur when the bond PMD is > restarted

Re: [dpdk-dev] [PATCH v7 09/15] vhost: add shadow used ring support for packed rings

2018-07-05 Thread Maxime Coquelin
On 07/05/2018 09:15 AM, Tiwei Bie wrote: On Wed, Jul 04, 2018 at 11:54:32PM +0200, Maxime Coquelin wrote: [...] + +static __rte_always_inline void +flush_shadow_used_ring_packed(struct virtio_net *dev, + struct vhost_virtqueue *vq) +{ [...] +} + +static __rte_always_in

Re: [dpdk-dev] [PATCH v6] examples: fix RSS hash function configuration

2018-07-05 Thread Ferruh Yigit
On 7/5/2018 10:30 AM, Hunt, David wrote: > Hi Ferruh, > > > On 4/7/2018 9:02 PM, Ferruh Yigit wrote: >> ethdev layer introduced checks for application requested RSS hash >> functions and returns error for ones unsupported by hardware >> >> This check breaks some sample applications which blindly

Re: [dpdk-dev] [PATCH] doc: update CRC feature with new offload flag

2018-07-05 Thread Ferruh Yigit
On 7/4/2018 8:46 PM, Andrew Rybchenko wrote: > On 04.07.2018 20:15, Ferruh Yigit wrote: >> Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC") >> >> Signed-off-by: Ferruh Yigit > > Acked-by: Andrew Rybchenko Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v7 09/15] vhost: add shadow used ring support for packed rings

2018-07-05 Thread Tiwei Bie
On Thu, Jul 05, 2018 at 02:49:34PM +0200, Maxime Coquelin wrote: > On 07/05/2018 09:15 AM, Tiwei Bie wrote: > > On Wed, Jul 04, 2018 at 11:54:32PM +0200, Maxime Coquelin wrote: > > [...] > > > + > > > +static __rte_always_inline void > > > +flush_shadow_used_ring_packed(struct virtio_net *dev, > >

Re: [dpdk-dev] [PATCH] test: add unit tests for metrics library

2018-07-05 Thread Remy Horton
'noon, See inline comments. On 05/07/2018 08:37, Hari kumar Vemula wrote: Unit Testcases are added for metrics library. [..] +/* Test case to validate registering a list of valid metric names */ +static int +test_metrics_reg_names(void) +{ + int err = 0; + const char * const mn

Re: [dpdk-dev] [PATCH v2] security: remove experimental tag from security APIs

2018-07-05 Thread De Lara Guarch, Pablo
Hi Hemant, > -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > Sent: Wednesday, July 4, 2018 10:05 AM > To: Nicolau, Radu ; akhil.go...@nxp.com; Doherty, > Declan ; De Lara Guarch, Pablo > ; bor...@mellanox.com > Cc: dev@dpdk.org > Subject: [PATCH v2] security: re

Re: [dpdk-dev] [PATCH v7 09/15] vhost: add shadow used ring support for packed rings

2018-07-05 Thread Maxime Coquelin
On 07/05/2018 04:03 PM, Tiwei Bie wrote: On Thu, Jul 05, 2018 at 02:49:34PM +0200, Maxime Coquelin wrote: On 07/05/2018 09:15 AM, Tiwei Bie wrote: On Wed, Jul 04, 2018 at 11:54:32PM +0200, Maxime Coquelin wrote: [...] + +static __rte_always_inline void +flush_shadow_used_ring_packed(struct

[dpdk-dev] [PATCH v8 1/2] app/testpmd: add VXLAN encap/decap support

2018-07-05 Thread Nelio Laranjeiro
Due to the complex VXLAN_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the packet. This same global structure will then be used by t

[dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-05 Thread Nelio Laranjeiro
This series adds an easy and maintainable configuration version support for those two actions for 18.08 by using global variables in testpmd to store the necessary information for the tunnel encapsulation. Those variables are used in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to cre

[dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE encap/decap support

2018-07-05 Thread Nelio Laranjeiro
Due to the complex NVGRE_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the packet. This same global structure will then be used by t

Re: [dpdk-dev] [PATCH v7 09/15] vhost: add shadow used ring support for packed rings

2018-07-05 Thread Tiwei Bie
On Thu, Jul 05, 2018 at 04:28:20PM +0200, Maxime Coquelin wrote: > On 07/05/2018 04:03 PM, Tiwei Bie wrote: > > On Thu, Jul 05, 2018 at 02:49:34PM +0200, Maxime Coquelin wrote: > > > On 07/05/2018 09:15 AM, Tiwei Bie wrote: > > > > On Wed, Jul 04, 2018 at 11:54:32PM +0200, Maxime Coquelin wrote: >

Re: [dpdk-dev] [PATCH v10 01/27] devargs: add non-variadic parsing function

2018-07-05 Thread Thomas Monjalon
05/07/2018 13:48, Gaetan Rivet: > rte_devargs_parse becomes non-variadic, > rte_devargs_parsef becomes the variadic version, to be used to compose > device strings. > > Signed-off-by: Gaetan Rivet Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH v4 1/2] lib/librte_power: traffic pattern aware power control

2018-07-05 Thread Liang, Ma
On 27 Jun 18:33, Kevin Traynor wrote: > On 06/26/2018 12:40 PM, Radu Nicolau wrote: > > From: Liang Ma > > > > 1. Abstract > > > > For packet processing workloads such as DPDK polling is continuous. > > This means CPU cores always show 100% busy independent of how much work > > those cores are d

Re: [dpdk-dev] [PATCH] mk: using initial-exec model for thread local variable

2018-07-05 Thread Sachin Saxena
> > When building share library, thread-local storage model will be changed to > global-dynamic. It will add additional cost for reading thread local variable. > On the other hand, dynamically load share library with static TLS will request > additional DTV slot which is limited by loader. By n

Re: [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-05 Thread Adrien Mazarguil
On Thu, Jul 05, 2018 at 04:33:08PM +0200, Nelio Laranjeiro wrote: > This series adds an easy and maintainable configuration version support for > those two actions for 18.08 by using global variables in testpmd to store the > necessary information for the tunnel encapsulation. Those variables are

Re: [dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-05 Thread Doherty, Declan
Hey Shally, just a few things inline below mainly concerned with the need to be able to support session-less operations in future PMDs. I think with a few minor changes to the API now it should allow session-less to be supported later without the need for a major rework of the APIs, I don't t

Re: [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap

2018-07-05 Thread Mohammad Abdul Awal
On 05/07/2018 15:33, Nelio Laranjeiro wrote: This series adds an easy and maintainable configuration version support for those two actions for 18.08 by using global variables in testpmd to store the necessary information for the tunnel encapsulation. Those variables are used in conjunction of

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: add VXLAN encap/decap support

2018-07-05 Thread Mohammad Abdul Awal
On 05/07/2018 15:33, Nelio Laranjeiro wrote: Due to the complex VXLAN_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new command in testpmd to initialise a global structure containing the necessary information to make the outer layer of the packet.

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE encap/decap support

2018-07-05 Thread Mohammad Abdul Awal
Some nits. Auto-completion suggestion for values should be wrapped between '<' and '>', not '(' and ')'. See all the cases. On 05/07/2018 15:33, Nelio Laranjeiro wrote: Due to the complex NVGRE_ENCAP flow action and based on the fact testpmd does not allocate memory, this patch adds a new com

Re: [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE encap/decap support

2018-07-05 Thread Nélio Laranjeiro
On Thu, Jul 05, 2018 at 04:07:28PM +0100, Mohammad Abdul Awal wrote: >Some nits. > >Auto-completion suggestion for values should be wrapped between '<' and >'>', not '(' and ')'. See all the cases. >[...] Right, I'll send a v9 to fix this. Thanks, -- Nélio Laranjeiro 6WIND

[dpdk-dev] [PATCH v4 00/23] net/softnic: refactoring

2018-07-05 Thread Jasvinder Singh
This patch set modifies the Soft NIC device driver to use the Packet Framework, which makes it much more modular, flexible and extensible with new functionality. � The Soft NIC allows building custom NIC pipelines in SW. The Soft NIC pipeline is DIY and reconfigurable through �firmware� (DPDK Pa

[dpdk-dev] [PATCH v4 01/23] net/softnic: restructuring

2018-07-05 Thread Jasvinder Singh
Rework the softnic implementation to have flexiblity in enabling more features to its receive and transmit data path. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 607 drivers/net/softnic/rte_eth

[dpdk-dev] [PATCH v4 03/23] net/softnic: add link object

2018-07-05 Thread Jasvinder Singh
Add link object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/rte_eth_softnic.c | 4 + drivers/net/softnic/rte_eth_softnic_internals.h | 37 ++ d

[dpdk-dev] [PATCH v4 06/23] net/softnic: add traffic manager object

2018-07-05 Thread Jasvinder Singh
Add traffic manager(tmgr) object to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 70 +++- drivers/net/softnic/rte_eth_softnic.h | 11 ++- drivers/net/softnic/rte_eth_softnic_internals

[dpdk-dev] [PATCH v4 04/23] net/softnic: add mempool object

2018-07-05 Thread Jasvinder Singh
Add mempool object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/rte_eth_softnic.c | 2 + drivers/net/softnic/rte_eth_softnic_internals.h | 38 +++

[dpdk-dev] [PATCH v4 02/23] net/softnic: add software queue object

2018-07-05 Thread Jasvinder Singh
Add swq object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/rte_eth_softnic.c | 7 ++ drivers/net/softnic/rte_eth_softnic_internals.h | 39 ++ d

[dpdk-dev] [PATCH v4 05/23] net/softnic: add tap object

2018-07-05 Thread Jasvinder Singh
Add tap object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/rte_eth_softnic.c | 2 + drivers/net/softnic/rte_eth_softnic_internals.h | 29 ++ dri

[dpdk-dev] [PATCH v4 07/23] net/softnic: add port action profile

2018-07-05 Thread Jasvinder Singh
Add pipeline's port action profile implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 3 + drivers/net/softnic/hash_func.h | 359 drivers/net/softnic/ha

[dpdk-dev] [PATCH v4 11/23] net/softnic: add softnic run API

2018-07-05 Thread Jasvinder Singh
Implements softnic API function to run pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c| 13 -- drivers/net/softnic/rte_eth_softnic_thread.c | 195 +++ 2 files changed, 195 insertions(+

[dpdk-dev] [PATCH v4 09/23] net/softnic: add pipeline object

2018-07-05 Thread Jasvinder Singh
Add pipeline object implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 3 +- drivers/net/softnic/rte_eth_softnic.c | 2 + drivers/net/softnic/rte_eth_softnic_internals.h | 196 +

[dpdk-dev] [PATCH v4 10/23] net/softnic: add thread

2018-07-05 Thread Jasvinder Singh
Add thread data structure and init function to run softnic pipelines objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 1 + drivers/net/softnic/rte_eth_softnic.c | 8 +++ drivers/net/softnic/rte_eth_softn

[dpdk-dev] [PATCH v4 08/23] net/softnic: add table action profile

2018-07-05 Thread Jasvinder Singh
Add pipeline's table action profile implementation to the softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 2 + drivers/net/softnic/rte_eth_softnic_action.c| 227 drivers/net/softnic/r

[dpdk-dev] [PATCH v4 13/23] net/softnic: add connection agent

2018-07-05 Thread Jasvinder Singh
Add connection agent to enable connectivity with external agen (e.g. telnet, netcat, Python script, etc). Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- config/common_base | 2 +- config/common_linuxapp | 1 +

[dpdk-dev] [PATCH v4 12/23] net/softnic: add cli interface

2018-07-05 Thread Jasvinder Singh
Add interface for softnic cli commands. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/Makefile| 2 + drivers/net/softnic/parser.c| 685 drivers/net/softnic/parser.h

[dpdk-dev] [PATCH v4 14/23] net/softnic: add cli to create softnic objects

2018-07-05 Thread Jasvinder Singh
Add cli commands to create softnic objects such as mempool, swq, pipeline, etc. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 1646 ++- drivers/net/softnic/rte_eth_softnic_internals.h | 85 ++ driver

[dpdk-dev] [PATCH v4 15/23] net/softnic: add cli to enable and disable pipeline

2018-07-05 Thread Jasvinder Singh
Add cli commands to enable and disable pipelines on specific threads in softnic. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 103 drivers/net/softnic/rte_eth_softnic_internals.h | 10 + drivers/net/softnic/rte

[dpdk-dev] [PATCH v4 16/23] net/softnic: add cli for pipeline table entries

2018-07-05 Thread Jasvinder Singh
Add cli commands for table entries in softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 2187 --- drivers/net/softnic/rte_eth_softnic_internals.h | 35 + drivers/net/softnic/rte

[dpdk-dev] [PATCH v4 17/23] net/softnic: add cli to read stats

2018-07-05 Thread Jasvinder Singh
Add cli commands to read port and table stats of softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 288 + drivers/net/softnic/rte_eth_softnic_internals.h | 29 +++ drivers/net/so

[dpdk-dev] [PATCH v4 18/23] net/softnic: add cli for meter action

2018-07-05 Thread Jasvinder Singh
Add cli commands for meter action in softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 418 drivers/net/softnic/rte_eth_softnic_internals.h | 29 ++ drivers/net/softnic/rte_

[dpdk-dev] [PATCH v4 20/23] net/softnic: receive and transmit queue setup

2018-07-05 Thread Jasvinder Singh
Implements softnic receive and transmit queues setup using swq object. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 62 ++- 1 file changed, 32 insertions(+), 30 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v4 19/23] net/softnic: add cli for ttl action

2018-07-05 Thread Jasvinder Singh
Add cli commands for ttl action in softnic pipeline objects. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic_cli.c | 23 +++ drivers/net/softnic/rte_eth_softnic_internals.h | 8 +++ drivers/net/softnic/rte_eth_softnic_thread.c

[dpdk-dev] [PATCH v4 21/23] net/softnic: start and stop function

2018-07-05 Thread Jasvinder Singh
Implements softnic start and stop function. Signed-off-by: Cristian Dumitrescu Signed-off-by: Jasvinder Singh --- drivers/net/softnic/rte_eth_softnic.c | 49 - drivers/net/softnic/rte_eth_softnic_internals.h | 6 +++ drivers/net/softnic/rte_eth_softnic_pipelin

[dpdk-dev] [PATCH v4 22/23] net/softnic: add firmware script

2018-07-05 Thread Jasvinder Singh
Add default firmware script for softnic. Signed-off-by: Jasvinder Singh --- drivers/net/softnic/firmware.cli | 21 + 1 file changed, 21 insertions(+) create mode 100644 drivers/net/softnic/firmware.cli diff --git a/drivers/net/softnic/firmware.cli b/drivers/net/softnic/firm

[dpdk-dev] [PATCH v4 23/23] app/testpmd: rework softnic forward mode

2018-07-05 Thread Jasvinder Singh
Modied the testpmd softnic forwarding mode as per the changes in softnic PMD. To run testpmd application with softnic fwd mode, following command is used; $ ./testpmd -c 0xc -n 4 --vdev 'net_softnic0,firmware=script.cli' -- -i --forward-mode=softnic Signed-off-by: Jasvinder Singh Signed-off-b

[dpdk-dev] [PATCH v4 0/2] test/crypto: add testcase for asym crypto

2018-07-05 Thread Shally Verma
This patch series add unit test case for asymmetric crypto. Current testcase covers following operations: - RSA encrypt, decrypt, sign and verify - Modular Inversion and Exponentiation - Deiffie-Hellman key pair generation and shared secret compute - DSA sign and verify All test cases use pre-de

[dpdk-dev] [PATCH v4 2/2] test/crypto: add dh and dsa test application

2018-07-05 Thread Shally Verma
From: Sunila Sahu Test application include test case for : - Deiffie-Hellman key pair generation and shared secret compute - DSA sign and verify Test cases uses predefined test vectors. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- test/test/test_cr

[dpdk-dev] [PATCH v4 1/2] test/crypto: add rsa and mod test application

2018-07-05 Thread Shally Verma
From: Sunila Sahu Test application include test case for : - RSA encrypt, decrypt, sign and verify - Modular Inversion and Exponentiation Test cases uses predefined test vectors. Signed-off-by: Sunila Sahu Signed-off-by: Shally Verma Signed-off-by: Ashish Gupta --- test/test/Makefile

[dpdk-dev] [PATCH] app/testpmd: fix typo in setting Tx offload command

2018-07-05 Thread Ferruh Yigit
udp_cksum is duplicated, second one should be tcp_cksum Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- Cc: wei@intel.com --- app/test-pmd/cmdline.c | 8 doc/guides/testpmd_app_ug/tes

[dpdk-dev] [PATCH v2 00/16] compress/qat: add compression PMD

2018-07-05 Thread Fiona Trahe
Create compression PMD for Intel QuickAssist devices Currently only the C62x and c3xxx devices are supported. The qat comp PMD supports - stateless compression and decompression using the Deflate algorithm with Fixed Huffman encoding. Dynamic huffman encoding is not supported, it will be

[dpdk-dev] [PATCH v2 01/16] common/qat: updated firmware headers

2018-07-05 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Change-Id: Ia8890f78361852664d555db1a26ecc03ef2c39d2 Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat/q

Re: [dpdk-dev] [PATCH v2] examples/multi_process: add l2fwd_fork to Makefile

2018-07-05 Thread Ferruh Yigit
On 7/3/2018 5:16 PM, Emma Kenny wrote: > l2fwd_fork is not complied by default, this will make it compile > > Fixes: 95e8005a56e8 ("examples/l2fwd_fork: new app") > > Signed-off-by: Emma Kenny Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v2 03/16] compress/qat: add meson build

2018-07-05 Thread Fiona Trahe
Add meson build files. Change-Id: Ia759f56fcc230f90252afcc5e1745c6fb78cefa3 Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18

[dpdk-dev] [PATCH v2 02/16] compress/qat: add makefiles for PMD

2018-07-05 Thread Fiona Trahe
Add Makefiles, directory and empty source files for compression PMD. Handle cases for building either symmetric crypto PMD or compression PMD or both and the common files both depend on. Change-Id: I71c4c6abd1982443cd6f7ff25e03bb161fb3fb16 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak

[dpdk-dev] [PATCH v2 05/16] compress/qat: create fw request and process response

2018-07-05 Thread Fiona Trahe
Add functions to create the request message to send to firmware and to process the firmware response. Change-Id: Ie03a6ba3de3741f237e2247d543f2e7101c7435d Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 101

[dpdk-dev] [PATCH v2 04/16] compress/qat: add xform processing

2018-07-05 Thread Fiona Trahe
Add code to process compressdev rte_comp_xforms, creating private qat_comp_xforms with prepared firmware message templates. Change-Id: I8e785d3a6ab3fe196d581413d938244f8143d7bb Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 239 +++

[dpdk-dev] [PATCH v2 06/16] compress/qat: check that correct firmware is in use

2018-07-05 Thread Fiona Trahe
Check bit in response message to verify that correct firmware is in use for compression. If not return an error. Change-Id: I0d1a6ba3a27380226e60491e66aef3284e49de67 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 16 +++- drivers/compr

[dpdk-dev] [PATCH v2 07/16] compress/qat: add stats functions

2018-07-05 Thread Fiona Trahe
Add fns to get and clear compression queue-pair stats. Change-Id: I22cbf2425c96850472410da11a18be64727f5d17 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7 +++

[dpdk-dev] [PATCH v2 09/16] compress/qat: add fns to configure and clear device

2018-07-05 Thread Fiona Trahe
Add functions to configure and clear the qat comp device, including the creation and freeing of the xform pool and the freeing of queue-pairs. Change-Id: I24d75b20141ae9bda3917dda0c9c2accf874cf88 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c |

[dpdk-dev] [PATCH v2 08/16] compress/qat: setup queue-pairs for compression service

2018-07-05 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Change-Id: Id9e517eb7bfcbbd3a79cae8f6757c91cc46d4de6 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 62 ++

[dpdk-dev] [PATCH v2 10/16] compress/qat: add fn to return device info

2018-07-05 Thread Fiona Trahe
Add capabilities ptr to internal qat comp device and function to return this and other info. Change-Id: Ic0bf5375e0fbf6338d90fb10e7b9ae1454c93792 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 18 ++ drivers/compress/qat/qat_co

[dpdk-dev] [PATCH v2 11/16] compress/qat: add enqueue/dequeue functions

2018-07-05 Thread Fiona Trahe
Wrap generic qat enqueue/dequeue functions with compressdev enqueue and dequeue fns. Change-Id: Ie2fd918f17b29fd97f52ce9773966d231f4c7a33 Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 14 ++ drivers/compress/qat/qat_comp_pmd.h |

[dpdk-dev] [PATCH v2 12/16] compress/qat: add device start and stop fns

2018-07-05 Thread Fiona Trahe
There are no specific actions needed to start/stop a QAT comp device so these are just trivial fns to satisfy the pmd API. Change-Id: I09288ffee58614ee68acf54f031b0eadb991b266 Signed-off-by: Fiona Trahe --- drivers/compress/qat/qat_comp_pmd.c | 11 +++ drivers/compress/qat/qat_comp_pmd.h

[dpdk-dev] [PATCH v2 13/16] compress/qat: create and populate the ops structure

2018-07-05 Thread Fiona Trahe
Create an ops structure and populate it with the qat-specific finctions. Change-Id: I4fec917df598b983b889e4e07e5aa110774e446d Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 38 - drivers/compress/qat/qat_com

[dpdk-dev] [PATCH v2 14/16] compress/qat: add fns to create and destroy the PMD

2018-07-05 Thread Fiona Trahe
Now that all the device operations are available, add the functions to create and destroy the pmd. Called on probe and remove of the qat pci device, these register the device with the compressdev API and plug in all the device functionality. Change-Id: I288fe781a5ea4a8595bc00754089921af89c2f50 Sig

[dpdk-dev] [PATCH v2 15/16] compress/qat: prevent device usage if incorrect firmware

2018-07-05 Thread Fiona Trahe
Previous check only causes op to fail on dequeue. This extends so once first fail is detected, application can no longer enqueue ops to the device and will also get an appropriate error if trying to reconfigure or setup the device. Change-Id: Ie196fbaa0ab09ecdf5dfb8e4c3059b3d437a53a6 Signed-off-by

[dpdk-dev] [PATCH v2 16/16] docs/qat: refactor docs adding compression guide

2018-07-05 Thread Fiona Trahe
Extend QAT guide to cover crypto and compression and common informationi, particularly about kernel driver. Update release note. Update compression feature ist for qat. Change-Id: I7d9bde8b71d23e5e160170243ae4705aaa4cff3d Signed-off-by: Fiona Trahe --- config/common_base |

Re: [dpdk-dev] [PATCH] test/crypto: fix the devid testcases

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Thursday, July 5, 2018 1:29 PM > To: Hemant Agrawal > Cc: dev@dpdk.org; sta...@dpdk.org; Doherty, Declan > > Subject: Re: [dpdk-stable] [PATCH] test/crypto: fix the devid t

Re: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: Pattan, Reshma > Sent: Wednesday, July 4, 2018 10:54 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: RE: [dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging > > Hi Pablo, > > Also need to remove CONFIG_RTE_LIBRTE_PMD

Re: [dpdk-dev] [dpdk-stable] [PATCH] security: fix segfault when destroy NULL session

2018-07-05 Thread De Lara Guarch, Pablo
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, July 5, 2018 11:52 AM > To: Nicolau, Radu ; dev@dpdk.org > Cc: bor...@mellanox.com; Doherty, Declan ; > sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] security:

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-05 Thread Mordechay Haimovsky
Hello Ferruh, Here are my findings: 1. The error you've seen is definitely a bug in mlx5dv.h from rdma-core (I'm emphasizing rdma-core since I cannot just send a fix for this file) As it didn’t take into account that an address may be a 32bit one when performing the 32bit shift.

[dpdk-dev] [PATCH v3 00/16] compress/qat: add compression PMD

2018-07-05 Thread Fiona Trahe
Create compression PMD for Intel QuickAssist devices Currently only the C62x and c3xxx devices are supported. The qat comp PMD supports - stateless compression and decompression using the Deflate algorithm with Fixed Huffman encoding. Dynamic huffman encoding is not supported, it will be

[dpdk-dev] [PATCH v3 01/16] common/qat: updated firmware headers

2018-07-05 Thread Fiona Trahe
Updated to latest firmware headers files for QuickAssist devices. Includes updates for symmetric crypto, PKE and Compression services. Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_adf/icp_qat_fw.h | 69 +++- drivers/common/qat/qat_adf/icp_qat_fw_comp.h | 482 ++

[dpdk-dev] [PATCH v3 02/16] compress/qat: add makefiles for PMD

2018-07-05 Thread Fiona Trahe
Add Makefiles, directory and empty source files for compression PMD. Handle cases for building either symmetric crypto PMD or compression PMD or both and the common files both depend on. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- MAINTAINERS | 4

[dpdk-dev] [PATCH v3 03/16] compress/qat: add meson build

2018-07-05 Thread Fiona Trahe
Add meson build files. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/Makefile | 2 +- drivers/compress/meson.build | 2 +- drivers/compress/qat/meson.build | 18 ++ drivers/compress/qat/rte_pmd_qat_

[dpdk-dev] [PATCH v3 08/16] compress/qat: setup queue-pairs for compression service

2018-07-05 Thread Fiona Trahe
Setup and clear queue-pairs for handling compression requests and responses. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.h | 2 ++ drivers/compress/qat/qat_comp_pmd.c | 62 + drivers/compress/qat/qat_comp_pm

[dpdk-dev] [PATCH v3 07/16] compress/qat: add stats functions

2018-07-05 Thread Fiona Trahe
Add functions to get and clear compression queue-pair statistics. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 35 +++ drivers/compress/qat/qat_comp_pmd.h | 7 +++ 2 files changed, 42 insertions(+) diff

[dpdk-dev] [PATCH v3 06/16] compress/qat: check that correct firmware is in use

2018-07-05 Thread Fiona Trahe
Check bit in response message to verify that correct firmware is in use for compression. If not return an error. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 16 +++- drivers/compress/qat/qat_comp.h | 2 ++ 2 files changed, 17 inser

[dpdk-dev] [PATCH v3 05/16] compress/qat: create fw request and process response

2018-07-05 Thread Fiona Trahe
Add functions to create the request message to send to firmware and to process the firmware response. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 101 drivers/compress/qat/qat_comp.h | 8 +++ drive

[dpdk-dev] [PATCH v3 09/16] compress/qat: add fns to configure and clear device

2018-07-05 Thread Fiona Trahe
Add functions to configure and clear the qat comp device, including the creation and freeing of the xform pool and the freeing of queue-pairs. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 96 + drivers/com

[dpdk-dev] [PATCH v3 04/16] compress/qat: add xform processing

2018-07-05 Thread Fiona Trahe
Add code to process compressdev rte_comp_xforms, creating private qat_comp_xforms with prepared firmware message templates. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 239 drivers/compress/qat/qat_comp.

[dpdk-dev] [PATCH v3 10/16] compress/qat: add fn to return device info

2018-07-05 Thread Fiona Trahe
Add capabilities pointer to internal qat comp device and function to return this and other info. Signed-off-by: Fiona Trahe Signed-off-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp_pmd.c | 18 ++ drivers/compress/qat/qat_comp_pmd.h | 6 ++ 2 files changed, 24 inserti

<    1   2   3   >