Hello Ferruh,
On Wed, May 16, 2018 at 4:42 PM, Ferruh Yigit wrote:
> @@ -136,3 +132,22 @@ static bool pci_check_and_mask_intx(struct pci_dev *pdev)
> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 5, 0)
> #define HAVE_PCI_MSI_MASK_IRQ 1
> #endif
> +
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(4,
On Thu, Jun 28, 2018 at 4:16 PM, Ferruh Yigit wrote:
> Documents the assumption that 'xstats[i].id == i' and
> key=xstats_names[i].name, value=xstats[i].value
>
> xstats[i].id is still used for xstats _by_id() APIs.
>
> This patch reverts some part of the commit 6d52d1d4afb4 ("ethdev:
> clarify ex
HI Pablo
>-Original Message-
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 20 June 2018 03:48
>To: Verma, Shally
>Cc: Trahe, Fiona ; dev@dpdk.org; Athreya, Narayana
>Prasad ;
>Challa, Mahipal ; Gupta, Ashish
>; Sahu, Sunila
>
>Subject: RE: [PATCH v1 4/7] co
Hello Pablo,
On Mon, Jun 25, 2018 at 09:48:50AM +0100, Pablo de Lara wrote:
> Most crypto PMDs do not have a limitation
> of the number of the sessions that can be handled
> internally. The value that was set before was not
> actually used at all, since the sessions are created
> at the applicatio
On 06/28/2018 05:39 PM, Liu, Yong wrote:
-Original Message-
From: Maxime Coquelin [mailto:maxime.coque...@redhat.com]
Sent: Thursday, June 28, 2018 11:16 PM
To: Liu, Yong ; Bie, Tiwei
Cc: Wang, Zhihong ; dev@dpdk.org
Subject: Re: [PATCH v3 08/11] net/virtio: add in-order Rx/Tx into
Hello Pablo,
On Thu, Jun 28, 2018 at 01:52:57AM +0100, Pablo de Lara wrote:
> Most crypto PMDs do not have a limitation
> of the number of the sessions that can be handled
> internally. The value that was set before was not
> actually used at all, since the sessions are created
> at the applicatio
2018-06-28 16:32 GMT+02:00 Ferruh Yigit :
> On 6/28/2018 2:15 PM, Rafal Kozik wrote:
>> Write combining (WC) increases NIC performance by making better
>> utilization of PCI bus, but cannot be use by all PMDs.
>>
>> To get internal_addr memory need to be mapped. But as memory could not be
>> mapped
On 6/8/2018 10:08 PM, Bruce Richardson wrote:
> By default, the DPAA2_USE_PHYS_IOVA setting with the make build-system
> is "y", which is overridden to "n" in the config file specifically for
> the arm64-dpaa2-linuxapp-gcc builds. The lack of this setting in meson
> builds causes issues for 32-bi
On 6/8/2018 10:08 PM, Bruce Richardson wrote:
> This patchset enables building DPDK on 32-bit systems, and has been tested
> using debian 32-bit on x86 i.e. doing an "i686" build in the old build
> system.
>
> Additional work is still required (possibly via cross-file) to get DPDK
> building for
2018-06-28 16:50 GMT+02:00 Ferruh Yigit :
> On 6/28/2018 2:15 PM, Rafal Kozik wrote:
>> Write combining (WC) increases NIC performance by making better
>> utilization of PCI bus, but cannot be used by all PMDs.
>>
>> It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in
>> drivers flags
On 6/29/2018 9:58 AM, Rafał Kozik wrote:
> 2018-06-28 16:50 GMT+02:00 Ferruh Yigit :
>> On 6/28/2018 2:15 PM, Rafal Kozik wrote:
>>> Write combining (WC) increases NIC performance by making better
>>> utilization of PCI bus, but cannot be used by all PMDs.
>>>
>>> It will be enabled only if RTE_PCI
On 6/28/2018 7:01 AM, Rasesh Mody wrote:
> This patch disables extended VLAN offload by default as PMD does not
> support it.
>
> Fixes: d87246a43759 ("net/qede: enable and disable VLAN filtering")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Rasesh Mody
Series applied to dpdk-next-net/master, than
From: Hyong Youb Kim
Fix missing or incorrect packet types discovered by DTS.
- Non-IP inner packets
Set the tunnel flag.
- Inner Ethernet packets
All supported tunnel packets have Ethernet as inner packets. So, set
INNER_L2_ETHER for all tunnel types.
- IPv4 fragments carrying TCP/UDP
Th
Updated a few commits in the patchset per suggestions by Ferrus Yigit.
thanks,
John
Hyong Youb Kim (12):
net/enic: fix receive packet types
net/enic: update the UDP RSS detection mechanism
net/enic: do not overwrite admin Tx queue limit
net/enic: initialize RQ fetch index before enabling R
From: Hyong Youb Kim
The UDP RSS interface has changed in the release firmware for 100G VIC
adapters. The capability bit is now in NIC_CFG. Also the driver is
supposed to use CMD_NIC_CFG_CHK and check if RSS config is
successful. No more changes are expected with respect to UDP RSS API.
Fixes: 9
From: Hyong Youb Kim
The fetch index must be initialized only when RQ is
disabled. Otherwise, it may lead to stale entries in IG descriptor
cache on the VIC.
Fixes: a74629cfa3a1 ("net/enic: enable RQ first and then post Rx buffers")
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
d
From: Hyong Youb Kim
Currently, enic_alloc_wq (via rte_eth_tx_queue_setup) may overwrite
the admin limit with a lower value. This is wrong as seen in the
following sequence.
1. UCS admin-set Tx queue limit (config.wq_desc_count) = 4096
2. Set up tx queue with 512 descriptors
The admin limit (
From: Hyong Youb Kim
Report min/max ring sizes, alignments, and so on, and rely on the
common checks implemented in the rte_ethdev layer.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic_ethdev.c | 24
drivers/net/enic/enic_main.c | 24
From: Hyong Youb Kim
The NIC has one configurable VXLAN port, which is set to the default
4789 upon vNIC reset. Adding a non-default port replaces this single
VXLAN port. Deleting the previously added non-default port restores
the VXLAN port to the hardware default.
Signed-off-by: Hyong Youb Kim
From: Hyong Youb Kim
Add a new devarg "ig-vlan-rewrite" to allow the user to set
non-default rewrite mode. The UCS VIC may add/remove/modify the VLAN
header of an ingress packet depending on the ingress VLAN rewrite
mode.
By default, the driver sets the pass-through mode, which tells the NIC
"do
From: Hyong Youb Kim
WQ is currently using vnic_wq_buf to store mbuf pointers for Tx
packets. But, it contains an unused mempool pointer and mbuf is
unnecessarily cast to void pointer. Remove vnic_wq_buf entirely and
use an mbuf pointer array instead.
Signed-off-by: Hyong Youb Kim
Reviewed-by:
From: Hyong Youb Kim
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
v2: documented new feature in enic.ini file
doc/guides/nics/features/enic.ini | 1 +
drivers/net/enic/base/vnic_wq.h | 1 +
drivers/net/enic/enic.h | 1 +
drivers/net/enic/enic_ethdev.c| 11
From: Hyong Youb Kim
Request one completion update per roughly 32 buffers. It saves DMA
resources on the NIC, PCIe utilization, and cache miss rates.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/base/vnic_wq.c | 1 +
drivers/net/enic/base/vnic_wq.h | 1 +
drive
From: Hyong Youb Kim
Add a much-simplified handler that works when all offloads are
disabled, except mbuf fast free. When compared against the default
handler, under ideal conditions, cycles per packet drop by 60+%.
The driver tries to use the simple handler first.
The idea of using specialized/
From: Hyong Youb Kim
The default tx handler checks the maximum packet size. Check it in the
prepare handler too. WQ stops working if the app/driver tries to send
oversized packets, so these checks are unavoidable.
Signed-off-by: Hyong Youb Kim
Reviewed-by: John Daley
---
drivers/net/enic/enic
Add an optimized Rx handler for non-scattered Rx.
Signed-off-by: Hyong Youb Kim
Signed-off-by: John Daley
---
drivers/net/enic/base/cq_desc.h | 1 +
drivers/net/enic/base/vnic_rq.h | 2 +
drivers/net/enic/enic.h | 2 +
drivers/net/enic/enic_ethdev.c | 3 +-
drivers/net/enic/eni
In the default Rx handler stop processing packets at the end of
the completion ring so that wrapping doesn't have to be checked
in the inner while loop.
Also, check the color bit in the completion without using a conditional.
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
drivers/ne
On 6/29/2018 8:04 AM, David Marchand wrote:
> Hello Ferruh,
>
> On Wed, May 16, 2018 at 4:42 PM, Ferruh Yigit wrote:
>> @@ -136,3 +132,22 @@ static bool pci_check_and_mask_intx(struct pci_dev
>> *pdev)
>> #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 5, 0)
>> #define HAVE_PCI_MSI_MASK_IRQ 1
>>
Signed-off-by: John Daley
Reviewed-by: Hyong Youb Kim
---
doc/guides/rel_notes/release_18_08.rst | 8
1 file changed, 8 insertions(+)
diff --git a/doc/guides/rel_notes/release_18_08.rst
b/doc/guides/rel_notes/release_18_08.rst
index bc0124295..903f046c8 100644
--- a/doc/guides/rel_not
1.added new logtype for kasumi driver.
2.registered new logtype.
3.KASUMI_LOG_ERR and CDEV_LOG_ERR are
replaced with new logtype name KASUMI_PMD_LOG.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
Reviewed-by: Pablo de Lara Guarch
---
v2:
Changed suggested macro name and t
1.added new logtype for aesni_mb driver.
2.registered new logtype.
3.MB_LOG_ERR and CDEV_LOG_ERR are
replaced with new logtype name AESNI_MB_PMD_LOG.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
Reviewed-by: Pablo de Lara Guarch
---
v2:
Changed suggested macro name and tit
The RTE_MAX_ETHPORT_QUEUE_STATS_MAPS does not exists, change
to the correct definition(RTE_ETHDEV_QUEUE_STAT_CNTRS)
Fixes: 5de201df8927 ("ethdev: add stats per queue")
Cc: sta...@dpdk.org
Signed-off-by: Jerin Jacob
---
lib/librte_ethdev/rte_ethdev.h | 4 ++--
1 file changed, 2 insertions(+), 2
On 6/29/2018 9:35 AM, Rafał Kozik wrote:
> 2018-06-28 16:32 GMT+02:00 Ferruh Yigit :
>> On 6/28/2018 2:15 PM, Rafal Kozik wrote:
>>> Write combining (WC) increases NIC performance by making better
>>> utilization of PCI bus, but cannot be use by all PMDs.
>>>
>>> To get internal_addr memory need to
Hi Pablo,
The Chained mbufs feature in doc/guides/compressdevs/features/default.ini needs
updating with this change.
Also while you're updating it I think we wanted to rename By-Pass? To Pass-thru?
Fiona
> -Original Message-
> From: De Lara Guarch, Pablo
> Sent: Wednesday, June 27, 2018
Caught on ubuntu-16.04 with hwe kernel for aarch64:
$ uname -a
Linux ubuntu1604arm64es 4.13.0-43-generic #48~16.04.1-Ubuntu SMP Thu May
17 13:08:01 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux
== Build kernel/linux/igb_uio
CC [M] .../kernel/linux/igb_uio/igb_uio.o
In file included from .../kernel
Support for write combining.
---
v2:
* Rebased on top of master.
* Fix typos.
* Make commit messages more verbose.
* Add comments.
* Initialize fd.
---
v3:
* Log if BAR was mapped with or without support for WC.
Rafal Kozik (4):
igb_uio: add wc option
bus/pci: reference driver structur
Write combining (WC) increases NIC performance by making better
utilization of PCI bus, but cannot be use by all PMDs.
To get internal_addr memory need to be mapped. But as memory could not be
mapped twice: with and without WC, it should be skipped for WC. [1]
To do not spoil other drivers that p
Add pointer to driver structure before calling rte_pci_map_device.
It allows to use driver flags for adjusting configuration.
Signed-off-by: Rafal Kozik
Acked-by: Bruce Richardson
---
drivers/bus/pci/pci_common.c | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
diff --g
Write combining (WC) increases NIC performance by making better
utilization of PCI bus, but cannot be used by all PMDs.
It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in
drivers flags. For proper work also igb_uio driver must be loaded with
wc_activate set to 1.
When mapping PCI r
Write combining (WC) increases NIC performance by making better
utilization of PCI bus. ENA PMD may make usage of this feature.
To enable it load igb_uio driver with wc_activate set to 1.
Signed-off-by: Rafal Kozik
Acked-by: Bruce Richardson
---
drivers/net/ena/ena_ethdev.c | 3 ++-
1 file cha
matan
On 6/27/2018 2:05 PM, Matan Azrad wrote:
Hi Guo
From: Guo, Jia
Sent: Wednesday, June 27, 2018 6:56 AM
To: Matan Azrad ; step...@networkplumber.org;
bruce.richard...@intel.com; ferruh.yi...@intel.com;
konstantin.anan...@intel.com; gaetan.ri...@6wind.com;
jingjing...@intel.com; Thomas Mon
As we know, hot plug is an importance feature, either use for the datacenter
device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring
the higher flexibility and continuality to the networking services in multiple
use cases in industry. So let we see, dpdk as an importance netw
When a hardware device is removed physically or the software disables
it, the hotplug occur. App need to call ether dev API to detach the device,
to unplug the device at the bus level and make access to the device
invalid. But the removal of the device from the software lists is not going
to be ins
This patch implements the ops of hotplug handler for PCI bus, it is
functional to remap a new dummy memory which overlap to the failure
memory to avoid MMIO read/write error.
Signed-off-by: Jeff Guo
---
v4->v3:
split patches to be small and clear.
---
drivers/bus/pci/pci_common.c | 28 ++
When device be hotplug, if data path still read/write device, the sigbus
error will occur, this error need to be handled. So a handler need to be
here to capture the signal and handle it correspondingly.
To handle sigbus error is a bus-specific behavior, this patch introduces
a bus ops so that eac
This patch introduces a failure handler mechanism to handle device
hot plug removal event.
First register sigbus handler, once sigbus error be captured, will
check the failure address and accordingly remap the invalid memory
for the corresponding device. Bese on this mechanism, it could
guaranty t
Use testpmd for example, to show how an application smoothly handle
failure when device being hot unplug. If app have enabled the device event
monitor and register the hot plug event’s callback before running, once
app detect the removal event, the callback would be called. It will first
stop the p
This patch implements the ops of sigbus handler for PCI bus, it is
functional to find the corresponding pci device which is be hot removal.
and then handle the hot plug failure for this device.
Signed-off-by: Jeff Guo
---
v4->v3:
split patches to be small and clear.
---
drivers/bus/pci/pci_commo
When hot unplug device, the kernel will release the device resource in the
kernel side, such as the fd sys file will disappear, and the irq will be
released. At this time, if igb uio driver still try to release this
resource, it will cause kernel crash. On the other hand, something like
interrupt d
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
---
v4->v3:
split patches to be small and clear.
---
lib/librte_eal/common/eal_common_bus.c | 34 +-
lib/librte_eal/common/eal_pri
As we know, there 2 different hotplug mechanisms in dpdk, the one is
ethdev event + kernel driver hotplug solution, while the other one is
eal device event + pci uio driver hotplug solution, each of them have
different configure and callback process in testpmd. In oder to avoid
the race between the
2018-06-29 11:05 GMT+02:00 Ferruh Yigit :
> On 6/29/2018 9:58 AM, Rafał Kozik wrote:
>> 2018-06-28 16:50 GMT+02:00 Ferruh Yigit :
>>> On 6/28/2018 2:15 PM, Rafal Kozik wrote:
Write combining (WC) increases NIC performance by making better
utilization of PCI bus, but cannot be used by all
As we know, hot plug is an importance feature, either use for the datacenter
device’s fail-safe, or use for SRIOV Live Migration in SDN/NFV. It could bring
the higher flexibility and continuality to the networking services in multiple
use cases in industry. So let we see, dpdk as an importance netw
When a hardware device is removed physically or the software disables
it, the hotplug occur. App need to call ether dev API to detach the device,
to unplug the device at the bus level and make access to the device
invalid. But the removal of the device from the software lists is not going
to be ins
This patch implements the ops of hotplug handler for PCI bus, it is
functional to remap a new dummy memory which overlap to the failure
memory to avoid MMIO read/write error.
Signed-off-by: Jeff Guo
---
v4->v3:
split patches to be small and clear.
---
drivers/bus/pci/pci_common.c | 28 ++
When hot unplug device, the kernel will release the device resource in the
kernel side, such as the fd sys file will disappear, and the irq will be
released. At this time, if igb uio driver still try to release this
resource, it will cause kernel crash. On the other hand, something like
interrupt d
This patch implements the ops of sigbus handler for PCI bus, it is
functional to find the corresponding pci device which is be hot removal.
and then handle the hot plug failure for this device.
Signed-off-by: Jeff Guo
---
v4->v3:
split patches to be small and clear.
---
drivers/bus/pci/pci_commo
When device be hotplug, if data path still read/write device, the sigbus
error will occur, this error need to be handled. So a handler need to be
here to capture the signal and handle it correspondingly.
To handle sigbus error is a bus-specific behavior, this patch introduces
a bus ops so that eac
This patch introduces a failure handler mechanism to handle device
hot plug removal event.
First register sigbus handler, once sigbus error be captured, will
check the failure address and accordingly remap the invalid memory
for the corresponding device. Bese on this mechanism, it could
guaranty t
Use testpmd for example, to show how an application smoothly handle
failure when device being hot unplug. If app have enabled the device event
monitor and register the hot plug event’s callback before running, once
app detect the removal event, the callback would be called. It will first
stop the p
This patch aim to add a helper to iterate all buses to find the
corresponding bus to handle the sigbus error.
Signed-off-by: Jeff Guo
---
v4->v3:
split patches to be small and clear.
---
lib/librte_eal/common/eal_common_bus.c | 34 +-
lib/librte_eal/common/eal_pri
As we know, there 2 different hotplug mechanisms in dpdk, the one is
ethdev event + kernel driver hotplug solution, while the other one is
eal device event + pci uio driver hotplug solution, each of them have
different configure and callback process in testpmd. In oder to avoid
the race between the
On 6/29/2018 11:28 AM, Rafał Kozik wrote:
> 2018-06-29 11:05 GMT+02:00 Ferruh Yigit :
>> On 6/29/2018 9:58 AM, Rafał Kozik wrote:
>>> 2018-06-28 16:50 GMT+02:00 Ferruh Yigit :
On 6/28/2018 2:15 PM, Rafal Kozik wrote:
> Write combining (WC) increases NIC performance by making better
> u
Hi Jeff,
>
> This patch introduces a failure handler mechanism to handle device
> hot plug removal event.
>
> First register sigbus handler, once sigbus error be captured, will
> check the failure address and accordingly remap the invalid memory
> for the corresponding device. Bese on this mecha
> +int
> +rte_bus_sigbus_handler(const void *failure_addr)
> +{
> + struct rte_bus *bus;
> + int old_errno = rte_errno;
> + int ret = 0;
> +
> + rte_errno = 0;
> +
> + bus = rte_bus_find(NULL, bus_handle_sigbus, failure_addr);
> + if (bus == NULL) {
> + RTE_LOG
On 6/29/2018 11:24 AM, Rafal Kozik wrote:
> Write combining (WC) increases NIC performance by making better
> utilization of PCI bus, but cannot be use by all PMDs.
>
> To get internal_addr memory need to be mapped. But as memory could not be
> mapped twice: with and without WC, it should be skipp
On 6/29/2018 11:13 AM, David Marchand wrote:
> Caught on ubuntu-16.04 with hwe kernel for aarch64:
>
> $ uname -a
> Linux ubuntu1604arm64es 4.13.0-43-generic #48~16.04.1-Ubuntu SMP Thu May
> 17 13:08:01 UTC 2018 aarch64 aarch64 aarch64 GNU/Linux
>
> == Build kernel/linux/igb_uio
> CC [M] .../ke
On 6/29/2018 2:48 AM, Wei Zhao wrote:
> rte_eth_rx_descritpr_status and rte_eth_tx_descriptor_status
> are supported by fm10K.
>
> Signed-off-by: Wei Zhao
>
> ---
>
> v2:
> -fix DD check error in tx descriptor
>
> v3:
> -fix DD check index error
>
> v4:
> -fix error in RS bit list poll
>
> v
hi,konstantin
On 6/29/2018 6:49 PM, Ananyev, Konstantin wrote:
Hi Jeff,
This patch introduces a failure handler mechanism to handle device
hot plug removal event.
First register sigbus handler, once sigbus error be captured, will
check the failure address and accordingly remap the invalid me
> -Original Message-
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yeddula, Avinash
> Sent: Friday, June 29, 2018 1:11 AM
> To: dev@dpdk.org; dev ; us...@dpdk.org
> Cc: Bly, Mike
> Subject: [dpdk-dev] 17.05 --> 17.11, minimum hash table key size
>
> Hello,
>
> We are in process
hi, konstantin
On 6/29/2018 6:51 PM, Ananyev, Konstantin wrote:
+int
+rte_bus_sigbus_handler(const void *failure_addr)
+{
+ struct rte_bus *bus;
+ int old_errno = rte_errno;
+ int ret = 0;
+
+ rte_errno = 0;
+
+ bus = rte_bus_find(NULL, bus_handle_sigbus, failure_a
DEV_RX_OFFLOAD_KEEP_CRC offload flag is added. PMDs that support
keeping CRC should advertise this offload capability.
DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release
default behavior in PMDs are to keep the CRC until this flag removed
Until DEV_RX_OFFLOAD_CRC_STRIP flag is removed:
-
> -Original Message-
> From: Xing, Beilei
> Sent: Thursday, June 28, 2018 9:46 AM
> To: Zhang, Qi Z
> Cc: Wu, Jingjing ; Yu, De ;
> dev@dpdk.org
> Subject: RE: [PATCH v3] net/i40e: remove VF interrupt handler
>
>
>
> > -Original Message-
> > From: Zhang, Qi Z
> > Sent: Wednes
29/06/2018 14:41, Ferruh Yigit:
> DEV_RX_OFFLOAD_KEEP_CRC offload flag is added. PMDs that support
> keeping CRC should advertise this offload capability.
>
> DEV_RX_OFFLOAD_CRC_STRIP flag will remain one more release
> default behavior in PMDs are to keep the CRC until this flag removed
>
> Unti
> -Original Message-
> From: Guo, Jia
> Sent: Friday, June 29, 2018 12:15 PM
> To: Ananyev, Konstantin ;
> step...@networkplumber.org; Richardson, Bruce
> ; Yigit, Ferruh ;
> gaetan.ri...@6wind.com; Wu, Jingjing
> ; tho...@monjalon.net; mo...@mellanox.com;
> ma...@mellanox.com; Van Ha
From: Kozik
Add pointer to driver structure before calling rte_pci_map_device.
It allows to use driver flags for adjusting configuration.
Signed-off-by: Rafal Kozik
Acked-by: Bruce Richardson
---
drivers/bus/pci/pci_common.c | 17 -
1 file changed, 12 insertions(+), 5 deletion
Support for write combining.
---
v2:
* Rebased on top of master.
* Fix typos.
* Make commit messages more verbose.
* Add comments.
* Initialize fd.
---
v3:
* Log if BAR was mapped with or without support for WC.
---
v4:
* Before opening PCI resource, check if it supports WC.
* Log only w
From: Kozik
Write combining (WC) increases NIC performance by making better
utilization of PCI bus, but cannot be use by all PMD.
To get internal_addr memory need to be mapped. But as memory could not be
mapped twice: with and without WC it should be skipped for WC. [1]
To do not spoil other dr
From: Kozik
Write combining (WC) increases NIC performance by making better
utilization of PCI bus, but cannot be used by all PMDs.
It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in
drivers flags. For proper work also igb_uio driver must be loaded with
wc_activate set to 1.
When
From: Kozik
Write combining (WC) increases NIC performance by making better
utilization of PCI bus. ENA PMD may make usage of this feature.
To enable it load igb_uio driver with wc_activate set to 1.
Signed-off-by: Rafal Kozik
Acked-by: Bruce Richardson
---
drivers/net/ena/ena_ethdev.c | 3 +
> -Original Message-
> From: Guo, Jia
> Sent: Friday, June 29, 2018 12:23 PM
> To: Ananyev, Konstantin ;
> step...@networkplumber.org; Richardson, Bruce
> ; Yigit, Ferruh ;
> gaetan.ri...@6wind.com; Wu, Jingjing
> ; tho...@monjalon.net; mo...@mellanox.com;
> ma...@mellanox.com; Van Ha
From: Pallantla Poornima
1.added new logtype for null driver.
2.registered new logtype.
3.NULL_CRYPTO_LOG_ERR, RTE_LOG_ERR and CDEV_LOG_ERR
are replaced with new logtype name NULL_PMD_LOG.
Signed-off-by: Pallantla Poornima
Reviewed-by: Reshma Pattan
Reviewed-by: Pablo de Lara Guarch
---
v2:
1.added new logtype for openssl driver.
2.registered new logtype.
3.OPENSSL_LOG_ERR and CDEV_LOG_ERR are
replaced with new logtype name OPENSSL_PMD_LOG.
Signed-off-by: Naga Suresh Somarowthu
Reviewed-by: Reshma Pattan
Reviewed-by: Pablo de Lara Guarch
---
v2:
Changed suggested macro name and
On Fri, Jun 29, 2018 at 12:21:39PM +, Ananyev, Konstantin wrote:
>
>
> > -Original Message-
> > From: Guo, Jia
> > Sent: Friday, June 29, 2018 12:23 PM
> > To: Ananyev, Konstantin ;
> > step...@networkplumber.org; Richardson, Bruce
> > ; Yigit, Ferruh ;
> > gaetan.ri...@6wind.com; W
On 6/29/2018 12:55 AM, Thomas Monjalon wrote:
> 20/06/2018 19:15, Ferruh Yigit:
>> On 6/20/2018 6:07 PM, Dan Gora wrote:
>>> Hi Ferruh,
>>>
>>> The documentation for rte_eth_dev_configure() should get updated as
>>> well to document this requirement to strip the unsupported RSS hash
>>> function bi
ethdev layer introduced checks for application requested RSS hash
functions and returns error for ones unsupported by hardware
This check breaks some sample applications which blindly configures
RSS hash functions without checking underlying hardware support.
Updated examples to mask out unsuppor
Hi,
I was about to apply it, but there are quite a few checkpatch and
git-check-log.sh issues reported.
Could you please resent with this fixed?
Also, I think it would be better to squash the doc patches in relevant
ones.
Thanks,
Maxime
On 06/28/2018 11:52 PM, Marvin Liu wrote:
In latest virt
> How can I confirm this silently fall-back behavior, is there any log can I
> turn
> on in kernel or anything from proc/sysfs?
I cannot find any.
I check it by measuring write speed.
2018-06-29 14:17 GMT+02:00 Rafal Kozik :
> From: Kozik
>
> Write combining (WC) increases NIC performance by ma
On 6/29/2018 1:17 PM, Rafal Kozik wrote:
> From: Kozik
>
> Write combining (WC) increases NIC performance by making better
> utilization of PCI bus, but cannot be use by all PMD.
>
> To get internal_addr memory need to be mapped. But as memory could not be
> mapped twice: with and without WC it
This patch enables setting the MTU of an igbvf device by re-using the
eth_igb_mtu_set() in igbvf_eth_dev_ops.
Cc: sta...@dpdk.org
Signed-off-by: Ian Stokes
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/i
Hi Bernard,
On 06/26/2018 01:09 PM, Iremonger, Bernard wrote:
checkpatch.pl is showing the following warnings:
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#122: FILE: app/test-pmd/noisy_vnf.c:1:
+/* SPDX-License-Identifier: BSD-3-Clause
I'm not sure to get what is wro
On 6/29/2018 1:17 PM, Rafal Kozik wrote:
> From: Kozik
>
> Write combining (WC) increases NIC performance by making better
> utilization of PCI bus, but cannot be use by all PMD.
>
> To get internal_addr memory need to be mapped. But as memory could not be
> mapped twice: with and without WC it
On 6/29/2018 2:36 PM, Ian Stokes wrote:
This patch enables setting the MTU of an igbvf device by re-using the
eth_igb_mtu_set() in igbvf_eth_dev_ops.
Cc: sta...@dpdk.org
Signed-off-by: Ian Stokes
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/
This patch enables setting the MTU of an igbvf device by re-using the
eth_igb_mtu_set() in igbvf_eth_dev_ops.
Cc: sta...@dpdk.org
Signed-off-by: Ian Stokes
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/i
Support for write combining.
---
v2:
* Rebased on top of master.
* Fix typos.
* Make commit messages more verbose.
* Add comments.
* Initialize fd.
---
v3:
* Log if BAR was mapped with or without support for WC.
---
v4:
* Log only if WC mapping failed.
* Log if wc_activate is set in igb_
On Fri, Apr 27, 2018 at 01:03:31AM +0300, Medvedkin Vladimir wrote:
> Signed-off-by: Medvedkin Vladimir
> ---
> config/common_base | 6 +
> doc/api/doxy-api.conf | 1 +
> lib/Makefile | 2 +
> lib/librte_rib/Makefile| 23 ++
>
From: Kozik
Write combining (WC) increases NIC performance by making better
utilization of PCI bus. ENA PMD may make usage of this feature.
To enable it load igb_uio driver with wc_activate set to 1.
Signed-off-by: Rafal Kozik
Acked-by: Bruce Richardson
---
drivers/net/ena/ena_ethdev.c | 3 +
From: Kozik
Write combining (WC) increases NIC performance by making better
utilization of PCI bus, but cannot be used by all PMDs.
It will be enabled only if RTE_PCI_DRV_WC_ACTIVATE will be set in
drivers flags. For proper work also igb_uio driver must be loaded with
wc_activate set to 1.
When
From: Kozik
Write combining (WC) increases NIC performance by making better
utilization of PCI bus, but cannot be use by all PMD.
To get internal_addr memory need to be mapped. But as memory could not be
mapped twice: with and without WC it should be skipped for WC. [1]
To do not spoil other dr
From: Kozik
Add pointer to driver structure before calling rte_pci_map_device.
It allows to use driver flags for adjusting configuration.
Signed-off-by: Rafal Kozik
Acked-by: Bruce Richardson
---
drivers/bus/pci/pci_common.c | 17 -
1 file changed, 12 insertions(+), 5 deletion
1 - 100 of 182 matches
Mail list logo
