On Sun, Apr 29, 2018 at 09:03:08PM +0300, Shahaf Shuler wrote:
> A new ethdev API was exposed by
> commit 3be82f5cc5e3 ("ethdev: support PMD-tuned Tx/Rx parameters")
>
> Enabling the PMD to provide default parameters in case no strict request
> from application in order to improve the out of the b
On Sun, Apr 29, 2018 at 09:03:07PM +0300, Shahaf Shuler wrote:
> According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS
> should be called before ETHTOOL_GSET as the later one deprecated.
>
> Fixes: f47ba80080ab ("net/mlx5: remove kernel version check")
> Cc: nelio.laranje...@6
Hello Bruce,
It should work because decision about kind of mapping is made in patch
3 based on PMD request.
ENA use only one BAR in wc mode and two other without caching,
therefore not making remap in igb_uio rather not spoil anything.
I added patch 1 because this variable is provided also outsi
On 28-Apr-18 10:38 AM, Andrew Rybchenko wrote:
On 04/25/2018 01:36 PM, Anatoly Burakov wrote:
The original implementation used flock() locks, but was later
switched to using fcntl() locks for page locking, because
fcntl() locks allow locking parts of a file, which is useful
for single-file segme
On Mon, Apr 30, 2018 at 10:07:07AM +0200, Rafał Kozik wrote:
> Hello Bruce,
>
> It should work because decision about kind of mapping is made in patch
> 3 based on PMD request.
>
> ENA use only one BAR in wc mode and two other without caching,
> therefore not making remap in igb_uio rather not sp
On Fri, Apr 27, 2018 at 06:07:04PM +0100, Anatoly Burakov wrote:
> We were closing descriptor before checking if mapping has
> failed, but if it did, we did a second close afterwards. Fix
> it by moving closing descriptor to after we've done all error
> checks.
>
> Coverity issue: 272560
>
> Fixe
In the loop to copy virtio-net header to the descriptor buffer,
destination pointer was incremented instead of the source
pointer.
Coverity issue: 277240
Fixes: 82c93a567d3b ("examples/vhost: move to safe GPA translation API")
Signed-off-by: Maxime Coquelin
---
examples/vhost/virtio_net.c | 2 +
This series fixes copying virtio net header to discontiguous descriptor
buffer in VA space.
The issue was spotted by Coverity for examples/vhost, but same issue
was present in vhost-user library.
Maxime Coquelin (2):
examples/vhost: fix header copy to discontiguous desc buffer
vhost: fix head
In the loop to copy virtio-net header to the descriptor buffer,
destination pointer was incremented instead of the source
pointer.
Fixes: fb3815cc614d ("vhost: handle virtually non-contiguous buffers in Rx-mrg")
Fixes: 6727f5a739b6 ("vhost: handle virtually non-contiguous buffers in Rx")
Cc: sta.
At hugepage info initialization, EAL takes out a write lock on
hugetlbfs directories, and drops it after the memory init is
finished. However, in non-legacy mode, if "-m" or "--socket-mem"
switches are passed, this leads to a deadlock because EAL tries
to allocate pages (and thus take out a write l
Coverity issue: 277232
Coverity issue: 277237
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_cr
Coverity issue: 233232
Coverity issue: 233237
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_cryp
On 04/30/2018 12:36 PM, Fan Zhang wrote:
Coverity issue: 233232
Coverity issue: 233237
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Maxime Coque
On 04/30/2018 12:31 PM, Fan Zhang wrote:
Coverity issue: 277232
Coverity issue: 277237
Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
Signed-off-by: Fan Zhang
---
lib/librte_vhost/vhost_crypto.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Maxime Coqu
25/04/2018 12:03, Luca Boccassi:
> On Wed, 2018-04-25 at 09:33 +0100, Ferruh Yigit wrote:
> > On 4/20/2018 4:52 PM, Aaron Conole wrote:
> > > Kevin Traynor writes:
> > > > On 04/18/2018 02:28 PM, Thomas Monjalon wrote:
> > > > > 18/04/2018 14:28, Ferruh Yigit:
> > > > > > On 4/18/2018 10:14 AM, Th
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Sunday, April 29, 2018 9:44 PM
> To: Gujjar, Abhinandan S
> Cc: hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org; Vangati,
> Narender ; Rao, Nikhil ;
> Eads, Gage
> Subject: Re: [v2,2/6] ev
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Sunday, April 29, 2018 9:53 PM
> To: Gujjar, Abhinandan S
> Cc: hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org; Vangati,
> Narender ; Rao, Nikhil ;
> Eads, Gage
> Subject: Re: [v2,3/6] ev
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Sunday, April 29, 2018 9:55 PM
> To: Gujjar, Abhinandan S
> Cc: hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org; Vangati,
> Narender ; Rao, Nikhil ;
> Eads, Gage
> Subject: Re: [v2,5/6] ev
Mapping size is a 64-bit integer, but mmap() will accept size_t for
size mappings. A user could request a mapping with an alignment, which
would have overflown size_t, so check if (size + alignment) will
overflow size_t.
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_common_memory.
When we ask to reserve virtual areas, we usually include
alignment in the mapping size, and that memory ends up
being wasted. Wasting a gigabyte of VA space while trying to
reserve one gigabyte is pretty expensive on 32-bit, so after
we're done mapping, unmap unneeded space.
Signed-off-by: Anatoly
-Original Message-
> Date: Mon, 30 Apr 2018 11:21:38 +
> From: "Gujjar, Abhinandan S"
> To: Jerin Jacob
> CC: "hemant.agra...@nxp.com" ,
> "akhil.go...@nxp.com" , "dev@dpdk.org"
> , "Vangati, Narender" , "Rao,
> Nikhil" , "Eads, Gage"
> Subject: RE: [v2,5/6] eventdev: add event cr
On 28-Apr-18 10:38 AM, Andrew Rybchenko wrote:
On 04/25/2018 01:36 PM, Anatoly Burakov wrote:
The original implementation used flock() locks, but was later
switched to using fcntl() locks for page locking, because
fcntl() locks allow locking parts of a file, which is useful
for single-file segme
> -Original Message-
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com]
> Sent: Sunday, April 29, 2018 10:01 PM
> To: Gujjar, Abhinandan S
> Cc: hemant.agra...@nxp.com; akhil.go...@nxp.com; dev@dpdk.org; Vangati,
> Narender ; Rao, Nikhil ;
> Eads, Gage
> Subject: Re: [v2,6/6] d
On 04/30/2018 01:31 PM, Burakov, Anatoly wrote:
On 28-Apr-18 10:38 AM, Andrew Rybchenko wrote:
On 04/25/2018 01:36 PM, Anatoly Burakov wrote:
The original implementation used flock() locks, but was later
switched to using fcntl() locks for page locking, because
fcntl() locks allow locking par
As has been suggested [1], all DPDK runtime paths should be put
into a single place. This patchset accomplishes exactly that.
If running as root, all files will be put under /var/run/dpdk/,
otherwise they will be put under $XDG_RUNTIME_PATH/dpdk/, or, if
that environment variable is not defined, a
Currently, during runtime, DPDK will store a bunch of files here
and there (in /var/run, /tmp or in $HOME). Fix it by creating a
DPDK-specific runtime directory, under which all runtime data
will be placed. The template for creating this runtime directory
is the following:
/dpdk//
Where is set
The original name for this path was not too descriptive and
confusing. Rename it to a more appropriate and descriptive name:
it stores data about hugepages, so name it eal_hugepage_data_path().
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/common/eal_filesystem.h | 2 +-
lib/librte_eal/li
Fix all calls to functions in eal_filesystem to produce paths
residing inside dedicated DPDK runtime directory.
Signed-off-by: Anatoly Burakov
---
lib/librte_eal/bsdapp/eal/eal.c| 2 +
lib/librte_eal/common/eal_filesystem.h | 71 +-
lib/librte_eal/linuxap
The define was a leftover from IVSHMEM library.
Fixes: c711ccb30987 ("ivshmem: remove library and its EAL integration")
Cc: david.march...@6wind.com
Cc: sta...@dpdk.org
Signed-off-by: Anatoly Burakov
Reviewed-by: David Marchand
---
lib/librte_eal/common/eal_filesystem.h | 2 --
1 file changed,
There are two capabilities related to CRC stripping:
1. mlx4 HW capability to perform CRC stripping on a recieved packet.
This capability is built in mlx4 HW. It should be returned by the API
call mlx4_get_rx_queue_offloads().
2. mlx4 driver capability to enable/disable HW CRC stripping. This
capab
24/04/2018 13:49, Nipun Gupta:
> drivers/raw/dpaa2_qdma/dpaa2_qdma.c| 294
> +
> drivers/raw/dpaa2_qdma/dpaa2_qdma.h| 66 +
> drivers/raw/dpaa2_qdma/dpaa2_qdma_logs.h | 46
[...]
> +install_headers('rte_pmd_dpaa2_qdma.h')
I
Monday, April 30, 2018 1:38 PM, Anatoly Burakov:
> Cc: arybche...@solarflare.com; anatoly.bura...@intel.com
> Subject: [dpdk-dev] [PATCH] eal: check if hugedir write lock is already being
> held
>
> At hugepage info initialization, EAL takes out a write lock on hugetlbfs
> directories, and drops i
On Mon, Apr 30, 2018 at 12:21:42PM +0100, Anatoly Burakov wrote:
> Mapping size is a 64-bit integer, but mmap() will accept size_t for
> size mappings. A user could request a mapping with an alignment, which
> would have overflown size_t, so check if (size + alignment) will
> overflow size_t.
>
>
On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote:
> When we ask to reserve virtual areas, we usually include
> alignment in the mapping size, and that memory ends up
> being wasted. Wasting a gigabyte of VA space while trying to
> reserve one gigabyte is pretty expensive on 32-bit, s
30/04/2018 12:36, Fan Zhang:
> Coverity issue: 233232
> Coverity issue: 233237
> Fixes: 3bb595ecd682 ("vhost/crypto: add request handler")
>
> Signed-off-by: Fan Zhang
2 comments, Fan:
1/ I think it the v2 of a previous commit.
Please update the patchwork status (superseded),
use -v option for
Hi Thomas, Ferruh, all,
Initial testing on RC1 from our System Test and Validation shows a lot of
defects/issues, and from the list it appears others may be seeing issues
too. These issues, as well as causing test failures are blocking other
tests from being run. We are also seeing some serious pe
30/04/2018 14:57, Bruce Richardson:
> Hi Thomas, Ferruh, all,
>
> Initial testing on RC1 from our System Test and Validation shows a lot of
> defects/issues, and from the list it appears others may be seeing issues
> too. These issues, as well as causing test failures are blocking other
> tests fr
On 04/30/2018 01:38 PM, Anatoly Burakov wrote:
At hugepage info initialization, EAL takes out a write lock on
hugetlbfs directories, and drops it after the memory init is
finished. However, in non-legacy mode, if "-m" or "--socket-mem"
switches are passed, this leads to a deadlock because EAL tri
On 04/30/2018 02:31 PM, Burakov, Anatoly wrote:
On 28-Apr-18 10:38 AM, Andrew Rybchenko wrote:
On 04/25/2018 01:36 PM, Anatoly Burakov wrote:
The original implementation used flock() locks, but was later
switched to using fcntl() locks for page locking, because
fcntl() locks allow locking parts
Thomas Monjalon writes:
> The fake getauxval function does not use its parameter.
> So the compiler raised this error:
> lib/librte_eal/common/eal_common_cpuflags.c:25:25: error:
> unused parameter 'type'
>
> Fixes: 2ed9bf330709 ("eal: abstract away the auxiliary vector")
> Cc: acon..
Thomas Monjalon writes:
> The auxiliary vector read is implemented only for Linux.
> It could be done with procstat_getauxv() for FreeBSD.
>
> Since the commit below, the auxiliary vector functions
> are compiled for every architectures, including x86
> which is tested with FreeBSD.
>
> This patc
30/04/2018 15:07, Andrew Rybchenko:
> On 04/30/2018 01:38 PM, Anatoly Burakov wrote:
> > At hugepage info initialization, EAL takes out a write lock on
> > hugetlbfs directories, and drops it after the memory init is
> > finished. However, in non-legacy mode, if "-m" or "--socket-mem"
> > switches
25/04/2018 15:42, Anatoly Burakov:
> When heap initializes, we need to add already allocated segments
> onto the heap. However, in doing that, we never increased total
> heap size. Fix it by adding segment length to total heap length
> when initializing the heap.
>
> Fixes: 66cc45e293ed ("mem: rep
The port_init function calls the rte_eth_dev_is_valid_port function.
This function now returns 1 if the port state is attached.
A return value of 1 now means a valid port.
Fixes: a9dbe1802226 ("fix ethdev port id validation")
Signed-off-by: Bernard Iremonger
---
examples/flow_classify/flow_class
30/04/2018 15:43, Bernard Iremonger:
> The port_init function calls the rte_eth_dev_is_valid_port function.
> This function now returns 1 if the port state is attached.
> A return value of 1 now means a valid port.
>
> Fixes: a9dbe1802226 ("fix ethdev port id validation")
> Signed-off-by: Bernard
I just wanted to say I'm using the functionality for debugging NFP firmware
and getting some useful information from the device.
I did not plan to have this upstream, but after this patch for removing the
experimental tag, I think it would be a good idea.
Thanks!
On Wed, Apr 25, 2018 at 1:58 PM,
24/04/2018 18:26, Thomas Monjalon:
> Hi,
>
> > Declan Doherty (4):
> > ethdev: Add tunnel encap/decap actions
> > ethdev: Add group JUMP action
> > ethdev: add mark flow item to rte_flow_item_types
> > ethdev: add shared counter support to rte_flow
>
> No specific comment.
>
> It is only
>
> On 04/27/2018 04:19 PM, Ciara Loftus wrote:
> > rte_eth_vhost_get_vid_from_port_id returns a value of 0 if called before
> > the first call to the new_device callback. A vid value >=0 suggests the
> > device is active which is not the case in this instance. Initialise vid
> > to a negative val
Why is Netronome driver using its own version of existing rte_pci_read_config?
And hard coding magic numbers for offsets.
This shows up as Coverity error
*** CID 277243: Error handling issues
Changes introduced by e0cb96204b71 modified the default name generated
for the i40e PF PMD, this patch reverts the default name to the
original PCI BDBF.
Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
Signed-off-by: Declan Doherty
---
drivers/net/i40e/i40e_ethdev.c | 8 +++--
Initialise rte_ethdev_args nb_representor_ports to zero to handle
the case where no devargs are passed to the IXGBE PF on
device probe, so that there is no invalid attempts to create
representor ports.
Coverity Issue: 277231
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Sig
Changes introduced by cf80ba6e2038 modified the default name generated
for the IXGBE PF PMD, this patch reverts the default name to the
original PCI BDBF.
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Signed-off-by: Declan Doherty
---
drivers/net/ixgbe/ixgbe_ethdev.c | 8 +
Add NULL parameter check for rte_eth_dev_allocated() API call to
eth_ixgbe_pci_probe().
Coverity Issue: 277216
Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports")
Signed-off-by: Declan Doherty
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff -
Hi Olivier,
On 04/24/2018 04:46 PM, Olivier Matz wrote:
Some parts of dpdk use their own management threads. Most of the time,
the affinity of the thread is not properly set: it should not be scheduled
on the dataplane cores, because interrupting them can cause packet losses.
This patchset intr
This patch caches all dirty pages logging until the used ring index
is updated. These dirty pages won't be accessed by the guest as
long as the host doesn't give them back to it by updating the
index.
The goal of this optimization is to fix a performance regression
introduced when the vhost librar
Hi Maxime,
Le 30 avril 2018 17:45:52 GMT+02:00, Maxime Coquelin
a écrit :
>Hi Olivier,
>
>On 04/24/2018 04:46 PM, Olivier Matz wrote:
>> Some parts of dpdk use their own management threads. Most of the
>time,
>> the affinity of the thread is not properly set: it should not be
>scheduled
>> on th
Ethdev RX offloads API has changed since: commit ce17eddefc20
("ethdev: introduce Rx queue offloads API")
This patch adopts the new RX Offload API in vmxnet3 driver.
Signed-off-by: Louis Luo
---
drivers/net/vmxnet3/vmxnet3_ethdev.c | 61 ++--
1 file changed, 45 i
> -Original Message-
> From: Louis Luo [mailto:llo...@vmware.com]
> Sent: Monday, April 30, 2018 3:21 PM
> To: Yong Wang
> Cc: dev@dpdk.org; Louis Luo
> Subject: [PATCH] net/vmxnet3: convert to new rx offload api
>
> Ethdev RX offloads API has changed since: commit ce17eddefc20
> ("ethde
From: Scott Branden
Rename driver version from "Broadcom Cumulus driver" to
"Broadcom NetXtreme driver" to reflect this driver is applicable to
NetXtreme family beyond Cumulus.
Signed-off-by: Scott Branden
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file chan
From: Jay Ding
Return EINVAL instead of ENOSPC when invalid queue_idx passed in
during rx and tx queue_setup_op routines.
Signed-off-by: Jay Ding
Signed-off-by: Scott Branden
Reviewed-by: Ray Jui
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_rxq.c | 2 +-
drivers/net/bnxt/bnxt_
From: Qingmin Liu
Add support to bnxt driver to register RTE_ETH_EVENT_INTR_LSC
event and monitor physical link status.
Signed-off-by: Qingmin Liu
Signed-off-by: Scott Branden
Signed-off-by: Ajit Kumar Khaparde
Reviewed-by: Randy Schacher
---
drivers/net/bnxt/bnxt_ethdev.c | 5 +
1 file
From: Scott Branden
rename check_zero_bytes to bnxt_check_zero_bytes to match proper prefix.
Signed-off-by: Scott Branden
Signed-off-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
drivers/net/bnxt/bnxt_filter.c | 8 +---
drivers/net/bnxt/bnxt_filter.h | 2 +-
3 files c
From: Qingmin Liu
MTU setting does not take effect after rte_eth_dev_configure
is called with jumbo enable unless it is configured using the
set_mtu dev_op.
Fixes: daef48efe5e5 ("net/bnxt: support set MTU")
Cc: sta...@dpdk.org
Signed-off-by: Qingmin Liu
Signed-off-by: Scott Branden
Reviewed-b
From: Rahul Gupta
Validate pointers aren't pointing to uninitialized areas
including txq and rxq before using them to avoid
bnxt driver from crashing.
Signed-off-by: Rahul Gupta
Signed-off-by: Jay Ding
Signed-off-by: Scott Branden
Reviewed-by: Ray Jui
Reviewed-by: Ajit Kumar Khaparde
Review
We were not considering the case of nested VLANs while
calculating MTU. This patch takes care of the same.
Fixes: daef48efe5e5 ("net/bnxt: support set MTU")
Cc: sta...@dpdk.org
Signed-off-by: Qingmin Liu
Signed-off-by: Scott Branden
Reviewed-by: Jay Ding
Reviewed-by: Ajit Kumar Khaparde
Revie
From: Jay Ding
return error if init is not complete before accessing stats.
Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats")
Cc: sta...@dpdk.org
Signed-off-by: Jay Ding
Signed-off-by: Scott Branden
Reviewed-by: Ajit Kumar Khaparde
Reviewed-by: Randy Schacher
Sig
Patchset against dpdk-next-net.
Please apply.
Ajit Khaparde (3):
net/bnxt: fix MTU calculation
net/bnxt: fix to reset status of initialization
net/bnxt: fix usage of vnic id
Jay Ding (2):
net/bnxt: return EINVAL instead of ENOSPC on invalid max ring
net/bnxt: return error if init is not
From: Xiaoxin Peng
In the start/stop_op operation, mbufs allocated for rings were not freed
1) add bnxt_free_tx_mbuf/bnxt_free_rx_mbuf in bnxt_dev_stop_op to free MBUF
before freeing the rings.
2) MBUF allocation and free routines were not in sync. Allocation uses the
ring->ring_size inclu
clear flag on stop at proper location to avoid race conditions.
Fixes: ed2ced6fe927 ("net/bnxt: check initialization before accessing stats")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
From: Randy Schacher
Clear HWRM sniffer list for DPDK PFs so that VFs on
DPDK PFs initialize successfully. DPDK PF driver does not
handle HWRM commands from VFs.
Signed-off-by: Randy Schacher
Signed-off-by: Scott Branden
Reviewed-by: Ajit Kumar Khaparde
---
drivers/net/bnxt/bnxt_hwrm.c | 9 +
VNIC ID returned by the FW is a 16-bit field.
We are incorrectly using it as a 32-bit value in few places.
This patch corrects that.
Fixes: daef48efe5e5 ("net/bnxt: support set MTU")
Cc: sta...@dpdk.org
Signed-off-by: Ajit Khaparde
Signed-off-by: Scott Branden
Reviewed-by: Michael Wildt
Review
> -Original Message-
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Monday, April 30, 2018 6:05 PM
> To: Nipun Gupta
> Cc: dev@dpdk.org; Shreyansh Jain ; Hemant
> Agrawal
> Subject: Re: [dpdk-dev] [PATCH 5/8 v4] raw/dpaa2_qdma: introduce the
> DPAA2 QDMA driver
>
> 24/04/
> -Original Message-
> From: Nipun Gupta
> Sent: Tuesday, May 1, 2018 11:44 AM
> To: 'Thomas Monjalon'
> Cc: dev@dpdk.org; Shreyansh Jain ; Hemant
> Agrawal
> Subject: RE: [dpdk-dev] [PATCH 5/8 v4] raw/dpaa2_qdma: introduce the
> DPAA2 QDMA driver
>
>
>
> > -Original Message-
73 matches
Mail list logo
