On Sun, Apr 29, 2018 at 09:03:07PM +0300, Shahaf Shuler wrote:
> According to ethtool_link_setting API recommendation ETHTOOL_GLINKSETTINGS
> should be called before ETHTOOL_GSET as the later one deprecated.
> 
> Fixes: f47ba80080ab ("net/mlx5: remove kernel version check")
> Cc: nelio.laranje...@6wind.com
> 
> Signed-off-by: Shahaf Shuler <shah...@mellanox.com>

Acked-by: Nelio Laranjeiro <nelio.laranje...@6wind.com>

> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
> index 746b94f734..588d4ba627 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -697,9 +697,9 @@ mlx5_link_update(struct rte_eth_dev *dev, int 
> wait_to_complete)
>       time_t start_time = time(NULL);
>  
>       do {
> -             ret = mlx5_link_update_unlocked_gset(dev, &dev_link);
> +             ret = mlx5_link_update_unlocked_gs(dev, &dev_link);
>               if (ret)
> -                     ret = mlx5_link_update_unlocked_gs(dev, &dev_link);
> +                     ret = mlx5_link_update_unlocked_gset(dev, &dev_link);
>               if (ret == 0)
>                       break;
>               /* Handle wait to complete situation. */
> -- 
> 2.12.0
> 

-- 
Nélio Laranjeiro
6WIND

Reply via email to