[dpdk-dev] [PATCH 4/5] net/nfl: add newline in PMD_RX/TX_LOG macros

2018-04-25 Thread Stephen Hemminger
Be consistent with usage in other drivers. No need for snowflake drivers. Signed-off-by: Stephen Hemminger --- drivers/net/nfp/nfp_net.c | 30 +++--- drivers/net/nfp/nfp_net_logs.h | 4 ++-- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/ne

Re: [dpdk-dev] [PATCH] drivers: cleanup unnecessary global variables

2018-04-25 Thread Pavan Nikhilesh
On Mon, Apr 23, 2018 at 11:00:09AM +0200, Olivier Matz wrote: > On Fri, Apr 20, 2018 at 12:21:59AM +0530, Pavan Nikhilesh wrote: > > Signed-off-by: Pavan Nikhilesh > > --- > > drivers/bus/dpaa/base/fman/netcfg_layer.c | 5 - > > drivers/bus/dpaa/base/qbman/bman_driver.c | 4 ++-- > >

[dpdk-dev] [PATCH next 00/10] more dynamic logging

2018-04-25 Thread Stephen Hemminger
This set of patches converts more virtual drivers to use the dynamic log type, rather than PMD log type. Marking these for next since there is no urgency to get these into 18.05 and they are compile tested only. Stephen Hemminger (10): net/tap: convert to dynamic logging net/af_packet: conver

[dpdk-dev] [PATCH next 01/10] net/tap: convert to dynamic logging

2018-04-25 Thread Stephen Hemminger
Use new logging macro to convert all calls to RTE_LOG() into new dynamic log type. Also fix whitespace. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 168 ++ drivers/net/tap/rte_eth_tap.h | 1 + drivers/net/tap/tap_flow.c| 51 +--

[dpdk-dev] [PATCH next 02/10] net/af_packet: convert to dynamic log level

2018-04-25 Thread Stephen Hemminger
Convert this driver to use dynamic log level support. Signed-off-by: Stephen Hemminger --- drivers/net/af_packet/rte_eth_af_packet.c | 132 -- 1 file changed, 73 insertions(+), 59 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rt

[dpdk-dev] [PATCH next 03/10] net/null: convert to dynamic logging

2018-04-25 Thread Stephen Hemminger
Convert null device to use dynamic logging. Signed-off-by: Stephen Hemminger --- drivers/net/null/rte_eth_null.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 6413a9064245..

[dpdk-dev] [PATCH next 04/10] net/ring: convert to dynamic logging

2018-04-25 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/ring/rte_eth_ring.c | 46 ++--- 1 file changed, 31 insertions(+), 15 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index e53823adb3e5..0581ab216cd4 100644 --- a/drivers/net/

[dpdk-dev] [PATCH next 05/10] net/softnic: convert to dynamic logging

2018-04-25 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/softnic/rte_eth_softnic.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c index e3243940cba7..9835124ad9f2 100644 --- a/dr

[dpdk-dev] [PATCH next 06/10] net/failsafe: convert to dynamic logging

2018-04-25 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/failsafe/failsafe.c | 13 - drivers/net/failsafe/failsafe_private.h | 8 ++-- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index dc9b0d088

[dpdk-dev] [PATCH next 07/10] net/kni: support dynamic logging

2018-04-25 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/kni/rte_eth_kni.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index 35a6d3ef7280..bbb2f00c80d7 100644 --- a/drivers/net/kni/r

[dpdk-dev] [PATCH next 09/10] net/vhost: implement dynamic logging

2018-04-25 Thread Stephen Hemminger
Use dynamic log type (instead of PMD) in vhost. Signed-off-by: Stephen Hemminger --- drivers/net/vhost/rte_eth_vhost.c | 82 ++- 1 file changed, 48 insertions(+), 34 deletions(-) diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c inde

[dpdk-dev] [PATCH next 08/10] net/pcap: support dynamic logging

2018-04-25 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/pcap/rte_eth_pcap.c | 41 ++--- 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index 570c9e984d32..4ef28a4995d2 100644 --- a/drivers/net/

[dpdk-dev] [PATCH next 10/10] net/bond: convert to dynamic logging

2018-04-25 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_8023ad.c | 126 + drivers/net/bonding/rte_eth_bond_alb.c | 4 +- drivers/net/bonding/rte_eth_bond_args.c| 5 +- drivers/net/bonding/rte_eth_bond_pmd.c | 303 ++--- drivers/net/bonding/rt

Re: [dpdk-dev] [PATCH v8 00/10] eal: replace calls to rte_panic and refrain from new instances

2018-04-25 Thread Stephen Hemminger
On Wed, 25 Apr 2018 16:45:34 +0300 Arnon Warshavsky wrote: > The purpose of this patch series is to cleanup the library code > from paths that end up aborting the process, > and move to checking error values, in order to allow the running process > perform an orderly teardown or other mitigation

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

2018-04-25 Thread Burakov, Anatoly
On 14-Feb-18 10:07 AM, Burakov, Anatoly wrote: On 14-Feb-18 8:04 AM, Thomas Monjalon wrote: Hi Anatoly, 19/12/2017 12:14, Anatoly Burakov:   * Memory tagging. This is related to previous item. Right now, we can only ask     malloc to allocate memory by page size, but one could potentially hav

Re: [dpdk-dev] [PATCH v6 10/16] ethdev: fix TPID handling in flow API

2018-04-25 Thread Adrien Mazarguil
On Wed, Apr 25, 2018 at 05:27:56PM +0200, Adrien Mazarguil wrote: > TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not > consistent with the normal stacking order of pattern items, which is > confusing to applications. > > Problem is that when followed by one of these layers,

Re: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support

2018-04-25 Thread De Lara Guarch, Pablo
Hi Kamil, > -Original Message- > From: Chalupnik, KamilX > Sent: Wednesday, April 25, 2018 9:43 AM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Cc: Mokhtar, Amr > Subject: RE: [dpdk-dev] [PATCH] app/bbdev: dynamic lib support > > Hi Pablo > > > -Original Message- > > From: De La

Re: [dpdk-dev] [RFC v2 00/23] Dynamic memory allocation for DPDK

2018-04-25 Thread Stephen Hemminger
On Wed, 25 Apr 2018 17:02:48 +0100 "Burakov, Anatoly" wrote: > On 14-Feb-18 10:07 AM, Burakov, Anatoly wrote: > > On 14-Feb-18 8:04 AM, Thomas Monjalon wrote: > >> Hi Anatoly, > >> > >> 19/12/2017 12:14, Anatoly Burakov: > >>>   * Memory tagging. This is related to previous item. Right now, w

Re: [dpdk-dev] [PATCH v6 10/16] ethdev: fix TPID handling in flow API

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 5:10 PM, Adrien Mazarguil wrote: > On Wed, Apr 25, 2018 at 05:27:56PM +0200, Adrien Mazarguil wrote: >> TPID handling in rte_flow VLAN and E_TAG pattern item definitions is not >> consistent with the normal stacking order of pattern items, which is >> confusing to applications. >> >> P

[dpdk-dev] [PATCH v1] net/tap: return empty port offload capabilities

2018-04-25 Thread Ophir Munk
Fix report on port offload capabilities to be 0 (no capabilities). Before this commit port capabilities were a clone of queue capabilities, however the current TAP offload capabilities (e.g. checksum calculation) are per queue and are not specific per port. Fixes: 95ae196ae10b ("net/tap: use new R

Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ophir Munk
Hi Ferruh, Patch https://dpdk.org/dev/patchwork/patch/38957/ was submitted. Can you please review it? Please add Suggest-by with your name. Regards, Ophir > -Original Message- > From: Ophir Munk > Sent: Wednesday, April 25, 2018 3:21 PM > To: 'Ferruh Yigit' ; 'Pascal Mazon' > > Cc: 'dev

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd failure due to RSS offload check

2018-04-25 Thread Adrien Mazarguil
On Wed, Apr 25, 2018 at 09:38:16PM +0800, Qi Zhang wrote: > After add RSS hash offload check, default rss_hf will fail on > devices that not support all bits, the patch take rss_hf as > a suggest value and only set bits that device supported base on > rte_eth_dev_get_info, also rss_hf will only be

[dpdk-dev] Failsafe issue following [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ophir Munk
Hi, I am seeing the same potential issue with failsafe device (drivers/net/failsafe/failsafe_ops.c) where Rx port offloads are a clone of Rx queue offloads. Checking it... Regards, Ophir > -Original Message- > From: Ophir Munk > Sent: Wednesday, April 25, 2018 7:18 PM > To: Ferruh Yigit

Re: [dpdk-dev] [PATCH v1] net/tap: return empty port offload capabilities

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 5:15 PM, Ophir Munk wrote: > Fix report on port offload capabilities to be 0 (no capabilities). > Before this commit port capabilities were a clone of queue > capabilities, however the current TAP offload capabilities (e.g. > checksum calculation) are per queue and are not specific per

[dpdk-dev] [PATCH v3 4/6] mempool/bucket: implement block dequeue operation

2018-04-25 Thread Andrew Rybchenko
From: "Artem V. Andreev" Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- drivers/mempool/bucket/rte_mempool_bucket.c | 52 + 1 file changed, 52 insertions(+) diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c b/drivers/mempool/bucket/rte_

[dpdk-dev] [PATCH v3 0/6] mempool: add bucket driver

2018-04-25 Thread Andrew Rybchenko
The initial patch series [1] (RFCv1 is [2]) is split into two to simplify processing. It is the second part which relies on the first one [3] which is already applied. The patch series adds bucket mempool driver which allows to allocate (both physically and virtually) contiguous blocks of objects

[dpdk-dev] [PATCH v3 3/6] mempool: support block dequeue operation

2018-04-25 Thread Andrew Rybchenko
From: "Artem V. Andreev" If mempool manager supports object blocks (physically and virtual contiguous set of objects), it is sufficient to get the first object only and the function allows to avoid filling in of information about each block member. Signed-off-by: Artem V. Andreev Signed-off-by:

[dpdk-dev] [PATCH v3 6/6] doc: advertise bucket mempool driver

2018-04-25 Thread Andrew Rybchenko
Signed-off-by: Andrew Rybchenko --- doc/guides/rel_notes/release_18_05.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_18_05.rst b/doc/guides/rel_notes/release_18_05.rst index 222cc77cf..61dca6726 100644 --- a/doc/guides/rel_notes/re

[dpdk-dev] [PATCH v3 2/6] mempool: implement abstract mempool info API

2018-04-25 Thread Andrew Rybchenko
From: "Artem V. Andreev" Primarily, it is intended as a way for the mempool driver to provide additional information on how it lays up objects inside the mempool. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko Acked-by: Olivier Matz --- lib/librte_mempool/rte_mempool.h

[dpdk-dev] [PATCH v3 5/6] mempool/bucket: do not allow one lcore to grab all buckets

2018-04-25 Thread Andrew Rybchenko
From: "Artem V. Andreev" Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- drivers/mempool/bucket/rte_mempool_bucket.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/mempool/bucket/rte_mempool_bucket.c b/drivers/mempool/bucket/rte_mempool_bucket.c

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd failure due to RSS offload check

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 5:27 PM, Adrien Mazarguil wrote: > On Wed, Apr 25, 2018 at 09:38:16PM +0800, Qi Zhang wrote: >> After add RSS hash offload check, default rss_hf will fail on >> devices that not support all bits, the patch take rss_hf as >> a suggest value and only set bits that device supported base

[dpdk-dev] [PATCH v3 1/6] mempool/bucket: implement bucket mempool manager

2018-04-25 Thread Andrew Rybchenko
From: "Artem V. Andreev" The manager provides a way to allocate physically and virtually contiguous set of objects. Signed-off-by: Artem V. Andreev Signed-off-by: Andrew Rybchenko --- MAINTAINERS| 9 + config/common_base

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 01:16:38PM +, Ananyev, Konstantin wrote: > > > > > > On Mon, Apr 23, 2018 at 11:53:04AM +, Ananyev, Konstantin wrote: > > [...] > > > > @@ -693,9 +711,14 @@ rte_mbuf_to_baddr(struct rte_mbuf *md) > > > > #define RTE_MBUF_INDIRECT(mb) ((mb)->ol_flags & IND_ATTAC

[dpdk-dev] [RFC] net/mvpp2: implement dynamic logging

2018-04-25 Thread Stephen Hemminger
All DPDK drivers should use dynamic log types, not the default PMD value. This is an RFC not a patch since I don't have libraries are hardware to validate it. Signed-off-by: Stephen Hemminger --- drivers/net/mvpp2/mrvl_ethdev.c | 135 +--- drivers/net/mvpp2/mrvl_ethd

Re: [dpdk-dev] Survey for final decision about per-port offload API

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 2:32 PM, Ferruh Yigit wrote: >>> There are two cases of disable: >>> 1- Disabling a "queue level offload" enabled queue_setup() previously >>> 2- Disabling a "queue level offload" enabled in configure() >>> >>> If second is not supported, to disable the offload, applications should >>>

Re: [dpdk-dev] [PATCH v1] net/tap: return empty port offload capabilities

2018-04-25 Thread Thomas Monjalon
25/04/2018 18:15, Ophir Munk: > Fix report on port offload capabilities to be 0 (no capabilities). > Before this commit port capabilities were a clone of queue > capabilities, however the current TAP offload capabilities (e.g. > checksum calculation) are per queue and are not specific per port. I

[dpdk-dev] [PATCH] app/test: fix failure on mempool autotest retry

2018-04-25 Thread Andrew Rybchenko
Single producer / single consumer mempool handle is stored in static variable and the mempool allocated if stored value is NULL. If the mempool is freed, NULL should be restored to make sure that the mempool is allocated once again next time when the test is run. Fixes: 8ef772aee072 ("app/test: re

Re: [dpdk-dev] [PATCH v4] ethdev: check Rx/Tx offloads

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 12:50 PM, Wei Dai wrote: > This patch check if a requested offloading is supported > in the device capability. > Any offloading is disabled by default if it is not set > in rte_eth_dev_configure( ) and rte_eth_[rt]x_queue_setup(). > A per port offloading can only be enabled in > rte_et

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 01:31:42PM +, Ananyev, Konstantin wrote: [...] > > /** Mbuf prefetch */ > > #define RTE_MBUF_PREFETCH_TO_FREE(m) do { \ > > if ((m) != NULL)\ > > @@ -1213,11 +1306,127 @@ static inline int rte_pktmbuf_alloc_bulk(struct > > rte_mempool

Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test

2018-04-25 Thread Thomas Monjalon
Hi, Your patch has been forgotten for months. Do not hesitate to ping if no reply. I have a question below. 06/02/2018 03:21, Phil Yang: > --- a/test/test/test_eal_flags.c > +++ b/test/test/test_eal_flags.c > -#define SOCKET_MEM_STRLEN (RTE_MAX_NUMA_NODES * 10) > +#define SOCKET_MEM_STRLEN (RTE_

Re: [dpdk-dev] [PATCH v1] net/tap: return empty port offload capabilities

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 5:47 PM, Thomas Monjalon wrote: > 25/04/2018 18:15, Ophir Munk: >> Fix report on port offload capabilities to be 0 (no capabilities). >> Before this commit port capabilities were a clone of queue >> capabilities, however the current TAP offload capabilities (e.g. >> checksum calculatio

[dpdk-dev] [PATCH] net/sfc: ignore spec bits not covered by mask

2018-04-25 Thread Andrew Rybchenko
mask is a simple bit-mask applied before interpreting the contents of spec and last. Fixes: a9825ccf5bb8 ("net/sfc: support flow API filters") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Roman Zhukov --- drivers/net/sfc/sfc_flow.c | 6 ++ 1 f

Re: [dpdk-dev] [PATCH v3] net/tap: remove queue specific offload support

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 5:17 PM, Ophir Munk wrote: > Hi Ferruh, > Patch https://dpdk.org/dev/patchwork/patch/38957/ was submitted. Thanks Ophir, Since your patch is out, I am marking this one as rejected. > Can you please review it? > Please add Suggest-by with your name. > > Regards, > Ophir > >> -

Re: [dpdk-dev] how can I get a git version of Latest Major release? (18.02.1)

2018-04-25 Thread Andrii
The problem here is that common dpdk user is not able to find a stable repository from a website. That would be great if dpdk.com/download or dpdk.com/dev would contain a direct link to http://dpdk.org/browse/ for example. On Wed, Apr 25, 2018 at 5:47 PM, Ferruh Yigit wrote: > On 4/25/2018 3:02

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Ananyev, Konstantin
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Wednesday, April 25, 2018 6:07 PM > To: Ananyev, Konstantin > Cc: Lu, Wenzhuo ; Wu, Jingjing ; > olivier.m...@6wind.com; dev@dpdk.org; > arybche...@solarflare.com; step...@networkplumber.org; tho...@monjalon.n

Re: [dpdk-dev] [PATCH v6 00/16] Flow API overhaul for switch offloads

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 4:27 PM, Adrien Mazarguil wrote: > As summarized in a prior RFC [1], the flow API (rte_flow) was chosen as a > means to manage switch offloads supported by many devices (usually going by > names such as E-Switch or vSwitch) through user-specified flow rules. > > Combined with the need

Re: [dpdk-dev] [PATCH v7 1/5] doc: remove RSS configuration change announcement

2018-04-25 Thread Ferruh Yigit
On 4/24/2018 6:07 AM, Xueming(Steven) Li wrote: > Hi Ferruh, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, April 24, 2018 12:13 AM >> To: Xueming(Steven) Li ; Wenzhuo Lu >> ; Jingjing Wu >> ; Thomas Monjalon ; Adrien >> Mazarguil >> >> Cc: Nélio Laranjeiro ; Shahaf Sh

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 05:45:34PM +0300, Andrew Rybchenko wrote: > On 04/25/2018 02:34 AM, Yongseok Koh wrote: > > On Tue, Apr 24, 2018 at 09:15:38PM +0200, Olivier Matz wrote: > > > On Tue, Apr 24, 2018 at 09:21:00PM +0300, Andrew Rybchenko wrote: > > > > On 04/24/2018 07:02 PM, Olivier Matz wrot

Re: [dpdk-dev] [PATCH v2 0/8] net/sfc: RSS improvements

2018-04-25 Thread Andrew Rybchenko
On 04/19/2018 07:41 PM, Andrew Rybchenko wrote: The patch series should be applied on top of [1]. checkpatches.sh warnings are bacause of positive errno used inside the driver. checkpatches.sh checks are OK. [1] https://dpdk.org/ml/archives/dev/2018-April/098047.html Self NACK, fix is require

[dpdk-dev] [PATCH v3 0/8] net/sfc: RSS improvements

2018-04-25 Thread Andrew Rybchenko
The patch series should be applied on top of [1]. checkpatches.sh warnings are bacause of positive errno used inside the driver. checkpatches.sh checks are OK. [1] https://dpdk.org/ml/archives/dev/2018-April/099188.html v2 -> v3: - fix processing of legacy hash type flags in base driver v1 ->

[dpdk-dev] [PATCH v3 1/8] net/sfc/base: cope with clang warning on negative shift

2018-04-25 Thread Andrew Rybchenko
clang 4.0.1-6 on Ubuntu generates false positive warning that shift is negative. It is done regardless of the fact that the branch is not taken because of previous check. The warning is generate in EFX_INSERT_NATIVE32 used by EFX_INSERT_FIELD_NATIVE32. All similar cases are fixed as well. It is

[dpdk-dev] [PATCH v3 3/8] net/sfc/base: support more RSS hash configurations

2018-04-25 Thread Andrew Rybchenko
From: Ivan Malov Modern firmwares on EF10 adapters have support for more traffic classes eligible for hash computation. Also, it has become possible to adjust hashing per individual class and select distinct packet fields which will be able to contribute to the hash value. This patch adds suppor

[dpdk-dev] [PATCH v3 2/8] net/sfc/base: add a new means to control RSS hash

2018-04-25 Thread Andrew Rybchenko
From: Ivan Malov Currently, libefx has no support for additional RSS modes available with later controllers. In order to support this, libefx should be able to list available hash configurations. This patch provides basic infrastructure for the new interface. The client drivers will be able to q

[dpdk-dev] [PATCH v3 5/8] net/sfc: process RSS settings on Rx configure step

2018-04-25 Thread Andrew Rybchenko
From: Ivan Malov One may submit advanced RSS settings as part of rte_eth_conf to customise RSS configuration from the very beginning. Currently the driver does not check that piece of settings and proceeds with default choices for RSS hash functions and RSS key. This patch implements the require

[dpdk-dev] [PATCH v3 4/8] net/sfc/base: honour packed stream RSS restriction

2018-04-25 Thread Andrew Rybchenko
From: Ivan Malov Packed stream firmware variant on EF10 adapters has a number of properties which must be taken into account: - Only one exclusive RSS context is available per port. - Only IP addresses can contribute to the hash value. Huntington and Medford have one more limitation which is

[dpdk-dev] [PATCH v3 8/8] net/sfc: convert to the advanced EFX RSS interface

2018-04-25 Thread Andrew Rybchenko
From: Ivan Malov The current code has the following drawbacks: - It is assumed that TCP 4-tuple hash is always supported, which is untrue in the case of packed stream FW variant. - The driver is unaware of UDP hash support available with latest firmware. In order to cope with the ment

[dpdk-dev] [PATCH v3 6/8] net/sfc: remove conditional compilation for RSS

2018-04-25 Thread Andrew Rybchenko
From: Ivan Malov RSS is one of the most valuable features in the driver, and one would hardly need to disable it at build time. This patch withdraws unnecessary conditionals for RSS snippets. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c| 10 -

[dpdk-dev] [PATCH v3 7/8] net/sfc: factor out RSS fields from adapter info

2018-04-25 Thread Andrew Rybchenko
From: Ivan Malov RSS handling will need more sophisticated fields in the adapter context storage in future patches. This patch groups existing fields in a dedicated structure and updates the rest of the code. Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc.c

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 05:23:20PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Yongseok Koh [mailto:ys...@mellanox.com] > > Sent: Wednesday, April 25, 2018 6:07 PM > > To: Ananyev, Konstantin > > Cc: Lu, Wenzhuo ; Wu, Jingjing > > ; olivier.m...@6wind.com; dev

Re: [dpdk-dev] [PATCH v3 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Ananyev, Konstantin
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Wednesday, April 25, 2018 5:44 PM > To: Ananyev, Konstantin > Cc: Lu, Wenzhuo ; Wu, Jingjing ; > olivier.m...@6wind.com; dev@dpdk.org; > adrien.mazarg...@6wind.com; nelio.laranje...@6wind.com > Subject: Re: [P

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 11:02:36AM -0700, Yongseok Koh wrote: > On Wed, Apr 25, 2018 at 05:23:20PM +, Ananyev, Konstantin wrote: > > > > > > > -Original Message- > > > From: Yongseok Koh [mailto:ys...@mellanox.com] > > > Sent: Wednesday, April 25, 2018 6:07 PM > > > To: Ananyev, Konst

Re: [dpdk-dev] [PATCH v5 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
> On Apr 25, 2018, at 11:22 AM, Yongseok Koh wrote: > > On Wed, Apr 25, 2018 at 11:02:36AM -0700, Yongseok Koh wrote: >> On Wed, Apr 25, 2018 at 05:23:20PM +, Ananyev, Konstantin wrote: >>> >>> -Original Message- From: Yongseok Koh [mailto:ys...@mellanox.com] Sent: W

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Olivier Matz
On Wed, Apr 25, 2018 at 09:19:32AM +, Yongseok Koh wrote: > > On Apr 25, 2018, at 2:08 AM, Yongseok Koh wrote: > >> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote: > >> > >> Hi Yongseok, > >> > >> On Tue, Apr 24, 2018 at 06:02:44PM +0200, Olivier Matz wrote: > > @@ -688,14 +704,33 @@ r

Re: [dpdk-dev] [PATCH v7 0/5] introduce new tunnel types

2018-04-25 Thread Ferruh Yigit
On 4/23/2018 1:16 PM, Xueming Li wrote: > v7: > - Fixed display name of MPLS-in-GRE and MPLS-in-UDP > v6: > - Add MPLS-in-GRE and MPLS-in-UDP back > - UPdate comment alignment > v5: > - Fixed VXLAN-GPE comment alignment > - Removed MPLS-in-GRE and MPLS-in-UDP patch > v4: > - Update testpmd doc for

Re: [dpdk-dev] [PATCH v3 6/6] doc: advertise bucket mempool driver

2018-04-25 Thread Thomas Monjalon
Usually it is better to update the release notes in the main patch implementing the feature (probably the first one in this case). You can also update it step by step in several patches. 25/04/2018 18:32, Andrew Rybchenko: > --- a/doc/guides/rel_notes/release_18_05.rst > +++ b/doc/guides/rel_notes

Re: [dpdk-dev] [PATCH v3 6/6] doc: advertise bucket mempool driver

2018-04-25 Thread Thomas Monjalon
25/04/2018 23:56, Thomas Monjalon: > Usually it is better to update the release notes in the main patch > implementing the feature (probably the first one in this case). > You can also update it step by step in several patches. > > 25/04/2018 18:32, Andrew Rybchenko: > > --- a/doc/guides/rel_notes

Re: [dpdk-dev] [PATCH v5 0/4] ethdev additions to support tunnel encap/decap

2018-04-25 Thread Ferruh Yigit
On 4/23/2018 4:56 PM, Declan Doherty wrote: > This patchset contains the revised proposal to manage > tunnel endpoints hardware accleration based on community > feedback on RFC > (http://dpdk.org/ml/archives/dev/2017-December/084676.html). This > > proposal is purely enabled through rte_flow APIs

Re: [dpdk-dev] [PATCH v5 0/3] rte_flow extension for vSwitch acceleration

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 2:54 PM, Zhang, Qi Z wrote: >> -Original Message- >> From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] >> Sent: Tuesday, April 24, 2018 11:59 PM >> To: Yigit, Ferruh ; Zhang, Qi Z >> >> Cc: dev@dpdk.org; Doherty, Declan ; Chandran, >> Sugesh ; Glynn, Michael J >> ; L

Re: [dpdk-dev] [PATCH v4 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
On Wed, Apr 25, 2018 at 10:00:10PM +0200, Olivier Matz wrote: > On Wed, Apr 25, 2018 at 09:19:32AM +, Yongseok Koh wrote: > > > On Apr 25, 2018, at 2:08 AM, Yongseok Koh wrote: > > >> On Apr 25, 2018, at 1:28 AM, Olivier Matz wrote: > > >> > > >> Hi Yongseok, > > >> > > >> On Tue, Apr 24, 2

[dpdk-dev] [PATCH 18.05-rc2] dpaa2: do not log messages if bus not present

2018-04-25 Thread Stephen Hemminger
A typical distribution will compile with default config and all buses enabled. Therefore every driver should be silent and not log anything for this normal case. This patch gets rid of these messages when running on basic x86 environment such as bare metal or VM. fslmc: DPAA2: DPRC not available

[dpdk-dev] [PATCH v2] dpaa2: do not log messages if bus not present

2018-04-25 Thread Stephen Hemminger
A typical distribution will compile with default config and all buses enabled. Therefore every driver should be silent and not log anything for this normal case. This patch gets rid of these messages when running on basic x86 environment such as bare metal or VM. fslmc: DPAA2: DPRC not available

Re: [dpdk-dev] [PATCH v3 0/8] net/sfc: RSS improvements

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 6:51 PM, Andrew Rybchenko wrote: > The patch series should be applied on top of [1]. > > checkpatches.sh warnings are bacause of positive errno used inside > the driver. checkpatches.sh checks are OK. > > [1] https://dpdk.org/ml/archives/dev/2018-April/099188.html > > v2 -> v3: > -

Re: [dpdk-dev] [PATCH v3] app/testpmd: fix testpmd failure due to RSS offload check

2018-04-25 Thread Ferruh Yigit
On 4/25/2018 5:27 PM, Adrien Mazarguil wrote: > On Wed, Apr 25, 2018 at 09:38:16PM +0800, Qi Zhang wrote: >> After add RSS hash offload check, default rss_hf will fail on >> devices that not support all bits, the patch take rss_hf as >> a suggest value and only set bits that device supported base

Re: [dpdk-dev] [PATCH] app/testpmd: update start log to be less verbose

2018-04-25 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 25, 2018 10:15 PM > To: Lu, Wenzhuo ; Wu, Jingjing > > Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Qi Z > > Subject: [PATCH] app/testpmd: update start log to be less verbose > > A per port per queue log is too verbose wit

Re: [dpdk-dev] [PATCH] app/pdump: remove unused socket path options

2018-04-25 Thread Tan, Jianfeng
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, April 25, 2018 9:04 PM > To: dev@dpdk.org > Cc: Burakov, Anatoly; Pattan, Reshma; Tan, Jianfeng > Subject: [PATCH] app/pdump: remove unused socket path options > > The options --server-socket-pat

[dpdk-dev] [PATCH] eal: shut up warning about master lcore

2018-04-25 Thread Stephen Hemminger
This message looks suspicious and seen on healthy testpmd. EAL: WARNING: Master core has no memory on local socket! The message is wrong: the master lcore is 0 and its socket is 0 and there are multiple available memory segments on socket 0. At that point in the startup process, the count value

[dpdk-dev] [PATCH v6 1/2] mbuf: support attaching external buffer to mbuf

2018-04-25 Thread Yongseok Koh
This patch introduces a new way of attaching an external buffer to a mbuf. Attaching an external buffer is quite similar to mbuf indirection in replacing buffer addresses and length of a mbuf, but a few differences: - When an indirect mbuf is attached, refcnt of the direct mbuf would be 2 as

[dpdk-dev] [PATCH v6 2/2] app/testpmd: conserve offload flags of mbuf

2018-04-25 Thread Yongseok Koh
This patch is to accommodate an experimental feature of mbuf - external buffer attachment. If mbuf is attached to an external buffer, its ol_flags will have EXT_ATTACHED_MBUF set. Without enabling/using the feature, everything remains same. If PMD delivers Rx packets with non-direct mbuf, ol_flags

Re: [dpdk-dev] [PATCH] test/eal_flags: Optimize memory flags test

2018-04-25 Thread Phil Yang
Hi Thomas, That change just want to make sure below two buffers have enough space when configure RTE_MAX_NUMA_NODES=1. /* construct an invalid socket mask with 2 megs on each socket plus * extra 2 megs on socket that doesn't exist on current system */ char invalid_socket_mem[SOCKET_MEM_STRLEN]

Re: [dpdk-dev] [v2,4/6] test: add event crypto adapter auto-test

2018-04-25 Thread Gujjar, Abhinandan S
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, April 25, 2018 8:10 PM > To: Gujjar, Abhinandan S ; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > akhil.go...@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > ; Eads, Gage

Re: [dpdk-dev] [PATCH] vhost: fix vDPA set features

2018-04-25 Thread Wang, Zhihong
> -Original Message- > From: Wang, Xiao W > Sent: Wednesday, April 25, 2018 10:18 AM > To: maxime.coque...@redhat.com > Cc: Tan, Jianfeng ; Wang, Zhihong > ; dev@dpdk.org; Wang, Xiao W > > Subject: [PATCH] vhost: fix vDPA set features > > We should call set_features callback after setti

Re: [dpdk-dev] [v2,1/6] eventdev: introduce event crypto adapter

2018-04-25 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, April 25, 2018 6:12 PM > To: Gujjar, Abhinandan S ; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > akhil.go...@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > ; Ead

Re: [dpdk-dev] [v2, 3/6] eventdev: add crypto adapter implementation

2018-04-25 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, April 25, 2018 7:44 PM > To: Gujjar, Abhinandan S ; > jerin.ja...@caviumnetworks.com; hemant.agra...@nxp.com; > akhil.go...@nxp.com; dev@dpdk.org > Cc: Vangati, Narender ; Rao, Nikhil > ; Ead

[dpdk-dev] [PATCH v9 01/10] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver

2018-04-25 Thread Arnon Warshavsky
replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky Acked-by: Akhil Goyal --- drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +--- drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ++ 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/driver

[dpdk-dev] [PATCH v9 02/10] bond: replace rte_panic instances in bonding driver

2018-04-25 Thread Arnon Warshavsky
Replace panic calls with log and return value. Local functions to this file, changing from void to int are non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++- drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +

[dpdk-dev] [PATCH v9 03/10] e1000: replace rte_panic instances in e1000 driver

2018-04-25 Thread Arnon Warshavsky
replace panic calls with log and return value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/net/e1000/e1000_ethdev.h | 2 +- drivers/net/e1000/igb_ethdev.c | 4 +++- drivers/net/e1000/igb_pf.c | 15 +-

[dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances

2018-04-25 Thread Arnon Warshavsky
The purpose of this patch series is to cleanup the library code from paths that end up aborting the process, and move to checking error values, in order to allow the running process perform an orderly teardown or other mitigation of the event. This patch modifies the majority of rte_panic calls un

[dpdk-dev] [PATCH v9 04/10] ixgbe: replace rte_panic instances in ixgbe driver

2018-04-25 Thread Arnon Warshavsky
replace panic calls with log and return value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 -- drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- drivers/net/ixgbe/ixgbe_pf.c | 15 ++--

[dpdk-dev] [PATCH v9 06/10] kni: replace rte_panic instances in kni

2018-04-25 Thread Arnon Warshavsky
replace panic calls with log and return value. Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_kni/rte_kni.c | 18 -- lib/librte_kni/rte_kni_fifo.h | 11 --- 2 files changed, 20 insertions(+),

[dpdk-dev] [PATCH v9 07/10] eal: replace rte_panic instances in hugepage_info

2018-04-25 Thread Arnon Warshavsky
replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky Acked-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 37 + 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_i

[dpdk-dev] [PATCH v9 05/10] eal: replace rte_panic instances in eventdev

2018-04-25 Thread Arnon Warshavsky
replace panic calls with log and return value. Signed-off-by: Arnon Warshavsky --- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +--- lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev_

[dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-25 Thread Arnon Warshavsky
Change some local functions return type from void to int. This change does not break ABI as the functions are internal. Panic thrown from threads was not handled in this patch Signed-off-by: Arnon Warshavsky Acked-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal.c | 71 +

[dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev

2018-04-25 Thread Arnon Warshavsky
Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_ether/rte_ethdev.c | 42 ++ lib/librte_ether/rte_ethdev.h | 4 +++- 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/

Re: [dpdk-dev] [PATCH v6 00/11] mlx5 Rx tunnel offloading

2018-04-25 Thread Shahaf Shuler
Tuesday, April 24, 2018 11:25 AM, Nélio Laranjeiro: > Subject: Re: [PATCH v6 00/11] mlx5 Rx tunnel offloading > > On Mon, Apr 23, 2018 at 08:32:59PM +0800, Xueming Li wrote: > > > > Important note: > > please note that this patchset relies on Adrien's patchset of flow > > API > >

[dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit

2018-04-25 Thread Arnon Warshavsky
This patch adds a new function that is called per every checked patch, and alerts for new instances of rte_panic/rte_exit. The check excludes comments, and alerts in the case of a positive balance between additions and removals. Signed-off-by: Arnon Warshavsky --- devtools/checkpatches.sh | 95 +

Re: [dpdk-dev] [PATCH 1/8 v4] raw: support meson build

2018-04-25 Thread Shreyansh Jain
On Tuesday 24 April 2018 05:19 PM, Nipun Gupta wrote: Signed-off-by: Shreyansh Jain Signed-off-by: Nipun Gupta --- drivers/meson.build | 3 ++- drivers/raw/meson.build | 7 +++ drivers/raw/skeleton_rawdev/meson.build | 8 3 files changed, 17

<    1   2   3