On 4/25/2018 2:32 PM, Ferruh Yigit wrote:
>>> There are two cases of disable:
>>> 1- Disabling a "queue level offload" enabled queue_setup() previously
>>> 2- Disabling a "queue level offload" enabled in configure()
>>>
>>> If second is not supported, to disable the offload, applications should
>>> stop->re-configure()->re-queue_setup()->start the port. But having this
>>> capability makes the offloading parameters more confusing for applications.
>> I don't understand the last sentence.
>>
>>> I suggest adding disable support to fist one but not second one.
>> Yes, it is the item 3 of the survey.
> Yes indeed.
Just to confirm, as far as I can see 2) is supported by Mlx PMD, at least the
verify function doesn't return error for this case [1], which won't be supported
anymore.
Can we get a confirmation from mlx PMD developers that this is OK?
[1]
static int
mlx5_is_rx_queue_offloads_allowed(struct rte_eth_dev *dev, uint64_t offloads)
{
uint64_t port_offloads = dev->data->dev_conf.rxmode.offloads;
uint64_t queue_supp_offloads = mlx5_get_rx_queue_offloads(dev);
uint64_t port_supp_offloads = mlx5_get_rx_port_offloads();
if ((offloads & (queue_supp_offloads | port_supp_offloads)) !=
offloads)
return 0;
if (((port_offloads ^ offloads) & port_supp_offloads))
return 0;
return 1;
}
