Re: [dpdk-dev] [PATCH] net/mlx5: fix link state on device start

2018-01-24 Thread Nélio Laranjeiro
Hi Shahaf, On Tue, Jan 23, 2018 at 07:01:06PM +0200, Shahaf Shuler wrote: > Following commit c7bf62255edf ("net/mlx5: fix handling link status event") > the link state must be up in order for the burst function to be set on > the device ops. > > As the link may take time to move between down and

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-24 Thread Thomas Monjalon
23/01/2018 22:18, Ananyev, Konstantin: > > > > 23/01/2018 16:18, Ananyev, Konstantin: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 23/01/2018 14:34, Ananyev, Konstantin: > > > > > > If that' s th

[dpdk-dev] [PATCH v2 0/4] fix VF RX queue interrupt enabling

2018-01-24 Thread Wenzhuo Lu
If multiple interrupt not supported, the driver should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the polling mode. v2: - AVF acts as not configured RX queue interrupt if not allowed. Wenzhuo Lu (4): net/i40e: fix VF RX queue

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: fix secondary process mempool registration

2018-01-24 Thread Nélio Laranjeiro
Hi Shahaf, On Tue, Jan 23, 2018 at 07:08:20PM +0200, Shahaf Shuler wrote: > Secondary process is not allowed to register mempools on the flight. > > The code will return invalid memory key for such case. > > Fixes: 87ec44ce1651 ("net/mlx5: add operations for secondary process") > Cc: sta...@dpdk

[dpdk-dev] [PATCH v2 3/4] net/e1000: fix VF RX queue interrupt enabling

2018-01-24 Thread Wenzhuo Lu
When using UIO, after enabling the interrupt to get the PF message, VF RX queue interrupt is not working. It's expected, as UIO doesn't support multiple interrupt. So, PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the pollin

[dpdk-dev] [PATCH v2 2/4] net/ixgbe: fix VF RX queue interrupt enabling

2018-01-24 Thread Wenzhuo Lu
When using UIO, after enabling the interrupt to get the PF message, VF RX queue interrupt is not working. It's expected, as UIO doesn't support multiple interrupt. So, PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the pollin

[dpdk-dev] [PATCH v2 4/4] net/avf: fix VF RX queue interrupt enabling

2018-01-24 Thread Wenzhuo Lu
As UIO doesn't support multiple interrupt, and the interrupt is occupied by the control plane. PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the polling mode. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Signed-off-

[dpdk-dev] [PATCH v2 1/4] net/i40e: fix VF RX queue interrupt enabling

2018-01-24 Thread Wenzhuo Lu
When using UIO, after enabling the interrupt to get the PF message, VF RX queue interrupt is not working. It's expected, as UIO doesn't support multiple interrupt. So, PMD should not try to enable RX queue interrupt. Then APP can know the RX queue interrupt is not enabled and only choose the pollin

Re: [dpdk-dev] [PATCH v3 3/3] doc: convert license headers to SPDX tags

2018-01-24 Thread Thomas Monjalon
24/01/2018 06:48, Hemant Agrawal: > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 23/01/2018 16:19, Hemant Agrawal: > > > > > > > -Original Message- > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > > > 23/01/2018 14:08, Hemant

Re: [dpdk-dev] [PATCH 3/5] net/mlx5: assert for un-successful memory registration

2018-01-24 Thread Nélio Laranjeiro
Hi Shahaf, On Tue, Jan 23, 2018 at 07:08:21PM +0200, Shahaf Shuler wrote: > Memory registration can fail, add the proper assert for such scenario > for it at least to be visible in debug mode. > > Signed-off-by: Shahaf Shuler > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5_rxtx.h | 4

Re: [dpdk-dev] [PATCH] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Ori Kam
Hi Beilei, PSB > -Original Message- > From: Beilei Xing [mailto:beilei.x...@intel.com] > Sent: Wednesday, January 24, 2018 9:53 AM > To: Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH] examples/flow_filtering: add delay during updating link > status > > Add up to 9s delay for getting link

Re: [dpdk-dev] [PATCH] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Xing, Beilei
> -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Wednesday, January 24, 2018 4:17 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH] examples/flow_filtering: add delay during updating link > status > > Hi Beilei, > > PSB > > > -Original Message

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 07:43, Yuanhan Liu: > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > 23/01/2018 13:46, Yuanhan Liu: > > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > > > > On Thu, Jan 18, 2018 at 09:46:29AM +0100, Thomas Monjalon wrote: > > > > > 18/01/2018 08:3

[dpdk-dev] [PATCH v2] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Beilei Xing
Add up to 9s delay for getting link status to make sure NIC updates link status successfully, just like other applications such as testpmd and l2fwd. Signed-off-by: Beilei Xing --- v2 changes: - Add rte_delay_ms(CHECK_INTERVAL) which is missed in v1. examples/flow_filtering/main.c | 13 ++

Re: [dpdk-dev] [PATCH v3 1/3] net/i40e: add null point check and fix mem leak

2018-01-24 Thread Zhang, Helin
Hi Yong Thank you so much for your contribution! I have comments in general. 1. for a patch set, you need a cover letter for the series. 2. If a patch is to fix a bug/issue, the title should start with 'fix'. 3. A 'Fixes:' line is needed for any bug fixes. 4. A 'Cc:' line is needed, if the patch s

Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Ori Kam
Hi > -Original Message- > From: Beilei Xing [mailto:beilei.x...@intel.com] > Sent: Wednesday, January 24, 2018 10:35 AM > To: Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH v2] examples/flow_filtering: add delay during updating link > status > > Add up to 9s delay for getting link status

Re: [dpdk-dev] [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-01-24 Thread De Lara Guarch, Pablo
Hi Ravi, > -Original Message- > From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] > Sent: Wednesday, January 17, 2018 9:09 AM > To: De Lara Guarch, Pablo ; > dev@dpdk.org > Cc: Shippen, Greg > Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD > > >Hi Ravi, > > > >> -Or

Re: [dpdk-dev] Dynamic Logging Name Formatting

2018-01-24 Thread Olivier Matz
On Wed, Jan 24, 2018 at 09:32:33AM +0300, Andrew Rybchenko wrote: > On 01/23/2018 11:54 PM, Bruce Richardson wrote: > > On Tue, Jan 23, 2018 at 05:45:09PM +, Ferruh Yigit wrote: > > > On 1/23/2018 5:31 PM, Van Haaren, Harry wrote: > > > > === Suggested Consistent Schema === > > > >

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > 24/01/2018 07:43, Yuanhan Liu: > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > 23/01/2018 13:46, Yuanhan Liu: > > > > On Thu, Jan 18, 2018 at 10:46:23AM +0100, Gaëtan Rivet wrote: > > > > > On Thu, Jan 18,

[dpdk-dev] 答复: RE: [PATCH v3 1/3] net/i40e: add null point check andfix mem leak

2018-01-24 Thread wang.yong19
Hi Helin Thanks for your advice. However, it's hard to find the original patches which introduced the bug in general, especailly when the file name has changed. This may prevent us to contribute to dpdk. < 4. A 'Cc:' line is needed, if the patch should be back ported into any stable release versi

[dpdk-dev] [PATCH] app/eventdev: fix port dequeue depth configuration

2018-01-24 Thread Pavan Nikhilesh
The port dequeue depth value has to be compared against the maximum allowed dequeue depth reported by the event drivers. Fixes: 3617aae53f92 ("app/eventdev: add event Rx adapter setup") Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/test_perf_atq.c | 13 - app/test-event

Re: [dpdk-dev] Dynamic Logging Name Formatting

2018-01-24 Thread Van Haaren, Harry
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, January 24, 2018 9:28 AM > To: Andrew Rybchenko > Cc: Richardson, Bruce ; Yigit, Ferruh > ; Van Haaren, Harry ; > dev@dpdk.org; Ma, Liang J ; Mccarthy, Peter > ; santosh.shu...@caviumnetworks.com; > jerin.ja...@caviumnetworks.

Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Xing, Beilei
> -Original Message- > From: Ori Kam [mailto:or...@mellanox.com] > Sent: Wednesday, January 24, 2018 4:56 PM > To: Xing, Beilei > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] examples/flow_filtering: add delay during updating > link status > > Hi > > > > -Original Message- > > F

[dpdk-dev] [PATCH v3] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Beilei Xing
Add up to 9s delay for getting link status to make sure NIC updates link status successfully, just like other applications such as testpmd and l2fwd. Signed-off-by: Beilei Xing --- v3 changes: - Modify MAX_REPEAT_TIME with MAX_REPEAT_TIMES v2 changes: - Add rte_delay_ms(CHECK_INTERVAL) which is

[dpdk-dev] [PATCH] net/failsafe: fix Rx burst infinite loop

2018-01-24 Thread Matan Azrad
In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst function for packet receiving. This function iterates over the present sub-devices until it receives a traffic from one of them or they are all cannot receive packets. The corrupted code didn't advance the sub-device pointer

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 10:28, Yuanhan Liu: > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > 24/01/2018 07:43, Yuanhan Liu: > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > > 23/01/2018 13:46, Yuanhan Liu: > > > > > If port not found, then the whole string will

[dpdk-dev] [PATCH] usertools/devbind: fix kernel module reporting

2018-01-24 Thread Anatoly Burakov
lspci reports kernel modules in "Module" string, but devbind expects it to be "Module_str". Fix it up similar to how we fix up "Driver" to be "Driver_str". Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: devbind status before changes: Other Network devices ===

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-24 Thread Burakov, Anatoly
On 23-Jan-18 5:25 PM, Ravi Kerur wrote: Hi, I am running into an issue when DPDK is started with iommu on via GRUB command. Problem is not seen with regular kernel driver, error messages show when DPDK is started and happens for both PF and VF interfaces. I am using DPDK 17.05 so the patch prop

Re: [dpdk-dev] [PATCH] net/failsafe: fix Rx burst infinite loop

2018-01-24 Thread Gaëtan Rivet
On Wed, Jan 24, 2018 at 10:19:17AM +, Matan Azrad wrote: > In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst > function for packet receiving. > > This function iterates over the present sub-devices until it > receives a traffic from one of them or they are all cannot rece

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > 24/01/2018 10:28, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 07:43, Yuanhan Liu: > > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thomas Monjalon wrote: > > > > > 23/01/2018 1

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 11:36, Yuanhan Liu: > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > > 24/01/2018 10:28, Yuanhan Liu: > > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > > 24/01/2018 07:43, Yuanhan Liu: > > > > > On Tue, Jan 23, 2018 at 03:29:34PM +0100, Thom

Re: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions

2018-01-24 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ophir Munk > Sent: Tuesday, January 23, 2018 9:54 PM > To: dev@dpdk.org; Pascal Mazon > Cc: Thomas Monjalon ; Olga Shern ; > Ophir Munk > Subject: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions > > eBPF has a graceful approach: it

[dpdk-dev] [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic

2018-01-24 Thread Ophir Munk
In order to guarantee a successful vdev_netvsc compilation on old Linux distributions remove CFLAGS -std=c11 and -pedantic Otherwise old GCC compilers may complain as follows: cc1: error: unrecognized command line option -std=c11 Signed-off-by: Ophir Munk --- drivers/net/vdev_netvsc/Makefile | 2

[dpdk-dev] [pull-request] dpdk-next-build 18.02-rc2

2018-01-24 Thread Bruce Richardson
Hi Thomas, the new build system for DPDK using meson and ninja is now ready for merge as EXPERIMENTAL into the 18.02 release. Regards, /Bruce The following changes since commit bf375b4d51170cd58ca50c646781cb6de17766ea: version: 18.02-rc1 (2018-01-22 01:59:14 +0100) are available in the Git r

Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add delay during updating link status

2018-01-24 Thread Ori Kam
> -Original Message- > From: Beilei Xing [mailto:beilei.x...@intel.com] > Sent: Wednesday, January 24, 2018 12:16 PM > To: Ori Kam > Cc: dev@dpdk.org > Subject: [PATCH v3] examples/flow_filtering: add delay during updating link > status > > Add up to 9s delay for getting link status to

[dpdk-dev] [PATCH] app/testpmd: move variables definition in source

2018-01-24 Thread Georgios P. Katsikas
From: Georgios Katsikas This patch moves the definition of 3 variables in testpmd.h into the respective .c file. The idea behind this move is to allow external applications to compile against testpmd without throwing compilation errors related to multiple definition of variables. Also, an extern

Re: [dpdk-dev] [PATCH v2] keepalive: fix keepalive state alignment

2018-01-24 Thread Remy Horton
Done quick smoke test and it all seems fine :) On 23/01/2018 15:43, Andriy Berestovskyy wrote: [..] Fixes: e70a61ad50ab ("keepalive: export states") Cc: remy.hor...@intel.com Signed-off-by: Andriy Berestovskyy Acked-by: Remy Horton

Re: [dpdk-dev] [PATCH 1/3] app/testpmd: Moved cmdline_flow to librte_cmdline

2018-01-24 Thread george . dit
Hi again, I decided to simplify things for now, hence sent a new minimal patch only for testpmd (not librte_cmdline), which allows external applications to compile against it without errors. Thanks again for you time, Georgios On Tue, Jan 16, 2018 at 6:54 PM, Adrien Mazarguil wrote: > On Tue, J

[dpdk-dev] [PATCH v1] doc: fix bbdev test guide build

2018-01-24 Thread Marko Kovacevic
Some indentations in the bbdev test application were causing build failures. Which are solved by this commit. Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: amr.mokh...@intel.com Signed-off-by: Marko Kovacevic --- doc/guides/tools/testbbdev.rst | 18 ++

[dpdk-dev] [PATCH] eal/service: add routine to release memory.

2018-01-24 Thread Vipin Varghese
The routine rte_service_finalize cehcks if service is initialized, if yes releases the internal meory for services and lcore states. This routine is to be invoked at end of application termiantion. Signed-off-by: Vipin Varghese --- lib/librte_eal/common/include/rte_service.h | 12

Re: [dpdk-dev] [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic

2018-01-24 Thread Matan Azrad
Hi Ophir From: Ophir Munk, Wednesday, January 24, 2018 1:20 PM > In order to guarantee a successful vdev_netvsc compilation on old Linux > distributions remove CFLAGS -std=c11 and -pedantic Otherwise old GCC > compilers may complain as follows: > cc1: error: unrecognized command line option -std=c

[dpdk-dev] [PATCH] usertools/devbind: remove unused code

2018-01-24 Thread Anatoly Burakov
Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 33 - 1 file changed, 33 deletions(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index 894b519..955e984 100755 --- a/usertools/dpdk-devbind.py +++ b/usertoo

[dpdk-dev] [PATCH v2] net/bonding: check dequeue result before proceeding

2018-01-24 Thread Radu Nicolau
Fixes: 09150784a776 ("net/bonding: burst mode hash calculation") Coverity issue: 257015 Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v2: updated commit message drivers/net/bonding/rte_eth_bond_pmd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [dpdk-dev] [PATCH] eal/service: add routine to release memory.

2018-01-24 Thread Van Haaren, Harry
> From: Varghese, Vipin > Sent: Wednesday, January 24, 2018 7:03 AM > To: Van Haaren, Harry ; dev@dpdk.org > Cc: Jain, Deepak K ; Mcnamara, John > ; sta...@dpdk.org; Patel, Amol > ; Varghese, Vipin > Subject: [PATCH] eal/service: add routine to release memory. > > The routine rte_service_finalize

[dpdk-dev] [PATCH] app/procinfo: fix memory leak by rte_service_init

2018-01-24 Thread Vipin Varghese
When procinfo is run multiple times against primary application, it consumes huge page memory by rte_service_init. Which is not released at exit of application. Invoking rte_service_finalize to free memory and prevent memory leak. Signed-off-by: Vipin Varghese --- app/proc_info/main.c | 3 +++

[dpdk-dev] [PATCH] examples/ip_pipeline: update copyright and license

2018-01-24 Thread Lee Daly
This updates the Intel and Oliver Matz licenses on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/ip_pipeline/parser.c | 56 +++-

[dpdk-dev] [PATCH v2] examples/bond: add mbuf alloc check

2018-01-24 Thread Radu Nicolau
Fixes: cc7e8ae84faa ("examples/bond: add example application for link bonding mode 6") Coverity issue: 257008 Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v2: updated commit message examples/bond/main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/examples/bond/main.c b/exam

[dpdk-dev] [PATCH] app/pdump: fix the memory leak by rte_service_init

2018-01-24 Thread Vipin Varghese
When pdump is run multiple times against any primary application, it consumes huge page memory by rte_service_init. This is not freed at exit of application. Invoking rte_service_finalize to free memory and prevent memory leak. Signed-off-by: Vipin Varghese --- app/pdump/main.c | 3 +++ 1 file

[dpdk-dev] [PATCH] examples: update copyrights and license

2018-01-24 Thread Lee Daly
This updates the Intel and Cavium license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- .../performance-thread/common/arch/x86/stack.h | 30 +

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: fix secondary process mempool registration

2018-01-24 Thread Shahaf Shuler
Wednesday, January 24, 2018 10:14 AM, Nélio Laranjeiro: > Hi Shahaf, > > On Tue, Jan 23, 2018 at 07:08:20PM +0200, Shahaf Shuler wrote: > > Secondary process is not allowed to register mempools on the flight. > > > > The code will return invalid memory key for such case. > > > > Fixes: 87ec44ce165

[dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Ophir Munk
Remove CFLAGS -std=c11 and -pedantic in order to guarantee a successful vdev_netvsc compilation on old Linux distributions. Otherwise old GCC compilers may complain as follows: cc1: error: unrecognized command line option -std=c11 Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform d

[dpdk-dev] [PATCH v2] eal/service: add routine to release memory

2018-01-24 Thread Vipin Varghese
The routine rte_service_finalize checks if service is initialized, if yes; releases internal memory for services and lcore states. This routine is to be invoked at end of application termination. Signed-off-by: Vipin Varghese --- V2 Changes: - redo the logic for rte_service_finalize - added in

Re: [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Matan Azrad
Hi Ophir From: Ophir Munk, Wednesday, January 24, 2018 4:12 PM > Remove CFLAGS -std=c11 and -pedantic in order to guarantee a successful > vdev_netvsc compilation on old Linux distributions. > Otherwise old GCC compilers may complain as follows: > cc1: error: unrecognized command line option -std=

Re: [dpdk-dev] [PATCH V12 1/3] eal: add uevent monitor api and callback func

2018-01-24 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Thursday, January 18, 2018 12:12 PM > To: step...@networkplumber.org; Richardson, Bruce > ; > Yigit, Ferruh ; gaetan.ri...@6wind.com > Cc: Ananyev, Konstantin ; jblu...@infradead.org; > shreyansh.j...@nxp.com; Wu, Jingjing ; dev@dpdk.org; >

Re: [dpdk-dev] [PATCH V12 2/3] eal: add uevent pass and process function

2018-01-24 Thread Wu, Jingjing
> -Original Message- > From: Guo, Jia > Sent: Thursday, January 18, 2018 12:12 PM > To: step...@networkplumber.org; Richardson, Bruce > ; > Yigit, Ferruh ; gaetan.ri...@6wind.com > Cc: Ananyev, Konstantin ; jblu...@infradead.org; > shreyansh.j...@nxp.com; Wu, Jingjing ; dev@dpdk.org; >

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Wed, Jan 24, 2018 at 11:37:31AM +0100, Thomas Monjalon wrote: > 24/01/2018 11:36, Yuanhan Liu: > > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > > > 24/01/2018 10:28, Yuanhan Liu: > > > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thomas Monjalon wrote: > > > > > 24/01/2018 0

[dpdk-dev] [PATCH 2/2] event/opdl: fix dereference before null check

2018-01-24 Thread Liang Ma
Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") Coverity issue: 257022 Signed-off-by: Liang Ma --- drivers/event/opdl/opdl_ring.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_ring.c b/drivers/event/opdl/opdl_ring.c i

[dpdk-dev] [PATCH 1/2] event/opdl: fix the resource leak issue

2018-01-24 Thread Liang Ma
Fixes: d548ef513cd7 ("event/opdl: add unit tests") Coverity issue: 257004 Signed-off-by: Liang Ma --- drivers/event/opdl/opdl_test.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/event/opdl/opdl_test.c b/drivers/event/opdl/opdl_test.c index 44a5cc5..4894c08 1

[dpdk-dev] [PATCH v2] doc: fix bbdev test guide build

2018-01-24 Thread Marko Kovacevic
Fix build issue with pdf guides. Some indentations in the bbdev test application doc were causing build failures. Latex Log message:       doc.log:! LaTeX Error: Too deeply nested.     Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev") Cc: amr.mokh...@intel.com   Signed-off-by:

Re: [dpdk-dev] [PATCH V12 3/3] app/testpmd: use uevent to monitor hotplug

2018-01-24 Thread Wu, Jingjing
> + > +static void > +add_uevent_callback(void *arg) > +{ > + char *dev_name = (char *)arg; > + > + rte_eal_alarm_cancel(add_uevent_callback, arg); > + > + if (!in_hotplug_list(dev_name)) > + return; > + > + RTE_LOG(ERR, EAL, "add device: %s\n", dev_name); It's not an e

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Yuanhan Liu
On Tue, Jan 23, 2018 at 05:08:16PM +0100, Gaëtan Rivet wrote: > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > standardized objects in response to parameters that are given to them > for init. I think matching properties should be restricted to higher > classes (bus, eth/cr

Re: [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2018 14:12:13 + Ophir Munk wrote: > Remove CFLAGS -std=c11 and -pedantic in order to guarantee > a successful vdev_netvsc compilation on old Linux distributions. > Otherwise old GCC compilers may complain as follows: > cc1: error: unrecognized command line option -std=c11 > >

Re: [dpdk-dev] [PATCH] ethdev: move internal callback list definition

2018-01-24 Thread Ferruh Yigit
On 1/22/2018 12:25 PM, David Marchand wrote: > This structure is not exposed through public apis, we should just move it > to the core header. > > Signed-off-by: David Marchand > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v2 0/2] net/mrvl: switch to the new Rx/Tx offloads API

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 8:46 AM, Tomasz Duszynski wrote: > This patch series replaces the old Rx/Tx offload API with the > new API. > > v2: > * Follow the same logic for calculating both unsupported and missing flags. > > Tomasz Duszynski (2): > net/mrvl: switch to the new Rx offload API > net/mrvl: sw

[dpdk-dev] [PATCH v6 1/3] net/failsafe: register as an Rx interrupt mode PMD

2018-01-24 Thread Moti Haimovsky
This patch adds registering the Rx queues of the failsafe PMD with EAL Rx interrupts subsystem. Each failsafe RX queue is assigned with a unique eventfd and an enable interrupts flag. The PMD creates an interrupt vector containing the above eventfds and Registers it with EAL. The PMD also implemen

[dpdk-dev] [PATCH v6 0/3] net/failsafe: add Rx interrupts support

2018-01-24 Thread Moti Haimovsky
These three patches add support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single device to be handled by the application wh

[dpdk-dev] [PATCH v6 2/3] net/failsafe: slaves Rx interrupts registration

2018-01-24 Thread Moti Haimovsky
This commit adds the following functionality to failsafe PMD: * Register and unregister slaves Rx interrupts. * Enable and Disable slaves Rx interrupts. The interrupts events generated by the slaves are not handled in this commit. Signed-off-by: Moti Haimovsky --- V6: Added a wrapper around epoll

[dpdk-dev] [PATCH v6 3/3] net/failsafe: add Rx interrupts

2018-01-24 Thread Moti Haimovsky
This patch is the last patch in the series of patches aimed to add support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single

[dpdk-dev] [PATCH v1] doc: add note in proc info for stats retrieval

2018-01-24 Thread Marko Kovacevic
Note added to outline that using proc_info for virtual devices is not supported Signed-off-by: Marko Kovacevic --- doc/guides/tools/proc_info.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.rst index fd17e27..191ab20 100644 -

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 16:24, Yuanhan Liu: > On Tue, Jan 23, 2018 at 05:08:16PM +0100, Gaëtan Rivet wrote: > > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > > standardized objects in response to parameters that are given to them > > for init. I think matching properties should be rest

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-24 Thread Thomas Monjalon
24/01/2018 16:04, Yuanhan Liu: > On Wed, Jan 24, 2018 at 11:37:31AM +0100, Thomas Monjalon wrote: > > 24/01/2018 11:36, Yuanhan Liu: > > > On Wed, Jan 24, 2018 at 11:21:44AM +0100, Thomas Monjalon wrote: > > > > 24/01/2018 10:28, Yuanhan Liu: > > > > > On Wed, Jan 24, 2018 at 09:19:10AM +0100, Thom

[dpdk-dev] [PATCH] service: fix possible mem leak on initialize

2018-01-24 Thread Harry van Haaren
This commit ensures that if that if we run out of memory during the initialization of the service library, that the first allocated memory is correctly freed instead of leaked. Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Reported-by: Vipin Varghese Signed

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only > for IPv4. The hardware actually validates the TCP/UDP checksum of > IPv6 packets too. Set PKT_RX_L4_CKSUM_{GOOD,BAD} accordingly. > > Signed-off-by: Hyong Y

Re: [dpdk-dev] [PATCH] net/enic: add a Tx prepare handler

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > Like most NICs, this hardware (Cisco VIC) also requires partial > checksum in the packet for checksum offload and TSO. So, add > the tx_pkt_prepare handler like other PMDs do. > > Technically, VIC has an offload mode that does no

Re: [dpdk-dev] [PATCH] net/enic: fix segfault due to static max number of queues

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > ENIC_CQ_MAX, ENIC_WQ_MAX and others are arbitrary values that > prevent the app from using more queues when they are available on > hardware. Remove them and dynamically allocate vnic_cq and such > arrays to accommodate all availa

[dpdk-dev] [PATCH] maintainers: update for cryptodev

2018-01-24 Thread Pablo de Lara
Signed-off-by: Pablo de Lara --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5788ea004..924426343 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -276,6 +276,7 @@ F: examples/bbdev_app/ F: doc/guides/sample_app_ug/bbdev_app.rst Crypto API +M:

Re: [dpdk-dev] [PATCH] net/failsafe: fix Rx burst infinite loop

2018-01-24 Thread Ferruh Yigit
On 1/24/2018 10:31 AM, Gaëtan Rivet wrote: > On Wed, Jan 24, 2018 at 10:19:17AM +, Matan Azrad wrote: >> In case of plugged out device, the fail-safe PMD uses failsafe_rx_burst >> function for packet receiving. >> >> This function iterates over the present sub-devices until it >> receives a tra

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Hyong Youb Kim
On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote: > On 1/23/2018 1:05 AM, John Daley wrote: > > From: Hyong Youb Kim > > > > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only > > for IPv4. The hardware actually validates the TCP/UDP checksum of > > IPv6 packets to

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Ferruh Yigit
On 1/24/2018 5:30 PM, Hyong Youb Kim wrote: > On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote: >> On 1/23/2018 1:05 AM, John Daley wrote: >>> From: Hyong Youb Kim >>> >>> enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only >>> for IPv4. The hardware actually validat

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Hyong Youb Kim
On Wed, Jan 24, 2018 at 05:45:48PM +, Ferruh Yigit wrote: > On 1/24/2018 5:30 PM, Hyong Youb Kim wrote: > > On Wed, Jan 24, 2018 at 05:18:37PM +, Ferruh Yigit wrote: > >> On 1/23/2018 1:05 AM, John Daley wrote: > >>> From: Hyong Youb Kim > >>> > >>> enic_cq_rx_to_pkt_flags() currently sets

Re: [dpdk-dev] [PATCH] net/enic: set L4 checksum flags for IPv6 packets

2018-01-24 Thread Ferruh Yigit
On 1/23/2018 1:05 AM, John Daley wrote: > From: Hyong Youb Kim > > enic_cq_rx_to_pkt_flags() currently sets checksum good/bad flags only > for IPv4. The hardware actually validates the TCP/UDP checksum of > IPv6 packets too. Set PKT_RX_L4_CKSUM_{GOOD,BAD} accordingly. > > Signed-off-by: Hyong Y

Re: [dpdk-dev] [PATCH] event/opdl: rework loops to comply with dpdk style

2018-01-24 Thread Thomas Monjalon
22/01/2018 11:30, Liang, Ma: > On 22 Jan 10:04, Harry van Haaren wrote: > > This commit reworks the loop counter variable declarations > > to be in line with the DPDK source code. > > > > Fixes: 3c7f3dcfb099 ("event/opdl: add PMD main body and helper function") > > Fixes: 8ca8e3b48eff ("event/opdl

Re: [dpdk-dev] [PATCH] drivers/event: fix resource leak in selftest

2018-01-24 Thread Thomas Monjalon
23/01/2018 15:17, Van Haaren, Harry: > > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > > Sent: Monday, January 22, 2018 5:46 PM > > To: jerin.ja...@caviumnetworks.com; Van Haaren, Harry > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev] [PATCH] drivers/event: fix

Re: [dpdk-dev] [PATCH v1] net/tap: use local eBPF definitions

2018-01-24 Thread Thomas Monjalon
24/01/2018 12:05, Van Haaren, Harry: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ophir Munk > > Sent: Tuesday, January 23, 2018 9:54 PM > > To: dev@dpdk.org; Pascal Mazon > > Cc: Thomas Monjalon ; Olga Shern ; > > Ophir Munk > > Subject: [dpdk-dev] [PATCH v1] net/tap: use local eBPF

Re: [dpdk-dev] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Thomas Monjalon
24/01/2018 15:45, Matan Azrad: > Hi Ophir > > From: Ophir Munk, Wednesday, January 24, 2018 4:12 PM > > Remove CFLAGS -std=c11 and -pedantic in order to guarantee a successful > > vdev_netvsc compilation on old Linux distributions. > > Otherwise old GCC compilers may complain as follows: > > cc1:

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Thomas Monjalon
24/01/2018 16:39, Stephen Hemminger: > On Wed, 24 Jan 2018 14:12:13 + > Ophir Munk wrote: > > --- a/drivers/net/vdev_netvsc/Makefile > > +++ b/drivers/net/vdev_netvsc/Makefile > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map > > # Additional compilation flags. > > CFLAGS +

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic

2018-01-24 Thread Stephen Hemminger
On Wed, 24 Jan 2018 19:08:02 +0100 Thomas Monjalon wrote: > 24/01/2018 16:39, Stephen Hemminger: > > On Wed, 24 Jan 2018 14:12:13 + > > Ophir Munk wrote: > > > --- a/drivers/net/vdev_netvsc/Makefile > > > +++ b/drivers/net/vdev_netvsc/Makefile > > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_

Re: [dpdk-dev] [PATCH v3 7/7] app/testpmd: adjust ethdev port ownership

2018-01-24 Thread Ananyev, Konstantin
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, January 24, 2018 8:10 AM > To: Ananyev, Konstantin > Cc: Matan Azrad ; Gaëtan Rivet ; > Wu, Jingjing ; > dev@dpdk.org; Neil Horman ; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH v3 7/7

Re: [dpdk-dev] IXGBE, IOMMU DMAR DRHD handling fault issue

2018-01-24 Thread Ravi Kerur
Hi Burakov, Thank you. I will try with vfio-pci driver. I am assuming it will work for both PF and VF interfaces since I am using both in my setup? Thanks. On Wed, Jan 24, 2018 at 2:31 AM, Burakov, Anatoly wrote: > On 23-Jan-18 5:25 PM, Ravi Kerur wrote: > >> Hi, >> >> I am running into an issu

Re: [dpdk-dev] [RFC v3 1/1] lib: add compressdev API

2018-01-24 Thread Ahmed Mansour
Hi All, Please see responses in line. Thanks, Ahmed On 1/23/2018 6:58 AM, Verma, Shally wrote: > Hi Fiona > >> -Original Message- >> From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >> Sent: 19 January 2018 17:30 >> To: Verma, Shally ; dev@dpdk.org; >> akhil.go...@nxp.com >> Cc: Challa

Re: [dpdk-dev] [RFC v2, 1/2] cryptodev: add support to set session private data

2018-01-24 Thread De Lara Guarch, Pablo
> -Original Message- > From: Gujjar, Abhinandan S > Sent: Tuesday, January 23, 2018 8:54 AM > To: Doherty, Declan ; akhil.go...@nxp.com; De > Lara Guarch, Pablo ; > jerin.jacobkollanukka...@cavium.com > Cc: dev@dpdk.org; Vangati, Narender ; > Gujjar, Abhinandan S ; Rao, Nikhil > > Subjec

Re: [dpdk-dev] [PATCH] maintainers: update for cryptodev

2018-01-24 Thread Doherty, Declan
On 24/01/2018 5:24 PM, Pablo de Lara wrote: Signed-off-by: Pablo de Lara --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5788ea004..924426343 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -276,6 +276,7 @@ F: examples/bbdev_app/ F: doc/guid

[dpdk-dev] [PATCH v1 1/4] net/mlx4: move rdma-core calls to separate file

2018-01-24 Thread Adrien Mazarguil
This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/Makefile | 1 + drivers/net/mlx4/mlx4.c| 35 ++--- drivers/net/mlx4/mlx4_ethdev.c | 3

[dpdk-dev] [PATCH v1 0/4] net/mlx: make rdma-core optional at run-time

2018-01-24 Thread Adrien Mazarguil
A problem encountered with Mellanox PMDs and frequently reported by DPDK application developers and Linux distribution package maintainers is their dependency on rdma-core components, namely libibverbs, libmlx4, and libmlx5. For best performance in applications, DPDK is normally built as a collect

[dpdk-dev] [PATCH v1 2/4] net/mlx4: spawn rdma-core dependency plug-in

2018-01-24 Thread Adrien Mazarguil
When mlx4 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx4 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

[dpdk-dev] [PATCH v1 3/4] net/mlx5: move rdma-core calls to separate file

2018-01-24 Thread Adrien Mazarguil
From: Nelio Laranjeiro This lays the groundwork for externalizing rdma-core as an optional run-time dependency instead of a mandatory one. No functional change. Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/Makefile| 1 + drivers/net/mlx5/mlx5.c | 48 ++--- drivers/

[dpdk-dev] [PATCH v1 4/4] net/mlx5: spawn rdma-core dependency plug-in

2018-01-24 Thread Adrien Mazarguil
When mlx5 is not compiled directly as an independent shared object (e.g. CONFIG_RTE_BUILD_SHARED_LIB not enabled for performance reasons), DPDK applications inherit its dependencies on libibverbs and libmlx5 through rte.app.mk. This is an issue both when DPDK is delivered as a binary package (Linu

Re: [dpdk-dev] [PATCH v1 1/4] net/mlx4: move rdma-core calls to separate file

2018-01-24 Thread Stephen Hemminger
On Thu, 25 Jan 2018 00:25:00 +0100 Adrien Mazarguil wrote: > +const struct mlx4_glue *mlx4_glue = &(const struct mlx4_glue){ > + .fork_init = mlx4_glue_fork_init, > + .get_async_event = mlx4_glue_get_async_event, The cast should not be necessary here.

Re: [dpdk-dev] [PATCH] app/testpmd: do not enable Rx offloads by default

2018-01-24 Thread Lu, Wenzhuo
Hi Moti, > -Original Message- > From: Moti Haimovsky [mailto:mo...@mellanox.com] > Sent: Tuesday, January 23, 2018 4:11 PM > To: Lu, Wenzhuo ; tho...@monjalon.net > Cc: dev@dpdk.org; Moti Haimovsky > Subject: [PATCH] app/testpmd: do not enable Rx offloads by default > > Removed the hard

Re: [dpdk-dev] [PATCH v5 7/7] app/testpmd: adjust ethdev port ownership

2018-01-24 Thread Lu, Wenzhuo
Hi Matan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Matan Azrad > Sent: Tuesday, January 23, 2018 12:38 AM > To: Thomas Monjalon ; Gaetan Rivet > ; Wu, Jingjing > Cc: dev@dpdk.org; Neil Horman ; Richardson, > Bruce ; Ananyev, Konstantin > > Subject: [dp

  1   2   >