[dpdk-dev] [PATCH v2] vhost: dequeue zero copy should restore mbuf before return to pool

2018-01-17 Thread Junjie Chen
dequeue zero copy change buf_addr and buf_iova of mbuf, and return to mbuf pool without restore them, it breaks vm memory if others allocate mbuf from same pool since mbuf reset doesn't reset buf_addr and buf_iova. Signed-off-by: Junjie Chen --- v2 changes: Remove useless restore lib/librte_vhos

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-17 Thread Andrew Rybchenko
On 01/16/2018 06:55 PM, Adrien Mazarguil wrote: I understand the motivation behind this proposal, however since new ideas must be challenged, I have a few comments: - How about making packet type recognition an optional offload configurable per queue like any other (e.g. DEV_RX_OFFLOAD_PTYPE)

Re: [dpdk-dev] [PATCH] vhost: dequeue zero copy should restore mbuf before return to pool

2018-01-17 Thread Chen, Junjie J
> > > > dequeue zero copy change buf_addr and buf_iova of mbuf, and return to > > mbuf pool without restore them, it breaks vm memory if others allocate > > mbuf from same pool since mbuf reset doesn't reset buf_addr and > buf_iova. > > > > Signed-off-by: Junjie Chen > > --- > > lib/librte_vhost/

[dpdk-dev] [PATCH v2 1/2] net/ena: convert to new Tx offloads API

2018-01-17 Thread Rafal Kozik
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit support the new Tx offloads API. Queue configuration is stored in ena_ring.offloads. During preparing mbufs for tx, offloads are allowed only if appropriate flags in this field ar

Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-17 Thread Thomas Monjalon
17/01/2018 05:03, Jia He: > To support C11 memory model barrier, 2 options are suggested by Jerin: > 1. use rte_smp_rmb > 2. use load_acquire/store_release(refer to [1]). > CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" > on any architectures so far. In previous patches, i

[dpdk-dev] [PATCH v2 2/2] net/ena: convert to new Rx offloads API

2018-01-17 Thread Rafal Kozik
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit support the new Rx offloads API. Signed-off-by: Rafal Kozik --- v2: * Use PRIx64 in printf. drivers/net/ena/ena_ethdev.c | 36 ++-- drivers/ne

[dpdk-dev] [PATCH v2 4/6] test: fix memory leak in ring perf autotest

2018-01-17 Thread Anatoly Burakov
Fixes: ac3fb3019c52 ("app: rework ring tests") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_ring_perf.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/test/test/test_ring_perf.c b/test/test/test_ring_perf.c inde

[dpdk-dev] [PATCH v2 2/6] test: fix memory leak in reorder autotest

2018-01-17 Thread Anatoly Burakov
Add a teardown function that frees allocated resources. Fixes: d0c9b58d7156 ("app/test: new reorder unit test") Cc: sergio.gonzalez.mon...@intel.com Cc: reshma.pat...@intek.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_reorder.c | 11 +++ 1 file changed, 11 i

[dpdk-dev] [PATCH v2 6/6] test: fix memory leak in timer perf autotest

2018-01-17 Thread Anatoly Burakov
Fixes: 277afaf3dbcb ("app/test: add timer_perf") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_timer_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test/test_timer_perf.c b/test/test/test_timer_perf.c index afa3a06..0fe2b74 100644 --- a/test/test/test_tim

[dpdk-dev] [PATCH v2 1/6] test: fix memory leak in bitmap test

2018-01-17 Thread Anatoly Burakov
Acked-by: Cristian Dumitrescu Fixes: c7e4a134e769 ("test: verify bitmap operations") Cc: pbhagavat...@caviumnetworks.com Signed-off-by: Anatoly Burakov --- test/test/test_bitmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test/test_bitmap.c b/test/test/test_bitmap.c index 05d

[dpdk-dev] [PATCH v2 5/6] test: fix memory leak in table autotest

2018-01-17 Thread Anatoly Burakov
Always deallocate allocated resources after the test is done. Acked-by: Cristian Dumitrescu Fixes: 5205954791cb ("app/test: packet framework unit tests") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_table.c | 44 ++

[dpdk-dev] [PATCH v2 3/6] test: fix memory leak in ring autotest

2018-01-17 Thread Anatoly Burakov
Get rid of global static ring variable and don't reuse rings between test runs. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_ring.c | 61 --- 1 file changed, 33 insertions(+), 2

Re: [dpdk-dev] [PATCH v3 3/8] net/failsafe: support probed sub-devices getting

2018-01-17 Thread Matan Azrad
Hi Gaetan From: Gaëtan Rivet, Wednesday, January 17, 2018 12:31 AM > Hi Matan, > > On Tue, Jan 16, 2018 at 05:20:27PM +, Matan Azrad wrote: > > Hi Gaetan > > > > > > > > > > In 18.05, or 18.08 there should be an EAL function that would be > > > > > able to identify a device given a specifi

Re: [dpdk-dev] [PATCH v2 3/6] test: fix memory leak in ring autotest

2018-01-17 Thread Burakov, Anatoly
On 17-Jan-18 8:36 AM, Anatoly Burakov wrote: Get rid of global static ring variable and don't reuse rings between test runs. Fixes: af75078fece3 ("first public release") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_ring.c | 61

Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-17 Thread Jia He
Hi Thomas On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: 17/01/2018 05:03, Jia He: To support C11 memory model barrier, 2 options are suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release(refer to [1]). CONFIG_RTE_RING_USE_C11_MEM_MODEL is provided, and by default it is "n" on

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-17 Thread Jonas Pfefferle
On Tue, 16 Jan 2018 18:01:32 +0100 Maxime Coquelin wrote: Hi Jonas, On 01/16/2018 05:08 PM, Jonas Pfefferle wrote:  On Mon, 15 Jan 2018 17:11:58 +0100  Thomas Monjalon wrote: 15/01/2018 13:22, Jonas Pfefferle:   On Sat, 13 Jan 2018 23:49:30 +0100   Thomas Monjalon wrote: > 13/01/201

Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: adjust ethdev port ownership

2018-01-17 Thread Matan Azrad
Hi Lu From: Lu, Wenzhuo, Wednesday, January 17, 2018 2:47 AM > Hi Matan, > > > -Original Message- > > From: Matan Azrad [mailto:ma...@mellanox.com] > > Sent: Tuesday, January 16, 2018 4:16 PM > > To: Lu, Wenzhuo ; Thomas Monjalon > > ; Gaetan Rivet ; Wu, > > Jingjing > > Cc: dev@dpdk.org

[dpdk-dev] [PATCH v2] mempool/dpaa: optimize phy to virt conversion

2018-01-17 Thread Hemant Agrawal
If the allocation is from a single memzone, optimize the phy-virt address conversions. Signed-off-by: Hemant Agrawal --- v2: use register memory area instead of new flag in mempool drivers/mempool/dpaa/dpaa_mempool.c | 50 ++--- drivers/mempool/dpaa/dpaa_mempool.

[dpdk-dev] [PATCH] net/i40e: fix link_state update for i40e_ethdev_vf drv

2018-01-17 Thread Tushar Mulkar
The check for bool was accounting unwanted bits in the calulation of truth value Signed-off-by: Tushar Mulkar --- drivers/net/i40e/i40e_ethdev_vf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index b96

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-17 Thread Maxime Coquelin
On 01/17/2018 09:48 AM, Jonas Pfefferle wrote:  On Tue, 16 Jan 2018 18:01:32 +0100  Maxime Coquelin wrote: Hi Jonas, On 01/16/2018 05:08 PM, Jonas Pfefferle wrote:   On Mon, 15 Jan 2018 17:11:58 +0100   Thomas Monjalon wrote: 15/01/2018 13:22, Jonas Pfefferle:   On Sat, 13 Jan 2018

Re: [dpdk-dev] [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD

2018-01-17 Thread Kumar, Ravi1
>Hi Ravi, > >> -Original Message- >> From: Kumar, Ravi1 [mailto:ravi1.ku...@amd.com] >> Sent: Thursday, January 11, 2018 6:37 AM >> To: De Lara Guarch, Pablo ; >> dev@dpdk.org >> Cc: Shippen, Greg >> Subject: RE: [PATCH v3 01/19] crypto/ccp: add AMD ccp skeleton PMD >> >> > -Original

Re: [dpdk-dev] [PATCH v8 3/3] ring: introduce new header file to support C11 memory model

2018-01-17 Thread Thomas Monjalon
17/01/2018 09:47, Jia He: > > Hi Thomas > > On 1/17/2018 4:24 PM, Thomas Monjalon Wrote: > > 17/01/2018 05:03, Jia He: > >> To support C11 memory model barrier, 2 options are suggested by Jerin: > >> 1. use rte_smp_rmb > >> 2. use load_acquire/store_release(refer to [1]). > >> CONFIG_RTE_RING_USE

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-17 Thread Gaëtan Rivet
Hi Thomas, On Wed, Jan 17, 2018 at 01:03:50AM +0100, Thomas Monjalon wrote: > 17/01/2018 00:46, Gaëtan Rivet: > > On Wed, Jan 17, 2018 at 12:22:43AM +0100, Thomas Monjalon wrote: > > > 17/01/2018 00:19, Gaëtan Rivet: > > > > It might be a nitpick, but the driver specific properties might not > > >

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-17 Thread Thomas Monjalon
17/01/2018 10:37, Gaëtan Rivet: > Hi Thomas, > > On Wed, Jan 17, 2018 at 01:03:50AM +0100, Thomas Monjalon wrote: > > 17/01/2018 00:46, Gaëtan Rivet: > > > On Wed, Jan 17, 2018 at 12:22:43AM +0100, Thomas Monjalon wrote: > > > > 17/01/2018 00:19, Gaëtan Rivet: > > > > > It might be a nitpick, but

Re: [dpdk-dev] [PATCH 1/2] lib/cryptodev: add support to set session private data

2018-01-17 Thread De Lara Guarch, Pablo
Hi Abhinandan, > -Original Message- > From: Gujjar, Abhinandan S > Sent: Wednesday, January 17, 2018 6:35 AM > To: Akhil Goyal ; Doherty, Declan > ; De Lara Guarch, Pablo > ; Jacob, Jerin > > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil > Subject: RE: [PATCH 1/2] lib/cryptodev: ad

Re: [dpdk-dev] [PATCH 1/2] lib/cryptodev: add support to set session private data

2018-01-17 Thread Gujjar, Abhinandan S
Hi Akhil, > -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, January 17, 2018 3:16 PM > To: Gujjar, Abhinandan S ; Akhil Goyal > ; Doherty, Declan ; Jacob, > Jerin > Cc: dev@dpdk.org; Vangati, Narender ; Rao, > Nikhil > Subject: RE: [PATCH 1/2] lib/cryptodev: add suppo

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-17 Thread Gaëtan Rivet
A new suggestion about the syntax. On Tue, Jan 16, 2018 at 10:50:18PM +0800, Yuanhan Liu wrote: > This patch documents the new devargs syntax, which is going to be > implemented in DPDK v18.05. > > The new devargs proposal is introduced for having a consistent > interface for: > > - whitelisting

Re: [dpdk-dev] [PATCH v2] vfio: noiommu check error handling

2018-01-17 Thread Jonas Pfefferle
On Wed, 17 Jan 2018 09:55:37 +0100 Maxime Coquelin wrote: On 01/17/2018 09:48 AM, Jonas Pfefferle wrote:  On Tue, 16 Jan 2018 18:01:32 +0100  Maxime Coquelin wrote: Hi Jonas, On 01/16/2018 05:08 PM, Jonas Pfefferle wrote:   On Mon, 15 Jan 2018 17:11:58 +0100   Thomas Monjalon wrot

Re: [dpdk-dev] [PATCH v3] lib/librte_vhost: move fdset_del out of conn_mutex

2018-01-17 Thread 王志克
Hi Yuanhan, Huawei, Can you please spare some time for code review? Thanks. Br, Zhike -Original Message- From: 王志克 Sent: Tuesday, January 02, 2018 6:09 PM To: dev@dpdk.org Cc: 王志克 Subject: [PATCH v3] lib/librte_vhost: move fdset_del out of conn_mutex From: wang zhike v3: * Fix duplic

Re: [dpdk-dev] [PATCH v2 3/4] eal: add synchronous multi-process communication

2018-01-17 Thread Ananyev, Konstantin
> > Hi Jianfeng, > > > >> -Original Message- > >> From: Tan, Jianfeng > >> Sent: Tuesday, January 16, 2018 8:11 AM > >> To: Ananyev, Konstantin ; dev@dpdk.org; > >> Burakov, Anatoly > >> Cc: Richardson, Bruce ; tho...@monjalon.net > >> Subject: Re: [PATCH v2 3/4] eal: add synchronous mu

Re: [dpdk-dev] [PATCH 1/2] lib/cryptodev: add support to set session private data

2018-01-17 Thread Akhil Goyal
Hi Abhinandan, On 1/17/2018 3:35 PM, Gujjar, Abhinandan S wrote: Hi Akhil, -Original Message- From: De Lara Guarch, Pablo Sent: Wednesday, January 17, 2018 3:16 PM To: Gujjar, Abhinandan S ; Akhil Goyal ; Doherty, Declan ; Jacob, Jerin Cc: dev@dpdk.org; Vangati, Narender ; Rao, Nikhil

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-17 Thread Thomas Monjalon
17/01/2018 11:11, Gaëtan Rivet: > A new suggestion about the syntax. > > On Tue, Jan 16, 2018 at 10:50:18PM +0800, Yuanhan Liu wrote: > > This patch documents the new devargs syntax, which is going to be > > implemented in DPDK v18.05. > > > > The new devargs proposal is introduced for having a c

Re: [dpdk-dev] [PATCH 1/2] test: rely on dynamic log level to display hexdumps

2018-01-17 Thread Thomas Monjalon
08/12/2017 14:21, Olivier Matz: > Instead of relying on a compile-time option, use the global log-level > to decide if the hexdumps should be displayed in the tests. > > Valitation: > > # build/app/test --no-huge > RTE>>crc_autotest > Test OK > > # build/app/test --no-huge --log-level=8

[dpdk-dev] [PATCH v3 1/6] test: fix memory leak in bitmap test

2018-01-17 Thread Anatoly Burakov
Acked-by: Cristian Dumitrescu Fixes: c7e4a134e769 ("test: verify bitmap operations") Cc: pbhagavat...@caviumnetworks.com Signed-off-by: Anatoly Burakov --- test/test/test_bitmap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/test/test_bitmap.c b/test/test/test_bitmap.c index 05d

[dpdk-dev] [PATCH v3 3/6] test: fix memory leak in ring autotest

2018-01-17 Thread Anatoly Burakov
Get rid of global static ring variable and don't reuse rings between test runs. Fixes: 4e32101f9b01 ("ring: support freeing") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v3: fix commit message to point to approriate commit being fixed

[dpdk-dev] [PATCH v3 2/6] test: fix memory leak in reorder autotest

2018-01-17 Thread Anatoly Burakov
Add a teardown function that frees allocated resources. Fixes: d0c9b58d7156 ("app/test: new reorder unit test") Cc: sergio.gonzalez.mon...@intel.com Cc: reshma.pat...@intek.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_reorder.c | 11 +++ 1 file changed, 11 i

[dpdk-dev] [PATCH v3 4/6] test: fix memory leak in ring perf autotest

2018-01-17 Thread Anatoly Burakov
Fixes: ac3fb3019c52 ("app: rework ring tests") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- Notes: v2: remove static ring variable test/test/test_ring_perf.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/test/test/test_

[dpdk-dev] [PATCH v3 6/6] test: fix memory leak in timer perf autotest

2018-01-17 Thread Anatoly Burakov
Fixes: 277afaf3dbcb ("app/test: add timer_perf") Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_timer_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test/test_timer_perf.c b/test/test/test_timer_perf.c index afa3a06..0fe2b74 100644 --- a/test/test/test_tim

[dpdk-dev] [PATCH v3 5/6] test: fix memory leak in table autotest

2018-01-17 Thread Anatoly Burakov
Always deallocate allocated resources after the test is done. Acked-by: Cristian Dumitrescu Fixes: 5205954791cb ("app/test: packet framework unit tests") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/test_table.c | 44 ++

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-17 Thread Ananyev, Konstantin
Hi Matan, > Hi Konstantin > > From: Ananyev, Konstantin, Tuesday, January 16, 2018 9:11 PM > > Hi Matan, > > > > > > > > Hi Konstantin > > > From: Ananyev, Konstantin, Monday, January 15, 2018 8:44 PM > > > > Hi Matan, > > > > > Hi Konstantin > > > > > From: Ananyev, Konstantin, Monday, January 1

[dpdk-dev] [PATCH] net/ixgbe: check if security capabilities are enabled by HW

2018-01-17 Thread Radu Nicolau
Check if the security enable bits are not fused before setting offload capabilities for security Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/ixgbe_ethdev.c | 6 -- drivers/net/ixgbe/ixgbe_ipsec.c | 15 +++ drivers/net/ixgbe/ixgbe_ipsec.h | 1 + 3 files changed, 20 inser

Re: [dpdk-dev] [PATCH] net/ixgbe: check if security capabilities are enabled by HW

2018-01-17 Thread Ananyev, Konstantin
Hi Radu, > -Original Message- > From: Nicolau, Radu > Sent: Wednesday, January 17, 2018 11:19 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > ; Zhao, XinfengX > ; De Lara Guarch, Pablo > ; Nicolau, Radu > Subject: [PATCH] net/ixgbe: check if security capabilities are ena

Re: [dpdk-dev] [PATCH] net/ixgbe: check if security capabilities are enabled by HW

2018-01-17 Thread Nicolau, Radu
> -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, January 17, 2018 11:34 AM > To: Nicolau, Radu ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao, XinfengX > ; De Lara Guarch, Pablo > > Subject: RE: [PATCH] net/ixgbe: check if security capabilities are enabled by > HW > > Hi Rad

[dpdk-dev] [PATCH v2] net/ixgbe: check if security capabilities are enabled by HW

2018-01-17 Thread Radu Nicolau
Check if the security enable bits are not fused before setting offload capabilities for security Signed-off-by: Radu Nicolau --- drivers/net/ixgbe/ixgbe_ethdev.c | 20 +++- drivers/net/ixgbe/ixgbe_ipsec.c | 31 +-- 2 files changed, 36 insertions(+), 1

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-17 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Sent: Wednesday, January 17, 2018 1:24 PM > Hi Matan, > > > Hi Konstantin > > > > From: Ananyev, Konstantin, Tuesday, January 16, 2018 9:11 PM > > > Hi Matan, > > > > > > > > > > > Hi Konstantin > > > > From: Ananyev, Konstantin, Monday, January 15, 2018 8

Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax

2018-01-17 Thread Ferruh Yigit
On 1/16/2018 2:50 PM, Yuanhan Liu wrote: > This patch documents the new devargs syntax, which is going to be > implemented in DPDK v18.05. > > The new devargs proposal is introduced for having a consistent > interface for: > > - whitelisting/blacklisting devices > - identifying ports > - attachin

[dpdk-dev] [PATCH V3] net/failsafe: add Rx interrupts

2018-01-17 Thread Moti Haimovsky
This patch adds support for registering and waiting for Rx interrupts in failsafe PMD. This allows applications to wait for Rx events from the PMD using the DPDK rte_epoll subsystem. The failsafe PMD presents to the application a facade of a single device to be handled by the application while inte

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-17 Thread Ananyev, Konstantin
> > > Hi Konstantin > From: Ananyev, Konstantin, Sent: Wednesday, January 17, 2018 1:24 PM > > Hi Matan, > > > > > Hi Konstantin > > > > > > From: Ananyev, Konstantin, Tuesday, January 16, 2018 9:11 PM > > > > Hi Matan, > > > > > > > > > > > > > > Hi Konstantin > > > > > From: Ananyev, Konstant

Re: [dpdk-dev] [PATCH v2 3/4] eal: add synchronous multi-process communication

2018-01-17 Thread Tan, Jianfeng
On 1/17/2018 6:50 PM, Ananyev, Konstantin wrote: Hi Jianfeng, -Original Message- From: Tan, Jianfeng Sent: Tuesday, January 16, 2018 8:11 AM To: Ananyev, Konstantin ; dev@dpdk.org; Burakov, Anatoly Cc: Richardson, Bruce ; tho...@monjalon.net Subject: Re: [PATCH v2 3/4] eal: add sy

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-17 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Wednesday, January 17, 2018 2:55 PM > > > > > > Hi Konstantin > > From: Ananyev, Konstantin, Sent: Wednesday, January 17, 2018 1:24 PM > > > Hi Matan, > > > > > > > Hi Konstantin > > > > > > > > From: Ananyev, Konstantin, Tuesday, January 16, 2018 9:11 PM >

Re: [dpdk-dev] [PATCH v2 3/4] eal: add synchronous multi-process communication

2018-01-17 Thread Tan, Jianfeng
On 1/17/2018 9:09 PM, Tan, Jianfeng wrote: On 1/17/2018 6:50 PM, Ananyev, Konstantin wrote: [...] +int +rte_eal_mp_request(const char *action_name, + void *params, + int len_p, + int fds[], + int fds_in, + int fds_out) +{ +int i, j; +

Re: [dpdk-dev] [PATCH v2 3/3] logs: remove log level config option

2018-01-17 Thread Thomas Monjalon
12/12/2017 17:36, Olivier MATZ: > On Sat, Dec 09, 2017 at 06:53:58PM +0530, Pavan Nikhilesh wrote: > > Remove RTE_LOG_LEVEL config option, use existing RTE_LOG_DP_LEVEL config > > option for controlling datapath log level. > > RTE_LOG_LEVEL is no longer needed as dynamic logging can be used to > >

[dpdk-dev] [Bug 10] [Testpmd] NUMA, speed issue

2018-01-17 Thread bugzilla
https://dpdk.org/tracker/show_bug.cgi?id=10 Bug ID: 10 Summary: [Testpmd] NUMA, speed issue Product: DPDK Version: unspecified Hardware: x86 OS: All Status: CONFIRMED Severity: normal Priority: N

Re: [dpdk-dev] [PATCH v2 1/8] eal: introduce DMA memory barriers

2018-01-17 Thread Thomas Monjalon
16/01/2018 10:10, Jianbo Liu: > The 01/16/2018 10:49, Andrew Rybchenko wrote: > > On 01/16/2018 04:10 AM, Yongseok Koh wrote: > > >This commit introduces rte_dma_wmb() and rte_dma_rmb(), in order to > > >guarantee the ordering of coherent shared memory between the CPU and a DMA > > >capable device.

[dpdk-dev] [PATCH v5] vhost_user: protect active rings from async ring changes

2018-01-17 Thread Victor Kaplansky
When performing live migration or memory hot-plugging, the changes to the device and vrings made by message handler done independently from vring usage by PMD threads. This causes for example segfaults during live-migration with MQ enable, but in general virtually any request sent by qemu changing

Re: [dpdk-dev] [dpdk-stable] [PATCH] pdump: fix error code check when creating/canceling pthread

2018-01-17 Thread Thomas Monjalon
> > On error, pthread_create() returns a positive number (an errno) but does > > not set the errno variable. > > > > Fixes: 278f945402c5 ("pdump: add new library for packet capture") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Olivier Matz > > Acked-by: John McNamara Applied, thanks

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-17 Thread Neil Horman
On Wed, Jan 17, 2018 at 12:05:42PM +, Matan Azrad wrote: > > Hi Konstantin > From: Ananyev, Konstantin, Sent: Wednesday, January 17, 2018 1:24 PM > > Hi Matan, > > > > > Hi Konstantin > > > > > > From: Ananyev, Konstantin, Tuesday, January 16, 2018 9:11 PM > > > > Hi Matan, > > > > > > > > >

[dpdk-dev] [PATCH V5 1/2] net/tap: use new Tx offloads API

2018-01-17 Thread Moti Haimovsky
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit adds support for the new Tx offloads API. Signed-off-by: Moti Haimovsky --- V5: * Fixed compilation errors caused by not using PRIx64 in log messages when displaying uint64_t va

[dpdk-dev] [PATCH V5 2/2] net/tap: use new Rx offloads API

2018-01-17 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit adds support for the new Rx offloads API. Signed-off-by: Moti Haimovsky --- V5: * Fixed compilation errors caused by not using PRIx64 in log messages when displaying uint64_t va

Re: [dpdk-dev] [PATCH v6 0/2] app/testpmd: fix invalid rxq and txq nubmer settings

2018-01-17 Thread Thomas Monjalon
12/01/2018 12:31, Wei Dai: > If an invlaid number of RX or TX queues is configured from testpmd > command like "port config all rxq number" or "port config all txq > number" or from --rxq and --txq in the command to start testpmd. > The global variable nb_rxq or nb_txq is updated by the invalid > i

[dpdk-dev] [PATCH v4 2/2] net/failsafe: use new Rx offloads API

2018-01-17 Thread Moti Haimovsky
Ethdev Rx offloads API has changed since: commit ce17eddefc20 ("ethdev: introduce Rx queue offloads API") This commit adds support for the new Rx offloads API. Signed-off-by: Moti Haimovsky --- V4: Modifications according to inputs from Gaetan Rivet in reply to 1515595223-36144-2-git-send-email-m

[dpdk-dev] [PATCH v4 1/2] net/failsafe: use new Tx offloads API

2018-01-17 Thread Moti Haimovsky
Ethdev Tx offloads API has changed since: commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") This commit adds support for the new Tx offloads API. Signed-off-by: Moti Haimovsky --- V4: Modifications according to inputs from Gaetan Rivet in reply to 1515595223-36144-1-git-send-email-m

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-17 Thread Ferruh Yigit
On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: > On 01/16/2018 09:37 PM, Stephen Hemminger wrote: >> While reviewing drivers, noticed a lot of unnecessary >> duplication of code in drivers for handling the eth_dev link status >> information. While consolidating this, it also became obvious that >> s

Re: [dpdk-dev] [RFC] New packet type query API

2018-01-17 Thread Shahaf Shuler
Wednesday, January 17, 2018 10:09 AM, Andrew RybchenkoL > On 01/16/2018 06:55 PM, Adrien Mazarguil wrote: > > I understand the motivation behind this proposal, however since new > > ideas must be challenged, I have a few comments: > > > > - How about making packet type recognition an optional offlo

[dpdk-dev] [PATCH] examples: update copyright and license

2018-01-17 Thread Lee Daly
This updates the license on files in examples to be the standard BSD-3-Clause license used for the rest of DPDK, bringing the files in compliance with the DPDK licensing policy. Signed-off-by: Lee Daly --- examples/Makefile | 31 +- examples/cmdline/comma

Re: [dpdk-dev] [PATCH] vhost: do deep copy while reallocate vq

2018-01-17 Thread Yuanhan Liu
On Mon, Jan 15, 2018 at 06:32:19AM -0500, Junjie Chen wrote: > When vhost reallocate dev and vq for NUMA enabled case, it doesn't perform > deep copy, which lead to 1) zmbuf list not valid 2) remote memory access. > This patch is to re-initlize the zmbuf list and also do the deep copy. > > Signed-

Re: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when other interrupts not allowed.

2018-01-17 Thread Zhang, Helin
Hi Tonghao, Xiangxia In general, I have several comments for your patch sets. 1. As there are 6 patches in your patch set, so a cover letter is needed. 2. You have send several version of patch sets, so '--in-reply-to' is needed to make sure all can see the history version together. Please fol

Re: [dpdk-dev] [PATCH v3] net/i40e: fix packet type parser issue

2018-01-17 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Tuesday, January 16, 2018 7:56 AM > To: Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix packet type parser issue > > > > > -Original M

Re: [dpdk-dev] [RFC PATCH 0/6] mempool: add bucket mempool driver

2018-01-17 Thread Andrew Rybchenko
Hi Olivier, first of all many thanks for the review. See my replies/comments below. Also I'll reply to the the specific patch mails as well. On 12/14/2017 04:36 PM, Olivier MATZ wrote: Hi Andrew, Please find some comments about this patchset below. I'll also send some comments as replies to th

Re: [dpdk-dev] [RFC PATCH 1/6] mempool: implement abstract mempool info API

2018-01-17 Thread Andrew Rybchenko
On 12/14/2017 04:36 PM, Olivier MATZ wrote: On Fri, Nov 24, 2017 at 04:06:26PM +, Andrew Rybchenko wrote: From: "Artem V. Andreev" Primarily, it is intended as a way for the mempool driver to provide additional information on how it lays up objects inside the mempool. Signed-off-by: Artem

Re: [dpdk-dev] [PATCH] net/i40e: fix link_state update for i40e_ethdev_vf drv

2018-01-17 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Tushar Mulkar > Sent: Wednesday, January 17, 2018 4:53 PM > To: dev@dpdk.org > Cc: Xing, Beilei; Zhang, Qi Z; Tushar Mulkar > Subject: [dpdk-dev] [PATCH] net/i40e: fix link_state update for i40e_ethdev_vf > drv >

Re: [dpdk-dev] [RFC PATCH 2/6] mempool: implement clustered object allocation

2018-01-17 Thread Andrew Rybchenko
On 12/14/2017 04:37 PM, Olivier MATZ wrote: On Fri, Nov 24, 2017 at 04:06:27PM +, Andrew Rybchenko wrote: From: "Artem V. Andreev" Clustered allocation is required to simplify packaging objects into buckets and search of the bucket control structure by an object. Signed-off-by: Artem V. A

[dpdk-dev] [PATCH 1/2] net/vmxnet3: set the queue shared buffer at start

2018-01-17 Thread Chas Williams
From: "Charles (Chas) Williams" If a reconfiguration happens, queuedesc is reallocated. Any queues that are preserved point to the previous queuedesc since the queues are only configured during queue setup. Delay configuration of the shared queue pointers until device start when queuedesc is no

[dpdk-dev] [PATCH 2/2] net/vmxnet3: keep consistent link status

2018-01-17 Thread Chas Williams
From: "Charles (Chas) Williams" Bonding may examine the link properties to ensure that matching interfaces are bound together. If the link is going to have fixed properties, these need to remain consistent regardless of the link_status or the state of the adapter. Signed-off-by: Chas Williams

Re: [dpdk-dev] [RFC PATCH 3/6] mempool/bucket: implement bucket mempool manager

2018-01-17 Thread Andrew Rybchenko
On 12/14/2017 04:38 PM, Olivier MATZ wrote: On Fri, Nov 24, 2017 at 04:06:28PM +, Andrew Rybchenko wrote: From: "Artem V. Andreev" The manager provides a way to allocate physically and virtually contiguous set of objects. Note: due to the way objects are organized in the bucket manager, t

Re: [dpdk-dev] [RFC PATCH 4/6] mempool: add a function to flush default cache

2018-01-17 Thread Andrew Rybchenko
On 12/14/2017 04:38 PM, Olivier MATZ wrote: On Fri, Nov 24, 2017 at 04:06:29PM +, Andrew Rybchenko wrote: From: "Artem V. Andreev" Mempool get/put API cares about cache itself, but sometimes it is required to flush the cache explicitly. I don't disagree, but do you have some use-case in m

[dpdk-dev] [PATCH] net/i40e: add warning log during writing global register

2018-01-17 Thread Beilei Xing
This patch adds warning log when writing global register, and add limitation doc for impact during use of 700 series NIC with both kernel driver and DPDK PMD. Signed-off-by: Beilei Xing --- doc/guides/nics/i40e.rst | 12 drivers/net/i40e/i40e_ethdev.c | 16 dr

Re: [dpdk-dev] [RFC PATCH 2/6] mempool: implement clustered object allocation

2018-01-17 Thread santosh
On Wednesday 17 January 2018 08:33 PM, Andrew Rybchenko wrote: > On 12/14/2017 04:37 PM, Olivier MATZ wrote: >> On Fri, Nov 24, 2017 at 04:06:27PM +, Andrew Rybchenko wrote: >>> From: "Artem V. Andreev" >>> >>> Clustered allocation is required to simplify packaging objects into >>> buckets an

Re: [dpdk-dev] [PATCH v2] net/bonding: fix link status check

2018-01-17 Thread Ferruh Yigit
On 11/29/2017 3:42 PM, Tomasz Kulasek wrote: > Some devices needs more time to initialize and bring interface up. When > link is down the link properties are not valid, e.g. link_speed is > reported as 0 and this is not a valid speed for slave as well as for whole > bonding. > > During NIC (and bo

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-17 Thread Stephen Hemminger
On Wed, 17 Jan 2018 14:32:17 + Ferruh Yigit wrote: > On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: > > On 01/16/2018 09:37 PM, Stephen Hemminger wrote: > >> While reviewing drivers, noticed a lot of unnecessary > >> duplication of code in drivers for handling the eth_dev link status > >> in

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2018-01-17 Thread Ferruh Yigit
On 12/21/2017 1:38 PM, Wiles, Keith wrote: > > >> On Dec 21, 2017, at 10:53 AM, Vipin Varghese >> wrote: >> >> TAP speed is passed as user argument, but never set to interface. >> New logic brings speed get and set to LOCAL and REMOTE interfaces. >> >> Updated the default PMD speeed to 10M as p

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2018-01-17 Thread Wiles, Keith
> On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh wrote: > > On 12/21/2017 1:38 PM, Wiles, Keith wrote: >> >> >>> On Dec 21, 2017, at 10:53 AM, Vipin Varghese >>> wrote: >>> >>> TAP speed is passed as user argument, but never set to interface. >>> New logic brings speed get and set to LOCAL an

Re: [dpdk-dev] [PATCH v5 00/15] common ethdev linkstatus functions

2018-01-17 Thread Ferruh Yigit
On 1/17/2018 4:05 PM, Stephen Hemminger wrote: > On Wed, 17 Jan 2018 14:32:17 + > Ferruh Yigit wrote: > >> On 1/17/2018 7:56 AM, Andrew Rybchenko wrote: >>> On 01/16/2018 09:37 PM, Stephen Hemminger wrote: While reviewing drivers, noticed a lot of unnecessary duplication of code i

Re: [dpdk-dev] [PATCH v1] [net/tap] add logic to assign speed from user

2018-01-17 Thread Ferruh Yigit
On 1/17/2018 4:14 PM, Wiles, Keith wrote: > > >> On Jan 17, 2018, at 10:06 AM, Yigit, Ferruh wrote: >> >> On 12/21/2017 1:38 PM, Wiles, Keith wrote: >>> >>> On Dec 21, 2017, at 10:53 AM, Vipin Varghese wrote: TAP speed is passed as user argument, but never set to interface.

[dpdk-dev] [PATCH] vfio: fix compilation errors in bsdapp

2018-01-17 Thread Moti Haimovsky
This patch fixes the following compilation errors in bsdapp /home/patchWorkOrg/compilation/lib/librte_eal/bsdapp/eal/eal.c:782:5: error: no previous prototype for function 'rte_vfio_clear_group' [-Werror,-Wmissing-prototypes] int rte_vfio_clear_group(int vfio_group_fd) ^ /home/patchWorkOrg/comp

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: update mbuf packet type

2018-01-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, January 16, 2018 4:12 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Gonzalez Monroy, Sergio > > Subject: RE: [PATCH] examples/ipsec-secgw: update mbuf packet type > > > > -Orig

Re: [dpdk-dev] [PATCH] doc: update pcap documentation

2018-01-17 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 16, 2018 6:45 PM > To: Richardson, Bruce ; Mcnamara, John > ; Kovacevic, Marko > Cc: dev@dpdk.org; Yigit, Ferruh ; Varghese, Vipin > ; Glynn, Michael J > Subject: [PATCH] doc: update pcap documentation > > Add note abo

Re: [dpdk-dev] [RFC PATCH 2/6] mempool: implement clustered object allocation

2018-01-17 Thread Andrew Rybchenko
On 01/17/2018 06:55 PM, santosh wrote: On Wednesday 17 January 2018 08:33 PM, Andrew Rybchenko wrote: On 12/14/2017 04:37 PM, Olivier MATZ wrote: On Fri, Nov 24, 2017 at 04:06:27PM +, Andrew Rybchenko wrote: From: "Artem V. Andreev" Clustered allocation is required to simplify packaging

[dpdk-dev] [PATCH] net/bonding: don't early mark eth device as bonded

2018-01-17 Thread Chas Williams
From: "Charles (Chas) Williams" bonding immediately marks the incoming eth device as bonded and doesn't clear this in later error paths. Delay marking the dev until we are certain that we are going to add this eth device to the bond group. Signed-off-by: Chas Williams --- drivers/net/bonding/

Re: [dpdk-dev] [PATCH v3 5/8] net/vdev_netvsc: implement core functionality

2018-01-17 Thread Thomas Monjalon
10/01/2018 16:02, Matan Azrad: > From: Stephen Hemminger, Tuesday, January 9, 2018 8:49 PM > > On Tue, 9 Jan 2018 14:47:30 + > > Matan Azrad wrote: > > > + ret = rte_eal_alarm_set(VDEV_NETVSC_PROBE_MS * 1000, > > > + vdev_netvsc_alarm, NULL); > > > + if (ret < 0) { > >

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add port ownership

2018-01-17 Thread Ananyev, Konstantin
Hi Matan, > > Hi Konstantin > From: Ananyev, Konstantin, Wednesday, January 17, 2018 2:55 PM > > > > > > > > > Hi Konstantin > > > From: Ananyev, Konstantin, Sent: Wednesday, January 17, 2018 1:24 PM > > > > Hi Matan, > > > > > > > > > Hi Konstantin > > > > > > > > > > From: Ananyev, Konstantin,

Re: [dpdk-dev] [PATCH v2 1/2] lib/net: add IPv6 header fields macros

2018-01-17 Thread Ferruh Yigit
On 1/16/2018 9:17 AM, Shahaf Shuler wrote: > From: Shachar Beiser > > Support IPv6 header vtc_flow fields : tc , flow_label > > Signed-off-by: Shachar Beiser > --- > Sending on behalf of Shachar. > > On v2: > - Addressed Stephen comments on the coding style. Hi Olivier, Any objection to the

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix corner case for spi value

2018-01-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, January 16, 2018 11:02 AM > To: Akhil Goyal ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Gonzalez Monroy, Sergio > > Subject: RE: [PATCH] examples/ipsec-secgw: fix corner case for spi value > > > > >

Re: [dpdk-dev] [PATCH v2] crypto/dpaa_sec: rewrite Rx/Tx path

2018-01-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, January 11, 2018 11:44 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Akhil Goyal ; Nipun > Gupta > Subject: [PATCH v2] crypto/dpaa_sec: rewrite Rx/Tx path > > Rx and T

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: improve ipsec dequeue logic

2018-01-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, January 16, 2018 4:13 PM > To: Akhil Goyal ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com; Gonzalez Monroy, Sergio > > Subject: RE: [PATCH] examples/ipsec-secgw: improve ipsec dequeue logic > > > > -

Re: [dpdk-dev] [PATCH 0/6] net/sfc: convert to the new offload API

2018-01-17 Thread Ferruh Yigit
On 1/11/2018 8:12 AM, Andrew Rybchenko wrote: > May be it is too late to suggest a new API functions to ethdev, > but hopefully if the idea is accepted, it could be applied in the > current release cycle since these functions are trivial. Agreed, I think they are OK to get in even late. > > I'm

Re: [dpdk-dev] [PATCH 1/6] ethdev: add a function to look up Rx offload names

2018-01-17 Thread Ferruh Yigit
On 1/11/2018 8:12 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Commonly, drivers converted to the new offload API > may need to log unsupported offloads as a response > to wrong settings. From this perspective, it would > be convenient to have generic functions to look up > offload names. T

Re: [dpdk-dev] [PATCH 10/10 v4] doc: add DPAA eventdev guide

2018-01-17 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Nipun Gupta > Sent: Tuesday, January 16, 2018 8:44 PM > To: jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; sunil.k...@nxp.com; hemant.agra...@nxp.com > Subject: [dpdk-dev] [PATCH 10/10 v4] doc: add DPAA eventd

Re: [dpdk-dev] [PATCH v2] doc: add eventdev pipeline sample app to release notes

2018-01-17 Thread Mcnamara, John
> -Original Message- > From: Pavan Nikhilesh [mailto:pbhagavat...@caviumnetworks.com] > Sent: Tuesday, January 16, 2018 6:06 PM > To: jerin.ja...@caviumnetworks.com; Kovacevic, Marko > ; Mcnamara, John > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2] doc: add eventde

Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 to 64

2018-01-17 Thread Ferruh Yigit
On 1/15/2018 5:33 PM, Kirill Rybalchenko wrote: > Increase the internal limit for flow types from 32 to 64 > to support future flow type extensions. > Change type of variables from uint32_t[] to uint64_t[]: > rte_eth_fdir_info.flow_types_mask > rte_eth_hash_global_conf.sym_hash_enable_mask > rte_et

  1   2   3   >