Hi Tonghao, Xiangxia
In general, I have several comments for your patch sets.
1. As there are 6 patches in your patch set, so a cover letter is needed.
2. You have send several version of patch sets, so '--in-reply-to' is needed to
make sure all can see the history version together. Please follow the
guidance
on dpdk.org to contribute patches.
3. I saw one ACKs for one of your patches. You still need to get ACKs for all of
your patch set. Please address the comments, and ask maintainers to help
directly.
4. As today is the integration deadline, I don't know if canbe applied in
18.02. Anyway
I will apply it as early as possibel whenever everything is ready and
reasonable.
Thank you very much for your contribution!
Regards,
Helin
> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of
> xiangxia.m....@gmail.com
> Sent: Sunday, January 14, 2018 6:04 PM
> To: Dai, Wei; Xing, Beilei
> Cc: dev@dpdk.org; Tonghao Zhang
> Subject: [dpdk-dev] [PATCH v3 1/6] net/ixgbevf: unregister irq handler when
> other interrupts not allowed.
>
> From: Tonghao Zhang <xiangxia.m....@gmail.com>
>
> When bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the
> rx-interrupt,
> there will be more than one epoll_wait on intr_handle.fd.
> One is in "eal-intr-thread" thread, and the others are in the thread which
> call
> the "rte_epoll_wait". The problem is that sometimes "eal-intr-thread" thread
> will process the rx interrupt, and then rte_epoll_wait can't get the event
> anymore, and the packets may be lost.
>
> The patch unregister the status interrupt handler in "eal-intr-thread"
> thread and the ixgbe pf is in the same case.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m....@gmail.com>
> Acked-by: Beilei Xing <beilei.x...@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index ff19a56..0e056a2 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5078,6 +5078,15 @@ static int
> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
> }
> ixgbevf_configure_msix(dev);
>
> + if (!rte_intr_allow_others(intr_handle)) {
> + rte_intr_callback_unregister(intr_handle,
> + ixgbevf_dev_interrupt_handler,
> + dev);
> + if (dev->data->dev_conf.intr_conf.lsc != 0)
> + PMD_INIT_LOG(INFO, "lsc won't enable because of"
> + " no intr multiplex");
> + }
> +
> /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt
> * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ).
> * If previous VFIO interrupt mapping setting in eth_ixgbevf_dev_init( )
> @@ -5120,6 +5129,12 @@ static int
> ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
>
> ixgbe_dev_clear_queues(dev);
>
> + if (!rte_intr_allow_others(intr_handle))
> + /* resume to the default handler */
> + rte_intr_callback_register(intr_handle,
> + ixgbevf_dev_interrupt_handler,
> + (void *)dev);
> +
> /* Clean datapath event and queue/vec mapping */
> rte_intr_efd_disable(intr_handle);
> if (intr_handle->intr_vec != NULL) {
> --
> 1.8.3.1
