Re: [dpdk-dev] [PATCH v3 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-11-02 Thread Yao, Lei A
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Maxime Coquelin > Sent: Thursday, October 5, 2017 4:36 PM > To: dev@dpdk.org; Horton, Remy ; Bie, Tiwei > ; y...@fridaylinux.org > Cc: m...@redhat.com; jfrei...@redhat.com; vkapl...@redhat.com; > jasow...@redhat.c

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Mody, Rasesh
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, November 01, 2017 7:12 AM > > On Wed, 1 Nov 2017 06:58:53 + > "Mody, Rasesh" wrote: > > > Hi Jianfeng and Ferruh, > > > > > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > > > Sent: Thursday, October 26, 20

Re: [dpdk-dev] [PATCH v3 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-11-02 Thread Maxime Coquelin
Hi Lei, On 11/02/2017 08:21 AM, Yao, Lei A wrote: ... Hi, Maxime > I met one issue with your patch set during the v17.11 test. Is it with v17.11-rc2 or -rc1? The test scenario is following, 1. Bind one NIC, use test-pmd set vhost-user with 2 queue usertools/dpdk-devbind.py --bind=igb

[dpdk-dev] [PATCH] net/mrvl: reset errno before library call

2017-11-02 Thread Tomasz Duszynski
In case errno contains some non-zero value and call to strtoul() is successful -2 error will be returned. Setting errno to zero before calling strtoul() makes sure errors will be handled correctly. Fixes: 0ddc9b815b11 ("net/mrvl: add net PMD skeleton") Signed-off-by: Tomasz Duszynski --- drive

[dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-02 Thread Jia He
We watched a rte panic of mbuf_autotest in our qualcomm arm64 server. As for the possible race condition, please refer to [1]. Furthermore, there are 2 options as suggested by Jerin: 1. use rte_smp_rmb 2. use load_acquire/store_release(refer to [2]). CONFIG_RTE_ATOMIC_ACQUIRE_RELEASE_BARRIER_PREFE

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Ferruh Yigit
On 11/2/2017 1:03 AM, Mody, Rasesh wrote: >> From: Stephen Hemminger [mailto:step...@networkplumber.org] >> Sent: Wednesday, November 01, 2017 7:12 AM >> >> On Wed, 1 Nov 2017 06:58:53 + >> "Mody, Rasesh" wrote: >> >>> Hi Jianfeng and Ferruh, >>> From: Ferruh Yigit [mailto:ferruh.yi...@in

Re: [dpdk-dev] [PATCH] ring: guarantee ordering of cons/prod loading when doing enqueue/dequeue

2017-11-02 Thread Jia He
Hi, Jerin please see my performance test below On 11/2/2017 3:04 AM, Jerin Jacob Wrote: [...] Should it be like instead? +#else +        *old_head = __atomic_load_n(&r->cons.head, __ATOMIC_ACQUIRE); +        const uint32_t prod_tail = __atomic_load_n(&r->prod.tail, __ATOMIC_ACQUIRE); It would b

Re: [dpdk-dev] [PATCH] eal: force IOVA PA mode if KNI module inserted

2017-11-02 Thread Ferruh Yigit
On 11/1/2017 8:58 PM, santosh wrote: > Hi Ferruh, > > > On Thursday 02 November 2017 05:36 AM, Ferruh Yigit wrote: >> Fix kernel crash with KNI because KNI requires physical addresses. >> >> When IOVA VA mode used, memzones and mbufs physical address fields >> contain virtual addresses. But KNI r

Re: [dpdk-dev] [PATCH] service: fix race in service on app lcore function

2017-11-02 Thread Bruce Richardson
On Wed, Nov 01, 2017 at 05:59:51PM +, Van Haaren, Harry wrote: > > From: Richardson, Bruce > > Sent: Wednesday, November 1, 2017 5:09 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org; pbhagavat...@caviumnetworks.com; tho...@monjalon.net > > Subject: Re: [dpdk-dev] [PATCH] service: fix race in

[dpdk-dev] [PATCH 1/2] net/ixgbe: fix l3fwd start failed on VF

2017-11-02 Thread Yanglong Wu
VF can't run in multi queue module,if nb_q_per_pool was set as 1. Since the value of nb_q_per_pool pass through to max_rx_q and max_tx_q in VF. Fixes: 27b609cbd1c6 ("ethdev: move the multi-queue mode check to specific drivers") Signed-off-by: Yanglong Wu --- drivers/net/ixgbe/ixgbe_ethdev.c |

[dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF

2017-11-02 Thread Yanglong Wu
which occurred when the SRIOV is active and tx_q > rx_q. The number of nb_q_per_pool should equeal to max number of queues supported by HW not nb_rx_q. Fixes: 27b609cbd1c6 (ethdev: move the multi-queue mode check to specific drivers) Signed-off-by: Yanglong Wu --- drivers/net/ixgbe/ixgbe_ethde

Re: [dpdk-dev] [PATCH v3 01/19] Revert "vhost: workaround MQ fails to startup"

2017-11-02 Thread Maxime Coquelin
Hi Mark, On 11/01/2017 06:11 PM, Kavanagh, Mark B wrote: Hi Maxime, First off, apologies for the lateness of this reply - I realize that this patch has already been upstreamed. No worries, great to see DPDK integration being tested before v17.11 is released. Is the v17.11 upgrade patch avail

Re: [dpdk-dev] [PATCH v2] service: fix race in service on app lcore function

2017-11-02 Thread Bruce Richardson
On Wed, Nov 01, 2017 at 06:48:01PM +, Harry van Haaren wrote: > This commit fixes a possible race condition if an application > uses the service-cores infrastructure and the function to run > a service on an application lcore at the same time. > > The fix is to change the num_mapped_cores vari

Re: [dpdk-dev] [PATCH] net/vmxnet3: fix memory leak when releasing queues

2017-11-02 Thread Luca Boccassi
On Wed, 2017-11-01 at 16:38 -0400, Chas Williams wrote: > From: Chas Williams > > At the end of the queue release, we can free the containers for the > queue objects. > > Fixes: dfaff37fc46d ("vmxnet3: import new vmxnet3 poll mode driver > implementation") > > Signed-off-by: > --- >  drivers/n

[dpdk-dev] [PATCH 2/5] lpm: fix compilation on ARM BE

2017-11-02 Thread Hemant Agrawal
Compiling on ARM BE using Linaro toolchain caused following error/warnings. rte_lpm.c: In function ‘add_depth_big_v20’: rte_lpm.c:911:4: error: braces around scalar initializer [-Werror] { .group_idx = (uint8_t)tbl8_group_index, }, ^ rte_lpm.c:911:4: note: (near initialization for

[dpdk-dev] [PATCH 1/5] pmdinfogen: fix cross compilation for ARM BE

2017-11-02 Thread Hemant Agrawal
cross compiling DPDK for BE mode on ARM results into errors "PMDINFO portal/dpaa2_hw_dpio.o.pmd.c No drivers registered" Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") Cc: Neil Horman Cc: sta...@dpdk.org Signed-off-by: Jun Yang Signed-off-by: Hemant Agrawal --- bui

[dpdk-dev] [PATCH 3/5] bus/dpaa: fix compilation on ARM BE

2017-11-02 Thread Hemant Agrawal
Fix the following compilation error when compiling with ARM BE compiler. drivers/bus/dpaa/include/fsl_qman.h:1997:25: error: statement with no effect [-Werror=unused-value] #define hw_sg_to_cpu(x) (x) Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines") Signed-off-by: Hemant Agrawal

[dpdk-dev] [PATCH 5/5] net/ixgbe: fix compilation on ARM BE

2017-11-02 Thread Hemant Agrawal
fixes the following compilation error on compiling with ARM BE compiler ixgbe_common.c: In function ‘ixgbe_host_interface_command’: ixgbe_common.c:4610:22: error: passing argument 1 of ‘__builtin_bswap32’ makes integer from pointer without a cast [-Werror=int-conversion] IXGBE_LE32_TO_CPUS(&buf

[dpdk-dev] [PATCH 4/5] net/i40e: fix compilation on ARM BE

2017-11-02 Thread Hemant Agrawal
This patch fixes the following error observed when compiling with ARM BE compiler. i40e_ethdev.c: In function ‘i40e_dev_tunnel_filter_set’: i40e_ethdev.c:6988:5: error: lvalue required as unary ‘&’ operand &rte_cpu_to_le_32(ipv4_addr), Fixes: edc845bd53ec ("app/testpmd: fix build on FreeBSD"

[dpdk-dev] [PATCH] app/testpmd: fix potential memory leak

2017-11-02 Thread Kirill Rybalchenko
Fix potential memory leak in cmd_ddp_info_parsed() function. Fixes: a8e005696c7b ("app/testpmd: get ddp profile protocol info") Signed-off-by: Kirill Rybalchenko --- app/test-pmd/cmdline.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test

Re: [dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-11-02 Thread Thomas Monjalon
Hi 26/10/2017 14:57, Jonas Pfefferle1: > > Hi @all > > I just stumbled upon this patch while testing on POWER. RTE_IOVA_VA will > not work for the sPAPR code since the dma window size is currently > determined by the physical address only. Is it affecting POWER8? > I'm preparing a patch to a

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Wang, Zhihong
> I don't know what is creating this drop exactly. > When doing different tests on different environments, we do not see this > drop. > If nobody else can see such issue, I guess we can ignore it. Hi Thomas, Xiaoyun, With this patch (commit 84cc318424d49372dd2a5fbf3cf84426bf95acce) I see more tha

Re: [dpdk-dev] [PATCH v7 7/9] linuxapp/eal_vfio: honor iova mode before mapping

2017-11-02 Thread Jonas Pfefferle1
Thomas Monjalon wrote on 11/02/2017 11:17:10 AM: > From: Thomas Monjalon > To: Jonas Pfefferle1 > Cc: dev@dpdk.org, Santosh Shukla > , jerin.ja...@caviumnetworks.com, > hemant.agra...@nxp.com, olivier.m...@6wind.com, > maxime.coque...@redhat.com, sergio.gonzalez.mon...@intel.com, > bruce.richa

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions

2017-11-02 Thread Jerin Jacob
-Original Message- > Date: Mon, 30 Oct 2017 15:36:15 +0800 > From: Jianbo Liu > To: Guduri Prathyusha > CC: tomasz.kante...@intel.com, guduriprathyu...@gmail.com, dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix NEON instructions > User-Agent: Mutt/1.5.21 (2010-09-15)

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Thomas Monjalon
02/11/2017 11:22, Wang, Zhihong: > > I don't know what is creating this drop exactly. > > When doing different tests on different environments, we do not see this > > drop. > > If nobody else can see such issue, I guess we can ignore it. > > Hi Thomas, Xiaoyun, > > With this patch (commit 84cc318

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Li, Xiaoyun
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, November 2, 2017 18:45 > To: Wang, Zhihong ; Li, Xiaoyun > > Cc: dev@dpdk.org; Richardson, Bruce ; > Ananyev, Konstantin ; Lu, Wenzhuo > ; Zhang, Helin ; > ophi...@mellanox.com > Subject: Re: [dpd

[dpdk-dev] [PATCH v2] net/mlx4: enhance Rx packet type offloads

2017-11-02 Thread Moti Haimovsky
This patch enhances the Rx packet type offload to also report the L4 protocol information in the hw ptype filled by the PMD for each received packet. Signed-off-by: Moti Haimovsky --- V2: * Modifications according to review by Adrien Mazarguil Re: [PATCH] net/mlx4: enhance Rx packet type off

Re: [dpdk-dev] [PATCH v8 1/3] eal/x86: run-time dispatch over memcpy

2017-11-02 Thread Thomas Monjalon
02/11/2017 11:58, Li, Xiaoyun: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 02/11/2017 11:22, Wang, Zhihong: > > > > I don't know what is creating this drop exactly. > > > > When doing different tests on different environments, we do not see > > > > this drop. > > > > If nobody else can

[dpdk-dev] [PATCH 0/2] Fix 2 bugs of i40e VF interrupt found in l3fwd-power

2017-11-02 Thread Wei Dai
These 2 bugs can be observed from example/l3fwd-power run with i40e VF bound to VFIO-PCI. The test steps are as follows: 1. Disable LSC interrupt by clearing port_conf.intr_conf.lsc=0, as i40e VF doesn't support LSC interrupt to avoid rte_eth_dev_configure() failure. 2. Create a VF from i40e hos

[dpdk-dev] [PATCH 1/2] net/i40e: fix VFIO interrupt mapping in VF

2017-11-02 Thread Wei Dai
When a VF port is bound to VFIO-PIC, only miscellaneous interrupt is mapped to VFIO vector 0 in i40evf_dev_init( ). In ixgbevf_dev_interrupt_handler( ), if previous VFIO interrupt mapping set in i40evf_dev_init( ) is not cleard, it will fail when calling rte_intr_enable( ) tries to map Rx queue int

[dpdk-dev] [PATCH 2/2] net/i40e: fix Rx queue interrupt mapping in VF

2017-11-02 Thread Wei Dai
When a VF port is bound to VFIO-PCI, miscellaneous interrupt is mapped to MSI-X vector 0 and Rx queues interrupt are mapped to other vectors in vfio_enable_msix( ). To simplify implementation, all VFIO-PCI bound i40e VF Rx queue interrupts can be mapped in vector 1. And as current igb_uio only supp

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-02 Thread Ananyev, Konstantin
Hi Jia, > -Original Message- > From: Jia He [mailto:hejia...@gmail.com] > Sent: Thursday, November 2, 2017 8:44 AM > To: jerin.ja...@caviumnetworks.com; dev@dpdk.org; olivier.m...@6wind.com > Cc: Ananyev, Konstantin ; Richardson, Bruce > ; jianbo@arm.com; > hemant.agra...@nxp.com; Jia

[dpdk-dev] [PATCH] net/mlx5: fix segfault due to array overflow

2017-11-02 Thread Nelio Laranjeiro
VLAN id is limited to MLX5_MAX_VLAN_IDS which is not verified by the code before trying to add a new VLAN filter. Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_vlan.c | 8 +++- 1 file changed, 7 insertions(+),

[dpdk-dev] [PATCH] net/mlx4: fix missing include

2017-11-02 Thread Adrien Mazarguil
Fixes: 76df01ff622f ("net/mlx4: separate debugging macros") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_utils.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx4/mlx4_utils.h b/drivers/net/mlx4/mlx4_utils.h index bebd4ae..dc529c9 100644 --- a/drivers/net/mlx4/mlx

Re: [dpdk-dev] [PATCH v4 4/8] net/mlx4: merge Tx path functions

2017-11-02 Thread Adrien Mazarguil
On Tue, Oct 31, 2017 at 06:21:29PM +, Matan Azrad wrote: > Merge tx_burst and mlx4_post_send functions to prevent > double asking about WQ remain space. > > Signed-off-by: Matan Azrad Ideally this patch and subsequent ones should have come after: "net/mlx4: fix HW memory optimizations care

Re: [dpdk-dev] [PATCH v4 2/8] net/mlx4: associate MR to MP in a short function

2017-11-02 Thread Adrien Mazarguil
Hi Matan/Ophir, On Tue, Oct 31, 2017 at 06:21:27PM +, Matan Azrad wrote: > From: Ophir Munk > > Associate memory region to mempool (on data path) in a short function. > Handle the less common case of adding a new memory region to mempool > in a separate function. > > Signed-off-by: Ophir Mu

Re: [dpdk-dev] [PATCH v4 5/8] net/mlx4: remove duplicate handling in Tx burst

2017-11-02 Thread Adrien Mazarguil
On Tue, Oct 31, 2017 at 06:21:30PM +, Matan Azrad wrote: > Remove usage of variable which count the packets for completion and > doesn't add more information than packets counter. > > Remove no space in elements ring check which is already covered by > regular Tx flow. > > Signed-off-by: Mata

Re: [dpdk-dev] [PATCH v4 6/8] net/mlx4: separate Tx segment cases

2017-11-02 Thread Adrien Mazarguil
On Tue, Oct 31, 2017 at 06:21:31PM +, Matan Azrad wrote: > Optimize single segment case by processing it in different block which > prevents checks, calculations and barriers relevant only for multi > segment case. > > Call a dedicated function for handling multi segments case. > > Signed-off

Re: [dpdk-dev] [PATCH v4 7/8] net/mlx4: fix HW memory optimizations careless

2017-11-02 Thread Adrien Mazarguil
On Tue, Oct 31, 2017 at 06:21:32PM +, Matan Azrad wrote: > Volatilize all Rx/Tx HW negotiation memories to be sure no compiler > optimization prevents either load or store commands. > > Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs") > Fixes: 9f57340a8087 ("net/mlx4: restore Rx offloa

Re: [dpdk-dev] [PATCH v4 8/8] net/mlx4: mitigate Tx path memory barriers

2017-11-02 Thread Adrien Mazarguil
On Tue, Oct 31, 2017 at 06:21:33PM +, Matan Azrad wrote: > Replace most of the memory barriers by IO memory barriers since they > are all targeted to the DRAM; This improves code efficiency for > systems which force store order between different addresses. > > Only the doorbell register store

Re: [dpdk-dev] [PATCH v4 3/8] net/mlx4: fix ring wraparound compiler hint

2017-11-02 Thread Adrien Mazarguil
On Tue, Oct 31, 2017 at 06:21:28PM +, Matan Azrad wrote: > Remove unlikely hint from WQ wraparound check because it is > expected case. > > Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs") > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND

Re: [dpdk-dev] [PATCH v1] net/failsafe: fix VLAN stripping configuration

2017-11-02 Thread Gaëtan Rivet
On Wed, Nov 01, 2017 at 08:12:38PM +, Ophir Munk wrote: > failsafe device has vlan stripping configured at startup however once > a sub device is found as non-capable of vlan-stripping failsafe > updates it configuration and removes vlan stripping from it. > This update occurs only once at star

[dpdk-dev] [PATCH] eal/ppc: revert fix mmap for memory initialization

2017-11-02 Thread Jonas Pfefferle
This reverts commit 284ae3e9ff9a92575c28c858efd2c85c8de6d440 ("eal/ppc: fix mmap for memory initialization").The logic if the address hint is respected on mmap is no different on POWER than on x86 however the address layout of userspace applications might be slightly different i.e. you might need t

Re: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF

2017-11-02 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Yanglong Wu > Sent: Thursday, November 2, 2017 5:05 PM > To: dev@dpdk.org > Cc: Wu, Yanglong > Subject: [dpdk-dev] [PATCH 2/2] net/ixgbe: fix l3fwd start failed on PF > > which occurred when the SRIOV is acti

Re: [dpdk-dev] [PATCH v1] net/failsafe: fix VLAN stripping configuration

2017-11-02 Thread Gaëtan Rivet
On Thu, Nov 02, 2017 at 02:52:16PM +0100, Gaëtan Rivet wrote: > On Wed, Nov 01, 2017 at 08:12:38PM +, Ophir Munk wrote: > > failsafe device has vlan stripping configured at startup however once > > a sub device is found as non-capable of vlan-stripping failsafe > > updates it configuration and

Re: [dpdk-dev] [PATCH] eventdev: remove experimental label

2017-11-02 Thread Eads, Gage
> -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Wednesday, November 1, 2017 11:12 PM > To: Eads, Gage > Cc: dev@dpdk.org; Richardson, Bruce ; Van > Haaren, Harry ; Hemant Agrawal > ; Nipun Gupta ; Rao, > Nikhil ; Pavan Nikhilesh > ; Thomas Monjalo

[dpdk-dev] [PATCH ] examples/l3fwd: fix aliasing in port grouping

2017-11-02 Thread Guduri Prathyusha
With -f-strict-aliasing enabled by default from -O2, gcc > 5.x gives undefined behavior in port_groupx4. 'pn' and 'pnum' are two different pointers pointing to same chunk of memory and with -f-strict-aliasing the pointers are assumed to be pointing to different memory and compiler reorders instruct

Re: [dpdk-dev] [PATCH ] examples/l3fwd: fix aliasing in port grouping

2017-11-02 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > Sent: Thursday, November 2, 2017 2:31 PM > To: Kantecki, Tomasz > Cc: jianbo@arm.com; guduriprathyu...@gmail.com; Ananyev, Konstantin > ; dev@dpdk.org; Guduri > Prathyusha > Subject: [dpdk-d

Re: [dpdk-dev] [PATCH ] examples/l3fwd: fix aliasing in port grouping

2017-11-02 Thread Guduri Prathyusha
On Thu, Nov 02, 2017 at 02:46:43PM +, Ananyev, Konstantin wrote: > Hi, Hi > > > -Original Message- > > From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > > Sent: Thursday, November 2, 2017 2:31 PM > > To: Kantecki, Tomasz > > Cc: jianbo@arm.com; guduriprathyu...@gmai

[dpdk-dev] [PATCH 2/3] net/mlx4: adjust removal error

2017-11-02 Thread Matan Azrad
Fail-safe PMD expects to get -ENODEV error value if sub PMD control command fails because of device removal. Make control callbacks return with -ENODEV when the device has disappeared. Signed-off-by: Matan Azrad --- drivers/net/mlx4/mlx4.h| 1 + drivers/net/mlx4/mlx4_ethdev.c | 38

[dpdk-dev] [PATCH 0/3] Fail-safe fix removal handling lack

2017-11-02 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. This series adjusts the -ENODEV error value to fa

[dpdk-dev] [PATCH 1/3] net/failsafe: fix removal handling lack

2017-11-02 Thread Matan Azrad
There is time between the physical removal of the device until sub-device PMDs get a RMV interrupt. At this time DPDK PMDs and applications still don't know about the removal and may call sub-device control operation which should return an error. In previous code this error is reported to the appl

[dpdk-dev] [PATCH 3/3] net/mlx5: adjust removal error

2017-11-02 Thread Matan Azrad
Fail-safe PMD expects to get -ENODEV error value if sub PMD control command fails because of device removal. Make control callbacks return with -ENODEV when the device has disappeared. Signed-off-by: Matan Azrad --- drivers/net/mlx5/mlx5.h| 1 + drivers/net/mlx5/mlx5_ethdev.c | 39

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-02 Thread Jia He
Hi Ananyev On 11/2/2017 9:26 PM, Ananyev, Konstantin Wrote: Hi Jia, -Original Message- From: Jia He [mailto:hejia...@gmail.com] Sent: Thursday, November 2, 2017 8:44 AM To: jerin.ja...@caviumnetworks.com; dev@dpdk.org; olivier.m...@6wind.com Cc: Ananyev, Konstantin ; Richardson, Bruce

Re: [dpdk-dev] [PATCH ] examples/l3fwd: fix aliasing in port grouping

2017-11-02 Thread Ananyev, Konstantin
> -Original Message- > From: Guduri Prathyusha [mailto:gprathyu...@caviumnetworks.com] > Sent: Thursday, November 2, 2017 3:34 PM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; jianbo@arm.com; guduriprathyu...@gmail.com; Kantecki, > Tomasz > Subject: Re: [dpdk-dev] [PATCH ] examples

Re: [dpdk-dev] [PATCH v3 17/19] vhost-user: iommu: postpone device creation until ring are mapped

2017-11-02 Thread Maxime Coquelin
On 11/02/2017 09:21 AM, Maxime Coquelin wrote: Hi Lei, On 11/02/2017 08:21 AM, Yao, Lei A wrote: ... Hi, Maxime > I met one issue with your patch set during the v17.11 test. Is it with v17.11-rc2 or -rc1? The test scenario is following, 1.    Bind one NIC, use test-pmd set vhost-user w

[dpdk-dev] [RFC PATCH 0/6] lib/librte_vhost: introduce new vhost_user crypto backend support

2017-11-02 Thread Fan Zhang
This RFC patchset adds crypto backend suppport to vhost_user library, including a proof-of-concept sample application. The implementation follows the virtio-crypto specification and have been tested with qemu 2.9.50 (with several patches applied, detailed later) with Fedora 24 running in the fronte

[dpdk-dev] [RFC PATCH 1/6] lib/librte_vhost: add vhost_user private info structure

2017-11-02 Thread Fan Zhang
This patch adds a vhost_user_dev_priv structure and a vhost_user message handler function prototype to vhost_user. This allows different types of devices to add private information and their device-specific vhost-user message function handlers to virtio_net structure. The change to vhost_user_msg_h

[dpdk-dev] [RFC PATCH 2/6] lib/librte_vhost: add virtio-crypto spec support

2017-11-02 Thread Fan Zhang
This patch adds virtio-crypto support to vhost_user. Signed-off-by: Fan Zhang --- lib/librte_vhost/vhost_user.h | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h index 4052dbf..793cdc2 100

[dpdk-dev] [RFC PATCH 4/6] config/common_base: add vhost_crypto configuration items

2017-11-02 Thread Fan Zhang
This patch adds the vhost_crypto related compile configuration items to config/common_base. A new item "CONFIG_RTE_LIBRTE_VHOST_CRYPTO_DATA_QUEUE_NO_COPY" is introduced to turn on/off data queue no copy feature to vhost_crypto. This feature is in experimental level so no gurantee it would work, esp

[dpdk-dev] [RFC PATCH 5/6] lib/librte_vhost: update Makefile for vhost_crypto

2017-11-02 Thread Fan Zhang
Signed-off-by: Fan Zhang --- lib/librte_vhost/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/Makefile b/lib/librte_vhost/Makefile index e1084ab..c6ec7ff 100644 --- a/lib/librte_vhost/Makefile +++ b/lib/librte_vhost/Makefile @@ -48,9 +48,8 @@ end

[dpdk-dev] [RFC PATCH 3/6] lib/librte_vhost: add vhost_user backend support

2017-11-02 Thread Fan Zhang
This patch adds vhost_crypto device driver support to vhost_user. Several new APIs are introduced for user to create and delete vhost_crypto devices, fetch virtio queue descriptors and translate to DPDK crypto operations for enqueuing to target cryptodev in the backend. After dequeuing from the cry

[dpdk-dev] [RFC PATCH 6/6] example/vhost_crypto: add vhost_crypto sample application

2017-11-02 Thread Fan Zhang
This patch adds vhost_crypto sample application to DPDK. Signed-off-by: Fan Zhang --- examples/vhost_crypto/Makefile | 59 examples/vhost_crypto/main.c | 617 + 2 files changed, 676 insertions(+) create mode 100644 examples/vhost_crypto/Makefile

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-02 Thread Ananyev, Konstantin
> -Original Message- > From: Jia He [mailto:hejia...@gmail.com] > Sent: Thursday, November 2, 2017 3:43 PM > To: Ananyev, Konstantin ; > jerin.ja...@caviumnetworks.com; dev@dpdk.org; olivier.m...@6wind.com > Cc: Richardson, Bruce ; jianbo@arm.com; > hemant.agra...@nxp.com; jie2@

Re: [dpdk-dev] [PATCH] doc: update release notes for rte_security

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, November 1, 2017 6:21 AM > To: Thomas Monjalon ; Mcnamara, John > > Cc: dev@dpdk.org; Doherty, Declan ; De Lara > Guarch, Pablo ; hemant.agra...@nxp.com; > Nicolau, Radu ; bor...@mellanox.com; > avia

[dpdk-dev] [PATCH v5 0/8] net/mlx4: Tx path improvements

2017-11-02 Thread Matan Azrad
v1: This series is a follow-up of the new datapath implementation introduced in RC1. It is dedicated to Tx and improves the performance. v2: Change uint32_t be_lkey to rte_be32_t lkey v3: Rebase to 17.11-rc2. Remove "net/mlx4: save lkey in big-endian format" patch which degrade performance. Merg

[dpdk-dev] [PATCH v5 4/8] net/mlx4: merge Tx path functions

2017-11-02 Thread Matan Azrad
Merge tx_burst and mlx4_post_send functions to prevent double asking about WQ remain space. Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 355 +-- 1 file changed, 170 insertions(+), 185 deletions(-) diff --git a

[dpdk-dev] [PATCH v5 2/8] net/mlx4: associate MR to MP in a short function

2017-11-02 Thread Matan Azrad
From: Ophir Munk Associate memory region to mempool (on data path) in a short function. Handle the less common case of adding a new memory region to mempool in a separate function. Signed-off-by: Ophir Munk Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4.h | 2 ++ drivers/net/mlx4/

[dpdk-dev] [PATCH v5 1/8] net/mlx4: remove error flows from Tx fast path

2017-11-02 Thread Matan Azrad
Move unnecessary error flows to DEBUG mode. Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxtx.c b/drivers/net/mlx4/mlx4_rxtx.c index 67dc712..79c7

[dpdk-dev] [PATCH v5 3/8] net/mlx4: fix ring wraparound compiler hint

2017-11-02 Thread Matan Azrad
Remove unlikely hint from WQ wraparound check because it is expected case. Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs") Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH v5 5/8] net/mlx4: remove duplicate handling in Tx burst

2017-11-02 Thread Matan Azrad
Remove usage of variable which count the packets for completion and doesn't add more information than packets counter. Remove no space in elements ring check which is already covered by regular Tx flow. Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxtx.c | 6

[dpdk-dev] [PATCH v5 7/8] net/mlx4: fix HW memory optimizations careless

2017-11-02 Thread Matan Azrad
Volatilize all Rx/Tx HW negotiation memories to be sure no compiler optimization prevents either load or store commands. Fixes: c3c977bbecbd ("net/mlx4: add Tx bypassing Verbs") Fixes: 9f57340a8087 ("net/mlx4: restore Rx offloads") Fixes: 6681b845034c ("net/mlx4: add Rx bypassing Verbs") Fixes: 62

[dpdk-dev] [PATCH v5 6/8] net/mlx4: separate Tx segment cases

2017-11-02 Thread Matan Azrad
Optimize single segment case by processing it in different block which prevents checks, calculations and barriers relevant only for multi segment case. Call a dedicated function for handling multi segments case. Signed-off-by: Matan Azrad Signed-off-by: Ophir Munk Acked-by: Adrien Mazarguil --

[dpdk-dev] [PATCH v5 8/8] net/mlx4: mitigate Tx path memory barriers

2017-11-02 Thread Matan Azrad
Replace most of the memory barriers by IO memory barriers since they are all targeted to the DRAM; This improves code efficiency for systems which force store order between different addresses. Only the doorbell register store should be protected by memory barrier since it is targeted to the PCI m

Re: [dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, October 26, 2017 10:09 AM > To: dev@dpdk.org; Mcnamara, John > Cc: Iremonger, Bernard > Subject: [PATCH 1/2] doc: flow classify library prog guide > > This file documents the Flow Classification library, librte_flow_clas

Re: [dpdk-dev] [PATCH 2/2] doc: flow classify sample app guide

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, October 26, 2017 10:09 AM > To: dev@dpdk.org; Mcnamara, John > Cc: Iremonger, Bernard > Subject: [PATCH 2/2] doc: flow classify sample app guide > > This file documents the flow_classify sample application which is used

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-02 Thread Jerin Jacob
-Original Message- > Date: Thu, 2 Nov 2017 16:16:33 + > From: "Ananyev, Konstantin" > To: Jia He , "jerin.ja...@caviumnetworks.com" > , "dev@dpdk.org" , > "olivier.m...@6wind.com" > CC: "Richardson, Bruce" , "jianbo@arm.com" > , "hemant.agra...@nxp.com" , > "jie2@hxt-semit

Re: [dpdk-dev] [PATCH] doc: fix a typo in ip pipeline app guide

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Saturday, October 28, 2017 8:58 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Rosen, Rami > > Subject: [dpdk-dev] [PATCH] doc: fix a typo in ip pipeline app guide > > This patch fixes a t

Re: [dpdk-dev] [PATCH] doc: fix a typo in DPDK programmer's guide

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Sunday, October 29, 2017 1:25 PM > To: dev@dpdk.org > Cc: Rosen, Rami > Subject: [dpdk-dev] [PATCH] doc: fix a typo in DPDK programmer's guide > > This patch fixes a trivial typo in DPDK progr

Re: [dpdk-dev] [PATCH] doc: fix description of traffic management function in testpmd

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: Singh, Jasvinder > Sent: Thursday, October 26, 2017 12:07 PM > To: dev@dpdk.org > Cc: Mcnamara, John > Subject: [PATCH] doc: fix description of traffic management function in > testpmd > > Fixes: 5b590fbe09b6 ("app/testpmd: add traffic management forwarding

Re: [dpdk-dev] [PATCH v2] doc: add basic howto for flow API

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, October 27, 2017 12:18 AM > To: Mcnamara, John > Cc: dev@dpdk.org; Ori Kam ; adrien.mazarg...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v2] doc: add basic howto for flow API > > 25/10/2017 17:27,

Re: [dpdk-dev] [PATCH] doc: fix an error in DPDK programmers's guide (EAL)

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Saturday, October 28, 2017 4:37 AM > To: dev@dpdk.org > Cc: Rosen, Rami > Subject: [dpdk-dev] [PATCH] doc: fix an error in DPDK programmers's guide > (EAL) > > Fix an error in DPDK programmer'

Re: [dpdk-dev] [PATCH v5 0/8] net/mlx4: Tx path improvements

2017-11-02 Thread Adrien Mazarguil
On Thu, Nov 02, 2017 at 04:42:43PM +, Matan Azrad wrote: > v1: > This series is a follow-up of the new datapath implementation introduced in > RC1. > It is dedicated to Tx and improves the performance. > > v2: > Change uint32_t be_lkey to rte_be32_t lkey > > v3: > Rebase to 17.11-rc2. > Remo

Re: [dpdk-dev] [PATCH] doc/guides: mention 17.11 LTS in contributing/stable

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > luca.bocca...@gmail.com > Sent: Tuesday, October 31, 2017 4:29 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Luca Boccassi > Subject: [dpdk-dev] [PATCH] doc/guides: mention 17.11 LTS in > contributing/stable

Re: [dpdk-dev] [PATCH] doc: update release note for DPAA2 Event PMD

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: Shreyansh Jain [mailto:shreyansh.j...@nxp.com] > Sent: Thursday, October 26, 2017 3:26 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Mcnamara, John ; > Shreyansh Jain > Subject: [PATCH] doc: update release note for DPAA2 Event PMD > > Signed-off-by: Shrey

Re: [dpdk-dev] [PATCH v2] doc: update mlx5 guide

2017-11-02 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Monday, October 30, 2017 10:58 AM > To: nelio.laranje...@6wind.com; adrien.mazarg...@6wind.com; > ys...@mellanox.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2] doc: update mlx5 guide

Re: [dpdk-dev] [PATCH v2] ring: guarantee ordering of cons/prod loading when doing

2017-11-02 Thread Jerin Jacob
-Original Message- > Date: Thu, 2 Nov 2017 08:43:30 + > From: Jia He > To: jerin.ja...@caviumnetworks.com, dev@dpdk.org, olivier.m...@6wind.com > Cc: konstantin.anan...@intel.com, bruce.richard...@intel.com, > jianbo@arm.com, hemant.agra...@nxp.com, Jia He , > jie2@hxt-semit

[dpdk-dev] [PATCH v2] net/failsafe: fix VLAN stripping configuration

2017-11-02 Thread Ophir Munk
failsafe device has vlan stripping configured at startup however once a sub device is found as non-capable of vlan-stripping failsafe updates it configuration and removes vlan stripping from it. This update occurs only once at startup. Following a later plugin attempt and in case of vlan stripping

Re: [dpdk-dev] [PATCH 1/2] doc: flow classify library prog guide

2017-11-02 Thread Iremonger, Bernard
Hi John, > > Subject: [PATCH 1/2] doc: flow classify library prog guide > > > > This file documents the Flow Classification library, librte_flow_classify. > > > > Updated MAINTAINERS file > > > > Signed-off-by: Bernard Iremonger > > Hi Bernard, > > Thanks for the doc. > > There is a doc buil

Re: [dpdk-dev] [PATCH 2/2] doc: flow classify sample app guide

2017-11-02 Thread Iremonger, Bernard
Hi John, > > Subject: [PATCH 2/2] doc: flow classify sample app guide > > > > This file documents the flow_classify sample application which is used > > to demonstate use of the Flow Classify library, librte_flow_classify. > > > > Updated MAINTAINERS file > > > > Signed-off-by: Bernard Iremonger

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 02, 2017 1:55 AM > > On 11/2/2017 1:03 AM, Mody, Rasesh wrote: > >> From: Stephen Hemminger [mailto:step...@networkplumber.org] > >> Sent: Wednesday, November 01, 2017 7:12 AM > >> > >> On Wed, 1 Nov 2017 06:58:53 +000

Re: [dpdk-dev] [PATCH ] examples/l3fwd: fix aliasing in port grouping

2017-11-02 Thread Prathyusha, Guduri
Hi, Some issue with my mutt command line and hence apologies for unpleasant formatting in the mail. Please see inline From: dev on behalf of Ananyev, Konstantin Sent: Thursday, November 2, 2017 9:22 PM To: Prathyusha, Guduri Cc: dev@dpdk.org; jianbo@arm.c

Re: [dpdk-dev] [PATCH] doc: update failsafe feature list

2017-11-02 Thread Ferruh Yigit
On 11/1/2017 10:53 PM, Matan Azrad wrote: > Hi Ferruh, Gaetan > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Thursday, November 2, 2017 12:34 AM >> To: Matan Azrad ; Gaetan Rivet >> >> Cc: dev@dpdk.org; john.mcnam...@intel.com >> Subject: Re: [dpdk-

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Ferruh Yigit
On 11/2/2017 10:34 AM, Mody, Rasesh wrote: >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Thursday, November 02, 2017 1:55 AM >> >> On 11/2/2017 1:03 AM, Mody, Rasesh wrote: From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Wednesday, November 01, 2017 7:12

[dpdk-dev] [PATCH 2/2] net/mlx4: share memory region resources

2017-11-02 Thread Adrien Mazarguil
Memory regions assigned to hardware and used during Tx/Rx are mapped to mbuf pools. Each Rx queue creates its own MR based on the mempool provided during queue setup, while each Tx queue looks up and registers MRs for all existing mbuf pools instead. Since most applications use few large mbuf pool

[dpdk-dev] [PATCH 1/2] net/mlx4: fix function prototypes

2017-11-02 Thread Adrien Mazarguil
This is done for consistency with the rest of the code. Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") Signed-off-by: Adrien Mazarguil --- drivers/net/mlx4/mlx4_rxq.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/mlx4/mlx4_rxq.c b/d

Re: [dpdk-dev] [PATCH v2] net/enic: fix TSO for packets greater than 9208 bytes

2017-11-02 Thread Ferruh Yigit
On 11/1/2017 10:47 PM, John Daley wrote: > A check was previously added to drop Tx packets greater than what the Nic > is capable of sending since such packets can freeze the send queue. The > check did not account for TSO packets however, so TSO was limited to 9208 > bytes. > > Check packet lengt

Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open

2017-11-02 Thread Mody, Rasesh
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, November 02, 2017 11:10 AM > > On 11/2/2017 10:34 AM, Mody, Rasesh wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Thursday, November 02, 2017 1:55 AM > >> > >> On 11/2/2017 1:03 AM, Mody, Rasesh wrote

Re: [dpdk-dev] [PATCH] net/mrvl: reset errno before library call

2017-11-02 Thread Ferruh Yigit
On 11/2/2017 1:37 AM, Tomasz Duszynski wrote: > In case errno contains some non-zero value and call to strtoul() is > successful -2 error will be returned. > > Setting errno to zero before calling strtoul() makes sure > errors will be handled correctly. > > Fixes: 0ddc9b815b11 ("net/mrvl: add net

Re: [dpdk-dev] [PATCH] net/mlx5: fix segfault due to array overflow

2017-11-02 Thread Ferruh Yigit
On 11/2/2017 6:30 AM, Nelio Laranjeiro wrote: > VLAN id is limited to MLX5_MAX_VLAN_IDS which is not verified by the code > before trying to add a new VLAN filter. > > Fixes: 272733b5ebfd ("net/mlx5: use flow to enable unicast traffic") > > Signed-off-by: Nelio Laranjeiro Applied to dpdk-next-n

  1   2   >