02/11/2017 11:22, Wang, Zhihong: > > I don't know what is creating this drop exactly. > > When doing different tests on different environments, we do not see this > > drop. > > If nobody else can see such issue, I guess we can ignore it. > > Hi Thomas, Xiaoyun, > > With this patch (commit 84cc318424d49372dd2a5fbf3cf84426bf95acce) I see > more than 20% performance drop in vhost loopback test with testpmd > macswap for 256 bytes packets, which means it impacts actual vSwitching > performance. > > Suggest we fix it or revert it for this release.
I think we need more numbers to take a decision. What is the benefit of this patch? In which use-cases? What are the drawbacks? In which use-cases? Please, it is a call to test performance with and without this patch in more environments (CPU, packet size, applications).