Re: [dpdk-dev] [dpdk-users] DPDK16.11.2 LTS: i40e PMD fails to start X710 port

2017-09-07 Thread Li, Xiaoyun
Hi I think DPDK17.08 has fixed this issue. There is a patch in 17.08 which would introduced a delay in i40e_dev_sync_phy_type if getting wrong status. Best Regards, Xiaoyun Li -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Dumitru Ceara Sent: Tuesday, August

Re: [dpdk-dev] [PATCH v4 6/7] mempool: introduce block size align flag

2017-09-07 Thread Olivier MATZ
On Mon, Sep 04, 2017 at 11:15:50PM +0530, santosh wrote: > > On Monday 04 September 2017 09:50 PM, Olivier MATZ wrote: > > On Tue, Aug 15, 2017 at 11:37:42AM +0530, Santosh Shukla wrote: > >> Some mempool hw like octeontx/fpa block, demands block size > >> (/total_elem_sz) aligned object start add

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Dai, Wei
> -Original Message- > From: Dai, Wei > Sent: Wednesday, September 6, 2017 10:52 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix mirror rule reset when port is stopped > > When an i40e PF port is stopped, all mirror r

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Dai, Wei
Hi, Lijuan How about your test result ? > -Original Message- > From: Dai, Wei > Sent: Wednesday, September 6, 2017 10:52 PM > To: Wu, Jingjing ; Xing, Beilei > > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix mirror rule reset when port is stopped > > When

Re: [dpdk-dev] [PATCH v4 6/7] mempool: introduce block size align flag

2017-09-07 Thread santosh
On Thursday 07 September 2017 12:57 PM, Olivier MATZ wrote: > On Mon, Sep 04, 2017 at 11:15:50PM +0530, santosh wrote: >> On Monday 04 September 2017 09:50 PM, Olivier MATZ wrote: >>> On Tue, Aug 15, 2017 at 11:37:42AM +0530, Santosh Shukla wrote: Some mempool hw like octeontx/fpa block, dema

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Tu, LijuanX A
I have tested the patch ,it passed. -Original Message- From: Dai, Wei Sent: Thursday, September 7, 2017 3:36 PM To: Wu, Jingjing ; Xing, Beilei ; Tu, LijuanX A Cc: dev@dpdk.org; sta...@dpdk.org Subject: RE: [PATCH] net/i40e: fix mirror rule reset when port is stopped Hi, Lijuan How abo

Re: [dpdk-dev] [PATCH v5 1/8] mempool: remove unused flags argument

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:27PM +0530, Santosh Shukla wrote: > * Remove redundant 'flags' API description from > - __mempool_generic_put > - __mempool_generic_get > - rte_mempool_generic_put > - rte_mempool_generic_get > > * Remove unused 'flags' argument from > - rte_mempool_generic_

Re: [dpdk-dev] [PATCH v5 2/8] mempool: change flags from int to unsigned int

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:28PM +0530, Santosh Shukla wrote: > mp->flags is int and mempool API writes unsigned int > value in 'flags', so fix the 'flags' data type. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH] app/testpmd: fix forward port ids setting

2017-09-07 Thread Wu, Jingjing
> -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Sunday, September 3, 2017 9:19 PM > To: Wu, Jingjing ; Gaetan Rivet > ; > Thomas Monjalon > Cc: dev@dpdk.org; Ori Kam ; sta...@dpdk.org > Subject: [PATCH] app/testpmd: fix forward port ids setting > > The corr

Re: [dpdk-dev] [PATCH v5 3/8] mempool: add flags arg in xmem size and usage

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:29PM +0530, Santosh Shukla wrote: > @@ -1503,6 +1505,8 @@ size_t rte_mempool_xmem_size(uint32_t elt_num, size_t > total_elt_sz, > * Number of elements in the paddr array. > * @param pg_shift > * LOG2 of the physical pages size. > + * @param flags > + * The

Re: [dpdk-dev] [PATCH v5 4/8] doc: remove mempool notice

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:30PM +0530, Santosh Shukla wrote: > Removed mempool deprecation notice and > updated change info in release_17.11. > > Signed-off-by: Santosh Shukla > Signed-off-by: Jerin Jacob Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v5 3/8] mempool: add flags arg in xmem size and usage

2017-09-07 Thread santosh
On Thursday 07 September 2017 01:16 PM, Olivier MATZ wrote: > On Wed, Sep 06, 2017 at 04:58:29PM +0530, Santosh Shukla wrote: >> @@ -1503,6 +1505,8 @@ size_t rte_mempool_xmem_size(uint32_t elt_num, size_t >> total_elt_sz, >> * Number of elements in the paddr array. >> * @param pg_shift >>

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Wu, Jingjing
> -Original Message- > From: Dai, Wei > Sent: Wednesday, September 6, 2017 10:52 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix mirror rule reset when port is stopped > > When an i40e PF port is stopped, all mirror ru

Re: [dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:31PM +0530, Santosh Shukla wrote: > Allow mempool driver to advertise his pool capability. > For that pupose, an api(rte_mempool_ops_get_capabilities) typo: pupose -> purpose > ... > --- a/lib/librte_mempool/rte_mempool.c > +++ b/lib/librte_mempool/rte_mempool.c > @@

Re: [dpdk-dev] [PATCH v5 6/8] mempool: detect physical contiguous object in pool

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:32PM +0530, Santosh Shukla wrote: > The memory area containing all the objects must be physically > contiguous. > Introducing MEMPOOL_F_CAPA_PHYS_CONTIG flag for such use-case. > > The flag useful to detect whether pool area has sufficient space > to fit all objects.

Re: [dpdk-dev] [PATCH 7/9] net/virtio: rationalize setting of Rx/Tx handlers

2017-09-07 Thread Yuanhan Liu
On Wed, Sep 06, 2017 at 04:40:12PM +0200, Olivier MATZ wrote: > On Fri, Sep 01, 2017 at 08:31:06PM +0800, Yuanhan Liu wrote: > > On Fri, Sep 01, 2017 at 11:52:17AM +0200, Olivier MATZ wrote: > > > > > @@ -1534,7 +1554,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev) > > > > > RTE_BUILD_B

Re: [dpdk-dev] [PATCH v5 7/8] mempool: introduce block size align flag

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:33PM +0530, Santosh Shukla wrote: > --- a/lib/librte_mempool/rte_mempool.h > +++ b/lib/librte_mempool/rte_mempool.h > @@ -271,6 +271,10 @@ struct rte_mempool { > * Note: This flag should not be passed by application. > */ > #define MEMPOOL_F_CAPA_PHYS_CONTIG 0x004

Re: [dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-07 Thread santosh
On Thursday 07 September 2017 01:29 PM, Olivier MATZ wrote: > On Wed, Sep 06, 2017 at 04:58:31PM +0530, Santosh Shukla wrote: >> Allow mempool driver to advertise his pool capability. >> For that pupose, an api(rte_mempool_ops_get_capabilities) > typo: pupose -> purpose v6. >> ... >> --- a/lib/l

Re: [dpdk-dev] [PATCH] app/testpmd: app/testpmd: add device removal command

2017-09-07 Thread Wu, Jingjing
> > > > Since dealing with device is kind of new, it can be OK to create new > > command tree, but there are already hotplug commands per port: > > "port attach #PCI|#VDEV_NAME" > > "port detach #P" > > > > Those two commands deal with the etherdev hotplug API. > The new command should test the rt

Re: [dpdk-dev] [PATCH] app/testpmd: port info prints dynamically mapped flow types

2017-09-07 Thread Wu, Jingjing
> -Original Message- > From: Rybalchenko, Kirill > Sent: Saturday, September 2, 2017 12:23 AM > To: dev@dpdk.org > Cc: Rybalchenko, Kirill ; Chilikin, Andrey > ; Xing, Beilei ; Wu, > Jingjing > > Subject: [PATCH] app/testpmd: port info prints dynamically mapped flow types > > Port info

Re: [dpdk-dev] [PATCH v5 7/8] mempool: introduce block size align flag

2017-09-07 Thread santosh
On Thursday 07 September 2017 01:43 PM, Olivier MATZ wrote: > On Wed, Sep 06, 2017 at 04:58:33PM +0530, Santosh Shukla wrote: >> --- a/lib/librte_mempool/rte_mempool.h >> +++ b/lib/librte_mempool/rte_mempool.h >> @@ -271,6 +271,10 @@ struct rte_mempool { >> * Note: This flag should not be passed

Re: [dpdk-dev] [PATCH v5 8/8] mempool: update range info to pool

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:34PM +0530, Santosh Shukla wrote: > HW pool manager e.g. Octeontx SoC demands s/w to program start and end > address of pool. Currently, there is no such handle in external mempool. > Introducing rte_mempool_update_range handle which will let HW(pool > manager) to know

[dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- This RFC introduces a port representor based model for the control, management and monitoring of SR-IOV virtual function (VF) devices for control plane applications which have bound the devices physic

[dpdk-dev] [PATCH] mk: fix compiling error for atom target

2017-09-07 Thread Xiaoyun Li
GCC thinks target atom doesn't support SSE4.2 and SSE4 is now part of minimum requirements for DPDK on x86. So there are compiling errors when cross-compiling for target atom. And in fact, the atom supports SSE4 now. This patch fixes this issue. Fixes: 5ea4d4688dce ("net/ixgbe: remove fallback cod

[dpdk-dev] [RFC 1/5] Implemented port representor broker infrastructure, created BDF to port function.

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- lib/librte_ether/Makefile | 2 + lib/librte_ether/rte_ethdev.c | 93 ++ lib/librte_ether/rte_ethdev.h | 26 +++ lib/librte_ether/rte_ether_version.map |

[dpdk-dev] [RFC 2/5] added --enable-representor command line argument in EAL to load representor broker infrastructure.

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- lib/librte_eal/bsdapp/eal/eal.c| 6 ++ lib/librte_eal/common/eal_common_options.c | 1 + lib/librte_eal/common/eal_internal_cfg.h | 2 ++ lib/librte_eal/common/eal_options.h

[dpdk-dev] [RFC 4/5] Enable port representor PMD and broker for fortville PMD driver

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/i40e/Makefile| 1 + drivers/net/i40e/i40e_ethdev.c | 17 ++ drivers/net/i40e/i40e_prep_ops.c | 402 +++ drivers/net/i40e/i40e_prep_ops.h |

[dpdk-dev] [RFC 3/5] Implement port representor PMD

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- config/common_base | 5 + drivers/net/Makefile | 2 + drivers/net/representor/Makefile | 51 ++ drivers/net/repres

[dpdk-dev] [RFC 5/5] Enable port representor PMD and broker for ixgbe PMD driver.

2017-09-07 Thread Mohammad Abdul Awal
Signed-off-by: Mohammad Abdul Awal Signed-off-by: Remy Horton Signed-off-by: Declan Doherty --- drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 33 +++-- drivers/net/ixgbe/ixgbe_ethdev.h | 11 ++ drivers/net/ixgbe/ixgbe_prep_ops.c | 279

Re: [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts

2017-09-07 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Wednesday, August 23, 2017 11:45 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts > > The testpmd was doing old BSD

Re: [dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-07 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 01:45:58PM +0530, santosh wrote: > > The API is correct, but the flags should simply be returned, not or-ed. > > I think it should be kept as simple as possible: a function called > > get_somthing() is expected to return it without doing anything else. > > Sorry if I wasn't

Re: [dpdk-dev] [PATCH] app/testpmd:fix invalid port id parameters

2017-09-07 Thread Wu, Jingjing
> -Original Message- > From: Rybalchenko, Kirill > Sent: Monday, September 4, 2017 10:12 PM > To: Li Han ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] app/testpmd:fix invalid port id parameters > > Hi Han, > > > -Original Message- > > From: dev [mailto:dev

Re: [dpdk-dev] [PATCH] net/failsafe: stat support enhancement

2017-09-07 Thread Gaëtan Rivet
On Tue, Sep 05, 2017 at 12:56:34PM +0300, Matan Azrad wrote: > The previous stats code returned only the current TX sub > device stats. > > This enhancement extends it to return the sum of all sub > devices stats with history of removed sub-devices. > > Dedicated stats accumulator saves the stat

Re: [dpdk-dev] [PATCH] mk: fix compiling error for atom target

2017-09-07 Thread Bruce Richardson
On Thu, Sep 07, 2017 at 04:35:17PM +0800, Xiaoyun Li wrote: > GCC thinks target atom doesn't support SSE4.2 and SSE4 is now part of > minimum requirements for DPDK on x86. So there are compiling errors when > cross-compiling for target atom. And in fact, the atom supports SSE4 now. > This patch fix

Re: [dpdk-dev] [PATCH v5 8/8] mempool: update range info to pool

2017-09-07 Thread santosh
On Thursday 07 September 2017 02:00 PM, Olivier MATZ wrote: > On Wed, Sep 06, 2017 at 04:58:34PM +0530, Santosh Shukla wrote: >> HW pool manager e.g. Octeontx SoC demands s/w to program start and end >> address of pool. Currently, there is no such handle in external mempool. >> Introducing rte_mem

Re: [dpdk-dev] [PATCH v5 7/8] mempool: introduce block size align flag

2017-09-07 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 01:57:57PM +0530, santosh wrote: > > On Thursday 07 September 2017 01:43 PM, Olivier MATZ wrote: > > On Wed, Sep 06, 2017 at 04:58:33PM +0530, Santosh Shukla wrote: > >> --- a/lib/librte_mempool/rte_mempool.h > >> +++ b/lib/librte_mempool/rte_mempool.h > >> @@ -271,6 +271,1

[dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal

2017-09-07 Thread Pavan Nikhilesh Bhagavatula
Date: Thu, 7 Sep 2017 14:17:27 +0530 From: Pavan Nikhilesh Bhagavatula To: "Dumitrescu, Cristian" , techbo...@dpdk.org, govbo...@dpdk.org, step...@networkplumber.org, ktray...@redhat.com Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add u64 bit variant for reciprocal User-Agent: Mutt/1.5.24 (2015-0

Re: [dpdk-dev] [PATCH v5 8/8] mempool: update range info to pool

2017-09-07 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 02:26:49PM +0530, santosh wrote: > > On Thursday 07 September 2017 02:00 PM, Olivier MATZ wrote: > > On Wed, Sep 06, 2017 at 04:58:34PM +0530, Santosh Shukla wrote: > >> HW pool manager e.g. Octeontx SoC demands s/w to program start and end > >> address of pool. Currently,

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-09-07 Thread Hemant Agrawal
On 9/4/2017 6:44 PM, santosh wrote: Hi Olivier, On Monday 04 September 2017 05:41 PM, Olivier MATZ wrote: Hi Santosh, On Tue, Aug 15, 2017 at 01:37:17PM +0530, Santosh Shukla wrote: Now that dpdk supports more than one mempool drivers and each mempool driver works best for specific PMD, exam

Re: [dpdk-dev] [PATCH] net/i40e: fix mirror rule reset when port is stopped

2017-09-07 Thread Dai, Wei
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, September 7, 2017 3:51 PM > To: Dai, Wei ; Xing, Beilei > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH] net/i40e: fix mirror rule reset when port is stopped > > > > > -Original Message- > > From: Dai, Wei > >

Re: [dpdk-dev] [PATCH v3 1/2] eal: allow user to override default pool handle

2017-09-07 Thread Hemant Agrawal
On 8/15/2017 1:37 PM, Santosh Shukla wrote: DPDK has support for both sw and hw mempool and currently user is limited to use ring_mp_mc pool. In case user want to use other pool handle, need to update config RTE_MEMPOOL_OPS_DEFAULT, then build and run with desired pool handle. Introducing eal op

Re: [dpdk-dev] [PATCH] mk: fix compiling error for atom target

2017-09-07 Thread Li, Xiaoyun
Hi So I should delete the mk/machine/atm folder and add a new mk/machine/silvermont folder, right? And in silvermont/rte.vars.mk, there is sentence " MACHINE_CFLAGS = -march=silvermont ". The annotation just adds the copy of others like original atm? Another thing, we don't need to create the con

Re: [dpdk-dev] [PATCH v4] ethdev: allow returning error on VLAN offload configuration

2017-09-07 Thread Hemant Agrawal
On 9/1/2017 6:24 PM, David Harton (dharton) wrote: -Original Message- From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] Sent: Friday, September 01, 2017 3:41 AM Subject: Re: [PATCH v4] ethdev: allow returning error on VLAN offload configuration On 9/1/2017 8:06 AM, David Harton wro

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-09-07 Thread Alejandro Lucero
I understand this is the representor idea suiting Intel cards but it does not cover other possibilities. At least, Netronome and Mellanox require a representor not just for controlling a VF, but also for sending and receiving packets through the representor PMD. I sent an abstract for a presentat

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-09-07 Thread santosh
Hi Hemant, On Thursday 07 September 2017 02:51 PM, Hemant Agrawal wrote: > On 9/4/2017 6:44 PM, santosh wrote: >> Hi Olivier, >> >> >> On Monday 04 September 2017 05:41 PM, Olivier MATZ wrote: >>> Hi Santosh, >>> >>> On Tue, Aug 15, 2017 at 01:37:17PM +0530, Santosh Shukla wrote: Now that dp

Re: [dpdk-dev] [PATCH] mk: fix compiling error for atom target

2017-09-07 Thread Bruce Richardson
On Thu, Sep 07, 2017 at 10:31:17AM +0100, Li, Xiaoyun wrote: > Hi > So I should delete the mk/machine/atm folder and add a new > mk/machine/silvermont folder, right? > And in silvermont/rte.vars.mk, there is sentence " MACHINE_CFLAGS = > -march=silvermont ". > The annotation just adds the copy of

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-09-07 Thread santosh
On Thursday 07 September 2017 03:36 PM, santosh wrote: > Hi Hemant, > > > On Thursday 07 September 2017 02:51 PM, Hemant Agrawal wrote: >> On 9/4/2017 6:44 PM, santosh wrote: >>> Hi Olivier, >>> >>> >>> On Monday 04 September 2017 05:41 PM, Olivier MATZ wrote: Hi Santosh, On Tue, A

Re: [dpdk-dev] [PATCH v3 2/2] ethdev: allow pmd to advertise pool handle

2017-09-07 Thread Hemant Agrawal
On 9/7/2017 3:41 PM, santosh wrote: On Thursday 07 September 2017 03:36 PM, santosh wrote: Hi Hemant, On Thursday 07 September 2017 02:51 PM, Hemant Agrawal wrote: On 9/4/2017 6:44 PM, santosh wrote: Hi Olivier, On Monday 04 September 2017 05:41 PM, Olivier MATZ wrote: Hi Santosh, On T

[dpdk-dev] [PATCH v2 0/6] GPT-C and GTP-U enabling

2017-09-07 Thread Beilei Xing
This patch set enables RSS/FDIR/cloud filter for GPT-C and GTP-U. It depends on Kirill's patch: http://www.dpdk.org/dev/patchwork/patch/28294/ v2 changes: - Enable RSS/FDIR/cloud filter dinamicly by checking profile - Add GTPC and GTPU items to distinguish rule for GTP-C or GTP-U - Rework FDIR/

[dpdk-dev] [PATCH v2 4/6] net/i40e: add FDIR support for GTP-C and GTP-U

2017-09-07 Thread Beilei Xing
This patch adds FDIR support for GTP-C and GTP-U. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 1 + drivers/net/i40e/i40e_ethdev.h | 11 +++ drivers/net/i40e/i40e_fdir.c | 170 +++-- drivers/net/i40e/i40e_flow.c | 165

[dpdk-dev] [PATCH v2 3/6] net/i40e: finish integration FDIR with generic flow API

2017-09-07 Thread Beilei Xing
rte_eth_fdir_* structures are still used in FDIR functions. This patch adds i40e private FDIR related structures and functions to finish integration FDIR with generic flow API. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 94 +++- drivers/net/i40e/i40e_fdir.c | 490

[dpdk-dev] [PATCH v2 6/6] net/i40e: enable cloud filter for GTP-C and GTP-U

2017-09-07 Thread Beilei Xing
GTP-C & GTP-U are not supported by cloud filter due to limited resource of HW, this patch enables GTP-C and GTP-U cloud filter by replacing inner_mac and TUNNEL_KEY. This configuration will be set when adding GTP-C or GTP-U filter rules, and it will be invalid only by NIC core reset. Signed-off-by

[dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items

2017-09-07 Thread Beilei Xing
This patch adds GTPC and GTPU items to generic rte flow, and also exposes the following item fields through the flow command: - GTPC TEID - GTPU TEID Signed-off-by: Beilei Xing --- app/test-pmd/cmdline_flow.c | 44 + app/test-pmd/config.c

[dpdk-dev] [PATCH v2 5/6] net/i40e: add cloud filter parsing function for GTP

2017-09-07 Thread Beilei Xing
This patch adds i40e_flow_parse_gtp_filter parsing function for GTP-C and GTP-U. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.h | 2 + drivers/net/i40e/i40e_flow.c | 142 + 2 files changed, 144 insertions(+) diff --git a/drivers/net/i40

[dpdk-dev] [PATCH v2 1/6] net/i40e: support RSS for GTP-C and GTP-U

2017-09-07 Thread Beilei Xing
GTP-C and GTP-U are supported by new profile. Enable RSS for GTP-C and GTP-U after downloading profile. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev.c | 168 drivers/net/i40e/i40e_ethdev.h | 21 + drivers/net/i40e/rte_pmd_i40e.c |

[dpdk-dev] [PATCH v2] net/failsafe: stat support enhancement

2017-09-07 Thread Matan Azrad
The previous stats code returned only the current TX sub device stats. This enhancement extends it to return the sum of all sub devices stats with history of removed sub-devices. Dedicated stats accumulator saves the stat history of all sub device remove events. Each failsafe sub device contains

[dpdk-dev] [PATCH v2] examples/l2fwd-cat: fix build according to API changes

2017-09-07 Thread Vladimir Kuramshin
Current version is compatible with PQOS version 1.3 but not compatible with higher versions. This change makes l2fwd-cat example compatible with versions since 1.4 Signed-off-by: Vladimir Kuramshin --- Version 2 changes: fixed checkpatch warnings "Prefer 'unsigned int *' to bare use of 'unsigned

[dpdk-dev] [PATCH] crypto/aesni_mb: fix invalid session error

2017-09-07 Thread Sergio Gonzalez Monroy
Setting an invalid session in the crypto op results in SEGFAULT because the JOB user_data was never set to the crypto op. Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") Signed-off-by: Sergio Gonzalez Monroy --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 7 +-- 1 fil

Re: [dpdk-dev] [PATCH 01/21] Revert "vhost: workaround MQ fails to startup"

2017-09-07 Thread Yuanhan Liu
On Thu, Aug 31, 2017 at 11:50:03AM +0200, Maxime Coquelin wrote: > This reverts commit 04d81227960b5c1cf2f11f492100979ead20c526. > > As agreed when this workaround was introduced, it can be reverted > as Qemu v2.10 that fixes the issue is now out. First of all, I'm very sorry for being so late on

Re: [dpdk-dev] [PATCH v4] ethdev: allow returning error on VLAN offload configuration

2017-09-07 Thread David Harton (dharton)
> -Original Message- > From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > > On 9/1/2017 6:24 PM, David Harton (dharton) wrote: > > > >> -Original Message- > >> From: Hemant Agrawal [mailto:hemant.agra...@nxp.com] > >> > >> On 9/1/2017 8:06 AM, David Harton wrote: > >>> Some de

[dpdk-dev] [PATCH v2 00/10] virtio fixes

2017-09-07 Thread Olivier Matz
This patchset addresses several issues related to offload and Rx/Tx handler selection in virtio PMD. v1 -> v2: - add one patch to remove uneeded SSE check on x86 - remove Cc stable on last patches - inline virtio_update_rxtx_handler() in tx queue setup Olivier Matz (10): net/virtio: revert "do

[dpdk-dev] [PATCH v2 10/10] net/virtio: fix Rx handler when checksum is requested

2017-09-07 Thread Olivier Matz
The simple Rx handler is selected even if Rx checksum offload is requested by the application, but this handler does not support offloads. This results in broken received packets (no checksum flag but invalid checksum in the mbuf data). Disable the simple Rx handler in that case. Fixes: 96cb67119

[dpdk-dev] [PATCH v2 02/10] net/virtio: revert "do not falsely claim to do IP checksum"

2017-09-07 Thread Olivier Matz
This reverts commit 4dab342b7522 ("net/virtio: do not falsely claim to do IP checksum"). The description of rxmode->hw_ip_checksum is: hw_ip_checksum : 1, /**< IP/UDP/TCP checksum offload enable. */ Despite its name, this field can be set by an application to enable L3 and L4 checksums. I

[dpdk-dev] [PATCH v2 03/10] doc: fix description of L4 Rx checksum offload

2017-09-07 Thread Olivier Matz
As described in API documentation, the field hw_ip_checksum requests both L3 and L4 offload. Fixes: dad1ec72a377 ("doc: document NIC features") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- doc/guides/nics/features.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/fe

[dpdk-dev] [PATCH v2 01/10] net/virtio: revert "do not claim to support LRO"

2017-09-07 Thread Olivier Matz
This reverts commit 701a64622c26 ("net/virtio: do not claim to support LRO") Setting rxmode->enable_lro is a way to tell the host that the guest is ok to receive tso packets. From the guest point of view, it is like enabling LRO on a physical driver. Fixes: 701a64622c26 ("net/virtio: do not claim

[dpdk-dev] [PATCH v2 04/10] net/virtio: fix log levels in configure

2017-09-07 Thread Olivier Matz
On error, we should log with error level. Fixes: 9f4f2846ef76 ("virtio: support vlan filtering") Fixes: 86d59b21468a ("net/virtio: support LRO") Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload") Cc: sta...@dpdk.org Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v2 06/10] net/virtio: fix queue setup consistency

2017-09-07 Thread Olivier Matz
In rx/tx queue setup functions, some code is executed only if use_simple_rxtx == 1. The value of this variable can change depending on the offload flags or sse support. If Rx queue setup is called before Tx queue setup, it can result in an invalid configuration: - dev_configure is called: use_simp

[dpdk-dev] [PATCH v2 09/10] net/virtio: keep Rx handler whatever the Tx queue config

2017-09-07 Thread Olivier Matz
Split use_simple_rxtx into use_simple_rx and use_simple_tx, and ensure that only use_simple_tx is updated when txq flags forces to use the standard Tx handler. This change is also useful for next commit (disable simple Rx path when Rx checksum is requested). Signed-off-by: Olivier Matz --- driv

[dpdk-dev] [PATCH v2 07/10] net/virtio: rationalize setting of Rx/Tx handlers

2017-09-07 Thread Olivier Matz
The selection of Rx/Tx handlers is done at several places, group them in one function set_rxtx_funcs(). The update of hw->use_simple_rxtx is also rationalized: - initialized to 1 (prefer simple path) - in dev configure or rx/tx queue setup, if something prevents from using the simple path, chang

[dpdk-dev] [PATCH v2 08/10] net/virtio: remove SSE check

2017-09-07 Thread Olivier Matz
Since commit f27769f796a0 ("mk: require SSE4.2 support on all x86 platforms"), SSE4.2 is a requirement when compiling on x86 platforms. We can remove this check in the virtio driver. Signed-off-by: Olivier Matz --- drivers/net/virtio/virtio_ethdev.c | 5 + 1 file changed, 1 insertion(+), 4

[dpdk-dev] [PATCH v2 05/10] net/virtio: fix mbuf port for simple Rx function

2017-09-07 Thread Olivier Matz
The mbuf->port was was not properly set for the first received mbufs. Fix this by setting it in virtqueue_enqueue_recv_refill_simple(), which is used to enqueue the first mbuf in the ring. The function virtio_rxq_rearm_vec(), which is used to rearm the ring with new mbufs, is correct and does not

Re: [dpdk-dev] [PATCH v2] net/failsafe: stat support enhancement

2017-09-07 Thread Gaëtan Rivet
Hi Matan, You should send your v[N] In-Reply-To the Message-Id of your v[N-1] to help people reading. On Thu, Sep 07, 2017 at 02:31:13PM +0300, Matan Azrad wrote: > The previous stats code returned only the current TX sub > device stats. > > This enhancement extends it to return the sum of all s

Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items

2017-09-07 Thread Adrien Mazarguil
Hi Beilei, I assume this patch supersedes [1]? [1] http://dpdk.org/ml/archives/dev/2017-August/073501.html Thanks for merging testpmd and the API change as a single patch, I still have a few comments, see below. (please add "flow API" somewhere in the title by the way) On Thu, Sep 07, 2017 at

[dpdk-dev] [PATCH 1/2] ring: increase maximum ring size

2017-09-07 Thread Olivier Matz
There is no reason to prevent ring from beeing larger than 0x0FFF. Increase the maximum size to 0x7FFF, which is the maximum possible without changing the code and the structure definition (size is stored on a uint32_t). Link: http://dpdk.org/ml/archives/dev/2017-September/074701.html Sug

[dpdk-dev] [PATCH 2/2] test/ring: do not mask result of enqueue or dequeue

2017-09-07 Thread Olivier Matz
The define RTE_RING_SZ_MASK is the maximum size supported by the rte_ring. The size is checked at ring creation. There is no reason today to mask the result of rte_ring_sp_enqueue_burst() or rte_ring_sc_dequeue_burst() with this value. The flag RTE_RING_QUOT_EXCEED was previously included in the r

[dpdk-dev] [PATCH v4] net/mlx5: support upstream rdma-core

2017-09-07 Thread Shachar Beiser
This removes the dependency on specific Mellanox OFED libraries by using the upstream rdma-core and linux upstream community code. --- a. Compile with rdma-core commit f11292efd541 ("Merge pull request #202") b. Tested with linux kernel 4.13-rc4 c. For performance testing recommended to wait till

Re: [dpdk-dev] [PATCH 01/21] Revert "vhost: workaround MQ fails to startup"

2017-09-07 Thread Maxime Coquelin
Hi Yuanhan, On 09/07/2017 01:54 PM, Yuanhan Liu wrote: On Thu, Aug 31, 2017 at 11:50:03AM +0200, Maxime Coquelin wrote: This reverts commit 04d81227960b5c1cf2f11f492100979ead20c526. As agreed when this workaround was introduced, it can be reverted as Qemu v2.10 that fixes the issue is now out.

Re: [dpdk-dev] [RFC 0/5] Port Representor for control and monitoring of VF devices

2017-09-07 Thread Declan Doherty
On 07/09/2017 11:01 AM, Alejandro Lucero wrote: I understand this is the representor idea suiting Intel cards but it does not cover other possibilities. At least, Netronome and Mellanox require a representor not just for controlling a VF, but also for sending and receiving packets through the re

[dpdk-dev] [PATCH] cmdline: fix warning for unused return value

2017-09-07 Thread Bruce Richardson
When DPDK is compiled on Ubuntu with extra warnings turned on, there is a warning about the return value from write() being unchecked. Rather than having builds disable the warning, which may mask other cases we do care about, we can add a dummy use of the return value in the code to silence it in

Re: [dpdk-dev] [PATCH 03/21] vhost: protect virtio_net device struct

2017-09-07 Thread Yuanhan Liu
On Thu, Aug 31, 2017 at 11:50:05AM +0200, Maxime Coquelin wrote: > virtio_net device might be accessed while being reallocated > in case of NUMA awareness. >From data path? data path won't be enabled until all are ready, which is at a stage after numa_realloc(). Or, am I miss something? -

[dpdk-dev] [PATCH] eal: cleanup strerror function

2017-09-07 Thread Bruce Richardson
When compiled on Ubuntu with extra warnings enabled, the rte_strerror() function triggered a warning about an unused return value from strerror_r(). Rather than always have this warning disabled, we fix this, and in the process do some cleanup of the code so as to reduce the complexity of the fix,

Re: [dpdk-dev] [PATCH] cmdline: fix warning for unused return value

2017-09-07 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 02:09:23PM +0100, Bruce Richardson wrote: > When DPDK is compiled on Ubuntu with extra warnings turned on, there is a > warning about the return value from write() being unchecked. Rather than > having builds disable the warning, which may mask other cases we do care > about

Re: [dpdk-dev] [PATCH 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-07 Thread Bruce Richardson
On Wed, Sep 06, 2017 at 05:18:46PM +0100, Bruce Richardson wrote: > On Mon, Sep 04, 2017 at 02:51:01PM +0100, Bruce Richardson wrote: > > On Mon, Sep 04, 2017 at 02:36:42PM +0100, Van Haaren, Harry wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce > > > > Richardson Sent: Fr

[dpdk-dev] [dpdk-announce] DPDK 17.05.2 released

2017-09-07 Thread Yuanhan Liu
Hi all, Here is a new stable release: http://fast.dpdk.org/rel/dpdk-17.05.2.tar.xz The git tree is at: http://dpdk.org/browse/dpdk-stable/ Note that it's the last stable release for 17.05. And actually, v17.05.1 was supposed to be the last one as general. However, there was a fatal b

Re: [dpdk-dev] [PATCH 03/21] vhost: protect virtio_net device struct

2017-09-07 Thread Maxime Coquelin
On 09/07/2017 03:44 PM, Yuanhan Liu wrote: On Thu, Aug 31, 2017 at 11:50:05AM +0200, Maxime Coquelin wrote: virtio_net device might be accessed while being reallocated in case of NUMA awareness. From data path? data path won't be enabled until all are ready, which is at a stage after numa_r

[dpdk-dev] [PATCH 1/2] eal: move bitmap from lib sched

2017-09-07 Thread Pavan Nikhilesh
The librte_sched uses rte_bitmap to manage large arrays of bits in an optimized method so, moving it to eal/common would allow other libraries and applications to use it. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/Makefile | 1 + .../common/include}/rte_bitmap

[dpdk-dev] [PATCH 2/2] test: add test for bitmap operations

2017-09-07 Thread Pavan Nikhilesh
This patch adds a test for verifying the bitmap operations. Signed-off-by: Pavan Nikhilesh --- test/test/Makefile | 1 + test/test/test_bitmap.c | 192 2 files changed, 193 insertions(+) create mode 100644 test/test/test_bitmap.c diff --g

Re: [dpdk-dev] [PATCH v4] net/mlx5: support upstream rdma-core

2017-09-07 Thread Nélio Laranjeiro
On Thu, Sep 07, 2017 at 12:55:11PM +, Shachar Beiser wrote: > This removes the dependency on specific Mellanox OFED libraries by > using the upstream rdma-core and linux upstream community code. > > --- > a. Compile with rdma-core commit f11292efd541 ("Merge pull request #202") > b. Tested wit

[dpdk-dev] [PATCH v6 0/8] Infrastructure to support octeontx HW mempool manager

2017-09-07 Thread Santosh Shukla
v6: Include v5 review change, suggested by Olivier. Patches rebased on tip, commit:06791a4bcedf v5: Includes v4 review change, suggested by Olivier. v4: Include - mempool deprecation changes, refer [1], - patches are rebased against v17.11-rc0. In order to support octeontx HW mempool manager, t

[dpdk-dev] [PATCH v6 1/8] mempool: remove unused flags argument

2017-09-07 Thread Santosh Shukla
* Remove redundant 'flags' API description from - __mempool_generic_put - __mempool_generic_get - rte_mempool_generic_put - rte_mempool_generic_get * Remove unused 'flags' argument from - rte_mempool_generic_put - rte_mempool_generic_get Signed-off-by: Santosh Shukla Signed-off-by: J

[dpdk-dev] [PATCH v6 3/8] mempool: add flags arg in xmem size and usage

2017-09-07 Thread Santosh Shukla
xmem_size and xmem_usage need to know the status of mempool flags, so add 'flags' arg in _xmem_size/usage() api. Following patch will make use of that. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob --- v5 --> v6: - Fix 'flags' typo (Suggested by Olivier). v4 --> v5: - Removed 'mp' p

[dpdk-dev] [PATCH v6 2/8] mempool: change flags from int to unsigned int

2017-09-07 Thread Santosh Shukla
mp->flags is int and mempool API writes unsigned int value in 'flags', so fix the 'flags' data type. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by: Olivier Matz --- lib/librte_mempool/rte_mempool.c | 4 ++-- lib/librte_mempool/rte_mempool.h | 2 +- 2 files changed, 3 insert

[dpdk-dev] [PATCH v6 5/8] mempool: get the mempool capability

2017-09-07 Thread Santosh Shukla
Allow the mempool driver to advertise his pool capabilities. For that pupose, an api(rte_mempool_ops_get_capabilities) and ->get_capabilities() handler has been introduced. - Upon ->get_capabilities() call, mempool driver will advertise his capabilities to mempool flags param. Signed-off-by: Santo

[dpdk-dev] [PATCH v6 6/8] mempool: detect physical contiguous object in pool

2017-09-07 Thread Santosh Shukla
The memory area containing all the objects must be physically contiguous. Introducing MEMPOOL_F_CAPA_PHYS_CONTIG flag for such use-case. The flag useful to detect whether pool area has sufficient space to fit all objects. If not then return -ENOSPC. This way, we make sure that all object within a

[dpdk-dev] [PATCH v6 4/8] doc: remove mempool notice

2017-09-07 Thread Santosh Shukla
Removed mempool deprecation notice and updated change info in release_17.11. Signed-off-by: Santosh Shukla Signed-off-by: Jerin Jacob Acked-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 9 - doc/guides/rel_notes/release_17_11.rst | 7 +++ 2 files changed, 7 insertio

[dpdk-dev] [PATCH v6 7/8] mempool: introduce block size align flag

2017-09-07 Thread Santosh Shukla
Some mempool hw like octeontx/fpa block, demands block size (/total_elem_sz) aligned object start address. Introducing an MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS flag. If this flag is set: - Align object start address(vaddr) to a multiple of total_elt_sz. - Allocate one additional object. Additional ob

[dpdk-dev] [PATCH v6 8/8] mempool: notify memory area to pool

2017-09-07 Thread Santosh Shukla
HW pool manager e.g. Octeontx SoC demands s/w to program start and end address of pool. Currently, there is no such api in external mempool. Introducing rte_mempool_ops_register_memory_area api which will let HW(pool manager) to know when common layer selects hugepage: For each hugepage - Notify it

Re: [dpdk-dev] [PATCH v2] mbuf: use refcnt = 0 when debugging

2017-09-07 Thread Chas Williams
On Wed, 2017-09-06 at 14:53 +, Ananyev, Konstantin wrote: > > > -Original Message- > > From: Chas Williams [mailto:3ch...@gmail.com] > > Sent: Wednesday, September 6, 2017 2:56 PM > > To: Ananyev, Konstantin ; Nicolau, Radu > > ; dev@dpdk.org > > Cc: olivier.m...@6wind.com; cw8...@att

Re: [dpdk-dev] [dpdk-dev, 01/17] build: add initial infrastructure for meson & ninja builds

2017-09-07 Thread Neil Horman
On Fri, Sep 01, 2017 at 11:04:00AM +0100, Bruce Richardson wrote: > To build with meson and ninja, we need some initial infrastructure in > place. The build files for meson always need to be called "meson.build", > and options get placed in meson_options.txt > > This commit adds a top-level meson.

Re: [dpdk-dev] [dpdk-dev, 02/17] eal: add eal library to meson build

2017-09-07 Thread Neil Horman
On Fri, Sep 01, 2017 at 11:04:01AM +0100, Bruce Richardson wrote: > Support building the EAL with meson and ninja. This involves a number of > different meson.build files for iterating through all the different > subdirectories in the EAL. The library itself will be compiled on build but > the head

  1   2   >