On Wed, Sep 06, 2017 at 04:58:33PM +0530, Santosh Shukla wrote: > --- a/lib/librte_mempool/rte_mempool.h > +++ b/lib/librte_mempool/rte_mempool.h > @@ -271,6 +271,10 @@ struct rte_mempool { > * Note: This flag should not be passed by application. > */ > #define MEMPOOL_F_CAPA_PHYS_CONTIG 0x0040 > +/** > + * Align object start address to total elem size > + */ > +#define MEMPOOL_F_BLK_ALIGNED_OBJECTS 0x0080
Same than with the other flag: since the meaning of this flag is not obvious when we read the name, it has to be clearly described. - say that it's virtual address - say that it implies MEMPOOL_F_CAPA_PHYS_CONTIG - say that it can be advertised by a driver and the application should not pass it And, since it shall not be passed by an application, I suggest to add _CAPA too (i.e. MEMPOOL_F_CAPA_BLK_ALIGNED_OBJECTS).