[dpdk-dev] [PATCH] lib/librte_pipeline:fix the array index out of bound

2017-08-23 Thread Rongqiang XIE
In function rte_pipeline_compute_masks(), the value pos equal p->entries[i]->action,type constraint p->entries[i]->action is [0,4],but array action_mask1 size is 4,it possible attempt to access element 4 of array action_mask1.And also in function rte_pipeline_run(),it possible attempt to access ele

[dpdk-dev] [PATCH] net/mlx5: extend debug logs verbosity

2017-08-23 Thread Shahaf Shuler
Extend debug logs verbosity by printing the full completion with error along with the entire txq in case of error. For the Rx case no logs were added since such errors are counted and recovered by the Rx data path. Such prints are essential to understand the root cause for the error. Signed-off-b

[dpdk-dev] [PATCH 1/2] net/mlx5: fix num seg assumption on vPMD

2017-08-23 Thread Shahaf Shuler
vPMD Tx function assumes that after the scatter of the multi-segment packets the next packet will be a single segment packet. This is not current as the function can return due to lack of resources without sending all of the multi-segment mbufs sequence. Fixes: 6cb559d67b83 ("net/mlx5: add vector

[dpdk-dev] [PATCH 2/2] net/mlx5: enforce Tx num of segments limitation

2017-08-23 Thread Shahaf Shuler
Mellanox NICs has a limitation on the number of mbuf segments a multi segment mbuf can have. The max number depends on the Tx offloads requested. The current code not enforce such limitation, which might cause malformed WQEs to be written to the device. This commit adds verification for the numbe

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Thomas Monjalon
23/08/2017 04:55, David Harton: > rte_eth_stats_get() unconditonally would set rx_nombuf > even if the device was setting the value. A check has > been added in rte_eth_stats_get() to leave the device > value in-tact when non-zero. If we get this counter from stats->rx_nombuf, why keeping dev->da

Re: [dpdk-dev] [PATCH] lib/lib_eal:add mellanox kernel driver type

2017-08-23 Thread Gaëtan Rivet
Hi, On Wed, Aug 23, 2017 at 10:48:01AM +0800, Rongqiang XIE wrote: > When use bond function in mellanox driver environment, we call the > find_port_id_by_pci_addr() function,if we don't add mellanox kernel > driver type in enum rte_kernel_driver, the function will return -1 > because kdrv unknown,

[dpdk-dev] [PATCH v2 1/8] net/mlx5: avoid reusing old queue's mbuf on reconfigure

2017-08-23 Thread Nelio Laranjeiro
This patch prepare the merge of fake mbuf allocation needed by the vector code with rxq_alloc_elts() where all mbuf of the queues should be allocated. Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_rxq.c | 23 +++ 1 file changed, 3 insertion

[dpdk-dev] [PATCH v2 2/8] net/mlx5: prepare vector Rx ring at setup time

2017-08-23 Thread Nelio Laranjeiro
To use the vector, it needs to add to the PMD Rx mbuf ring four extra mbuf to avoid memory corruption. This additional mbuf are added on dev_start() whereas all other mbuf are allocated on queue setup. This patch brings this allocation back to the same place as other mbuf allocation. Signed-off-

[dpdk-dev] [PATCH v2 3/8] net/mlx5: cleanup Rx ring in free functions

2017-08-23 Thread Nelio Laranjeiro
Vector PMD returns buffers to the application without setting the pointers in the Rx queue to null nor allocating them. When the PMD cleanup the ring it needs to take a special care to those pointers to not free the mbufs before the application have used them nor if the application have already fr

[dpdk-dev] [PATCH v2 0/8] net/mlx5: cleanups

2017-08-23 Thread Nelio Laranjeiro
This Series make some cleanup in mlx5 PMD by removing useless code or non working code. Changes in v2: - update mlx5 feature list to remove the multi process awareness. Nelio Laranjeiro (8): net/mlx5: avoid reusing old queue's mbuf on reconfigure net/mlx5: prepare vector Rx ring at setup ti

[dpdk-dev] [PATCH v2 4/8] net/mlx5: remove flow drop useless if branches

2017-08-23 Thread Nelio Laranjeiro
Those two if statements are useless as there is a verification on the drop field of the flow to jump to the end of the function just above. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5_flow.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net

[dpdk-dev] [PATCH v2 6/8] net/mlx5: fix non working secondary process by removing it

2017-08-23 Thread Nelio Laranjeiro
Secondary process is a copy/paste of the mlx4 drivers, it was never tested and it even segfault at the secondary process start in the mlx5_pci_probe(). This makes more sense to wipe this non working feature to re-write a working and functional version. Fixes: a48deada651b ("mlx5: allow operation

[dpdk-dev] [PATCH v2 7/8] net/mlx5: remove multiple drop RSS queues

2017-08-23 Thread Nelio Laranjeiro
Since MLNX_OFED 4.1 this code is no more useful. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/Makefile| 5 drivers/net/mlx5/mlx5_flow.c | 55 ++-- 2 files changed, 17 insertions(+), 43 deletions(-) diff --git a/d

[dpdk-dev] [PATCH v2 8/8] net/mlx5: remove old MLNX_OFED 3.3 verification

2017-08-23 Thread Nelio Laranjeiro
This version of MLNX_OFED is no more supported. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 2392be5..e89aba8 100644 --- a/drivers/net/mlx5/mlx5

[dpdk-dev] [PATCH v2 5/8] net/mlx5: remove pdentic pragma

2017-08-23 Thread Nelio Laranjeiro
Those are useless since DPDK headers have been cleaned up. Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c | 7 --- drivers/net/mlx5/mlx5.h | 7 --- drivers/net/mlx5/mlx5_ethdev.c | 7 --- drivers/net/mlx5/mlx5_fdir

[dpdk-dev] [PATCH 0/3] remove unused code of DPDK version

2017-08-23 Thread Beilei Xing
Since there's no specific version number to distinguish DPDK pf and Linux kernel pf, DPDK vf won't recognize if host is DPDK pf or kernel pf. The specific virtual channel commands for DPDK pf and code of DPDK version can be deleted. Beilei Xing (3): net/i40e: remove virtual channel command for V

[dpdk-dev] [PATCH 2/3] net/i40e: remove virtual channel command for VSI queue

2017-08-23 Thread Beilei Xing
This patch removes specific virtual channel command VIRTCHNL_OP_CONFIG_VSI_QUEUES_EXT. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev_vf.c | 69 + drivers/net/i40e/i40e_pf.c| 72 --- drivers/net/i40e/i40

[dpdk-dev] [PATCH 1/3] net/i40e: remove virtual channel command for VLAN pvid

2017-08-23 Thread Beilei Xing
Since there's no specific version number to distinguish DPDK pf and Linux kernel pf, DPDK vf won't recognize if host is DPDK pf or kernel pf. The specific virtual channel commands for DPDK pf can be deleted. This patch removes I40E_VIRTCHNL_OP_CFG_VLAN_PVID. Signed-off-by: Beilei Xing --- driver

[dpdk-dev] [PATCH 3/3] net/i40e: remove DPDK PF version specific code

2017-08-23 Thread Beilei Xing
This patch removes unused code related to DPDK PF version. Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_ethdev_vf.c | 54 --- drivers/net/i40e/i40e_pf.h| 9 --- 2 files changed, 10 insertions(+), 53 deletions(-) diff --git a/drivers/net/i

Re: [dpdk-dev] [PATCH] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-23 Thread Bruce Richardson
On Tue, Aug 22, 2017 at 09:55:53AM -0700, Stephen Hemminger wrote: > On Mon, 21 Aug 2017 19:33:45 +0200 > Markus Theil wrote: > > > This patch adds MSI IRQ mode and in a way, that should > > also work on older kernel versions. The base for my patch > > was an attempt to do this in cf705bc36c whic

[dpdk-dev] [PATCH] net/enic:fix no return value bug

2017-08-23 Thread Rongqiang XIE
In enic_alloc_consistent() function, if the value mze malloc faile, !mze is true, free the rz should return NULL. Signed-off-by: Rongqiang XIE --- drivers/net/enic/enic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 40

Re: [dpdk-dev] [PATCH] igb_uio: MSI IRQ mode, irq enable/disable refactored

2017-08-23 Thread Bruce Richardson
On Wed, Aug 23, 2017 at 09:47:35AM +0100, Bruce Richardson wrote: > On Tue, Aug 22, 2017 at 09:55:53AM -0700, Stephen Hemminger wrote: > > On Mon, 21 Aug 2017 19:33:45 +0200 > > Markus Theil wrote: > > > > > This patch adds MSI IRQ mode and in a way, that should > > > also work on older kernel ve

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Olivier MATZ
Hello, On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > > While doing code for Hyper-V, noticed that the virtio driver was > > confused about receive versus transmit offloads. The virtio > > checksum offload is L4

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: support device removal event

2017-08-23 Thread Nélio Laranjeiro
Hi Matan, On Sun, Aug 13, 2017 at 03:25:11PM +0300, Matan Azrad wrote: > Extend the LSC event handling to support the device removal as well. > The Verbs library may send several related events, which are > different from LSC event. > > The mlx5 event handling has been made capable of receiving a

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: fix probe failure report

2017-08-23 Thread Nélio Laranjeiro
On Sun, Aug 13, 2017 at 03:25:12PM +0300, Matan Azrad wrote: > The corrupted code doesn't return error when probe function > fails due to error in device mac address getting. > By this way, the probe function may return success even if the > ETH dev is not allocated. > > Hence, the probe caller, f

Re: [dpdk-dev] [PATCH v2 0/8] net/mlx5: cleanups

2017-08-23 Thread Ferruh Yigit
On 8/23/2017 9:15 AM, Nelio Laranjeiro wrote: > This Series make some cleanup in mlx5 PMD by removing useless code or non > working code. > > Changes in v2: > > - update mlx5 feature list to remove the multi process awareness. > > Nelio Laranjeiro (8): > net/mlx5: avoid reusing old queue's mb

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix mapping of user priority to TC

2017-08-23 Thread Ferruh Yigit
On 8/21/2017 8:50 AM, Wei Dai wrote: > This patch fixes the mapping of user priority to traffic class > in Rx/Tx path of DCB configuration. Each DCB traffic class > should include all user priorities mapping to it in both Rx and > Tx path. > > Fixes: 0807f80d35d0 ("ixgbe: DCB / flow control") > Cc

Re: [dpdk-dev] [PATCH] ixgbe: initialize scattered_rx during dev_configure

2017-08-23 Thread Ananyev, Konstantin
Hi David, > > An application may want to manipulate the MTU settings of > a device without having to start the device first. > In order to remove the need to start the device the > ixgbe/ixgbevf drivers need to initialize the scattered_rx > value during dev_configure. Not sure how that would hel

Re: [dpdk-dev] [PATCH] net/ixgbe:fix some bugs about rte zmalloc memory may NULL

2017-08-23 Thread Ferruh Yigit
On 8/22/2017 12:49 PM, Rongqiang XIE wrote: > In the function ixgbe_flow_create(), the value ntuple_filter_ptr, > ethertype_filter_ptr,syn_filter_ptr,fdir_rule_ptr and l2_tn_filter_ptr > use rte_zmalloc() malloc memory may return NULL,so, we should > add judge the return is NULL or success. > > Si

Re: [dpdk-dev] [PATCH] net/ixgbe:fix some bugs about rte zmalloc memory may NULL

2017-08-23 Thread Ferruh Yigit
On 8/23/2017 11:36 AM, Ferruh Yigit wrote: > On 8/22/2017 12:49 PM, Rongqiang XIE wrote: >> In the function ixgbe_flow_create(), the value ntuple_filter_ptr, >> ethertype_filter_ptr,syn_filter_ptr,fdir_rule_ptr and l2_tn_filter_ptr >> use rte_zmalloc() malloc memory may return NULL,so, we should >>

Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

2017-08-23 Thread Ferruh Yigit
On 8/23/2017 1:41 AM, David Harton wrote: > eth_ena_dev_init() was not initializing all of the common > pci dev info for the rte_eth_dev. Added call to > rte_eth_copy_pci_info() to complete the init particularly > the driver name. rte_eth_copy_pci_info() already called during probe [1], what info

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: don't map doorbell register to write combining

2017-08-23 Thread Ferruh Yigit
On 8/21/2017 8:47 AM, Sagi Grimberg wrote: > From: Shahaf Shuler > > By default, Verbs maps the doorbell register to write combining. > Working with write combining is useful for drivers which use blue flame > for the doorbell write. > > Since mlx5 PMD uses only doorbells and write combining map

[dpdk-dev] [PATCH] service: add new `rte_service_lcore_count_services` API

2017-08-23 Thread Pavan Nikhilesh
This new API returns the number of services that are running on a specific service core. It allows an application to decide which service core to run a new service on. Signed-off-by: Pavan Nikhilesh --- lib/librte_eal/common/include/rte_service.h | 12 lib/librte_eal/common/rte_serv

[dpdk-dev] [PATCH 2/4] test: meter autotest update

2017-08-23 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- test/test/test_meter.c | 138 +++-- 1 file changed, 87 insertions(+), 51 deletions(-) diff --git a/test/test/test_meter.c b/test/test/test_meter.c index 26b0565..b3232f6 100644 --- a/test/test/test_meter.c +++ b/t

[dpdk-dev] [PATCH 0/4] meter: add meter configuration profile api

2017-08-23 Thread Cristian Dumitrescu
This patch set adds support for meter configuration profiles. Benefits: simplified configuration procedure, improved performance. Q1: What is the configuration profile and why does it make sense? A1: The configuration profile represents the set of configuration parameters for a given meter obj

[dpdk-dev] [PATCH 1/4] meter: add meter configuration profile

2017-08-23 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- lib/librte_meter/rte_meter.c | 88 ++--- lib/librte_meter/rte_meter.h | 170 ++--- lib/librte_meter/rte_meter_version.map | 8 ++ 3 files changed, 174 insertions(+), 92 deletions(-) diff --git a

[dpdk-dev] [PATCH 3/4] qos_meter: accommodate meter api changes

2017-08-23 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- examples/qos_meter/main.c | 36 +--- examples/qos_meter/main.h | 32 2 files changed, 45 insertions(+), 23 deletions(-) diff --git a/examples/qos_meter/main.c b/examples/qos_meter/main.c index

[dpdk-dev] [PATCH 4/4] deprecation: removed the librte_meter notice

2017-08-23 Thread Cristian Dumitrescu
Signed-off-by: Cristian Dumitrescu --- doc/guides/rel_notes/deprecation.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 3362f33..11a9d09 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: replace memory barrier type

2017-08-23 Thread Nélio Laranjeiro
On Mon, Aug 21, 2017 at 10:47:01AM +0300, Sagi Grimberg wrote: > From: Shahaf Shuler > > The reason for the requirement of a barrier between the txq writes > and the doorbell record writes is to avoid a case where the device > reads the doorbell record's new value before the txq writes are flushe

Re: [dpdk-dev] Intel 82599ES send packets failed on dpdk-17.05.1 after traffic testing

2017-08-23 Thread zimeiw
hi, I have tested below dpdk version, after dpdk-17.05 version, ixgbe nic would send fail. the logs is same as below. dpdk-17.02 ok dpdk-17.02.1 ok dpdk-17.05 nok dpdk-17.05.1 nok dpdk-17.08 nok PMD: ixgbe_xmit_pkts(): port_id=0 queue_id=0 tx_tail=63

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: don't map doorbell register to write combining

2017-08-23 Thread Shahaf Shuler
Wednesday, August 23, 2017 2:04 PM, Ferruh Yigit: > On 8/21/2017 8:47 AM, Sagi Grimberg wrote: > > From: Shahaf Shuler > > > > By default, Verbs maps the doorbell register to write combining. > > Working with write combining is useful for drivers which use blue > > flame for the doorbell write. >

Re: [dpdk-dev] [PATCH 2/2] net/mlx5: don't map doorbell register to write combining

2017-08-23 Thread Nélio Laranjeiro
On Wed, Aug 23, 2017 at 12:03:39PM +0100, Ferruh Yigit wrote: > On 8/21/2017 8:47 AM, Sagi Grimberg wrote: > > From: Shahaf Shuler > > > > By default, Verbs maps the doorbell register to write combining. > > Working with write combining is useful for drivers which use blue flame > > for the doorb

[dpdk-dev] [RFC v1] net/mlx4: support count flow action

2017-08-23 Thread Ori Kam
Support count flow action in mlx4. This patch is draft only, do to missing features on the verbs driver. As soon as the features will be implemented on the verbs driver this patch will be updated and rebased on top of the head version. Signed-off-by: Ori Kam --- drivers/net/mlx4/mlx4_flow.c |

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, August 23, 2017 3:52 AM > To: David Harton (dharton) > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by > rte_eth_stats_get > > 23/08/2017 04:55, David Harton:

Re: [dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API

2017-08-23 Thread Ananyev, Konstantin
Hi, > Introduce a new API to configure Rx offloads. > > The new API will re-use existing DEV_RX_OFFLOAD_* flags > to enable the different offloads. This will ease the process > of adding a new Rx offloads, as no ABI breakage is involved. > In addition, the offload configuration can be done per qu

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix uninitialized errno value

2017-08-23 Thread Hemant Agrawal
errno should be initialized to 0 before calling strtol Fixes: 1df9c0109f4c ("examples/l2fwd-crypto: parse key parameters") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- examples/l2fwd-crypto/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/l2fwd-crypto/main.c b/exampl

[dpdk-dev] [PATCH] app/crypto-perf: fix uninitialized errno value

2017-08-23 Thread Hemant Agrawal
errno should be initialized to 0 before calling strtol Fixes: f6cefe253cc8 ("app/crypto-perf: add range/list of sizes") Cc: sta...@dpdk.org Signed-off-by: Hemant Agrawal --- app/test-crypto-perf/cperf_options_parsing.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-crypto-perf/cpe

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-23 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > Sent: Monday, August 7, 2017 1:55 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new > offloads API > > A new offloads API was introduced by commit

[dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Sergio Gonzalez Monroy
First, try to use CPUID Time Stamp Counter and Nominal Core Crystal Clock Information Leaf to determine the tsc hz on platforms that supports it (does not require priviledge user). If the CPUID leaf is not available, then try to determine the tsc hz by reading the MSR 0xCE (requires priviledge use

[dpdk-dev] [PATCH 1/2] eal/x86: use cpuid builtin

2017-08-23 Thread Sergio Gonzalez Monroy
Signed-off-by: Sergio Gonzalez Monroy --- lib/librte_eal/common/arch/x86/rte_cpuflags.c | 41 +-- 1 file changed, 7 insertions(+), 34 deletions(-) diff --git a/lib/librte_eal/common/arch/x86/rte_cpuflags.c b/lib/librte_eal/common/arch/x86/rte_cpuflags.c index 0138257..67

Re: [dpdk-dev] [PATCH] ixgbe: initialize scattered_rx during dev_configure

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Wednesday, August 23, 2017 6:32 AM > To: David Harton (dharton) ; wenzhuo...@intel.co > Cc: dev@dpdk.org > Subject: RE: [PATCH] ixgbe: initialize scattered_rx during dev_configure > > Hi David,

[dpdk-dev] [PATCH v2] net/failsafe: safer subdev iterator

2017-08-23 Thread Gaetan Rivet
The sub_device iterator macro should follow the general gist of the tailq API for an easier understanding and safer use. Once the loop has finished, the iterator should be set to NULL. If no sub_device was iterated upon, the iterator should still be NULL. Signed-off-by: Gaetan Rivet --- v2:

Re: [dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API

2017-08-23 Thread Shahaf Shuler
Wednesday, August 23, 2017 3:21 PM, Ananyev, Konstantin: > Hi, > > > Introduce a new API to configure Rx offloads. > > > > The new API will re-use existing DEV_RX_OFFLOAD_* flags to enable the > > different offloads. This will ease the process of adding a new Rx > > offloads, as no ABI breakage is

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: replace memory barrier type

2017-08-23 Thread Bruce Richardson
On Wed, Aug 23, 2017 at 01:39:08PM +0200, Nélio Laranjeiro wrote: > On Mon, Aug 21, 2017 at 10:47:01AM +0300, Sagi Grimberg wrote: > > From: Shahaf Shuler > > > > The reason for the requirement of a barrier between the txq writes > > and the doorbell record writes is to avoid a case where the dev

Re: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to the new offloads API

2017-08-23 Thread Shahaf Shuler
Wednesday, August 23, 2017 3:29 PM, Ananyev, Konstantin: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Shahaf Shuler > > Sent: Monday, August 7, 2017 1:55 PM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [RFC PATCH 4/4] ethdev: add helpers to move to t

Re: [dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Bruce Richardson
On Wed, Aug 23, 2017 at 01:42:41PM +0100, Sergio Gonzalez Monroy wrote: > First, try to use CPUID Time Stamp Counter and Nominal Core Crystal > Clock Information Leaf to determine the tsc hz on platforms that > supports it (does not require priviledge user). > > If the CPUID leaf is not available,

Re: [dpdk-dev] [PATCH] ena: fix init of ena pci_dev info

2017-08-23 Thread David Harton (dharton)
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Wednesday, August 23, 2017 6:48 AM > To: David Harton (dharton) ; m...@semihalf.com; > m...@semihalf.com; gtza...@amazon.com; evge...@amazon.com > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] ena: fix

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by rte_eth_stats_get

2017-08-23 Thread Thomas Monjalon
23/08/2017 14:18, David Harton (dharton): > > > -Original Message- > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, August 23, 2017 3:52 AM > > To: David Harton (dharton) > > Cc: dev@dpdk.org > > Subject: Re: [PATCH v2 1/2] ethdev: stop overriding rx_nombuf by >

Re: [dpdk-dev] [PATCH] eal/malloc: fix malloc cookie check

2017-08-23 Thread Sergio Gonzalez Monroy
Hi Xueming, I think I have understood what you are doing and why the change is required, but I believe we can improve the commit message. It might be even a good idea to split the patches: 1. RTE_MALLOC_DEBUG fix 2. malloc_elem_free fix On 23/08/2017 03:29, Xueming Li wrote: From: xuemingl

[dpdk-dev] [PATCH v1 0/6] Flow classification library

2017-08-23 Thread Bernard Iremonger
DPDK works with packets, but some network administration tools works based on flow information. This library is suggested to provide a helper API to convert packet based information to the flow records. Basically the library consist of APIs to validate, create and destroy the rule and to query

[dpdk-dev] [PATCH v1 1/6] librte_table: move structure to header file

2017-08-23 Thread Bernard Iremonger
Move struct librte_table from the rte_table_acl.c to the rte_table_acl.h file. Signed-off-by: Bernard Iremonger --- lib/librte_table/rte_table_acl.c | 24 lib/librte_table/rte_table_acl.h | 24 2 files changed, 24 insertions(+), 24 deletions(-)

[dpdk-dev] [PATCH v1 2/6] librte_table: fix acl entry add and delete functions

2017-08-23 Thread Bernard Iremonger
The rte_table_acl_entry_add() function was returning data from acl_memory instead of acl_rule_memory. It was also returning data from entry instead of entry_ptr. The rte_table_acl_entry_delete() function was returning data from acl_memory instead of acl_rule_memory. Fixes: 166923eb2f78 ("table: A

[dpdk-dev] [PATCH v1 3/6] librte_ether: initialise IPv4 protocol mask for rte_flow

2017-08-23 Thread Bernard Iremonger
Initialise the next_proto_id mask in the default mask for rte_flow_item_type_ipv4. Signed-off-by: Bernard Iremonger --- lib/librte_ether/rte_flow.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_ether/rte_flow.h b/lib/librte_ether/rte_flow.h index bba6169..59c42fa 100644 --- a/li

[dpdk-dev] [PATCH v1 4/6] librte_flow_classify: add librte_flow_classify library

2017-08-23 Thread Bernard Iremonger
From: Ferruh Yigit The following library APIs's are implemented: rte_flow_classify_create rte_flow_classify_validate rte_flow_classify_destroy rte_flow_classify_query The librte_table ACL API is used for matching packets The library supports counting of IPv4 five tupple packets only, ie IPv4 UD

[dpdk-dev] [PATCH v1 5/6] examples/flow_classify: flow classify sample application

2017-08-23 Thread Bernard Iremonger
The flow_classify sample application exercises the following librte_flow_classify API's: rte_flow_classify_create rte_flow_classify_validate rte_flow_classify_destroy rte_flow_classify_query It sets up the IPv4 ACL field definitions. It creates table_acl using the librte_table API. Signed-off-by

[dpdk-dev] [PATCH v1 6/6] test: flow classify library unit tests

2017-08-23 Thread Bernard Iremonger
Add flow_classify_autotest program. Set up IPv4 ACL field definitions. Create table_acl for use by librte_flow_classify API's. Create an mbuf pool for use by rte_flow_classify_query. For each of the librte_flow_classify API's: add bad parameter tests add bad pattern tests add bad action tests add

Re: [dpdk-dev] [PATCH 2/2] eal/x86: implement x86 specific tsc hz

2017-08-23 Thread Sergio Gonzalez Monroy
On 23/08/2017 14:17, Bruce Richardson wrote: On Wed, Aug 23, 2017 at 01:42:41PM +0100, Sergio Gonzalez Monroy wrote: First, try to use CPUID Time Stamp Counter and Nominal Core Crystal Clock Information Leaf to determine the tsc hz on platforms that supports it (does not require priviledge user)

[dpdk-dev] [PATCH] eal: add config option to enable asserts

2017-08-23 Thread Xueming Li
Currently, enabling assertion have to set CONFIG_RTE_LOG_LEVEL to RTE_LOG_DEBUG. CONFIG_RTE_LOG_LEVEL is the default log level of control path, RTE_LOG_DP_LEVEL is the log level of data path. It's a little bit hard to understand literally that assertion is decided by control path LOG_LEVEL, especia

[dpdk-dev] [PATCH v3 03/40] bus/dpaa: add compatibility and helper macros

2017-08-23 Thread Shreyansh Jain
From: Hemant Agrawal Linked list, bit operations and compatibility macros. Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal --- v3: - Removed checkpatch warning and duplicate PER_CPU macro --- drivers/bus/dpaa/include/compat.h| 389 +++ drivers/b

[dpdk-dev] [PATCH v3 02/40] bus/dpaa: introduce NXP DPAA Bus driver skeleton

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain Signed-off-by: Hemant Agrawal --- MAINTAINERS | 5 + config/common_base| 3 + config/defconfig_arm64-dpaa-linuxapp-gcc | 6 + drivers/bus/Makefile | 3 + drivers/bus/dpaa/Makefile

[dpdk-dev] [PATCH v3 04/40] bus/dpaa: add OF parser for device scanning

2017-08-23 Thread Shreyansh Jain
This layer is used by Bus driver's scan function. Devices are parsed using OF parser and added to DPAA device list. Signed-off-by: Geoff Thorpe Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefile | 7 + drivers/bus/dpaa/base/fman/of.c | 576 ++

[dpdk-dev] [PATCH v3 07/40] bus/dpaa: enable DPAA IOCTL portal driver

2017-08-23 Thread Shreyansh Jain
Userspace applications interact with DPAA blocks using this IOCTL driver. Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefile | 4 +- drivers/bus/dpaa/base/qbman/process.c | 331 ++

[dpdk-dev] [PATCH v3 08/40] bus/dpaa: add layer for interrupt emulation using pthread

2017-08-23 Thread Shreyansh Jain
An interrupt manager is implemented by emulating over pthreads. Handlers are registered by QBMAN layer for being notified about any interrupt request from DPAA blocks in userspace. Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefi

[dpdk-dev] [PATCH v3 11/40] bus/dpaa: add QMan driver core routines

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefile |2 + drivers/bus/dpaa/base/qbman/dpaa_alloc.c | 88 ++ drivers/bus/dpaa/base/qbman/qman.c| 2402 ++

[dpdk-dev] [PATCH v3 12/40] bus/dpaa: add BMAN driver core

2017-08-23 Thread Shreyansh Jain
The Buffer Manager (BMan) is a hardware buffer pool management block that allows software and accelerators on the datapath to acquire and release buffers in order to build frames. This patch adds the core routines. Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agra

[dpdk-dev] [PATCH v3 13/40] bus/dpaa: add support for FMAN frame queue lookup

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/base/qbman/qman.c| 99 ++- drivers/bus/dpaa/base/qbman/qman_driver.c | 7 ++- drivers/bus/dpaa/base/qbman/qman_priv.h |

[dpdk-dev] [PATCH v3 00/40] Introduce NXP DPAA Bus, Mempool and PMD

2017-08-23 Thread Shreyansh Jain
Change Log: v3: - Rebasing over 17.11-rc0 (85238f50) - Checkpatch fixes (There are still 2 errors which I think are false positives) - Implement rte_bus.find_device() interface - Various other minor updates/cleanups v2: - Fixing various comments from Ferruh, but broadly: -)

[dpdk-dev] [PATCH v3 06/40] bus/dpaa: add FMan hardware operations

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefile | 1 + drivers/bus/dpaa/base/fman/fman_hw.c | 606 ++ drivers/bus/dpaa/include/fsl_fman.h | 182 + drivers/bus/d

[dpdk-dev] [PATCH v3 05/40] bus/dpaa: introducing FMan configurations

2017-08-23 Thread Shreyansh Jain
FMan or Frame Manager, inspects traffic, splits it into queueson ingress. It is also responsible for directing traffic on queues on egress. This patch introduces FMan configurational interfaces. This layer is used by Bus driver for configuring the hardware block. Signed-off-by: Geoff Thorpe Sign

[dpdk-dev] [PATCH v3 16/40] bus/dpaa: integrate DPAA Bus with hardware blocks

2017-08-23 Thread Shreyansh Jain
Now that QBMAN (QMAN, BMAN) and FMAN drivers are available, this patch integrates the DPAA Bus driver for using the drivers for scanning devices and calling the PMD registered probe callbacks. Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/dpaa_bus.c

[dpdk-dev] [PATCH v3 18/40] bus/dpaa: add DPAA mempool logging macros

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/dpaa_bus.c | 5 + drivers/bus/dpaa/rte_dpaa_logs.h | 28 2 files changed, 33 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index 8017df3..dc2b3ad 100644 --- a/drivers/

[dpdk-dev] [PATCH v3 10/40] bus/dpaa: add QMAN interface driver

2017-08-23 Thread Shreyansh Jain
The Queue Manager (QMan) is a hardware queue management block that allows software and accelerators on the datapath to enqueue and dequeue frames in order to communicate. This part of QBMAN DPAA Block. Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-o

[dpdk-dev] [PATCH v3 01/40] config: add NXP DPAA SoC build configuration

2017-08-23 Thread Shreyansh Jain
This patch adds skeleton build configuration for DPAA platform. Signed-off-by: Shreyansh Jain --- config/defconfig_arm64-dpaa-linuxapp-gcc | 39 mk/machine/dpaa/rte.vars.mk | 61 2 files changed, 100 insertions(+) create mode 10

[dpdk-dev] [PATCH v3 09/40] bus/dpaa: add routines for managing a RB tree

2017-08-23 Thread Shreyansh Jain
QMAN frames are managed over a RB tree data structure. This patch introduces necessary routines for implementing a RB tree. Signed-off-by: Geoff Thorpe Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/include/dpaa_rbtree.h | 143 +

[dpdk-dev] [PATCH v3 14/40] bus/dpaa: add BMan hardware interfaces

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/Makefile | 1 + drivers/bus/dpaa/base/qbman/bman.c| 394 + drivers/bus/dpaa/base/qbman/bman.h| 550 ++

[dpdk-dev] [PATCH v3 15/40] bus/dpaa: add fman flow control threshold setting

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Geoff Thorpe Signed-off-by: Roy Pledge Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/base/fman/fman_hw.c | 28 drivers/bus/dpaa/include/fsl_fman.h | 7 +++ 2 files changed, 35 insertions(+) diff --git a/drive

[dpdk-dev] [PATCH v3 24/40] config: enable NXP DPAA PMD compilation

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- config/common_base | 1 + config/defconfig_arm64-dpaa-linuxapp-gcc | 12 drivers/net/Makefile | 2 ++ mk/rte.app.mk| 5 + 4 files changed, 20 insertions(+) diff --git a/con

[dpdk-dev] [PATCH v3 19/40] mempool/dpaa: add support for NXP DPAA Mempool

2017-08-23 Thread Shreyansh Jain
This Mempool driver works with DPAA BMan hardware block. This block manages data buffers in memory, and provides efficient interface with other hardware and software components for buffer requests. This patch adds support for BMan. Compilation would be enabled in subsequent patches. Signed-off-by

[dpdk-dev] [PATCH v3 17/40] doc: add NXP DPAA PMD documentation

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- MAINTAINERS | 2 + doc/guides/nics/dpaa.rst | 374 ++ doc/guides/nics/features/dpaa.ini | 8 + doc/guides/nics/index.rst | 1 + 4 files changed, 385 in

[dpdk-dev] [PATCH v3 20/40] drivers: enable compilation of DPAA Mempool driver

2017-08-23 Thread Shreyansh Jain
This patch also adds configuration necessary for compilation of DPAA Mempool driver into the DPAA specific config file. CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS=dpaa is also configured to allow applications to use DPAA mempool as default. Signed-off-by: Shreyansh Jain --- config/common_base

[dpdk-dev] [PATCH v3 21/40] maintainers: claim ownership of DPAA Mempool driver

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 10646a4..74b7aba 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -409,6 +409,7 @@ NXP dpaa M: Hemant Agrawal M: Shreyansh Jain F: drivers/bus/dpaa/ +F: drivers/memp

[dpdk-dev] [PATCH v3 22/40] bus/dpaa: add DPAA PMD logging macros

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Shreyansh Jain --- drivers/bus/dpaa/dpaa_bus.c | 5 + drivers/bus/dpaa/rte_dpaa_logs.h | 36 2 files changed, 41 insertions(+) diff --git a/drivers/bus/dpaa/dpaa_bus.c b/drivers/bus/dpaa/dpaa_bus.c index dc2b3ad..7ae5bfa 100644 --- a/

[dpdk-dev] [PATCH v3 26/40] net/dpaa: add support for MTU update

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 21 + 2 files changed, 22 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index 9e8

[dpdk-dev] [PATCH v3 25/40] net/dpaa: add support for Tx and Rx queue setup

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- drivers/net/dpaa/Makefile | 4 + drivers/net/dpaa/dpaa_ethdev.c | 290 +++- drivers/net/dpaa/dpaa_rxtx.c | 370 + drivers/net/dpaa/dpaa_rxtx.h | 61

[dpdk-dev] [PATCH v3 31/40] net/dpaa: add support for multicast toggle

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index b2df

[dpdk-dev] [PATCH v3 29/40] net/dpaa: add support for device info and speed capability

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index 132f

[dpdk-dev] [PATCH v3 23/40] net/dpaa: add NXP DPAA PMD driver skeleton

2017-08-23 Thread Shreyansh Jain
A skeleton which would be called after bus device scan. It currently fails to identify the device. Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- MAINTAINERS | 1 + drivers/net/dpaa/Makefile | 63 drivers/net/dpaa/dpaa_e

[dpdk-dev] [PATCH v3 27/40] net/dpaa: add support for jumbo frames

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 13 +++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini i

[dpdk-dev] [PATCH v3 28/40] net/dpaa: add support for link status update

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 42 +++ 2 files changed, 43 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/

[dpdk-dev] [PATCH v3 33/40] net/dpaa: add support for basic stats

2017-08-23 Thread Shreyansh Jain
Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain --- doc/guides/nics/features/dpaa.ini | 1 + drivers/net/dpaa/dpaa_ethdev.c| 20 2 files changed, 21 insertions(+) diff --git a/doc/guides/nics/features/dpaa.ini b/doc/guides/nics/features/dpaa.ini index cdf5

  1   2   >