23/08/2017 04:55, David Harton: > rte_eth_stats_get() unconditonally would set rx_nombuf > even if the device was setting the value. A check has > been added in rte_eth_stats_get() to leave the device > value in-tact when non-zero.
If we get this counter from stats->rx_nombuf, why keeping dev->data->rx_mbuf_alloc_failed ? We could rework other PMDs to not use this global variable. It is inconsistent to use it for some PMDs but not all. And it seems not used outside of PMDs.
