Re: [dpdk-dev] [PATCH v2] ethdev: moved bypass functions to ixgbe pmd

No other NIC has bypass functions except ixgbe, so I agree moving them from ethdev to ixgbe pmd. As these functions are exported to external upper layer application, it is necessary to use is_ixgbe_supported() to avoid be called by other type of NIC. > -Original Message- > From: dev [ma

Re: [dpdk-dev] [PATCH] crypto/scheduler: add multicore scheduling mode

Hi Kirill, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Sunday, May 28, 2017 9:09 PM > To: Doherty, Declan; Zhang, Roy Fan > Cc: dev@dpdk.org; Rybalchenko, Kirill > Subject: [dpdk-dev] [PATCH] crypto/scheduler: add multicore scheduling >

Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern

On Tue, May 30, 2017 at 02:46:30PM +0200, Adrien Mazarguil wrote: Hi Zhang, You should cram "flow API" somewhere in the title of such commits. On Tue, May 23, 2017 at 07:28:54PM -0400, Qi Zhang wrote: Add new meta pattern item RTE_FLOW_TYPE_ITEM_ROUGHLY. This is for device that support no-per

Re: [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names

On 29.05.2017 14:40, Ferruh Yigit wrote: On 5/26/2017 7:05 PM, Matej Vido wrote: Signed-off-by: Matej Vido Hi Matej, Overall patchset looks good to me, but can you please provide a little more information in commit logs, please check comments on patches. For this patch, it seems refactor nam

Re: [dpdk-dev] [PATCH 3/5] net/szedata2: refactor ibuf and obuf address definition

On 29.05.2017 14:41, Ferruh Yigit wrote: On 5/26/2017 7:05 PM, Matej Vido wrote: This is to prepare for firmwares with multiple ibufs and obufs. Offsets of ibufs and obufs are defined in array. I was thinking ibufs and obufs as queues, but since link functions updated per ibufs it looks like po

Re: [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares

On 29.05.2017 14:42, Ferruh Yigit wrote: On 5/26/2017 7:05 PM, Matej Vido wrote: Add IBUF and OBUF offsets definitions for new firmwares. just to double check, is it required to add new pci device ids to support these new cards? Is dpdk supported nics (http://dpdk.org/doc/nics) needs to be upd

Re: [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares

On 5/31/2017 9:34 AM, Matej Vido wrote: > On 29.05.2017 14:42, Ferruh Yigit wrote: >> On 5/26/2017 7:05 PM, Matej Vido wrote: >>> Add IBUF and OBUF offsets definitions for new firmwares. >> just to double check, is it required to add new pci device ids to >> support these new cards? >> >> Is dpdk s

Re: [dpdk-dev] [PATCH 3/5] net/szedata2: refactor ibuf and obuf address definition

On 5/31/2017 9:33 AM, Matej Vido wrote: > On 29.05.2017 14:41, Ferruh Yigit wrote: >> On 5/26/2017 7:05 PM, Matej Vido wrote: >>> This is to prepare for firmwares with multiple ibufs and obufs. >>> Offsets of ibufs and obufs are defined in array. >> I was thinking ibufs and obufs as queues, but sin

[dpdk-dev] [PATCH 0/3] timer: inform periodic timers of multiple expiries

For periodic timers, with the current there is no way to know if timer expiries have been missed between calls to rte_timer_manage(). This patchset adds in a new parameter to timer callbacks, to give the number of expiries since the last one. ABI compatibility with previous releases is kept, and a

[dpdk-dev] [PATCH 1/3] timer: inform periodic timers of multiple expiries

if timer_manage is called much less frequently than the period of a periodic timer, then timer expiries will be missed. For example, if a timer has a period of 300us, but timer_manage is called every 1ms, then there will only be one timer callback called every 1ms instead of 3 within that time. Wh

[dpdk-dev] [PATCH 2/3] timer: add symbol versions for ABI compatibility

With the change in parameters to the callback function for timers, ABI compatibility needs to be managed. Do this by adding symbol version information and adding back in older copies of some functions. Signed-off-by: Bruce Richardson --- lib/librte_timer/rte_timer.c | 79 ++

[dpdk-dev] [PATCH 3/3] test/test: add test for multiple timer expiries

The API for the rte_timer callbacks has been modified to allow us to return the number of times a periodic callback would have been called. Test this capability by adding a new unit test. Signed-off-by: Bruce Richardson --- test/test/test_timer.c | 54

Re: [dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats

On 5/31/2017 3:12 AM, Ajit Khaparde wrote: > > On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit > wrote: > > > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count) > > +{ > > + struct rte_eth_dev *dev; > > + struct rte_eth_dev_in

[dpdk-dev] [PATCH v2] net/i40e: update actions for FDIR

This commit adds support of FLAG action and PASSTHRU action for flow director. Signed-off-by: Beilei Xing --- v2 changes: -Add support of PASSTHRU action. -Refine code. drivers/net/i40e/i40e_flow.c | 74 1 file changed, 40 insertions(+), 34 deletio

[dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

Set UIO info device file operations open and release. Call pci reset function inside open and release to clear device state at start and end. Copied this behaviour from vfio_pci kernel module code. With this change, it is not mandatory to issue FLR by PMD's during init and close. Signed-off-by: Sh

[dpdk-dev] [PATCH v3] ethdev: moved bypass functions to ixgbe pmd

Moved all bypass functions to ixgbe pmd and removed function pointers from the eth_dev_ops struct. Changes in v2: CONFIG_RTE_NIC_BYPASS removed, new option in the IXGBE section added, CONFIG_RTE_LIBRTE_IXGBE_BYPASS. Updated test-pmd to always include the bypass commands. Changes in v3: Added is_i

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

On 5/31/2017 12:09 PM, Shijith Thotton wrote: > Set UIO info device file operations open and release. Call pci reset > function inside open and release to clear device state at start and > end. Copied this behaviour from vfio_pci kernel module code. With this > change, it is not mandatory to issue

[dpdk-dev] [PATCH v2 01/11] bus: add bus iterator to find a particular bus

From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 13 ++ lib/librte_eal/common/include/rte_bus.h | 32 + lib/librte_eal/lin

[dpdk-dev] [PATCH v2 00/11] bus: attach / detach API

Following the work from Jan: This patchset introduces the attach / detach API to rte_bus. The rte_device structure is used as the generic device representation. This API is implemented for the virtual bus. The functions rte_eal_dev_attach and rte_eal_dev_detach are updated to use this new interfa

[dpdk-dev] [PATCH v2 03/11] bus: add helper to find bus for a particular device

From: Jan Blunck Signed-off-by: Jan Blunck --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 24 lib/librte_eal/common/include/rte_bus.h | 5 + lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1

[dpdk-dev] [PATCH v2 02/11] bus: add device iterator

From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_bus.h | 7 +++ lib/librte_eal/common/include/rte_dev.h | 15 +++ 2 files changed, 22 insertions(+) diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_e

[dpdk-dev] [PATCH v2 04/11] bus: add bus helper iterator to find a particular device

From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_bus.c | 25 + lib/librte_eal/common/include/rte_bus.h | 23 +++ lib/l

[dpdk-dev] [PATCH v2 05/11] bus: introduce hotplug functionality

From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_bus.c | 3 +++ lib/librte_eal/common/include/rte_bus.h | 20 2 files changed, 23 insertions(+) diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_e

[dpdk-dev] [PATCH v2 06/11] vdev: implement find_device bus operation

From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 0037a64..46f2b74 100644

[dpdk-dev] [PATCH v2 07/11] vdev: implement hotplug functionality

Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 46f2b74..813955e 100644 --- a/lib/librte_eal/common/eal_common_vdev.c +++ b/l

[dpdk-dev] [PATCH v2 08/11] vdev: implement unplug bus operation

From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_vdev.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 813955e..67c6fff 100644 --- a/l

[dpdk-dev] [PATCH v2 09/11] eal: make virtual driver probe and remove take rte_vdev_device

From: Jan Blunck This is a preparation to embed the generic rte_device into the rte_eth_dev also for virtual devices. Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_dev.c | 93 ++ 1 file changed, 71 insertions(+), 22

[dpdk-dev] [PATCH v2 11/11] net/ring: fix dev handle in eth_dev

The ring PMD uses special eth_dev allocators, which cannot be updated to accept an rte_vdev_device. Circumvent the limitation and store the rte_device handle in the rte_eth_dev structure. Fixes: 050fe6e9ff97 ("drivers/net: use ethdev allocation helper for vdev") Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH v2 10/11] ethdev: Use embedded rte_device to detach driver

From: Jan Blunck Signed-off-by: Jan Blunck Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + lib/librte_eal/common/eal_common_dev.c| 43 --- lib/librte_eal/common/include/rte_dev.h | 11 +++ lib/librte_ether/rte_ethd

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: add traffic management API

-Original Message- > Date: Fri, 19 May 2017 18:12:52 +0100 > From: Cristian Dumitrescu > To: dev@dpdk.org > CC: thomas.monja...@6wind.com, jerin.ja...@caviumnetworks.com, > balasubramanian.manoha...@cavium.com, hemant.agra...@nxp.com, > shreyansh.j...@nxp.com > Subject: [PATCH v4 2/2] et

Re: [dpdk-dev] [PATCH 1/3] cfgfile: add new API functions

On Tue, May 30, 2017 at 10:30:35AM +0200, Jacek Piasecki wrote: > Extend existing cfgfile library with providing new API functions: > rte_cfgfile_create() - create new cfgfile object > rte_cfgfile_add_section() - add new section to existing cfgfile object > rte_cfgfile_add_entry() - add new entry t

Re: [dpdk-dev] [PATCH 1/3] cfgfile: add new API functions

On Wed, May 31, 2017 at 03:20:00PM +0100, Bruce Richardson wrote: > On Tue, May 30, 2017 at 10:30:35AM +0200, Jacek Piasecki wrote: > > Extend existing cfgfile library with providing new API functions: > > rte_cfgfile_create() - create new cfgfile object > > rte_cfgfile_add_section() - add new sect

[dpdk-dev] [dpdk-announce] DPDK 16.11.2 (LTS) released

Hi all, Here is a new LTS release, v16.11.2: http://fast.dpdk.org/rel/dpdk-16.11.2.tar.xz The git tree is at: http://dpdk.org/browse/dpdk-stable/ Thanks. --yliu --- app/test-pipeline/init.c | 2 +- app/test-pmd/parameters.c

Re: [dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats

On Wed, May 31, 2017 at 4:57 AM, Ferruh Yigit wrote: > On 5/31/2017 3:12 AM, Ajit Khaparde wrote: > > > > On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit > > wrote: > > > > > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count) > > > +{ > >

Re: [dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats

On 5/31/2017 3:27 PM, Ajit Khaparde wrote: > On Wed, May 31, 2017 at 4:57 AM, Ferruh Yigit >wrote: > > On 5/31/2017 3:12 AM, Ajit Khaparde wrote: > > > > On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit > >

Re: [dpdk-dev] [PATCH 00/20] next-eventdev: NXP DPAA2 eventdev PMD

-Original Message- > Date: Thu, 25 May 2017 23:37:31 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > harry.van.haa...@intel.com, bruce.richard...@intel.com, > gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta > > Subje

Re: [dpdk-dev] [PATCH 01/20] event/dpaa2: add basic build infrastructure

-Original Message- > Date: Thu, 25 May 2017 23:37:32 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > harry.van.haa...@intel.com, bruce.richard...@intel.com, > gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta > > Subje

Re: [dpdk-dev] [PATCH 10/20] event/dpaa2: add initialization of event device

-Original Message- > Date: Thu, 25 May 2017 23:37:41 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > harry.van.haa...@intel.com, bruce.richard...@intel.com, > gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta > > Subje

Re: [dpdk-dev] [PATCH v4 04/12] net/failsafe: add fail-safe PMD

On Mon, 29 May 2017 15:42:16 +0200 Gaetan Rivet wrote: > +Fail-safe poll mode driver library > +== > + > +The Fail-safe poll mode driver library (**librte_pmd_failsafe**) is a virtual > +device that allows using any device supporting hotplug (sudden device removal >

Re: [dpdk-dev] [PATCH v4 05/12] net/failsafe: add plug-in support

On Mon, 29 May 2017 15:42:17 +0200 Gaetan Rivet wrote: > Periodically check for the existence of a device. > If a device has not been initialized and exists on the system, then it > is probed and configured. > > The configuration process strives to synchronize the states between the > plugged-in

Re: [dpdk-dev] [PATCH v4 06/12] net/failsafe: add flexible device definition

On Mon, 29 May 2017 15:42:18 +0200 Gaetan Rivet wrote: > > +- **exec()** parameter > + > + This parameter allows the user to provide a command to the fail-safe PMD to > + execute and define a sub-device. > + It is done within a regular shell context. > + The first line of its output is read

Re: [dpdk-dev] [PATCH 12/20] event/dpaa2: add configuration functions

-Original Message- > Date: Thu, 25 May 2017 23:37:43 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > harry.van.haa...@intel.com, bruce.richard...@intel.com, > gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta > > Subje

Re: [dpdk-dev] [PATCH v4 07/12] net/failsafe: support flow API

On Mon, 29 May 2017 15:42:19 +0200 Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > Acked-by: Olga Shern > --- > doc/guides/nics/features/failsafe.ini | 1 + > drivers/net/failsafe/Makefile | 1 + > drivers/net/failsafe/failsafe.c | 1 + > drivers/net/failsafe/fail

Re: [dpdk-dev] [PATCH v4 08/12] net/failsafe: support offload capabilities

On Mon, 29 May 2017 15:42:20 +0200 Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > Acked-by: Olga Shern > --- > doc/guides/nics/features/failsafe.ini | 6 ++ > drivers/net/failsafe/failsafe_ops.c | 131 > +- > 2 files changed, 135 insertions(+), 2 delet

Re: [dpdk-dev] [PATCH v4 00/12] introduce fail-safe PMD

On Mon, 29 May 2017 15:03:40 +0100 Ferruh Yigit wrote: > Should this discussed in the tech-board, again for this release? The primary discussion area should be the mailing list not the tech board. Comments in public please.

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

On Wed, 31 May 2017 16:39:26 +0530 Shijith Thotton wrote: > + /* reset the pci device */ > + pci_reset_function(dev); It is not considered best practice to comment the obvious. This comment borders on being the classic /* add one to i */

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

On Wed, 31 May 2017 13:20:08 +0100 Ferruh Yigit wrote: > On 5/31/2017 12:09 PM, Shijith Thotton wrote: > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and > > end. Copied this behaviour from vfio_pci kern

Re: [dpdk-dev] [PATCH 12/20] event/dpaa2: add configuration functions

-Original Message- > Date: Thu, 25 May 2017 23:37:43 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > harry.van.haa...@intel.com, bruce.richard...@intel.com, > gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta > > Subje

Re: [dpdk-dev] [PATCH v2 00/11] bus: attach / detach API

On Wed, 31 May 2017 15:17:45 +0200 Gaetan Rivet wrote: > Following the work from Jan: > > This patchset introduces the attach / detach API to rte_bus. > The rte_device structure is used as the generic device representation. > > This API is implemented for the virtual bus. > The functions rte_ea

[dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4.

Fix kni compilation under RHEL 7.4. Signed-off-by: Lee Roberts --- lib/librte_eal/linuxapp/kni/compat.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/kni/compat.h b/lib/librte_eal/linuxapp/kni/compat.h index d96275a..6a1587b 100644 --- a/lib/libr

Re: [dpdk-dev] [PATCH 2/3] eal: add functions parsing EAL arguments

On Tue, May 30, 2017 at 10:30:36AM +0200, Jacek Piasecki wrote: > From: Kuba Kozak > > added function rte_eal_configure which translate > options from config file into argc, **argv form. > > changed function rte_eal_init to meld > argc, argv** options from config file with > these from command l

Re: [dpdk-dev] [PATCH 19/20] event/dpaa2: handle timeout using interrupts in dequeue

-Original Message- > Date: Thu, 25 May 2017 23:37:50 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > harry.van.haa...@intel.com, bruce.richard...@intel.com, > gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta > > Subje

Re: [dpdk-dev] [PATCH 20/20] doc: add NXP DPAA2 EVENTDEV details

-Original Message- > Date: Thu, 25 May 2017 23:37:51 +0530 > From: Nipun Gupta > To: dev@dpdk.org > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > harry.van.haa...@intel.com, bruce.richard...@intel.com, > gage.e...@intel.com, shreyansh.j...@nxp.com, Nipun Gupta > > Subje

Re: [dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats

31/05/2017 16:46, Ferruh Yigit: > On 5/31/2017 3:27 PM, Ajit Khaparde wrote: > > On Wed, May 31, 2017 at 4:57 AM, Ferruh Yigit > >wrote: > > > > On 5/31/2017 3:12 AM, Ajit Khaparde wrote: > > > > > > On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit > > ma

Re: [dpdk-dev] [PATCH 00/20] next-eventdev: NXP DPAA2 eventdev PMD

31/05/2017 16:50, Jerin Jacob: > -Original Message- > > Date: Thu, 25 May 2017 23:37:31 +0530 > > From: Nipun Gupta > > To: dev@dpdk.org > > CC: hemant.agra...@nxp.com, jerin.ja...@caviumnetworks.com, > > harry.van.haa...@intel.com, bruce.richard...@intel.com, > > gage.e...@intel.com, sh

Re: [dpdk-dev] [PATCH v2] kni: add new mbuf in alloc_q only based on its empty slots

Hi Gowrishankar, Sorry for late response. On 5/18/2017 6:45 PM, gowrishankar muthukrishnan wrote: > On Tuesday 16 May 2017 10:45 PM, Ferruh Yigit wrote: >> On 5/11/2017 12:51 PM, Gowrishankar wrote: >>> From: Gowrishankar Muthukrishnan >>> >>> In kni_allocate_mbufs(), we attempt to add max_burst

Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4.

On 5/31/2017 4:40 PM, Lee Roberts wrote: > Fix kni compilation under RHEL 7.4. > > Signed-off-by: Lee Roberts Not tested on RHEL 7.4, but patch looks good to me except following nit-picking: - There should not be "." at the end of the patch title - It can be good to add Linux commit that is the

Re: [dpdk-dev] [PATCH v4 2/2] ethdev: add traffic management API

I am fine with this proposal. Acked-by: Balasubramanian Manoharan > On 31-May-2017, at 7:15 PM, Jacob, Jerin > wrote: > > -Original Message- >> Date: Fri, 19 May 2017 18:12:52 +0100 >> From: Cristian Dumitrescu >> To: dev@dpdk.org >> CC: thomas.monja...@6wind.com, jerin.ja...@caviumn

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

On 5/31/2017 4:30 PM, Stephen Hemminger wrote: > On Wed, 31 May 2017 13:20:08 +0100 > Ferruh Yigit wrote: > >> On 5/31/2017 12:09 PM, Shijith Thotton wrote: >>> Set UIO info device file operations open and release. Call pci reset >>> function inside open and release to clear device state at start

[dpdk-dev] [PATCH] net/mlx5: fix redundant free of Tx buffer

SW completion ring of Tx (txq->elts) stores individual mbufs even if a multi-segmented packet is sent. rte_pktmbuf_free_seg() must be used when cleaning up the completion ring. Otherwise, chained mbufs are redundantly freed and finally it would cause a crash. CC: sta...@dpdk.org Fixes: 1d88ba17194

Re: [dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats

On Wed, May 31, 2017 at 11:15 AM, Thomas Monjalon wrote: > 31/05/2017 16:46, Ferruh Yigit: > > On 5/31/2017 3:27 PM, Ajit Khaparde wrote: > > > On Wed, May 31, 2017 at 4:57 AM, Ferruh Yigit > > >wrote: > > > > > > On 5/31/2017 3:12 AM, Ajit Khaparde wrote: > >

[dpdk-dev] [PATCH] crypto/aesni_mb: fix assert check

Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") CC: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/cryp

Re: [dpdk-dev] [PATCH] crypto/aesni_mb: fix assert check

On Wed, 31 May 2017 14:44:43 +0100 Pablo de Lara wrote: > Fixes: 0f548b50a160 ("crypto/aesni_mb: process crypto op on dequeue") > CC: sta...@dpdk.org > > Signed-off-by: Pablo de Lara > --- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH v3] ethdev: moved bypass functions to ixgbe pmd

Hi, > -Original Message- > From: Nicolau, Radu > Sent: Wednesday, May 31, 2017 7:10 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh; Iremonger, Bernard; Dai, Wei; Lu, Wenzhuo; Nicolau, Radu > Subject: [PATCH v3] ethdev: moved bypass functions to ixgbe pmd > > Moved all bypass functions to ixgbe

Re: [dpdk-dev] [RFC] Add Membership Library

Hi Vincent, Thanks for the comments and some quick responses below: - DPDK Bloom Filter is derived from the libbloom (as shown by the included BSD license), but optimized for performance with various DPDK goodness such as rte_zmalloc, rte_bitmap, rte_jhash, etc. It doesn't seem appropriate to

Re: [dpdk-dev] [PATCH v3] eal: Set numa node value for system which not support it.

Did you think this patch is necessary. I submitted v4. v4: http://dpdk.org/dev/patchwork/patch/24212/ Thanks. Nick > On May 10, 2017, at 10:20 PM, nickcooper-zhangtonghao > wrote: > > Thanks for your review. > >> On May 10, 2017, at 8:45 PM, Thoma

Re: [dpdk-dev] [PATCH] memzone: Check socket_id value when creating memzone.

If that patch is ok, will we apply it to master? Thanks. Nick > On May 12, 2017, at 4:42 PM, Bruce Richardson > wrote: > > On Thu, May 11, 2017 at 11:03:43PM -0700, Tonghao Zhang wrote: >> If the socket_id is invalid (e.g. -2, -3), the >> memzone_reserve_aligned_thread_unsafe should return the

Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern

> -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, May 31, 2017 3:52 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Adrien Mazarguil ; Mcnamara, John > > Subject: Re: [dpdk-dev] [PATCH] ethdev: add roughly match pattern > > On Tue, May 30, 2017 at 02

Re: [dpdk-dev] [PATCH] net/i40e: get information about ddp profile

Hi Andrey, > -Original Message- > From: Chilikin, Andrey > Sent: Friday, May 26, 2017 8:42 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Wu, Jingjing > ; Chilikin, Andrey > Subject: [PATCH] net/i40e: get information about ddp profile > > This patch adds ability to request information about

[dpdk-dev] [PATCH v2 0/3] ixgbe: enable flex filter for rte_flow

Enable fdir flex byte support for rte_flow APIs. v2: - fix couple checkpatch errors. Qi Zhang (3): net/ixgbe: remove reduandent code net/ixgbe: fix fdir mask not be reset net/ixgbe: enable flex bytes for generic flow API drivers/net/ixgbe/ixgbe_ethdev.h | 3 + drivers/net/ixgbe/ixgbe_fd

[dpdk-dev] [PATCH v2 1/3] net/ixgbe: remove reduandent code

Remove reduandent code. item->type != RTE_FLOW_ITEM_TYPE_END already cover item->type == RTE_FLOW_ITEM_TYPE_VLAN. Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_flow.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixg

[dpdk-dev] [PATCH v2 2/3] net/ixgbe: fix fdir mask not be reset

When the last fdir flow be destroyed, the flag "mask_added" should be reset, so the remain mask info will not take effect when a new flow be added. Fixes: a14de8b498d1 ("net/ixgbe: destroy consistent filter") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_flow.c | 4 +++

[dpdk-dev] [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow API

Add fdir flex byte support for rte_flow APIs. Signed-off-by: Qi Zhang --- v2: - fix couple checkpatch errors. drivers/net/ixgbe/ixgbe_ethdev.h | 3 + drivers/net/ixgbe/ixgbe_fdir.c | 31 - drivers/net/ixgbe/ixgbe_flow.c | 137 ++- 3 files chan

[dpdk-dev] [PATCH v3 03/26] net/bnxt: handle VF/PF initialization appropriately

1) For a VF, query the firmware to determine if a MAC address is already configured. If not configure a random default MAC address. 2) Do not initialize the default completion ring in bnxt_alloc_hwrm_rings(). 3) While registering for async events with the firmware, use func_vf_cfg for a VF and use

[dpdk-dev] [PATCH v3 00/26] bnxt patchset

This patchset amongst other changes adds support few more dev_ops, updates HWRM to version 1.7.7, switches to polling stats from the hardware, support for Jumbo MTU, LRO etc.. v1->v2: - Grouped in the end, it also has PMD specific APIs to control VF from PF. - I have updated the release notes and

[dpdk-dev] [PATCH v3 02/26] net/bnxt: code reorg to properly allocate resources for PF/VF

1) Move the function reset to bnxt_dev_init. On the same lines, setup, enable and request interrupt to init path. Memory allocation is also being done in the init path. 2) After a function reset, configure the VFs. Distribute resources evenly between all functions (PF and VF) for now. In the futur

[dpdk-dev] [PATCH v3 04/26] net/bnxt: support lack of huge pages

rte_malloc_virt2phy() does not return a physical address if huge pages aren't in use. Further, rte_memzone->phys_addr is not a physical address. Use rte_mem_virt2phy() and manually lock pages to support lack of huge pages. Also check the return value of rte_mem_virt2phy() Verify the function re

[dpdk-dev] [PATCH v3 05/26] net/bnxt: add additonal HWRM debug info to error messages

Add the cmd_err and opaque_0 and opaque_1 fields to HWRM error messages. These allow better debugging of some classes of HWRM errors. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-

[dpdk-dev] [PATCH v3 07/26] net/bnxt: add support for xstats get/reset

This patch adds support to get and reset xstats dev_ops dev_ops added: xstats_get, xstats_get_name, xstats_reset HWRM commands added: hwrm_port_qstats, hwrm_port_clr_stats Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing

[dpdk-dev] [PATCH v3 06/26] net/bnxt: add tunneling support

Add support for udp_tunnel_port_add/del dev_ops to configure a UDP port for VXLAN and Geneve Tunnel protocols. The HWRM supports only one global destination port for a tunnel type, use a referene counter to keep track of its usage. Cache the configured VXLAN/Geneve ports and use that value to check

[dpdk-dev] [PATCH v3 08/26] net/bnxt: add support for VLAN filter and strip

This patch adds VLAN strip and offload callbacks. To add a VLAN filter: For each VNIC and each associated filter(s) if VLAN exists: if VLAN matches vlan_id VLAN filter already exists, just skip and continue else add a new MAC+VLAN

[dpdk-dev] [PATCH v3 10/26] doc: update bnxt.ini to document Allmulticast mode

This patch update bnxt.int to document Allmulticast mode which is already supported by the PMD. Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/bnxt.ini b/doc/guides/nics/features/bnxt.ini index 78a7

[dpdk-dev] [PATCH v3 11/26] net/bnxt: add support to get fw version

This patch adds support for fw_version_get dev_op Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Avoid using dev_ops in the patch subject line

[dpdk-dev] [PATCH v3 09/26] net/bnxt: add support for set multicast addr list and MAC addr set

This patch adds support for set_mc_addr_list and mac_addr_set dev_ops Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Split the patch to document

[dpdk-dev] [PATCH v3 14/26] net/bnxt: add rxq/txq info_get

Add support for txq_info_get and rxq_info_get dev_ops Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Avoid using dev_ops in the patch subject l

[dpdk-dev] [PATCH v3 13/26] net/bnxt: add support for LRO

This patch adds support to enable and disable LRO To support this feature, the driver creates an aggregrator ring. When the hardware starts doing LRO, it sends a tpa_start completion. When the driver receives a tpa_end completion, it indicates that the LRO chaining is complete. Signed-off-by: Stee

[dpdk-dev] [PATCH v3 12/26] net/bnxt: add support to set MTU

This patch adds support to modify MTU using the set_mtu dev_op. To support frames > 2k, the PMD creates an aggregator ring. When a frame greater than 2k is received, it is fragmented and the resulting fragments are DMA'ed to the aggregator ring. Now the driver can support jumbo frames upto 9500 byt

[dpdk-dev] [PATCH v3 15/26] net/bnxt: add code to support VLAN pvid

This patch adds code to support vlan_pvid_set dev_op Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Avoid using dev_ops in the patch subject li

[dpdk-dev] [PATCH v3 17/26] doc: update default.ini to add LED support

Update default.ini to indicate LED on/off support Signed-off-by: Ajit Khaparde --- doc/guides/nics/features/default.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/default.ini b/doc/guides/nics/features/default.ini index cafc6c7..5549acd 100644 --- a/doc/guides/n

[dpdk-dev] [PATCH v3 19/26] net/bnxt: add support for tx loopback, set vf mac and queues drop

Add functions rte_pmd_bnxt_set_tx_loopback, rte_pmd_bnxt_set_all_queues_drop_en and rte_pmd_bnxt_set_vf_mac_addr to configure tx_loopback, queue_drop and VF MAC address setting in the hardware. It also adds the necessary functions to send the HWRM commands to the firmware. Signed-off-by: Steeven L

[dpdk-dev] [PATCH v3 16/26] net/bnxt: reorg the query stats code

1) Use hwrm_stat_ctx_query command to query statistics Using hwrm_stat_ctx_query command will allow polling the statistics from hardware instead of using the current push model from the hardware which does a DMA of the stats to the host at fixed intervals. 2) Use the rx_mbuf_alloc_fail to track mbu

[dpdk-dev] [PATCH v3 18/26] net/bnxt: add support for led on/off

This patch adds support for dev_led_on/off dev_ops HWRM calls added: bnxt_hwrm_port_led_qcaps() bnxt_hwrm_port_led_cfg() Signed-off-by: Ajit Khaparde -- v1-v2: - rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Update bnxt.ini indicating support for LED on/o

[dpdk-dev] [PATCH v3 21/26] net/bnxt: add support to get and clear VF specific stats

This patch adds code to get and clear VF stats. It also adds the necessary HWRM structures to send the command to the firmware. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - Rebasing to next-net tree

[dpdk-dev] [PATCH v3 20/26] net/bnxt: add support for set VF QOS and MAC anti spoof

This patch adds support to 1) enable VF MAC anti spoof. 2) QOS configuration for specified VF. Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - Rebasing to next-net tree - Use net/bnxt instead of just bnxt in patch subject - Ad

[dpdk-dev] [PATCH v3 22/26] net/bnxt: add code to determine the Rx status of VF

This patch adds code to determine the Rx status of a VF. It adds the rte_pmd_bnxt_get_vf_rx_status call, which calculates the VNIC count of the function to get the Rx status. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review

[dpdk-dev] [PATCH v3 23/26] net/bnxt: add support to add a VF MAC address

This patch adds support to allocate a filter and program it in the hardware for every MAC address added to the specified function. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - Rebasing to next-net

[dpdk-dev] [PATCH v3 24/26] net/bnxt: add code to configure a default VF VLAN

This patch adds code to insert a default VF VLAN. Also track the current default VLAN per vnic for the VF. When setting the default VLAN, avoid setting it to the current value. Signed-off-by: Stephen Hurd Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other revi

[dpdk-dev] [PATCH v3 25/26] net/bnxt: add support to set VF rxmode

This patch adds support to configure the VF L2 Rx settings. The per VF setting is maintained in bnxt_child_vf_info.l2_rx_mask Signed-off-by: Ajit Khaparde -- v1->v2: regroup related patches and incorporate other review comments v2->v3: - Rebasing to next-net tree - Use net/bnxt instead of ju

[dpdk-dev] [PATCH v3 26/26] doc: update release notes

Update release doc briefly describing updates to bnxt PMD. v1->v2: - Rebasing to next-net tree - Use doc in the patch subject line Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_17_08.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/doc/guides/rel_notes/rel

Re: [dpdk-dev] [PATCH] eventdev: clarify the worker thread workflow

-Original Message- > Date: Thu, 18 May 2017 12:20:59 +0100 > From: Bruce Richardson > To: Jerin Jacob > CC: dev@dpdk.org, harry.van.haa...@intel.com, hemant.agra...@nxp.com, > gage.e...@intel.com, nipun.gu...@nxp.com, narender.vang...@intel.com > Subject: Re: [dpdk-dev] [PATCH] eventdev:

  1   2   >