On Wed, May 31, 2017 at 03:20:00PM +0100, Bruce Richardson wrote: > On Tue, May 30, 2017 at 10:30:35AM +0200, Jacek Piasecki wrote: > > Extend existing cfgfile library with providing new API functions: > > rte_cfgfile_create() - create new cfgfile object > > rte_cfgfile_add_section() - add new section to existing cfgfile object > > rte_cfgfile_add_entry() - add new entry to existing cfgfile object > > in specified section > > This modification allows to create a cfgfile on runtime and > > opens up the possibility to have applications dynamically build up > > a proper DPDK configuration, rather than having to have a pre-existing one. > > > > Signed-off-by: Jacek Piasecki <jacekx.piase...@intel.com> > > Hi, > > There seems to be some additional work in this patch apart from what is > described above, which may go into a separate patchset to improve > readability.
s/a separate patchset/separate patches/ > For example, the dependency on librte_eal (apart from one > header) is removed, so those changes could go in a separate patch. > Also, you might consider moving the rework of the load API to a separate > patch, i.e. have one patch add the new APIs, and then a second patch > rework existing load code to be simpler using those APIs. >
