Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: update license and copyright for hw and mc files

2017-04-25 Thread Thomas Monjalon
21/04/2017 12:56, akhil.go...@nxp.com: > From: Akhil Goyal > > license and copyright for hw and mc files are made consistent > as per the other dpaa2 dual licensed files. > > Signed-off-by: Akhil Goyal Applied, thanks

[dpdk-dev] [PATCH 01/11] net/qede: fix default MAC address handling

2017-04-25 Thread Rasesh Mody
From: Harish Patil - In qede_mac_addr_set(), in order to configure default MAC address we first delete the existing MAC address before trying to add new one. During init time, there is no MAC filter to begin with, so trying to remove a non-existing MAC address causes a firmware exception. This ca

[dpdk-dev] [PATCH 02/11] net/qede: fix reset of fastpath rings after port stop

2017-04-25 Thread Rasesh Mody
From: Harish Patil Perform reset of the fastpath RX/TX rings after stopping device port and not while starting the ports. Fixes: cfe28a988565 ("net/qede: support unequal number of Rx/Tx queues") Cc: sta...@dpdk.org Signed-off-by: Harish Patil --- drivers/net/qede/qede_rxtx.c |5 + 1 f

[dpdk-dev] [PATCH 03/11] net/qede: fix LRO handling issue

2017-04-25 Thread Rasesh Mody
From: Harish Patil - Add a common routine to handle ETH_RX_CQE_TYPE_TPA_CONT and ETH_RX_CQE_TYPE_TPA_END. - Remove enum qede_agg_state since there is no need to maintain aggregation state. - Modify the segment chaining logic by tracking head and tail TPA segments of each aggregation. - Add more d

[dpdk-dev] [PATCH 04/11] net/qede: fix coverity detected defects

2017-04-25 Thread Rasesh Mody
From: Harish Patil This defect is a functional issue where the RX CQE pointer remains uninitialized in the LRO code path which can cause null pointer exception while accessing VLAN or RSS hash value from CQE. Fixes: 29540be7efce ("net/qede: support LRO/TSO offloads") Coverity issue: 143474 Sign

[dpdk-dev] [PATCH 05/11] net/qede: use new stripped VLAN mbuf flags

2017-04-25 Thread Rasesh Mody
From: Harish Patil Use new mbuf flags PKT_RX_VLAN_STRIPPED and PKT_RX_QINQ_STRIPPED introduced by the patch: commit b37b528d957c ("mbuf: add new Rx flags for stripped VLAN") Signed-off-by: Harish Patil --- drivers/net/qede/qede_ethdev.c |1 + drivers/net/qede/qede_ethdev.h |1 + driver

[dpdk-dev] [PATCH 09/11] net/qede/base: fix macro ecore mfw set field

2017-04-25 Thread Rasesh Mody
Fix ECORE_MFW_SET_FIELD macro Coverity issue: 1423907 Coverity issue: 1423908 Fixes: 0b6bf70d7ee3 ("net/qede/base: support previous driver unload") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore.h |2 +- drivers/net/qede/base/mcp_public.h |6 +++--- 2 files changed, 4 i

[dpdk-dev] [PATCH 07/11] net/qede: fix FW version string display for SRIOV

2017-04-25 Thread Rasesh Mody
In SRIOV testing, print adapter info shows firmware version used by PF, this patch provides fix to populate correct firmware version used by VF. Fixes: 86a2265e59d7 ("qede: add SRIOV support") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_main.c | 13 +

[dpdk-dev] [PATCH 08/11] net/qede/base: fix coverity issues

2017-04-25 Thread Rasesh Mody
Remove unused code to address coverity issues and address a code flow issue. Coverity issue: 1379468 Coverity issue: 1379521 Coverity issue: 1379522 Coverity issue: 1379523 Coverity issue: 1423918 Fixes: 86a2265e59d7 ("qede: add SRIOV support") Fixes: ec94dbc57362 ("qede: add base driver") Fixes:

[dpdk-dev] [PATCH 06/11] net/qede: remove IPV4/IPV6 as valid ntuple flows

2017-04-25 Thread Rasesh Mody
From: Harish Patil Firmware supports ntuple configuration which is always based on 4-tuples. So remove RTE_ETH_FLOW_FRAG_IPV4 and RTE_ETH_FLOW_FRAG_IPV6 as valid flows. Also merge the two switch statements into one. Fixes: 622075356e8f ("net/qede: support ntuple and flow director filter") Signe

[dpdk-dev] [PATCH 10/11] net/qede/base: fix find zero bit macro

2017-04-25 Thread Rasesh Mody
Use appropriate operater for if condition Coverity issue: 1379399 Coverity issue: 1379404 Fixes: ec94dbc57362 ("qede: add base driver") Cc: sta...@dpdk.org Signed-off-by: Rasesh Mody --- drivers/net/qede/base/bcm_osal.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/d

[dpdk-dev] [PATCH 11/11] net/qede: fix to limit CFLAGS to base files

2017-04-25 Thread Rasesh Mody
From: Rasesh Mody Changes included in this fix - limit CFLAGS to base files - fix to remove/mark unused members - add checks for debug config option - make qede_set_mtu() and qede_udp_dst_port_del() static and others non-static as appropriate - move local APIs qede_vlan_offload_set() and

Re: [dpdk-dev] [RFC PATCH 1/2] ethdev: add function to adjust number of descriptors

2017-04-25 Thread Andrew Rybchenko
Hi, On 04/24/2017 06:13 PM, Thomas Monjalon wrote: Hi, 02/03/2017 14:05, Andrew Rybchenko: From: Roman Zhukov Check that numbers of Rx and Tx descriptors satisfy descriptors limits from the Ethernet device information, otherwise adjust them to boundaries. Signed-off-by: Roman Zhukov Signed

[dpdk-dev] [PATCH] net/mlx5: fix ipv6 flow pattern item

2017-04-25 Thread Nelio Laranjeiro
Only masked bits must be set in Verbs specification for a rule to be valid. Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[dpdk-dev] [PATCH v2 00/13] Fixes for exported headers

2017-04-25 Thread Adrien Mazarguil
This series addresses the remaining issues seen by check-includes.sh in exported headers. Most of them may cause compilation errors in user applications: - Dependencies on missing includes. - Non-standard C/C++ constructs usage without associated safeties. - Missing C++ awareness blocks. It also

[dpdk-dev] [PATCH v2 01/13] crypto/scheduler: fix missing includes

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from build/include/rte_cryptodev_scheduler.h:37:0, from /tmp/check-includes.sh.5355.c:1: build/include/rte_cryptodev_scheduler_operations.h:43:30: error: unknown type name 'uint8_t' struct rte_cryptode

[dpdk-dev] [PATCH v2 02/13] eventdev: fix errors with strict compilation flags

2017-04-25 Thread Adrien Mazarguil
Exported headers must allow compilation with the strictest flags. This commit addresses the following errors: In file included from build/include/rte_eventdev_pmd.h:55:0, from /tmp/check-includes.sh.25816.c:1: build/include/rte_eventdev.h:908:8: error: struct has no named membe

[dpdk-dev] [PATCH v2 03/13] latency: fix missing includes in exported header

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following errors: In file included from build/include/rte_latencystats.h:43:0, from /tmp/check-includes.sh.6580.c:1: build/include/rte_metrics.h:91:2: error: unknown type name 'uint16_t' [...] In file included from /tmp/check-includes.sh.6580.c:1:0:

[dpdk-dev] [PATCH v2 04/13] net: fix missing include in exported header

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following errors: In file included from /tmp/check-includes.sh.18889.c:1:0: build/include/rte_net_crc.h:86:1: error: unknown type name 'uint32_t' [...] Fixes: 986ff526fb84 ("net: add CRC computation API") Cc: Jasvinder Singh Signed-off-by: Adrien Mazarguil --- lib

[dpdk-dev] [PATCH v2 05/13] vhost: fix errors with strict compilation flags

2017-04-25 Thread Adrien Mazarguil
Exported headers must allow compilation with the strictest flags. This commit addresses the following errors: In file included from /tmp/check-includes.sh.20132.c:1:0: build/include/rte_vhost.h:73:30: error: ISO C forbids zero-size array 'regions' [-Werror=pedantic] [...] Also: - Add C++

[dpdk-dev] [PATCH v2 08/13] bitrate: fix errors in exported header

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following error: In file included from /tmp/check-includes.sh.28023.c:1:0: build/include/rte_bitrate.h:82:2: error: unknown type name 'uint8_t' [...] It also adds C++ awareness to rte_bitrate.h. Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Cc: Rem

[dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Adrien Mazarguil
This commit addresses several errors related to missing includes such as: In file included from /tmp/check-includes.sh.15315.c:1:0: build/include/rte_avp_fifo.h:77:22: error: 'struct rte_avp_fifo' declared inside parameter list [-Werror] [...] build/include/rte_avp_fifo.h: In function 'avp

[dpdk-dev] [PATCH v2 06/13] mbuf: fix missing includes in exported header

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following errors: In file included from /tmp/check-includes.sh.681.c:1:0: build/include/rte_mbuf_ptype.h:587:35: error: unknown type name 'uint32_t' [...] build/include/rte_mbuf_ptype.h:662:51: error: unknown type name 'size_t' [...] Fixes: 288541c8ff9e ("mbuf: add

[dpdk-dev] [PATCH v2 09/13] efd: fix missing include in exported header

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from /tmp/check-includes.sh.8373.c:1:0: build/include/rte_efd.h:133:9: error: unknown type name 'uint8_t' [...] Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Cc: Byron Marohn Cc:

[dpdk-dev] [PATCH v2 10/13] metrics: fix errors in exported header

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from /tmp/check-includes.sh.21060.c:1:0: build/include/rte_metrics.h:91:2: error: unknown type name 'uint16_t' [...] It also adds C++ awareness to rte_metrics.h. Fixes: 349950ddb9c5 ("metrics: add information metrics lib

[dpdk-dev] [PATCH v2 11/13] ethdev: fix C++ errors in flow API

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from build/include/rte_flow_driver.h:50:0, from /tmp/check-includes.sh.1397.cc:1: build/include/rte_flow.h:428:2: error: expected primary-expression before '.' token [...] build/include/rte_flow.h:46

[dpdk-dev] [PATCH v2 12/13] ethdev: fix C++ errors in flow API (MPLS, GRE)

2017-04-25 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from build/include/rte_flow_driver.h:50:0, from /tmp/check-includes.sh.1397.cc:1: build/include/rte_flow.h:631:1: error: C99 designator 'label_tc_s' outside aggregate initializer [...] build/include/

[dpdk-dev] [PATCH v2 13/13] ethdev: fix incomplete items in flow API

2017-04-25 Thread Adrien Mazarguil
E-Tag and NVGRE pattern items have been added hastily without updating documentation nor testpmd. This commit also adds default masks for these items based on the ixgbe implementation. Fixes: 99e7003831c3 ("net/ixgbe: parse L2 tunnel filter") Cc: sta...@dpdk.org Cc: Wei Zhao Cc: Wenzhuo Lu Sig

Re: [dpdk-dev] [PATCH] usertools: use /sys/devices/system/cpu for CPU layout script

2017-04-25 Thread Thomas Monjalon
Hi, 31/03/2017 14:21, Andriy Berestovskyy: > Some platforms do not have core/socket info in /proc/cpuinfo. > > Signed-off-by: Andriy Berestovskyy > --- > usertools/cpu_layout.py | 53 > + > 1 file changed, 23 insertions(+), 30 deletions(-) Appli

Re: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup

2017-04-25 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bernard Iremonger > Sent: Monday, April 24, 2017 6:25 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi ; > Iremonger, Bernard ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopp

Re: [dpdk-dev] [PATCH v2 1/5] ethdev: introduce device removal event

2017-04-25 Thread Gaëtan Rivet
Hi Ferruh, On Fri, Apr 21, 2017 at 03:59:24PM +0100, Ferruh Yigit wrote: On 4/18/2017 1:17 PM, Gaetan Rivet wrote: This new API allows reacting to a device removal. A device removal is the sudden disappearance of a device from its bus. PMDs implementing support for this notification guarantee

Re: [dpdk-dev] [PATCH v2 4/5] app/testpmd: request link status interrupt

2017-04-25 Thread Gaëtan Rivet
On Fri, Apr 21, 2017 at 03:55:43PM +0100, Ferruh Yigit wrote: On 4/18/2017 1:17 PM, Gaetan Rivet wrote: For drivers supporting the LSC event, enable it. This allows to test LSC event support. Add the --no-lsc-interrupt parameter to explicitly disable the link status change interrupt. Signed-of

Re: [dpdk-dev] [PATCH 0/7] dpdk-devbind.py refactor

2017-04-25 Thread Thomas Monjalon
22/03/2017 15:11, Jerin Jacob: > This patchset refactor the dpdk-devbind.py script to > > 1) Optimize the bind and status operation delay(It is noticeable > when the system has fairly large number of PCIe device. For instance, > OCTEONTX system has around 170 PCIe devices and it takes around > 19

Re: [dpdk-dev] [PATCH v2 4/5] app/testpmd: request link status interrupt

2017-04-25 Thread Ferruh Yigit
On 4/25/2017 10:07 AM, Gaëtan Rivet wrote: > On Fri, Apr 21, 2017 at 03:55:43PM +0100, Ferruh Yigit wrote: >> On 4/18/2017 1:17 PM, Gaetan Rivet wrote: >>> For drivers supporting the LSC event, enable it. >>> This allows to test LSC event support. >>> >>> Add the --no-lsc-interrupt parameter to exp

Re: [dpdk-dev] [PATCH 1/2] app/testpmd: load cmdline commands from file at startup

2017-04-25 Thread Wu, Jingjing
> -Original Message- > From: Allain Legacy [mailto:allain.leg...@windriver.com] > Sent: Saturday, April 1, 2017 3:13 AM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [PATCH 1/2] app/testpmd: load cmdline commands from file at startup > > Adds support to testpmd to load a set of cmdli

Re: [dpdk-dev] [PATCH 2/2] app/testpmd: load cmdline commands from file at runtime

2017-04-25 Thread Wu, Jingjing
> -Original Message- > From: Allain Legacy [mailto:allain.leg...@windriver.com] > Sent: Saturday, April 1, 2017 3:13 AM > To: Wu, Jingjing > Cc: dev@dpdk.org > Subject: [PATCH 2/2] app/testpmd: load cmdline commands from file at > runtime > > Adds support to testpmd to load a set of cmd

Re: [dpdk-dev] [PATCH] devtools: add git log checks for vsi, lsc, crc

2017-04-25 Thread Thomas Monjalon
17/04/2017 15:13, Ferruh Yigit: > Signed-off-by: Ferruh Yigit Applied, thanks

Re: [dpdk-dev] [PATCH v2 06/13] mbuf: fix missing includes in exported header

2017-04-25 Thread Olivier Matz
On Tue, 25 Apr 2017 10:30:00 +0200, Adrien Mazarguil wrote: > This commit addresses the following errors: > > In file included from /tmp/check-includes.sh.681.c:1:0: > build/include/rte_mbuf_ptype.h:587:35: error: unknown type name 'uint32_t' > [...] > build/include/rte_mbuf_ptype.h:662:51:

Re: [dpdk-dev] [PATCH v2 00/13] Fixes for exported headers

2017-04-25 Thread Ferruh Yigit
On 4/25/2017 9:29 AM, Adrien Mazarguil wrote: > This series addresses the remaining issues seen by check-includes.sh in > exported headers. Most of them may cause compilation errors in user > applications: > > - Dependencies on missing includes. > - Non-standard C/C++ constructs usage without asso

Re: [dpdk-dev] [PATCH] net/i40e: fix array bounds

2017-04-25 Thread Ferruh Yigit
On 4/25/2017 6:01 AM, Jingjing Wu wrote: > Fix array bounds when set default ptype mapping. > > Fixes: 62e94f7f66fb ("net/i40e: configure packet type mapping") > Signed-off-by: Jingjing Wu Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH 1/3] doc: fix missing backquotes

2017-04-25 Thread Gaetan Rivet
Fixes: ea85e7d711b6 ("ethdev: retrieve xstats by ID") Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/release_17_05.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index ad20e86..eb5b30f

[dpdk-dev] [PATCH 3/3] doc: add lsc and rmv interrupt to testpmd user guide

2017-04-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/testpmd_app_ug/run_app.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index df5a0ee..a72c7e3 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guid

[dpdk-dev] [PATCH 2/3] doc: add device removal event to release note

2017-04-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/release_17_05.rst | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index eb5b30f..293d3fd 100644 --- a/doc/guides/rel_notes/release_17_05.r

[dpdk-dev] [PATCH v2 1/4] doc: fix missing backquotes

2017-04-25 Thread Gaetan Rivet
Fixes: ea85e7d711b6 ("ethdev: retrieve xstats by ID") Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/release_17_05.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index ad20e86..eb5b30f

[dpdk-dev] [PATCH v2 2/4] doc: add device removal event to release note

2017-04-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/rel_notes/release_17_05.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index eb5b30f..602ef8e 100644 --- a/doc/guides/rel_notes/release_17_05.rst +++ b/doc/gui

[dpdk-dev] [PATCH v2 3/4] doc: add LSC and RMV interrupt to testpmd user guide

2017-04-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- doc/guides/testpmd_app_ug/run_app.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst index df5a0ee..a72c7e3 100644 --- a/doc/guides/testpmd_app_ug/run_app.rst +++ b/doc/guid

[dpdk-dev] [PATCH v2 4/4] devtools: add git log checks for rmv

2017-04-25 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- devtools/check-git-log.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh index 8449d4f..f081ff5 100755 --- a/devtools/check-git-log.sh +++ b/devtools/check-git-log.sh @@ -132,6 +132,7 @@ bad=$(echo "$headli

Re: [dpdk-dev] [PATCH] usertools: use /sys/devices/system/cpu for CPU layout script

2017-04-25 Thread Andriy Berestovskyy
Hi, On 25.04.2017 10:48, Thomas Monjalon wrote: Do you think it is really a good idea to keep and maintain this script in DPDK? It was intentionnally not exported in "make install". I think it is a bit out of scope, and I wonder which alternatives do we have? I know hwloc/lstopo, but there are p

Re: [dpdk-dev] [PATCH] net/mlx5: fix ipv6 flow pattern item

2017-04-25 Thread Ferruh Yigit
On 4/25/2017 9:27 AM, Nelio Laranjeiro wrote: > Only masked bits must be set in Verbs specification for a rule to be valid. > > Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions") > > Signed-off-by: Nelio Laranjeiro > Acked-by: Adrien Mazarguil Applied to dpdk-next-net/maste

Re: [dpdk-dev] [PATCH v2] net/i40e: mbuf alloc failed counter not incremented

2017-04-25 Thread Zhang, Helin
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 24, 2017 1:47 PM > To: Legacy, Allain (Wind River); Zhang, Helin; Wu, Jingjing > Cc: dev@dpdk.org; Peters, Matt (Wind River) > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: mbuf alloc failed counter not > incremented Actually

Re: [dpdk-dev] [PATCH] usertools: use /sys/devices/system/cpu for CPU layout script

2017-04-25 Thread Thomas Monjalon
25/04/2017 12:19, Andriy Berestovskyy: > Hi, > > On 25.04.2017 10:48, Thomas Monjalon wrote: > > Do you think it is really a good idea to keep and maintain this script > > in DPDK? It was intentionnally not exported in "make install". > > I think it is a bit out of scope, and I wonder which altern

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 11/13] ethdev: fix C++ errors in flow API

2017-04-25 Thread Shahaf Shuler
Tuesday, April 25, 2017 11:30 AM, Adrien Mazarguil: > This commit addresses the following compilation errors: > > In file included from build/include/rte_flow_driver.h:50:0, > from /tmp/check-includes.sh.1397.cc:1: > build/include/rte_flow.h:428:2: error: expected primary-expre

Re: [dpdk-dev] [PATCH v2 12/13] ethdev: fix C++ errors in flow API (MPLS, GRE)

2017-04-25 Thread Shahaf Shuler
Tuesday, April 25, 2017 11:30 AM, Adrien Mazarguil: > This commit addresses the following compilation errors: > > In file included from build/include/rte_flow_driver.h:50:0, > from /tmp/check-includes.sh.1397.cc:1: > build/include/rte_flow.h:631:1: error: C99 designator 'label_

[dpdk-dev] [PATCH] doc: update mlx4 and mlx5 release notes

2017-04-25 Thread Shahaf Shuler
Update release notes for 17.05. Signed-off-by: Shahaf Shuler --- doc/guides/rel_notes/release_17_05.rst | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/doc/guides/rel_notes/release_17_05.rst b/doc/guides/rel_notes/release_17_05.rst index ad20e8608..7d1c77

[dpdk-dev] [PATCH v3] net/i40e: mbuf alloc failed counter not incremented

2017-04-25 Thread Allain Legacy
From: Matt Peters When an mbuf alloc fails during the mempool get operation for the i40e bulk alloc receive function, the rx_mbuf_alloc_failed counter is not incremented to record the error. This fix ensures consistency with the other i40e receive procedures and other net drivers. Signed-off-by

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Legacy, Allain
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 25, 2017 4:30 AM <...> > > +#include > #ifdef __KERNEL__ > #include > +#else > +#include > +#include > +#include > +#include > +#endif I compiled this in our environment and fo

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Adrien Mazarguil
On Tue, Apr 25, 2017 at 12:31:56PM +, Legacy, Allain wrote: > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Tuesday, April 25, 2017 4:30 AM > <...> > > > > +#include > > #ifdef __KERNEL__ > > #include > > +#else > > +#include > > +#i

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Legacy, Allain
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 25, 2017 8:50 AM <...> > > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__. > > Missed that one, however I suggest either: > > #ifndef __KERNEL__ around RTE_STD_C11 > >

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps

2017-04-25 Thread Wu, Jingjing
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Oleg Kuporosov > Sent: Thursday, October 13, 2016 10:35 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet > timestamps > > Implemented two methods of control > > - b

[dpdk-dev] [PATCH] lib/cryptodev: fix API aad comments

2017-04-25 Thread Arek Kusztal
Fix comments concerning aad sizes in Cryptodev API. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Signed-off-by: Arek Kusztal --- lib/librte_cryptodev/rte_crypto_sym.h | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/librte_

[dpdk-dev] [PATCH] doc: add limitation of aad size to qat rst file

2017-04-25 Thread Arek Kusztal
Add limitation of additional authenticated data (AAD) in Intel QuickAssist Technology driver rst file Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: Arek Kusztal --- doc/guides/cryptodevs/qat.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/cryp

[dpdk-dev] [PATCH] crypto/openssl: fix aad capabilities for AES-GCM

2017-04-25 Thread Arek Kusztal
Fix aad capabilities for AES-GCM authtentication, aad is changed from range 8-12 to 0-65535 Fixes: 8a9867a635c0 ("crypto/openssl: rename libcrypto to openssl") Signed-off-by: Arek Kusztal --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-

[dpdk-dev] [PATCH] crypto/qat: fix aad capabilities for AES-GCM

2017-04-25 Thread Arek Kusztal
Fix aad capabilities for AES-GCM authtentication, aad is changed from range 8-12 to 0-240 Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: Arek Kusztal --- drivers/crypto/qat/qat_crypto_capabilities.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) dif

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Adrien Mazarguil
On Tue, Apr 25, 2017 at 01:00:46PM +, Legacy, Allain wrote: > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Tuesday, April 25, 2017 8:50 AM > <...> > > > 2) RTE_STD_C11 needs to be included in the #ifdef __KERNEL__. > > > > Missed that on

Re: [dpdk-dev] [PATCH v2 07/13] net/avp: fix errors in exported headers

2017-04-25 Thread Legacy, Allain
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 25, 2017 10:49 AM <...> > > Thank you. > > Can I add your acked-by line directly assuming all the above is done as > described? Yes.

Re: [dpdk-dev] [PATCH v2 02/13] eventdev: fix errors with strict compilation flags

2017-04-25 Thread De Lara Guarch, Pablo
Hi Adrien, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Tuesday, April 25, 2017 9:30 AM > To: dev@dpdk.org > Cc: Jerin Jacob > Subject: [dpdk-dev] [PATCH v2 02/13] eventdev: fix errors with strict > compilation flags > > Exported hea

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix wrong array index

2017-04-25 Thread Pablo de Lara
Fixes: c0f87eb5252b ("cryptodev: change burst API to be crypto op oriented") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- examples/l2fwd-crypto/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index d7d

Re: [dpdk-dev] [PATCH v2 01/13] crypto/scheduler: fix missing includes

2017-04-25 Thread Zhang, Roy Fan
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 25, 2017 9:30 AM > To: dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: [PATCH v2 01/13] crypto/scheduler: fix missing includes > > This commit addresses the following compilation errors

Re: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for QinQ setup

2017-04-25 Thread Iremonger, Bernard
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Tuesday, April 25, 2017 9:55 AM > To: Iremonger, Bernard ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi ; > Iremonger, Bernard ; sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: check port is stopped for > QinQ

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API aad comments

2017-04-25 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, April 25, 2017 3:34 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Doherty, Declan > ; Kusztal, ArkadiuszX > > Subject: [PATCH] lib/cryptodev: fix API aad comments >

Re: [dpdk-dev] [PATCH] doc: add limitation of aad size to qat rst file

2017-04-25 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, April 25, 2017 3:40 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Kusztal, ArkadiuszX > > Subject: [PATCH] doc: add limitation of aad size to qat rst file > > Add

Re: [dpdk-dev] [PATCH] crypto/qat: fix aad capabilities for AES-GCM

2017-04-25 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, April 25, 2017 3:41 PM > To: dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > ; Griffin, John ; > Jain, Deepak K ; Kusztal, ArkadiuszX > > Subject: [PATCH] crypto/qat: fix aad capabilities for AES-GCM > > Fix aad

[dpdk-dev] [PATCH] mk: use extra cflags when linking apps with the compiler

2017-04-25 Thread Gage Eads
From: John Jacques When using the compiler to link applications, include EXTRA_CFLAGS. This is needed, for example, when cross-compiling, to pass --sysroot. GCC cross-compilers built with Yocto don't use the --with-sysroot option, making it necessary to pass --sysroot command-line option. Signed

Re: [dpdk-dev] [PATCH v2 04/13] net: fix missing include in exported header

2017-04-25 Thread Singh, Jasvinder
-Original Message- From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] Sent: Tuesday, April 25, 2017 9:30 AM To: dev@dpdk.org Cc: Singh, Jasvinder Subject: [PATCH v2 04/13] net: fix missing include in exported header This commit addresses the following errors: In file included

Re: [dpdk-dev] [PATCH 2/3] app/testpmd: enabled control for packet timestamps

2017-04-25 Thread Thomas Monjalon
Hi, 25/04/2017 16:02, Wu, Jingjing: > From: Oleg Kuporosov > > Implemented two methods of control > > > > - by --enable-timestamps CL testpmd application we can enable timestamping > > for all ports; > > - in interactive mode port config timestamps on|off is able to > > configure timestampin

[dpdk-dev] [PATCH] lib/cryptodev: fix API digest length comments

2017-04-25 Thread Fiona Trahe
Fix misleading comments clarifying setting of digest length. Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto devices") Cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- lib/librte_cryptodev/rte_crypto_sym.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions

[dpdk-dev] [PATCH] ip_frag: free mbufs on reassembly table destroy

2017-04-25 Thread Allain Legacy
From: Dahir Osman The rte_ip_frag_table_destroy procedure simply releases the memory for the table without freeing the packet buffers that may be referenced in the hash table for in-flight or incomplete packet reassembly operations. To prevent leaked mbufs go through the list of fragments and fr

Re: [dpdk-dev] [PATCH v3] net/i40e: mbuf alloc failed counter not incremented

2017-04-25 Thread Zhang, Helin
> -Original Message- > From: Allain Legacy [mailto:allain.leg...@windriver.com] > Sent: Tuesday, April 25, 2017 8:29 PM > To: Zhang, Helin; Wu, Jingjing > Cc: dev@dpdk.org; Peters, Matt (Wind River) > Subject: [PATCH v3] net/i40e: mbuf alloc failed counter not incremented > > From: Matt

[dpdk-dev] [PATCH v1] doc: Merge l3fwd and l3fwd-acl documentation files

2017-04-25 Thread Ravi Kerur
Merge relevant contents of l3fwd and l3fwd-acl documentation. Modify l3fwd document with ACL specific information. Remove l3fwd-acl documentation file. Signed-off-by: Ravi Kerur --- doc/guides/sample_app_ug/img/ipv4_hash_rule.svg| 158 + doc/guides/sample_app_ug/img/ipv4_lpm_rule.svg

[dpdk-dev] [PATCH] bnxt: Add new device ids

2017-04-25 Thread Ajit Khaparde
Add support for new device ids. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 5dc3ff0..7805221 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers

Re: [dpdk-dev] [PATCH v6 0/5] Extended xstats API in ethdev library to allow grouping of stats

2017-04-25 Thread Roger B Melton
On 4/24/17 11:49 AM, Mcnamara, John wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon Sent: Monday, April 24, 2017 1:41 PM To: Kozak, KubaX Cc: dev@dpdk.org; Olivier Matz ; Van Haaren, Harry ; Jain, Deepak K ; Piasecki, JacekX Subject: Re: [d

Re: [dpdk-dev] [PATCH] net/virtio-user: fix recognize physical devices

2017-04-25 Thread Yuanhan Liu
On Fri, Apr 21, 2017 at 02:28:09AM +, Jianfeng Tan wrote: > Segfault happens when using virtio-user after commit 7f0a669e7b04 > ("ethdev: add allocation helper for virtual drivers"). > > It's due to we use ethdev->device to recognize physical devices, > but after above commit, this field is al

[dpdk-dev] custom align for mempool elements

2017-04-25 Thread Gregory Etelson
Signed-off-by: Gregory Etelson --- lib/librte_mempool/rte_mempool.c | 27 --- lib/librte_mempool/rte_mempool.h | 1 + 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index f65310f..c780df3

[dpdk-dev] [PATCH 3/3] net/virtio: fix link status always being down

2017-04-25 Thread Jianfeng Tan
The virtio port link status will always be DOWN: The commit aa9f06061765 ("net/virtio: fix link status always being up") introduces a flag to help checking the status. If this flag is not set, status will be always down. However, in dev start, this flag is set after link status update, then we mis

[dpdk-dev] [PATCH 1/3] net/virtio: fix wrong MSI-X for modern devices

2017-04-25 Thread Jianfeng Tan
The field, use_msix, in struct virtio_hw is not updated for modern device, and is always zero. And now we depend on the status feature and MSI-X to report LSC support (which is also not a correct behavior). As a result, LSC is always disabled for modern devices. Te fix this, we just recognize MSI-

[dpdk-dev] [PATCH 0/3] Some fixes on virtio LSC

2017-04-25 Thread Jianfeng Tan
Patch 1: fix wrong MSI-X for modern devices so that LSC is always not available. Patch 2: clean up LSC setting. Patch 3: fix link status always being down. Signed-off-by: Jianfeng Tan Jianfeng Tan (3): net/virtio: fix wrong MSI-X for modern devices net/virtio: clean up LSC setting

[dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-25 Thread Jianfeng Tan
Clean up LSC setting: - LSC flag is set in several places, but only the last one takes effect; so we just keep the last one. - As we already change to use capability list to detect MSI-X, remove the redundant MSI-X detection in legacy devices. Signed-off-by: Jianfeng Tan --- drivers/

[dpdk-dev] Too much print of testpmd

2017-04-25 Thread Lu, Wenzhuo
Hi Gaetan, When using DPDK PF + DPDK VF, there's too much print like, Port 0: VF Mbox event Port 0: VF Mbox event Port 0: VF Mbox event Port 0: VF Mbox event Port 0: VF Mbox event Port 0: VF Mbox event Port 0: VF Mbox event Port 0: VF Mbox event Port 0: VF Mbox event Make it a little hard

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-25 Thread Yuanhan Liu
On Wed, Apr 26, 2017 at 04:52:50AM +, Jianfeng Tan wrote: > Clean up LSC setting: Firstly, this patch does two things. There should be two patches. > - LSC flag is set in several places, but only the last one takes > effect; so we just keep the last one. > - As we already change to us

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-25 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, April 26, 2017 1:33 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting > > On Wed, Apr 26,

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-25 Thread Yuanhan Liu
On Wed, Apr 26, 2017 at 05:44:05AM +, Tan, Jianfeng wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Wednesday, April 26, 2017 1:33 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net > >

[dpdk-dev] [PATCH] doc: enic SR-IOV configurations

2017-04-25 Thread John Daley
Document SR-IOV passthrough setup and limitations for enic PMD. Signed-off-by: John Daley --- doc/guides/nics/enic.rst | 94 1 file changed, 94 insertions(+) diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst index c535b589c..8f8ae1

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-25 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, April 26, 2017 1:52 PM > To: Tan, Jianfeng > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net; > Michael S. Tsirkin > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting

[dpdk-dev] dpdk-devbind can't be used misc with kernel tools

2017-04-25 Thread Tu, LijuanX A
Hi Guduri, I am a tester from intel dpdk team. I get a issues on usertools/dpdk-devbind.py With the usertools/dpdk-devbind.py , I can't bind driver as expect. I use the "dpdk-devbind.py" bind pci to igb_uio, then I using kernel tools bind pci to ixgbe, I can bind pci to igb_uio successfully ,

[dpdk-dev] [PATCH] examples/l3fwd-power: fix zero rxq handling

2017-04-25 Thread Jingjing Wu
If the number of rx queues is zero, it is meaningless to enable rx interrupt. This patch fixes it. Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- examples/l3fwd-power/main.c | 6 ++ 1 file chan