Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-05 Thread Ferruh Yigit
On 2/4/2017 3:36 AM, Jingjing Wu wrote: > Some Tx offload flags are missed in bitmask of all supported packet > Tx flags by i40e. > This patch fixes it. > > CC: helin.zh...@intel.com > Fixes: 3f33e643e5c6 ("net/i40e: add Tx preparation") > Signed-off-by: Jingjing Wu > --- > drivers/net/i40e/i40e

[dpdk-dev] bnx2x and VFIO

2017-02-05 Thread Chas Williams
This PMD driver doesn't seem to work with VFIO.  I haven't had time to look into it very closely, so I was going to ask here first just in case someone had any ideas why this might be the case.  Thanks for any pointers here!

Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags

2017-02-05 Thread Ananyev, Konstantin
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Saturday, February 4, 2017 3:36 AM > To: dev@dpdk.org > Cc: Wu, Jingjing ; Ananyev, Konstantin > > Subject: [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags > > Add missed flags to bitmask of all supported packet

Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags

2017-02-05 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin > Sent: Sunday, February 5, 2017 11:59 AM > To: Wu, Jingjing ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx > flags > > Hi Jingjing, > > > >

Re: [dpdk-dev] [PATCH v4 4/6] eventdev: implement PMD registration functions

2017-02-05 Thread Jerin Jacob
On Thu, Feb 02, 2017 at 11:20:09AM +, Nipun Gupta wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jerin Jacob > > Sent: Wednesday, December 21, 2016 14:55 > > To: dev@dpdk.org > > Cc: thomas.monja...@6wind.com; bruce.richard...@intel.com; Hem

Re: [dpdk-dev] [PATCH v3 0/3] xen: netfront poll mode driver

2017-02-05 Thread Thomas Monjalon
Hi Jan, 2016-03-22 10:55, Jan Blunck: > v3 changes: > - removed fake PCI interface > - removed struct virt_eth_driver > - check for UIO name and version > - added basic documentation > > Jan Blunck (3): > xen: Add UIO kernel driver > xen: Add netfront poll mode driver > xen: Add documentati

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-02-05 Thread Ivan Nardi
Hi guys any updates on this issue? We are facing a very similar problem. We have a server with 4 nics X710 4*10Gbit and the dpdk randomly failed to start with the error: PMD: eth_i40e_dev_init(): FW 4.40 API 1.4 NVM 04.05.03 eetrack 80001cd8 PMD: eth_i40e_dev_init(): Failed to sync phy type: -95

[dpdk-dev] [PATCH v2 1/6] net/tap: fix tap docs for device name

2017-02-05 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/guides/nics/tap.rst | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/guides/nics/tap.rst b/doc/guides/nics/tap.rst index 622b9e7..c4f207b 100644 --- a/doc/guides/nics/tap.rst +++ b/doc/guides/nics/tap.rst @@ -45,18 +45,18

[dpdk-dev] [PATCH v2 2/6] net/tap: remove redundant fds array

2017-02-05 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index c7b04bb..6d93eb7 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_e

[dpdk-dev] [PATCH v2 4/6] net/tap: fix multi-queue support

2017-02-05 Thread Keith Wiles
At the same time remove the code which created the first device queue at probe time. Now all queues are created during queue setup calls. Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 104 ++ 1 file changed, 34 insertions(+), 70 deletions(

[dpdk-dev] [PATCH v2 3/6] net/tap: remove unused variable and minor cleanup

2017-02-05 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 6d93eb7..61659bc 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth

[dpdk-dev] [PATCH v2 5/6] net/tap: cleanup log messages

2017-02-05 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 54 ++- 1 file changed, 28 insertions(+), 26 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 7c923a2..65e4bab 100644 --- a/drivers/net/tap/rte_eth_

[dpdk-dev] [PATCH v2 6/6] net/tap: link set down must be before close

2017-02-05 Thread Keith Wiles
Signed-off-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 65e4bab..966e91a 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-02-05 Thread Ivan Nardi
HI same issue with 17.02-rc2 It seems to me the problem I am facing is similar to the ones reported in these mails; if not, I apologize to have used this thread Ivan On 5 February 2017 at 16:30, Ivan Nardi wrote: > Hi guys > any updates on this issue? > We are facing a very similar problem. > W

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-02-05 Thread Zhang, Qi Z
Hi Ivan: I'm looking at this issue, but I can't repeat it on my environment both with X710x4 and XL710x1 Not sure if you could try below things to help narrow down this issue. 1) move i40e_dev_sync_phy_type call after i40e_set_fc call, to see if the problem still

Re: [dpdk-dev] i40e_aq_get_phy_capabilities() fails when using SFP+ with no link

2017-02-05 Thread Zhang, Helin
Hi guys There may have firmware dependencies, new DPDK version + old firmware version may not work. Please refer to below link to see what type of firmware has been validated with 16.11 DPDK. http://dpdk.org/doc/guides/rel_notes/release_16_11.html#tested-nics Then first, you need to upgrade your

Re: [dpdk-dev] [PATCH] net/i40e: fix parsing tunnel filter issue

2017-02-05 Thread Xing, Beilei
Hi Ferruh, Sorry for late reply due to Chinese New Year. > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 24, 2017 11:18 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix parsing tunnel filter issue >

[dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Wenzhuo Lu
It's not appropriate to call rte_eth_dev_info_get in PMD, as rte_eth_dev_info_get need to get info from PMD. Remove rte_eth_dev_info_get from PMD code and get the info directly. Signed-off-by: Wenzhuo Lu --- v2: - change is_ixgbe_pmd to is_device_supported to make it more generic. drivers/net/i

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 10:09:32AM +0800, Wenzhuo Lu wrote: [...] > static void ixgbe_dcb_init(struct ixgbe_hw *hw, struct ixgbe_dcb_config > *dcb_config); > -static int is_ixgbe_pmd(const char *driver_name); > +static int is_device_supported(struct rte_eth_dev *dev, struct eth_driver > *drv); >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
Hi Tiwei, > -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 10:31 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 10:09:32AM +0800, Wenzhuo Lu wrote: > [...] > > stati

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 10:41:28AM +0800, Lu, Wenzhuo wrote: > Hi Tiwei, > > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 10:31 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
Hi Tiwei, > -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 10:51 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 10:41:28AM +0800, Lu, Wenzhuo wrote: > > Hi Tiwei, >

Re: [dpdk-dev] [PATCH v2 2/5] net/i40e: fix bitmask of supported Tx flags

2017-02-05 Thread Wu, Jingjing
> > Functionally will be same, but what do you think about following, to make > easy to see what define adds: > > +#define I40E_TX_OFFLOAD_MASK (\ > + PKT_TX_IP_CKSUM |\ > + PKT_TX_IPV4 |\ > + PKT_TX_IPV6 |\ > +

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 10:59:42AM +0800, Lu, Wenzhuo wrote: > Hi Tiwei, > > > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 10:51 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
Hi Tiwei, > -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 11:08 AM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 10:59:42AM +0800, Lu, Wenzhuo wrote: > > Hi Tiwei, > >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 11:45:41AM +0800, Lu, Wenzhuo wrote: > Hi Tiwei, > > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 11:08 AM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > >

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Lu, Wenzhuo
> -Original Message- > From: Bie, Tiwei > Sent: Monday, February 6, 2017 12:57 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > On Mon, Feb 06, 2017 at 11:45:41AM +0800, Lu, Wenzhuo wrote: > > Hi Tiwei, > > > > >

[dpdk-dev] [PATCH 0/4] add eventdev vdev uninit support

2017-02-05 Thread Jerin Jacob
This patchset adds eventdev vdev uinit support and a unit test case to verify the same Jerin Jacob (4): eventdev: fix event driver name to eventdev lookup evendev: add vdev uninit support event/skeleton: add vdev uninit support app/test: unit test case to exercise eventdev vdev uninit ap

[dpdk-dev] [PATCH 1/4] eventdev: fix event driver name to eventdev lookup

2017-02-05 Thread Jerin Jacob
- Removed uninitialized max_devs value - Corrected dev assignment Fixes: 8ca610e0487c ("eventdev: implement the northbound APIs") Signed-off-by: Jerin Jacob --- lib/librte_eventdev/rte_eventdev_pmd.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_eventdev/rt

[dpdk-dev] [PATCH 2/4] evendev: add vdev uninit support

2017-02-05 Thread Jerin Jacob
Added eventdev vdev uninit support to release the resources allocated in eventdev vdev init. Signed-off-by: Jerin Jacob --- lib/librte_eventdev/rte_eventdev.c | 43 +--- lib/librte_eventdev/rte_eventdev_pmd.h | 12 +++- lib/librte_eventdev/rte_eventdev

[dpdk-dev] [PATCH 3/4] event/skeleton: add vdev uninit support

2017-02-05 Thread Jerin Jacob
Removed global index based device name generation as vdev uninit needs the exact driver name used vdev init. Signed-off-by: Jerin Jacob --- drivers/event/skeleton/skeleton_eventdev.c | 42 -- 1 file changed, 5 insertions(+), 37 deletions(-) diff --git a/drivers/event

[dpdk-dev] [PATCH 4/4] app/test: unit test case to exercise eventdev vdev uninit

2017-02-05 Thread Jerin Jacob
Signed-off-by: Jerin Jacob --- app/test/test_eventdev.c | 60 +++- 1 file changed, 59 insertions(+), 1 deletion(-) diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c index 042a446..e817838 100644 --- a/app/test/test_eventdev.c +++ b/app/t

Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get

2017-02-05 Thread Tiwei Bie
On Mon, Feb 06, 2017 at 01:17:30PM +0800, Lu, Wenzhuo wrote: > > -Original Message- > > From: Bie, Tiwei > > Sent: Monday, February 6, 2017 12:57 PM > > To: Lu, Wenzhuo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: clean up rte_eth_dev_info_get > > > > On Mon, Feb

[dpdk-dev] [PATCH v2] net/i40e: fix parsing tunnel filter issue

2017-02-05 Thread Beilei Xing
VNI of VXLAN is parsed wrongly. The root cause is that array vni in item VXLAN also uses network byte ordering. Fixes: d416530e6358 ("net/i40e: parse tunnel filter") Signed-off-by: Beilei Xing --- v2 changes: Use rte_be_to_cpu_32 api instead of the new function. drivers/net/i40e/i40e_flow.c |

[dpdk-dev] [PATCH] eventdev: limit port link operation to configured queues

2017-02-05 Thread Jerin Jacob
On port_setup, the link_map is updated only for configured number of event queues. Limit the port_links_get scan only to configured number of event queues. Also, Limit the port link and unlink queue validation to configured number of event queues. Fixes: 8ca610e0487c ("eventdev: implement the nort

[dpdk-dev] vhost user MTU and promisc mode

2017-02-05 Thread Tan, Jianfeng
Hi Maxime, Have seen that you submit a feature in QEMU, commit c5f048d8fb69 ("vhost-user: Add MTU protocol feature and op"). Appreciate your insights on: (1) Do you have plan to enable it in DPDK vhost user? (2) How about another similar feature, promisc mode enable/disable? Thanks, Jianfeng