Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags

[Ananyev, Konstantin]

> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ananyev, Konstantin
> Sent: Sunday, February 5, 2017 11:59 AM
> To: Wu, Jingjing <jingjing...@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx 
> flags
> 
> Hi Jingjing,
> 
> 
> > -----Original Message-----
> > From: Wu, Jingjing
> > Sent: Saturday, February 4, 2017 3:36 AM
> > To: dev@dpdk.org
> > Cc: Wu, Jingjing <jingjing...@intel.com>; Ananyev, Konstantin 
> > <konstantin.anan...@intel.com>
> > Subject: [PATCH v2 3/5] net/ixgbe: fix bitmask of supported Tx flags
> >
> > Add missed flags to bitmask of all supported packet Tx flags.
> >
> > CC: konstantin.anan...@intel.com
> > Fixes: 7829b8d52be0 ("net/ixgbe: add Tx preparation")
> > Signed-off-by: Jingjing Wu <jingjing...@intel.com>
> > ---
> >  drivers/net/ixgbe/ixgbe_rxtx.c | 17 ++++++++++++++++-
> >  1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> > index 36f1c02..8454581 100644
> > --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> > @@ -81,13 +81,28 @@
> >  #include "ixgbe_rxtx.h"
> >
> >  /* Bit Mask to indicate what bits required for building TX context */
> > +#ifdef RTE_LIBRTE_IEEE1588
> >  #define IXGBE_TX_OFFLOAD_MASK (                     \
> >             PKT_TX_VLAN_PKT |                \
> >             PKT_TX_IP_CKSUM |                \
> > +           PKT_TX_IPV4 |                    \
> >             PKT_TX_L4_MASK |                 \
> > +           PKT_TX_IEEE1588_TMST |           \
> >             PKT_TX_TCP_SEG |                 \
> >             PKT_TX_MACSEC |                  \
> > -           PKT_TX_OUTER_IP_CKSUM)
> > +           PKT_TX_OUTER_IP_CKSUM |          \
> > +           PKT_TX_OUTER_IPV4)
> > +#else
> > +#define IXGBE_TX_OFFLOAD_MASK (                     \
> > +           PKT_TX_VLAN_PKT |                \
> > +           PKT_TX_IP_CKSUM |                \
> > +           PKT_TX_IPV4 |                    \
> 
> Wonder why ixgbe doesn't have PKT_TX_IPV6?

Same question for e1000 and fm10k.
Also if you decided to go that way, you'll probably need to update 
TX_OFFLOAD_MASK
for enic and vmxnet3.
That's why I still think it would be much less hassle not to include
these flags (PKT_TX_IPV4 and PKT_TX_IPV6)  into TX_OFFLOAD_MASK at all.
Konstantin


> 
> > +           PKT_TX_L4_MASK |                 \
> > +           PKT_TX_TCP_SEG |                 \
> > +           PKT_TX_MACSEC |                  \
> > +           PKT_TX_OUTER_IP_CKSUM |          \
> > +           PKT_TX_OUTER_IPV4)
> > +#endif
> >
> >  #define IXGBE_TX_OFFLOAD_NOTSUP_MASK \
> >             (PKT_TX_OFFLOAD_MASK ^ IXGBE_TX_OFFLOAD_MASK)
> > --
> > 2.4.11