Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process

2017-01-09 Thread Xu, Qian Q
Fangfang, Could you help double confirm below error and the patchset ? Thanks. http://dpdk.org/patch/18975 > -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Monday, January 9, 2017 1:19 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; sta...@dpdk.org; X

Re: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wrong Rx/Tx method for secondary process

2017-01-09 Thread Wei, FangfangX
I've re-build it manually, it passed with this patch. -Original Message- From: Xu, Qian Q Sent: Monday, January 9, 2017 4:02 PM To: Yuanhan Liu ; Stephen Hemminger ; Wei, FangfangX Cc: dev@dpdk.org; sta...@dpdk.org; Liu, Yong Subject: RE: [dpdk-dev] [PATCH v3 2/6] net/virtio: fix wron

Re: [dpdk-dev] [PATCH v2] doc: fix a link in contribution guide

2017-01-09 Thread Mcnamara, John
> -Original Message- > From: Yongseok Koh [mailto:ys...@mellanox.com] > Sent: Friday, January 6, 2017 10:40 PM > To: Mcnamara, John > Cc: dev@dpdk.org; Yongseok Koh > Subject: [PATCH v2] doc: fix a link in contribution guide > > A referenced document in the Linux Kernel has been moved

Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd application guide.

2017-01-09 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Rami Rosen > Sent: Saturday, January 7, 2017 2:08 PM > To: dev@dpdk.org > Cc: Rosen, Rami > Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd application guide. > > This patch fixes a trivial typo in testpm

Re: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for new performance test application

2017-01-09 Thread Mrozowicz, SlawomirX
>-Original Message- >From: De Lara Guarch, Pablo >Sent: Friday, January 6, 2017 1:22 PM >To: Mrozowicz, SlawomirX ; >dev@dpdk.org >Cc: Mrozowicz, SlawomirX ; Doherty, >Declan ; Kerlin, Marcin > >Subject: RE: [dpdk-dev] [PATCH v2 2/3] lib/librte_cryptodev: functions for >new performance te

Re: [dpdk-dev] Bug in virtqueue_dequeue_burst_rx()

2017-01-09 Thread Gopakumar Choorakkot Edakkunni
Hi Yuanahn, Thanks for the response. Because of my filters, I missed this email completely, apologies for the late response ! I haven't tried breaking out of the loop to see if it will go back to working state - I have two testbeds, one using plain linux kvm + guest VM running 16.07 dpdk where I

Re: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in close

2017-01-09 Thread Wu, Jingjing
> > All of the VSI's are released in the call to i40e_vsi_release(pf->main_vsi) > at line > 1895. > This function is recursive and release all the VSI's. > > There is still a VSI address in pf->vmdq[i].vsi but calling > i40e_vsi_release(pf- > >vmdq[i].vsi); > Results in a segmentation fault. >

Re: [dpdk-dev] [PATCH v2 0/4] eal/common: introduce rte_memset and related test

2017-01-09 Thread Yang, Zhiyong
Hi, Thomas, Bruce, Konstantin: Any comments about the patchset? Do I need to modify anything? Thanks Zhiyong > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhiyong Yang > Sent: Tuesday, December 27, 2016 6:05 PM > To: dev@dpdk.org > Cc: yuanhan@

Re: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in close

2017-01-09 Thread Iremonger, Bernard
Hi Jingjing, > -Original Message- > From: Wu, Jingjing > Sent: Monday, January 9, 2017 9:44 AM > To: Iremonger, Bernard ; Lu, Wenzhuo > ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v7 26/27] net/i40e: fix segmentation fault in > close > > > > > All of the VSI's ar

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-09 Thread Remy Horton
On 09/01/2017 07:16, Yang, Qiming wrote: -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] [..] void +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int +fw_length) { + struct rte_eth_dev *dev; + + RTE_ETH_VALID_PORTID_OR_RET(por

[dpdk-dev] [PATCH] mempool: try to get objects from cache when the mempool is single consumer and multiple producer

2017-01-09 Thread Wenfeng Liu
We put objects to cache when the mempool is multiple producer, however the cache will not be used when it is single consumer. With this patch we can get objects from cache when the single consumer is happen to be one of the producers, and this improves performance. Signed-off-by: Wenfeng Liu --

[dpdk-dev] test

2017-01-09 Thread Liu, Yu Y

Re: [dpdk-dev] [PATCH] mempool: try to get objects from cache when the mempool is single consumer and multiple producer

2017-01-09 Thread Ananyev, Konstantin
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Wenfeng Liu > Sent: Monday, January 9, 2017 10:25 AM > To: olivier.m...@6wind.com > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] mempool: try to get objects from cache when the > mempool is single consumer a

Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5

2017-01-09 Thread Ferruh Yigit
On 1/8/2017 4:23 PM, Elad Persiko wrote: > Feature implemented at: > commit b007e98ccda9 ("net/mlx5: implement TSO data path") > commit 085c4137280a ("net/mlx5: support TSO in control plane") Hi Elad, Instead of send this a separate patch, it is better if you can send these updates with the patch

Re: [dpdk-dev] [PATCH v1 2/2] Test cases for rte_memcmp functions

2017-01-09 Thread Thomas Monjalon
2017-01-09 05:29, Wang, Zhihong: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2016-06-07 11:09, Wang, Zhihong: > > > From: Ravi Kerur [mailto:rke...@gmail.com] > > > > Zhilong, Thomas, > > > > > > > > If there is enough interest within DPDK community I can work on adding > > suppo

Re: [dpdk-dev] [PATCH] net/enic: add support for TSO

2017-01-09 Thread Ferruh Yigit
Hi John, On 1/7/2017 4:45 AM, John Daley wrote: > The enic TSO implementation requires that the length of the Eth/IP/TCP > headers be passed to the NIC. Other than that, it's just a matter of > setting the mss and offload mode on a per packet basis. > > In TSO mode, IP and TCP checksums are offlo

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-09 Thread Thomas Monjalon
2017-01-09 11:57, Tiwei Bie: > On Sun, Jan 08, 2017 at 08:39:55PM +0800, Ananyev, Konstantin wrote: > > > Well my first reply to this thread was asking why isn't the whole API > > > global > > > from the start then? > > > > That's good question, and my preference would always be to have the > > A

Re: [dpdk-dev] [PATCH] net/bnxt: Add support for new PCI IDs

2017-01-09 Thread Ferruh Yigit
On 1/6/2017 7:55 PM, Ajit Khaparde wrote: > Add suupport for PCI IDs which was removed as a part of > commit 953158857f194991 ("net/bnxt: remove support for few devices") > > Signed-off-by: Ajit Khaparde Applied to dpdk-next-net/master, thanks. (fixed referenced commit id)

Re: [dpdk-dev] [PATCH] net/af_packet: fix fd use after free

2017-01-09 Thread Ferruh Yigit
On 1/5/2017 2:33 PM, Timmons C. Player wrote: > When using the same file descriptor for both rx and tx, the > eth_dev_stop function would close the same fd twice. This > change prevents that from happening. > > Signed-off-by: Timmons C. Player Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PA

Re: [dpdk-dev] [PATCH] net/i40e: fix segment num in reassemble process

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 3:31 AM, Chenghu Yao wrote: > When freeing up last mbuf, start->nb_segs should be decremented > by one. See also ixgbe process. > > Signed-off-by: Chenghu Yao Fixes: 0e0da28cd888 ("i40e: add vector scatter Rx") CC:sta...@dpdk.org Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability

2017-01-09 Thread Bruce Richardson
On Wed, Dec 28, 2016 at 03:51:56AM +, Wu, Jingjing wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > > Sent: Tuesday, December 13, 2016 9:08 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message g

Re: [dpdk-dev] [PATCH] net/i40e: fix segment num in reassemble process

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 11:55 AM, Ferruh Yigit wrote: > On 1/9/2017 3:31 AM, Chenghu Yao wrote: >> When freeing up last mbuf, start->nb_segs should be decremented >> by one. See also ixgbe process. >> >> Signed-off-by: Chenghu Yao > > Fixes: 0e0da28cd888 ("i40e: add vector scatter Rx") > > CC:sta...@dpdk.or

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/af_packet: fix fd use after free

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 11:55 AM, Ferruh Yigit wrote: > On 1/5/2017 2:33 PM, Timmons C. Player wrote: >> When using the same file descriptor for both rx and tx, the >> eth_dev_stop function would close the same fd twice. This >> change prevents that from happening. >> >> Signed-off-by: Timmons C. Player >

Re: [dpdk-dev] [PATCH v4] null: fake PMD capabilities

2017-01-09 Thread Ferruh Yigit
On 12/14/2016 7:16 PM, Michał Mirosław wrote: > From: Paweł Małachowski > > This allows for testing code which needs offloads to be supported. > > Signed-off-by: Michał Mirosław > --- > drivers/net/null/rte_eth_null.c | 23 ++- > 1 file changed, 22 insertions(+), 1 deletion

Re: [dpdk-dev] [PATCH 2/5] net/mlx5: remove unessecary goto label

2017-01-09 Thread Ferruh Yigit
On 1/8/2017 3:42 PM, Elad Persiko wrote: > use_dseg label can be deleted as it happens without goto. > > Signed-off-by: Elad Persiko Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] doc: add tso capabilities feature for mlx5

2017-01-09 Thread Ferruh Yigit
On 1/8/2017 4:23 PM, Elad Persiko wrote: > Feature implemented at: > commit b007e98ccda9 ("net/mlx5: implement TSO data path") > commit 085c4137280a ("net/mlx5: support TSO in control plane") > > Signed-off-by: Elad Persiko > --- > doc/guides/nics/features/mlx4.ini | 1 + > doc/guides/nics/featu

[dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces

2017-01-09 Thread Yong Wang
In function "reassemble_packets()", the statement "end = secondlast;" is redundant since there is another assignment "start = end = NULL;" 3 lines below. BTW, I removed the redundant braces in the conditional statement "if (end->data_len > rxq->crc_len)". Signed-off-by: Yong Wang --- drivers/net

Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability

2017-01-09 Thread Thomas Monjalon
2017-01-09 12:02, Bruce Richardson: > On Wed, Dec 28, 2016 at 03:51:56AM +, Wu, Jingjing wrote: > > > > > > > -Original Message- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > > > Sent: Tuesday, December 13, 2016 9:08 AM > > > To: dev@dpdk.org > > > Subje

[dpdk-dev] Pocket loss on 82545EM Gigabit Ethernet Controller (Copper)

2017-01-09 Thread Keren Hochman
Hello, I have a VM with network card: 82545EM Gigabit Ethernet Controller (Copper) - SpanSwitch when I use libpcap of dpdk I see 30% packet loss. Only when I bind the network card to igb_uio I do not see packet loss anymore. Without dpdk I there is no packet loss also. Is there a problem running l

Re: [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 1:48 PM, Yong Wang wrote: > In function "reassemble_packets()", the statement "end = secondlast;" > is redundant since there is another assignment "start = end = NULL;" > 3 lines below. BTW, I removed the redundant braces in the conditional > statement "if (end->data_len > rxq->crc_len)

Re: [dpdk-dev] [PATCH v2 00/11] Introducing NXP DPAA2 SEC based cryptodev PMD

2017-01-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, December 22, 2016 8:17 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > hemant.agra...@nxp.com; Mcnamara, John; nhor...@tuxdriver.com; > Akhil Goyal > Su

Re: [dpdk-dev] [PATCH] net/i40e: remove redundant statement and braces

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 1:30 PM, Ferruh Yigit wrote: > On 1/9/2017 1:48 PM, Yong Wang wrote: >> In function "reassemble_packets()", the statement "end = secondlast;" >> is redundant since there is another assignment "start = end = NULL;" >> 3 lines below. BTW, I removed the redundant braces in the conditional

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-09 Thread Shahaf Shuler
Hi Georgios, It is not support on Mellanox PMD to read the primary process counters from a secondary process. --Shahaf -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of george@gmail.com Sent: Sunday, January 8, 2017 3:38 PM To: dev@dpdk.org Subject: [dpdk-dev

Re: [dpdk-dev] [PATCH v2 01/11] librte_cryptodev: Add rte_device pointer in cryptodevice

2017-01-09 Thread De Lara Guarch, Pablo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, December 22, 2016 8:17 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > hemant.agra...@nxp.com; Mcnamara, John; nhor...@tuxdriver.co

Re: [dpdk-dev] [PATCH] app/test: fix aad padding size in SGL operation

2017-01-09 Thread De Lara Guarch, Pablo
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Tuesday, January 03, 2017 3:39 PM > To: dev@dpdk.org > Cc: Trahe, Fiona; De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K; > Kusztal, ArkadiuszX > Subject: [PATCH] app/test: fix aad padding size in SGL operation > > Thi

Re: [dpdk-dev] [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for Descriptor formation

2017-01-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Thursday, December 22, 2016 8:17 PM > To: dev@dpdk.org > Cc: thomas.monja...@6wind.com; Doherty, Declan; De Lara Guarch, Pablo; > hemant.agra...@nxp.com; Mcnamara, John; nhor...@tuxdriver.com; > Akhil Goyal; Hor

Re: [dpdk-dev] [PATCH v3 0/7] virtio_user as an alternative exception path

2017-01-09 Thread Bruce Richardson
On Wed, Jan 04, 2017 at 03:59:19AM +, Jianfeng Tan wrote: > v3: > - Drop the patch to postpone driver ok sending patch, superseded it > with a bug fix to disable all virtqueues and re-init the device. > (you might wonder why not just send reset owner msg. Under my test, > it caus

Re: [dpdk-dev] [PATCH] app/test: fix aad padding size in SGL operation

2017-01-09 Thread Kusztal, ArkadiuszX
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, January 09, 2017 1:39 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; Griffin, John > ; Jain, Deepak K > Subject: RE: [PATCH] app/test: fix aad padding size in SGL operation > > Hi Arek, > > > -Orig

Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability

2017-01-09 Thread Ferruh Yigit
On 12/13/2016 1:08 AM, Michał Mirosław wrote: > Signed-off-by: Michał Mirosław > --- <...> > if (ret) > - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow control " > - " frames from VSIs."); > + PMD_INIT_LOG(ERR, "Failed to add fil

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-09 Thread Adrien Mazarguil
Hi Konstantin, On Sun, Jan 08, 2017 at 12:39:55PM +, Ananyev, Konstantin wrote: > > Hi Adrien, > > > > > Hi Konstantin, > > > > On Thu, Jan 05, 2017 at 11:32:38AM +, Ananyev, Konstantin wrote: > > > Hi Adrien, [...] > > > > PMD-specific symbols have nothing to do in the global namespac

Re: [dpdk-dev] Port stats zero when using MLX5 DPDK driver

2017-01-09 Thread george . dit
Hi Shahaf, Thanks for the clarification! Is there a plan for this functionality to be provided (soon)? (or any technical limitation that stands in this way) Thanks and best regards, Georgios On Mon, Jan 9, 2017 at 2:32 PM, Shahaf Shuler wrote: > Hi Georgios, > > It is not support on Mellanox P

[dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check

2017-01-09 Thread Piotr Azarewicz
EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is unneeded. Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Signed-off-by: Piotr Azarewicz --- drivers/crypto/openssl/rte_openssl_pmd.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v4 1/6] lib: distributor performance enhancements

2017-01-09 Thread David Hunt
Now sends bursts of up to 8 mbufs to each worker, and tracks the in-flight flow-ids (atomic scheduling) New file with a new api, similar to the old API except with _burst at the end of the function names Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 2 + l

[dpdk-dev] [PATCH v4 0/6] distributor library performance enhancements

2017-01-09 Thread David Hunt
This patch aims to improve the throughput of the distributor library. It uses a similar handshake mechanism to the previous version of the library, in that bits are used to indicate when packets are ready to be sent to a worker and ready to be returned from a worker. One main difference is that in

[dpdk-dev] [PATCH v4 2/6] lib: add distributor vector flow matching

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- lib/librte_distributor/Makefile| 4 + lib/librte_distributor/rte_distributor_burst.c | 11 +- lib/librte_distributor/rte_distributor_match_sse.c | 113 + lib/librte_distributor/rte_distributor_priv.h | 6 ++ 4 fil

[dpdk-dev] [PATCH v4 3/6] test: unit tests for new distributor burst api

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor.c | 501 ++-- 1 file changed, 392 insertions(+), 109 deletions(-) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index 85cb8f3..3871f86 100644 --- a/app/test/test_distributor.c

[dpdk-dev] [PATCH v4 4/6] test: add distributor_perf autotest

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- app/test/test_distributor_perf.c | 148 --- 1 file changed, 137 insertions(+), 11 deletions(-) diff --git a/app/test/test_distributor_perf.c b/app/test/test_distributor_perf.c index 7947fe9..b273bf9 100644 --- a/app/test/test_dist

[dpdk-dev] [PATCH v4 6/6] doc: distributor library changes for new burst api

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- doc/guides/prog_guide/packet_distrib_lib.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/prog_guide/packet_distrib_lib.rst b/doc/guides/prog_guide/packet_distrib_lib.rst index b5bdabb..dffd4ad 100644 --- a/doc/guides/prog_guide/packet_distrib_

Re: [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce new performance test application

2017-01-09 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slawomir > Mrozowicz > Sent: Thursday, January 05, 2017 4:50 PM > To: dev@dpdk.org > Cc: Mrozowicz, SlawomirX; Doherty, Declan; Azarewicz, PiotrX T; Kerlin, > Marcin; Kobylinski, MichalX > Subject: [dpdk-dev] [PAT

[dpdk-dev] [PATCH v4 5/6] example: distributor app showing burst api

2017-01-09 Thread David Hunt
Signed-off-by: David Hunt --- examples/distributor/main.c | 508 ++-- 1 file changed, 390 insertions(+), 118 deletions(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index e7641d2..eebfb74 100644 --- a/examples/distributor/main.c

[dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Royce Niu
Dear all, I cannot use my Mellanox 3 Pro, after I binded it with igb_uio driver. It always shows when I use my DPDK application. EAL: Detected 32 lcore(s) EAL: Probing VFIO support... PMD: bnxt_rte_pmd_init() called for (null) EAL: PCI device :02:00.0 on NUMA socket 0 EAL: probe driver: 80

Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove

2017-01-09 Thread Ferruh Yigit
On 12/26/2016 1:24 PM, Shreyansh Jain wrote: > These callbacks now act as first layer of PCI interfaces from the Bus. > Bus probe would enter the PMDs through the rte_driver->probe/remove > callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the > drivers are rte_pci_driver). > > Th

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Adrien Mazarguil
Hi Royce, On Mon, Jan 09, 2017 at 10:53:37PM +0800, Royce Niu wrote: > Dear all, > > I cannot use my Mellanox 3 Pro, after I binded it with igb_uio driver. > > It always shows when I use my DPDK application. > > EAL: Detected 32 lcore(s) > EAL: Probing VFIO support... > PMD: bnxt_rte_pmd_init()

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-09 Thread Ferruh Yigit
On 12/26/2016 1:23 PM, Shreyansh Jain wrote: <...> > + > +DPDK_17.02 { > + global: > + > + rte_bus_list; > + rte_eal_bus_add_device; > + rte_eal_bus_add_driver; > + rte_eal_bus_get; > + rte_eal_bus_dump; > + rte_eal_bus_register; > + rte_eal_bus_insert_device; Th

Re: [dpdk-dev] [PATCH] crypto test: add integrity check for mbuf data

2017-01-09 Thread Kusztal, ArkadiuszX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Thursday, December 22, 2016 4:51 PM > To: dev@dpdk.org > Cc: Griffin, John ; Jain, Deepak K > ; De Lara Guarch, Pablo > ; Trahe, Fiona > Subject: [dpdk-dev] [PATCH] crypto test: add integrity

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Royce Niu
Hi, Adrien, Actually, I tested using the original kernel module without binding. It works. However, it is only 6Mpps for 64B in pkt-gen, which is so slow for a 40Gbps NIC. Is that right? On Mon, Jan 9, 2017 at 11:13 PM, Adrien Mazarguil < adrien.mazarg...@6wind.com> wrote: > Hi Royce, > > On

Re: [dpdk-dev] [PATCH v2 3/3] app/crypto-perf: introduce new performance test application

2017-01-09 Thread Thomas Monjalon
2017-01-05 17:50, Slawomir Mrozowicz: > --- a/app/Makefile > +++ b/app/Makefile > @@ -38,5 +38,6 @@ DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd > DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test > DIRS-$(CONFIG_RTE_EXEC_ENV_LINUXAPP) += proc_info > DIRS-$(CONFIG_RTE_LIBRTE_PDUMP) += pdump > +DIRS-$

Re: [dpdk-dev] [PATCH v5 2/6] net/mlx5: support basic flow items and actions

2017-01-09 Thread Adrien Mazarguil
Hi Ferruh, On Fri, Jan 06, 2017 at 01:52:53PM +, Ferruh Yigit wrote: > On 1/4/2017 6:42 PM, Adrien Mazarguil wrote: > > Hi Ferruh, > > > > On Wed, Jan 04, 2017 at 05:49:46PM +, Ferruh Yigit wrote: > >> Hi Nelio, > >> > >> A quick question. > > > > I'll reply since it's related to the API

Re: [dpdk-dev] [PATCH v2 07/11] crypto/dpaa2_sec: Add DPAA2_SEC PMD into build system

2017-01-09 Thread Thomas Monjalon
2016-12-23 01:46, Akhil Goyal: > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_COMMON),y) > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_sec > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_qbman > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_dpio > +_LD

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Adrien Mazarguil
On Mon, Jan 09, 2017 at 11:23:56PM +0800, Royce Niu wrote: > Hi, Adrien, > > Actually, I tested using the original kernel module without binding. It > works. > > However, it is only 6Mpps for 64B in pkt-gen, which is so slow for a 40Gbps > NIC. > > Is that right? That's difficult to say without

Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 3:19 PM, Ferruh Yigit wrote: > On 12/26/2016 1:24 PM, Shreyansh Jain wrote: >> These callbacks now act as first layer of PCI interfaces from the Bus. >> Bus probe would enter the PMDs through the rte_driver->probe/remove >> callbacks, falling to rte_xxx_driver->probe/remove (Currently,

[dpdk-dev] [PATCH v2 0/2] net/i40e: fix segmentation fault

2017-01-09 Thread Bernard Iremonger
Changes in v2: These two patches were previously part of the following patchset: [PATCH v7 00/27] Support VFD on i40e They are being submitted seperately as they are not needed for VFD. The net/i40e patch has been revised. The testpmd patch is needed to setup VMDq in order to test the fix. Bernar

[dpdk-dev] [PATCH v2 1/2] net/i40e: fix segmentation fault in close

2017-01-09 Thread Bernard Iremonger
Change the order of releasing the vsi's. Release the vmdq vsi's first, then release the main vsi. Fixes: 4861cde46116 ("i40e: new poll mode driver") CC: sta...@dpdk.org Signed-off-by: Bernard Iremonger --- drivers/net/i40e/i40e_ethdev.c | 12 +++- 1 file changed, 7 insertions(+), 5 del

[dpdk-dev] [PATCH v2 2/2] app/testpmd: add command to configure VMDq

2017-01-09 Thread Bernard Iremonger
Add the following command to configure VMDq: port config vmdq Add new command to testpmd user guide. Signed-off-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 60 + app/test-pmd/testpmd.c | 126 app/test-pm

[dpdk-dev] [PATCH] tools: fix active interface detection in dpdk-devbind.py

2017-01-09 Thread Yoni Gilad
When adding crypto devices, the "Active" and "Ssh_if" attributes of existing network devices were reset. This causes the follwing issues: - Network interfaces aren't marked as "*Active*" in the --status output. - Active network interfaces can be unbound without the --force option, causing loss o

Re: [dpdk-dev] Cannot use MLX4 with igb_uio driver

2017-01-09 Thread Royce Niu
It is a simple L2FWD. It can be 14mpps in x520 nics. So, do you think where should I check? Thanks On Tue, 10 Jan 2017 at 12:13 AM, Adrien Mazarguil < adrien.mazarg...@6wind.com> wrote: > On Mon, Jan 09, 2017 at 11:23:56PM +0800, Royce Niu wrote: > > > Hi, Adrien, > > > > > > Actually, I tested

Re: [dpdk-dev] [PATCH] net/bnxt: Add support for new PCI IDs

2017-01-09 Thread Stephen Hemminger
fine BROADCOM_DEV_ID_57416_MF 0x16ee > > static struct rte_pci_id bnxt_pci_id_map[] = { > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID_57301) }, > @@ -95,6 +110,21 @@ static struct rte_pci_id bnxt_pci_id_map[] = { > { RTE_PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, BROADCOM_DEV_ID

Re: [dpdk-dev] [PATCH] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Iremonger, Bernard
> -Original Message- > From: Lu, Wenzhuo > Sent: Friday, January 6, 2017 2:31 AM > To: dev@dpdk.org > Cc: Iremonger, Bernard ; Lu, Wenzhuo > ; sta...@dpdk.org > Subject: [PATCH] ixgbe: fix wrong VMDq function name > > The function name ixgbe_vmdq_mode_check is not right. > This function ch

Re: [dpdk-dev] [PATCH v4] ethdev: fix port data mismatched in multiple process model

2017-01-09 Thread Thomas Monjalon
Hi Yuanhan, Nit: the title should be "v4 1/6" Except that, good patch :) > Signed-off-by: Yuanhan Liu Acked-by: Thomas Monjalon

Re: [dpdk-dev] [PATCH 0/2] minor cleanups

2017-01-09 Thread Thomas Monjalon
Hi Stephen, This series is still pending. Would you mind to make a v2, please? 2016-12-07 17:47, Stephen Hemminger: > Saw this while reviewing other changes > > Stephen Hemminger (2): > eth: get rid of goto's in rte_eth_dev_detach > sched/malloc: remove unnecesary return statements

Re: [dpdk-dev] [PATCH v2 1/7] pci: If a driver's probe function fails, unmap resources.

2017-01-09 Thread Thomas Monjalon
2017-01-04 18:39, Thomas Monjalon: > 2016-12-21 17:19, Thomas Monjalon: > > 2016-11-25 14:51, Shreyansh Jain: > > > On Thursday 24 November 2016 01:37 AM, Ben Walker wrote: > > > > If resources were mapped prior to probe, unmap them > > > > if probe fails. > > > > > > > > This does not handle the c

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-09 Thread Stephen Hemminger
On Mon, 9 Jan 2017 10:01:40 + Remy Horton wrote: > On 09/01/2017 07:16, Yang, Qiming wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > [..] > >> void > >> +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int > >> +fw_lengt

Re: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability

2017-01-09 Thread Stephen Hemminger
On Mon, 09 Jan 2017 14:18:58 +0100 Thomas Monjalon wrote: > 2017-01-09 12:02, Bruce Richardson: > > On Wed, Dec 28, 2016 at 03:51:56AM +, Wu, Jingjing wrote: > > > > > > > > > > -Original Message- > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Ferruh Yigit
On 1/9/2017 5:06 PM, Iremonger, Bernard wrote: >> -Original Message- >> From: Lu, Wenzhuo >> Sent: Friday, January 6, 2017 2:31 AM >> To: dev@dpdk.org >> Cc: Iremonger, Bernard ; Lu, Wenzhuo >> ; sta...@dpdk.org >> Subject: [PATCH] ixgbe: fix wrong VMDq function name >> >> The function name

Re: [dpdk-dev] [PATCH v3 00/33] NXP DPAA2 PMD

2017-01-09 Thread Ferruh Yigit
On 12/29/2016 5:16 AM, Shreyansh Jain wrote: > ** Sending v3 on behalf of Hemant Agrawal ** > <...> Hi, Getting compile error for shared library [1] build. Not investigated, copying here. Thanks, ferruh [1] == Build drivers/net/dpaa2 LD librte_pmd_dpaa2.so.1.1 /usr/bin/ld: cannot find -lr

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-09 Thread Olivier Matz
Hi Yuanhan, On Wed, 14 Dec 2016 15:27:50 +0800, Yuanhan Liu wrote: > Firstly sorry for late response! No problem, I fully understand ;) > On Thu, Nov 24, 2016 at 09:56:38AM +0100, Olivier Matz wrote: > > With virtio, doing tso requires to modify the network > > packet data: > > I thought mor

Re: [dpdk-dev] [PATCH 5/5] net/virtio: fix Tso when mbuf is shared

2017-01-09 Thread Stephen Hemminger
On Thu, 24 Nov 2016 09:56:38 +0100 Olivier Matz wrote: > diff --git a/drivers/net/virtio/virtio_rxtx.c > b/drivers/net/virtio/virtio_rxtx.c > index 22d97a4..577c775 100644 > --- a/drivers/net/virtio/virtio_rxtx.c > +++ b/drivers/net/virtio/virtio_rxtx.c > @@ -211,43 +211,73 @@ virtqueue_enqueue_

Re: [dpdk-dev] [PATCH v2 0/5] Elastic Flow Distributor

2017-01-09 Thread Maciocco, Christian
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Pablo de Lara > Sent: Friday, January 06, 2017 5:06 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo > Subject: [dpdk-dev] [PATCH v2 0/5] Elastic Flow Distributor > > EFD is a distributor library that uses perf

[dpdk-dev] [PATCH v2] net/enic: add support for TSO

2017-01-09 Thread John Daley
The enic TSO implementation requires that the length of the Eth/IP/TCP headers be passed to the NIC. Other than that, it's just a matter of setting the mss and offload mode on a per packet basis. In TSO mode, IP and TCP checksums are offloaded even if not requested with mb->ol_flags. Signed-off-b

[dpdk-dev] [PATCH v3] net/enic: add support for TSO

2017-01-09 Thread John Daley
The enic TSO implementation requires that the length of the Eth/IP/TCP headers be passed to the NIC. Other than that, it's just a matter of setting the mss and offload mode on a per packet basis. In TSO mode, IP and TCP checksums are offloaded even if not requested with mb->ol_flags. Signed-off-b

[dpdk-dev] [PATCH v2 0/7] minor cleanup

2017-01-09 Thread Stephen Hemminger
Mostly things found while inspecting other code. Stephen Hemminger (7): bonding,malloc,bitmap: remove useless return ethdev: reduce goto's in attach/detach bnx2x: remove useless return's kni: remove useless return statements i40e: remove useless return ixgbe: remove useless return ig

[dpdk-dev] [PATCH 2/7] ethdev: reduce goto's in attach/detach

2017-01-09 Thread Stephen Hemminger
Extra goto's to just a return are unnecessary. Don't do unnecessary initialization. Propgate return value. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 52 +-- 1 file changed, 21 insertions(+), 31 deletions(-) diff --git a/lib/libr

[dpdk-dev] [PATCH 1/7] bonding, malloc, bitmap: remove useless return

2017-01-09 Thread Stephen Hemminger
return statements at end of void functions are unnecessary and unwanted. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- lib/librte_eal/common/rte_malloc.c | 1 - lib/librte_sched/rte_bitmap.h | 2 -- 3 files changed, 1 insertion(+), 4 deletions(-

[dpdk-dev] [PATCH 4/7] kni: remove useless return statements

2017-01-09 Thread Stephen Hemminger
A return statement at end of void function is unnecessary. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_82575.c | 4 lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_i210.c| 2 -- lib/librte_eal/linuxapp/kni/ethtool/igb/e1000_mac.c | 4 l

[dpdk-dev] [PATCH 3/7] bnx2x: remove useless return's

2017-01-09 Thread Stephen Hemminger
Don't need empty return; at end of void function. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c| 2 -- drivers/net/bnx2x/bnx2x_ethdev.c | 2 -- drivers/net/bnx2x/elink.c| 1 - 3 files changed, 5 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/b

[dpdk-dev] [PATCH 5/7] i40e: remove useless return

2017-01-09 Thread Stephen Hemminger
No need for return at end of void function. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_ethdev_vf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c index 0dc0af52..482b339c 100644 --- a/drivers/net/i40e/i

[dpdk-dev] [PATCH 6/7] ixgbe: remove useless return

2017-01-09 Thread Stephen Hemminger
If all goto's lead to a return, then better to get rid of goto. Signed-off-by: Stephen Hemminger --- drivers/net/ixgbe/ixgbe_82599_bypass.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_82599_bypass.c b/drivers/net/ixgbe/ixgbe_82599_bypas

[dpdk-dev] [PATCH 7/7] igb: remove useless return's

2017-01-09 Thread Stephen Hemminger
Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_pf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index 67da3c24..15bf8bfe 100644 --- a/drivers/net/e1000/igb_pf.c +++ b/drivers/net/e1000/igb_pf.c @@ -125,8 +125,6 @@ void i

Re: [dpdk-dev] [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 10, 2017 1:37 AM > To: Iremonger, Bernard; Lu, Wenzhuo; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] ixgbe: fix wrong VMDq function name > > On 1/9/2017 5:06 PM, Iremonger, Bernard w

Re: [dpdk-dev] [PATCH v5 3/8] ethdev: reserve capability flags for PMD-specific API

2017-01-09 Thread Tiwei Bie
On Mon, Jan 09, 2017 at 12:26:53PM +0100, Thomas Monjalon wrote: > 2017-01-09 11:57, Tiwei Bie: > > On Sun, Jan 08, 2017 at 08:39:55PM +0800, Ananyev, Konstantin wrote: > > > > Well my first reply to this thread was asking why isn't the whole API > > > > global > > > > from the start then? > > >

[dpdk-dev] [PATCH v2] ixgbe: fix wrong VMDq function name

2017-01-09 Thread Wenzhuo Lu
The function name ixgbe_vmdq_mode_check is not right. This function checks if Virtualization Technology is enabled. It's for both VMDq and IOV. Others may be misled by the current name. Fixes: fe3a45fd4104 ("ixgbe: add VMDq support") CC: sta...@dpdk.org Signed-off-by: Wenzhuo Lu Acked-by: Bernar

[dpdk-dev] MSI-X vector #1 seems to be stalled sometimes after VF reset (ixgbe)

2017-01-09 Thread Ruslan Nikolaev
Attached are 2 patches, and the discussion below is related to the slightly modified version of the dpdk 16.07 library: interrupts_excerpt.patch and dpdk_vfreset.patch 1. We use a single-shot interrupt mechanism for the RX queue (vector #1, intr_handle.efds[0]file descriptor). When we receive

Re: [dpdk-dev] MSI-X vector #1 seems to be stalled sometimes after VF reset (ixgbe)

2017-01-09 Thread Ruslan Nikolaev
interrupts_excerpts.patch: drivers/net/ixgbe/ixgbe_ethdev.c eth_ixgbevf_dev_init: @@ -1462,8 +1467,9 @@ rte_intr_callback_register(&pci_dev->intr_handle, ixgbevf_dev_interrupt_handler, (void *)eth_dev); - rte_int

Re: [dpdk-dev] MSI-X vector #1 seems to be stalled sometimes after VF reset (ixgbe)

2017-01-09 Thread Ruslan Nikolaev
dpdk_vfreset.patch: diff -urN dpdk-16.07/doc/guides/nics/overview.rst dpdk-16.07-new/doc/guides/nics/overview.rst --- dpdk-16.07/doc/guides/nics/overview.rst 2016-07-28 11:48:41.0 -0700 +++ dpdk-16.07-new/doc/guides/nics/overview.rst 2016-12-15 17:32:27.436425563 -0800 @@ -89,6 +89,

Re: [dpdk-dev] [PATCH v5 01/12] eal/bus: introduce bus abstraction

2017-01-09 Thread Shreyansh Jain
Hello Ferruh, On Monday 09 January 2017 08:52 PM, Ferruh Yigit wrote: On 12/26/2016 1:23 PM, Shreyansh Jain wrote: <...> + +DPDK_17.02 { + global: + + rte_bus_list; + rte_eal_bus_add_device; + rte_eal_bus_add_driver; + rte_eal_bus_get; + rte_eal_bus_dump; +

Re: [dpdk-dev] [PATCH v5 11/12] drivers: update PMDs to use rte_driver probe and remove

2017-01-09 Thread Shreyansh Jain
On Monday 09 January 2017 09:48 PM, Ferruh Yigit wrote: On 1/9/2017 3:19 PM, Ferruh Yigit wrote: On 12/26/2016 1:24 PM, Shreyansh Jain wrote: These callbacks now act as first layer of PCI interfaces from the Bus. Bus probe would enter the PMDs through the rte_driver->probe/remove callbacks, fal

Re: [dpdk-dev] [PATCH v3 00/33] NXP DPAA2 PMD

2017-01-09 Thread Shreyansh Jain
On Monday 09 January 2017 11:12 PM, Ferruh Yigit wrote: On 12/29/2016 5:16 AM, Shreyansh Jain wrote: ** Sending v3 on behalf of Hemant Agrawal ** <...> Hi, Getting compile error for shared library [1] build. Not investigated, copying here. Thanks, ferruh [1] == Build drivers/net/dpaa2

[dpdk-dev] Why MLX4 can only generate 6Mpp/s (64B pkt) by one core?

2017-01-09 Thread Royce Niu
Dear all, My Mellanox 3 Pro can only generate packet at maximum of 6Mpp/s (64B) by one core. This is too slow for a 40Gbps port. Could anyone give me a hint please? Configuration: Followed: http://dpdk.org/doc/guides/nics/mlx4.html 1. install MLNX_OFED_LINUX-3.4-2.0.0.0 2. Added CONFIG_RTE_LIB

Re: [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter

2017-01-09 Thread Zhao1, Wei
Hi, yigit > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 12:31 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 02/18] net/ixgbe: store flow director filter > > On 12/30/2016 7:52 AM, Wei Zhao wrote: > > Add support fo

Re: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter

2017-01-09 Thread Zhao1, Wei
Hi, yigit > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, January 7, 2017 12:29 AM > To: Zhao1, Wei ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH v2 01/18] net/ixgbe: store SYN filter > > On 12/30/2016 7:52 AM, Wei Zhao wrote: > > Add support for storing

  1   2   >