On Mon, 09 Jan 2017 14:18:58 +0100 Thomas Monjalon <thomas.monja...@6wind.com> wrote:
> 2017-01-09 12:02, Bruce Richardson: > > On Wed, Dec 28, 2016 at 03:51:56AM +0000, Wu, Jingjing wrote: > > > > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw > > > > Sent: Tuesday, December 13, 2016 9:08 AM > > > > To: dev@dpdk.org > > > > Subject: [dpdk-dev] [PATCH 13/13] i40e: improve message grepability > > > > > > > > Signed-off-by: Michał Mirosław <michal.miros...@atendesoftware.pl> > > > > --- > > > > drivers/net/i40e/i40e_ethdev.c | 198 > > > > +++++++++++++++-------------------------- > > > > 1 file changed, 73 insertions(+), 125 deletions(-) > > > > > > > > diff --git a/drivers/net/i40e/i40e_ethdev.c > > > > b/drivers/net/i40e/i40e_ethdev.c > > > > index 39fbcfe..4d73aca 100644 > > > > --- a/drivers/net/i40e/i40e_ethdev.c > > > > +++ b/drivers/net/i40e/i40e_ethdev.c > > > > @@ -763,8 +763,7 @@ i40e_add_tx_flow_control_drop_filter(struct i40e_pf > > > > *pf) > > > > pf->main_vsi_seid, 0, > > > > TRUE, NULL, NULL); > > > > if (ret) > > > > - PMD_INIT_LOG(ERR, "Failed to add filter to drop flow > > > > control " > > > > - " frames from VSIs."); > > > > + PMD_INIT_LOG(ERR, "Failed to add filter to drop flow > > > > control > > > > frames > > > > +from VSIs."); > > > > } > > > > > > You are right, it makes grep easily. But it will break the coding style > > > "Line length is recommended to be not more than 80 characters, including > > > comments." > > > > > > Any comments from committers? > > > > > Being able to grep error messages is more important that having lines > > wrapped at 80 characters. I believe checkpatch ignores long strings when > > checking line lengths. > > I agree keeping strings is more important than checkpatch conformity. > Please, if checkpatch complains, try to tune the script checkpatch.sh. > There are some options to manage strings. Checkpatch does not complain as long as string is on one line. i.e PMD_INIT_LOG(ERR, ""Failed to add filter to drop flow control frames from VSIs.");
