[dpdk-dev] Coverity policy for upstream (base) drivers.

2015-11-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Thursday, November 12, 2015 10:05 PM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: [dpdk-dev] Coverity policy for upstream (base) drivers. > > Looking at the Coverity scan for

[dpdk-dev] Coverity policy for upstream (base) drivers.

2015-11-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon > Sent: Thursday, November 12, 2015 10:19 PM > To: Stephen Hemminger > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] Coverity policy for upstream (base) drivers. > > 2015-11-12 14:05, Stephen H

[dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error

2015-11-13 Thread Cunming Liang
The vector number may change during 'dev_start'. Before enabling a new vector mapping, it's necessary to disable/unmap the previous setting. Fixes: 7ab8500037f6 ("ixgbe: fix VF start with PF stopped") Reported-by: Yong Liu Signed-off-by: Cunming Liang --- drivers/net/ixgbe/ixgbe_ethdev.c | 3

[dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error

2015-11-13 Thread Cunming Liang
The vector number may change during 'dev_start'. Before enabling a new vector mapping, it's necessary to disable/unmap the previous setting. Fixes: fe685de2b1b6 ("igb: fix VF start with PF stopped") Reported-by: Yong Liu Signed-off-by: Cunming Liang --- drivers/net/e1000/igb_ethdev.c | 3 +++

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/12 21:52, Wang, Zhihong wrote: > Hi Tetsuya, > > In my test I created 2 vdev using "--vdev > 'eth_vhost0,iface=/tmp/sock0,queues=1' --vdev > 'eth_vhost1,iface=/tmp/sock1,queues=1'", and the qemu message got handled in > wrong order. > The reason is that: 2 threads are created to handl

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-13 Thread Wang, Zhihong
> -Original Message- > From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp] > Sent: Friday, November 13, 2015 11:10 AM > To: Wang, Zhihong ; dev at dpdk.org; Liu, Yuanhan > > Cc: ann.zhuangyanying at huawei.com > Subject: Re: [dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD > > On 2015/11/1

[dpdk-dev] [PATCH v3 2/2] vhost: Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/13 13:03, Rich Lane wrote: >> + if (rte_kvargs_count(kvlist, ETH_VHOST_IFACE_ARG) == 1) { >> + ret = rte_kvargs_process(kvlist, ETH_VHOST_IFACE_ARG, >> +&open_iface, &iface_name); >> + if (ret < 0) >> +

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
The patch introduces a new PMD. This PMD is implemented as thin wrapper of librte_vhost. * Known issue. We may see issues while handling RESET_OWNER message. These handlings are done in vhost library, so not a part of vhost PMD. So far, we are waiting for QEMU fixing. PATCH v4 changes: - Rebase

[dpdk-dev] [PATCH v4 1/2] vhost: Add callback and private data for vhost PMD

2015-11-13 Thread Tetsuya Mukawa
These variables are needed to be able to manage one of virtio devices using both vhost library APIs and vhost PMD. For example, if vhost PMD uses current callback handler and private data provided by vhost library, A DPDK application that links vhost library cannot use some of vhost library APIs. T

[dpdk-dev] [PATCH v4 2/2] vhost: Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
The patch introduces a new PMD. This PMD is implemented as thin wrapper of librte_vhost. It means librte_vhost is also needed to compile the PMD. The vhost messages will be handled only when a port is started. So start a port first, then invoke QEMU. The PMD has 2 parameters. - iface: The parame

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-13 Thread Yuanhan Liu
On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: > The patch introduces a new PMD. This PMD is implemented as thin wrapper > of librte_vhost. > > * Known issue. > We may see issues while handling RESET_OWNER message. > These handlings are done in vhost library, so not a part of vhos

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/13 14:32, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. >> >> * Known issue. >> We may see issues while handling RESET_OWNER message. >> These handlings a

[dpdk-dev] [PATCH] rte_log.h: display level in logs from RTE_LOG

2015-11-13 Thread Matthew Hall
Signed-off-by: Matthew Hall --- lib/librte_eal/common/include/rte_log.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index ede0dca..be961d0 100644 --- a/lib/librte_eal/common/include/

[dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error

2015-11-13 Thread Liu, Yong
Tested-by: Yong Liu > -Original Message- > From: Liang, Cunming > Sent: Friday, November 13, 2015 10:50 AM > To: dev at dpdk.org > Cc: Liu, Yong; Liang, Cunming > Subject: [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error > > The vector number may change during 'dev_start'. Before enablin

[dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function.

2015-11-13 Thread kamasamikon
Give user a chance to costomize the hash key compare function. The default rte_hash_cmp_eq function is set in the rte_hash_create function, but these builtin ones may not good enough, so the user may call this to override the default one. Signed-off-by: Yu Nemo Wenbin --- lib/librte_hash/rte_cuc

[dpdk-dev] [PATCH v5 0/4] add virtio offload support in us-vhost

2015-11-13 Thread Yuanhan Liu
Series Acked-by: Yuanhan Liu --yliu On Thu, Nov 12, 2015 at 08:07:02PM +0800, Jijiang Liu wrote: > Adds virtio offload support in us-vhost. > > The patch set adds the feature negotiation of checksum and TSO between > us-vhost and vanilla Linux virtio guest, and add these offload featu

[dpdk-dev] [PATCH 0/6] librte_eal: allow wider range of log levels

2015-11-13 Thread Matthew Hall
This is a simple but very helpful patch for app developers. It allows a wider range of log levels from in the rte_log framework. It allows developers to avoid resorting to a lot of external log frameworks in their DPDK code. Matthew Hall (6): librte_log: add function to retrieve log_level r

[dpdk-dev] [PATCH 1/6] librte_log: add function to retrieve log_level

2015-11-13 Thread Matthew Hall
Signed-off-by: Matthew Hall --- lib/librte_eal/common/include/rte_log.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index ede0dca..9dad24e 100644 --- a/lib/librte_eal/common/include/rte_log.h +++ b/lib/libr

[dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels RTE_LOG{FINE, FINER, FINEST}

2015-11-13 Thread Matthew Hall
Signed-off-by: Matthew Hall --- lib/librte_eal/common/include/rte_log.h | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index 9dad24e..7dc19e1 100644 --- a/lib/librte_eal/co

[dpdk-dev] [PATCH 3/6] eal_common_log.c: reset default level to RTE_LOG_FINEST

2015-11-13 Thread Matthew Hall
Signed-off-by: Matthew Hall --- lib/librte_eal/common/eal_common_log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c index 1ae8de7..510eeff 100644 --- a/lib/librte_eal/common/eal_common_log.c ++

[dpdk-dev] [PATCH 4/6] rte_log.h: update logging docs to include FINEST level

2015-11-13 Thread Matthew Hall
Signed-off-by: Matthew Hall --- lib/librte_eal/common/include/rte_log.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index 7dc19e1..4a70ce5 100644 --- a/lib/librte_eal/common/include/

[dpdk-dev] [PATCH 5/6] rte_log.h: add RTE_SYSLOG_LEVEL_MAX

2015-11-13 Thread Matthew Hall
Signed-off-by: Matthew Hall --- lib/librte_eal/common/include/rte_log.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index 4a70ce5..d7e11f1 100644 --- a/lib/librte_eal/common/include/rte_log.h +++ b/lib/l

[dpdk-dev] [PATCH 6/6] eal_log.c: limit syslog level to RTE_SYSLOG_LEVEL_MAX

2015-11-13 Thread Matthew Hall
Signed-off-by: Matthew Hall --- lib/librte_eal/linuxapp/eal/eal_log.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/linuxapp/eal/eal_log.c b/lib/librte_eal/linuxapp/eal/eal_log.c index 0b133c3..dbeff75 100644 --- a/lib/librte_eal/linuxapp/eal/eal_log.c +++ b/lib/librte_eal/l

[dpdk-dev] [PATCH v4 0/2] Add VHOST PMD

2015-11-13 Thread Tetsuya Mukawa
On 2015/11/13 14:32, Yuanhan Liu wrote: > On Fri, Nov 13, 2015 at 02:20:29PM +0900, Tetsuya Mukawa wrote: >> The patch introduces a new PMD. This PMD is implemented as thin wrapper >> of librte_vhost. >> >> * Known issue. >> We may see issues while handling RESET_OWNER message. >> These handlings a

[dpdk-dev] [PATCH v5 1/4] vhost/lib: add vhost TX offload capabilities in vhost lib

2015-11-13 Thread Yuanhan Liu
On Thu, Nov 12, 2015 at 08:07:03PM +0800, Jijiang Liu wrote: > Add vhost TX offload(CSUM and TSO) support capabilities in vhost lib. > > Refer to feature bits in Virtual I/O Device (VIRTIO) Version 1.0 below, > > VIRTIO_NET_F_CSUM (0) Device handles packets with partial checksum. This > "checksu

[dpdk-dev] [PATCH v5 0/4] add virtio offload support in us-vhost

2015-11-13 Thread Xu, Qian Q
Tested-by: Qian Xu - Test Commit: 6b6a94ee17d246a0078cc83257f522d0a6db5409 - OS/Kernel: Fedora 21/4.1.8 - GCC: gcc (GCC) 4.9.2 20141101 (Red Hat 4.9.2-1) - CPU: Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz - NIC: Intel Corporation 82599ES 10-Gigabit SFI/SFP+ Network Connection (rev 01) - Target: Int

[dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional?

2015-11-13 Thread David Marchand
Hello Roger, On Thu, Nov 12, 2015 at 11:43 PM, Roger B Melton wrote: > Hi folks, > > With the addition of hot plug support we have been migrating away from > device discovery and attach at initialization time to a model where it is > controlled from a separate process. The separate process mana

[dpdk-dev] [PATCH] virtio: fix rx ring descriptor starvation

2015-11-13 Thread Tom Kiely
If all rx descriptors are processed while transient mbuf exhaustion is present, the rx ring ends up with no available descriptors. Thus no packets are received on that ring. Since descriptor refill is performed post rx descriptor processing, in this case no refill is ever subsequently performed res

[dpdk-dev] [PATCH 1/2] Revert "eal: fix C++ app build"

2015-11-13 Thread David Marchand
This reverts commit 621389bbbe0860d41538aeac893b6d74e714530c. Signed-off-by: David Marchand --- lib/librte_eal/common/include/arch/ppc_64/rte_cpuflags.h | 4 ++-- lib/librte_eal/common/include/arch/tile/rte_cpuflags.h | 4 ++-- lib/librte_eal/common/include/arch/x86/rte_cpuflags.h| 4 ++

[dpdk-dev] [PATCH 2/2] eal: move empty declarations to doc

2015-11-13 Thread David Marchand
No need for those forward declarations (which breaks build when asking for C++11 or adding pedantic flag). Signed-off-by: David Marchand --- lib/librte_eal/common/include/generic/rte_cpuflags.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_eal/common/include/generic/rte_cp

[dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function.

2015-11-13 Thread Bruce Richardson
On Fri, Nov 13, 2015 at 02:28:13PM +0800, kamasamikon wrote: > Give user a chance to costomize the hash key compare function. > The default rte_hash_cmp_eq function is set in the rte_hash_create > function, but these builtin ones may not good enough, so the user > may call this to override the defa

[dpdk-dev] [PATCH] l3fwd: Fix l3fwd crash due to unaligned load/store intrinsics

2015-11-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of harish.patil at > qlogic.com > Sent: Sunday, November 08, 2015 7:40 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] l3fwd: Fix l3fwd crash due to unaligned > load/store intrinsics > > From: Harish Pat

[dpdk-dev] [PATCH v3 0/5] Xen DOM0 runtime support

2015-11-13 Thread Thomas Monjalon
2015-11-05 16:09, Stephen Hemminger: > Rebase of patches to current Intel drivers in DPDK 2.2-rc1 > > Stephen Hemminger (5): > xen: allow determining DOM0 at runtime > e1000: use rte_eth_dma_zone_reserve > ixgbe: use rte_eth_dma_zone_reserve > i40e: use rte_eth_dma_zone_reserve > fm10k:

[dpdk-dev] [PATCH 1/6] librte_log: add function to retrieve log_level

2015-11-13 Thread Bruce Richardson
On Fri, Nov 13, 2015 at 06:47:33AM +, Matthew Hall wrote: > Signed-off-by: Matthew Hall > --- > lib/librte_eal/common/include/rte_log.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/common/include/rte_log.h > b/lib/librte_eal/common/include/rte_log.h > index ede0dc

[dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels RTE_LOG{FINE, FINER, FINEST}

2015-11-13 Thread Bruce Richardson
On Fri, Nov 13, 2015 at 06:47:34AM +, Matthew Hall wrote: > Signed-off-by: Matthew Hall > --- > lib/librte_eal/common/include/rte_log.h | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_log.h > b/lib/librte_eal/co

[dpdk-dev] [PATCH] doc: fix examples in netmap compatibility docs

2015-11-13 Thread John McNamara
Fix the examples in the netmap compatibility sample application docs which referred to the packet_reordering application. Also fix some minor rst formatting issues. Reported-by: Qian Xu Signed-off-by: John McNamara --- doc/guides/sample_app_ug/netmap_compatibility.rst | 91

[dpdk-dev] Permanently binding NIC ports with DPDK drivers

2015-11-13 Thread Montorsi, Francesco
Hi Panu, > -Original Message- > From: Panu Matilainen [mailto:pmatilai at redhat.com] > I've been looking into this recently, here's what I have so far: > http://laiskiainen.org/git/?p=driverctl.git > Thanks I tried the script (I just had to change /bin/sh into /bin/bash on first line) a

[dpdk-dev] Permanently binding NIC ports with DPDK drivers

2015-11-13 Thread Montorsi, Francesco
Hi John, > -Original Message- > From: Mcnamara, John [mailto:john.mcnamara at intel.com] > > The Ubuntu dpdk package for 15.10 contains system scripts with functions for > reserving hugepages and binding interfaces on bootup: > > > /etc/dpdk/dpdk.conf > /etc/dpdk/interfaces >

[dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels RTE_LOG{FINE, FINER, FINEST}

2015-11-13 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, November 13, 2015 11:44 AM > To: Matthew Hall > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels > RTE_LOG{FINE, FINER, FINEST} > >

[dpdk-dev] [PATCH 1/6] librte_log: add function to retrieve log_level

2015-11-13 Thread Thomas Monjalon
2015-11-13 11:40, Bruce Richardson: > On Fri, Nov 13, 2015 at 06:47:33AM +, Matthew Hall wrote: > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -131,6 +131,7 @@ void rte_set_log_level(uint32_t level); > > > > /** > > * Get the glob

[dpdk-dev] Making rte_eal_pci_probe() in rte_eal_init() optional?

2015-11-13 Thread Roger B. Melton
Hi David, On 11/13/15 3:49 AM, David Marchand wrote: > Hello Roger, > > On Thu, Nov 12, 2015 at 11:43 PM, Roger B Melton > wrote: > > Hi folks, > > With the addition of hot plug support we have been migrating away > from device discovery and attach at ini

[dpdk-dev] Permanently binding NIC ports with DPDK drivers

2015-11-13 Thread Panu Matilainen
On 11/13/2015 01:44 PM, Montorsi, Francesco wrote: > Hi Panu, > >> -Original Message- >> From: Panu Matilainen [mailto:pmatilai at redhat.com] >> I've been looking into this recently, here's what I have so far: >> http://laiskiainen.org/git/?p=driverctl.git >> > Thanks I tried the script (I

[dpdk-dev] Permanently binding NIC ports with DPDK drivers

2015-11-13 Thread Panu Matilainen
On 11/13/2015 01:48 PM, Montorsi, Francesco wrote: > Hi John, > >> -Original Message- >> From: Mcnamara, John [mailto:john.mcnamara at intel.com] >> >> The Ubuntu dpdk package for 15.10 contains system scripts with functions for >> reserving hugepages and binding interfaces on bootup: >> >>

[dpdk-dev] [PATCH] rte_log.h: display level in logs from RTE_LOG

2015-11-13 Thread Panu Matilainen
On 11/13/2015 07:50 AM, Matthew Hall wrote: > Signed-off-by: Matthew Hall > --- > lib/librte_eal/common/include/rte_log.h | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_log.h > b/lib/librte_eal/common/include/rte_log.h > index

[dpdk-dev] ACL Library Information Request

2015-11-13 Thread Ananyev, Konstantin
Hi Jason, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jason Terry > Sent: Thursday, November 12, 2015 1:58 PM > To: dev at dpdk.org > Subject: [dpdk-dev] ACL Library Information Request > > HI, > >I've read the documentation and looked at the exampl

[dpdk-dev] [PATCH v6 8/8] doc: add a ptpclient sample guide

2015-11-13 Thread Thomas Monjalon
> doc/guides/sample_app_ug/img/ptpclient.svg | 524 > + [...] > + width="105mm" > + height="148mm" Tip: the extra white margins can be stripped in inkscape with ctrl+shift+d and "resize page to content".

[dpdk-dev] Permanently binding NIC ports with DPDK drivers

2015-11-13 Thread Aaron Conole
Panu Matilainen writes: > On 11/11/2015 06:28 PM, Bruce Richardson wrote: >> On Wed, Nov 11, 2015 at 04:13:01PM +, Montorsi, Francesco wrote: >>> Hi, >>> Is there a way to permanently (i.e., have the configuration automatically >>> applied after reboot) bind a NIC port to DPDK? >>> >>> In cas

[dpdk-dev] [PATCH v6 8/8] doc: add a ptpclient sample guide

2015-11-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, November 13, 2015 2:39 PM > To: De Lara Guarch, Pablo; Mrzyglod, DanielX T; Mcnamara, John > Cc: dev at dpdk.org; Ananyev, Konstantin > Subject: Re: [PATCH v6 8/8] doc: add a ptpclient sampl

[dpdk-dev] [PATCH v6 8/8] doc: add a ptpclient sample guide

2015-11-13 Thread Thomas Monjalon
2015-11-13 14:58, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Tip: the extra white margins can be stripped in inkscape with ctrl+shift+d > > and "resize page to content". > > Thanks for the tip! I will change it and send a new version shortly today. >

[dpdk-dev] [PATCH v6 8/8] doc: add a ptpclient sample guide

2015-11-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, November 13, 2015 3:11 PM > To: De Lara Guarch, Pablo > Cc: Mrzyglod, DanielX T; Mcnamara, John; dev at dpdk.org; Ananyev, > Konstantin > Subject: Re: [PATCH v6 8/8] doc: add a ptpclient sam

[dpdk-dev] ACL Library Information Request

2015-11-13 Thread Jason Terry
Thanks! -Original Message- From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] Sent: Friday, November 13, 2015 8:49 AM To: Jason Terry; dev at dpdk.org Subject: RE: ACL Library Information Request Hi Jason, > -Original Message- > From: dev [mailto:dev-bounces at dpdk

[dpdk-dev] [PATCH v6 8/8] doc: add a ptpclient sample guide

2015-11-13 Thread Thomas Monjalon
2015-11-13 15:15, De Lara Guarch, Pablo: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-11-13 14:58, De Lara Guarch, Pablo: > > > P.S.: I have done more refactoring, to make it simpler and more generic, > > will send it with the v7. > > > > Oh no! > > Please send a nack whe

[dpdk-dev] [PATCH v6 03/10] eal: add __rte_packed /__rte_aligned macros

2015-11-13 Thread Thomas Monjalon
2015-11-10 17:32, Declan Doherty: > Adding a new marco for specifing __aligned__ attribute, and updating the 2 typos spotted on this line ;) I wonder why the "marco" typo is so common.

[dpdk-dev] [PATCH v6 03/10] eal: add __rte_packed /__rte_aligned macros

2015-11-13 Thread Declan Doherty
On 13/11/15 15:35, Thomas Monjalon wrote: > 2015-11-10 17:32, Declan Doherty: >> Adding a new marco for specifing __aligned__ attribute, and updating the > > 2 typos spotted on this line ;) > I wonder why the "marco" typo is so common. > oops, I didn't have my spell-check plugin enabled in vim :(

[dpdk-dev] [PATCH v6 05/10] cryptodev: Initial DPDK Crypto APIs and device framework release

2015-11-13 Thread Thomas Monjalon
2015-11-10 17:32, Declan Doherty: > +DPDK_2.2 { > + global: > + > + rte_cryptodevs; > + rte_cryptodev_callback_register; > + rte_cryptodev_callback_unregister; > + rte_cryptodev_close; > + rte_cryptodev_count; > + rte_cryptodev_count_devtype; > + rte_cryptodev_config

[dpdk-dev] [PATCH v6 06/10] mbuf_offload: library to support attaching offloads to a mbuf

2015-11-13 Thread Thomas Monjalon
2015-11-10 17:32, Declan Doherty: > @@ -841,6 +844,9 @@ struct rte_mbuf { > + > + /* Chain of off-load operations to perform on mbuf */ > + struct rte_mbuf_offload *offload_ops; > } __rte_cache_aligned; Why is there a pointer in the mbuf structure? Can it be a metadata for the crypto

[dpdk-dev] [PATCH v6 07/10] qat_crypto_pmd: Addition of a new QAT DPDK PMD.

2015-11-13 Thread Thomas Monjalon
2015-11-10 17:32, Declan Doherty: > --- a/lib/librte_mbuf_offload/rte_mbuf_offload.h > +++ b/lib/librte_mbuf_offload/rte_mbuf_offload.h > @@ -123,17 +123,10 @@ rte_pktmbuf_offload_get(struct rte_mbuf *m, enum > rte_mbuf_ol_op_type type) > { > struct rte_mbuf_offload *ol = m->offload_ops;

[dpdk-dev] [PATCH v6 10/10] l2fwd-crypto: crypto

2015-11-13 Thread Thomas Monjalon
2015-11-10 17:32, Declan Doherty: > MAINTAINERS|1 + > examples/l2fwd-crypto/Makefile | 50 ++ > examples/l2fwd-crypto/main.c | 1473 > > 3 files changed, 1524 insertions(+) I think you missed examples/Makefile

[dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels RTE_LOG{FINE, FINER, FINEST}

2015-11-13 Thread Stephen Hemminger
On Fri, 13 Nov 2015 06:47:34 + Matthew Hall wrote: > Signed-off-by: Matthew Hall > --- > lib/librte_eal/common/include/rte_log.h | 19 +++ > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/lib/librte_eal/common/include/rte_log.h > b/lib/librte_eal/common/

[dpdk-dev] [PATCH v7 0/8] add sample ptp slave application

2015-11-13 Thread Pablo de Lara
Add a sample application that acts as a PTP slave using the DPDK IEEE1588 functions. Also add some additional IEEE1588 support functions to enable getting, setting and adjusting the device time. V6->v7: - Simplified common functionality for timecounters and make it more generic. - Reset time co

[dpdk-dev] [PATCH v7 2/8] eal: add helpers for time conversions

2015-11-13 Thread Pablo de Lara
From: Daniel Mrzyglod Add common functions and structures to handle time, and cycle counts which will be used for PTP processing. Signed-off-by: Daniel Mrzyglod Signed-off-by: Pablo de Lara Reviewed-by: John McNamara --- lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/commo

[dpdk-dev] [PATCH v7 3/8] ixgbe: support ieee1588 functions for device time

2015-11-13 Thread Pablo de Lara
From: Daniel Mrzyglod Add additional functions to support the existing IEEE1588 functionality and to enable getting, setting and adjusting the device time. Signed-off-by: Daniel Mrzyglod Signed-off-by: Pablo de Lara Reviewed-by: John McNamara --- drivers/net/ixgbe/ixgbe_ethdev.c | 244 ++

[dpdk-dev] [PATCH v7 4/8] igb: support ieee1588 functions for device time

2015-11-13 Thread Pablo de Lara
Add additional functions to support the existing IEEE1588 functionality and to enable getting, setting and adjusting the device time. Signed-off-by: Pablo de Lara Signed-off-by: Daniel Mrzyglod Reviewed-by: John McNamara --- drivers/net/e1000/e1000_ethdev.h | 4 + drivers/net/e1000/igb_ethde

[dpdk-dev] [PATCH v2 ] ixgbe: speed up transmit

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger The freeing of mbuf's in ixgbe is one of the observable hot spots under load. Optimize it by doing bulk free of mbufs using code similar to i40e and fm10k. Drop the no longer needed micro-optimization for the no refcount flag. Signed-off-by: Stephen Hemminger --- v2 - r

[dpdk-dev] [PATCH v7 1/8] ethdev: add ieee1588 functions for device clock time

2015-11-13 Thread Pablo de Lara
From: Daniel Mrzyglod Add additional functions to support the existing IEEE1588 functionality. * rte_eth_timesync_write_time(): set the device clock time. * rte_eth_timesync_read_time(): get the device clock time. * rte_eth_timesync_adjust_time(): adjust the device clock time. Signed-o

[dpdk-dev] [PATCH v7 5/8] i40e: support ieee1588 functions for device time

2015-11-13 Thread Pablo de Lara
Add additional functions to support the existing IEEE1588 functionality and to enable getting, setting and adjusting the device time. Signed-off-by: Pablo de Lara Signed-off-by: Daniel Mrzyglod Reviewed-by: John McNamara --- drivers/net/i40e/i40e_ethdev.c | 210

[dpdk-dev] [PATCH v7 6/8] testpmd: add nanosecond output for ieee1588

2015-11-13 Thread Pablo de Lara
Testpmd was only printing out second values when printing RX/TX timestamp value, instead of both second and nanoseconds. Since resolution of time counters is in nanoseconds, testpmd should print out both. Signed-off-by: Pablo de Lara Reviewed-by: John McNamara --- app/test-pmd/ieee1588fwd.c | 8

[dpdk-dev] [PATCH v7 7/8] example: add minimal PTP client

2015-11-13 Thread Pablo de Lara
From: Daniel Mrzyglod Add a sample application that acts as a PTP slave using the DPDK ieee1588 functions. Signed-off-by: Daniel Mrzyglod Signed-off-by: Pablo de Lara Reviewed-by: John McNamara --- MAINTAINERS| 4 + examples/Makefile | 1 + examples/ptpcl

[dpdk-dev] [PATCH v7 8/8] doc: add a ptpclient sample guide

2015-11-13 Thread Pablo de Lara
From: Daniel Mrzyglod Add a sample app guide for the ptpclient application. Signed-off-by: Daniel Mrzyglod Signed-off-by: Pablo de Lara Reviewed-by: John McNamara --- doc/guides/sample_app_ug/img/ptpclient.svg | 528 + doc/guides/sample_app_ug/index.rst |

[dpdk-dev] [PATCH v4 1/3] rte: add keep alive functionality

2015-11-13 Thread Thomas Monjalon
2015-11-05 11:32, Remy Horton: > --- /dev/null > +++ b/lib/librte_eal/common/include/rte_keepalive.h Please add it in doxygen configuration and index. > --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > @@ -133,5 +133,9 @@ DPDK_2.2 { >

[dpdk-dev] [PATCH v2 04/11] doc: Add BNX2X PMD documentation

2015-11-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Rasesh Mody > Sent: Monday, November 9, 2015 11:56 PM > To: thomas.monjalon at 6wind.com > Cc: dev at dpdk.org; sony.chacko at qlogic.com > Subject: [dpdk-dev] [PATCH v2 04/11] doc: Add BNX2X PMD documentation >

[dpdk-dev] [PATCH v6 06/10] mbuf_offload: library to support attaching offloads to a mbuf

2015-11-13 Thread Thomas Monjalon
2015-11-10 17:32, Declan Doherty: > +DEPDIRS-$(CONFIG_RTE_LIBRTE_MBUF_OFFLOAD) += lib/librte_cryptodev Why this lib depends on cryptodev? Shoudn't be the reverse?

[dpdk-dev] [PATCH v6 07/10] qat_crypto_pmd: Addition of a new QAT DPDK PMD.

2015-11-13 Thread Declan Doherty
On 13/11/15 16:00, Thomas Monjalon wrote: > 2015-11-10 17:32, Declan Doherty: >> --- a/lib/librte_mbuf_offload/rte_mbuf_offload.h >> +++ b/lib/librte_mbuf_offload/rte_mbuf_offload.h >> @@ -123,17 +123,10 @@ rte_pktmbuf_offload_get(struct rte_mbuf *m, enum >> rte_mbuf_ol_op_type type) >> { >>

[dpdk-dev] [PATCH v2] ip_pipeline: add flow actions pipeline

2015-11-13 Thread Fan Zhang
Flow actions pipeline is an extension of flow-classification pipeline. Some of the operations of flow classification pipeline such as traffic metering/marking(for e.g. Single Rate Three Color Marker (srTCM), Two Rate Three Color Marker trTCM)), policer can be performed separately in flow action pip

[dpdk-dev] [PATCH v7 0/8] add sample ptp slave application

2015-11-13 Thread Thomas Monjalon
2015-11-13 16:09, Pablo de Lara: > V6->v7: > - Simplified common functionality for timecounters and make it more generic. So you chose to drop the read() callback? I think it's better. What was the benefit of having it?

[dpdk-dev] support for X552/X557-AT 10GBase-T devices

2015-11-13 Thread Aws Ismail
Hi all, I have sent in an earlier email, but it seems it did not get any reply. I just wanted to confirm whether the 0x15ad X552/X557-AT 10GBase-T devices are currently "fully" supported by DPDK (master). Does anyone know about this? I have looked at the ixgbe PMD code and I can see 0x15AD bein

[dpdk-dev] [PATCH v2] ip_pipeline: add flow actions pipeline

2015-11-13 Thread Thomas Monjalon
2015-11-13 16:29, Fan Zhang: > examples/ip_pipeline/Makefile |2 + > examples/ip_pipeline/app.h |1 + > examples/ip_pipeline/init.c|4 + > .../ip_pipeline/pipeline/pipeline_actions_common.h | 83 + > examples/ip_pip

[dpdk-dev] [PATCH v7 0/8] add sample ptp slave application

2015-11-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, November 13, 2015 4:29 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; konstatin.ananyev at intel.com > Subject: Re: [PATCH v7 0/8] add sample ptp slave application > > 2015-11-13 16:

[dpdk-dev] [PATCH] rte_log.h: display level in logs from RTE_LOG

2015-11-13 Thread Stephen Hemminger
On Fri, 13 Nov 2015 15:11:09 +0200 Panu Matilainen wrote: > On 11/13/2015 07:50 AM, Matthew Hall wrote: > > Signed-off-by: Matthew Hall > > --- > > lib/librte_eal/common/include/rte_log.h | 8 > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/lib/librte_eal/com

[dpdk-dev] support for X552/X557-AT 10GBase-T devices

2015-11-13 Thread Thomas Monjalon
2015-11-13 11:32, Aws Ismail: > I just wanted to confirm whether the 0x15ad X552/X557-AT 10GBase-T > devices are currently "fully" supported by DPDK (master). My understanding is that it is supported: http://dpdk.org/browse/dpdk/commit/?id=2e83c81bad (but you can have a hint in the last le

[dpdk-dev] [PATCH v7 0/8] add sample ptp slave application

2015-11-13 Thread Thomas Monjalon
2015-11-13 16:09, Pablo de Lara: > Daniel Mrzyglod (5): > ethdev: add additional ieee1588 support functions > eal: add common time structures and functions > ixgbe: add additional ieee1588 support functions > example: minimal ptp client implementation > doc: add a ptpclient sample guide >

[dpdk-dev] [PATCH v6 2/2] doc: add user-space ethtool sample app guide

2015-11-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Remy Horton > Sent: Friday, November 6, 2015 4:11 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v6 2/2] doc: add user-space ethtool sample app > guide Hi, Thanks for this. A few minor comments below:

[dpdk-dev] [PATCH] doc: update user guide about e1000em limitations

2015-11-13 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yong Liu > Sent: Friday, October 30, 2015 9:23 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: update user guide about e1000em > limitations > > Update interrupt related limitations for e1000em nic.

[dpdk-dev] [PATCH 00/10] rte_sched: enhancements and cleanups

2015-11-13 Thread Stephen Hemminger
Hierarchal scheduler changes. Most of these are cleanups for existing code to make it more compatiable with coding style, and eliminate #ifdefs. The only substantive change is to allow more subports per scheduler instance. This was submitted for DPDK 2.1 but since it required some ABI finesse to

[dpdk-dev] [PATCH] doc: fix repeated typo in sample app docs

2015-11-13 Thread John McNamara
Fix repeated typo in the "Compiling the Application" section of almost all of the sample app docs. This generally gets copied into new sample app guides. Signed-off-by: John McNamara --- doc/guides/sample_app_ug/kernel_nic_interface.rst| 4 ++-- doc/guides/sample_app_ug/l2_forward_job_stats

[dpdk-dev] [PATCH v2 00/10] rte_sched: enhancements and cleanups

2015-11-13 Thread Stephen Hemminger
Hierarchal scheduler changes (resend) Most of these are cleanups for existing code to make it more compatiable with coding style, and eliminate #ifdefs. The only substantive change is to allow more subports per scheduler instance. This was submitted for DPDK 2.1 but since it required some ABI fin

[dpdk-dev] [PATCH v2 01/10] sched: drop deprecated port hierarchy structure

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger The actual port_hierarchy was deprecated and hidden in 2.1 so drop it from view in DPDK 2.2 Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 14 +++--- lib/librte_sched/rte_sched.h | 14 -- 2 files changed, 7 insertions(+), 21 dele

[dpdk-dev] [PATCH v2 02/10] sched: cleanup comments

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger Break block comments that exceed common practice for line length. Shorten wording for obvious things. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 8 +- lib/librte_sched/rte_sched.h | 221 +-- 2 files chan

[dpdk-dev] [PATCH v2 03/10] sched: make debugging configurable

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger All #ifdefs in code should be enabled/disabled via DPDK config (or better yet removed all together). Signed-off-by: Stephen Hemminger --- config/common_bsdapp | 1 + config/common_linuxapp | 1 + lib/librte_sched/rte_sched.c | 10 +++--- 3 files chan

[dpdk-dev] [PATCH v2 04/10] sched: drop debug #ifdef's for credit check

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger Drop conditional code which was for debugging credit checks. It is hard to maintain code with any additional #ifdef baggage. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) dif

[dpdk-dev] [PATCH v2 05/10] sched: remove debug conditional code around ENQUEUE

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger Remove RTE_SCHED_ENQUEUE ifdef that was always being set. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 35 +-- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_

[dpdk-dev] [PATCH v2 06/10] sched: drop RTE_SCHED_WRR #define

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger The RTE_SCHED_WRR value is always defined as 1. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 25 - 1 file changed, 25 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index 3400b73..1f8

[dpdk-dev] [PATCH v2 07/10] sched: cleanup defined constants

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger Only use RTE_SCHED_PORT_N_GRINDERS from config. Use RTE_BUILD_BUG_ON for errors. The remaining implementation constants can be put together. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 22 -- 1 file changed, 4 insertions(+), 1

[dpdk-dev] [PATCH v2 08/10] sched: allow enabling SSE optimizations in config

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger Make the SSE optimizations visible as a normal config option. Signed-off-by: Stephen Hemminger --- config/common_bsdapp | 1 + config/common_linuxapp | 1 + lib/librte_sched/rte_sched.c | 8 ++-- 3 files changed, 4 insertions(+), 6 deletions(-) diff -

[dpdk-dev] [PATCH v2 09/10] sched: fix coding style

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger Make rte_sched conform to kernel/DPDK coding style. Fix missing whitespace and some of the excessively long lines. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 415 +++ 1 file changed, 218 insertions(+), 197

[dpdk-dev] [PATCH v2 10/10] sched: allow more subports

2015-11-13 Thread Stephen Hemminger
From: Stephen Hemminger Increase the number of possible subports per port to allow up to 16 bits. It is still possible that this will require excessive RAM. Although mbuf structure is changed, it is ABI compatiable since it just expands existing sched part of structure to overlap pre-existing ho

[dpdk-dev] support for X552/X557-AT 10GBase-T devices

2015-11-13 Thread Aws Ismail
On Fri, Nov 13, 2015 at 11:40 AM, Thomas Monjalon wrote: > 2015-11-13 11:32, Aws Ismail: >> I just wanted to confirm whether the 0x15ad X552/X557-AT 10GBase-T >> devices are currently "fully" supported by DPDK (master). > > My understanding is that it is supported: > http://dpdk.org/browse

[dpdk-dev] Coverity policy for upstream (base) drivers.

2015-11-13 Thread Matthew Hall
On Fri, Nov 13, 2015 at 12:12:04AM +, Mcnamara, John wrote: > If people haven't already done so I would urge them to sign up and view/fix > the defects. > > https://scan.coverity.com/users/sign_up > https://scan.coverity.com/projects/4005 (DPDK) Hi John, I got signed up. Thanks for

[dpdk-dev] [PATCH v7 00/10] Crypto API and device framework

2015-11-13 Thread Declan Doherty
This series of patches defines a set of application burst oriented APIs for asynchronous symmetric cryptographic functions within DPDK. It also contains a poll mode driver cryptographic device framework for the implementation of crypto devices within DPDK. In the patch set we also have included 2

[dpdk-dev] [PATCH v7 02/10] ethdev: make error checking macros public

2015-11-13 Thread Declan Doherty
Move the function pointer and port id checking macros to rte_ethdev and rte_dev header files, so that they can be used in the static inline functions there. Also replace the RTE_LOG call within RTE_PMD_DEBUG_TRACE so this macro can be built with the -pedantic flag Signed-off-by: Declan Doherty Ac

  1   2   >