On 13/11/15 16:00, Thomas Monjalon wrote: > 2015-11-10 17:32, Declan Doherty: >> --- a/lib/librte_mbuf_offload/rte_mbuf_offload.h >> +++ b/lib/librte_mbuf_offload/rte_mbuf_offload.h >> @@ -123,17 +123,10 @@ rte_pktmbuf_offload_get(struct rte_mbuf *m, enum >> rte_mbuf_ol_op_type type) >> { >> struct rte_mbuf_offload *ol = m->offload_ops; >> >> - if (m->offload_ops != NULL && m->offload_ops->type == type) >> - return ol; >> - >> - ol = m->offload_ops; >> - while (ol != NULL) { >> + for (ol = m->offload_ops; ol != NULL; ol = ol->next) >> if (ol->type == type) >> return ol; >> >> - ol = ol->next; >> - } >> - >> return ol; >> } > > Strange: why changing the code of the previous patch? >
I squashed this tidy up into the wrong patch. I'll fix in v7