[dpdk-dev] [PATCH 1/3] pcap: utilize underlying real interface properties

2015-04-29 Thread Nicolás Pernas Maradei
Hi Tero, Just a few comments on one of your patches - see inline comments below. Interesting features btw. Nico. --? Nicol?s Pernas Maradei On 27 February 2015 at 13:43:14, dev-request at dpdk.org (dev-request at dpdk.org) wrote: Message: 5? Date: Fri, 27 Feb 2015 15:42:38 +0200? From: Tero

[dpdk-dev] NMI Watchdog warning

2015-04-29 Thread 陳政柏
Hi,all When I enabled nmi_watchdog, and I get following warning messages. How can I resolve it? Kernel version is 3.10.52 [ 940.093592] [ cut here ] [ 940.098218] WARNING: at kernel/watchdog.c:245 watchdog_overflow_callback+0x94/0xc0() [ 940.105960] Watchdog de

[dpdk-dev] [PATCH v1 3/4] ixgbe: Kill ixgbe_recv_scattered_pkts()

2015-04-29 Thread Vlad Zolotarov
On 04/28/15 20:42, Ananyev, Konstantin wrote: > Hi Vlad, > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >> Sent: Sunday, April 26, 2015 3:46 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH v1 3/4] ixgbe: Kill ixgbe_recv_scattered_

[dpdk-dev] [PATCH v1 3/4] ixgbe: Kill ixgbe_recv_scattered_pkts()

2015-04-29 Thread Vlad Zolotarov
On 04/29/15 09:47, Vlad Zolotarov wrote: > > > On 04/28/15 20:42, Ananyev, Konstantin wrote: >> Hi Vlad, >> >>> -Original Message- >>> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov >>> Sent: Sunday, April 26, 2015 3:46 PM >>> To: dev at dpdk.org >>> Subject: [dpdk

[dpdk-dev] data copy in vhost-user

2015-04-29 Thread Nikita Kalyazin
Zoltan, Huawei, Thank you for your replies. -- Best regards, Nikita Kalyazin, n.kalyazin at samsung.com CE OS Group Samsung R&D Institute Russia Tel: +7 (495) 797-25-00 #3816 Tel: +7 (495) 797-25-03 Office #1501, 12-1, Dvintsev str., Moscow, 127018, Russia On Tue, Apr 28, 2015 at 01:24:25PM

[dpdk-dev] [RFC PATCH] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Gonzalez Monroy, Sergio
On 28/04/2015 17:50, Wiles, Keith wrote: > Hi Sergio > > On 4/28/15, 11:25 AM, "Gonzalez Monroy, Sergio" > wrote: > >> On 28/04/2015 16:21, Keith Wiles wrote: >>> Trying to simplify the ifdefs in rte.app.mk to make the code >>> more readable and maintainable by moving LDLIBS variable to use >>> th

[dpdk-dev] [PATCH 0/3] pcap pmd improvements

2015-04-29 Thread Nicolas Pernas Maradei
Hi, I had a look to the patch set last night and it looks good to me apart from the few comments that I've already shared with Tero. Nico. On 28/04/15 13:09, Mcnamara, John wrote: >> -Original Message- >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] >> Sent: Tuesday, Apri

[dpdk-dev] gmake test on freeBSD

2015-04-29 Thread Bruce Richardson
On Tue, Apr 28, 2015 at 06:15:53PM -0700, Ravi Kerur wrote: > DPDK team, > > Is there a automated tests to run on freeBSD similar to Linux (make test). > > I ran "gmake test T=x86_64-native-bsdapp-clang CC=clang" I get following > output > > /usr/home/rkerur/dpdk-validate-abi-1/dpdk/build/app/te

[dpdk-dev] [PATCH v2 0/5]: Cleanups in the ixgbe PMD

2015-04-29 Thread Vlad Zolotarov
This series includes: - Fix the "issue" introduced in 01fa1d6215fa7cd6b5303ac9296381b75b9226de: files in librte_pmd_ixgbe/ixgbe/ are shared with FreeBSD and AFAIU should not be changed unless the change is pushed into the FreeBSD tree first. - Remove unused rsc_en field in ixgbe_rx

[dpdk-dev] [PATCH v2 1/5] ixgbe: move rx_bulk_alloc_allowed and rx_vec_allowed to ixgbe_adapter

2015-04-29 Thread Vlad Zolotarov
Move the above fields from ixgbe_hw to ixgbe_adapter. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h | 2 -- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 8 +++ lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 3 +++ lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 38 ++

[dpdk-dev] [PATCH v2 2/5] ixgbe: ixgbe_rx_queue: remove unused rsc_en field

2015-04-29 Thread Vlad Zolotarov
Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 --- lib/librte_pmd_ixgbe/ixgbe_rxtx.h | 1 - 2 files changed, 4 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index 60344a9..a45f51e 100644 --- a/lib/librte_pmd_ixgbe/ixgbe

[dpdk-dev] [PATCH v2 3/5] ixgbe: Rename yy_rsc_xx -> yy_sc/scattered_rx_xx

2015-04-29 Thread Vlad Zolotarov
- ixgbe_rsc_entry -> ixgbe_scattered_rx_entry - sw_rsc_ring -> sw_sc_ring - ixgbe_free_rsc_cluster() -> ixgbe_free_sc_cluster() - In local variables: xx_rsc_yy -> xx_sc_yy Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 48 +++

[dpdk-dev] [PATCH v2 4/5] ixgbe: Kill ixgbe_recv_scattered_pkts()

2015-04-29 Thread Vlad Zolotarov
Kill ixgbe_recv_scattered_pkts() - use ixgbe_recv_pkts_lro_single_alloc() instead. Work against HW queues in LRO and scattered Rx cases is exactly the same. Therefore we may drop the inferior callback. This patch also changes the sw_rsc_ring allocation in the ixgbe_dev_rx_queue_setup() to always

[dpdk-dev] [PATCH v2 5/5] ixgbe: Add support for scattered Rx with bulk allocation.

2015-04-29 Thread Vlad Zolotarov
Simply initialze rx_pkt_burst callback to ixgbe_recv_pkts_lro_bulk_alloc() if the conditions are right. This is possible because work against HW in LRO and scattered cases is exactly the same and LRO callback already supports the bulk allocation. Signed-off-by: Vlad Zolotarov --- lib/librte_pm

[dpdk-dev] [PATCH v1 3/4] ixgbe: Kill ixgbe_recv_scattered_pkts()

2015-04-29 Thread Ananyev, Konstantin
> -Original Message- > From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com] > Sent: Wednesday, April 29, 2015 7:50 AM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 3/4] ixgbe: Kill ixgbe_recv_scattered_pkts() > > > > On 04/29/15 09:47, Vlad Zolot

[dpdk-dev] [PATCH] test-pmd fix default mbuf size

2015-04-29 Thread Olivier MATZ
Hi Konstantin, On 04/28/2015 03:02 PM, Konstantin Ananyev wrote: > Latest mbuf changes (priv_size addition and related fixes) > exposed small problem with testpmd default config: > testpmd default mbuf size is exaclty 2KB, that causes > ixgbe PMD to select scattered RX even for configs with 'norma

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-29 Thread Neil Horman
On Tue, Apr 28, 2015 at 04:52:37PM -0700, Ravi Kerur wrote: > On Tue, Apr 28, 2015 at 12:35 PM, Neil Horman > wrote: > > > On Mon, Apr 27, 2015 at 03:39:41PM -0700, Ravi Kerur wrote: > > > On Mon, Apr 27, 2015 at 6:44 AM, Neil Horman > > wrote: > > > > > > > On Sat, Apr 25, 2015 at 05:09:01PM -

[dpdk-dev] [PATCH] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Thomas Monjalon
Hi Keith, Thanks for trying to improve maintainability. It seems this is the second version of your patch. Please add v2 prefix and a changelog to ease review and patch management. As you probably know, it is explained here: http://dpdk.org/dev#send 2015-04-28 19:03 GMT+02:00 Keith Wiles : >

[dpdk-dev] [PATCH v8 0/6] Move common functions in EAL

2015-04-29 Thread Neil Horman
On Tue, Apr 28, 2015 at 04:46:21PM -0700, Ravi Kerur wrote: > Changes in v8 includes > Re-ordering source file compilation to fix ABI warning. > Ran validate-abi against x86_64-native-linuxapp-gcc, > x86_64-native-linuxapp-clang and x86_64-ivshmem-linuxapp-gcc > environments. > > Testing: > Linux

[dpdk-dev] [PATCH] test-pmd fix default mbuf size

2015-04-29 Thread Ananyev, Konstantin
Hi Olivier, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Wednesday, April 29, 2015 10:55 AM > To: Ananyev, Konstantin; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] test-pmd fix default mbuf size > > Hi Konstantin, > > On 04/28/2015 03:02 PM, K

[dpdk-dev] [PATCH] test-pmd fix default mbuf size

2015-04-29 Thread Olivier MATZ
Hi Konstantin, On 04/29/2015 12:39 PM, Ananyev, Konstantin wrote: > Hi Olivier, > >> -Original Message- >> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] >> Sent: Wednesday, April 29, 2015 10:55 AM >> To: Ananyev, Konstantin; dev at dpdk.org >> Subject: Re: [dpdk-dev] [PATCH] test-p

[dpdk-dev] [PATCH] doc: disable doxygen member sorting

2015-04-29 Thread John McNamara
Disabled the doxygen option to sort member data so that functions and struct memebers are listed in order of definition in the brief and main sections. Previously they were sorted in the brief section and were in definition order in the main section. Signed-off-by: John McNamara --- doc/api/dox

[dpdk-dev] [PATCH] doc: disable doxygen member sorting

2015-04-29 Thread Mcnamara, John
> -Original Message- > From: Mcnamara, John > Sent: Wednesday, April 29, 2015 11:48 AM > To: dev at dpdk.org > Cc: Mcnamara, John > Subject: [PATCH] doc: disable doxygen member sorting > > Disabled the doxygen option to sort member data so that functions and > struct memebers are listed in

[dpdk-dev] [PATCH] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Gonzalez Monroy, Sergio
On 29/04/2015 11:12, Thomas Monjalon wrote: > Hi Keith, > > Thanks for trying to improve maintainability. > > It seems this is the second version of your patch. > Please add v2 prefix and a changelog to ease review and > patch management. > As you probably know, it is explained here: > http://

[dpdk-dev] [PATCH v2] vhost: flush used->idx update before reading avail->flags

2015-04-29 Thread Huawei Xie
update of used->idx and read of avail->flags could be reordered. memory fence should be used to ensure the order, otherwise guest could see a stale used->idx value after it toggles the interrupt suppression flag. After guest sets the interrupt suppression flag, it will check if there is more buff

[dpdk-dev] [PATCH v2 0/5]: Cleanups in the ixgbe PMD

2015-04-29 Thread Ananyev, Konstantin
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Vlad Zolotarov > Sent: Wednesday, April 29, 2015 9:38 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2 0/5]: Cleanups in the ixgbe PMD > > This series includes: >- Fix the "issue" introduced in 01fa1d6215fa7cd6b5303ac9296381b75b

[dpdk-dev] [PATCH] vhost: make vhost lockless enqueue configurable

2015-04-29 Thread Huawei Xie
vhost enabled vSwitch could have their own thread-safe vring enqueue policy. Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for vhost lockless enqueue. Turn it off by default. Signed-off-by: Huawei Xie --- config/common_linuxapp| 1 + lib/librte_vhost/vhost_rxtx.c | 24

[dpdk-dev] [PATCH] vhost: make vhost lockless enqueue configurable

2015-04-29 Thread Panu Matilainen
On 04/29/2015 02:29 PM, Huawei Xie wrote: > vhost enabled vSwitch could have their own thread-safe vring enqueue policy. > Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for vhost lockless enqueue. > Turn it off by default. > > Signed-off-by: Huawei Xie > --- > config/common_linuxapp| 1 +

[dpdk-dev] [PATCH] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Thomas Monjalon
2015-04-29 13:08 GMT+02:00 Gonzalez Monroy, Sergio : > On 29/04/2015 11:12, Thomas Monjalon wrote: >> It seems this is the second version of your patch. >> Please add v2 prefix and a changelog to ease review and >> patch management. >> As you probably know, it is explained here: >> http://dpdk

[dpdk-dev] [PATCH] vhost: make vhost lockless enqueue configurable

2015-04-29 Thread Thomas Monjalon
2015-04-29 13:38 GMT+02:00 Panu Matilainen : > On 04/29/2015 02:29 PM, Huawei Xie wrote: >> >> vhost enabled vSwitch could have their own thread-safe vring enqueue >> policy. >> Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for vhost lockless enqueue. >> Turn it off by default. >> >> Signed-off-by: H

[dpdk-dev] Issues with rte_hash_crc.h when compiling with C++

2015-04-29 Thread Pavel Odintsov
Hello! I have C++ application compiles and works nice. But when I include rte_hash_crc.h header everything goes away. CC main.o In file included from /usr/src/dpdk-2.0.0/x86_64-native-linuxapp-gcc/include/rte_cpuflags.h:46:0, from /usr/src/dpdk-2.0.0/x86_64-native-linuxapp-gcc/

[dpdk-dev] [PATCH] kni: fix compilation issue on kernel 4.0.0

2015-04-29 Thread Thomas Monjalon
2015-04-28 18:37, Pablo de Lara: > Due to API changes in function pointer ndo_bridge_setlink > (commit ad41faa8) and the rename of functions vlan_tx_* > (commit df8a39de) in kernel 4.0, DPDK would not build. > > This patch adds the properly checks to fix the compilation. > > Reported-by: Stephen

[dpdk-dev] [PATCH] doc: disable doxygen member sorting

2015-04-29 Thread Butler, Siobhan A
Thanks for making this change John - it helps with readability Siobhan Acked-by Siobhan Butler > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mcnamara, John > Sent: Wednesday, April 29, 2015 11:52 AM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Wiles, Keith
On 4/29/15, 6:51 AM, "Thomas Monjalon" wrote: >2015-04-29 13:08 GMT+02:00 Gonzalez Monroy, Sergio >: >> On 29/04/2015 11:12, Thomas Monjalon wrote: >>> It seems this is the second version of your patch. >>> Please add v2 prefix and a changelog to ease review and >>> patch management. >>> As you

[dpdk-dev] [RFC PATCH] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Wiles, Keith
On 4/29/15, 3:04 AM, "Gonzalez Monroy, Sergio" wrote: >On 28/04/2015 17:50, Wiles, Keith wrote: >> Hi Sergio >> >> On 4/28/15, 11:25 AM, "Gonzalez Monroy, Sergio" >> wrote: >> >>> On 28/04/2015 16:21, Keith Wiles wrote: Trying to simplify the ifdefs in rte.app.mk to make the code mor

[dpdk-dev] [RFC PATCH] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Wiles, Keith
On 4/29/15, 9:09 AM, "Wiles, Keith" wrote: > > >On 4/29/15, 3:04 AM, "Gonzalez Monroy, Sergio" > wrote: > >>On 28/04/2015 17:50, Wiles, Keith wrote: >>> Hi Sergio >>> >>> On 4/28/15, 11:25 AM, "Gonzalez Monroy, Sergio" >>> wrote: >>> On 28/04/2015 16:21, Keith Wiles wrote: > Trying to

[dpdk-dev] [PATCH v2 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Keith Wiles
Trying to simplify the ifdefs in rte.app.mk to make the code more readable and maintainable by moving LDLIBS variable to use the same style as LDLIBS-y being used in the rest of the code. Added a new variable called EXTRA_LDLIBS to be used by example apps instead of using LDLIBS directly. Signed-

[dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/build-sdk-quick.txt | 1 + doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/build-sdk-quick.txt b/doc/buil

[dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Gonzalez Monroy, Sergio
On 29/04/2015 15:37, Keith Wiles wrote: > Signed-off-by: Keith Wiles > --- > doc/build-sdk-quick.txt | 1 + > doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ > doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- > 3 files changed, 4 insertions(+), 1 dele

[dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Wiles, Keith
On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" wrote: >On 29/04/2015 15:37, Keith Wiles wrote: >> Signed-off-by: Keith Wiles >> --- >> doc/build-sdk-quick.txt | 1 + >> doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ >> doc/guides/prog_guide/dev_kit_root_m

[dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Gonzalez Monroy, Sergio
On 29/04/2015 16:00, Wiles, Keith wrote: > > On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" > wrote: > >> On 29/04/2015 15:37, Keith Wiles wrote: >>> Signed-off-by: Keith Wiles >>> --- >>>doc/build-sdk-quick.txt | 1 + >>>doc/guides/prog_guide/dev_kit_build_system.

[dpdk-dev] [PATCH] kni: fix compilation issue on kernel 4.0.0

2015-04-29 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, April 29, 2015 2:20 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation issue on kernel 4.0.0 > > 2015-04-28 18:37, Pabl

[dpdk-dev] [PATCH v3 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Keith Wiles
Trying to simplify the ifdefs in rte.app.mk to make the code more readable and maintainable by moving LDLIBS variable to use the same style as LDLIBS-y being used in the rest of the code. Added a new variable called EXTRA_LDLIBS to be used by example apps instead of using LDLIBS directly. Signed-

[dpdk-dev] [PATCH v3 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/build-sdk-quick.txt | 1 + doc/guides/prog_guide/build_app.rst | 2 +- doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- 4 files changed, 5 insertions(+), 2 del

[dpdk-dev] [PATCH v2 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Bruce Richardson
On Wed, Apr 29, 2015 at 09:37:42AM -0500, Keith Wiles wrote: > Trying to simplify the ifdefs in rte.app.mk to make the code > more readable and maintainable by moving LDLIBS variable to use > the same style as LDLIBS-y being used in the rest of the code. > > Added a new variable called EXTRA_LDLIB

[dpdk-dev] [PATCH v2 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Wiles, Keith
On 4/29/15, 10:11 AM, "Richardson, Bruce" wrote: >On Wed, Apr 29, 2015 at 09:37:42AM -0500, Keith Wiles wrote: >> Trying to simplify the ifdefs in rte.app.mk to make the code >> more readable and maintainable by moving LDLIBS variable to use >> the same style as LDLIBS-y being used in the rest

[dpdk-dev] [PATCH] vfio: eventfd should be non-block and not inherited

2015-04-29 Thread Stephen Hemminger
Set internal event file descriptor to be non-block and not inherited across exec. This prevents accidental hangs and passing in anothr thread. Signed-off-by: Stephen Hemminger --- lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/

[dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Wiles, Keith
On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio" wrote: >On 29/04/2015 16:00, Wiles, Keith wrote: >> >> On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" >> wrote: >> >>> On 29/04/2015 15:37, Keith Wiles wrote: Signed-off-by: Keith Wiles --- doc/build-sdk-quick.txt

[dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Gonzalez Monroy, Sergio
On 29/04/2015 16:16, Wiles, Keith wrote: > > On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio" > wrote: > >> On 29/04/2015 16:00, Wiles, Keith wrote: >>> On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" >>> wrote: >>> On 29/04/2015 15:37, Keith Wiles wrote: > Signed-off-by: Keith Wiles

[dpdk-dev] [PATCH v2 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Wiles, Keith
On 4/29/15, 10:19 AM, "Gonzalez Monroy, Sergio" wrote: >On 29/04/2015 16:16, Wiles, Keith wrote: >> >> On 4/29/15, 10:04 AM, "Gonzalez Monroy, Sergio" >> wrote: >> >>> On 29/04/2015 16:00, Wiles, Keith wrote: On 4/29/15, 9:55 AM, "Gonzalez Monroy, Sergio" wrote: > On 29/04/

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Keith Wiles
Trying to simplify the ifdefs in rte.app.mk to make the code more readable and maintainable by moving LDLIBS variable to use the same style as LDLIBS-y being used in the rest of the code. Added a new variable called EXTRA_LDLIBS to be used by example apps instead of using LDLIBS directly. Signed-

[dpdk-dev] [PATCH v4 2/2] Update Docs for new EXTRA_LDLIBS variable

2015-04-29 Thread Keith Wiles
Signed-off-by: Keith Wiles --- doc/build-sdk-quick.txt | 1 + doc/guides/prog_guide/build_app.rst | 2 +- doc/guides/prog_guide/dev_kit_build_system.rst | 2 ++ doc/guides/prog_guide/dev_kit_root_make_help.rst | 2 +- 4 files changed, 5 insertions(+), 2 del

[dpdk-dev] [PATCH] doc: disable doxygen member sorting

2015-04-29 Thread Jayakumar, Muthurajan
Thanks for making this. Acked Thanks M Jay http://dpdk.readthedocs.org/en/latest/ -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Butler, Siobhan A Sent: Wednesday, April 29, 2015 6:56 AM To: Mcnamara, John; dev at dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: di

[dpdk-dev] [PATCH] vfio: eventfd should be non-block and not inherited

2015-04-29 Thread Burakov, Anatoly
> Set internal event file descriptor to be non-block and not inherited across > exec. This prevents accidental hangs and passing in anothr thread. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

[dpdk-dev] [PATCH 03/10] hash: silence -Wcast-align on pointer arithmetic

2015-04-29 Thread Cyril Chemparathy
Since sig_tbl_bucket_size and key_tbl_key_size are explicitly aligned at initialization, offset dereferences in the hash table code cannot possibly be unaligned. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_ADD(), thereby

[dpdk-dev] [PATCH 00/10] Improve cast alignment for strict aligned machines

2015-04-29 Thread Cyril Chemparathy
This series contains a few improvements that allow the DPDK code base to build properly on machines that enforce strict pointer cast alignment constraints. When dealing with packet data which could be arbitrarily aligned, we get the compiler to do the right thing by (a) making sure that header typ

[dpdk-dev] [PATCH 02/10] mempool: silence -Wcast-align on pointer arithmetic

2015-04-29 Thread Cyril Chemparathy
Translating from a mempool object to the mempool pointer does not break alignment constraints. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_SUB(), thereby silencing the compiler by casting through (void *). Signed-off-by

[dpdk-dev] [PATCH 01/10] eal: add and use unaligned integer types

2015-04-29 Thread Cyril Chemparathy
On machines that are strict on pointer alignment, current code breaks on GCC's -Wcast-align checks on casts from narrower to wider types. This patch introduces new unaligned_uint(16|32|64)_t types, which correctly retain alignment in such cases. This is currently unimplemented on ICC and clang, a

[dpdk-dev] [PATCH 04/10] mbuf: silence -Wcast-align on pointer arithmetic

2015-04-29 Thread Cyril Chemparathy
Translating from an mbuf element to the mbuf pointer does not break alignment constraints. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_SUB(), thereby silencing the compiler by casting through (void *). Signed-off-by: Cy

[dpdk-dev] [PATCH 06/10] app/test-pmd: pack simple_gre_hdr

2015-04-29 Thread Cyril Chemparathy
Not packing this causes -Wcast-align breakage on machines that are strict on alignment. This patch fixes this bug. Signed-off-by: Cyril Chemparathy --- app/test-pmd/csumonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c i

[dpdk-dev] [PATCH 05/10] ethdev: silence -Wcast-align on pointer arithmetic

2015-04-29 Thread Cyril Chemparathy
Statistics offsets in the rte_stats_strings[] array are always 64-bit aligned. However, the compiler is unaware of this fact and complains on -Wcast-align. This patch modifies the code to use RTE_PTR_ADD(), thereby silencing the compiler by casting through (void *). Signed-off-by: Cyril Chemparath

[dpdk-dev] [PATCH 07/10] app/test: use struct ether_addr instead of a byte array cast

2015-04-29 Thread Cyril Chemparathy
This patch instantiates struct ether_addr instead of type casting a uint8_t pointer to the same structure. The type cast breaks on machines that enforce strict alignment. Signed-off-by: Cyril Chemparathy --- app/test/test_pmd_perf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(

[dpdk-dev] [PATCH 09/10] librte_mbuf: Add transform for rte_pktmbuf_mtod_offset()

2015-04-29 Thread Cyril Chemparathy
This patch adds a coccinelle (see http://coccinelle.lip6.fr/) transform to use the newly added rte_pktmbuf_mtod_offset() helper. In addition, we add a simple script to apply all available transforms to a codebase. Signed-off-by: Cyril Chemparathy --- scripts/cocci.sh| 64 +++

[dpdk-dev] [PATCH 08/10] librte_mbuf: Add rte_pktmbuf_mtod_offset()

2015-04-29 Thread Cyril Chemparathy
There are a number of instances in the code where rte_pktmbuf_mtod() is used to get the mbuf data pointer, only to add an offset before casting the result to some other header type. This patch adds a new rte_pktmbuf_mtod_offset() macro to eliminate these awful double cast situations. Signed-off-b

[dpdk-dev] [PATCH 10/10] librte_mbuf: Apply mtod-offset.cocci transform

2015-04-29 Thread Cyril Chemparathy
This patch simply applies the transform previously committed in scripts/cocci/mtod-offset.cocci. No other modifications have been made here. This patch applies on commit 9f0bf3f4a3eabd7ab5af13b4ed793c36e7615b35. This patch may need to be regenerated by rerunning scripts/cocci.sh instead of simpl

[dpdk-dev] [PATCH] doc: disable doxygen member sorting

2015-04-29 Thread Thomas Monjalon
> > > Disabled the doxygen option to sort member data so that functions and > > > struct memebers are listed in order of definition in the brief and > > > main sections. > > > > See for example: > > > > http://dpdk.org/doc/api/structlcore__config.html > > > > The first listed member is "unsi

[dpdk-dev] [PATCH] doc: link doxygen docs to source code

2015-04-29 Thread Thomas Monjalon
> > Enabled Doxygen option to add links to the source code in documented > > entities. > > > > Signed-off-by: John McNamara > > Thanks John, I think this will help. > Acked-by: Siobhan Butler Applied, thanks

[dpdk-dev] [PATCH] doc: fixed spellings and typos

2015-04-29 Thread Thomas Monjalon
> Fixed several typos and spelling errors in guide docs. > > Signed-off-by: John McNamara Applied, thanks

[dpdk-dev] [PATCH 0/2] doc: refactored fig and table nums into references

2015-04-29 Thread Thomas Monjalon
Hi John, 2015-04-24 14:11, John McNamara: > This patch adds automatic figure and table references to the docs. The > figure and table numbers in the generated Html and PDF docs can now be > automatically numbered based on section. > > Requires Sphinx >= 1.3. > > Advantages: > > * Figues/tables

[dpdk-dev] [PATCH 0/6] rte_sched: patches against 2.o

2015-04-29 Thread Stephen Hemminger
This is a subset of earlier patches for QoS (rte_sched) subsystem. Only changes were to fix whitespace and update against DPDK 2.0 Stephen Hemminger (6): rte_sched: make RED optional at runtime rte_sched: expand scheduler hierarchy for more VLAN's rte_sched: keep track of RED drops rte_sch

[dpdk-dev] [PATCH 1/6] rte_sched: make RED optional at runtime

2015-04-29 Thread Stephen Hemminger
From: Stephen Hemminger Want to be able to build with RTE_SCHED_RED enabled but allow disabling RED on a per-queue basis at runtime. RED is disabled unless min/max thresholds set. Signed-off-by: Stephen Hemmminger --- lib/librte_sched/rte_sched.c | 9 + 1 file changed, 9 insertions(+)

[dpdk-dev] [PATCH 2/6] rte_sched: expand scheduler hierarchy for more VLAN's

2015-04-29 Thread Stephen Hemminger
From: Stephen Hemminger The QoS subport is limited to 8 bits in original code. But customers demanded ability to support full number of VLAN's (4096) therefore use the full part of the tag field of mbuf. Resize the pipe as well to allow for more pipes in future and avoid expensive bitfield acces

[dpdk-dev] [PATCH 3/6] rte_sched: keep track of RED drops

2015-04-29 Thread Stephen Hemminger
From: Stephen Hemminger Add new statistic to keep track of drops due to RED. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 31 ++- lib/librte_sched/rte_sched.h | 6 ++ 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/lib/lib

[dpdk-dev] [PATCH 4/6] rte_sched: allow reading without clearing

2015-04-29 Thread Stephen Hemminger
The rte_sched statistics API should allow reading statistics without clearing. Make auto-clear optional. Signed-off-by: Stephen Hemminger --- app/test/test_sched.c| 4 ++-- examples/qos_sched/stats.c | 16 +++- lib/librte_sched/rte_sched.c | 44 ++--

[dpdk-dev] [PATCH 5/6] rte_sched: don't put tabs in log messages

2015-04-29 Thread Stephen Hemminger
From: Stephen Hemminger syslog does not like tabs in log messages; tab gets translated to #011 Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rt

[dpdk-dev] [PATCH 6/6] rte_sched: use correct log level

2015-04-29 Thread Stephen Hemminger
The setup messages should be at DEBUG level since they are not important for normal operation of system. The messages about problems should be at NOTICE or ERR level. Signed-off-by: Stephen Hemminger --- lib/librte_sched/rte_sched.c | 15 +-- 1 file changed, 9 insertions(+), 6 deleti

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Thomas Monjalon
2015-04-29 10:25, Keith Wiles: > -# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > -# Copyright(c) 2014 6WIND S.A. > +# Copyright(c) 2010-2015 Intel Corporation. All rights reserved. > +# Copyright(c) 2015 6WIND S.A. A correct update of copyright dates should be - 2014 +

[dpdk-dev] [PATCH v7 1/6] Move common functions in eal_thread.c

2015-04-29 Thread Ravi Kerur
> > I tried to run validate-abi.sh on BSD but ran into errors. If there is a > > way to check against BSD please let me know. > > > The ABI checker should work on BSD as far as I know, since it only relies > on > dwarf information in the output binary. What errors are you seeing? > dpdk-bsd:/home

[dpdk-dev] [PATCH v4 1/2] Simplify the ifdefs in rte.app.mk.

2015-04-29 Thread Wiles, Keith
On 4/29/15, 12:17 PM, "Thomas Monjalon" wrote: >2015-04-29 10:25, Keith Wiles: >> -# Copyright(c) 2010-2014 Intel Corporation. All rights reserved. >> -# Copyright(c) 2014 6WIND S.A. >> +# Copyright(c) 2010-2015 Intel Corporation. All rights reserved. >> +# Copyright(c) 2015 6WIND S.A.

[dpdk-dev] gmake test on freeBSD

2015-04-29 Thread Ravi Kerur
On Wed, Apr 29, 2015 at 1:29 AM, Bruce Richardson < bruce.richardson at intel.com> wrote: > On Tue, Apr 28, 2015 at 06:15:53PM -0700, Ravi Kerur wrote: > > DPDK team, > > > > Is there a automated tests to run on freeBSD similar to Linux (make > test). > > > > I ran "gmake test T=x86_64-native-bsda

[dpdk-dev] [PATCH] vhost: make vhost lockless enqueue configurable

2015-04-29 Thread Flavio Leitner
On Wed, 29 Apr 2015 13:56:58 +0200 Thomas Monjalon wrote: > 2015-04-29 13:38 GMT+02:00 Panu Matilainen : > > On 04/29/2015 02:29 PM, Huawei Xie wrote: > >> > >> vhost enabled vSwitch could have their own thread-safe vring > >> enqueue policy. > >> Add the RTE_LIBRTE_VHOST_LOCKLESS_ENQ macro for v

[dpdk-dev] Issues of MSIx interrupt enable with user space driver

2015-04-29 Thread James (Fei) Liu-SSI
Do you have kernel version in your build environment that has ? [James] The kernel version is 3.17.2 Do you have iommu enabled on your target machine? [James] Yes Did you program the MSI-X correctly? [James] We can issues several admin commands successfully with interrupt enabled , however. It

[dpdk-dev] Issues of MSIx interrupt enable with user space driver

2015-04-29 Thread James (Fei) Liu-SSI
Hi Danny, Thanks a lot for your promptly answer. I am going to check your patch soon. In the mean time, Have you guys ever try DPDK with PCIe storage device? Regards, James -Original Message- From: Zhou, Danny [mailto:danny.z...@intel.com] Sent: Tuesday, April 28, 2015 4:19 PM To:

[dpdk-dev] Issues of MSIx interrupt enable with user space driver

2015-04-29 Thread Zhou, Danny
DPDK is aimed to drive PCIe NIC device for high performance packet processing only. While we do have a Waikiki Beach project that integrates user space DPDK PMD and NVMe poll mode iSCSI target and NVMe backend together to improve performance of storage. > -Original Message- > From: James