On Wed, Jan 28, 2015 at 03:01:38PM +, Burakov, Anatoly wrote:
> Hi Dan
>
> Apologies for not looking at it earlier.
No problem, we are all quite busy :)
> > + if (map_addr != MAP_FAILED
> > + && memreg[1].offset && memreg[1].size) {
> > +
While VFIO doesn't allow us to map complete BARs with MSI-X tables,
it does allow us to map around them in PAGE_SIZE granularity. There
might be adapters that provide their registers in the same BAR
but on a different page. For example, Intel's NVME adapter, though
not a network adapter, provides o
v3 changes:
add sched_yield() in rte_ring to avoid long spin [15/16]
v2 changes:
add '-' support for EAL option '--lcores'
The patch series contain the enhancements of EAL and fixes for libraries
to run multi-pthreads(either EAL or non-EAL thread) per physical core.
Two major changes list as
The patch adds 'cpuset' into per-lcore configure 'lcore_config[]',
as the lcore no longer always 1:1 pinning with physical cpu.
The lcore now stands for a EAL thread rather than a logical cpu.
It doesn't change the default behavior of 1:1 mapping, but allows to
affinity the EAL thread to multiple
It supports one new eal long option '--lcores' for EAL thread cpuset assignment.
The format pattern:
--lcores='lcores[@cpus]<,lcores[@cpus]>'
lcores, cpus could be a single digit/range or a group.
'(' and ')' are necessary if it's a group.
If not supply '@cpus', the value of cpus uses the
It returns the socket_id if all cpus in the cpuset belongs
to the same NUMA node, otherwise it will return SOCKET_ID_ANY.
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal_lcore.c | 7 +
lib/librte_eal/common/eal_thread.h | 52 +
lib/librt
1. add two TLS *_socket_id* and *_cpuset*
2. add two external API rte_thread_set/get_affinity
3. add one internal API eal_thread_dump_affinity
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal_thread.c| 2 ++
lib/librte_eal/common/eal_thread.h| 14 ++
lib/li
The API works for both EAL thread and none EAL thread.
When calling rte_thread_set_affinity, the *_socket_id* and
*_cpuset* of calling thread will be updated if the thread
successful set the cpu affinity.
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/Makefile| 1 +
lib/lib
The rte_gettid() wraps the linux and freebsd syscall gettid().
It provides a persistent unique thread id for the calling thread.
It will save the unique id in TLS on the first time.
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal_thread.c | 9 +
lib/librte_eal/common/in
Some macro already been defined by freebsd 'sys/param.h'.
Signed-off-by: Cunming Liang
---
lib/librte_pmd_enic/enic.h| 1 +
lib/librte_pmd_enic/enic_compat.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/librte_pmd_enic/enic.h b/lib/librte_pmd_enic/enic.h
index c43417c..189c3
EAL threads use assigned cpuset to set core affinity during startup.
It keeps 1:1 mapping, if no '--lcores' option is used.
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal.c | 13 ---
lib/librte_eal/bsdapp/eal/eal_thread.c | 63 +-
lib/li
Add check for rte_socket_id(), avoid get unexpected return like (-1).
Signed-off-by: Cunming Liang
---
lib/librte_malloc/malloc_heap.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/lib/librte_malloc/malloc_heap.h b/lib/librte_malloc/malloc_heap.h
index b4aec45..a47136
For those non-EAL thread, *_lcore_id* is invalid and probably larger than
RTE_MAX_LCORE.
The patch adds the check and allows only EAL thread using EAL per thread log
level and log type.
Others shares the global log level.
Signed-off-by: Cunming Liang
---
lib/librte_eal/common/eal_common_log.c
For non-EAL thread, bypass per lcore cache, directly use ring pool.
It allows using rte_mempool in either EAL thread or any user pthread.
As in non-EAL thread, it directly rely on rte_ring and it's none preemptive.
It doesn't suggest to run multi-pthread/cpu which compete the rte_mempool.
It will g
ring debug stat won't take care non-EAL thread.
Signed-off-by: Cunming Liang
---
lib/librte_ring/rte_ring.h | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h
index 7cd5f2d..39bacdd 100644
--- a/lib/librte_ring/r
It does a gentle yield after spin for a while.
It reduces the wasting by spin when the preemption happens.
Signed-off-by: Cunming Liang
---
lib/librte_ring/rte_ring.h | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/lib/librte_ring/rte_ring.h b/lib/l
Allow to setup timers only for EAL (lcore) threads (__lcore_id < MAX_LCORE_ID).
E.g. ? dynamically created thread will be able to reset/stop timer for lcore
thread,
but it will be not allowed to setup timer for itself or another non-lcore
thread.
rte_timer_manage() for non-lcore thread would simp
For those none EAL thread, *_lcore_id* shall always be LCORE_ID_ANY.
The libraries using *_lcore_id* as index need to take care.
*_socket_id* always be SOCKET_ID_ANY unitl the thread changes the affinity
by rte_thread_set_affinity()
Signed-off-by: Cunming Liang
---
lib/librte_eal/bsdapp/eal/eal_
In non-EAL thread, lcore_id alrways be LCORE_ID_ANY.
It cann't be used as unique id for recursive spinlock.
Then use rte_gettid() to replace it.
Signed-off-by: Cunming Liang
---
lib/librte_eal/common/include/generic/rte_spinlock.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
Enable SRIOV switch in i40e driver. With this patch set, SRIOV switch
can be done on Fortville NICs.
Jingjing Wu (2):
i40e: fix the bug when configuring vsi
i40e: enable internal switch of pf
lib/librte_pmd_i40e/i40e_ethdev.c | 38 +-
1 file changed, 37 in
In i40e_vsi_config_tc_queue_mapping, should add a flag to indicate
another valid setting by OR operation, but not set this flag to
valid_sections, otherwise it will overwrite the flags set before.
Signed-off-by: Jingjing Wu
---
lib/librte_pmd_i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertio
This patch enables PF's internal switch by setting ALLOWLOOPBACK
flag when VEB is created. With this patch, traffic from PF can be
switched on the VEB.
Signed-off-by: Jingjing Wu
---
lib/librte_pmd_i40e/i40e_ethdev.c | 36
1 file changed, 36 insertions(+)
di
> -Original Message-
> From: EDMISON, Kelvin (Kelvin) [mailto:kelvin.edmison at alcatel-lucent.com]
> Sent: Thursday, January 29, 2015 5:48 AM
> To: Wang, Zhihong; Stephen Hemminger; Neil Horman
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization
>
>
> O
On 1/29/2015 9:42 AM, Jingjing Wu wrote:
> This patch enables PF's internal switch by setting ALLOWLOOPBACK
> flag when VEB is created. With this patch, traffic from PF can be
> switched on the VEB.
>
> Signed-off-by: Jingjing Wu
> ---
> lib/librte_pmd_i40e/i40e_ethdev.c | 36
On 1/28/2015 5:51 PM, Danny Zhou wrote:
Commit log is better for others to review the patch I think, it's
helpful for others to understand your patch.
> Signed-off-by: Danny Zhou
> ---
> lib/librte_ether/rte_ethdev.c | 45 ++
> lib/librte_ether/rte_ethdev.h | 57
This patch set optimizes memcpy for DPDK for both SSE and AVX platforms.
It also extends memcpy test coverage with unaligned cases and more test points.
Optimization techniques are summarized below:
1. Utilize full cache bandwidth
2. Enforce aligned stores
3. Apply load address alignment based
Main code changes:
1. Added more typical data points for a thorough performance test
2. Added unaligned test cases since it's common in DPDK usage
Signed-off-by: Zhihong Wang
---
app/test/test_memcpy_perf.c | 220 +++-
1 file changed, 138 insertions(+),
VTA is for debugging only, it increases compile time and binary size,
especially when there're a lot of inlines.
So disable it since memcpy test contains a lot of inline calls.
Signed-off-by: Zhihong Wang
---
app/test/Makefile | 6 ++
1 file changed, 6 insertions(+)
diff --git a/app/test/M
Removed unnecessary test cases for base move functions since the function
"func_test" covers them all.
Signed-off-by: Zhihong Wang
---
app/test/test_memcpy.c | 52 +-
1 file changed, 1 insertion(+), 51 deletions(-)
diff --git a/app/test/test_memc
Main code changes:
1. Differentiate architectural features based on CPU flags
a. Implement separated move functions for SSE/AVX/AVX2 to make full
utilization of cache bandwidth
b. Implement separated copy flow specifically optimized for target
architecture
2. Rewrite the memcpy functi
Currently only 6 bits which are stored in ol_flags are used to indicate
the packet types. This is not enough, as some NIC hardware can recognize
quite a lot of packet types, e.g i40e hardware can recognize more than 150
packet types. Hiding those packet types hides hardware offload capabilities
whi
As there are only 6 bit flags in ol_flags for indicating packet types,
which is not enough to describe all the possible packet types hardware
can recognize. For example, i40e hardware can recognize more than 150
packet types. Unified packet type is composed of tunnel type, L3 type,
L4 type and inne
To unify packet types among all PMDs, bit masks of packet type for
ol_flags are replaced by unified packet type.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_e1000/igb_rxtx.c | 95 ++---
1 file changed, 80 insertions(+), 15 deletions(-)
diff --git a/lib/libr
To unify packet types among all PMDs, bit masks of packet type for
ol_flags are replaced by unified packet type.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 141 +-
1 file changed, 107 insertions(+), 34 deletions(-)
diff --git a/lib/lib
To unify packet types among all PMDs, bit masks of packet type for
ol_flags are replaced by unified packet type for Vector PMD.
Signed-off-by: Cunming Liang
Signed-off-by: Helin Zhang
---
lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 39 +++
1 file changed, 21 insertio
To unify packet types among all PMDs, bit masks of packet type for
ol_flags are replaced by unified packet type.
Signed-off-by: Helin Zhang
Signed-off-by: Jijiang Liu
---
lib/librte_pmd_i40e/i40e_rxtx.c | 778 ++--
1 file changed, 504 insertions(+), 274 delet
To unify packet types among all PMDs, bit masks of packet type for
ol_flags are replaced by unified packet type.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_bond/rte_eth_bond_pmd.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd
To unify packet types among all PMDs, bit masks of packet type for
ol_flags are replaced by unified packet type.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_enic/enic_main.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/lib/librte_pmd_enic/enic_main.c b/lib
To unify packet types among all PMDs, bit masks of packet type for
ol_flags are replaced by unified packet type.
Signed-off-by: Helin Zhang
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
b/l
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
app/test-pipeline/pipeline_hash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/te
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
app/test-pmd/csumonly.c | 6 +++---
app/test-pmd/rxonly.c | 9 +++--
2 files changed, 6 insertions(+), 9 d
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
app/test/packet_burst_generator.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
examples/ip_fragmentation/main.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/exam
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
examples/l3fwd-acl/main.c | 19 ++-
1 file changed, 6 insertions(+), 13 deletions(-)
diff --git
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
examples/ip_reassembly/main.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/example
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
examples/l3fwd-power/main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/examples/l3
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
lib/librte_mbuf/rte_mbuf.c | 6 --
lib/librte_mbuf/rte_mbuf.h | 10 ++
2 files changed, 2 insertion
To unify packet types among all PMDs, bit masks and relevant macros
of packet type for ol_flags are replaced by unified packet type and
relevant macros.
Signed-off-by: Helin Zhang
---
examples/l3fwd/main.c | 64 +--
1 file changed, 37 insertions(+)
On 1/28/2015 5:52 PM, Danny Zhou wrote:
> Signed-off-by: Danny Zhou
> ---
> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 371
>
> lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 9 +
> 2 files changed, 380 insertions(+)
>
> diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c
Basic Information
Patch nameDPDK memcpy optimization
Brief description about test purposeVerify memory copy and memory
copy performance cases on variety OS
Test Flag Tested-by
Tester name jingguox.fu at intel.com
Test Tool Chain i
Thanks for review Steve. Comments inline.
> -Original Message-
> From: Liang, Cunming
> Sent: Thursday, January 29, 2015 2:10 AM
> To: Zhou, Danny; dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v1 4/5] eal: add per rx queue interrupt
> handling based on VFIO
>
>
>
> > -Original
> -Original Message-
> From: Liang, Cunming
> Sent: Thursday, January 29, 2015 2:34 AM
> To: Zhou, Danny; dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v1 5/5] L3fwd-power: enable one-shot rx
> interrupt and polling/interrupt mode switch
>
>
>
> > -Original Message-
> > Fro
Hi, Michael
> -Original Message-
> From: Qiu, Michael
> Sent: Thursday, January 29, 2015 9:56 AM
> To: Wu, Jingjing; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] i40e: enable internal switch of pf
>
> On 1/29/2015 9:42 AM, Jingjing Wu wrote:
> > This patch enables PF's internal s
On 1/28/2015 5:52 PM, Danny Zhou wrote:
> Signed-off-by: Danny Zhou
> Signed-off-by: Yong Liu
> ---
[...]
> +static void
> +eal_intr_process_rx_interrupts(uint8_t port_id, struct epoll_event *events,
> int nfds)
> +{
> + int n, bytes_read;
> + union rte_intr_read_buffer buf;
> + st
> -Original Message-
> From: Qiu, Michael
> Sent: Thursday, January 29, 2015 1:07 PM
> To: Zhou, Danny; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 4/5] eal: add per rx queue interrupt
> handling based on VFIO
>
> On 1/28/2015 5:52 PM, Danny Zhou wrote:
> > Signed-off-by: Danny
The patch set uses new filter_ctrl API to replace old flow director filter APIs.
It uses new functions and structure to replace old ones in ixgbe driver,
updates commands to replace old ones in testpmd, and removes the old APIs
Jingjing Wu (15):
ixgbe: migrate flow director filter operations (ad
This patch changes the add/delete/update operations to be implemented through
filter_ctrl API and
RTE_ETH_FILTER_ADD/RTE_ETH_FILTER_DELETE/RTE_ETH_FILTER_UPDATE ops.
It also removes the callback functions:
- ixgbe_eth_dev_ops.fdir_add_signature_filter
- ixgbe_eth_dev_ops.fdir_update_signature_fi
This patch adds RTE_ETH_FLOW_TYPE_RAW and RTE_ETH_RAW_PAYLOAD to support the
flexible payload is started from the beginning of the packet.
Signed-off-by: Jingjing Wu
---
lib/librte_ether/rte_eth_ctrl.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/librte_ether/rte_eth_ctrl.h b/lib/li
This patch implement the flexpayload configuration of flow director filter.
Signed-off-by: Jingjing Wu
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 1 +
lib/librte_pmd_ixgbe/ixgbe_fdir.c | 114 +---
2 files changed, 108 insertions(+), 7 deletions(-)
diff --git a
This patch removes the flexbytes_offset setting, because the flexible payload
setting is done by flex_conf instead of flexbytes_offset.
Signed-off-by: Jingjing Wu
---
app/test/test_link_bonding.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test/test_link_bonding.c b/app/test/test_link
This patch removes the flexbytes_offset setting, because the flexible payload
setting is done by flex_conf instead of flexbytes_offset.
Signed-off-by: Jingjing Wu
---
app/test-pmd/parameters.c | 16
app/test-pmd/testpmd.c| 1 -
2 files changed, 17 deletions(-)
diff --git a
This patch defines structure rte_eth_fdir_masks.
It extends rte_fdir_conf and rte_eth_fdir_info to contain mask's configuration.
Signed-off-by: Jingjing Wu
---
lib/librte_ether/rte_eth_ctrl.h | 13 +
lib/librte_ether/rte_ethdev.h | 1 +
2 files changed, 14 insertions(+)
diff --gi
This patch implement the mask configuration of flow director filter,
by using the mask defined in rte_fdir_conf instead of callback function
fdir_set_masks.
Signed-off-by: Jingjing Wu
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 -
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 16 +-
lib/librte_pmd_ix
This patch removes the flexbytes_offset from rte_fdir_conf, because
the flexible payload setting is done by flex_conf instead of flexbytes_offset.
Signed-off-by: Jingjing Wu
---
lib/librte_ether/rte_ethdev.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib
This patch changes the get info operation to be implemented through
filter_ctrl API and RTE_ETH_FILTER_INFO/RTE_ETH_FILTER_STATS ops.
Signed-off-by: Jingjing Wu
---
lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 1 -
lib/librte_pmd_ixgbe/ixgbe_ethdev.h | 3 --
lib/librte_pmd_ixgbe/ixgbe_fdir.c | 94 +
This patch implement RTE_ETH_FILTER_FLUSH operation to delete all
flow director filters in ixgbe driver.
Signed-off-by: Jingjing Wu
---
lib/librte_pmd_ixgbe/ixgbe_fdir.c | 26 ++
1 file changed, 26 insertions(+)
diff --git a/lib/librte_pmd_ixgbe/ixgbe_fdir.c
b/lib/librt
update the function to print information includes:
- capability
- mask
- flex configuration
Signed-off-by: Jingjing Wu
---
app/test-pmd/config.c | 77 ++-
1 file changed, 45 insertions(+), 32 deletions(-)
diff --git a/app/test-pmd/config.c b/ap
this patch sets the default value of flow director's mask.
Signed-off-by: Jingjing Wu
---
app/test-pmd/testpmd.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 2773c10..8b41fe5 100644
--- a/app/test-pmd/testpmd.c
+++ b/app
Following commands of flow director filter are removed:
- add_signature_filter
- upd_signature_filter
- rm_signature_filter
- add_perfect_filter
- upd_perfect_filter
- rm_perfect_filter
- set_masks_filter
- set_ipv6_masks_filter
Signed-off-by: Jingjing Wu
---
app/test-pmd/cmdline
Add new command to set flow director's mask:
- flow_director_mask
Update arguments of commands:
- flow_director_filter
- flow_director_flex_mask
- flow_director_flex_payload
Signed-off-by: Jingjing Wu
---
app/test-pmd/cmdline.c | 182 -
1 f
Following commands of flow director filter are removed:
- add_signature_filter
- upd_signature_filter
- rm_signature_filter
- add_perfect_filter
- upd_perfect_filter
- rm_perfect_filter
- set_masks_filter
- set_ipv6_masks_filter
New command is added to set flow director's mask:
-
> -Original Message-
> From: Qiu, Michael
> Sent: Thursday, January 29, 2015 11:40 AM
> To: Zhou, Danny; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 2/5] ixgbe: enable rx queue interrupts for
> both PF and VF
>
> On 1/28/2015 5:52 PM, Danny Zhou wrote:
> > Signed-off-by: Danny Z
On 1/29/2015 12:57 PM, Wu, Jingjing wrote:
> Hi, Michael
>
>> -Original Message-
>> From: Qiu, Michael
>> Sent: Thursday, January 29, 2015 9:56 AM
>> To: Wu, Jingjing; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 2/2] i40e: enable internal switch of pf
>>
>> On 1/29/2015 9:42 AM, Jingj
Basic Information
Patch nameDPDK memcpy optimization v2
Brief description about test purposeVerify memory copy and memory
copy performance cases on variety OS
Test Flag Tested-by
Tester name jingguox.fu at intel.com
Test Tool Chai
Hi, Michael
> -Original Message-
> From: Qiu, Michael
> Sent: Thursday, January 29, 2015 2:06 PM
> To: Wu, Jingjing; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] i40e: enable internal switch of pf
>
> On 1/29/2015 12:57 PM, Wu, Jingjing wrote:
> > Hi, Michael
> >
> >> -Origin
On 1/29/2015 2:27 PM, Wu, Jingjing wrote:
> Hi, Michael
>
>> -Original Message-
>> From: Qiu, Michael
>> Sent: Thursday, January 29, 2015 2:06 PM
>> To: Wu, Jingjing; dev at dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 2/2] i40e: enable internal switch of pf
>>
>> On 1/29/2015 12:57 PM, Wu, J
For clarity make the setup of PCI resources for Linux into a function rather
than block of code #ifdef'd in middle of dev_init.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 76 ---
1 file changed, 43
Virtio has link state interrupt which can be used.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 78 +++
lib/librte_pmd_virtio/virtio_pci.c| 22 ++
lib/librte_pmd_virtio/virtio_pci.h|
Starting driver with link down should be ok, it is with every
other driver. So just allow it.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/librte_pmd_virti
It is helpful to allow device drivers that don't support hardware
VLAN stripping to emulate this in software. This allows application
to be device independent.
Avoid discarding shared mbufs. Make a copy in rte_vlan_insert() of any
packet to be tagged that has a reference count > 1.
Signed-off-by:
The DPDK driver only has to deal with the case of running on PCI
and with SMP. In this case, the code can use the weaker barriers
instead of using hard (fence) barriers. This will help performance.
The rationale is explained in Linux kernel virtio_ring.h.
To make it clearer that this is a virtio t
Implement VLAN stripping in software. This allows application
to be device independent.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 3 +++
lib/librte_pmd_virtio/virtio_ethdev.c | 2 ++
lib/librte_pmd_virtio/virtio_pci.h| 1
Cleanup virtio code by eliminating unnecessary nesting of
virtio hardware structure inside adapter structure.
Also allows removing unneeded macro, making code clearer.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 43 ---
Change order of initialiazation to match Linux kernel.
Don't blow away control queue by doing reset when stopped.
Calling dev_stop then dev_start would not work.
Dev_stop was calling virtio reset and that would clear all queues
and clear all feature negotiation.
Resolved by only doing reset on dev
This is the patch set for single virtio implementation.
Why we need single virtio?
As we know currently there are at least 3 virtio PMD driver implementations:
A) lib/librte_pmd_virtio(refer as virtio A);
B) virtio_net_pmd by 6wind(refer as virtio B);
C) virtio by Broc
Better to check at compile time than fail at runtime.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
b/lib/librte_pmd_virti
Since vq_alignment is constant (always 4K), it does not
need to be part of the vring struct.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 1 -
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
lib/librte_pmd_virtio/virtqueue.h | 3
If allocation fails, don't want to leave virtio device stuck
in middle of initialization sequence.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/li
Virtio supports vlan filtering.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
b/lib/librte_pmd
Need to have do special things to set default mac address.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 5 +
lib/librte_pmd_virtio/virtio_ethdev.c | 24
2 files changed, 29 insertions(+)
diff --git a/
Make vtpci_get_status a local function as it is used in one file.
igned-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_pci.c | 4 +++-
lib/librte_pmd_virtio/virtio_pci.h | 2 --
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librte
This makes virtio driver work like ixgbe. Transmit buffers are
held until a transmit threshold is reached. The previous behavior
was to hold mbuf's until the ring entry was reused which caused
more memory usage than needed.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
li
Virtio support multiple MAC addresses.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 94 ++-
lib/librte_pmd_virtio/virtio_ethdev.h | 3 +-
lib/librte_pmd_virtio/virtqueue.h | 34 -
3
It should use vring descriptor index instead of used_ring index to index
vq_descx.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
b/lib/librte_pmd_virtio/virtio_rxtx
Need swap the data from cpu to BE(big endian) for vlan-type.
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ether.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ether.h b/lib/librte_ether/rte_ether.h
index 74f71c2..0797908 100644
--- a/li
Make virtio not require UIO for some security reasons, this is to match 6Wind's
virtio-net-pmd.
Signed-off-by: Changchun Ouyang
---
config/common_linuxapp | 2 +
lib/librte_eal/common/include/rte_pci.h | 4 ++
lib/librte_eal/linuxapp/eal/eal_pci.c | 5 +-
lib/librte_pmd_vi
Check if it has already been vlan-tagged packet, if true, avoid inserting a
duplicated vlan tag into it.
This is a possible case when guest has the capability of inserting vlan tag.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 45 -
1 f
Support turn on/off RX VLAN strip on host, this let guest get the chance of
using its software VALN strip functionality.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b
To keep the consistent logic with normal Rx path, the mergeable
Rx path also needs software vlan strip/decap if it is enabled.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
b/li
vHOST zero copy need get vring descriptor and its buffer address to
set the DMA address of HW ring, it is done in new_device when ioctl set_backend
is called. This requies virtio_dev_rxtx_start is called before
vtpci_reinit_complete,
which makes sure the vring descriptro and its buffer is ready be
1 - 100 of 176 matches
Mail list logo
