On Wed, Jan 28, 2015 at 03:01:38PM +0000, Burakov, Anatoly wrote: > Hi Dan > > Apologies for not looking at it earlier.
No problem, we are all quite busy :) > > + if (map_addr != MAP_FAILED > > + && memreg[1].offset && memreg[1].size) { > > + uint8_t *second_addr = > > + ((uint8_t *)bar_addr + > > memreg[1].offset); > > Nitpicking, but probably better to use void* and RTE_PTR_ADD here. Nitpicking very justified. New patch coming your way. -- Dan Aloni