> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, January 27, 2015 2:29 AM
> To: Wang, Zhihong; Richardson, Bruce; Marc Sune
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization
>
> Hi Zhihong,
>
> > -Original Message-
> > From: de
This is the patch set for single virtio implementation.
Why we need single virtio?
As we know currently there are at least 3 virtio PMD driver implementations:
A) lib/librte_pmd_virtio(refer as virtio A);
B) virtio_net_pmd by 6wind(refer as virtio B);
C) virtio by Broc
For clarity make the setup of PCI resources for Linux into a function rather
than block of code #ifdef'd in middle of dev_init.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 76 ---
1 file changed, 43
The DPDK driver only has to deal with the case of running on PCI
and with SMP. In this case, the code can use the weaker barriers
instead of using hard (fence) barriers. This will help performance.
The rationale is explained in Linux kernel virtio_ring.h.
To make it clearer that this is a virtio t
It is helpful to allow device drivers that don't support hardware
VLAN stripping to emulate this in software. This allows application
to be device independent.
Avoid discarding shared mbufs. Make a copy in rte_vlan_insert() of any
packet to be tagged that has a reference count > 1.
Signed-off-by:
Change order of initialiazation to match Linux kernel.
Don't blow away control queue by doing reset when stopped.
Calling dev_stop then dev_start would not work.
Dev_stop was calling virtio reset and that would clear all queues
and clear all feature negotiation.
Resolved by only doing reset on dev
If allocation fails, don't want to leave virtio device stuck
in middle of initialization sequence.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/li
Implement VLAN stripping in software. This allows application
to be device independent.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 3 +++
lib/librte_pmd_virtio/virtio_ethdev.c | 2 ++
lib/librte_pmd_virtio/virtio_pci.h| 1
Starting driver with link down should be ok, it is with every
other driver. So just allow it.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lib/librte_pmd_virti
Virtio has link state interrupt which can be used.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 78 +++
lib/librte_pmd_virtio/virtio_pci.c| 22 ++
lib/librte_pmd_virtio/virtio_pci.h|
Cleanup virtio code by eliminating unnecessary nesting of
virtio hardware structure inside adapter structure.
Also allows removing unneeded macro, making code clearer.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 43 ---
Virtio supports vlan filtering.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 31 +--
1 file changed, 29 insertions(+), 2 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
b/lib/librte_pmd
Make vtpci_get_status a local function as it is used in one file.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_pci.c | 4 +++-
lib/librte_pmd_virtio/virtio_pci.h | 2 --
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/librt
This makes virtio driver work like ixgbe. Transmit buffers are
held until a transmit threshold is reached. The previous behavior
was to hold mbuf's until the ring entry was reused which caused
more memory usage than needed.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
li
vHOST zero copy need get vring descriptor and its buffer address to
set the DMA address of HW ring, it is done in new_device when ioctl set_backend
is called. This requies virtio_dev_rxtx_start is called before
vtpci_reinit_complete,
which makes sure the vring descriptro and its buffer is ready be
Since vq_alignment is constant (always 4K), it does not
need to be part of the vring struct.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 1 -
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
lib/librte_pmd_virtio/virtqueue.h | 3
Virtio support multiple MAC addresses.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 94 ++-
lib/librte_pmd_virtio/virtio_ethdev.h | 3 +-
lib/librte_pmd_virtio/virtqueue.h | 34 -
3
Check if it has already been vlan-tagged packet, if true, avoid inserting a
duplicated vlan tag into it.
This is a possible case when guest has the capability of inserting vlan tag.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 14 --
1 file changed, 12 insertions(+),
Support turn on/off RX VLAN strip on host, this let guest get the chance of
using its software VALN strip functionality.
Signed-off-by: Changchun Ouyang
---
examples/vhost/main.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/examples/vhost/main.c b
Remove those hotspots which is unnecessary when early returning occurs;
Also reverse one likely to unlikely to let compiler has better decision;
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 33 +++--
1 file changed, 23 insertions(+), 10 de
Need to have do special things to set default mac address.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ethdev.h | 5 +
lib/librte_pmd_virtio/virtio_ethdev.c | 24
2 files changed, 29 insertions(+)
diff --git a/
It should use vring descriptor index instead of used_ring index to index
vq_descx.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
b/lib/librte_pmd_virtio/virtio_rxtx
Better to check at compile time than fail at runtime.
Signed-off-by: Stephen Hemminger
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_ethdev.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
b/lib/librte_pmd_virti
Need swap the data from cpu to BE(big endian) for vlan-type.
Signed-off-by: Changchun Ouyang
---
lib/librte_ether/rte_ether.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ether.h b/lib/librte_ether/rte_ether.h
index 74f71c2..0797908 100644
--- a/li
Make virtio not require UIO for some security reasons, this is to match 6Wind's
virtio-net-pmd.
Signed-off-by: Changchun Ouyang
---
config/common_linuxapp | 2 +
lib/librte_eal/common/include/rte_pci.h | 4 ++
lib/librte_eal/linuxapp/eal/eal_pci.c | 5 +-
lib/librte_pmd_vi
To keep the consistent logic with normal Rx path, the mergeable
Rx path also needs software vlan strip/decap if it is enabled.
Signed-off-by: Changchun Ouyang
---
lib/librte_pmd_virtio/virtio_rxtx.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/librte_pmd_virtio/virtio_rxtx.c
b/li
65 bytes frame may degrade performace a lot.Thats related to DMA and cache.
When NIC dma packets to memory, NIC has to do read modify write if DMA size is
partial cache line.So for 65 bytes, the first 64 bytes are ok. The next 1 byte
NIC has to read the whole cache line, change one byte and updat
On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote:
> This patch series adds a dynamic port hotplug framework to DPDK.
> With the patches, DPDK apps can attach or detach ports at runtime.
>
> The basic concept of the port hotplug is like followings.
> - DPDK apps must have responsibility to manage ports.
>
On 1/26/15, 8:06 PM, "Matthew Hall" wrote:
>On Tue, Jan 27, 2015 at 10:35:40AM +0800, Ouyang Changchun wrote:
>> This is the patch set for single virtio implementation.
>>
>> Why we need single virtio?
>>
>> As we know currently there are at least 3 virtio PMD dri
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Sunday, January 25, 2015 4:05 PM
> To: Liang, Cunming
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1 09/15] malloc: fix the issue of
> SOCKET_ID_ANY
>
> On Thu, 22 Jan 2015 16:16:32
On 2015/01/27 12:00, Qiu, Michael wrote:
> On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote:
>> This patch series adds a dynamic port hotplug framework to DPDK.
>> With the patches, DPDK apps can attach or detach ports at runtime.
>>
>> The basic concept of the port hotplug is like followings.
>> - DPDK
> -Original Message-
> From: Wodkowski, PawelX
> Sent: Monday, January 26, 2015 10:43 PM
> To: Wang, Zhihong; dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 4/4] lib/librte_eal: Optimized memcpy in
> arch/x86/rte_memcpy.h for both SSE and AVX platforms
>
> Hi,
>
> I must say: greate w
Hi Vithal
Exactly! Some types of NIC (e.g. i40e) support it.
Regards,
Helin
> -Original Message-
> From: Vithal S Mohare [mailto:vmohare at arubanetworks.com]
> Sent: Tuesday, January 27, 2015 12:31 PM
> To: Zhang, Helin
> Subject: RE: [dpdk-dev] [PATCH 5/7] ethdev: unification of flow t
Test by: min.cao
Patch name: [dpdk-dev] [PATCH 0/6] Support NVGRE on i40e
Test Flag: Tested-by
Tester name:min.cao at intel.com
Result summary: total 2 cases, 2 passed, 0 failed
Test Case 1:
Name: nvgre fi
On 1/27/2015 1:02 PM, Tetsuya Mukawa wrote:
> On 2015/01/27 12:00, Qiu, Michael wrote:
>> On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote:
>>> This patch series adds a dynamic port hotplug framework to DPDK.
>>> With the patches, DPDK apps can attach or detach ports at runtime.
>>>
>>> The basic concept
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun
> Sent: Tuesday, January 27, 2015 10:36 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2 02/24] virtio: Use weaker barriers
>
> The DPDK driver only has to deal with the case of runnin
Hey Luke,
Thanks for the excellent questions!
The following script will launch the memcpy test in DPDK:
echo -e 'memcpy_autotest\nmemcpy_perf_autotest\nquit\n' |
./x86_64-native-linuxapp-gcc/app/test -c 4 -n 4 -- -i
Thanks for sharing the object code, I think it?s the Sandy Bridge version
thou
On 2015/01/27 14:50, Qiu, Michael wrote:
> On 1/27/2015 1:02 PM, Tetsuya Mukawa wrote:
>> On 2015/01/27 12:00, Qiu, Michael wrote:
>>> On 1/19/2015 6:42 PM, Tetsuya Mukawa wrote:
This patch series adds a dynamic port hotplug framework to DPDK.
With the patches, DPDK apps can attach or det
Hi Pablo,
On Mon, Jan 26, 2015 at 5:22 PM, De Lara Guarch, Pablo <
pablo.de.lara.guarch at intel.com> wrote:
> Hi Alexander,
>
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alexander Belyakov
> > Sent: Monday, January 26, 2015 10:18 AM
> > To: dev at d
Hello,
On Mon, Jan 26, 2015 at 8:08 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:
> On Mon, 26 Jan 2015 13:17:48 +0300
> Alexander Belyakov wrote:
>
> > Hello,
> >
> > recently I have found a case of significant performance degradation for
> our
> > application (built on top of D
Hi,all
I use vhost-user to send data to VM at first it cant work well but after many
hours VM can not receive data but can send data.
(gdb)p avail_idx
$4 = 2668
(gdb)p free_entries
$5 = 0
(gdb)l
/* check that we have enough buffers */
if (unlikely(count > free_entries))
>---if (likely(nb_enqueued)) {
>--->---virtio_wmb();
>--->---if (unlikely(virtqueue_kick_prepare(rxvq))) {
>--->--->---virtqueue_notify(rxvq);
>--->--->---PMD_RX_LOG(DEBUG, "Notified\n");
>--->---}
>---}
>---vq_update_avail_idx(rxvq);
Tw
Hello,
On Tue, Jan 27, 2015 at 5:49 AM, ??? wrote:
> 65 bytes frame may degrade performace a lot.Thats related to DMA and cache.
> When NIC dma packets to memory, NIC has to do read modify write if DMA
> size is partial cache line.So for 65 bytes, the first 64 bytes are ok. The
> next 1 byte NIC
Hi Stephen,
Although it is original code logic,
But we can move vq_update_avail_idx(rxvq) into if block to resolve it.
What do you think of it?
Thanks
Changchun
-Original Message-
From: Xie, Huawei
Sent: Tuesday, January 27, 2015 3:57 PM
To: Ouyang, Changchun; dev at dpdk.org
Cc: Stephe
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of EDMISON, Kelvin
> (Kelvin)
> Sent: Friday, January 23, 2015 2:22 AM
> To: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization
>
>
>
> On 2015-01-21, 3:54 PM, "Neil Horman" wrote:
Hi Konstantin,
On 01/26/2015 03:15 PM, Ananyev, Konstantin wrote:
Another thing - IPIP seems to work ok by HW.
There is something wrong on our (PMD/test-pmd) side.
I think at least we have to remove the following check:
if (!l2_len) {
PMD_DRV_LOG(DEBUG, "L
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun
> Sent: Tuesday, January 27, 2015 10:36 AM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH v2 04/24] virtio: Add support for Link State
> interrupt
>
> Virtio has link state interrupt whic
Hi,
2015-01-22 15:05, Cian Ferriter:
> Removes the dependency that this memzone reserve has on the
> socket currently running on. Following the socket of the master
> core will yield more predictable results when calling this
> function after initialisation.
You don't describe what is the problem
On Tue, Jan 27, 2015 at 03:42:00AM +, Wiles, Keith wrote:
> There is an app note on how to get DPDK working in VirtualBox, it is a bit
> bumpy on getting it work.
> Here is the link:
> http://plvision.eu/blog/deploying-intel-dpdk-in-oracle-virtualbox/
>
> I have not tried it, but it was sugge
> I recall our original code is virtio_wmb().
> Use store fence to ensure all updates to entries before updating the index.
> Why do we need virtio_rmb() here and add virtio_wmb after
> vq_update_avail_idx()?
Store fence is unnecessary, Intel CPU's are cache coherent, please read
the virtio Lin
On Tue, 27 Jan 2015 09:04:07 +
"Xie, Huawei" wrote:
> > -Original Message-
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ouyang Changchun
> > Sent: Tuesday, January 27, 2015 10:36 AM
> > To: dev at dpdk.org
> > Subject: [dpdk-dev] [PATCH v2 04/24] virtio: Add support for
Hi Michael,
I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
reviewing this patch. However I have few comments.
2015-01-15 22:45, Michael Qiu:
> - ixgbe_dev_rxtx_start(dev);
> + err = ixgbe_dev_rxtx_start(dev);
> + if (err < 0) {
> + PMD_INIT_LOG(ERR, "U
On Mon, 26 Jan 2015 19:06:12 -0800
Matthew Hall wrote:
> Thank you so much for this, using virtio drivers in DPDK has been messy and
> unpleasant in the past, and you clearly wrote a lot of nice new code to help
> improve it all.
>
> Previously I'd reported a bug, where all RTE virtio drivers
Hi Stephen,
2015-01-22 22:23, stephen at networkplumber.org:
> From: Stephen Hemminger
>
> The ixgbe driver was including CRC in the transmit packet byte
> count, but not for packets received. This was notice when forwarding and
> the number of bytes received was greater than the number of bytes
On Tue, Jan 27, 2015 at 10:51 AM, Alexander Belyakov
wrote:
>
> Hi Pablo,
>
> On Mon, Jan 26, 2015 at 5:22 PM, De Lara Guarch, Pablo <
> pablo.de.lara.guarch at intel.com> wrote:
>
>> Hi Alexander,
>>
>> > -Original Message-
>> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ale
Hi Michal,
2015-01-23 11:43, Michal Jastrzebski:
> This patch modifies testpmd behavior when setting:
> rx_vlan add all vf_port (enabling all vlanids
> to be passed thru rx filter on VF).
> Rx_vlan_all_filter_set() function,
> checks if the next vlanid can be enabled by the driver.
> Number of vla
> > This patch add Support for ICC 15.
> >
> > ICC 15 changed inline-max-size and inline-max-total-size default values, so
> > for ICC 15 flags -no-inline-max-size -no-inline-max-total-size must be
> > added.
> >
> > additionally disable compile error for:
> > 13368 - loop was not vectorized wit
> -Original Message-
> From: Wang, Zhihong
> Sent: Tuesday, January 27, 2015 1:42 AM
> To: Ananyev, Konstantin; Richardson, Bruce; Marc Sune
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization
>
>
>
> > -Original Message-
> > From: Ananyev, Kons
On Tue, 27 Jan 2015 11:11:39 +0100
Thomas Monjalon wrote:
> Hi Stephen,
>
> 2015-01-22 22:23, stephen at networkplumber.org:
> > From: Stephen Hemminger
> >
> > The ixgbe driver was including CRC in the transmit packet byte
> > count, but not for packets received. This was notice when forwardi
> When using core list argument to define which core to enable (ie -l) the
> core_num field of the rte configuration is not updated the same way as using
> coremask. This causes rte_lcore_num() to yield different value from the one
> using coremask.
>
> Signed-off-by: Remi Pommarel
Good catch, i
> Ethernet device's data should contain the virtual device name for pcap port.
> This name is correctly set by rte_eth_dev_allocate() at initialization time,
> but it is directly lost.
>
> Signed-off-by: Remi Pommarel
Fixes: 83b41136934d ("ethdev: add unique name to devices")
Acked-by: Thomas Mo
> rte_power_freq_min function did not include "extern" keyword,
> causing linking errors.
>
> Signed-off-by: Pablo de Lara
> Reported-by: Ildar Mustafin
Fixes: 445c6528b55f ("power: common interface for guest and host")
Acked-by: Thomas Monjalon
Applied
Thanks
--
Thomas
> Signed-off-by: Marc Sune
> --- a/lib/librte_ip_frag/rte_ip_frag.h
> +++ b/lib/librte_ip_frag/rte_ip_frag.h
> +#ifdef __cplusplus
> +extern "C" {
> +#endif
Fixes: 601e279df074 ("move fragmentation/reassembly headers into a library")
Acked-by: Thomas Monjalon
Applied
It seems that the same ki
> In some cases application may want to have additional rules
> for clean. This can be handled by allowing the double colon
> form of rule.
>
> https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html
>
> Single colon and double colon rules for same target causes
> an error.
>
>
On 1/27/2015 6:02 PM, Thomas Monjalon wrote:
> Hi Michael,
>
> I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
> reviewing this patch. However I have few comments.
Thanks Thomas,
I will send v2 with your comments.
But who maintains ixgbe? I would like add him(or she) to the c
2015-01-21 14:08, David Marchand:
> Hello Stephen,
>
> > From: Stephen Hemminger
> >
> > The rte_eth_stats_get is the only API that should call the device
> > statistics function directly, and it already does a memset of the
> > resulting structure. Therefore doing memset() in the driver is
> > r
> The link_status variable is not set when device is initialized.
> This can lead to problems with link never being reported as up
> if using some SFP modules where the link is instantly on.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Thomas Monjalon
Applied
Thanks
--
Thomas
> To follow up the comments from Wodkowski, PawelX, remove this unnecessary
> check,
> as check_mq_mode has already check the queue number in device configure stage,
> if the queue number of vf is not correct, it will return error code and exit,
> so it doesn't need check again here in device star
For ixgbe, when queue start failure, for example, mbuf allocate
failure, the device will still start success, which could be
an issue.
Add return status check of queue start to avoid this issue.
Signed-off-by: Michael Qiu
---
v2 --> v1
. remove duplicated error message in ixgbe_dev_rxtx_
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, January 27, 2015 11:30 AM
> To: Wang, Zhihong; Richardson, Bruce; Marc Sune
> Cc: dev at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 0/4] DPDK memcpy optimization
>
>
>
> > -Original Message-
> > From: Wang, Zhihon
Signed-off-by: Pawel Wodkowski
---
lib/librte_pmd_bond/rte_eth_bond_8023ad.h |8
lib/librte_pmd_bond/rte_eth_bond_8023ad_private.h |8
2 files changed, 16 insertions(+)
diff --git a/lib/librte_pmd_bond/rte_eth_bond_8023ad.h
b/lib/librte_pmd_bond/rte_eth_bond_80
Hi again John,
Thank you for the patient answers :-)
Thank you for pointing this out: I was mistakenly testing your Sandy Bridge
code on Haswell (lacking -DRTE_MACHINE_CPUFLAG_AVX2).
Correcting that, your code is both the fastest and the smallest in my
humble micro benchmarking tests.
Looks lik
On Tue, Jan 20, 2015 at 06:40:49PM +, Konstantin Ananyev wrote:
> v3 changes:
> Applied review comments from Thomas:
> - fix spelling errors reported by codespell.
> - split last patch into two:
> first to remove unused macros,
> second to add some comments about ACL internal layout.
>
Hi Xie,
I would be interested in alpha testing the vhost user patchset.
Is there an up to date example of how to use it ?
Best regards
Beno?t
2015-01-27 20:16, Michael Qiu:
> For ixgbe, when queue start failure, for example, mbuf allocate
> failure, the device will still start success, which could be
> an issue.
>
> Add return status check of queue start to avoid this issue.
>
> Signed-off-by: Michael Qiu
> ---
> v2 --> v1
> . r
2015-01-27 12:00, Qiu, Michael:
> On 1/27/2015 6:02 PM, Thomas Monjalon wrote:
> > Hi Michael,
> >
> > I'm clearly not the maintainer of ixgbe, so I'd prefer someone else
> > reviewing this patch. However I have few comments.
>
> Thanks Thomas,
>
> I will send v2 with your comments.
>
> But who
In test_sched, we are missing NULL pointer checks after calls to create the
mempool and to allocate an mbuf. Add in these checks using TEST_ASSERT_NOT_NULL
macros.
Signed-off-by: Daniel Mrzyglod
---
app/test/test_sched.c | 23 ---
1 file changed, 12 insertions(+), 11 deletio
2015-01-27 15:17, Daniel Mrzyglod:
> In test_sched, we are missing NULL pointer checks after calls to create the
> mempool and to allocate an mbuf. Add in these checks using
> TEST_ASSERT_NOT_NULL macros.
You are adding checks *and* replacing VERIFY by TEST_ASSERT_NOT_NULL.
It would be better to
the vhost library relies on libfuse, and thats included when we do a normal
shared object build, but when we specify combined libs, its gets left out. Add
it back in
Signed-off-by: Neil Horman
---
Change notes:
v2) Removed normal shared object inclusion of libfuse since its always included
now
2015-01-27 15:17, Daniel Mrzyglod:
> In test_sched, we are missing NULL pointer checks after calls to create the
> mempool and to allocate an mbuf. Add in these checks using
> TEST_ASSERT_NOT_NULL macros.
>
> Signed-off-by: Daniel Mrzyglod
[...]
> + TEST_ASSERT_NOT_NULL(mp, "Error create mem
Hi Olivier,
> -Original Message-
> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> Sent: Tuesday, January 27, 2015 8:34 AM
> To: Ananyev, Konstantin; Liu, Jijiang; Zhang, Helin
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 0/3] enhance TX checksum command and csum
> fo
In test_sched, we are missing NULL pointer checks after create_mempool()
and rte_pktmbuf_alloc(). Add in these checks using TEST_ASSERT_NOT_NULL macros.
VERIFY macro was removed and replaced by standard test ASSERTS from "test.h"
header.
This provides additional information to track when the fail
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Tuesday, January 27, 2015 11:33 AM
> To: Jastrzebski, MichalX K
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] testpmd: check return value of
> rte_eth_dev_vlan_filter()
>
> Hi Michal,
>
>
2015-01-27 09:39, Neil Horman:
> the vhost library relies on libfuse, and thats included when we do a normal
> shared object build, but when we specify combined libs, its gets left out.
> Add
> it back in
>
> Signed-off-by: Neil Horman
>
> ---
> Change notes:
> v2) Removed normal shared object
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Tuesday, January 27, 2015 5:59 PM
> To: Xie, Huawei
> Cc: Ouyang, Changchun; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 02/24] virtio: Use weaker barriers
>
>
> > I recall our original
> On Tue, Jan 27, 2015 at 10:51 AM, Alexander Belyakov
> mailto:abelyako at gmail.com>> wrote:
>
> Hi Pablo,
>
> On Mon, Jan 26, 2015 at 5:22 PM, De Lara Guarch, Pablo
> mailto:pablo.de.lara.guarch at intel.com>>
> wrote:
> Hi Alexander,
>
> > -Original Message-
> > From: dev [
> -Original Message-
> From: Beno?t Canet [mailto:benoit.canet at irqsave.net]
> Sent: Tuesday, January 27, 2015 10:11 PM
> To: Xie, Huawei; dev at dpdk.org
> Subject: vhost user examples
>
>
> Hi Xie,
>
> I would be interested in alpha testing the vhost user patchset.
>
> Is there an
The Tuesday 27 Jan 2015 ? 16:33:19 (+), Xie, Huawei wrote :
>
> > -Original Message-
> > From: Beno?t Canet [mailto:benoit.canet at irqsave.net]
> > Sent: Tuesday, January 27, 2015 10:11 PM
> > To: Xie, Huawei; dev at dpdk.org
> > Subject: vhost user examples
> >
> >
> > Hi Xie,
> >
> -Original Message-
> From: Beno?t Canet [mailto:benoit.canet at irqsave.net]
> Sent: Wednesday, January 28, 2015 1:00 AM
> To: Xie, Huawei
> Cc: Beno?t Canet; dev at dpdk.org
> Subject: Re: vhost user examples
>
> The Tuesday 27 Jan 2015 ? 16:33:19 (+), Xie, Huawei wrote :
> >
> >
The Tuesday 27 Jan 2015 ? 17:10:29 (+), Xie, Huawei wrote :
>
>
> > -Original Message-
> > From: Beno?t Canet [mailto:benoit.canet at irqsave.net]
> > Sent: Wednesday, January 28, 2015 1:00 AM
> > To: Xie, Huawei
> > Cc: Beno?t Canet; dev at dpdk.org
> > Subject: Re: vhost user exampl
This patch modifies testpmd behavior when setting:
rx_vlan add all vf_port (enabling all vlanids
to be passed thru rx filter on VF).
Rx_vlan_all_filter_set() function,
checks if the next vlanid can be enabled by the driver.
Number of vlanids is limited by the NIC and thus the NIC
do not allow to en
On Tue, Jan 27, 2015 at 04:44:53PM +0100, Daniel Mrzyglod wrote:
> In test_sched, we are missing NULL pointer checks after create_mempool()
> and rte_pktmbuf_alloc(). Add in these checks using TEST_ASSERT_NOT_NULL
> macros.
>
> VERIFY macro was removed and replaced by standard test ASSERTS from "
On Tue, Jan 27, 2015 at 10:02:24AM +, Stephen Hemminger wrote:
> On Mon, 26 Jan 2015 19:06:12 -0800
> Matthew Hall wrote:
>
> > Thank you so much for this, using virtio drivers in DPDK has been messy and
> > unpleasant in the past, and you clearly wrote a lot of nice new code to
> > help
>
Hi all,
I'm using dpdk 1.8 and pktgen-dpdk 2.8 to generate traffic on a back-to-back
setup both equipped with 82599EB 10-Gigabit NIC.
The problem is when I start it, pktgen indicates 1Mbits/s Tx with 64B
packet size, but I'm receiving about 15% of it on the other end.
This percentage s
Hello,
Currently using raw sockets with pf_packet, i would like to be able to send
scattered data to nic from different mmap files.
I use writev() right now, but what does dpdk suggest as an alternative?
Thanks
2015-01-27 15:58, Jastrzebski, MichalX K:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > And more importantly, you make it clear that sometimes we cannot enable
> > all vlans and return no error.
>
> Should I return this error somewhere? Isn't just printing the error best
> opt
Is there a way to control what ethernet port gets mapped to each port_id in
DPDK?
>From what I've seen, it looks like the port_id values just get assigned
based on the order they come back in the PCI probe/scan. Ideally, I'd like
to have the port_id values map reasonably directly to the customer-f
On Tue, Jan 27, 2015 at 03:57:13PM +0800, Linhaifeng wrote:
> Hi,all
>
> I use vhost-user to send data to VM at first it cant work well but after many
> hours VM can not receive data but can send data.
>
> (gdb)p avail_idx
> $4 = 2668
> (gdb)p free_entries
> $5 = 0
> (gdb)l
> /* check th
98 matches
Mail list logo
