[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled

2014-10-02 Thread Tetsuya Mukawa
(2014/10/01 19:50), Neil Horman wrote: > I'm not sure why thats necesecary. We add a --start-group/--end-group pair > halfway through this makefile. If we just encompassed the entire set of > libraries in that group, order would be irrelevant. I haven't known the options. Thanks. Anyway, I unders

[dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in recv/xmit

2014-10-02 Thread Hiroshi Shimamoto
> Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > recv/xmit > > On Wed, Oct 01, 2014 at 11:33:23PM +, Hiroshi Shimamoto wrote: > > > Subject: Re: [dpdk-dev] [memnic PATCH v2 6/7] pmd: add branch hint in > > > recv/xmit > > > > > > On Wed, Oct 01, 2014 at 09:12:44AM +0

[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled

2014-10-02 Thread Tetsuya Mukawa
(2014/10/01 20:56), Thomas Monjalon wrote: > 2014-10-01 06:50, Neil Horman: >> On Wed, Oct 01, 2014 at 01:27:03PM +0900, mukawa at igel.co.jp wrote: >>> When CONFIG_RTE_BUILD_SHARED_LIB is enabled, linking errors occured >>> while compiling. It seems those errors are caused by wrong link order >>>

[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled

2014-10-02 Thread Tetsuya Mukawa
(2014/10/02 11:46), Matthew Hall wrote: > On Thu, Oct 02, 2014 at 10:43:52AM +0900, Tetsuya Mukawa wrote: > It's worth pointing out that you're likely better off using > COMBINE_LIBS to make one big static lib rather than using a shared lib > or you're facing a performance loss from the dynamic lin

[dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer.

2014-10-02 Thread Thomas Monjalon
2014-10-01 17:05, Bruce Richardson: > On Wed, Oct 01, 2014 at 12:01:10PM -0400, Neil Horman wrote: > > On Wed, Oct 01, 2014 at 04:43:10PM +0100, Bruce Richardson wrote: > > > On Wed, Oct 01, 2014 at 11:02:27AM -0400, Neil Horman wrote: > > > > On Wed, Oct 01, 2014 at 03:36:45PM +0200, Thomas Monjal

[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled

2014-10-02 Thread Sergio Gonzalez Monroy
On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: > (2014/10/01 20:56), Thomas Monjalon wrote: > > 2014-10-01 06:50, Neil Horman: > >> On Wed, Oct 01, 2014 at 01:27:03PM +0900, mukawa at igel.co.jp wrote: > >>> When CONFIG_RTE_BUILD_SHARED_LIB is enabled, linking errors occured > >>>

[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled

2014-10-02 Thread Tetsuya Mukawa
(2014/10/02 17:12), Sergio Gonzalez Monroy wrote: > On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: > >> $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE >> -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MACHINE_CPUFLAG_SSE3 >> -DRTE_MACHINE_CPUFLAG_SSSE3 -DRTE_MACHINE_CPUFLAG_SS

[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled

2014-10-02 Thread Sergio Gonzalez Monroy
On Thu, Oct 02, 2014 at 05:28:04PM +0900, Tetsuya Mukawa wrote: > (2014/10/02 17:12), Sergio Gonzalez Monroy wrote: > > On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: > > > >> $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE_CPUFLAG_SSE > >> -DRTE_MACHINE_CPUFLAG_SSE2 -DRTE_MA

[dpdk-dev] [PATCH v3] distributor_app: new sample app

2014-10-02 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, October 01, 2014 4:38 PM > To: Neil Horman > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] distributor_app: new sample app > > On Wed, Oct 01, 2014 at 10:56:20AM

[dpdk-dev] [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled

2014-10-02 Thread Tetsuya Mukawa
(2014/10/02 17:53), Sergio Gonzalez Monroy wrote: > On Thu, Oct 02, 2014 at 05:28:04PM +0900, Tetsuya Mukawa wrote: >> (2014/10/02 17:12), Sergio Gonzalez Monroy wrote: >>> On Thu, Oct 02, 2014 at 11:48:37AM +0900, Tetsuya Mukawa wrote: >>> $ gcc -m64 -pthread -fPIC -march=native -DRTE_MACHINE

[dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration

2014-10-02 Thread David Marchand
On Wed, Oct 1, 2014 at 11:54 AM, De Lara Guarch, Pablo < pablo.de.lara.guarch at intel.com> wrote: > > > > -Original Message- > > From: De Lara Guarch, Pablo > > Sent: Wednesday, October 01, 2014 10:49 AM > > To: dev at dpdk.org > > Cc: De Lara Guarch, Pablo > > Subject: [PATCH v3 0/3] Get

[dpdk-dev] [PATCH v2] rte_mempool_dump() crashes with NULL rte_mempool pointer.

2014-10-02 Thread Neil Horman
On Thu, Oct 02, 2014 at 09:47:19AM +0200, Thomas Monjalon wrote: > 2014-10-01 17:05, Bruce Richardson: > > On Wed, Oct 01, 2014 at 12:01:10PM -0400, Neil Horman wrote: > > > On Wed, Oct 01, 2014 at 04:43:10PM +0100, Bruce Richardson wrote: > > > > On Wed, Oct 01, 2014 at 11:02:27AM -0400, Neil Horm

[dpdk-dev] [dpdk-announce] patchwork available

2014-10-02 Thread Thomas Monjalon
Hi all, A tool is now available to check state of the patches: http://dpdk.org/dev/patchwork It also helps to download patches for testing/review. Some explanations can be found in the dev page: http://dpdk.org/dev#patchwork Mails are automatically added to patchwork's database b

[dpdk-dev] [PATCH 1/4] Link combined shared library using CC

2014-10-02 Thread Sergio Gonzalez Monroy
It adds override definition of LD when linking using CC. Also it adds muldefs option to the linker when building shared libraries (same as building individual libraries). Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.sharelib.mk | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-)

[dpdk-dev] [PATCH 2/4] Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Sergio Gonzalez Monroy
When RTE_BUILD_COMBINE_LIBS=y is configured, there won't be individual shared libraries to copy over. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.lib.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk index f458258..d594692 100644 --- a/mk/rte.lib.mk +++

[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Sergio Gonzalez Monroy
When building DPDK with CONFIG_RTE_BUILD_COMBINE_LIBS=y, the result is not the expected behavior. - It does link the combine library using LD instead of CC which results in application linking errors. - It creates both individual libraries and combine library, then linking applications against

[dpdk-dev] [PATCH 3/4] Link apps only against combined lib or individual libs, not both

2014-10-02 Thread Sergio Gonzalez Monroy
Link only against combined library or individual libraries. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.app.mk | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/mk/rte.app.mk b/mk/rte.app.mk index 34dff2a..6f752dd 100644 --- a/mk/rte.app.mk +++ b/mk/rte.app.m

[dpdk-dev] [PATCH 4/4] Cleanup

2014-10-02 Thread Sergio Gonzalez Monroy
Reduce code duplication. This patch is not required for the patch set to work. Signed-off-by: Sergio Gonzalez Monroy --- mk/rte.lib.mk | 88 +- mk/rte.sharelib.mk | 39 ++-- 2 files changed, 35 insertions(+), 92 deletio

[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Neil Horman
On Thu, Oct 02, 2014 at 04:56:22PM +0100, Sergio Gonzalez Monroy wrote: > When building DPDK with CONFIG_RTE_BUILD_COMBINE_LIBS=y, the result is not > the expected behavior. > > - It does link the combine library using LD instead of CC which results > in application linking errors. > > - It cr

[dpdk-dev] [PATCH 2/4] Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Matthew Hall
On Thu, Oct 02, 2014 at 04:56:24PM +0100, Sergio Gonzalez Monroy wrote: > When RTE_BUILD_COMBINE_LIBS=y is configured, there won't be individual shared > libraries to copy over. As a user of RTE_BUILD_COMBINE_LIBS, disabling the ability to use the individual libs after the option is enabled is no

[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Matthew Hall
On Thu, Oct 02, 2014 at 01:26:34PM -0400, Neil Horman wrote: > Just out of curiosity, whats the impetus behind a single shared library here? > Is it just to ease application linking operations? If so, it almost seems to > me > that we should abandon the individual linking method and just use this

[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Neil Horman
On Thu, Oct 02, 2014 at 01:04:20PM -0700, Matthew Hall wrote: > On Thu, Oct 02, 2014 at 01:26:34PM -0400, Neil Horman wrote: > > Just out of curiosity, whats the impetus behind a single shared library > > here? > > Is it just to ease application linking operations? If so, it almost seems > > to

[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Matthew Hall
On Thu, Oct 02, 2014 at 04:24:51PM -0400, Neil Horman wrote: > This seems somewhat irrelevant to the patch. The default configuration is > already the way you want it to be, shared library performance is actually very > close to static performance, and yes, people can choose how they want to > bu

[dpdk-dev] [PATCH v3] Clang compile error with RTE_LIBRTE_MEMPOOL_DEBUG enabled.

2014-10-02 Thread Wiles, Roger Keith
Resend as it is missing in patchwork. When enabling RTE_LIBRTE_MEMPOOL_DEBUG and compiling with clang compiler an error occurs, because ifdefed code now includes GCC pragmas. GCC 4.4 is when push_options and pop_options pragma show up. Rework to include Thomas?s suggestion to drop push/pop pragm

[dpdk-dev] [PATCH 0/4] Fix build issues with CONFIG_RTE_BUILD_COMBINE_LIBS=y

2014-10-02 Thread Neil Horman
On Thu, Oct 02, 2014 at 02:10:55PM -0700, Matthew Hall wrote: > On Thu, Oct 02, 2014 at 04:24:51PM -0400, Neil Horman wrote: > > This seems somewhat irrelevant to the patch. The default configuration is > > already the way you want it to be, shared library performance is actually > > very > > clo