Re: net/virtio: duplicated xstats

2023-11-27 Thread Ferruh Yigit
On 11/27/2023 10:19 AM, Ferruh Yigit wrote: > On 11/24/2023 9:18 AM, Edwin Brossette wrote: >> Hello, >> >> I noticed a small inconsistency in the virtio pmd's xstats. >> The stat "rx_q0_errors" appears twice. >> I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" >> and "tx_q0_b

Re: net/virtio: duplicated xstats

2023-11-27 Thread Ferruh Yigit
On 11/24/2023 9:18 AM, Edwin Brossette wrote: > Hello, > > I noticed a small inconsistency in the virtio pmd's xstats. > The stat "rx_q0_errors" appears twice. > I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" > and "tx_q0_bytes" are duplicates of "rx_q0_good_packets", > "rx

Re: net/virtio: duplicated xstats

2023-11-24 Thread Maxime Coquelin
On 11/24/23 14:13, Edwin Brossette wrote: Hello again, The flag is already set during the device init, so it should be removed, not added. I can confirm removing it fixed my issue. I will submit a patch for this bug. g Great, thanks Edwin! Don't forget to add the Fixes: tag and cc sta..

Re: net/virtio: duplicated xstats

2023-11-24 Thread Edwin Brossette
Hello again, The flag is already set during the device init, so it should be removed, not added. I can confirm removing it fixed my issue. I will submit a patch for this bug. Regards, Edwin Brossette. On Fri, Nov 24, 2023 at 11:39 AM Maxime Coquelin wrote: > Hi Edwin, > > Thanks for reporting

Re: net/virtio: duplicated xstats

2023-11-24 Thread Maxime Coquelin
Hi Edwin, Thanks for reporting the issue. On 11/24/23 10:26, Olivier Matz wrote: Fix Maxime's mail. Thanks Olivier. On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote: Hello, I noticed a small inconsistency in the virtio pmd's xstats. The stat "rx_q0_errors" appears twice. I

Re: net/virtio: duplicated xstats

2023-11-24 Thread Olivier Matz
Fix Maxime's mail. On Fri, Nov 24, 2023 at 10:18:27AM +0100, Edwin Brossette wrote: > Hello, > > I noticed a small inconsistency in the virtio pmd's xstats. > The stat "rx_q0_errors" appears twice. > I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and > "tx_q0_bytes" are du

net/virtio: duplicated xstats

2023-11-24 Thread Edwin Brossette
Hello, I noticed a small inconsistency in the virtio pmd's xstats. The stat "rx_q0_errors" appears twice. I also think the stats "rx_q0_packets", "rx_q0_bytes", "tx_q0_packets" and "tx_q0_bytes" are duplicates of "rx_q0_good_packets", "rx_q0_good_bytes", "tx_q0_good_packets" and "tx_q0_good_bytes"