Re: ethdev: hide internal structures

2021-11-17 Thread Tyler Retzlaff
On Tue, Nov 16, 2021 at 03:22:01PM -0800, Stephen Hemminger wrote: > On Tue, 16 Nov 2021 14:58:08 -0800 > Tyler Retzlaff wrote: > > > > > > > Keep a array in application? Portid is universally > > > available. > > > > > > struct my_portdata *my_ports[RTE_ETH_MAXPORTS]; > > > > i guess by th

Re: ethdev: hide internal structures

2021-11-16 Thread Stephen Hemminger
On Tue, 16 Nov 2021 14:58:08 -0800 Tyler Retzlaff wrote: > On Tue, Nov 16, 2021 at 01:25:10PM -0800, Stephen Hemminger wrote: > > On Tue, 16 Nov 2021 11:10:18 -0800 > > Tyler Retzlaff wrote: > > > > > On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > > > > > > > rte

Re: ethdev: hide internal structures

2021-11-16 Thread Tyler Retzlaff
On Tue, Nov 16, 2021 at 01:25:10PM -0800, Stephen Hemminger wrote: > On Tue, 16 Nov 2021 11:10:18 -0800 > Tyler Retzlaff wrote: > > > On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > > > > > rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal > > > data st

Re: ethdev: hide internal structures

2021-11-16 Thread Stephen Hemminger
On Tue, 16 Nov 2021 11:10:18 -0800 Tyler Retzlaff wrote: > On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > > > rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal > > data structures that were used by public inline ethdev functions. > > Well behaving app

Re: ethdev: hide internal structures

2021-11-16 Thread Tyler Retzlaff
On Tue, Nov 16, 2021 at 08:07:49PM +, Ferruh Yigit wrote: > On 11/16/2021 5:54 PM, Tyler Retzlaff wrote: > > > >i thought someone was responsible for reviewing abi/api related changes > >on the board to understand the implications of changes like this? > > > > Sorry for the negative impact on

Re: ethdev: hide internal structures

2021-11-16 Thread Ferruh Yigit
On 11/16/2021 5:54 PM, Tyler Retzlaff wrote: On Tue, Nov 16, 2021 at 09:32:15AM +, Ferruh Yigit wrote: Hi Tyler, It shouldn't be an API change, which API is changed? exported declarations that were consumed by the application were removed from an installed header. anything making referen

Re: ethdev: hide internal structures

2021-11-16 Thread Tyler Retzlaff
On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal > data structures that were used by public inline ethdev functions. > Well behaving app should not access these data structures directly. > So, for well beh

Re: ethdev: hide internal structures

2021-11-16 Thread Tyler Retzlaff
On Tue, Nov 16, 2021 at 09:32:15AM +, Ferruh Yigit wrote: > > Hi Tyler, > > It shouldn't be an API change, which API is changed? exported declarations that were consumed by the application were removed from an installed header. anything making reference to rte_eth_devices[] will no longer co

RE: ethdev: hide internal structures

2021-11-16 Thread Ananyev, Konstantin
> hi folks, > > I don't understand the text of this change. would you mind explaining? > > commit f9bdee267ab84fd12dc288419aba341310b6ae08 > Author: Konstantin Ananyev > Date: Wed Oct 13 14:37:04 2021 +0100 > ethdev: hide internal structures > > +* ethdev: Made ``rte_eth_dev`

Re: ethdev: hide internal structures

2021-11-16 Thread Ferruh Yigit
On 11/16/2021 12:24 AM, Tyler Retzlaff wrote: hi folks, I don't understand the text of this change. would you mind explaining? commit f9bdee267ab84fd12dc288419aba341310b6ae08 Author: Konstantin Ananyev Date: Wed Oct 13 14:37:04 2021 +0100 ethdev: hide internal structures