Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object

2021-09-07 Thread Stephen Hemminger
On Tue, 24 Aug 2021 01:10:15 +0530 wrote: > + uint64_t rsvd[2]; > + /**< Reserved fields for future use. */ Did you check that these are 0 in current code? No. then they can't be safely used in the future.

Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object

2021-08-24 Thread Stephen Hemminger
On Tue, 24 Aug 2021 01:10:15 +0530 wrote: > From: Pavan Nikhilesh > > Reserve fields in rte_event_timer data structure to address future > use cases. > Also, remove volatile from rte_event_timer. > > Signed-off-by: Pavan Nikhilesh Reserve fields are not a good idea. They don't solve future A

Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object

2021-08-23 Thread Pavan Nikhilesh Bhagavatula
Hi Erik, >Hi Pavan, > >One comment in-line: > >> -Original Message- >> From: pbhagavat...@marvell.com >> Sent: Monday, August 23, 2021 2:40 PM >> To: jer...@marvell.com; Carrillo, Erik G >> Cc: Ananyev, Konstantin ; >dev@dpdk.org; >> Pavan Nikhilesh >> Subject: [dpdk-dev] [RFC 11/15] ev

Re: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object

2021-08-23 Thread Carrillo, Erik G
Hi Pavan, One comment in-line: > -Original Message- > From: pbhagavat...@marvell.com > Sent: Monday, August 23, 2021 2:40 PM > To: jer...@marvell.com; Carrillo, Erik G > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Pavan Nikhilesh > Subject: [dpdk-dev] [RFC 11/15] eventdev: reserve fields