Hi Pavan,
One comment in-line:
> -----Original Message-----
> From: pbhagavat...@marvell.com <pbhagavat...@marvell.com>
> Sent: Monday, August 23, 2021 2:40 PM
> To: jer...@marvell.com; Carrillo, Erik G <erik.g.carri...@intel.com>
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; dev@dpdk.org;
> Pavan Nikhilesh <pbhagavat...@marvell.com>
> Subject: [dpdk-dev] [RFC 11/15] eventdev: reserve fields in timer object
>
> From: Pavan Nikhilesh <pbhagavat...@marvell.com>
>
> Reserve fields in rte_event_timer data structure to address future use cases.
> Also, remove volatile from rte_event_timer.
>
> Signed-off-by: Pavan Nikhilesh <pbhagavat...@marvell.com>
> ---
> lib/eventdev/rte_event_timer_adapter.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/eventdev/rte_event_timer_adapter.h
> b/lib/eventdev/rte_event_timer_adapter.h
> index cad6d3b4c5..9499460a61 100644
> --- a/lib/eventdev/rte_event_timer_adapter.h
> +++ b/lib/eventdev/rte_event_timer_adapter.h
> @@ -475,7 +475,7 @@ struct rte_event_timer {
> * - op: RTE_EVENT_OP_NEW
> * - event_type: RTE_EVENT_TYPE_TIMER
> */
> - volatile enum rte_event_timer_state state;
> + enum rte_event_timer_state state;
> /**< State of the event timer. */
> uint64_t timeout_ticks;
> /**< Expiry timer ticks expressed in number of *timer_ticks_ns*
> from @@ -492,6 +492,8 @@ struct rte_event_timer {
> /**< Memory to store user specific metadata.
> * The event timer adapter implementation should not modify this
> area.
> */
> + uint64_t rsvd[2];
> + /**< Reserved fields for future use. */
This placement puts rsvd after the user_meta field, which should be last since
it is a zero-length array. Am I missing something?
Thanks,
Erik
> } __rte_cache_aligned;
>
> typedef uint16_t (*rte_event_timer_arm_burst_t)(
> --
> 2.17.1
