Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port

2017-04-20 Thread Zhao1, Wei
Hi, Thomas > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, April 21, 2017 5:12 AM > To: Zhao1, Wei ; Lu, Wenzhuo > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on > port &g

Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port

2017-04-20 Thread Thomas Monjalon
10/04/2017 05:02, Wei Zhao: > + memset(dev->data->dev_private, 0, > +(uint64_t)&adapter->reset_flag - (uint64_t)adapter); It does not compile for 32-bit. Should it be replaced by offsetof()? Does it mean that new fields should be added before reset_flag? There is no comment about

Re: [dpdk-dev] [PATCH v7 2/3] net/i40e: implement device reset on port

2017-04-20 Thread Thomas Monjalon
10/04/2017 05:02, Wei Zhao: > + if (adapter->reset_store_data == NULL) { > + PMD_INIT_LOG(ERR, "Failed to allocate %ld bytes needed to" > + " to store data when reset vf", > + sizeof(struct i40e_vf_reset_store)); Compilation f