10/04/2017 05:02, Wei Zhao: > + memset(dev->data->dev_private, 0, > + (uint64_t)&adapter->reset_flag - (uint64_t)adapter);
It does not compile for 32-bit. Should it be replaced by offsetof()? Does it mean that new fields should be added before reset_flag? There is no comment about position importance of this field in the struct. By the way, there is a field ptype_tbl appeared recently. Where should it be positionned after rebase?